OpenGitLink
/
yudao-cloud
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

商品品牛排和规格，代码 REVIEW

This commit is contained in:
YunaiV 2020-05-11 21:55:53 +08:00
parent b45739d151
commit a8bc6754c2
4 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
product/product-biz/src/main/java/cn/iocoder/mall/product/biz/dao/product/ProductBrandMapper.java
View File

@ -13,6 +13,7 @@ import org.springframework.stereotype.Repository;
@Repository
public interface ProductBrandMapper extends BaseMapper<ProductBrandDO> {
// TODO FROM 芋艿 to q2118cs：selectPageByParams
default IPage<ProductBrandDO> selectListByParams(ProductBrandPageDTO productBrandPageDTO) {
Page<ProductBrandDO> page = new Page<>(productBrandPageDTO.getPageNo(), productBrandPageDTO.getPageSize());
LambdaQueryWrapper<ProductBrandDO> queryWrapper = Wrappers.<ProductBrandDO>query().lambda()
@ -22,4 +23,4 @@ public interface ProductBrandMapper extends BaseMapper<ProductBrandDO> {
.eq(ProductBrandDO::getDeleted, false);
return selectPage(page, queryWrapper);
}
}
}

4
product/product-rest/src/main/java/cn/iocoder/mall/product/rest/controller/admins/AdminsProductBrandController.java
View File

@ -24,9 +24,10 @@ import static cn.iocoder.common.framework.vo.CommonResult.success;
@RestController
@RequestMapping("admins/brand")
@Api("商品品牌")
@Api("商品品牌") // TODO FROM 芋艿 to q2118cs：管理员 - 商品品牌 API。。哈哈哈，原来没规范
public class AdminsProductBrandController {
// TODO FROM 芋艿 to q2118cs：貌似没注入哈
private ProductBrandService productBrandService;
@PostMapping("/add")
@ -49,6 +50,7 @@ public class AdminsProductBrandController {
@ApiImplicitParam(name = "picUrl", value = "品牌图片", required = true, example = "http://www.iocoder.cn"),
@ApiImplicitParam(name = "status", value = "状态 1开启 2禁用", required = true, example = "1")
})
// TODO FROM 芋艿 to q2118cs：只要改成了 bean 接收，就不用在写 @ApiImplicitParam 注解啦，直接在 bean 里写就 ok 啦
public CommonResult<Boolean> update(@Validated ProductBrandUpdateRequest updateRequest) {
// 创建 productBrandUpdateDTO 对象
ProductBrandUpdateDTO productBrandUpdateDTO = ProductBrandConvert.INSTANCE.convertUpdate(updateRequest);

1
product/product-rest/src/main/java/cn/iocoder/mall/product/rest/controller/users/UserFavoriteController.java
View File

@ -13,6 +13,7 @@ import org.springframework.web.bind.annotation.RestController;
@RestController
@RequestMapping("users/favorite")
@Api("用户收藏")
// TODO FROM 芋艿 to ilnhj：controller 分包的话，还是按照模块。然后通过 Admins 和 Users 前缀，区分不同的 Controlller
public class UserFavoriteController {
}

1
user/user-biz/src/main/java/cn/iocoder/mall/user/biz/enums/UserErrorCodeEnum.java
View File

@ -15,6 +15,7 @@ public enum UserErrorCodeEnum implements ServiceExceptionUtil.Enumerable {
USER_GET_ADDRESS_NOT_EXISTS(1001004002, "获取的地址不存在!"),
// ========== 用户 ==========
// TODO FROM 芋艿 to linhj：是不是提示不对呀
USER_NOT_EXISTS(1001004003, "获取的地址不存在!"),
;