From 162e2657b80d3fffb57c1cee9d12eedbdca9d5fa Mon Sep 17 00:00:00 2001 From: Maurice van der Pot Date: Sat, 15 Jul 2017 17:13:27 +0200 Subject: [PATCH 1/2] Fix two issues found by coverity --- runtime/Cpp/runtime/src/atn/LexerActionExecutor.cpp | 2 +- runtime/Cpp/runtime/src/misc/IntervalSet.cpp | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/runtime/Cpp/runtime/src/atn/LexerActionExecutor.cpp b/runtime/Cpp/runtime/src/atn/LexerActionExecutor.cpp index c9c32f074..1ae510f75 100755 --- a/runtime/Cpp/runtime/src/atn/LexerActionExecutor.cpp +++ b/runtime/Cpp/runtime/src/atn/LexerActionExecutor.cpp @@ -101,7 +101,7 @@ size_t LexerActionExecutor::generateHashCode() const { for (auto lexerAction : _lexerActions) { hash = MurmurHash::update(hash, lexerAction); } - MurmurHash::finish(hash, _lexerActions.size()); + hash = MurmurHash::finish(hash, _lexerActions.size()); return hash; } diff --git a/runtime/Cpp/runtime/src/misc/IntervalSet.cpp b/runtime/Cpp/runtime/src/misc/IntervalSet.cpp index ab4d240cc..b76409405 100755 --- a/runtime/Cpp/runtime/src/misc/IntervalSet.cpp +++ b/runtime/Cpp/runtime/src/misc/IntervalSet.cpp @@ -44,6 +44,8 @@ IntervalSet::IntervalSet(int n, ...) : IntervalSet() { for (int i = 0; i < n; i++) { add(va_arg(vlist, int)); } + + va_end(vlist); } IntervalSet::~IntervalSet() From 73c17ffbd2eea4f9e75b29967d838b0b3fe3b9cd Mon Sep 17 00:00:00 2001 From: Maurice van der Pot Date: Fri, 27 Oct 2017 19:42:26 +0200 Subject: [PATCH 2/2] Updated contributors.txt --- contributors.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contributors.txt b/contributors.txt index 63d6d57f5..21a3c0cdb 100644 --- a/contributors.txt +++ b/contributors.txt @@ -150,4 +150,5 @@ YYYY/MM/DD, github id, Full name, email 2017/05/29, kosak, Corey Kosak, kosak@kosak.com 2017/06/11, erikbra, Erik A. Brandstadmoen, erik@brandstadmoen.net 2017/06/10, jm-mikkelsen, Jan Martin Mikkelsen, janm@transactionware.com -2017/06/25, alimg, Alim Gökkaya, alim.gokkaya@gmail.com \ No newline at end of file +2017/06/25, alimg, Alim Gökkaya, alim.gokkaya@gmail.com +2017/10/27, Griffon26, Maurice van der Pot, griffon26@kfk4ever.com