From 8013bb868c5270a135f1701c49903d9e516e50fc Mon Sep 17 00:00:00 2001
From: Terence Parr <parrt@antlr.org>
Date: Wed, 15 Feb 2012 18:28:34 -0800
Subject: [PATCH 1/8] stash; got lost of visitor stuff working

---
 .../antlr/v4/runtime/ParserRuleContext.java   |  4 +-
 .../v4/runtime/tree/ParseTreeVisitor.java     | 27 +++++++
 tool/playground/ABaseVisitor.java             | 11 +++
 tool/playground/AVisitor.java                 | 11 +++
 tool/playground/TestVisitor.java              | 79 +++++++++++++++++++
 .../v4/tool/templates/codegen/Java/Java.stg   |  2 +
 6 files changed, 133 insertions(+), 1 deletion(-)
 create mode 100644 runtime/Java/src/org/antlr/v4/runtime/tree/ParseTreeVisitor.java
 create mode 100644 tool/playground/ABaseVisitor.java
 create mode 100644 tool/playground/AVisitor.java
 create mode 100644 tool/playground/TestVisitor.java

diff --git a/runtime/Java/src/org/antlr/v4/runtime/ParserRuleContext.java b/runtime/Java/src/org/antlr/v4/runtime/ParserRuleContext.java
index 70dac3a32..ec112740e 100644
--- a/runtime/Java/src/org/antlr/v4/runtime/ParserRuleContext.java
+++ b/runtime/Java/src/org/antlr/v4/runtime/ParserRuleContext.java
@@ -34,6 +34,7 @@ import org.antlr.v4.runtime.misc.NotNull;
 import org.antlr.v4.runtime.misc.Nullable;
 import org.antlr.v4.runtime.tree.ParseTree;
 import org.antlr.v4.runtime.tree.ParseTreeListener;
+import org.antlr.v4.runtime.tree.ParseTreeVisitor;
 
 import java.util.ArrayList;
 import java.util.Collections;
@@ -131,10 +132,11 @@ public class ParserRuleContext<Symbol> extends RuleContext {
 		this(parent, parent!=null ? parent.s : -1 /* invoking state */, stateNumber);
 	}
 
-	// Double dispatch methods
+	// Double dispatch methods for listeners and visitors
 
 	public void enterRule(ParseTreeListener<Symbol> listener) { }
 	public void exitRule(ParseTreeListener<Symbol> listener) { }
+	public <T,V extends ParseTreeVisitor<T>> T dispatch(V visitor) { visitor.visitChildren(this); return null; }
 
 	/** Does not set parent link; other add methods do */
 	public void addChild(TerminalNode<Symbol> t) {
diff --git a/runtime/Java/src/org/antlr/v4/runtime/tree/ParseTreeVisitor.java b/runtime/Java/src/org/antlr/v4/runtime/tree/ParseTreeVisitor.java
new file mode 100644
index 000000000..9ad8eabae
--- /dev/null
+++ b/runtime/Java/src/org/antlr/v4/runtime/tree/ParseTreeVisitor.java
@@ -0,0 +1,27 @@
+package org.antlr.v4.runtime.tree;
+
+import org.antlr.v4.runtime.ParserRuleContext;
+import org.antlr.v4.runtime.Token;
+
+/** T is return type of visit methods. Use T=Void for no return type. */
+public class ParseTreeVisitor<T> {
+	public T visit(ParserRuleContext<?> ctx) {
+		return ctx.dispatch(this);
+	}
+
+	/** Visit all rule, nonleaf children */
+	public <Symbol> void visitChildren(ParserRuleContext<Symbol> ctx) {
+		for (ParseTree c : ctx.children) {
+			if ( c instanceof ParseTree.RuleNode) {
+				ParseTree.RuleNode r = (ParseTree.RuleNode)c;
+				ParserRuleContext<Symbol> rctx = (ParserRuleContext<Symbol>)r.getRuleContext();
+				rctx.dispatch(this);
+			}
+		}
+	}
+
+//  Don't need to visit tokens. each visit() method deals with it's leaf children
+//	public T visit(Token t) {
+//		return null;
+//	}
+}
diff --git a/tool/playground/ABaseVisitor.java b/tool/playground/ABaseVisitor.java
new file mode 100644
index 000000000..b20971e54
--- /dev/null
+++ b/tool/playground/ABaseVisitor.java
@@ -0,0 +1,11 @@
+import org.antlr.v4.runtime.Token;
+import org.antlr.v4.runtime.tree.ParseTreeVisitor;
+
+public class ABaseVisitor<T> extends ParseTreeVisitor<T> implements AVisitor<T> {
+	public T visit(AParser.MultContext ctx) { return null; }
+	public T visit(AParser.ParensContext ctx) { return null; }
+	public T visit(AParser.eContext ctx) { return null; }
+	public T visit(AParser.sContext ctx) { return null; }
+	public T visit(AParser.AddContext ctx) { return null; }
+	public T visit(AParser.IntContext ctx) { return null; }
+}
diff --git a/tool/playground/AVisitor.java b/tool/playground/AVisitor.java
new file mode 100644
index 000000000..5f0af723d
--- /dev/null
+++ b/tool/playground/AVisitor.java
@@ -0,0 +1,11 @@
+import org.antlr.v4.runtime.ParserRuleContext;
+import org.antlr.v4.runtime.Token;
+
+public interface AVisitor<T> {
+	T visit(AParser.MultContext ctx);
+	T visit(AParser.ParensContext ctx);
+	T visit(AParser.sContext ctx);
+	T visit(AParser.AddContext ctx);
+	T visit(AParser.IntContext ctx);
+//	T visit(Token t);
+}
diff --git a/tool/playground/TestVisitor.java b/tool/playground/TestVisitor.java
new file mode 100644
index 000000000..31fbabfd8
--- /dev/null
+++ b/tool/playground/TestVisitor.java
@@ -0,0 +1,79 @@
+/*
+ [The "BSD license"]
+ Copyright (c) 2011 Terence Parr
+ All rights reserved.
+
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions
+ are met:
+
+ 1. Redistributions of source code must retain the above copyright
+    notice, this list of conditions and the following disclaimer.
+ 2. Redistributions in binary form must reproduce the above copyright
+    notice, this list of conditions and the following disclaimer in the
+    documentation and/or other materials provided with the distribution.
+ 3. The name of the author may not be used to endorse or promote products
+    derived from this software without specific prior written permission.
+
+ THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
+ IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+ OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
+ IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
+ INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+ NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+import org.antlr.v4.runtime.ANTLRFileStream;
+import org.antlr.v4.runtime.CommonTokenStream;
+import org.antlr.v4.runtime.ParserRuleContext;
+import org.antlr.v4.runtime.Token;
+import org.antlr.v4.runtime.tree.ParseTreeVisitor;
+import org.antlr.v4.runtime.tree.ParseTreeWalker;
+
+public class TestVisitor {
+	public static class MyVisitor extends ParseTreeVisitor<Integer> implements AVisitor<Integer> {
+		@Override
+		public Integer visit(AParser.AddContext ctx) {
+			return ctx.e(0).dispatch(this) + ctx.e(1).dispatch(this);
+		}
+
+		@Override
+		public Integer visit(AParser.IntContext ctx) {
+			return Integer.valueOf(ctx.INT().getText());
+		}
+
+		@Override
+		public Integer visit(AParser.MultContext ctx) {
+			return ctx.e(0).dispatch(this) * ctx.e(1).dispatch(this);
+		}
+
+		@Override
+		public Integer visit(AParser.ParensContext ctx) {
+			return ctx.e().dispatch(this);
+		}
+
+		@Override
+		public Integer visit(AParser.sContext ctx) {
+			return ctx.e().dispatch(this);
+		}
+	}
+
+	public static void main(String[] args) throws Exception {
+		ALexer lexer = new ALexer(new ANTLRFileStream(args[0]));
+		CommonTokenStream tokens = new CommonTokenStream(lexer);
+		AParser p = new AParser(tokens);
+		p.setBuildParseTree(true);
+		ParserRuleContext<Token> t = p.s();
+		System.out.println("tree = "+t.toStringTree(p));
+
+		MyVisitor visitor = new MyVisitor();
+		Integer result = visitor.visit(t);
+//		Integer result = t.dispatch(visitor);
+		System.out.println("result from tree walk = " + result);
+	}
+}
+
diff --git a/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg b/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg
index 5c0d27bba..c7719732a 100644
--- a/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg
+++ b/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg
@@ -551,6 +551,7 @@ public static class <s.name> extends <superClass><if(interfaces)> implements <in
 	}
 <endif>
 	<visitorDispatchMethods; separator="\n">
+        public \<T, V extends <parser.grammarName>Visitor\<T>\> T dispatch(V visitor) { return visitor.visit(this); }
 	<extensionMembers; separator="\n">
 }
 >>
@@ -561,6 +562,7 @@ public static class <s.name> extends <currentRule.name>Context {
 	<getters:{g | <g>}; separator="\n">
 	public <s.name>(<currentRule.name>Context ctx) { copyFrom(ctx); }
 	<visitorDispatchMethods; separator="\n">
+        public \<T, V extends <parser.grammarName>Visitor\<T>\> T dispatch(V visitor) { return visitor.visit(this); }
 }
 >>
 

From baf62685ab1ade1bec904b53c5195ace9e30ded3 Mon Sep 17 00:00:00 2001
From: Terence Parr <parrt@antlr.org>
Date: Thu, 16 Feb 2012 10:27:56 -0800
Subject: [PATCH 2/8] snapshot

---
 .../antlr/v4/runtime/ParserRuleContext.java   |  2 +-
 tool/playground/AVisitor.java                 |  1 -
 tool/playground/TestVisitor.java              |  4 ++--
 .../v4/tool/templates/codegen/Java/Java.stg   | 20 ++++++++++++-------
 .../codegen/model/ListenerDispatchMethod.java | 20 +++++++++++++++++++
 .../v4/codegen/model/decl/StructDecl.java     | 10 +++++-----
 6 files changed, 41 insertions(+), 16 deletions(-)
 create mode 100644 tool/src/org/antlr/v4/codegen/model/ListenerDispatchMethod.java

diff --git a/runtime/Java/src/org/antlr/v4/runtime/ParserRuleContext.java b/runtime/Java/src/org/antlr/v4/runtime/ParserRuleContext.java
index ec112740e..531956ede 100644
--- a/runtime/Java/src/org/antlr/v4/runtime/ParserRuleContext.java
+++ b/runtime/Java/src/org/antlr/v4/runtime/ParserRuleContext.java
@@ -136,7 +136,7 @@ public class ParserRuleContext<Symbol> extends RuleContext {
 
 	public void enterRule(ParseTreeListener<Symbol> listener) { }
 	public void exitRule(ParseTreeListener<Symbol> listener) { }
-	public <T,V extends ParseTreeVisitor<T>> T dispatch(V visitor) { visitor.visitChildren(this); return null; }
+	public <T> T dispatch(ParseTreeVisitor<? extends T> visitor) { visitor.visitChildren(this); return null; }
 
 	/** Does not set parent link; other add methods do */
 	public void addChild(TerminalNode<Symbol> t) {
diff --git a/tool/playground/AVisitor.java b/tool/playground/AVisitor.java
index 5f0af723d..358bc5a0f 100644
--- a/tool/playground/AVisitor.java
+++ b/tool/playground/AVisitor.java
@@ -7,5 +7,4 @@ public interface AVisitor<T> {
 	T visit(AParser.sContext ctx);
 	T visit(AParser.AddContext ctx);
 	T visit(AParser.IntContext ctx);
-//	T visit(Token t);
 }
diff --git a/tool/playground/TestVisitor.java b/tool/playground/TestVisitor.java
index 31fbabfd8..8d39973de 100644
--- a/tool/playground/TestVisitor.java
+++ b/tool/playground/TestVisitor.java
@@ -48,7 +48,8 @@ public class TestVisitor {
 
 		@Override
 		public Integer visit(AParser.MultContext ctx) {
-			return ctx.e(0).dispatch(this) * ctx.e(1).dispatch(this);
+//			return ctx.e(0).dispatch(this) * ctx.e(1).dispatch(this);
+			return visit(ctx.e(0)) * visit(ctx.e(1));
 		}
 
 		@Override
@@ -76,4 +77,3 @@ public class TestVisitor {
 		System.out.println("result from tree walk = " + result);
 	}
 }
-
diff --git a/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg b/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg
index c7719732a..32fa834b3 100644
--- a/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg
+++ b/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg
@@ -533,7 +533,7 @@ ListLabelName(label)		  ::= "<label>"
 CaptureNextToken(d) ::= "<d.varName> = _input.LT(1);"
 CaptureNextTokenType(d) ::= "<d.varName> = _input.LA(1);"
 
-StructDecl(s,attrs,getters,visitorDispatchMethods,interfaces,extensionMembers,
+StructDecl(s,attrs,getters,dispatchMethods,interfaces,extensionMembers,
            superClass={ParserRuleContext\<<InputSymbolType()>>}) ::= <<
 public static class <s.name> extends <superClass><if(interfaces)> implements <interfaces; separator=", "><endif> {
 	<attrs:{a | <a>}; separator="\n">
@@ -550,29 +550,35 @@ public static class <s.name> extends <superClass><if(interfaces)> implements <in
 		<s.attrs:{a | this.<a.name> = ctx.<a.name>;}; separator="\n">
 	}
 <endif>
-	<visitorDispatchMethods; separator="\n">
-        public \<T, V extends <parser.grammarName>Visitor\<T>\> T dispatch(V visitor) { return visitor.visit(this); }
+	<dispatchMethods; separator="\n">
 	<extensionMembers; separator="\n">
 }
 >>
 
-AltLabelStructDecl(s,attrs,getters,visitorDispatchMethods) ::= <<
+AltLabelStructDecl(s,attrs,getters,dispatchMethods) ::= <<
 public static class <s.name> extends <currentRule.name>Context {
 	<attrs:{a | <a>}; separator="\n">
 	<getters:{g | <g>}; separator="\n">
 	public <s.name>(<currentRule.name>Context ctx) { copyFrom(ctx); }
-	<visitorDispatchMethods; separator="\n">
-        public \<T, V extends <parser.grammarName>Visitor\<T>\> T dispatch(V visitor) { return visitor.visit(this); }
+	<dispatchMethods; separator="\n">
 }
 >>
 
-VisitorDispatchMethod(method) ::= <<
+ListenerDispatchMethod(method) ::= <<
 @Override
 public void <if(method.isEnter)>enter<else>exit<endif>Rule(ParseTreeListener\<<InputSymbolType()>\> listener) {
 	if ( listener instanceof <parser.grammarName>Listener ) ((<parser.grammarName>Listener)listener).<if(method.isEnter)>enter<else>exit<endif>(this);
 }
 >>
 
+VisitorDispatchMethod() ::= <<
+@Override
+public \<T> T dispatch(ParseTreeVisitor\<? extends T> visitor) { 
+    if ( listener instanceof <parser.grammarName>Visitor ) return ((<parser.grammarName>Visitor\<T>)visitor).visit(this);
+    else return null;
+}
+>>
+
 AttributeDecl(d) ::= "public <d.decl>;"
 
 /** If we don't know location of label def x, use this template */
diff --git a/tool/src/org/antlr/v4/codegen/model/ListenerDispatchMethod.java b/tool/src/org/antlr/v4/codegen/model/ListenerDispatchMethod.java
new file mode 100644
index 000000000..5b241eb01
--- /dev/null
+++ b/tool/src/org/antlr/v4/codegen/model/ListenerDispatchMethod.java
@@ -0,0 +1,20 @@
+package org.antlr.v4.codegen.model;
+
+import org.antlr.v4.codegen.OutputModelFactory;
+import org.antlr.v4.misc.Triple;
+import org.antlr.v4.tool.Rule;
+import org.antlr.v4.tool.ast.AltAST;
+
+import java.util.List;
+
+public class ListenerDispatchMethod extends OutputModelObject {
+	public String listenerName = "Rule";
+	public boolean isEnter;
+
+	public ListenerDispatchMethod(OutputModelFactory factory, Rule r, boolean isEnter) {
+		super(factory);
+		this.isEnter = isEnter;
+		List<Triple<Integer,AltAST,String>> label = r.getAltLabels();
+		if ( label!=null ) listenerName = label.get(0).c;
+	}
+}
diff --git a/tool/src/org/antlr/v4/codegen/model/decl/StructDecl.java b/tool/src/org/antlr/v4/codegen/model/decl/StructDecl.java
index 4ecac29dc..afb9cbdeb 100644
--- a/tool/src/org/antlr/v4/codegen/model/decl/StructDecl.java
+++ b/tool/src/org/antlr/v4/codegen/model/decl/StructDecl.java
@@ -32,7 +32,7 @@ package org.antlr.v4.codegen.model.decl;
 import org.antlr.v4.codegen.OutputModelFactory;
 import org.antlr.v4.codegen.model.ModelElement;
 import org.antlr.v4.codegen.model.OutputModelObject;
-import org.antlr.v4.codegen.model.VisitorDispatchMethod;
+import org.antlr.v4.codegen.model.ListenerDispatchMethod;
 import org.antlr.v4.runtime.misc.OrderedHashSet;
 import org.antlr.v4.tool.Attribute;
 import org.antlr.v4.tool.Rule;
@@ -50,7 +50,7 @@ public class StructDecl extends Decl {
 	@ModelElement public OrderedHashSet<Decl> attrs = new OrderedHashSet<Decl>();
 	@ModelElement public OrderedHashSet<Decl> getters = new OrderedHashSet<Decl>();
 	@ModelElement public Collection<Attribute> ctorAttrs;
-	@ModelElement public List<VisitorDispatchMethod> visitorDispatchMethods;
+	@ModelElement public List<ListenerDispatchMethod> dispatchMethods;
 	@ModelElement public List<OutputModelObject> interfaces;
 	@ModelElement public List<OutputModelObject> extensionMembers;
 
@@ -61,9 +61,9 @@ public class StructDecl extends Decl {
 	}
 
 	public void addVisitorDispatchMethods(Rule r) {
-		visitorDispatchMethods = new ArrayList<VisitorDispatchMethod>();
-		visitorDispatchMethods.add(new VisitorDispatchMethod(factory, r, true));
-		visitorDispatchMethods.add(new VisitorDispatchMethod(factory, r, false));
+		dispatchMethods = new ArrayList<ListenerDispatchMethod>();
+		dispatchMethods.add(new ListenerDispatchMethod(factory, r, true));
+		dispatchMethods.add(new ListenerDispatchMethod(factory, r, false));
 	}
 
 	public void addDecl(Decl d) {

From 4a374dab602e58536d4b451fff260792ef2f5e40 Mon Sep 17 00:00:00 2001
From: Terence Parr <parrt@antlr.org>
Date: Thu, 16 Feb 2012 11:04:04 -0800
Subject: [PATCH 3/8] got visitors generated

---
 .../antlr/v4/runtime/ParserRuleContext.java   | 16 +++-----
 .../v4/runtime/tree/ParseTreeVisitor.java     | 10 +----
 tool/playground/AVisitor.java                 |  5 +--
 tool/playground/TestE.java                    |  2 +-
 tool/playground/TestVisitor.java              | 17 ++++----
 .../v4/tool/templates/codegen/Java/Java.stg   | 18 +++++++--
 .../org/antlr/v4/codegen/CodeGenPipeline.java |  1 +
 .../org/antlr/v4/codegen/CodeGenerator.java   | 39 +++++++++++++++----
 .../v4/codegen/OutputModelController.java     | 25 +++++-------
 .../v4/codegen/model/DispatchMethod.java      |  9 +++++
 .../codegen/model/ListenerDispatchMethod.java | 12 +-----
 .../codegen/model/VisitorDispatchMethod.java  | 15 +------
 .../antlr/v4/codegen/model/VisitorFile.java   | 37 ++++++++++++++++++
 .../model/decl/AltLabelStructDecl.java        |  7 ++++
 .../v4/codegen/model/decl/StructDecl.java     | 27 ++++++-------
 15 files changed, 142 insertions(+), 98 deletions(-)
 create mode 100644 tool/src/org/antlr/v4/codegen/model/DispatchMethod.java
 create mode 100644 tool/src/org/antlr/v4/codegen/model/VisitorFile.java

diff --git a/runtime/Java/src/org/antlr/v4/runtime/ParserRuleContext.java b/runtime/Java/src/org/antlr/v4/runtime/ParserRuleContext.java
index 531956ede..c3bdc8634 100644
--- a/runtime/Java/src/org/antlr/v4/runtime/ParserRuleContext.java
+++ b/runtime/Java/src/org/antlr/v4/runtime/ParserRuleContext.java
@@ -28,17 +28,11 @@
  */
 package org.antlr.v4.runtime;
 
-import org.antlr.v4.runtime.atn.ATN;
-import org.antlr.v4.runtime.atn.ATNState;
-import org.antlr.v4.runtime.misc.NotNull;
-import org.antlr.v4.runtime.misc.Nullable;
-import org.antlr.v4.runtime.tree.ParseTree;
-import org.antlr.v4.runtime.tree.ParseTreeListener;
-import org.antlr.v4.runtime.tree.ParseTreeVisitor;
+import org.antlr.v4.runtime.atn.*;
+import org.antlr.v4.runtime.misc.*;
+import org.antlr.v4.runtime.tree.*;
 
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.List;
+import java.util.*;
 
 /** A rule invocation record for parsing and tree parsing.
  *
@@ -136,7 +130,7 @@ public class ParserRuleContext<Symbol> extends RuleContext {
 
 	public void enterRule(ParseTreeListener<Symbol> listener) { }
 	public void exitRule(ParseTreeListener<Symbol> listener) { }
-	public <T> T dispatch(ParseTreeVisitor<? extends T> visitor) { visitor.visitChildren(this); return null; }
+	public <T> T accept(ParseTreeVisitor<? extends T> visitor) { visitor.visitChildren(this); return null; }
 
 	/** Does not set parent link; other add methods do */
 	public void addChild(TerminalNode<Symbol> t) {
diff --git a/runtime/Java/src/org/antlr/v4/runtime/tree/ParseTreeVisitor.java b/runtime/Java/src/org/antlr/v4/runtime/tree/ParseTreeVisitor.java
index 9ad8eabae..c77131a47 100644
--- a/runtime/Java/src/org/antlr/v4/runtime/tree/ParseTreeVisitor.java
+++ b/runtime/Java/src/org/antlr/v4/runtime/tree/ParseTreeVisitor.java
@@ -1,12 +1,11 @@
 package org.antlr.v4.runtime.tree;
 
 import org.antlr.v4.runtime.ParserRuleContext;
-import org.antlr.v4.runtime.Token;
 
 /** T is return type of visit methods. Use T=Void for no return type. */
 public class ParseTreeVisitor<T> {
 	public T visit(ParserRuleContext<?> ctx) {
-		return ctx.dispatch(this);
+		return ctx.accept(this);
 	}
 
 	/** Visit all rule, nonleaf children */
@@ -15,13 +14,8 @@ public class ParseTreeVisitor<T> {
 			if ( c instanceof ParseTree.RuleNode) {
 				ParseTree.RuleNode r = (ParseTree.RuleNode)c;
 				ParserRuleContext<Symbol> rctx = (ParserRuleContext<Symbol>)r.getRuleContext();
-				rctx.dispatch(this);
+				visit(rctx);
 			}
 		}
 	}
-
-//  Don't need to visit tokens. each visit() method deals with it's leaf children
-//	public T visit(Token t) {
-//		return null;
-//	}
 }
diff --git a/tool/playground/AVisitor.java b/tool/playground/AVisitor.java
index 358bc5a0f..5badbd275 100644
--- a/tool/playground/AVisitor.java
+++ b/tool/playground/AVisitor.java
@@ -1,10 +1,7 @@
-import org.antlr.v4.runtime.ParserRuleContext;
-import org.antlr.v4.runtime.Token;
-
 public interface AVisitor<T> {
 	T visit(AParser.MultContext ctx);
 	T visit(AParser.ParensContext ctx);
 	T visit(AParser.sContext ctx);
 	T visit(AParser.AddContext ctx);
 	T visit(AParser.IntContext ctx);
-}
+}
\ No newline at end of file
diff --git a/tool/playground/TestE.java b/tool/playground/TestE.java
index 02791e0c7..476cbb29f 100644
--- a/tool/playground/TestE.java
+++ b/tool/playground/TestE.java
@@ -3,7 +3,7 @@ import org.antlr.v4.runtime.*;
 public class TestE {
     public static void main(String[] args) throws Exception {
         CharStream input = new ANTLRFileStream(args[0]);
-        E lex = new E(input);
+        ELexer lex = new ELexer(input);
         CommonTokenStream tokens = new CommonTokenStream(lex);
         tokens.fill();
         for (Object t : tokens.getTokens()) System.out.println(t);
diff --git a/tool/playground/TestVisitor.java b/tool/playground/TestVisitor.java
index 8d39973de..734e6bc6a 100644
--- a/tool/playground/TestVisitor.java
+++ b/tool/playground/TestVisitor.java
@@ -27,18 +27,14 @@
  THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-import org.antlr.v4.runtime.ANTLRFileStream;
-import org.antlr.v4.runtime.CommonTokenStream;
-import org.antlr.v4.runtime.ParserRuleContext;
-import org.antlr.v4.runtime.Token;
+import org.antlr.v4.runtime.*;
 import org.antlr.v4.runtime.tree.ParseTreeVisitor;
-import org.antlr.v4.runtime.tree.ParseTreeWalker;
 
 public class TestVisitor {
 	public static class MyVisitor extends ParseTreeVisitor<Integer> implements AVisitor<Integer> {
 		@Override
 		public Integer visit(AParser.AddContext ctx) {
-			return ctx.e(0).dispatch(this) + ctx.e(1).dispatch(this);
+			return ctx.e(0).accept(this) + ctx.e(1).accept(this);
 		}
 
 		@Override
@@ -48,18 +44,19 @@ public class TestVisitor {
 
 		@Override
 		public Integer visit(AParser.MultContext ctx) {
-//			return ctx.e(0).dispatch(this) * ctx.e(1).dispatch(this);
+//			return ctx.e(0).accept(this) * ctx.e(1).accept(this);
 			return visit(ctx.e(0)) * visit(ctx.e(1));
 		}
 
 		@Override
 		public Integer visit(AParser.ParensContext ctx) {
-			return ctx.e().dispatch(this);
+			return ctx.e().accept(this);
 		}
 
 		@Override
 		public Integer visit(AParser.sContext ctx) {
-			return ctx.e().dispatch(this);
+			return visit(ctx.e());
+			//return ctx.e().accept(this);
 		}
 	}
 
@@ -73,7 +70,7 @@ public class TestVisitor {
 
 		MyVisitor visitor = new MyVisitor();
 		Integer result = visitor.visit(t);
-//		Integer result = t.dispatch(visitor);
+//		Integer result = t.accept(visitor);
 		System.out.println("result from tree walk = " + result);
 	}
 }
diff --git a/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg b/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg
index 32fa834b3..545a72227 100644
--- a/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg
+++ b/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg
@@ -56,6 +56,18 @@ public class <file.grammarName>BaseListener implements <file.grammarName>Listene
 }
 >>
 
+VisitorFile(file, header) ::= <<
+<header>
+import org.antlr.v4.runtime.tree.*;
+import org.antlr.v4.runtime.Token;
+
+public interface <file.grammarName>Visitor\<T> {
+	<file.visitorNames:{lname |
+T visit(<file.parserName>.<lname>Context ctx);}; separator="\n">
+}
+>>
+
+
 Parser(parser, funcs, atn, sempredFuncs, superclass) ::= <<
 <Parser_(ctor="parser_ctor", ...)>
 >>
@@ -571,10 +583,10 @@ public void <if(method.isEnter)>enter<else>exit<endif>Rule(ParseTreeListener\<<I
 }
 >>
 
-VisitorDispatchMethod() ::= <<
+VisitorDispatchMethod(method) ::= <<
 @Override
-public \<T> T dispatch(ParseTreeVisitor\<? extends T> visitor) { 
-    if ( listener instanceof <parser.grammarName>Visitor ) return ((<parser.grammarName>Visitor\<T>)visitor).visit(this);
+public \<T> T accept(ParseTreeVisitor\<? extends T> visitor) { 
+    if ( visitor instanceof <parser.grammarName>Visitor ) return ((<parser.grammarName>Visitor\<T>)visitor).visit(this);
     else return null;
 }
 >>
diff --git a/tool/src/org/antlr/v4/codegen/CodeGenPipeline.java b/tool/src/org/antlr/v4/codegen/CodeGenPipeline.java
index 1c2bc481d..fd08c81c9 100644
--- a/tool/src/org/antlr/v4/codegen/CodeGenPipeline.java
+++ b/tool/src/org/antlr/v4/codegen/CodeGenPipeline.java
@@ -48,6 +48,7 @@ public class CodeGenPipeline {
 			gen.writeRecognizer(gen.generateParser());
 			if ( g.tool.gen_listener) {
 				gen.writeListener(gen.generateListener());
+				gen.writeVisitor(gen.generateVisitor());
 				gen.writeBlankListener(gen.generateBlankListener());
 			}
 			gen.writeHeaderFile();
diff --git a/tool/src/org/antlr/v4/codegen/CodeGenerator.java b/tool/src/org/antlr/v4/codegen/CodeGenerator.java
index 76e824aaf..22ff0d310 100644
--- a/tool/src/org/antlr/v4/codegen/CodeGenerator.java
+++ b/tool/src/org/antlr/v4/codegen/CodeGenerator.java
@@ -33,16 +33,12 @@ import org.antlr.v4.Tool;
 import org.antlr.v4.codegen.model.OutputModelObject;
 import org.antlr.v4.runtime.Token;
 import org.antlr.v4.runtime.misc.NotNull;
-import org.antlr.v4.tool.ErrorType;
-import org.antlr.v4.tool.Grammar;
+import org.antlr.v4.tool.*;
 import org.stringtemplate.v4.*;
 
-import java.io.IOException;
-import java.io.Writer;
-import java.lang.reflect.Constructor;
-import java.lang.reflect.InvocationTargetException;
-import java.util.HashMap;
-import java.util.Map;
+import java.io.*;
+import java.lang.reflect.*;
+import java.util.*;
 
 /** General controller for code gen.  Can instantiate sub generator(s).
  */
@@ -173,6 +169,19 @@ public class CodeGenerator {
 		return st;
 	}
 
+	public ST generateVisitor() {
+		OutputModelFactory factory = new ParserFactory(this);
+
+		OutputModelController controller = new OutputModelController(factory);
+		factory.setController(controller);
+
+		OutputModelObject visitorModel = controller.buildVisitorOutputModel();
+
+		OutputModelWalker walker = new OutputModelWalker(tool, templates);
+		ST st = walker.walk(visitorModel);
+		return st;
+	}
+
 	public ST generateBlankListener() {
 		OutputModelFactory factory = new ParserFactory(this);
 
@@ -230,6 +239,10 @@ public class CodeGenerator {
 		target.genFile(g,outputFileST, getBlankListenerFileName());
 	}
 
+	public void writeVisitor(ST outputFileST) {
+		target.genFile(g,outputFileST, getVisitorFileName());
+	}
+
 	public void writeHeaderFile() {
 		String fileName = getHeaderFileName();
 		if ( fileName==null ) return;
@@ -309,6 +322,16 @@ public class CodeGenerator {
 		return listenerName+extST.render();
 	}
 
+	/** A given grammar T, return the visitor name such as
+	 *  TVisitor.java, if we're using the Java target.
+ 	 */
+	public String getVisitorFileName() {
+		assert g.name != null;
+		ST extST = templates.getInstanceOf("codeFileExtension");
+		String listenerName = g.name + "Visitor";
+		return listenerName+extST.render();
+	}
+
 	/** A given grammar T, return a blank listener implementation
 	 *  such as BlankTListener.java, if we're using the Java target.
  	 */
diff --git a/tool/src/org/antlr/v4/codegen/OutputModelController.java b/tool/src/org/antlr/v4/codegen/OutputModelController.java
index 619267da3..c68613f31 100644
--- a/tool/src/org/antlr/v4/codegen/OutputModelController.java
+++ b/tool/src/org/antlr/v4/codegen/OutputModelController.java
@@ -33,22 +33,12 @@ import org.antlr.runtime.tree.CommonTreeNodeStream;
 import org.antlr.v4.analysis.LeftRecursiveRuleAltInfo;
 import org.antlr.v4.codegen.model.*;
 import org.antlr.v4.codegen.model.decl.CodeBlock;
-import org.antlr.v4.parse.ANTLRParser;
-import org.antlr.v4.parse.GrammarASTAdaptor;
-import org.antlr.v4.tool.Alternative;
-import org.antlr.v4.tool.Grammar;
-import org.antlr.v4.tool.LeftRecursiveRule;
-import org.antlr.v4.tool.Rule;
-import org.antlr.v4.tool.ast.ActionAST;
-import org.antlr.v4.tool.ast.BlockAST;
-import org.antlr.v4.tool.ast.GrammarAST;
-import org.antlr.v4.tool.ast.PredAST;
-import org.stringtemplate.v4.ST;
-import org.stringtemplate.v4.STGroup;
+import org.antlr.v4.parse.*;
+import org.antlr.v4.tool.*;
+import org.antlr.v4.tool.ast.*;
+import org.stringtemplate.v4.*;
 
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Stack;
+import java.util.*;
 
 /** This receives events from SourceGenTriggers.g and asks factory to do work.
  *  Then runs extensions in order on resulting SrcOps to get final list.
@@ -123,6 +113,11 @@ public class OutputModelController {
 		return new BaseListenerFile(delegate, gen.getBlankListenerFileName());
 	}
 
+	public OutputModelObject buildVisitorOutputModel() {
+		CodeGenerator gen = delegate.getGenerator();
+		return new VisitorFile(delegate, gen.getVisitorFileName());
+	}
+
 	public ParserFile parserFile(String fileName) {
 		ParserFile f = delegate.parserFile(fileName);
 		for (CodeGeneratorExtension ext : extensions) f = ext.parserFile(f);
diff --git a/tool/src/org/antlr/v4/codegen/model/DispatchMethod.java b/tool/src/org/antlr/v4/codegen/model/DispatchMethod.java
new file mode 100644
index 000000000..799220ab9
--- /dev/null
+++ b/tool/src/org/antlr/v4/codegen/model/DispatchMethod.java
@@ -0,0 +1,9 @@
+package org.antlr.v4.codegen.model;
+
+import org.antlr.v4.codegen.OutputModelFactory;
+
+public class DispatchMethod extends OutputModelObject {
+	public DispatchMethod(OutputModelFactory factory) {
+		super(factory);
+	}
+}
diff --git a/tool/src/org/antlr/v4/codegen/model/ListenerDispatchMethod.java b/tool/src/org/antlr/v4/codegen/model/ListenerDispatchMethod.java
index 5b241eb01..c35be77ff 100644
--- a/tool/src/org/antlr/v4/codegen/model/ListenerDispatchMethod.java
+++ b/tool/src/org/antlr/v4/codegen/model/ListenerDispatchMethod.java
@@ -1,20 +1,12 @@
 package org.antlr.v4.codegen.model;
 
 import org.antlr.v4.codegen.OutputModelFactory;
-import org.antlr.v4.misc.Triple;
-import org.antlr.v4.tool.Rule;
-import org.antlr.v4.tool.ast.AltAST;
 
-import java.util.List;
-
-public class ListenerDispatchMethod extends OutputModelObject {
-	public String listenerName = "Rule";
+public class ListenerDispatchMethod extends DispatchMethod {
 	public boolean isEnter;
 
-	public ListenerDispatchMethod(OutputModelFactory factory, Rule r, boolean isEnter) {
+	public ListenerDispatchMethod(OutputModelFactory factory, boolean isEnter) {
 		super(factory);
 		this.isEnter = isEnter;
-		List<Triple<Integer,AltAST,String>> label = r.getAltLabels();
-		if ( label!=null ) listenerName = label.get(0).c;
 	}
 }
diff --git a/tool/src/org/antlr/v4/codegen/model/VisitorDispatchMethod.java b/tool/src/org/antlr/v4/codegen/model/VisitorDispatchMethod.java
index 19c954fd1..71cc671c8 100644
--- a/tool/src/org/antlr/v4/codegen/model/VisitorDispatchMethod.java
+++ b/tool/src/org/antlr/v4/codegen/model/VisitorDispatchMethod.java
@@ -1,20 +1,9 @@
 package org.antlr.v4.codegen.model;
 
 import org.antlr.v4.codegen.OutputModelFactory;
-import org.antlr.v4.misc.Triple;
-import org.antlr.v4.tool.Rule;
-import org.antlr.v4.tool.ast.AltAST;
 
-import java.util.List;
-
-public class VisitorDispatchMethod extends OutputModelObject {
-	public String listenerName = "Rule";
-	public boolean isEnter;
-
-	public VisitorDispatchMethod(OutputModelFactory factory, Rule r, boolean isEnter) {
+public class VisitorDispatchMethod extends DispatchMethod {
+	public VisitorDispatchMethod(OutputModelFactory factory) {
 		super(factory);
-		this.isEnter = isEnter;
-		List<Triple<Integer,AltAST,String>> label = r.getAltLabels();
-		if ( label!=null ) listenerName = label.get(0).c;
 	}
 }
diff --git a/tool/src/org/antlr/v4/codegen/model/VisitorFile.java b/tool/src/org/antlr/v4/codegen/model/VisitorFile.java
new file mode 100644
index 000000000..ee571c0ae
--- /dev/null
+++ b/tool/src/org/antlr/v4/codegen/model/VisitorFile.java
@@ -0,0 +1,37 @@
+package org.antlr.v4.codegen.model;
+
+import org.antlr.v4.codegen.OutputModelFactory;
+import org.antlr.v4.misc.Triple;
+import org.antlr.v4.tool.*;
+import org.antlr.v4.tool.ast.*;
+
+import java.util.*;
+
+public class VisitorFile extends OutputFile {
+	public String grammarName;
+	public String parserName;
+	public Set<String> visitorNames = new HashSet<String>();
+
+	@ModelElement public Action header;
+
+	public VisitorFile(OutputModelFactory factory, String fileName) {
+		super(factory, fileName);
+		Grammar g = factory.getGrammar();
+		parserName = g.getRecognizerName();
+		grammarName = g.name;
+		for (Rule r : g.rules.values()) {
+			List<Triple<Integer,AltAST,String>> labels = r.getAltLabels();
+			if ( labels!=null ) {
+				for (Triple<Integer,AltAST,String> pair : labels) {
+					visitorNames.add(pair.c);
+				}
+			}
+			else {
+				// if labels, must label all. no need for generic rule visitor then
+				visitorNames.add(r.name);
+			}
+		}
+		ActionAST ast = g.namedActions.get("header");
+		if ( ast!=null ) header = new Action(factory, ast);
+	}
+}
diff --git a/tool/src/org/antlr/v4/codegen/model/decl/AltLabelStructDecl.java b/tool/src/org/antlr/v4/codegen/model/decl/AltLabelStructDecl.java
index 6fe985471..b027cb1ba 100644
--- a/tool/src/org/antlr/v4/codegen/model/decl/AltLabelStructDecl.java
+++ b/tool/src/org/antlr/v4/codegen/model/decl/AltLabelStructDecl.java
@@ -30,6 +30,7 @@
 package org.antlr.v4.codegen.model.decl;
 
 import org.antlr.v4.codegen.OutputModelFactory;
+import org.antlr.v4.codegen.model.VisitorDispatchMethod;
 import org.antlr.v4.tool.Rule;
 
 /** A StructDecl to handle a -> label on alt */
@@ -46,6 +47,12 @@ public class AltLabelStructDecl extends StructDecl {
 			.getInstanceOf("RuleContextNameSuffix").render();
 	}
 
+	@Override
+	public void addDispatchMethods(Rule r) {
+		super.addDispatchMethods(r);
+		dispatchMethods.add(new VisitorDispatchMethod(factory));
+	}
+
 	@Override
 	public int hashCode() {
 		return name.hashCode();
diff --git a/tool/src/org/antlr/v4/codegen/model/decl/StructDecl.java b/tool/src/org/antlr/v4/codegen/model/decl/StructDecl.java
index afb9cbdeb..a4ebcfa5a 100644
--- a/tool/src/org/antlr/v4/codegen/model/decl/StructDecl.java
+++ b/tool/src/org/antlr/v4/codegen/model/decl/StructDecl.java
@@ -30,40 +30,37 @@
 package org.antlr.v4.codegen.model.decl;
 
 import org.antlr.v4.codegen.OutputModelFactory;
-import org.antlr.v4.codegen.model.ModelElement;
-import org.antlr.v4.codegen.model.OutputModelObject;
-import org.antlr.v4.codegen.model.ListenerDispatchMethod;
+import org.antlr.v4.codegen.model.*;
 import org.antlr.v4.runtime.misc.OrderedHashSet;
-import org.antlr.v4.tool.Attribute;
-import org.antlr.v4.tool.Rule;
+import org.antlr.v4.tool.*;
 
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.List;
+import java.util.*;
 
 /** This object models the structure holding all of the parameters,
  *  return values, local variables, and labels associated with a rule.
  */
 public class StructDecl extends Decl {
-	public String superClass;
 	public boolean provideCopyFrom;
 	@ModelElement public OrderedHashSet<Decl> attrs = new OrderedHashSet<Decl>();
 	@ModelElement public OrderedHashSet<Decl> getters = new OrderedHashSet<Decl>();
 	@ModelElement public Collection<Attribute> ctorAttrs;
-	@ModelElement public List<ListenerDispatchMethod> dispatchMethods;
+	@ModelElement public List<? super DispatchMethod> dispatchMethods;
 	@ModelElement public List<OutputModelObject> interfaces;
 	@ModelElement public List<OutputModelObject> extensionMembers;
 
 	public StructDecl(OutputModelFactory factory, Rule r) {
 		super(factory, factory.getGenerator().target.getRuleFunctionContextStructName(r));
-		addVisitorDispatchMethods(r);
+		addDispatchMethods(r);
 		provideCopyFrom = r.hasAltSpecificContexts();
 	}
 
-	public void addVisitorDispatchMethods(Rule r) {
-		dispatchMethods = new ArrayList<ListenerDispatchMethod>();
-		dispatchMethods.add(new ListenerDispatchMethod(factory, r, true));
-		dispatchMethods.add(new ListenerDispatchMethod(factory, r, false));
+	public void addDispatchMethods(Rule r) {
+		dispatchMethods = new ArrayList<DispatchMethod>();
+		dispatchMethods.add(new ListenerDispatchMethod(factory, true));
+		dispatchMethods.add(new ListenerDispatchMethod(factory, false));
+		if ( !r.hasAltSpecificContexts() ) {
+			dispatchMethods.add(new VisitorDispatchMethod(factory));
+		}
 	}
 
 	public void addDecl(Decl d) {

From 646b22b9ec25ee5c0c763f850dd055bdab17dc85 Mon Sep 17 00:00:00 2001
From: Terence Parr <parrt@antlr.org>
Date: Thu, 16 Feb 2012 13:36:07 -0800
Subject: [PATCH 4/8] snapshot

---
 .../v4/runtime/tree/ParseTreeVisitor.java     |  7 +++-
 tool/playground/ABaseVisitor.java             | 15 ++++---
 tool/playground/AVisitor.java                 |  3 ++
 tool/playground/TestVisitor.java              |  2 +-
 .../v4/tool/templates/codegen/Java/Java.stg   | 10 +++++
 .../org/antlr/v4/codegen/CodeGenPipeline.java |  3 +-
 .../org/antlr/v4/codegen/CodeGenerator.java   | 41 +++++++++++++++----
 .../v4/codegen/OutputModelController.java     |  9 +++-
 .../v4/codegen/model/BaseVisitorFile.java     |  9 ++++
 .../antlr/v4/codegen/model/ListenerFile.java  |  1 -
 10 files changed, 79 insertions(+), 21 deletions(-)
 create mode 100644 tool/src/org/antlr/v4/codegen/model/BaseVisitorFile.java

diff --git a/runtime/Java/src/org/antlr/v4/runtime/tree/ParseTreeVisitor.java b/runtime/Java/src/org/antlr/v4/runtime/tree/ParseTreeVisitor.java
index c77131a47..5dd260312 100644
--- a/runtime/Java/src/org/antlr/v4/runtime/tree/ParseTreeVisitor.java
+++ b/runtime/Java/src/org/antlr/v4/runtime/tree/ParseTreeVisitor.java
@@ -8,7 +8,12 @@ public class ParseTreeVisitor<T> {
 		return ctx.accept(this);
 	}
 
-	/** Visit all rule, nonleaf children */
+	/** Visit all rule, nonleaf children. Not useful if you are using T as
+	 *  non-Void.  This returns nothing, losing all computations from below.
+	 *  But handy if you are just walking the tree with a visitor and only
+	 *  care about some nodes.  The ParserRuleContext.accept() method
+	 *  walks all children by default; i.e., calls this method.
+	 */
 	public <Symbol> void visitChildren(ParserRuleContext<Symbol> ctx) {
 		for (ParseTree c : ctx.children) {
 			if ( c instanceof ParseTree.RuleNode) {
diff --git a/tool/playground/ABaseVisitor.java b/tool/playground/ABaseVisitor.java
index b20971e54..aa3159fbc 100644
--- a/tool/playground/ABaseVisitor.java
+++ b/tool/playground/ABaseVisitor.java
@@ -1,11 +1,10 @@
+import org.antlr.v4.runtime.tree.*;
 import org.antlr.v4.runtime.Token;
-import org.antlr.v4.runtime.tree.ParseTreeVisitor;
 
 public class ABaseVisitor<T> extends ParseTreeVisitor<T> implements AVisitor<T> {
-	public T visit(AParser.MultContext ctx) { return null; }
-	public T visit(AParser.ParensContext ctx) { return null; }
-	public T visit(AParser.eContext ctx) { return null; }
-	public T visit(AParser.sContext ctx) { return null; }
-	public T visit(AParser.AddContext ctx) { return null; }
-	public T visit(AParser.IntContext ctx) { return null; }
-}
+	public T visit(AParser.MultContext ctx) { visitChildren(ctx); return null; }
+	public T visit(AParser.ParensContext ctx) { visitChildren(ctx); return null; }
+	public T visit(AParser.sContext ctx) { visitChildren(ctx); return null; }
+	public T visit(AParser.AddContext ctx) { visitChildren(ctx); return null; }
+	public T visit(AParser.IntContext ctx) { visitChildren(ctx); return null; }
+}
\ No newline at end of file
diff --git a/tool/playground/AVisitor.java b/tool/playground/AVisitor.java
index 5badbd275..5730fa2d6 100644
--- a/tool/playground/AVisitor.java
+++ b/tool/playground/AVisitor.java
@@ -1,3 +1,6 @@
+import org.antlr.v4.runtime.tree.*;
+import org.antlr.v4.runtime.Token;
+
 public interface AVisitor<T> {
 	T visit(AParser.MultContext ctx);
 	T visit(AParser.ParensContext ctx);
diff --git a/tool/playground/TestVisitor.java b/tool/playground/TestVisitor.java
index 734e6bc6a..6d7e240cb 100644
--- a/tool/playground/TestVisitor.java
+++ b/tool/playground/TestVisitor.java
@@ -31,7 +31,7 @@ import org.antlr.v4.runtime.*;
 import org.antlr.v4.runtime.tree.ParseTreeVisitor;
 
 public class TestVisitor {
-	public static class MyVisitor extends ParseTreeVisitor<Integer> implements AVisitor<Integer> {
+	public static class MyVisitor extends ABaseVisitor<Integer> implements AVisitor<Integer> {
 		@Override
 		public Integer visit(AParser.AddContext ctx) {
 			return ctx.e(0).accept(this) + ctx.e(1).accept(this);
diff --git a/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg b/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg
index 545a72227..6fd56d759 100644
--- a/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg
+++ b/tool/resources/org/antlr/v4/tool/templates/codegen/Java/Java.stg
@@ -67,6 +67,16 @@ T visit(<file.parserName>.<lname>Context ctx);}; separator="\n">
 }
 >>
 
+BaseVisitorFile(file, header) ::= <<
+<header>
+import org.antlr.v4.runtime.tree.*;
+import org.antlr.v4.runtime.Token;
+
+public class <file.grammarName>BaseVisitor\<T> extends ParseTreeVisitor\<T> implements <file.grammarName>Visitor\<T> {
+	<file.visitorNames:{lname |
+public T visit(<file.parserName>.<lname>Context ctx) { visitChildren(ctx); return null; \}}; separator="\n">
+}
+>>
 
 Parser(parser, funcs, atn, sempredFuncs, superclass) ::= <<
 <Parser_(ctor="parser_ctor", ...)>
diff --git a/tool/src/org/antlr/v4/codegen/CodeGenPipeline.java b/tool/src/org/antlr/v4/codegen/CodeGenPipeline.java
index fd08c81c9..d89443fcd 100644
--- a/tool/src/org/antlr/v4/codegen/CodeGenPipeline.java
+++ b/tool/src/org/antlr/v4/codegen/CodeGenPipeline.java
@@ -48,8 +48,9 @@ public class CodeGenPipeline {
 			gen.writeRecognizer(gen.generateParser());
 			if ( g.tool.gen_listener) {
 				gen.writeListener(gen.generateListener());
+				gen.writeBaseListener(gen.generateBaseListener());
 				gen.writeVisitor(gen.generateVisitor());
-				gen.writeBlankListener(gen.generateBlankListener());
+				gen.writeBaseVisitor(gen.generateBaseVisitor());
 			}
 			gen.writeHeaderFile();
 		}
diff --git a/tool/src/org/antlr/v4/codegen/CodeGenerator.java b/tool/src/org/antlr/v4/codegen/CodeGenerator.java
index 22ff0d310..eaf9cba06 100644
--- a/tool/src/org/antlr/v4/codegen/CodeGenerator.java
+++ b/tool/src/org/antlr/v4/codegen/CodeGenerator.java
@@ -182,16 +182,29 @@ public class CodeGenerator {
 		return st;
 	}
 
-	public ST generateBlankListener() {
+	public ST generateBaseListener() {
 		OutputModelFactory factory = new ParserFactory(this);
 
 		OutputModelController controller = new OutputModelController(factory);
 		factory.setController(controller);
 
-		OutputModelObject blankModel = controller.buildBlankListenerOutputModel();
+		OutputModelObject baseModel = controller.buildBaseListenerOutputModel();
 
 		OutputModelWalker walker = new OutputModelWalker(tool, templates);
-		ST st = walker.walk(blankModel);
+		ST st = walker.walk(baseModel);
+		return st;
+	}
+
+	public ST generateBaseVisitor() {
+		OutputModelFactory factory = new ParserFactory(this);
+
+		OutputModelController controller = new OutputModelController(factory);
+		factory.setController(controller);
+
+		OutputModelObject baseModel = controller.buildBaseVisitorOutputModel();
+
+		OutputModelWalker walker = new OutputModelWalker(tool, templates);
+		ST st = walker.walk(baseModel);
 		return st;
 	}
 
@@ -235,14 +248,18 @@ public class CodeGenerator {
 		target.genFile(g,outputFileST, getListenerFileName());
 	}
 
-	public void writeBlankListener(ST outputFileST) {
-		target.genFile(g,outputFileST, getBlankListenerFileName());
+	public void writeBaseListener(ST outputFileST) {
+		target.genFile(g,outputFileST, getBaseListenerFileName());
 	}
 
 	public void writeVisitor(ST outputFileST) {
 		target.genFile(g,outputFileST, getVisitorFileName());
 	}
 
+	public void writeBaseVisitor(ST outputFileST) {
+		target.genFile(g,outputFileST, getBaseVisitorFileName());
+	}
+
 	public void writeHeaderFile() {
 		String fileName = getHeaderFileName();
 		if ( fileName==null ) return;
@@ -333,15 +350,25 @@ public class CodeGenerator {
 	}
 
 	/** A given grammar T, return a blank listener implementation
-	 *  such as BlankTListener.java, if we're using the Java target.
+	 *  such as TBaseListener.java, if we're using the Java target.
  	 */
-	public String getBlankListenerFileName() {
+	public String getBaseListenerFileName() {
 		assert g.name != null;
 		ST extST = templates.getInstanceOf("codeFileExtension");
 		String listenerName = g.name + "BaseListener";
 		return listenerName+extST.render();
 	}
 
+	/** A given grammar T, return a blank listener implementation
+	 *  such as TBaseListener.java, if we're using the Java target.
+ 	 */
+	public String getBaseVisitorFileName() {
+		assert g.name != null;
+		ST extST = templates.getInstanceOf("codeFileExtension");
+		String listenerName = g.name + "BaseVisitor";
+		return listenerName+extST.render();
+	}
+
 	/** What is the name of the vocab file generated for this grammar?
 	 *  Returns null if no .tokens file should be generated.
 	 */
diff --git a/tool/src/org/antlr/v4/codegen/OutputModelController.java b/tool/src/org/antlr/v4/codegen/OutputModelController.java
index c68613f31..9827eaf85 100644
--- a/tool/src/org/antlr/v4/codegen/OutputModelController.java
+++ b/tool/src/org/antlr/v4/codegen/OutputModelController.java
@@ -108,9 +108,9 @@ public class OutputModelController {
 		return new ListenerFile(delegate, gen.getListenerFileName());
 	}
 
-	public OutputModelObject buildBlankListenerOutputModel() {
+	public OutputModelObject buildBaseListenerOutputModel() {
 		CodeGenerator gen = delegate.getGenerator();
-		return new BaseListenerFile(delegate, gen.getBlankListenerFileName());
+		return new BaseListenerFile(delegate, gen.getBaseListenerFileName());
 	}
 
 	public OutputModelObject buildVisitorOutputModel() {
@@ -118,6 +118,11 @@ public class OutputModelController {
 		return new VisitorFile(delegate, gen.getVisitorFileName());
 	}
 
+	public OutputModelObject buildBaseVisitorOutputModel() {
+		CodeGenerator gen = delegate.getGenerator();
+		return new BaseVisitorFile(delegate, gen.getBaseVisitorFileName());
+	}
+
 	public ParserFile parserFile(String fileName) {
 		ParserFile f = delegate.parserFile(fileName);
 		for (CodeGeneratorExtension ext : extensions) f = ext.parserFile(f);
diff --git a/tool/src/org/antlr/v4/codegen/model/BaseVisitorFile.java b/tool/src/org/antlr/v4/codegen/model/BaseVisitorFile.java
new file mode 100644
index 000000000..0d8d1ab28
--- /dev/null
+++ b/tool/src/org/antlr/v4/codegen/model/BaseVisitorFile.java
@@ -0,0 +1,9 @@
+package org.antlr.v4.codegen.model;
+
+import org.antlr.v4.codegen.OutputModelFactory;
+
+public class BaseVisitorFile extends VisitorFile {
+	public BaseVisitorFile(OutputModelFactory factory, String fileName) {
+		super(factory, fileName);
+	}
+}
diff --git a/tool/src/org/antlr/v4/codegen/model/ListenerFile.java b/tool/src/org/antlr/v4/codegen/model/ListenerFile.java
index 5461d26fa..dda76c16b 100644
--- a/tool/src/org/antlr/v4/codegen/model/ListenerFile.java
+++ b/tool/src/org/antlr/v4/codegen/model/ListenerFile.java
@@ -14,7 +14,6 @@ public class ListenerFile extends OutputFile {
 	public String grammarName;
 	public String parserName;
 	public Set<String> listenerNames = new HashSet<String>();
-//	public List<String> ruleNames = new ArrayList<String>();
 
 	@ModelElement public Action header;
 

From 100b5302014643d44669028e6dca6338edcf8f60 Mon Sep 17 00:00:00 2001
From: Terence Parr <parrt@antlr.org>
Date: Thu, 16 Feb 2012 17:14:41 -0800
Subject: [PATCH 5/8] report errors with too few alt labels or redef of alt
 label

---
 tool/playground/A.g4                          |  6 +++
 tool/playground/ABaseVisitor.java             |  6 +--
 tool/playground/AVisitor.java                 |  6 +--
 .../v4/semantics/BasicSemanticChecks.java     | 43 +++++++++++++++++--
 tool/src/org/antlr/v4/tool/ErrorType.java     |  4 +-
 tool/src/org/antlr/v4/tool/ast/RuleAST.java   | 13 +++++-
 6 files changed, 64 insertions(+), 14 deletions(-)

diff --git a/tool/playground/A.g4 b/tool/playground/A.g4
index 9c2d6ea73..ce79583fc 100644
--- a/tool/playground/A.g4
+++ b/tool/playground/A.g4
@@ -8,5 +8,11 @@ e : e '*' e 		-> Mult
   | '(' e ')'		-> Parens
   ;
 
+x : A -> Foo
+  | B
+  ;
+
+y : Y -> Mult ;
+
 INT : [0-9]+ ;
 WS : [ \t\n]+ -> skip ;
diff --git a/tool/playground/ABaseVisitor.java b/tool/playground/ABaseVisitor.java
index aa3159fbc..355023fd6 100644
--- a/tool/playground/ABaseVisitor.java
+++ b/tool/playground/ABaseVisitor.java
@@ -1,10 +1,10 @@
-import org.antlr.v4.runtime.tree.*;
-import org.antlr.v4.runtime.Token;
+import org.antlr.v4.runtime.tree.ParseTreeVisitor;
 
 public class ABaseVisitor<T> extends ParseTreeVisitor<T> implements AVisitor<T> {
 	public T visit(AParser.MultContext ctx) { visitChildren(ctx); return null; }
 	public T visit(AParser.ParensContext ctx) { visitChildren(ctx); return null; }
 	public T visit(AParser.sContext ctx) { visitChildren(ctx); return null; }
+	public T visit(AParser.FooContext ctx) { visitChildren(ctx); return null; }
 	public T visit(AParser.AddContext ctx) { visitChildren(ctx); return null; }
 	public T visit(AParser.IntContext ctx) { visitChildren(ctx); return null; }
-}
\ No newline at end of file
+}
diff --git a/tool/playground/AVisitor.java b/tool/playground/AVisitor.java
index 5730fa2d6..4bd72a0f0 100644
--- a/tool/playground/AVisitor.java
+++ b/tool/playground/AVisitor.java
@@ -1,10 +1,8 @@
-import org.antlr.v4.runtime.tree.*;
-import org.antlr.v4.runtime.Token;
-
 public interface AVisitor<T> {
 	T visit(AParser.MultContext ctx);
 	T visit(AParser.ParensContext ctx);
 	T visit(AParser.sContext ctx);
+	T visit(AParser.FooContext ctx);
 	T visit(AParser.AddContext ctx);
 	T visit(AParser.IntContext ctx);
-}
\ No newline at end of file
+}
diff --git a/tool/src/org/antlr/v4/semantics/BasicSemanticChecks.java b/tool/src/org/antlr/v4/semantics/BasicSemanticChecks.java
index cea367831..d39b46cf0 100644
--- a/tool/src/org/antlr/v4/semantics/BasicSemanticChecks.java
+++ b/tool/src/org/antlr/v4/semantics/BasicSemanticChecks.java
@@ -40,10 +40,7 @@ import org.antlr.v4.tool.ast.*;
 import org.stringtemplate.v4.misc.MultiMap;
 
 import java.io.File;
-import java.util.ArrayList;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Set;
+import java.util.*;
 
 /** No side-effects except for setting options into the appropriate node.
  *  TODO:  make the side effects into a separate pass this
@@ -242,6 +239,44 @@ public class BasicSemanticChecks extends GrammarTreeVisitor {
 //		}
 	}
 
+	Map<String,String> altLabelToRuleName = new HashMap<String, String>();
+
+	@Override
+	public void finishRule(RuleAST rule, GrammarAST ID, GrammarAST block) {
+		MultiMap<String,GrammarAST> ruleToAltLabels = new MultiMap<String, GrammarAST>();
+		if ( rule.isLexerRule() ) return;
+		BlockAST blk = (BlockAST)rule.getFirstChildWithType(BLOCK);
+		int nalts = blk.getChildCount();
+		for (int i=0; i< nalts; i++) {
+			AltAST altAST = (AltAST)blk.getChild(i);
+			if ( altAST.altLabel!=null ) {
+				System.out.println("alt label "+altAST.altLabel);
+				ruleToAltLabels.map(rule.getRuleName(), altAST.altLabel);
+				String altLabel = altAST.altLabel.getText();
+				String prevRuleForLabel = altLabelToRuleName.get(altLabel);
+				if ( prevRuleForLabel!=null ) {
+					g.tool.errMgr.grammarError(ErrorType.ALT_LABEL_REDEF,
+											   g.fileName, rule.getToken(),
+											   altLabel,
+											   rule.getRuleName(),
+											   prevRuleForLabel);
+				}
+				else {
+					altLabelToRuleName.put(altLabel, rule.getRuleName());
+				}
+			}
+		}
+		System.out.println(rule.getRuleName()+" has "+ nalts +" alts");
+		List<GrammarAST> altLabels = ruleToAltLabels.get(rule.getRuleName());
+		int numAltLabels = 0;
+		if ( altLabels!=null ) numAltLabels = altLabels.size();
+		System.out.println("labels="+altLabels);
+		if ( numAltLabels>0 && nalts != numAltLabels ) {
+			g.tool.errMgr.grammarError(ErrorType.RULE_WITH_TOO_FEW_ALT_LABELS,
+									   g.fileName, rule.getToken(), rule.getRuleName());
+		}
+	}
+
 	// Routines to do the actual work of checking issues with a grammar.
 	// They are triggered by the visitor methods above.
 
diff --git a/tool/src/org/antlr/v4/tool/ErrorType.java b/tool/src/org/antlr/v4/tool/ErrorType.java
index af3757509..4b9f831b7 100644
--- a/tool/src/org/antlr/v4/tool/ErrorType.java
+++ b/tool/src/org/antlr/v4/tool/ErrorType.java
@@ -139,7 +139,9 @@ public enum ErrorType {
 	ALL_OPS_NEED_SAME_ASSOC(118, "all operators of alt <arg> of left-recursive rule must have same associativity", ErrorSeverity.WARNING),
 	LEFT_RECURSION_CYCLES(119, "The following sets of rules are mutually left-recursive <arg:{c| [<c:{r|<r.name>}; separator=\", \">]}; separator=\" and \">", ErrorSeverity.ERROR),
 	MODE_NOT_IN_LEXER(120, "lexical modes are only allowed in lexer grammars", ErrorSeverity.ERROR),
-    CANNOT_FIND_ATTRIBUTE_NAME_IN_DECL(121, "cannot find an attribute name in attribute declaration", ErrorSeverity.ERROR),
+	CANNOT_FIND_ATTRIBUTE_NAME_IN_DECL(121, "cannot find an attribute name in attribute declaration", ErrorSeverity.ERROR),
+	RULE_WITH_TOO_FEW_ALT_LABELS(122, "rule <arg>: must label all alternatives or none", ErrorSeverity.ERROR),
+	ALT_LABEL_REDEF(123, "rule alt label <arg> redefined in rule <arg2>, originally in <arg3>", ErrorSeverity.ERROR),
 	/** Documentation comment is unterminated */
     //UNTERMINATED_DOC_COMMENT(, "", ErrorSeverity.ERROR),
 
diff --git a/tool/src/org/antlr/v4/tool/ast/RuleAST.java b/tool/src/org/antlr/v4/tool/ast/RuleAST.java
index 5f4722018..257492538 100644
--- a/tool/src/org/antlr/v4/tool/ast/RuleAST.java
+++ b/tool/src/org/antlr/v4/tool/ast/RuleAST.java
@@ -34,8 +34,6 @@ import org.antlr.runtime.tree.Tree;
 import org.antlr.v4.parse.ANTLRParser;
 
 public class RuleAST extends GrammarASTWithOptions {
-
-
 	public RuleAST(GrammarAST node) {
 		super(node);
 	}
@@ -43,6 +41,17 @@ public class RuleAST extends GrammarASTWithOptions {
 	public RuleAST(Token t) { super(t); }
     public RuleAST(int type) { super(type); }
 
+	public boolean isLexerRule() {
+		String name = getRuleName();
+		return name!=null && Character.isUpperCase(name.charAt(0));
+	}
+
+	public String getRuleName() {
+		GrammarAST nameNode = (GrammarAST)getChild(0);
+		if ( nameNode!=null ) return nameNode.getText();
+		return null;
+	}
+
 	@Override
 	public Tree dupNode() { return new RuleAST(this); }
 

From d00ec9d2274abf0b5efb39baa67d4eed7a2f664c Mon Sep 17 00:00:00 2001
From: Terence Parr <parrt@antlr.org>
Date: Thu, 16 Feb 2012 17:31:30 -0800
Subject: [PATCH 6/8] got -no prefix options working. rm'd dup error from
 toolError(); rm dbg print

---
 tool/playground/A.g4                                 |  6 ------
 tool/playground/AVisitor.java                        |  6 ++++--
 tool/src/org/antlr/v4/Tool.java                      |  7 ++++++-
 tool/src/org/antlr/v4/codegen/CodeGenPipeline.java   |  4 +++-
 .../org/antlr/v4/semantics/BasicSemanticChecks.java  |  3 ---
 tool/src/org/antlr/v4/tool/ErrorManager.java         | 12 ++++++++----
 tool/src/org/antlr/v4/tool/ErrorType.java            |  3 ++-
 7 files changed, 23 insertions(+), 18 deletions(-)

diff --git a/tool/playground/A.g4 b/tool/playground/A.g4
index ce79583fc..9c2d6ea73 100644
--- a/tool/playground/A.g4
+++ b/tool/playground/A.g4
@@ -8,11 +8,5 @@ e : e '*' e 		-> Mult
   | '(' e ')'		-> Parens
   ;
 
-x : A -> Foo
-  | B
-  ;
-
-y : Y -> Mult ;
-
 INT : [0-9]+ ;
 WS : [ \t\n]+ -> skip ;
diff --git a/tool/playground/AVisitor.java b/tool/playground/AVisitor.java
index 4bd72a0f0..5730fa2d6 100644
--- a/tool/playground/AVisitor.java
+++ b/tool/playground/AVisitor.java
@@ -1,8 +1,10 @@
+import org.antlr.v4.runtime.tree.*;
+import org.antlr.v4.runtime.Token;
+
 public interface AVisitor<T> {
 	T visit(AParser.MultContext ctx);
 	T visit(AParser.ParensContext ctx);
 	T visit(AParser.sContext ctx);
-	T visit(AParser.FooContext ctx);
 	T visit(AParser.AddContext ctx);
 	T visit(AParser.IntContext ctx);
-}
+}
\ No newline at end of file
diff --git a/tool/src/org/antlr/v4/Tool.java b/tool/src/org/antlr/v4/Tool.java
index b7a11c82d..34172f8f3 100644
--- a/tool/src/org/antlr/v4/Tool.java
+++ b/tool/src/org/antlr/v4/Tool.java
@@ -186,8 +186,10 @@ public class Tool {
 				grammarFiles.add(arg);
 				continue;
 			}
+			boolean found = false;
 			for (Option o : optionDefs) {
 				if ( arg.equals(o.name) ) {
+					found = true;
 					String argValue = null;
 					if ( o.argType==OptionArgType.STRING ) {
 						argValue = args[i];
@@ -198,7 +200,7 @@ public class Tool {
 					try {
 						Field f = c.getField(o.fieldName);
 						if ( argValue==null ) {
-							if ( o.fieldName.startsWith("-no-") ) f.setBoolean(this, false);
+							if ( arg.startsWith("-no-") ) f.setBoolean(this, false);
 							else f.setBoolean(this, true);
 						}
 						else f.set(this, argValue);
@@ -208,6 +210,9 @@ public class Tool {
 					}
 				}
 			}
+			if ( !found ) {
+				errMgr.toolError(ErrorType.INVALID_CMDLINE_ARG, arg);
+			}
 		}
 		if ( outputDirectory!=null ) {
 			if (outputDirectory.endsWith("/") ||
diff --git a/tool/src/org/antlr/v4/codegen/CodeGenPipeline.java b/tool/src/org/antlr/v4/codegen/CodeGenPipeline.java
index d89443fcd..6b2286738 100644
--- a/tool/src/org/antlr/v4/codegen/CodeGenPipeline.java
+++ b/tool/src/org/antlr/v4/codegen/CodeGenPipeline.java
@@ -46,9 +46,11 @@ public class CodeGenPipeline {
 		}
 		else {
 			gen.writeRecognizer(gen.generateParser());
-			if ( g.tool.gen_listener) {
+			if ( g.tool.gen_listener ) {
 				gen.writeListener(gen.generateListener());
 				gen.writeBaseListener(gen.generateBaseListener());
+			}
+			if ( g.tool.gen_visitor ) {
 				gen.writeVisitor(gen.generateVisitor());
 				gen.writeBaseVisitor(gen.generateBaseVisitor());
 			}
diff --git a/tool/src/org/antlr/v4/semantics/BasicSemanticChecks.java b/tool/src/org/antlr/v4/semantics/BasicSemanticChecks.java
index d39b46cf0..137326bbf 100644
--- a/tool/src/org/antlr/v4/semantics/BasicSemanticChecks.java
+++ b/tool/src/org/antlr/v4/semantics/BasicSemanticChecks.java
@@ -250,7 +250,6 @@ public class BasicSemanticChecks extends GrammarTreeVisitor {
 		for (int i=0; i< nalts; i++) {
 			AltAST altAST = (AltAST)blk.getChild(i);
 			if ( altAST.altLabel!=null ) {
-				System.out.println("alt label "+altAST.altLabel);
 				ruleToAltLabels.map(rule.getRuleName(), altAST.altLabel);
 				String altLabel = altAST.altLabel.getText();
 				String prevRuleForLabel = altLabelToRuleName.get(altLabel);
@@ -266,11 +265,9 @@ public class BasicSemanticChecks extends GrammarTreeVisitor {
 				}
 			}
 		}
-		System.out.println(rule.getRuleName()+" has "+ nalts +" alts");
 		List<GrammarAST> altLabels = ruleToAltLabels.get(rule.getRuleName());
 		int numAltLabels = 0;
 		if ( altLabels!=null ) numAltLabels = altLabels.size();
-		System.out.println("labels="+altLabels);
 		if ( numAltLabels>0 && nalts != numAltLabels ) {
 			g.tool.errMgr.grammarError(ErrorType.RULE_WITH_TOO_FEW_ALT_LABELS,
 									   g.fileName, rule.getToken(), rule.getRuleName());
diff --git a/tool/src/org/antlr/v4/tool/ErrorManager.java b/tool/src/org/antlr/v4/tool/ErrorManager.java
index 8f6a884e7..1d5d09ad9 100644
--- a/tool/src/org/antlr/v4/tool/ErrorManager.java
+++ b/tool/src/org/antlr/v4/tool/ErrorManager.java
@@ -30,11 +30,16 @@
 package org.antlr.v4.tool;
 
 import org.antlr.v4.Tool;
-import org.stringtemplate.v4.*;
-import org.stringtemplate.v4.misc.*;
+import org.stringtemplate.v4.ST;
+import org.stringtemplate.v4.STErrorListener;
+import org.stringtemplate.v4.STGroup;
+import org.stringtemplate.v4.STGroupFile;
+import org.stringtemplate.v4.misc.ErrorBuffer;
+import org.stringtemplate.v4.misc.STMessage;
 
 import java.net.URL;
-import java.util.*;
+import java.util.Collection;
+import java.util.Locale;
 
 public class ErrorManager {
 	public static final String FORMATS_DIR = "org/antlr/v4/tool/templates/messages/formats/";
@@ -190,7 +195,6 @@ public class ErrorManager {
 	public void toolError(ErrorType errorType, Object... args) {
 		ToolMessage msg = new ToolMessage(errorType, args);
 		emit(errorType, msg);
-		tool.error(msg);
 	}
 
 	public void toolError(ErrorType errorType, Throwable e, Object... args) {
diff --git a/tool/src/org/antlr/v4/tool/ErrorType.java b/tool/src/org/antlr/v4/tool/ErrorType.java
index 4b9f831b7..94ecfbef4 100644
--- a/tool/src/org/antlr/v4/tool/ErrorType.java
+++ b/tool/src/org/antlr/v4/tool/ErrorType.java
@@ -43,8 +43,9 @@ package org.antlr.v4.tool;
 public enum ErrorType {
     INVALID(0, "<INVALID>", ErrorSeverity.ERROR),
 
+	// Tool errors
 	CANNOT_WRITE_FILE(1, "cannot write file <arg>: <arg2>", ErrorSeverity.ERROR),
-//	CANNOT_CLOSE_FILE(2, "cannot close file <arg>", ErrorSeverity.ERROR),
+	INVALID_CMDLINE_ARG(2, "unknown command-line option <arg>", ErrorSeverity.ERROR),
 	CANNOT_FIND_TOKENS_FILE(3, "cannot find tokens file <arg>", ErrorSeverity.ERROR),
 	ERROR_READING_TOKENS_FILE(4, "cannot find tokens file <arg>: <arg2>", ErrorSeverity.ERROR),
 	DIR_NOT_FOUND(5, "directory not found: <arg>", ErrorSeverity.ERROR),

From c098e5c72964f0fff7d14a57f27d6ce133692667 Mon Sep 17 00:00:00 2001
From: Terence Parr <parrt@antlr.org>
Date: Thu, 16 Feb 2012 17:31:59 -0800
Subject: [PATCH 7/8] rm file

---
 tool/playground/ABaseVisitor.java | 10 ----------
 1 file changed, 10 deletions(-)
 delete mode 100644 tool/playground/ABaseVisitor.java

diff --git a/tool/playground/ABaseVisitor.java b/tool/playground/ABaseVisitor.java
deleted file mode 100644
index 355023fd6..000000000
--- a/tool/playground/ABaseVisitor.java
+++ /dev/null
@@ -1,10 +0,0 @@
-import org.antlr.v4.runtime.tree.ParseTreeVisitor;
-
-public class ABaseVisitor<T> extends ParseTreeVisitor<T> implements AVisitor<T> {
-	public T visit(AParser.MultContext ctx) { visitChildren(ctx); return null; }
-	public T visit(AParser.ParensContext ctx) { visitChildren(ctx); return null; }
-	public T visit(AParser.sContext ctx) { visitChildren(ctx); return null; }
-	public T visit(AParser.FooContext ctx) { visitChildren(ctx); return null; }
-	public T visit(AParser.AddContext ctx) { visitChildren(ctx); return null; }
-	public T visit(AParser.IntContext ctx) { visitChildren(ctx); return null; }
-}

From 44c0c8ca5ef5db5f9a47e87a51452e8c1e5f90e1 Mon Sep 17 00:00:00 2001
From: Terence Parr <parrt@antlr.org>
Date: Thu, 16 Feb 2012 17:45:57 -0800
Subject: [PATCH 8/8] dont gen visitor unless -visitor option

---
 .../org/antlr/v4/codegen/model/decl/AltLabelStructDecl.java   | 4 +++-
 tool/src/org/antlr/v4/codegen/model/decl/StructDecl.java      | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/tool/src/org/antlr/v4/codegen/model/decl/AltLabelStructDecl.java b/tool/src/org/antlr/v4/codegen/model/decl/AltLabelStructDecl.java
index b027cb1ba..54ca3bc0c 100644
--- a/tool/src/org/antlr/v4/codegen/model/decl/AltLabelStructDecl.java
+++ b/tool/src/org/antlr/v4/codegen/model/decl/AltLabelStructDecl.java
@@ -50,7 +50,9 @@ public class AltLabelStructDecl extends StructDecl {
 	@Override
 	public void addDispatchMethods(Rule r) {
 		super.addDispatchMethods(r);
-		dispatchMethods.add(new VisitorDispatchMethod(factory));
+		if ( factory.getGrammar().tool.gen_visitor ) {
+			dispatchMethods.add(new VisitorDispatchMethod(factory));
+		}
 	}
 
 	@Override
diff --git a/tool/src/org/antlr/v4/codegen/model/decl/StructDecl.java b/tool/src/org/antlr/v4/codegen/model/decl/StructDecl.java
index a4ebcfa5a..0c3e2bef5 100644
--- a/tool/src/org/antlr/v4/codegen/model/decl/StructDecl.java
+++ b/tool/src/org/antlr/v4/codegen/model/decl/StructDecl.java
@@ -58,7 +58,7 @@ public class StructDecl extends Decl {
 		dispatchMethods = new ArrayList<DispatchMethod>();
 		dispatchMethods.add(new ListenerDispatchMethod(factory, true));
 		dispatchMethods.add(new ListenerDispatchMethod(factory, false));
-		if ( !r.hasAltSpecificContexts() ) {
+		if ( factory.getGrammar().tool.gen_visitor && !r.hasAltSpecificContexts() ) {
 			dispatchMethods.add(new VisitorDispatchMethod(factory));
 		}
 	}