Commit Graph

7200 Commits

Author SHA1 Message Date
Carlo ad2ea7a68c
Update contributors.txt 2019-03-18 18:07:20 +01:00
Carlo 572bc7eb6f
do not use python built-in as variable name 2019-03-18 18:04:15 +01:00
Terence Parr 28fc84874d
Merge pull request #2510 from base698/master
Added visitor example.
2019-03-13 10:00:20 -07:00
Justin Thomas 6ee94ed5b9
Adding base698 to contributors.txt 2019-03-13 09:42:52 -07:00
Justin Thomas 6160aa6101
Added visitor example. 2019-03-12 06:51:56 -07:00
Terence Parr dade65a895
Merge pull request #2463 from youkaichao/python/test
update test script
2019-02-23 08:57:40 -08:00
Terence Parr 1c6c62afc7
Merge pull request #2486 from ralucado/master
Fix Index Error in Python3 GetChild
2019-02-06 17:38:12 -08:00
Ralu 510e3f7ed9
Update contributors.txt 2019-02-06 10:50:59 +01:00
Ralu de58c28a24
Fix off by one error in getChild 2019-02-06 10:41:38 +01:00
parrt de316ff5ce tweak doc 2019-02-04 13:32:39 -08:00
You Kaichao 45a4cdc67b update test script 2019-01-04 09:17:36 +08:00
Terence Parr 07735085bd
Merge pull request #2461 from youkaichao/python/doc
update python runtime doc
2019-01-03 10:16:54 -07:00
You Kaichao 18e2a605c1 update python runtime doc 2019-01-03 19:29:56 +08:00
Mike Lischke ec665c1b90 A small fix in the C++ documentation. 2019-01-03 10:39:59 +01:00
Terence Parr e924e26205
Merge pull request #2452 from youkaichao/bugfix/python
bugfix for python-runtime/TokenStreamRewriter.getText
2019-01-02 15:21:19 -07:00
You Kaichao 157afd1a8d update code on updated master 2019-01-02 19:06:36 +08:00
Terence Parr 9f422d87b8
Merge pull request #2458 from ericvergnaud/fix-python-getText-api
Fix python get text api
2019-01-01 11:55:30 -07:00
Eric Vergnaud e06b7a8b5d restore full build 2019-01-01 17:08:45 +01:00
Eric Vergnaud 81f7aee6ea fix failing tests 2019-01-01 17:02:29 +01:00
Eric Vergnaud 90854967ca fix broken API calls 2019-01-01 15:04:20 +01:00
Eric Vergnaud 3ad118f87e fix invalid test sequence 2019-01-01 13:31:01 +01:00
Eric Vergnaud cccf6e87da Fix API inconsistency, where getText would expect a tuple named interval, leading to lots of confusion 2019-01-01 13:20:23 +01:00
Eric Vergnaud 108854f986 remove misleading API 2019-01-01 13:19:38 +01:00
Terence Parr 6808f9c4b4
Merge pull request #2447 from WalterCouto/test2
Change bitset upperbound to another higher arbitrary value to allow f…
2018-12-26 09:26:13 -07:00
Terence Parr fa19ded837
Merge pull request #2446 from WalterCouto/test
C++ avoid warning in visual studio build due to clang specific directive
2018-12-21 12:01:22 -07:00
Terence Parr fa466c42a1
Merge pull request #2445 from WalterCouto/master
C++: fix bug in PredictionContext::mergeArrays
2018-12-21 12:01:08 -07:00
Terence Parr ce3b5a4cb4
Merge pull request #2176 from niccroad/atnsimulator_memleak
This resolves the recently opened issue 2175 (a memory leak).
2018-12-21 12:00:36 -07:00
WalterCouto 6195ec749b Change bitset upperbound to another higher arbitrary value to allow for larger number of rules
We had a complex grammar file hit past this upperbound.  One solution is to put this up higher, another is to refactor into a container that can grow.
2018-12-20 11:18:16 -05:00
WalterCouto 2d28400234 C++ avoid warning in visual studio build due to clang specific directive
The revently added clang directive cause a new warning for Visual Studio build. Need to include the new code with a directive checking for visual studio
2018-12-20 11:02:35 -05:00
WalterCouto 936db23a40 C++ runtime version of previousTokenOnChannel doesn't handle edge case correctly #2343
<!--
Before submitting an issue to ANTLR, please check off these boxes:

- [x] I am not submitting a question on how to use ANTLR; instead, go to [antlr4-discussion google group](https://groups.google.com/forum/#!forum/antlr-discussion) or ask at [stackoverflow](http://stackoverflow.com/questions/tagged/antlr4)
- [ x] I have done a search of the existing issues to make sure I'm not sending in a duplicate

Please include information about the expected behavior, actual behavior, and the smallest grammar or code that reproduces the behavior. If appropriate, please indicate the code generation targets such as Java, C#, ...  Pointers into offending code regions are also very welcome.
-->
As documented previousTokenOnChannel, should "return -1 if there are no tokens on channel between i and 0."  but the C++ version of the runtime returns 0 not -1 as can be seen below:

```
while (true) {
    Token *token = _tokens[i].get();
    if (token->getType() == Token::EOF || token->getChannel() == channel) {
      return i;
    }

    if (i == 0)
      break;
    i--;
  }
```

Looking at the Java implementation, it would seem the C++ code should instead be:
```
while (true) {
    Token *token = _tokens[i].get();
    if (token->getType() == Token::EOF || token->getChannel() == channel) {
      return i;
    }

    if (i == 0)
      return -1;
    i--;
  }
```
This bug causes getHiddenTokensToLeft() to miss hidden tokens that come before the first non-hidden token.  There would also be a potential bug in CommonTokenStream::LB as the "< 0" case would never happen.
2018-12-20 10:24:49 -05:00
WalterCouto 27c8eb5c6a C++: fix bug in PredictionContext::mergeArrays
In the orignal PredictionContext::mergeArrays there was a bug on Line 281 where the logic differs from java: It currently is:
bool both$ = payload == EMPTY_RETURN_STATE && a_parent && b_parent;
and should instead match java as:
bool both$ = payload == EMPTY_RETURN_STATE && !a_parent && !b_parent;
2018-12-20 10:07:59 -05:00
parrt 70d9ddcd0a [maven-release-plugin] prepare for next development iteration 2018-12-18 10:35:34 -08:00
parrt be58ebffde [maven-release-plugin] prepare release 4.7.2 2018-12-18 10:35:24 -08:00
parrt 8fab6b98b3 [maven-release-plugin] rollback the release of 4.7.2 2018-12-18 10:33:52 -08:00
parrt 5e5476a61a Merge branch 'master' of github.com:antlr/antlr4 2018-12-18 10:32:05 -08:00
parrt 573cb86705 [maven-release-plugin] prepare release 4.7.2 2018-12-18 10:31:44 -08:00
Terence Parr ab08f43746
Merge pull request #2443 from parrt/master
prep for 4.7.2
2018-12-17 16:16:31 -07:00
parrt 9f6dfb1809 Merge branch 'master' of github.com:antlr/antlr4 2018-12-17 14:43:34 -08:00
parrt 4ccf715bc4 tweak script 2018-12-17 14:43:23 -08:00
Terence Parr d7e0f4b3fc
Merge pull request #2309 from scadgek/patch-1
Avoid StringIndexOutOfBoundException
2018-12-17 15:40:39 -07:00
Terence Parr 96890a3505
Merge branch 'master' into patch-1 2018-12-17 15:40:30 -07:00
parrt 38a95da397 manual edits of 4.7.1 -> 4.7.2 2018-12-17 14:32:39 -08:00
Terence Parr b3f00ca72a
Merge pull request #2426 from hannemann-tamas/master
virtual dtor for ParseTreeProperty
2018-11-30 09:40:51 -08:00
ralf 80230131ac added virtual dtor to polymorphic class template ParseTreeProperty and added myself as contributor 2018-11-29 11:03:49 +01:00
ralf 7fdec95d15 added virtual dtor to polymorphic class template ParseTreeProperty 2018-11-29 10:44:47 +01:00
Terence Parr 8268fdd957
Merge pull request #2423 from ericvergnaud/fix-illegal-dict-key
fix NPE
2018-11-25 09:08:45 -08:00
Eric Vergnaud 56186d9e9f fix NPE 2018-11-26 01:03:36 +08:00
parrt 5faa48a645 fix https link issue; fixes #2422 2018-11-22 14:17:51 -08:00
Terence Parr 62b1cf8a4f
Merge pull request #2421 from prateekgulati/patch-2
Updating current directory in classpath
2018-11-22 11:46:30 -08:00
Prateek Gulati aa503dfafb
Updating current directory in classpath
Otherwise it throws "Can't load Hello as lexer or parser" error
2018-11-22 15:03:09 +05:30