重构代码：Log重构SQL脚本，子类直接使用父类

Bootstrap.DataAccess.MySQL/Log.cs

@@ -1,80 +1,10 @@
-using Longbow;
+namespace Bootstrap.DataAccess.MySQL
-using Longbow.Configuration;
-using System;
-using System.Collections.Generic;
-using System.Data;
-using System.Data.Common;
-
-namespace Bootstrap.DataAccess.MySQL
 {
     /// <summary>
     /// 
     /// </summary>
     public class Log : DataAccess.Log
     {
-        /// <summary>
+
-        /// 查询所有日志信息
-        /// </summary>
-        /// <param name="tId"></param>
-        /// <returns></returns>
-        public override IEnumerable<DataAccess.Log> RetrieveLogs()
-        {
-            string sql = "select * from Logs where LogTime > date_add(now(), interval -7 day)";
-            List<DataAccess.Log> logs = new List<DataAccess.Log>();
-            DbCommand cmd = DbAccessManager.DBAccess.CreateCommand(CommandType.Text, sql);
-            using (DbDataReader reader = DbAccessManager.DBAccess.ExecuteReader(cmd))
-            {
-                while (reader.Read())
-                {
-                    logs.Add(new DataAccess.Log()
-                    {
-                        Id = reader[0].ToString(),
-                        CRUD = (string)reader[1],
-                        UserName = (string)reader[2],
-                        LogTime = LgbConvert.ReadValue(reader[3], DateTime.MinValue),
-                        ClientIp = (string)reader[4],
-                        ClientAgent = (string)reader[5],
-                        RequestUrl = (string)reader[6]
-                    });
-                }
-            }
-            return logs;
-        }
-        /// <summary>
-        /// 删除日志信息
-        /// </summary>
-        /// <param name="value"></param>
-        /// <returns></returns>
-        private static void DeleteLogAsync()
-        {
-            System.Threading.Tasks.Task.Run(() =>
-            {
-                string sql = $"delete from Logs where LogTime < date_add(now(), interval -{ConfigurationManager.AppSettings["KeepLogsPeriod"]} month)";
-                DbCommand cmd = DbAccessManager.DBAccess.CreateCommand(CommandType.Text, sql);
-                DbAccessManager.DBAccess.ExecuteNonQuery(cmd);
-            });
-        }
-        /// <summary>
-        /// 保存新增的日志信息
-        /// </summary>
-        /// <param name="p"></param>
-        /// <returns></returns>
-        public override bool SaveLog(DataAccess.Log p)
-        {
-            if (p == null) throw new ArgumentNullException("p");
-            bool ret = false;
-            string sql = "Insert Into Logs (CRUD, UserName, LogTime, ClientIp, ClientAgent, RequestUrl) Values (@CRUD, @UserName, now(), @ClientIp, @ClientAgent, @RequestUrl)";
-            using (DbCommand cmd = DbAccessManager.DBAccess.CreateCommand(CommandType.Text, sql))
-            {
-                cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@CRUD", p.CRUD));
-                cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@UserName", p.UserName));
-                cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@ClientIp", p.ClientIp));
-                cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@ClientAgent", p.ClientAgent));
-                cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@RequestUrl", p.RequestUrl));
-                ret = DbAccessManager.DBAccess.ExecuteNonQuery(cmd) == 1;
-            }
-            DeleteLogAsync();
-            return ret;
-        }
     }
 }

Bootstrap.DataAccess.SQLite/Log.cs

@@ -1,80 +1,10 @@
-using Longbow;
+namespace Bootstrap.DataAccess.SQLite
-using Longbow.Configuration;
-using System;
-using System.Collections.Generic;
-using System.Data;
-using System.Data.Common;
-
-namespace Bootstrap.DataAccess.SQLite
 {
     /// <summary>
     /// 
     /// </summary>
     public class Log : DataAccess.Log
     {
-        /// <summary>
+
-        /// 查询所有日志信息
-        /// </summary>
-        /// <param name="tId"></param>
-        /// <returns></returns>
-        public override IEnumerable<DataAccess.Log> RetrieveLogs()
-        {
-            string sql = "select * from Logs where LogTime > datetime('now', 'localtime', '-7 day')";
-            List<DataAccess.Log> logs = new List<DataAccess.Log>();
-            DbCommand cmd = DbAccessManager.DBAccess.CreateCommand(CommandType.Text, sql);
-            using (DbDataReader reader = DbAccessManager.DBAccess.ExecuteReader(cmd))
-            {
-                while (reader.Read())
-                {
-                    logs.Add(new DataAccess.Log()
-                    {
-                        Id = reader[0].ToString(),
-                        CRUD = (string)reader[1],
-                        UserName = (string)reader[2],
-                        LogTime = LgbConvert.ReadValue(reader[3], DateTime.MinValue),
-                        ClientIp = (string)reader[4],
-                        ClientAgent = (string)reader[5],
-                        RequestUrl = (string)reader[6]
-                    });
-                }
-            }
-            return logs;
-        }
-        /// <summary>
-        /// 删除日志信息
-        /// </summary>
-        /// <param name="value"></param>
-        /// <returns></returns>
-        private static void DeleteLogAsync()
-        {
-            System.Threading.Tasks.Task.Run(() =>
-            {
-                string sql = $"delete from Logs where LogTime < datetime('now', 'localtime', '-{ConfigurationManager.AppSettings["KeepLogsPeriod"]} month')";
-                DbCommand cmd = DbAccessManager.DBAccess.CreateCommand(CommandType.Text, sql);
-                DbAccessManager.DBAccess.ExecuteNonQuery(cmd);
-            });
-        }
-        /// <summary>
-        /// 保存新增的日志信息
-        /// </summary>
-        /// <param name="p"></param>
-        /// <returns></returns>
-        public override bool SaveLog(DataAccess.Log p)
-        {
-            if (p == null) throw new ArgumentNullException("p");
-            bool ret = false;
-            string sql = "Insert Into Logs (CRUD, UserName, LogTime, ClientIp, ClientAgent, RequestUrl) Values (@CRUD, @UserName, datetime('now', 'localtime'), @ClientIp, @ClientAgent, @RequestUrl)";
-            using (DbCommand cmd = DbAccessManager.DBAccess.CreateCommand(CommandType.Text, sql))
-            {
-                cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@CRUD", p.CRUD));
-                cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@UserName", p.UserName));
-                cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@ClientIp", p.ClientIp));
-                cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@ClientAgent", p.ClientAgent));
-                cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@RequestUrl", p.RequestUrl));
-                ret = DbAccessManager.DBAccess.ExecuteNonQuery(cmd) == 1;
-            }
-            DeleteLogAsync();
-            return ret;
-        }
     }
 }

Bootstrap.DataAccess/Log.cs

@@ -1,4 +1,5 @@
-using Longbow.Configuration;
+using Longbow;
+using Longbow.Configuration;
 using System;
 using System.Collections.Generic;
 using System.Data;
@@ -52,9 +53,10 @@ namespace Bootstrap.DataAccess
         /// <returns></returns>
         public virtual IEnumerable<Log> RetrieveLogs()
         {
-            string sql = "select * from Logs where DATEDIFF(Week, LogTime, GETDATE()) = 0";
+            string sql = "select * from Logs where LogTime > @LogTime";
             List<Log> logs = new List<Log>();
             DbCommand cmd = DbAccessManager.DBAccess.CreateCommand(CommandType.Text, sql);
+            cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@LogTime", DateTime.Now.AddDays(-7), DbType.DateTime));
             using (DbDataReader reader = DbAccessManager.DBAccess.ExecuteReader(cmd))
             {
                 while (reader.Read())
@@ -82,8 +84,9 @@ namespace Bootstrap.DataAccess
         {
             System.Threading.Tasks.Task.Run(() =>
             {
-                string sql = $"delete from Logs where LogTime < DATEADD(MONTH, -{ConfigurationManager.AppSettings["KeepLogsPeriod"]}, GETDATE())";
+                string sql = $"delete from Logs where LogTime < @LogTime";
                 DbCommand cmd = DbAccessManager.DBAccess.CreateCommand(CommandType.Text, sql);
+                cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@LogTime", DateTime.Now.AddMonths(0 - LgbConvert.ReadValue(ConfigurationManager.AppSettings["KeepLogsPeriod"], 1)), DbType.DateTime));
                 DbAccessManager.DBAccess.ExecuteNonQuery(cmd);
             });
         }
@@ -94,13 +97,14 @@ namespace Bootstrap.DataAccess
         /// <returns></returns>
         public virtual bool SaveLog(Log p)
         {
-            if (p == null) throw new ArgumentNullException("p");
+            if (p == null) throw new ArgumentNullException(nameof(p));
             bool ret = false;
-            string sql = "Insert Into Logs (CRUD, UserName, LogTime, ClientIp, ClientAgent, RequestUrl) Values (@CRUD, @UserName, GetDate(), @ClientIp, @ClientAgent, @RequestUrl)";
+            string sql = "Insert Into Logs (CRUD, UserName, LogTime, ClientIp, ClientAgent, RequestUrl) Values (@CRUD, @UserName, @LogTime, @ClientIp, @ClientAgent, @RequestUrl)";
             using (DbCommand cmd = DbAccessManager.DBAccess.CreateCommand(CommandType.Text, sql))
             {
                 cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@CRUD", p.CRUD));
                 cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@UserName", p.UserName));
+                cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@LogTime", DateTime.Now));
                 cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@ClientIp", p.ClientIp));
                 cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@ClientAgent", p.ClientAgent));
                 cmd.Parameters.Add(DbAccessManager.DBAccess.CreateParameter("@RequestUrl", p.RequestUrl));