2009-12-10 00:57:23 +08:00
|
|
|
from django.conf import settings
|
|
|
|
from django.contrib.messages import constants
|
|
|
|
from django.contrib.messages.storage.base import BaseStorage, Message
|
2011-01-25 04:35:46 +08:00
|
|
|
from django.http import SimpleCookie
|
2009-12-10 00:57:23 +08:00
|
|
|
from django.utils import simplejson as json
|
Fixed #14445 - Use HMAC and constant-time comparison functions where needed.
All adhoc MAC applications have been updated to use HMAC, using SHA1 to
generate unique keys for each application based on the SECRET_KEY, which is
common practice for this situation. In all cases, backwards compatibility
with existing hashes has been maintained, aiming to phase this out as per
the normal deprecation process. In this way, under most normal
circumstances the old hashes will have expired (e.g. by session expiration
etc.) before they become invalid.
In the case of the messages framework and the cookie backend, which was
already using HMAC, there is the possibility of a backwards incompatibility
if the SECRET_KEY is shorter than the default 50 bytes, but the low
likelihood and low impact meant compatibility code was not worth it.
All known instances where tokens/hashes were compared using simple string
equality, which could potentially open timing based attacks, have also been
fixed using a constant-time comparison function.
There are no known practical attacks against the existing implementations,
so these security improvements will not be backported.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14218 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-15 04:54:30 +08:00
|
|
|
from django.utils.crypto import salted_hmac, constant_time_compare
|
2009-12-10 00:57:23 +08:00
|
|
|
|
|
|
|
|
|
|
|
class MessageEncoder(json.JSONEncoder):
|
|
|
|
"""
|
|
|
|
Compactly serializes instances of the ``Message`` class as JSON.
|
|
|
|
"""
|
|
|
|
message_key = '__json_message'
|
|
|
|
|
|
|
|
def default(self, obj):
|
|
|
|
if isinstance(obj, Message):
|
|
|
|
message = [self.message_key, obj.level, obj.message]
|
|
|
|
if obj.extra_tags:
|
|
|
|
message.append(obj.extra_tags)
|
|
|
|
return message
|
|
|
|
return super(MessageEncoder, self).default(obj)
|
|
|
|
|
|
|
|
|
|
|
|
class MessageDecoder(json.JSONDecoder):
|
|
|
|
"""
|
|
|
|
Decodes JSON that includes serialized ``Message`` instances.
|
|
|
|
"""
|
|
|
|
|
|
|
|
def process_messages(self, obj):
|
|
|
|
if isinstance(obj, list) and obj:
|
|
|
|
if obj[0] == MessageEncoder.message_key:
|
|
|
|
return Message(*obj[1:])
|
|
|
|
return [self.process_messages(item) for item in obj]
|
|
|
|
if isinstance(obj, dict):
|
|
|
|
return dict([(key, self.process_messages(value))
|
|
|
|
for key, value in obj.iteritems()])
|
|
|
|
return obj
|
|
|
|
|
|
|
|
def decode(self, s, **kwargs):
|
|
|
|
decoded = super(MessageDecoder, self).decode(s, **kwargs)
|
|
|
|
return self.process_messages(decoded)
|
|
|
|
|
|
|
|
class CookieStorage(BaseStorage):
|
|
|
|
"""
|
|
|
|
Stores messages in a cookie.
|
|
|
|
"""
|
|
|
|
cookie_name = 'messages'
|
2010-01-24 08:04:02 +08:00
|
|
|
# We should be able to store 4K in a cookie, but Internet Explorer
|
|
|
|
# imposes 4K as the *total* limit for a domain. To allow other
|
|
|
|
# cookies, we go for 3/4 of 4K.
|
|
|
|
max_cookie_size = 3072
|
2009-12-10 00:57:23 +08:00
|
|
|
not_finished = '__messagesnotfinished__'
|
|
|
|
|
|
|
|
def _get(self, *args, **kwargs):
|
|
|
|
"""
|
|
|
|
Retrieves a list of messages from the messages cookie. If the
|
|
|
|
not_finished sentinel value is found at the end of the message list,
|
|
|
|
remove it and return a result indicating that not all messages were
|
|
|
|
retrieved by this storage.
|
|
|
|
"""
|
|
|
|
data = self.request.COOKIES.get(self.cookie_name)
|
|
|
|
messages = self._decode(data)
|
|
|
|
all_retrieved = not (messages and messages[-1] == self.not_finished)
|
|
|
|
if messages and not all_retrieved:
|
|
|
|
# remove the sentinel value
|
|
|
|
messages.pop()
|
|
|
|
return messages, all_retrieved
|
|
|
|
|
|
|
|
def _update_cookie(self, encoded_data, response):
|
|
|
|
"""
|
|
|
|
Either sets the cookie with the encoded data if there is any data to
|
|
|
|
store, or deletes the cookie.
|
|
|
|
"""
|
|
|
|
if encoded_data:
|
2011-03-16 11:50:51 +08:00
|
|
|
response.set_cookie(self.cookie_name, encoded_data,
|
|
|
|
domain=settings.SESSION_COOKIE_DOMAIN)
|
2009-12-10 00:57:23 +08:00
|
|
|
else:
|
2011-03-20 19:27:03 +08:00
|
|
|
response.delete_cookie(self.cookie_name,
|
|
|
|
domain=settings.SESSION_COOKIE_DOMAIN)
|
2009-12-10 00:57:23 +08:00
|
|
|
|
|
|
|
def _store(self, messages, response, remove_oldest=True, *args, **kwargs):
|
|
|
|
"""
|
|
|
|
Stores the messages to a cookie, returning a list of any messages which
|
|
|
|
could not be stored.
|
|
|
|
|
|
|
|
If the encoded data is larger than ``max_cookie_size``, removes
|
|
|
|
messages until the data fits (these are the messages which are
|
|
|
|
returned), and add the not_finished sentinel value to indicate as much.
|
|
|
|
"""
|
|
|
|
unstored_messages = []
|
|
|
|
encoded_data = self._encode(messages)
|
|
|
|
if self.max_cookie_size:
|
2011-01-25 04:35:46 +08:00
|
|
|
# data is going to be stored eventually by SimpleCookie, which
|
2010-01-24 07:56:04 +08:00
|
|
|
# adds it's own overhead, which we must account for.
|
2011-01-25 04:35:46 +08:00
|
|
|
cookie = SimpleCookie() # create outside the loop
|
2010-01-24 07:56:04 +08:00
|
|
|
def stored_length(val):
|
2010-01-26 02:14:30 +08:00
|
|
|
return len(cookie.value_encode(val)[1])
|
2010-01-24 07:56:04 +08:00
|
|
|
|
|
|
|
while encoded_data and stored_length(encoded_data) > self.max_cookie_size:
|
2009-12-10 00:57:23 +08:00
|
|
|
if remove_oldest:
|
|
|
|
unstored_messages.append(messages.pop(0))
|
|
|
|
else:
|
|
|
|
unstored_messages.insert(0, messages.pop())
|
|
|
|
encoded_data = self._encode(messages + [self.not_finished],
|
|
|
|
encode_empty=unstored_messages)
|
|
|
|
self._update_cookie(encoded_data, response)
|
|
|
|
return unstored_messages
|
|
|
|
|
|
|
|
def _hash(self, value):
|
|
|
|
"""
|
|
|
|
Creates an HMAC/SHA1 hash based on the value and the project setting's
|
|
|
|
SECRET_KEY, modified to make it unique for the present purpose.
|
|
|
|
"""
|
Fixed #14445 - Use HMAC and constant-time comparison functions where needed.
All adhoc MAC applications have been updated to use HMAC, using SHA1 to
generate unique keys for each application based on the SECRET_KEY, which is
common practice for this situation. In all cases, backwards compatibility
with existing hashes has been maintained, aiming to phase this out as per
the normal deprecation process. In this way, under most normal
circumstances the old hashes will have expired (e.g. by session expiration
etc.) before they become invalid.
In the case of the messages framework and the cookie backend, which was
already using HMAC, there is the possibility of a backwards incompatibility
if the SECRET_KEY is shorter than the default 50 bytes, but the low
likelihood and low impact meant compatibility code was not worth it.
All known instances where tokens/hashes were compared using simple string
equality, which could potentially open timing based attacks, have also been
fixed using a constant-time comparison function.
There are no known practical attacks against the existing implementations,
so these security improvements will not be backported.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14218 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-15 04:54:30 +08:00
|
|
|
key_salt = 'django.contrib.messages'
|
|
|
|
return salted_hmac(key_salt, value).hexdigest()
|
2009-12-10 00:57:23 +08:00
|
|
|
|
|
|
|
def _encode(self, messages, encode_empty=False):
|
|
|
|
"""
|
|
|
|
Returns an encoded version of the messages list which can be stored as
|
|
|
|
plain text.
|
|
|
|
|
|
|
|
Since the data will be retrieved from the client-side, the encoded data
|
|
|
|
also contains a hash to ensure that the data was not tampered with.
|
|
|
|
"""
|
|
|
|
if messages or encode_empty:
|
|
|
|
encoder = MessageEncoder(separators=(',', ':'))
|
|
|
|
value = encoder.encode(messages)
|
|
|
|
return '%s$%s' % (self._hash(value), value)
|
|
|
|
|
|
|
|
def _decode(self, data):
|
|
|
|
"""
|
|
|
|
Safely decodes a encoded text stream back into a list of messages.
|
|
|
|
|
|
|
|
If the encoded text stream contained an invalid hash or was in an
|
|
|
|
invalid format, ``None`` is returned.
|
|
|
|
"""
|
|
|
|
if not data:
|
|
|
|
return None
|
|
|
|
bits = data.split('$', 1)
|
|
|
|
if len(bits) == 2:
|
|
|
|
hash, value = bits
|
Fixed #14445 - Use HMAC and constant-time comparison functions where needed.
All adhoc MAC applications have been updated to use HMAC, using SHA1 to
generate unique keys for each application based on the SECRET_KEY, which is
common practice for this situation. In all cases, backwards compatibility
with existing hashes has been maintained, aiming to phase this out as per
the normal deprecation process. In this way, under most normal
circumstances the old hashes will have expired (e.g. by session expiration
etc.) before they become invalid.
In the case of the messages framework and the cookie backend, which was
already using HMAC, there is the possibility of a backwards incompatibility
if the SECRET_KEY is shorter than the default 50 bytes, but the low
likelihood and low impact meant compatibility code was not worth it.
All known instances where tokens/hashes were compared using simple string
equality, which could potentially open timing based attacks, have also been
fixed using a constant-time comparison function.
There are no known practical attacks against the existing implementations,
so these security improvements will not be backported.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14218 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-15 04:54:30 +08:00
|
|
|
if constant_time_compare(hash, self._hash(value)):
|
2009-12-10 00:57:23 +08:00
|
|
|
try:
|
|
|
|
# If we get here (and the JSON decode works), everything is
|
|
|
|
# good. In any other case, drop back and return None.
|
|
|
|
return json.loads(value, cls=MessageDecoder)
|
|
|
|
except ValueError:
|
|
|
|
pass
|
|
|
|
# Mark the data as used (so it gets removed) since something was wrong
|
|
|
|
# with the data.
|
|
|
|
self.used = True
|
|
|
|
return None
|