From b6f4a92ff45d98a63dc29402d8ad86b88e6a6697 Mon Sep 17 00:00:00 2001 From: Tomek Paczkowski Date: Sat, 23 Feb 2013 19:01:38 +0100 Subject: [PATCH] Proposed fix for #18162. --- django/db/models/fields/__init__.py | 7 +++++-- tests/regressiontests/model_fields/tests.py | 10 ++++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/django/db/models/fields/__init__.py b/django/db/models/fields/__init__.py index b70d235656..279c712a98 100644 --- a/django/db/models/fields/__init__.py +++ b/django/db/models/fields/__init__.py @@ -467,7 +467,7 @@ class Field(object): def save_form_data(self, instance, data): setattr(instance, self.name, data) - def formfield(self, form_class=forms.CharField, **kwargs): + def formfield(self, form_class=None, **kwargs): """ Returns a django.forms.Field instance for this database Field. """ @@ -488,7 +488,8 @@ class Field(object): defaults['coerce'] = self.to_python if self.null: defaults['empty_value'] = None - form_class = forms.TypedChoiceField + if form_class is None or not issubclass(form_class, forms.TypedChoiceField): + form_class = forms.TypedChoiceField # Many of the subclass-specific formfield arguments (min_value, # max_value) don't apply for choice fields, so be sure to only pass # the values that TypedChoiceField will understand. @@ -498,6 +499,8 @@ class Field(object): 'error_messages', 'show_hidden_initial'): del kwargs[k] defaults.update(kwargs) + if form_class is None: + form_class = forms.CharField return form_class(**defaults) def value_from_object(self, obj): diff --git a/tests/regressiontests/model_fields/tests.py b/tests/regressiontests/model_fields/tests.py index a49894e36c..8c596ed4f5 100644 --- a/tests/regressiontests/model_fields/tests.py +++ b/tests/regressiontests/model_fields/tests.py @@ -73,6 +73,16 @@ class BasicFieldTests(test.TestCase): self.assertEqual(m._meta.get_field('id').verbose_name, 'verbose pk') + def test_formclass_with_choices(self): + # regression for 18162 + class CustomChoiceField(forms.TypedChoiceField): + pass + choices = [('a@b.cc', 'a@b.cc'), ('b@b.cc', 'b@b.cc')] + field = models.CharField(choices=choices) + klass = CustomChoiceField + self.assertIsInstance(field.formfield(form_class=klass), klass) + + class DecimalFieldTests(test.TestCase): def test_to_python(self): f = models.DecimalField(max_digits=4, decimal_places=2)