Fixed a problem when computing deferred fields on multiple related models.

Fixed #10710, as this fixes the second bug reported there.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@10384 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Malcolm Tredinnick 2009-04-04 05:35:01 +00:00
parent 0a89a57ffc
commit 2b1934ff3c
2 changed files with 7 additions and 3 deletions

View File

@ -574,12 +574,13 @@ class BaseQuery(object):
if not field_names: if not field_names:
return return
columns = set() columns = set()
cur_model = self.model orig_opts = self.model._meta
opts = cur_model._meta
seen = {} seen = {}
must_include = {cur_model: set([opts.pk])} must_include = {self.model: set([orig_opts.pk])}
for field_name in field_names: for field_name in field_names:
parts = field_name.split(LOOKUP_SEP) parts = field_name.split(LOOKUP_SEP)
cur_model = self.model
opts = orig_opts
for name in parts[:-1]: for name in parts[:-1]:
old_model = cur_model old_model = cur_model
source = opts.get_field_by_name(name)[0] source = opts.get_field_by_name(name)[0]

View File

@ -24,6 +24,7 @@ class Child(models.Model):
class Leaf(models.Model): class Leaf(models.Model):
name = models.CharField(max_length=10) name = models.CharField(max_length=10)
child = models.ForeignKey(Child) child = models.ForeignKey(Child)
second_child = models.ForeignKey(Child, related_name="other", null=True)
value = models.IntegerField(default=42) value = models.IntegerField(default=42)
def __unicode__(self): def __unicode__(self):
@ -87,6 +88,8 @@ Some further checks for select_related() and inherited model behaviour
>>> obj = Leaf.objects.only("name", "child").select_related()[0] >>> obj = Leaf.objects.only("name", "child").select_related()[0]
>>> obj.child.name >>> obj.child.name
u'c1' u'c1'
>>> Leaf.objects.select_related().only("child__name", "second_child__name")
[<Leaf_Deferred_name_value: l1>]
""" """
} }