Fixed #33080 -- Preserved nullability of textual fields on Oracle.

Thanks Matt Hoskins for the report.
This commit is contained in:
Mariusz Felisiak 2021-09-01 13:26:46 +02:00
parent f65eb46646
commit 338fc0e7f1
2 changed files with 25 additions and 2 deletions

View File

@ -880,8 +880,10 @@ class BaseDatabaseSchemaEditor:
Return a (sql, params) fragment to set a column to null or non-null Return a (sql, params) fragment to set a column to null or non-null
as required by new_field, or None if no changes are required. as required by new_field, or None if no changes are required.
""" """
if (self.connection.features.interprets_empty_strings_as_nulls and if (
new_field.get_internal_type() in ("CharField", "TextField")): self.connection.features.interprets_empty_strings_as_nulls and
new_field.empty_strings_allowed
):
# The field is nullable in the database anyway, leave it alone. # The field is nullable in the database anyway, leave it alone.
return return
else: else:

View File

@ -863,6 +863,27 @@ class SchemaTests(TransactionTestCase):
with self.assertRaises(IntegrityError): with self.assertRaises(IntegrityError):
Note.objects.create(info=None) Note.objects.create(info=None)
@skipUnlessDBFeature('interprets_empty_strings_as_nulls')
def test_alter_textual_field_not_null_to_null(self):
"""
Nullability for textual fields is preserved on databases that
interpret empty strings as NULLs.
"""
with connection.schema_editor() as editor:
editor.create_model(Author)
columns = self.column_classes(Author)
# Field is nullable.
self.assertTrue(columns['uuid'][1][6])
# Change to NOT NULL.
old_field = Author._meta.get_field('uuid')
new_field = SlugField(null=False, blank=True)
new_field.set_attributes_from_name('uuid')
with connection.schema_editor() as editor:
editor.alter_field(Author, old_field, new_field, strict=True)
columns = self.column_classes(Author)
# Nullability is preserved.
self.assertTrue(columns['uuid'][1][6])
def test_alter_numeric_field_keep_null_status(self): def test_alter_numeric_field_keep_null_status(self):
""" """
Changing a field type shouldn't affect the not null status. Changing a field type shouldn't affect the not null status.