innov
/
django1
1
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

Added tests for incorrect content type and size in MultiPartParser.

This commit is contained in:
Mads Jensen 2018-06-12 20:42:20 +02:00 committed by Tim Graham
parent 9e4f26bb40
commit 4167959105
1 changed files with 25 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
tests/file_uploads/tests.py
View File

@ -10,7 +10,9 @@ from urllib.parse import quote
from django.core.files import temp as tempfile from django.core.files import temp as tempfile
from django.core.files.uploadedfile import SimpleUploadedFile from django.core.files.uploadedfile import SimpleUploadedFile
from django.http.multipartparser import MultiPartParser, parse_header from django.http.multipartparser import (
MultiPartParser, MultiPartParserError, parse_header,
)
from django.test import SimpleTestCase, TestCase, client, override_settings from django.test import SimpleTestCase, TestCase, client, override_settings
from . import uploadhandler from . import uploadhandler
@ -558,7 +560,7 @@ class DirectoryCreationTests(SimpleTestCase):
self.assertEqual(exc_info.exception.args[0], "%s exists and is not a directory." % UPLOAD_TO) self.assertEqual(exc_info.exception.args[0], "%s exists and is not a directory." % UPLOAD_TO)
class MultiParserTests(unittest.TestCase): class MultiParserTests(SimpleTestCase):
def test_empty_upload_handlers(self): def test_empty_upload_handlers(self):
# We're not actually parsing here; just checking if the parser properly # We're not actually parsing here; just checking if the parser properly
@ -568,6 +570,27 @@ class MultiParserTests(unittest.TestCase):
'CONTENT_LENGTH': '1' 'CONTENT_LENGTH': '1'
}, StringIO('x'), [], 'utf-8') }, StringIO('x'), [], 'utf-8')
def test_invalid_content_type(self):
with self.assertRaisesMessage(MultiPartParserError, 'Invalid Content-Type: text/plain'):
MultiPartParser({
'CONTENT_TYPE': 'text/plain',
'CONTENT_LENGTH': '1',
}, StringIO('x'), [], 'utf-8')
def test_negative_content_length(self):
with self.assertRaisesMessage(MultiPartParserError, 'Invalid content length: -1'):
MultiPartParser({
'CONTENT_TYPE': 'multipart/form-data; boundary=_foo',
'CONTENT_LENGTH': -1,
}, StringIO('x'), [], 'utf-8')
def test_bad_type_content_length(self):
multipart_parser = MultiPartParser({
'CONTENT_TYPE': 'multipart/form-data; boundary=_foo',
'CONTENT_LENGTH': 'a',
}, StringIO('x'), [], 'utf-8')
self.assertEqual(multipart_parser._content_length, 0)
def test_rfc2231_parsing(self): def test_rfc2231_parsing(self):
test_data = ( test_data = (
(b"Content-Type: application/x-stuff; title*=us-ascii'en-us'This%20is%20%2A%2A%2Afun%2A%2A%2A", (b"Content-Type: application/x-stuff; title*=us-ascii'en-us'This%20is%20%2A%2A%2Afun%2A%2A%2A",