From 5875b8d13333bf709b54f91a143304826d57f2fd Mon Sep 17 00:00:00 2001 From: Andrew Godwin Date: Mon, 21 Jul 2014 10:03:51 +0100 Subject: [PATCH] Fixed #23043: alter_field drops defaults too --- django/db/backends/schema.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/django/db/backends/schema.py b/django/db/backends/schema.py index 8fdc3083c9..d4573a4be8 100644 --- a/django/db/backends/schema.py +++ b/django/db/backends/schema.py @@ -766,6 +766,16 @@ class BaseDatabaseSchemaEditor(object): "check": new_db_params['check'], } ) + # Drop the default if we need to + # (Django usually does not use in-database defaults) + if not self.skip_default(new_field) and new_field.default is not None: + sql = self.sql_alter_column % { + "table": self.quote_name(model._meta.db_table), + "changes": self.sql_alter_column_no_default % { + "column": self.quote_name(new_field.column), + } + } + self.execute(sql) # Reset connection if required if self.connection.features.connection_persists_old_columns: self.connection.close()