Fixed #32906 -- Added docs and tests for using key and index lookups on JSONBAgg results.

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
This commit is contained in:
abhiabhi94 2021-07-15 19:09:40 +05:30 committed by Mariusz Felisiak
parent 325d7710ce
commit 5a634a7b6f
2 changed files with 69 additions and 2 deletions

View File

@ -125,7 +125,8 @@ General-purpose aggregation functions
.. class:: JSONBAgg(expressions, distinct=False, filter=None, default=None, ordering=(), **extra) .. class:: JSONBAgg(expressions, distinct=False, filter=None, default=None, ordering=(), **extra)
Returns the input values as a ``JSON`` array, or ``default`` if there are Returns the input values as a ``JSON`` array, or ``default`` if there are
no values. no values. You can query the result using :lookup:`key and index lookups
<jsonfield.key>`.
.. attribute:: distinct .. attribute:: distinct
@ -145,6 +146,29 @@ General-purpose aggregation functions
Examples are the same as for :attr:`ArrayAgg.ordering`. Examples are the same as for :attr:`ArrayAgg.ordering`.
Usage example::
class Room(models.Model):
number = models.IntegerField(unique=True)
class HotelReservation(model.Model):
room = models.ForeignKey('Room', on_delete=models.CASCADE)
start = models.DateTimeField()
end = models.DateTimeField()
requirements = models.JSONField(blank=True, null=True)
>>> from django.contrib.postgres.aggregates import JSONBAgg
>>> Room.objects.annotate(
... requirements=JSONBAgg(
... 'hotelreservation__requirements',
... ordering='-hotelreservation__start',
... )
... ).filter(requirements__0__sea_view=True).values('number', 'requirements')
<QuerySet [{'number': 102, 'requirements': [
{'parking': False, 'sea_view': True, 'double_bed': False},
{'parking': True, 'double_bed': True}
]}]>
.. deprecated:: 4.0 .. deprecated:: 4.0
If there are no rows and ``default`` is not provided, ``JSONBAgg`` If there are no rows and ``default`` is not provided, ``JSONBAgg``

View File

@ -4,10 +4,11 @@ from django.db.models import (
from django.db.models.fields.json import KeyTextTransform, KeyTransform from django.db.models.fields.json import KeyTextTransform, KeyTransform
from django.db.models.functions import Cast, Concat, Substr from django.db.models.functions import Cast, Concat, Substr
from django.test.utils import Approximate, ignore_warnings from django.test.utils import Approximate, ignore_warnings
from django.utils import timezone
from django.utils.deprecation import RemovedInDjango50Warning from django.utils.deprecation import RemovedInDjango50Warning
from . import PostgreSQLTestCase from . import PostgreSQLTestCase
from .models import AggregateTestModel, StatTestModel from .models import AggregateTestModel, HotelReservation, Room, StatTestModel
try: try:
from django.contrib.postgres.aggregates import ( from django.contrib.postgres.aggregates import (
@ -392,6 +393,48 @@ class TestGeneralAggregate(PostgreSQLTestCase):
) )
self.assertEqual(values, {'jsonbagg': ['en', 'pl']}) self.assertEqual(values, {'jsonbagg': ['en', 'pl']})
def test_jsonb_agg_key_index_transforms(self):
room101 = Room.objects.create(number=101)
room102 = Room.objects.create(number=102)
datetimes = [
timezone.datetime(2018, 6, 20),
timezone.datetime(2018, 6, 24),
timezone.datetime(2018, 6, 28),
]
HotelReservation.objects.create(
datespan=(datetimes[0].date(), datetimes[1].date()),
start=datetimes[0],
end=datetimes[1],
room=room102,
requirements={'double_bed': True, 'parking': True},
)
HotelReservation.objects.create(
datespan=(datetimes[1].date(), datetimes[2].date()),
start=datetimes[1],
end=datetimes[2],
room=room102,
requirements={'double_bed': False, 'sea_view': True, 'parking': False},
)
HotelReservation.objects.create(
datespan=(datetimes[0].date(), datetimes[2].date()),
start=datetimes[0],
end=datetimes[2],
room=room101,
requirements={'sea_view': False},
)
values = Room.objects.annotate(
requirements=JSONBAgg(
'hotelreservation__requirements',
ordering='-hotelreservation__start',
)
).filter(requirements__0__sea_view=True).values('number', 'requirements')
self.assertSequenceEqual(values, [
{'number': 102, 'requirements': [
{'double_bed': False, 'sea_view': True, 'parking': False},
{'double_bed': True, 'parking': True},
]},
])
def test_string_agg_array_agg_ordering_in_subquery(self): def test_string_agg_array_agg_ordering_in_subquery(self):
stats = [] stats = []
for i, agg in enumerate(AggregateTestModel.objects.order_by('char_field')): for i, agg in enumerate(AggregateTestModel.objects.order_by('char_field')):