innov
/
django1
1
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

Cleaned up session backends tests. 

Made SessionTestsMixin backend agnostic and removed code obsoleted by the test
discovery refactor.
This commit is contained in:
Simon Charette 2016-02-25 20:04:03 -05:00
parent 8890c533e0
commit 62ea86448e
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/sessions_tests/tests.py
View File

@ -149,9 +149,6 @@ class SessionTestsMixin(object):
self.assertTrue(self.session.modified) self.assertTrue(self.session.modified)
def test_save(self): def test_save(self):
if (hasattr(self.session, '_cache') and 'DummyCache' in
settings.CACHES[settings.SESSION_CACHE_ALIAS]['BACKEND']):
raise unittest.SkipTest("Session saving tests require a real cache backend")
self.session.save() self.session.save()
self.assertTrue(self.session.exists(self.session.session_key)) self.assertTrue(self.session.exists(self.session.session_key))
@ -345,8 +342,6 @@ class SessionTestsMixin(object):
Creating session records on load is a DOS vulnerability. Creating session records on load is a DOS vulnerability.
""" """
if self.backend is CookieSession:
raise unittest.SkipTest("Cookie backend doesn't have an external store to create records in.")
session = self.backend('someunknownkey') session = self.backend('someunknownkey')
session.load() session.load()
@ -458,9 +453,6 @@ class CacheDBSessionTests(SessionTestsMixin, TestCase):
backend = CacheDBSession backend = CacheDBSession
@unittest.skipIf('DummyCache' in
settings.CACHES[settings.SESSION_CACHE_ALIAS]['BACKEND'],
"Session saving tests require a real cache backend")
def test_exists_searches_cache_first(self): def test_exists_searches_cache_first(self):
self.session.save() self.session.save()
with self.assertNumQueries(0): with self.assertNumQueries(0):
@ -812,3 +804,7 @@ class CookieSessionTests(SessionTestsMixin, unittest.TestCase):
self.session.serializer = PickleSerializer self.session.serializer = PickleSerializer
self.session.load() self.session.load()
@unittest.skip("Cookie backend doesn't have an external store to create records in.")
def test_session_load_does_not_create_record(self):
pass