From 7b159df94235036a41ee93952ff83bbc95c1da3c Mon Sep 17 00:00:00 2001 From: Mariusz Felisiak Date: Tue, 18 Sep 2018 21:58:20 +0200 Subject: [PATCH] Fixed expressions tests when run in reverse. Regression in e7a0a5c8b21f5ad1a0066bd0dfab84466b474e15. --- tests/expressions/tests.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tests/expressions/tests.py b/tests/expressions/tests.py index c74ff8f30d..c631151448 100644 --- a/tests/expressions/tests.py +++ b/tests/expressions/tests.py @@ -273,18 +273,17 @@ class BasicExpressionsTests(TestCase): def test_object_update_fk(self): # F expressions cannot be used to update attributes which are foreign # keys, or attributes which involve joins. - def test(): - self.gmbh.point_of_contact = F('ceo') + test_gmbh = Company.objects.get(pk=self.gmbh.pk) msg = 'F(ceo)": "Company.point_of_contact" must be a "Employee" instance.' with self.assertRaisesMessage(ValueError, msg): - test() + test_gmbh.point_of_contact = F('ceo') - self.gmbh.point_of_contact = self.gmbh.ceo - self.gmbh.save() - self.gmbh.name = F('ceo__last_name') + test_gmbh.point_of_contact = self.gmbh.ceo + test_gmbh.save() + test_gmbh.name = F('ceo__last_name') msg = 'Joined field references are not permitted in this query' with self.assertRaisesMessage(FieldError, msg): - self.gmbh.save() + test_gmbh.save() def test_object_update_unsaved_objects(self): # F expressions cannot be used to update attributes on objects which do