innov
/
django1
1
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

Removed unreachable SystemExit check. 

This check dates back to Python <2.5, before Python introduced
BaseException to prevent exactly unwarranted catching of SystemExit
(and others).

response_for_exception() is only called under `except Exception` or
`except Http404` so it's now impossible for a SystemExit instance to
reach the branch.
This commit is contained in:
Adam Johnson 2021-01-19 06:04:53 +00:00 committed by GitHub
parent 6b01511f04
commit 8c7ff7b8cf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
django/core/handlers/exception.py
View File

@ -105,10 +105,6 @@ def response_for_exception(request, exc):
else: else:
response = get_exception_response(request, get_resolver(get_urlconf()), 400, exc) response = get_exception_response(request, get_resolver(get_urlconf()), 400, exc)
elif isinstance(exc, SystemExit):
# Allow sys.exit() to actually exit. See tickets #1023 and #4701
raise
else: else:
signals.got_request_exception.send(sender=None, request=request) signals.got_request_exception.send(sender=None, request=request)
response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info()) response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())