Fixed #26283 -- Fixed removal of trailing nulls for SplitArrayField.

This commit is contained in:
quaspas 2016-03-12 16:44:39 -05:00 committed by Tim Graham
parent ab8af342b1
commit 91f87b8f91
2 changed files with 15 additions and 1 deletions

View File

@ -183,7 +183,7 @@ class SplitArrayField(forms.Field):
null_index = i
else:
break
if null_index:
if null_index is not None:
cleaned_data = cleaned_data[:null_index]
errors = errors[:null_index]
errors = list(filter(None, errors))

View File

@ -663,6 +663,20 @@ class TestSplitFormField(PostgreSQLTestCase):
self.assertTrue(form.is_valid(), form.errors)
self.assertEqual(form.cleaned_data, {'array': ['a', '', 'b']})
def test_remove_trailing_nulls_not_required(self):
class SplitForm(forms.Form):
array = SplitArrayField(
forms.CharField(required=False),
size=2,
remove_trailing_nulls=True,
required=False,
)
data = {'array_0': '', 'array_1': ''}
form = SplitForm(data)
self.assertTrue(form.is_valid())
self.assertEqual(form.cleaned_data, {'array': []})
def test_required_field(self):
class SplitForm(forms.Form):
array = SplitArrayField(forms.CharField(), size=3)