innov
/
django1
1
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

Improved the way Model.save() skips the auto_field. 

Identity comparison is quicker than isinstance(), and it avoids coupling
between Model and AutoField.
This commit is contained in:
Adam Chainz 2016-11-24 11:01:36 +00:00 committed by Tim Graham
parent f095b249ba
commit 92bbef8b9e
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
django/db/models/base.py
View File

@ -19,7 +19,6 @@ from django.db import (
from django.db.models import signals from django.db.models import signals
from django.db.models.constants import LOOKUP_SEP from django.db.models.constants import LOOKUP_SEP
from django.db.models.deletion import CASCADE, Collector from django.db.models.deletion import CASCADE, Collector
from django.db.models.fields import AutoField
from django.db.models.fields.related import ( from django.db.models.fields.related import (
ForeignObjectRel, OneToOneField, lazy_related_operation, resolve_relation, ForeignObjectRel, OneToOneField, lazy_related_operation, resolve_relation,
) )
@ -899,7 +898,7 @@ class Model(six.with_metaclass(ModelBase)):
fields = meta.local_concrete_fields fields = meta.local_concrete_fields
if not pk_set: if not pk_set:
fields = [f for f in fields if not isinstance(f, AutoField)] fields = [f for f in fields if f is not meta.auto_field]
update_pk = bool(meta.has_auto_field and not pk_set) update_pk = bool(meta.has_auto_field and not pk_set)
result = self._do_insert(cls._base_manager, using, fields, update_pk, raw) result = self._do_insert(cls._base_manager, using, fields, update_pk, raw)