innov
/
django1
1
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

Refs #31617 -- Removed redundant title text in filter.html. 

Unnecessary since 269a767146.

Title text should provide advisory information and should not be the
same or very similar to the element text.
This commit is contained in:
David Smith 2021-12-28 12:42:35 +00:00 committed by GitHub
parent feeb0685c6
commit 950d697b95
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django/contrib/admin/templates/admin/filter.html
View File

@ -3,6 +3,6 @@
<ul> <ul>
{% for choice in choices %} {% for choice in choices %}
<li{% if choice.selected %} class="selected"{% endif %}> <li{% if choice.selected %} class="selected"{% endif %}>
<a href="{{ choice.query_string|iriencode }}" title="{{ choice.display }}">{{ choice.display }}</a></li> <a href="{{ choice.query_string|iriencode }}">{{ choice.display }}</a></li>
{% endfor %} {% endfor %}
</ul> </ul>

4
tests/admin_views/tests.py
View File

@ -753,11 +753,11 @@ class AdminViewBasicTest(AdminViewBasicTestCase):
) )
self.assertContains(response, '<div id="changelist-filter">') self.assertContains(response, '<div id="changelist-filter">')
self.assertContains( self.assertContains(
response, '<a href="?surface__exact=x" title="Horizontal">Horizontal</a>', response, '<a href="?surface__exact=x">Horizontal</a>',
msg_prefix=fail_msg, html=True msg_prefix=fail_msg, html=True
) )
self.assertContains( self.assertContains(
response, '<a href="?surface__exact=y" title="Vertical">Vertical</a>', response, '<a href="?surface__exact=y">Vertical</a>',
msg_prefix=fail_msg, html=True msg_prefix=fail_msg, html=True
) )