diff --git a/django/forms/models.py b/django/forms/models.py index ff20c936cb..30f1e2838c 100644 --- a/django/forms/models.py +++ b/django/forms/models.py @@ -159,7 +159,7 @@ def model_to_dict(instance, fields=None, exclude=None): data[f.name] = f.value_from_object(instance) return data -def fields_for_model(model, fields=None, exclude=None, formfield_callback=lambda f: f.formfield()): +def fields_for_model(model, fields=None, exclude=None, widgets=None, formfield_callback=lambda f, **kwargs: f.formfield(**kwargs)): """ Returns a ``SortedDict`` containing form fields for the given model. @@ -179,7 +179,11 @@ def fields_for_model(model, fields=None, exclude=None, formfield_callback=lambda continue if exclude and f.name in exclude: continue - formfield = formfield_callback(f) + if widgets and f.name in widgets: + kwargs = {'widget': widgets[f.name]} + else: + kwargs = {} + formfield = formfield_callback(f, **kwargs) if formfield: field_list.append((f.name, formfield)) field_dict = SortedDict(field_list) @@ -192,12 +196,13 @@ class ModelFormOptions(object): self.model = getattr(options, 'model', None) self.fields = getattr(options, 'fields', None) self.exclude = getattr(options, 'exclude', None) + self.widgets = getattr(options, 'widgets', None) class ModelFormMetaclass(type): def __new__(cls, name, bases, attrs): formfield_callback = attrs.pop('formfield_callback', - lambda f: f.formfield()) + lambda f, **kwargs: f.formfield(**kwargs)) try: parents = [b for b in bases if issubclass(b, ModelForm)] except NameError: @@ -215,7 +220,7 @@ class ModelFormMetaclass(type): if opts.model: # If a model is defined, extract form fields from it. fields = fields_for_model(opts.model, opts.fields, - opts.exclude, formfield_callback) + opts.exclude, opts.widgets, formfield_callback) # Override default model fields with any custom declared ones # (plus, include all the other declared fields). fields.update(declared_fields) diff --git a/docs/topics/forms/modelforms.txt b/docs/topics/forms/modelforms.txt index 7049464f86..e1a90262d9 100644 --- a/docs/topics/forms/modelforms.txt +++ b/docs/topics/forms/modelforms.txt @@ -146,7 +146,7 @@ In addition, each generated form field has attributes set as follows: ``default`` value will be initially selected instead). Finally, note that you can override the form field used for a given model -field. See `Overriding the default field types`_ below. +field. See `Overriding the default field types or widgets`_ below. A full example -------------- @@ -350,31 +350,53 @@ Since the Author model has only 3 fields, 'name', 'title', and .. _section on saving forms: `The save() method`_ -Overriding the default field types ----------------------------------- +Overriding the default field types or widgets +--------------------------------------------- The default field types, as described in the `Field types`_ table above, are sensible defaults. If you have a ``DateField`` in your model, chances are you'd want that to be represented as a ``DateField`` in your form. But -``ModelForm`` gives you the flexibility of changing the form field type -for a given model field. You do this by declaratively specifying fields like -you would in a regular ``Form``. Declared fields will override the default -ones generated by using the ``model`` attribute. +``ModelForm`` gives you the flexibility of changing the form field type and +widget for a given model field. + +To specify a custom widget for a field, use the ``widgets`` attribute of the +inner ``Meta`` class. This should be a dictionary mapping field names to widget +classes or instances. + +For example, if you want the a ``CharField`` to be represented by a +``' + +>>> str(CategoryForm()['url']) +'' + +>>> str(CategoryForm()['slug']) +'' + Don't allow more than one 'model' definition in the inheritance hierarchy. Technically, it would generate a valid form, but the fact that the resulting save method won't deal with multiple objects is likely to trip up people not