innov
/
django1
1
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

[1.11.x] Fixed #27759 -- Prevented forms attrs.html template from rendering False attrs. 

Regression in b52c73008a.

Backport of 5fa390ee81 from master
This commit is contained in:
Jon Dufresne 2017-01-22 10:15:56 -08:00 committed by Tim Graham
parent 6969100595
commit 9e9d0f8ef7
3 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django/forms/jinja2/django/forms/widgets/attrs.html
View File

@ -1 +1 @@
{% for name, value in widget.attrs.items() %} {{ name }}{% if not value is sameas True %}="{{ value }}"{% endif %}{% endfor %}
{% for name, value in widget.attrs.items() %}{% if value is not sameas False %} {{ name }}{% if not value is sameas True %}="{{ value }}"{% endif %}{% endif %}{% endfor %}

2
django/forms/templates/django/forms/widgets/attrs.html
View File

@ -1 +1 @@
{% for name, value in widget.attrs.items %} {{ name }}{% if not value is True %}="{{ value }}"{% endif %}{% endfor %}
{% for name, value in widget.attrs.items %}{% if value is not False %} {{ name }}{% if not value is True %}="{{ value }}"{% endif %}{% endif %}{% endfor %}

4
tests/forms_tests/widget_tests/test_widget.py
View File

@ -15,3 +15,7 @@ class WidgetTests(WidgetTest):
def test_no_trailing_newline_in_attrs(self):
self.check_html(Input(), 'name', 'value', strict=True, html='<input type="None" name="name" value="value" />')
def test_attr_false_not_rendered(self):
html = '<input type="None" name="name" value="value" />'
self.check_html(Input(), 'name', 'value', html=html, attrs={'readonly': False})