From 9ea2198fd1f2d0abf55373d8175dbb03f7440576 Mon Sep 17 00:00:00 2001 From: Jacob Kaplan-Moss Date: Wed, 22 Apr 2009 22:16:42 +0000 Subject: [PATCH] Fixed #10163: add an artificial ordering to querysets used by formsets, thus ensuring that POSTed data "lines up" correctly every time. Thanks to Karen Tracey for pointing in the right direction here. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10625 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- django/forms/models.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/django/forms/models.py b/django/forms/models.py index 626e727e3a..41380f21e9 100644 --- a/django/forms/models.py +++ b/django/forms/models.py @@ -406,6 +406,13 @@ class BaseModelFormSet(BaseFormSet): qs = self.queryset else: qs = self.model._default_manager.get_query_set() + + # If the queryset isn't already ordered we need to add an + # artificial ordering here to make sure that all formsets + # constructed from this queryset have the same form order. + if not qs.ordered: + qs = qs.order_by(self.model._meta.pk.name) + if self.max_num > 0: self._queryset = qs[:self.max_num] else: