innov
/
django1
1
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

Refs #23162 -- Removed forms.Field._has_changed() method. 

Per deprecation timeline.
This commit is contained in:
Tim Graham 2015-09-03 14:47:40 -04:00
parent 491de4f07c
commit a3fe4addcb
2 changed files with 2 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
django/forms/fields.py
View File

@ -28,9 +28,6 @@ from django.forms.widgets import (
) )
from django.utils import formats, six from django.utils import formats, six
from django.utils.dateparse import parse_duration from django.utils.dateparse import parse_duration
from django.utils.deprecation import (
RemovedInDjango110Warning, RenameMethodsBase,
)
from django.utils.duration import duration_string from django.utils.duration import duration_string
from django.utils.encoding import force_str, force_text, smart_text from django.utils.encoding import force_str, force_text, smart_text
from django.utils.ipv6 import clean_ipv6_address from django.utils.ipv6 import clean_ipv6_address
@ -48,13 +45,7 @@ __all__ = (
) )
class RenameFieldMethods(RenameMethodsBase): class Field(object):
renamed_methods = (
('_has_changed', 'has_changed', RemovedInDjango110Warning),
)
class Field(six.with_metaclass(RenameFieldMethods, object)):
widget = TextInput # Default widget to use when rendering this type of Field. widget = TextInput # Default widget to use when rendering this type of Field.
hidden_widget = HiddenInput # Default widget to use when rendering this as "hidden". hidden_widget = HiddenInput # Default widget to use when rendering this as "hidden".
default_validators = [] # Default set of validators default_validators = [] # Default set of validators

6
tests/forms_tests/tests/test_fields.py
View File

@ -44,10 +44,9 @@ from django.forms import (
Textarea, TextInput, TimeField, TypedChoiceField, TypedMultipleChoiceField, Textarea, TextInput, TimeField, TypedChoiceField, TypedMultipleChoiceField,
URLField, UUIDField, ValidationError, Widget, forms, URLField, UUIDField, ValidationError, Widget, forms,
) )
from django.test import SimpleTestCase, ignore_warnings from django.test import SimpleTestCase
from django.utils import formats, six, translation from django.utils import formats, six, translation
from django.utils._os import upath from django.utils._os import upath
from django.utils.deprecation import RemovedInDjango110Warning
from django.utils.duration import duration_string from django.utils.duration import duration_string
try: try:
@ -568,14 +567,11 @@ class FieldsTests(SimpleTestCase):
f = DateField() f = DateField()
self.assertRaisesMessage(ValidationError, "'Enter a valid date.'", f.clean, 'a\x00b') self.assertRaisesMessage(ValidationError, "'Enter a valid date.'", f.clean, 'a\x00b')
@ignore_warnings(category=RemovedInDjango110Warning) # for _has_changed
def test_datefield_changed(self): def test_datefield_changed(self):
format = '%d/%m/%Y' format = '%d/%m/%Y'
f = DateField(input_formats=[format]) f = DateField(input_formats=[format])
d = datetime.date(2007, 9, 17) d = datetime.date(2007, 9, 17)
self.assertFalse(f.has_changed(d, '17/09/2007')) self.assertFalse(f.has_changed(d, '17/09/2007'))
# Test for deprecated behavior _has_changed
self.assertFalse(f._has_changed(d, '17/09/2007'))
def test_datefield_strptime(self): def test_datefield_strptime(self):
"""Test that field.strptime doesn't raise an UnicodeEncodeError (#16123)""" """Test that field.strptime doesn't raise an UnicodeEncodeError (#16123)"""