From de912495ab1c3b3e05e79068861ab6b3b5f5c32e Mon Sep 17 00:00:00 2001 From: Erik Romijn Date: Sun, 16 Nov 2014 13:32:40 +0100 Subject: [PATCH] Added reminder to committing docs to test a PR with Jenkins first. --- docs/internals/contributing/committing-code.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/internals/contributing/committing-code.txt b/docs/internals/contributing/committing-code.txt index 6f7d4fd33b..b96b0c8c18 100644 --- a/docs/internals/contributing/committing-code.txt +++ b/docs/internals/contributing/committing-code.txt @@ -21,6 +21,14 @@ best pull requests possible. In practice however, committers - who will likely be more familiar with the commit guidelines - may decide to bring a commit up to standard themselves. +.. note:: + + Before merging, but after reviewing, have Jenkins test the pull request by + commenting "buildbot, test this please" on the PR. + See our `Jenkins wiki page`_ for more details. + +.. _Jenkins wiki page: https://code.djangoproject.com/wiki/Jenkins + Here is one way to commit a pull request:: # Create a new branch tracking upstream/master -- upstream is assumed