diff --git a/django/views/debug.py b/django/views/debug.py
index 2936b276df..4d68cd4d26 100644
--- a/django/views/debug.py
+++ b/django/views/debug.py
@@ -2,6 +2,7 @@ import functools
import re
import sys
import types
+from pathlib import Path
from django.conf import settings
from django.http import HttpResponse, HttpResponseNotFound
@@ -15,13 +16,17 @@ from django.utils.module_loading import import_string
from django.utils.translation import gettext as _
# Minimal Django templates engine to render the error templates
-# regardless of the project's TEMPLATES setting.
+# regardless of the project's TEMPLATES setting. Templates are
+# read directly from the filesystem so that the error handler
+# works even if the template loader is broken.
DEBUG_ENGINE = Engine(debug=True)
HIDDEN_SETTINGS = re.compile('API|TOKEN|KEY|SECRET|PASS|SIGNATURE', flags=re.IGNORECASE)
CLEANSED_SUBSTITUTE = '********************'
+CURRENT_DIR = Path(__file__).parent
+
class CallableSettingWrapper:
"""
@@ -320,13 +325,15 @@ class ExceptionReporter:
def get_traceback_html(self):
"""Return HTML version of debug 500 HTTP error page."""
- t = DEBUG_ENGINE.from_string(TECHNICAL_500_TEMPLATE)
+ with Path(CURRENT_DIR, 'templates', 'technical_500.html').open() as fh:
+ t = DEBUG_ENGINE.from_string(fh.read())
c = Context(self.get_traceback_data(), use_l10n=False)
return t.render(c)
def get_traceback_text(self):
"""Return plain text version of debug 500 HTTP error page."""
- t = DEBUG_ENGINE.from_string(TECHNICAL_500_TEXT_TEMPLATE)
+ with Path(CURRENT_DIR, 'templates', 'technical_500.txt').open() as fh:
+ t = DEBUG_ENGINE.from_string(fh.read())
c = Context(self.get_traceback_data(), autoescape=False, use_l10n=False)
return t.render(c)
@@ -480,7 +487,8 @@ def technical_404_response(request, exception):
module = obj.__module__
caller = '%s.%s' % (module, caller)
- t = DEBUG_ENGINE.from_string(TECHNICAL_404_TEMPLATE)
+ with Path(CURRENT_DIR, 'templates', 'technical_404.html').open() as fh:
+ t = DEBUG_ENGINE.from_string(fh.read())
c = Context({
'urlconf': urlconf,
'root_urlconf': settings.ROOT_URLCONF,
@@ -496,7 +504,8 @@ def technical_404_response(request, exception):
def default_urlconf(request):
"""Create an empty URLconf 404 error response."""
- t = DEBUG_ENGINE.from_string(DEFAULT_URLCONF_TEMPLATE)
+ with Path(CURRENT_DIR, 'templates', 'default_urlconf.html').open() as fh:
+ t = DEBUG_ENGINE.from_string(fh.read())
c = Context({
"title": _("Welcome to Django"),
"heading": _("It worked!"),
@@ -511,744 +520,3 @@ def default_urlconf(request):
})
return HttpResponse(t.render(c), content_type='text/html')
-
-
-#
-# Templates are embedded in the file so that we know the error handler will
-# always work even if the template loader is broken.
-#
-
-TECHNICAL_500_TEMPLATE = ("""
-
-
-
-
-
- {% if exception_type %}{{ exception_type }}{% else %}Report{% endif %}"""
-r"""{% if request %} at {{ request.path_info|escape }}{% endif %}
-
- {% if not is_email %}
-
- {% endif %}
-
-
-
-
{% if exception_type %}{{ exception_type }}{% else %}Report{% endif %}"""
- """{% if request %} at {{ request.path_info|escape }}{% endif %}
-
"""
- """{% if exception_value %}{{ exception_value|force_escape }}{% else %}No exception message supplied{% endif %}"""
-"""
-
-
-
Unicode error hint
-
The string that could not be encoded/decoded was: {{ unicode_hint|force_escape }}
-
-
Template-loader postmortem
- {% if postmortem %}
-
Django tried loading these templates, in this order:
- {% for entry in postmortem %}
-
Using engine {{ entry.backend.name }}:
-
- {% if entry.tried %}
- {% for attempt in entry.tried %}
- {{ attempt.0.loader_name }}: {{ attempt.0.name }} ({{ attempt.1 }})- This engine did not provide a list of tried templates.
- {% endif %}
-
- {% endfor %}
- {% else %}
-
No templates were found because your 'TEMPLATES' setting is not configured.
- {% endif %}
-
-
Error during template rendering
-
In template {{ template_info.name }}, error at line {{ template_info.line }}
-
{{ template_info.message }}
-
- {% for source_line in template_info.source_lines %}
- {% if source_line.0 == template_info.line %}
- | {{ source_line.0 }} |
- {{ template_info.before }}"""
- """{{ template_info.during }}"""
- """{{ template_info.after }} |
-
|---|
- {% else %}
- | {{ source_line.0 }} |
- {{ source_line.1 }} |
|---|
- {% endif %}
- {% endfor %}
-
-
-
- {% autoescape off %}
-
-
- {% for frame in frames %}
- {% ifchanged frame.exc_cause %}{% if frame.exc_cause %}
-
- {% if frame.exc_cause_explicit %}
- The above exception ({{ frame.exc_cause }}) was the direct cause of the following exception:
- {% else %}
- During handling of the above exception ({{ frame.exc_cause }}), another exception occurred:
- {% endif %}
-
-
-
{{ frame.filename|escape }} in {{ frame.function|escape }}
-
- {% if frame.context_line %}
-
- {% if frame.pre_context and not is_email %}
-
- {% for line in frame.pre_context %}
- {{ line|escape }}
- {% endif %}
-
-
-""" """{{ frame.context_line|escape }}{% if not is_email %} ...{% endif %}
- {% if frame.post_context and not is_email %}
-
- {% for line in frame.post_context %}
- {{ line|escape }}
- {% endif %}
-
- {% if is_email %}
-
Local Vars
- {% else %}
-
▶ Local vars
- {% endif %}
-
-
-
- | Variable |
- Value |
-
-
-
- {% for var in frame.vars|dictsort:0 %}
-
- | {{ var.0|force_escape }} |
- {{ var.1 }} |
-
- {% endfor %}
-
-
- {% endif %}
-
- {% endfor %}
-
-
- {% endautoescape %}
-
-
-
Request information
-
-{% if request %}
- {% if user_str %}
-
USER
-
{{ user_str }}
- {% endif %}
-
-
GET
- {% if request.GET %}
-
-
-
- | Variable |
- Value |
-
-
-
- {% for k, v in request_GET_items %}
-
- | {{ k }} |
- {{ v|pprint }} |
-
- {% endfor %}
-
-
- {% else %}
-
No GET data
- {% endif %}
-
-
POST
- {% if filtered_POST_items %}
-
-
-
- | Variable |
- Value |
-
-
-
- {% for k, v in filtered_POST_items %}
-
- | {{ k }} |
- {{ v|pprint }} |
-
- {% endfor %}
-
-
- {% else %}
-
No POST data
- {% endif %}
-
FILES
- {% if request.FILES %}
-
-
-
- | Variable |
- Value |
-
-
-
- {% for k, v in request_FILES_items %}
-
- | {{ k }} |
- {{ v|pprint }} |
-
- {% endfor %}
-
-
- {% else %}
-
No FILES data
- {% endif %}
-
-
-
COOKIES
- {% if request.COOKIES %}
-
-
-
- | Variable |
- Value |
-
-
-
- {% for k, v in request_COOKIES_items %}
-
- | {{ k }} |
- {{ v|pprint }} |
-
- {% endfor %}
-
-
- {% else %}
-
No cookie data
- {% endif %}
-
-
-
-
-
- | Variable |
- Value |
-
-
-
- {% for var in request.META.items|dictsort:0 %}
-
- | {{ var.0 }} |
- {{ var.1|pprint }} |
-
- {% endfor %}
-
-
-{% else %}
-
Request data not supplied
-{% endif %}
-
-
Settings
-
Using settings module {{ settings.SETTINGS_MODULE }}
-
-
-
- | Setting |
- Value |
-
-
-
- {% for var in settings.items|dictsort:0 %}
-
- | {{ var.0 }} |
- {{ var.1|pprint }} |
-
- {% endfor %}
-
-
-
-
-
- You're seeing this error because you have DEBUG = True in your
- Django settings file. Change that to False, and Django will
- display a standard page generated by the handler for this status code.
-
-
-
Page not found (404)
-
-
- {% if urlpatterns %}
-
- Using the URLconf defined in {{ urlconf }},
- Django tried these URL patterns, in this order:
-
-
- {% for pattern in urlpatterns %}
- -
- {% for pat in pattern %}
- {{ pat.regex.pattern }}
- {% if forloop.last and pat.name %}[name='{{ pat.name }}']{% endif %}
- {% endfor %}
-
- {% endfor %}
-
-
- {% if request_path %}
- The current path, {{ request_path|escape }},{% else %}
- The empty path{% endif %} didn't match any of these.
-
- {% else %}
-
{{ reason }}
- {% endif %}
-
-
- You're seeing this error because you have DEBUG = True in
- your Django settings file. Change that to False, and Django
- will display a standard 404 page.
-
-
-
{{ heading }}
- {{ subheading }}
-
-
-
-
- {{ instructions|safe }}
-
-
-
- {{ explanation|safe }}
-
-
+
{{ heading }}
+ {{ subheading }}
+
+
+
+
{{ instructions|safe }}
+
+
{{ explanation|safe }}
+
+
Page not found (404)
+
+
+ {% if urlpatterns %}
+
+ Using the URLconf defined in {{ urlconf }},
+ Django tried these URL patterns, in this order:
+
+
+ {% for pattern in urlpatterns %}
+ -
+ {% for pat in pattern %}
+ {{ pat.regex.pattern }}
+ {% if forloop.last and pat.name %}[name='{{ pat.name }}']{% endif %}
+ {% endfor %}
+
+ {% endfor %}
+
+
+ {% if request_path %}
+ The current path, {{ request_path|escape }},{% else %}
+ The empty path{% endif %} didn't match any of these.
+
+ {% else %}
+
{{ reason }}
+ {% endif %}
+
+
+ You're seeing this error because you have DEBUG = True in
+ your Django settings file. Change that to False, and Django
+ will display a standard 404 page.
+
+
+
{% if exception_type %}{{ exception_type }}{% else %}Report{% endif %}
+ {% if request %} at {{ request.path_info|escape }}{% endif %}
+
{% if exception_value %}{{ exception_value|force_escape }}{% else %}No exception message supplied{% endif %}
+
+
+
Unicode error hint
+
The string that could not be encoded/decoded was: {{ unicode_hint|force_escape }}
+
+
Template-loader postmortem
+ {% if postmortem %}
+
Django tried loading these templates, in this order:
+ {% for entry in postmortem %}
+
Using engine {{ entry.backend.name }}:
+
+ {% if entry.tried %}
+ {% for attempt in entry.tried %}
+ {{ attempt.0.loader_name }}: {{ attempt.0.name }} ({{ attempt.1 }})- This engine did not provide a list of tried templates.
+ {% endif %}
+
+ {% endfor %}
+ {% else %}
+
No templates were found because your 'TEMPLATES' setting is not configured.
+ {% endif %}
+
+
Error during template rendering
+
In template {{ template_info.name }}, error at line {{ template_info.line }}
+
{{ template_info.message }}
+
+ {% for source_line in template_info.source_lines %}
+ {% if source_line.0 == template_info.line %}
+ | {{ source_line.0 }} |
+ {{ template_info.before }}{{ template_info.during }}{{ template_info.after }} |
+
|---|
+ {% else %}
+ | {{ source_line.0 }} |
+ {{ source_line.1 }} |
|---|
+ {% endif %}
+ {% endfor %}
+
+
+
+ {% autoescape off %}
+
+
+ {% for frame in frames %}
+ {% ifchanged frame.exc_cause %}{% if frame.exc_cause %}
+
+ {% if frame.exc_cause_explicit %}
+ The above exception ({{ frame.exc_cause }}) was the direct cause of the following exception:
+ {% else %}
+ During handling of the above exception ({{ frame.exc_cause }}), another exception occurred:
+ {% endif %}
+
-
+
{{ frame.filename|escape }} in {{ frame.function|escape }}
+
+ {% if frame.context_line %}
+
+ {% if frame.pre_context and not is_email %}
+
+ {% for line in frame.pre_context %}
+ {{ line|escape }}
+ {% endif %}
+
+ {{ frame.context_line|escape }}{% if not is_email %} ...{% endif %}
+ {% if frame.post_context and not is_email %}
+
+ {% for line in frame.post_context %}
+ {{ line|escape }}
+ {% endif %}
+
+ {% if is_email %}
+
Local Vars
+ {% else %}
+
▶ Local vars
+ {% endif %}
+
+
+
+ | Variable |
+ Value |
+
+
+
+ {% for var in frame.vars|dictsort:0 %}
+
+ | {{ var.0|force_escape }} |
+ {{ var.1 }} |
+
+ {% endfor %}
+
+
+ {% endif %}
+
+ {% endfor %}
+
+
+ {% endautoescape %}
+
+
+
Request information
+
+{% if request %}
+ {% if user_str %}
+
USER
+
{{ user_str }}
+ {% endif %}
+
+
GET
+ {% if request.GET %}
+
+
+
+ | Variable |
+ Value |
+
+
+
+ {% for k, v in request_GET_items %}
+
+ | {{ k }} |
+ {{ v|pprint }} |
+
+ {% endfor %}
+
+
+ {% else %}
+
No GET data
+ {% endif %}
+
+
POST
+ {% if filtered_POST_items %}
+
+
+
+ | Variable |
+ Value |
+
+
+
+ {% for k, v in filtered_POST_items %}
+
+ | {{ k }} |
+ {{ v|pprint }} |
+
+ {% endfor %}
+
+
+ {% else %}
+
No POST data
+ {% endif %}
+
FILES
+ {% if request.FILES %}
+
+
+
+ | Variable |
+ Value |
+
+
+
+ {% for k, v in request_FILES_items %}
+
+ | {{ k }} |
+ {{ v|pprint }} |
+
+ {% endfor %}
+
+
+ {% else %}
+
No FILES data
+ {% endif %}
+
+
+
COOKIES
+ {% if request.COOKIES %}
+
+
+
+ | Variable |
+ Value |
+
+
+
+ {% for k, v in request_COOKIES_items %}
+
+ | {{ k }} |
+ {{ v|pprint }} |
+
+ {% endfor %}
+
+
+ {% else %}
+
No cookie data
+ {% endif %}
+
+
+
+
+
+ | Variable |
+ Value |
+
+
+
+ {% for var in request.META.items|dictsort:0 %}
+
+ | {{ var.0 }} |
+ {{ var.1|pprint }} |
+
+ {% endfor %}
+
+
+{% else %}
+
Request data not supplied
+{% endif %}
+
+
Settings
+
Using settings module {{ settings.SETTINGS_MODULE }}
+
+
+
+ | Setting |
+ Value |
+
+
+
+ {% for var in settings.items|dictsort:0 %}
+
+ | {{ var.0 }} |
+ {{ var.1|pprint }} |
+
+ {% endfor %}
+
+
+
+
+
+ You're seeing this error because you have DEBUG = True in your
+ Django settings file. Change that to False, and Django will
+ display a standard page generated by the handler for this status code.
+
+
ValueError at /test_view/
', html)
+ self.assertInHTML('ValueError at /test_view/
', html)
self.assertIn('Can't find my keys
', html)
self.assertIn('Request Method: | ', html)
self.assertIn('Request URL: | ', html)
@@ -299,7 +299,7 @@ class ExceptionReporterTests(SimpleTestCase):
exc_type, exc_value, tb = sys.exc_info()
reporter = ExceptionReporter(None, exc_type, exc_value, tb)
html = reporter.get_traceback_html()
- self.assertIn('ValueError
', html)
+ self.assertInHTML('ValueError
', html)
self.assertIn('Can't find my keys
', html)
self.assertNotIn('Request Method: | ', html)
self.assertNotIn('Request URL: | ', html)
@@ -333,7 +333,7 @@ class ExceptionReporterTests(SimpleTestCase):
request = self.rf.get('/test_view/')
reporter = ExceptionReporter(request, None, None, None)
html = reporter.get_traceback_html()
- self.assertIn('Report at /test_view/
', html)
+ self.assertInHTML('Report at /test_view/
', html)
self.assertIn('No exception message supplied
', html)
self.assertIn('Request Method: | ', html)
self.assertIn('Request URL: | ', html)
@@ -376,7 +376,7 @@ class ExceptionReporterTests(SimpleTestCase):
request = self.rf.get('/test_view/')
reporter = ExceptionReporter(request, None, "I'm a little teapot", None)
html = reporter.get_traceback_html()
- self.assertIn('Report at /test_view/
', html)
+ self.assertInHTML('Report at /test_view/
', html)
self.assertIn('I'm a little teapot
', html)
self.assertIn('Request Method: | ', html)
self.assertIn('Request URL: | ', html)
@@ -389,7 +389,7 @@ class ExceptionReporterTests(SimpleTestCase):
def test_message_only(self):
reporter = ExceptionReporter(None, None, "I'm a little teapot", None)
html = reporter.get_traceback_html()
- self.assertIn('Report
', html)
+ self.assertInHTML('Report
', html)
self.assertIn('I'm a little teapot
', html)
self.assertNotIn('Request Method: | ', html)
self.assertNotIn('Request URL: | ', html)
@@ -457,7 +457,7 @@ class ExceptionReporterTests(SimpleTestCase):
exc_type, exc_value, tb = sys.exc_info()
reporter = ExceptionReporter(request, exc_type, exc_value, tb)
html = reporter.get_traceback_html()
- self.assertIn('%sError at /test_view/
' % 'ModuleNotFound' if PY36 else 'Import', html)
+ self.assertInHTML('%sError at /test_view/
' % ('ModuleNotFound' if PY36 else 'Import'), html)
def test_ignore_traceback_evaluation_exceptions(self):
"""
@@ -544,7 +544,7 @@ class ExceptionReporterTests(SimpleTestCase):
reporter = ExceptionReporter(request, exc_type, exc_value, tb)
html = reporter.get_traceback_html()
- self.assertIn('ValueError at /test_view/
', html)
+ self.assertInHTML('ValueError at /test_view/
', html)
self.assertIn('Oops
', html)
self.assertIn('USER
', html)
self.assertIn('[unable to retrieve the current user]
', html)