innov
/
django1
1
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

Removed serial pk assumption from FormfieldShouldDeleteFormTests.test_custom_delete.

This commit is contained in:
Tim Graham 2020-11-02 09:48:53 -05:00 committed by Mariusz Felisiak
parent 09e1ec71df
commit f814fb6040
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tests/model_formsets_regress/tests.py
View File

@ -408,8 +408,8 @@ class FormfieldShouldDeleteFormTests(TestCase):
fields = "__all__" fields = "__all__"
def should_delete(self): def should_delete(self):
""" delete form if odd PK """ """Delete form if odd serial."""
return self.instance.pk % 2 != 0 return self.instance.serial % 2 != 0
NormalFormset = modelformset_factory(User, form=CustomDeleteUserForm, can_delete=True) NormalFormset = modelformset_factory(User, form=CustomDeleteUserForm, can_delete=True)
DeleteFormset = modelformset_factory(User, form=CustomDeleteUserForm, formset=BaseCustomDeleteModelFormSet) DeleteFormset = modelformset_factory(User, form=CustomDeleteUserForm, formset=BaseCustomDeleteModelFormSet)
@ -492,14 +492,14 @@ class FormfieldShouldDeleteFormTests(TestCase):
data.update(self.delete_all_ids) data.update(self.delete_all_ids)
formset = self.DeleteFormset(data, queryset=User.objects.all()) formset = self.DeleteFormset(data, queryset=User.objects.all())
# verify two were deleted # Three with odd serial values were deleted.
self.assertTrue(formset.is_valid()) self.assertTrue(formset.is_valid())
self.assertEqual(len(formset.save()), 0) self.assertEqual(len(formset.save()), 0)
self.assertEqual(len(User.objects.all()), 2) self.assertEqual(User.objects.count(), 1)
# verify no "odd" PKs left # No odd serial values left.
odd_ids = [user.pk for user in User.objects.all() if user.pk % 2] odd_serials = [user.serial for user in User.objects.all() if user.serial % 2]
self.assertEqual(len(odd_ids), 0) self.assertEqual(len(odd_serials), 0)
class RedeleteTests(TestCase): class RedeleteTests(TestCase):