innov
/
django1
1
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

Fixed #27700 -- Optimized inspectdb tests by specifying database tables.

This commit is contained in:
Mariusz Felisiak 2017-01-07 21:41:42 +01:00 committed by Tim Graham
parent 853fe6f697
commit f8e36047da
1 changed files with 7 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
tests/inspectdb/tests.py
View File

@ -42,9 +42,7 @@ class InspectDBTestCase(TestCase):
def make_field_type_asserter(self): def make_field_type_asserter(self):
"""Call inspectdb and return a function to validate a field type in its output""" """Call inspectdb and return a function to validate a field type in its output"""
out = StringIO() out = StringIO()
call_command('inspectdb', call_command('inspectdb', 'inspectdb_columntypes', stdout=out)
table_name_filter=lambda tn: tn.startswith('inspectdb_columntypes'),
stdout=out)
output = out.getvalue() output = out.getvalue()
def assertFieldType(name, definition): def assertFieldType(name, definition):
@ -173,11 +171,7 @@ class InspectDBTestCase(TestCase):
def test_digits_column_name_introspection(self): def test_digits_column_name_introspection(self):
"""Introspection of column names consist/start with digits (#16536/#17676)""" """Introspection of column names consist/start with digits (#16536/#17676)"""
out = StringIO() out = StringIO()
# Lets limit the introspection to tables created for models of this call_command('inspectdb', 'inspectdb_digitsincolumnname', stdout=out)
# application
call_command('inspectdb',
table_name_filter=lambda tn: tn.startswith('inspectdb_'),
stdout=out)
output = out.getvalue() output = out.getvalue()
error_message = "inspectdb generated a model field name which is a number" error_message = "inspectdb generated a model field name which is a number"
self.assertNotIn(" 123 = models.CharField", output, msg=error_message) self.assertNotIn(" 123 = models.CharField", output, msg=error_message)
@ -197,7 +191,7 @@ class InspectDBTestCase(TestCase):
""" """
out = StringIO() out = StringIO()
call_command('inspectdb', call_command('inspectdb',
table_name_filter=lambda tn: tn.startswith('inspectdb_'), table_name_filter=lambda tn: tn.startswith('inspectdb_special'),
stdout=out) stdout=out)
output = out.getvalue() output = out.getvalue()
base_name = 'Field' if not connection.features.uppercases_column_names else 'field' base_name = 'Field' if not connection.features.uppercases_column_names else 'field'
@ -219,7 +213,7 @@ class InspectDBTestCase(TestCase):
""" """
out = StringIO() out = StringIO()
call_command('inspectdb', call_command('inspectdb',
table_name_filter=lambda tn: tn.startswith('inspectdb_'), table_name_filter=lambda tn: tn.startswith('inspectdb_special'),
stdout=out) stdout=out)
output = out.getvalue() output = out.getvalue()
self.assertIn("class InspectdbSpecialTableName(models.Model):", output) self.assertIn("class InspectdbSpecialTableName(models.Model):", output)
@ -227,18 +221,14 @@ class InspectDBTestCase(TestCase):
def test_managed_models(self): def test_managed_models(self):
"""By default the command generates models with `Meta.managed = False` (#14305)""" """By default the command generates models with `Meta.managed = False` (#14305)"""
out = StringIO() out = StringIO()
call_command('inspectdb', call_command('inspectdb', 'inspectdb_columntypes', stdout=out)
table_name_filter=lambda tn: tn.startswith('inspectdb_columntypes'),
stdout=out)
output = out.getvalue() output = out.getvalue()
self.longMessage = False self.longMessage = False
self.assertIn(" managed = False", output, msg='inspectdb should generate unmanaged models.') self.assertIn(" managed = False", output, msg='inspectdb should generate unmanaged models.')
def test_unique_together_meta(self): def test_unique_together_meta(self):
out = StringIO() out = StringIO()
call_command('inspectdb', call_command('inspectdb', 'inspectdb_uniquetogether', stdout=out)
table_name_filter=lambda tn: tn.startswith('inspectdb_uniquetogether'),
stdout=out)
output = out.getvalue() output = out.getvalue()
unique_re = re.compile(r'.*unique_together = \((.+),\).*') unique_re = re.compile(r'.*unique_together = \((.+),\).*')
unique_together_match = re.findall(unique_re, output) unique_together_match = re.findall(unique_re, output)
@ -266,9 +256,7 @@ class InspectDBTestCase(TestCase):
'text': 'myfields.TextField', 'text': 'myfields.TextField',
'bigint': 'BigIntegerField', 'bigint': 'BigIntegerField',
} }
call_command('inspectdb', call_command('inspectdb', 'inspectdb_columntypes', stdout=out)
table_name_filter=lambda tn: tn.startswith('inspectdb_columntypes'),
stdout=out)
output = out.getvalue() output = out.getvalue()
self.assertIn("text_field = myfields.TextField()", output) self.assertIn("text_field = myfields.TextField()", output)
self.assertIn("big_int_field = models.BigIntegerField()", output) self.assertIn("big_int_field = models.BigIntegerField()", output)