innov
/
django1
1
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

Added test of filtering on BinaryField and corrected docs.

This commit is contained in:
Jon Dufresne 2018-09-26 11:38:12 -07:00 committed by Tim Graham
parent 024abe5b82
commit fb2964a410
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docs/ref/models/fields.txt
View File

@ -416,9 +416,8 @@ guaranteed to fit numbers from ``-9223372036854775808`` to
.. class:: BinaryField(max_length=None, **options) .. class:: BinaryField(max_length=None, **options)
A field to store raw binary data. It only supports ``bytes`` assignment. Be A field to store raw binary data. It can be assigned :class:`bytes` or a
aware that this field has limited functionality. For example, it is not possible :class:`memoryview`.
to filter a queryset on a ``BinaryField`` value.
By default, ``BinaryField`` sets :attr:`~Field.editable` to ``False``, in which By default, ``BinaryField`` sets :attr:`~Field.editable` to ``False``, in which
case it can't be included in a :class:`~django.forms.ModelForm`. case it can't be included in a :class:`~django.forms.ModelForm`.

10
tests/model_fields/test_binaryfield.py
View File

@ -34,3 +34,13 @@ class BinaryFieldTests(TestCase):
self.assertIs(field.editable, True) self.assertIs(field.editable, True)
field = models.BinaryField(editable=False) field = models.BinaryField(editable=False)
self.assertIs(field.editable, False) self.assertIs(field.editable, False)
def test_filter(self):
dm = DataModel.objects.create(data=self.binary_data)
DataModel.objects.create(data=b'\xef\xbb\xbf')
self.assertSequenceEqual(DataModel.objects.filter(data=self.binary_data), [dm])
def test_filter_memoryview(self):
dm = DataModel.objects.create(data=self.binary_data)
DataModel.objects.create(data=b'\xef\xbb\xbf')
self.assertSequenceEqual(DataModel.objects.filter(data=memoryview(self.binary_data)), [dm])