tapan gujjar
2d67222472
Fixed #31522 -- Made admin's SelectBox preserve scroll position.
2020-07-01 16:31:38 +02:00
Jon Dufresne
1e3ceb485e
Made JavaScript URL manipulation more robust with URL and URLSearchParams.
...
Use the rich interface and native parsing provided by the browser rather
than raw string manipulation.
https://developer.mozilla.org/en-US/docs/Web/API/URL
https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams
2020-07-01 11:19:24 +02:00
Jon Dufresne
dbae6de01e
Simplified JavaScript with Array.prototype.includes().
...
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/includes
2020-07-01 10:16:20 +02:00
Jon Dufresne
feb6581993
Fixed the centering of the "Log in" button on admin login page.
...
Previously, the button's container had a padding of 9.4em which was
approximately center but not precisely. Now, the container uses
'align:text-center' to let the browser center the button.
2020-06-26 06:59:33 +02:00
Jon Dufresne
f3e5fba7c5
Simplified label element CSS in admin login.css.
...
Don't add horizontal padding as the label is always displayed on its own
line. This padding added no visual difference.
Move the 'display: block' property from responsive.css to base.css. The
label is already displayed on its own line in all viewports, so reduce
differences in rendering. Using block also allows the label to consume
the width of its container, creating a larger clickable area for a
slight a11y improvement.
2020-06-25 12:26:36 +02:00
Jon Dufresne
60db8b7b37
Removed unnecessary admin CSS.
...
The "object-tools" container is never rendered as a descendant of
.form-row.
The "golink" CSS class is unused.
A <label> element has not been included in the login .submit-row since
5869afe32b
.
The "help" CSS class from login.css has been unused since
0e5faf225c
.
The <label> color in login.css is already inherited from the <body>
element and so does not need to be re-specified.
The #content-main container already has the property 'width: 100%' from
base.css and so does not need to be re-specified in login.css.
The <td> and <th> font-family property is inherited from the <body>
element and so does not need to be re-specified.
The <html> element has the attribute dir which automatically sets
the text direction in the layout. Adding the direction CSS property was
necessary to support IE which does not support the dir attribute, but IE
is no longer supported, so drop the direction property.
The 'font-size: 1em' property re-specifies the same font size. It
creates no visual difference.
The 'font-size: 14px' property often re-specifies the inherited value.
Avoid re-specifying it.
2020-06-25 11:46:05 +02:00
Hasan Ramezani
fbe82f8255
Refs #26761 -- Removed extra space in admin change list result header.
2020-06-25 06:33:12 +02:00
Jon Dufresne
30e59705fc
Fixed #31523 -- Removed jQuery dependency from actions.js.
2020-06-24 11:54:48 +02:00
Alix
26a413507a
Fixed #6933 -- Added support for searching against quoted phrases in ModelAdmin.search_fields.
2020-06-18 20:17:20 +02:00
Adam Johnson
fcdac3787d
Removed unused HTML class flex from admin changelist.
...
Unused since 233708fb68
.
2020-06-04 11:25:19 +02:00
Collin Anderson
4ae9a2b18e
Fixed #31641 -- Improved loading of navigation sidebar in admin.
2020-06-03 13:04:54 +02:00
Jon Dufresne
2dd4d110c1
Fixed CVE-2020-13596 -- Fixed potential XSS in admin ForeignKeyRawIdWidget.
2020-06-03 09:23:00 +02:00
Carles Pina
e46c2326c8
Fixed #31536 -- Fixed rendering of disabled AdminFileWidget and ClearableFileInput.
2020-06-01 12:25:25 +02:00
Jon Dufresne
3bc4240d97
Removed unused admin:jsi18n <script> element from change_password.html.
...
The view does not contain any other JavaScript and therefore does not
have any user facing JavaScript strings to translate. Avoid the HTTP
request.
2020-05-28 15:21:47 +02:00
Tom Carrick
780473d756
Refs #31034 -- Improved accessibility of admin navigation sidebar.
2020-05-28 10:16:20 +02:00
Scott Cranfill
62f1655a64
Fixed #11157 -- Stopped removing stop words in admin's prepopulated_fields.
...
Co-Authored-By: Andy Chosak <andy@chosak.org>
2020-05-27 12:32:56 +02:00
Hasan Ramezani
18759b2209
Fixed #31616 -- Added hint about middleware ordering for SessionMiddleware admin check.
2020-05-25 21:14:32 +02:00
Fran Hrzenjak
4484bc1b2f
Fixed #31597 , #31603 -- Corrected admin clear all filters link behavior.
...
- Show "Clear all filters" only when any filter is selected.
- Preserve query string not related with filters.
Co-Authored-By: Hasan Ramezani <hasan.r67@gmail.com>
2020-05-20 21:08:47 +02:00
Jon Dufresne
e46f700e39
Refs #31034 -- Used === in nav_sidebar.js admin JS to avoid possible coercion issues.
2020-05-18 07:42:44 +02:00
kjpc-tech
099bce1bf0
Fixed #31590 -- Fixed ModelAdmin.date_hierarchy crash with an empty QuerySet.
...
Regression in 55cdf6c52d
.
2020-05-15 06:35:10 +02:00
Jon Dufresne
81ffedaacc
Fixed #31524 -- Removed minified static assets from the admin.
2020-05-14 16:07:56 +02:00
Jon Dufresne
d522b51c40
Fixed #31575 -- Added system check for admin sidebar request context processor dependency.
...
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2020-05-14 11:00:51 +02:00
Jon Dufresne
0a627dbe73
Removed unused Downcoder.chars.
...
Unused -- other than as a local variable -- since its introduction in
953badbea5
2020-05-13 21:07:14 +02:00
Mariusz Felisiak
0668164b4a
Fixed E128, E741 flake8 warnings.
2020-05-12 08:52:23 +02:00
Claude Paroz
e6ec76d245
Updated JS admin translation catalog.
2020-05-11 22:59:27 +02:00
Claude Paroz
33f26339b7
Updated source translation catalogs.
2020-05-11 21:34:46 +02:00
Tom Carrick
46fe506445
Corrected indentation of #main div in admin base template.
2020-05-11 18:16:38 +02:00
Tom Carrick
d24ba1be7a
Fixed #31034 -- Added a navigation sidebar to the admin.
...
Co-authored-by: elky <elky@users.noreply.github.com>
Co-authored-by: Goetz <goetz.buerkle@gmail.com>
2020-05-11 18:16:38 +02:00
Jon Dufresne
d6aff369ad
Refs #30116 -- Simplified regex match group access with Match.__getitem__().
...
The method has been available since Python 3.6. The shorter syntax is
also marginally faster.
2020-05-11 12:01:28 +02:00
dbxnr
fc0f7f6c15
Fixed #31157 -- Fixed displaying read-only JSONField values in admin.
2020-05-08 09:44:42 +02:00
Jon Dufresne
6137ec2bf2
Changed selected attribute to HTML5 boolean syntax in SelectBox.js.
...
Per MDN, HTMLOptionElement.selected is a Boolean attribute.
2020-05-08 06:02:42 +02:00
Jon Dufresne
3c5a586ce9
Fixed #31542 -- Simplified admin JavaScript with "for … of" statements.
2020-05-07 18:09:32 +02:00
Mariusz Felisiak
aff7a58aef
Updated admin's Select2 to 4.0.13.
2020-05-05 11:30:02 +02:00
Mariusz Felisiak
30083e0780
Fixed #31485 -- Updated admin's jQuery to 3.5.1.
2020-05-05 11:00:05 +02:00
Jon Dufresne
f2051eb8a7
Removed invalid value from admin CSS.
...
The keyword value 'none' is not a valid value for padding-bottom.
2020-05-05 07:01:06 +02:00
Jon Dufresne
e972752504
Removed unused CSS in admin.
...
.system-message, .system-message-title are unused since their
introduction in ce0d0cd9e2
.
.float-right, .float-left, .align-left, .align-right, and .example are
unused since 6eb4f25692
.
2020-05-01 07:00:00 +02:00
Jon Dufresne
448cdde935
Removed CSS workarounds for IE7 in admin.
2020-05-01 06:33:24 +02:00
Jon Dufresne
29e35b9a3e
Refs #31032 -- Removed unnecessary vendor prefixes from admin CSS.
...
The CSS properties have been standardized and are available in all
supported browsers.
2020-05-01 06:26:36 +02:00
Jon Dufresne
5869afe32b
Removed unnecessary entities from the admin.
...
Normal spaces are fine when used as a single spaced separation. For
larger spacing, CSS is used.
2020-04-29 11:40:24 +02:00
Jon Dufresne
7271c8def4
Refs #31493 -- Changed IIFE to ES6 blocks.
2020-04-29 10:22:41 +02:00
Jon Dufresne
5d37cc703b
Fixed #31493 -- Replaced var with const and let keywords in JavaScript.
...
The eslint configuration and the admin script compress.py have been
updated for ES6.
The unused fallback of globals.django in jquery.init.js was removed. It
is always included before jsi18n-mocks.test.js and it always sets the
global value.
2020-04-29 10:22:41 +02:00
Jon Dufresne
0dafadadb9
Refs #30400 -- Improved typography of user facing strings in admin changelist.
2020-04-29 07:01:46 +02:00
François Freitag
9ef4a18dbe
Changed django.forms.ValidationError imports to django.core.exceptions.ValidationError.
...
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2020-04-28 10:49:00 +02:00
François Freitag
abea86f9e4
Removed unnecessary tuple wrapping of single format string argument.
2020-04-27 08:30:16 +02:00
Jon Dufresne
f48a1990fb
Made compress.py script use the official google-closure-compiler release.
...
The script previously used the PyPI package closure, which is slightly
out of date and not maintained by Google.
The JavaScript contribution docs and the compress.py script now runs the
google-closure-compiler package in the recommended way. Google's
documentation on usage and installation can be found at:
https://github.com/google/closure-compiler-npm/tree/master/packages/google-closure-compiler#usage
This also makes the usage simpler as the package now runs through npm's
npx utility, which will automatically install google-closure-compiler to
a per-user cache.
2020-04-22 16:19:27 +02:00
Jon Dufresne
f27482f147
Fixed #31483 -- Rewrote change_form.js without jQuery.
...
The use of $(document).ready() was removed. The script is loaded at the
end of the document. Therefore, the referenced DOM elements are already
available and the script does not need to wait for the full DOM to be
ready before continuing.
Now that the script has no external dependencies, it can be loaded
asynchronously. As such, the async attribute was added to the script
element.
2020-04-22 15:44:55 +02:00
Jon Dufresne
a8bb53dbd2
Refs #31483 -- Removed CSS and JavaScript for unused HTML class add-another.
...
The HTML class was removed in 07988744b3
.
As such, the CSS and JavaScript is unused.
2020-04-22 15:44:55 +02:00
Mariusz Felisiak
fb9b1c245d
Updated admin's XRegExp to 3.2.0.
2020-04-22 08:45:14 +02:00
Jon Dufresne
0f2885e3f6
Simplified collapse.js with Element.closest().
2020-04-22 06:13:58 +02:00
hashlash
dfbd9ca065
Fixed #30311 -- Restored ability to override global admin actions.
2020-04-17 20:23:00 +02:00
Hasan Ramezani
96c6f9c61c
Fixed #31441 -- Ensured TabluarInline expands when child inputs have errors.
2020-04-16 12:17:49 +02:00
Hasan Ramezani
b4e7bf5284
Refs #31441 -- Added red border to inputs with errors for TabluarInline.
2020-04-16 12:17:49 +02:00
Nick Pope
daabb102c0
Fixed #31470 -- Fixed fieldset admin CSS to prevent overflowing <pre> elements.
...
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2020-04-16 10:47:42 +02:00
007
d51c50d836
Fixed #31462 -- Allowed overriding autocomplete/raw_id_fields/filter widgets for ManyToManyFields with formfield_overrides.
2020-04-15 08:33:40 +02:00
zriv
b9336b78cf
Fixed #31404 -- Changed selector-chosen's multiple attribute to HTML5 boolean syntax.
2020-03-27 08:38:58 +01:00
Hasan Ramezani
55cdf6c52d
Fixed #29724 -- Fixed timezone handling in ModelAdmin.date_hierarchy queries.
...
Thanks Alexander Holmbäck for the initial patch.
2020-03-25 21:03:41 +01:00
Jon Dufresne
be648d1c45
Fixed #31391 -- Removed jQuery usage in cancel.js
...
Now that cancel.js has no dependencies, it can be loaded asynchronously.
Co-Authored-By: François Freitag <mail@franek.fr>
2020-03-24 11:09:29 +01:00
Jon Dufresne
3a807a6f59
Fixed #31365 -- Removed jQuery usage in SelectFilter2.js.
2020-03-24 09:14:22 +01:00
Jon Dufresne
f982f0bdb8
Refs #31032 -- Removed unsupported browsers workarounds and comments in admin's JavaScript.
...
Since 8b30360322
, the admin documentation
is explicit that only modern evergreen browsers are supported. This
allows removing several long standing workarounds for IE and Opera older
versions.
Since 2013, Opera is based on the Chromium blink engine.
2020-03-23 06:19:10 +01:00
Jon Dufresne
25d450c852
Removed unused return values in SelectFilter2.js.
2020-03-17 13:52:29 +01:00
Jon Dufresne
9cf4e40b84
Simplified SelectFilter2 with Element.closest().
...
https://developer.mozilla.org/en-US/docs/Web/API/Element/closest
2020-03-17 12:04:14 +01:00
Jon Dufresne
3857a08bdb
Fixed #31361 -- Fixed invalid action="" in admin forms.
...
The attribute action="" (empty string) on the <form> element is invalid
HTML5. The spec (https://html.spec.whatwg.org/#attr-fs-action ) says:
> The action and formaction content attributes, if specified, must have
> a value that is a valid non-empty URL potentially surrounded by
> spaces.
Emphasis on non-empty. The action attribute is allowed to be omitted, in
which case the current URL is used which is the same behavior as now.
2020-03-16 07:31:19 +01:00
Jon Dufresne
eb77e80de0
Fixed #31349 -- Used :nth-child() CSS pseudo-class to style alternative rows in admin.
2020-03-09 12:34:32 +01:00
007gzs
a4881f5e5d
Fixed #31307 -- Fixed filter_horizontal add/remove SVG :hover positioning.
2020-02-27 15:39:13 +01:00
Fabio Sangiovanni
b457068cf2
Fixed #31187 -- Fixed detecting of existing total ordering in admin changelist when using Meta.constraints.
...
Detection of existing total ordering in admin changelist now takes into
account non-partial unique constraints.
2020-02-19 09:36:23 +01:00
Nick Pope
335c9c94ac
Simplified imports from django.db and django.contrib.gis.db.
2020-02-04 13:20:06 +01:00
Claude Paroz
5dabb6002e
Updated translations from Transifex.
...
Forwardport of ca4f87027e
from stable/3.0.x
2020-01-31 20:59:10 +01:00
Mariusz Felisiak
b7a3a6c9ef
Used model's Options.label/label_lower where applicable.
2020-01-29 12:09:20 +01:00
Hasan Ramezani
5d654e1e71
Refs #27888 -- Removed redundant {% if %} in admin changelist filters.
2020-01-24 20:31:09 +01:00
Hasan Ramezani
b94764e178
Fixed #27888 -- Added link to clear all filters in the admin changelist view.
2020-01-23 14:14:54 +01:00
Daniel Hahler
68e018010b
Optimized ModelAdmin._changeform_view() by avoiding multiple get_fieldsets() calls.
...
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
2020-01-17 16:00:04 +01:00
Owen T. Heisler
77d335e5ab
Fixed #31160 -- Fixed admin CSS for ordered lists' descendants in unordered list.
2020-01-13 09:13:33 +01:00
Adam Donaghy
8b3e714ecf
Fixed #30980 -- Improved error message when checking uniqueness of admin actions' __name__.
...
Thanks Keshav Kumar for the initial patch.
2020-01-10 14:00:28 +01:00
Federico Jaramillo Martínez
372eaa395f
Fixed #28991 -- Added EmptyFieldListFilter class in admin.filters.
...
Thanks Simon Charette and Carlton Gibson for reviews.
Co-Authored-By: Jonas Haag <jonas@lophus.org>
Co-Authored-By: Christophe Baldy <christophe.baldy@polyconseil.fr>
2020-01-03 07:58:04 +01:00
Sjbrgsn
b2bd08bb7a
Fixed #30892 -- Fixed slugify() and admin's URLify.js for "İ".
...
Thanks Luis Nell for the implementation idea and very detailed report.
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2019-12-30 20:47:22 +01:00
Farhaan Bukhsh
cf5d4701dc
Fixed #30819 -- Fixed year determination in admin calendar widget for two-digit years.
...
Two-digit years in the range of [00, 68] are in the current century,
while [69,99] are in the previous century, according to the Open Group
Specification.
2019-12-30 13:06:29 +01:00
Mike Hansen
35d36d9462
Refs #30585 -- Updated project templates and tests to use (block)translate tags.
2019-12-18 13:15:38 +01:00
Jon Dufresne
e703b93a65
Fixed #31080 -- Removed redundant type="text/javascript" attribute from <script> tags.
2019-12-11 09:49:54 +01:00
Jon Dufresne
65285d1e7d
Refs #29892 -- Made Selenium tests wait for popups to be ready.
2019-12-02 15:06:36 +01:00
Carlton Gibson
6376278a90
Updated contrib translations from Transifex.
...
Forward port of 4afa0e5d2a
from stable/3.0.x
2019-12-02 11:25:23 +01:00
Carlton Gibson
11c5e0609b
Fixed CVE-2019-19118 -- Required edit permissions on parent model for editable inlines in admin.
...
Thank you to Shen Ying for reporting this issue.
2019-12-02 08:56:08 +01:00
Jon Dufresne
46a0edc3ba
Fixed #31028 -- Used classList API to check, add and remove DOM classes.
...
Thanks to Claude Paroz for review.
2019-11-28 15:21:37 +01:00
Jon Dufresne
c8bd37a860
Fixed #31042 -- Removed AdminSeleniumTestCase.get_css_value() in favor of Selenium .is_displayed().
...
All instances of AdminSeleniumTestCase.get_css_value() were used to
inspect the display property.
2019-11-28 15:10:13 +01:00
Johannes Hoppe
249a6190ae
Fixed #30975 -- Replaced custom get_select_option with Selenium's select_by_value.
2019-11-27 16:34:07 +01:00
Johannes Hoppe
69dbb6b708
Fixed #30973 -- Converted selenium tests wait_page_loaded to context manager.
2019-11-27 14:36:26 +01:00
Jon Dufresne
cab3661832
Fixed #31027 -- Replaced .getAttribute()/.setAttribute() usage with DOM properties.
2019-11-27 07:53:04 +01:00
Baptiste Mispelon
52936eface
Fixed #31031 -- Fixed data loss in admin changelist view when formset's prefix contains regex special chars.
...
Regression in b18650a263
.
2019-11-26 08:48:10 +01:00
Johannes Hoppe
ef93fd4683
Fixed #31013 -- Removed jQuery usage in SelectBox.js.
2019-11-25 13:35:20 +01:00
Hasan Ramezani
0284a26af9
Fixed #30981 -- Fixed admin changelist crash when using F() or OrderBy() expressions in admin_order_field.
2019-11-19 15:40:04 +01:00
Daniel Izquierdo
89abecc75d
Fixed #27272 -- Added an on_delete RESTRICT handler to allow cascading deletions while protecting direct ones.
2019-11-19 10:55:05 +01:00
Mariusz Felisiak
4c45b627f8
Removed unused import of ACTION_CHECKBOX_NAME in django.contrib.admin.
...
Unused since e651b3095c
.
2019-11-06 12:49:42 +01:00
Jon Dufresne
b9fe7f9294
Fixed #30947 -- Changed tuples to lists in model Meta options in django.contrib modules.
...
The Django "Model Meta options" docs provide examples and generally
point the reader to use lists for the unique_together and ordering
options. Follow our own advice for contrib models.
More generally, lists should be used for homogeneous sequences of
arbitrary lengths of which both unique_together and ordering are.
2019-11-05 08:16:31 +01:00
Jon Dufresne
607004f81a
Simplified consecutive calls to pathlib.Path.parent.
2019-11-04 09:59:34 +01:00
Erwin Junge
a6cb8ec389
Fixed #30922 -- Fixed ModelAdmin.date_hierarchy queries with DST changes.
...
There was an issue where admin date_hierarchy didn't render last day of
a month in DST-switch month.
2019-10-29 11:21:03 +01:00
Hasan Ramezani
e3d0b4d550
Fixed #30899 -- Lazily compiled import time regular expressions.
2019-10-29 09:22:26 +01:00
Carlton Gibson
24e540fbd7
Fixed #29087 -- Added delete buttons for unsaved admin inlines on validation error.
2019-10-25 13:28:08 +02:00
Carlton Gibson
6ea3aadd17
Refs #29087 -- Refactored admin inlines.js.
...
Split logic into separate functions to clarify and allow reuse.
2019-10-25 13:28:08 +02:00
Simon Charette
26c66f4519
Fixed #30856 -- Combined fast-delete queries by model during cascade deletion.
...
Reduced the number of queries required when performing cascade deletion
for a model referenced multiple time by another one by performing an
union of reference lookups.
2019-10-09 09:49:53 +02:00
Min ho Kim
b1d6b35e14
Fixed #30725 -- Fixed width of DateTimeField inputs in admin tabular inline.
...
"width" of DateTimeField inputs in admin tabular inline wasn't set
correctly what caused displaying too small inputs with responsive CSS
when timezone warning wasn't present.
2019-09-17 14:30:33 +02:00
Hasan Ramezani
b9db423d3c
Fixed #29376 -- Allowed hiding "Save and Add Another" button in admin.
2019-09-16 11:37:09 +02:00
Claude Paroz
5495ea3ae0
Updated translation catalogs
2019-09-08 17:35:32 +02:00
Jon Dufresne
a44d80f88e
Adjusted subprocess.run() calls to use arg list, rather than string.
...
The Python docs recommend passing a sequence to subprocess.run() when
possible. Doing so allows for automatic escaping and quoting of
arguments.
https://docs.python.org/3/library/subprocess.html#frequently-used-arguments
> args is required for all calls and should be a string, or a sequence
> of program arguments. Providing a sequence of arguments is generally
> preferred, as it allows the module to take care of any required
> escaping and quoting of arguments (e.g. to permit spaces in file
> names).
Also removed `shell=True` where unnecessary.
2019-08-28 10:19:30 +02:00
Federico Jaramillo Martínez
8f6860863e
Fixed #30722 -- Added default rate-limiting requests to admin's Select2 widget.
2019-08-27 13:47:36 +02:00
Dulmandakh
06372a8d27
Fixed #30507 -- Updated admin's jQuery to 3.4.1.
2019-08-23 11:00:16 +02:00
Claude Paroz
9386586f31
Replaced subprocess commands by run() wherever possible.
2019-08-23 10:53:36 +02:00
Carlton Gibson
5b4c6b58a0
Fixed #30064 -- Added form to validate admin search fields query input.
2019-08-22 14:09:49 +02:00
zeyneloz
8289fc55ff
Refs #30449 -- Made RelatedOnlyFieldListFilter respect ModelAdmin.ordering.
2019-08-15 10:29:10 +02:00
Johannes Hoppe
00d4e6f8b5
Updated Select2 to version 4.0.7.
2019-07-10 12:31:16 +02:00
Hasan Ramezani
ed668796f6
Fixed #30543 -- Fixed checks of ModelAdmin.list_display for fields accessible only via instance.
...
Co-Authored-By: Andrew Simons <andrewsimons@bubblegroup.com>
2019-07-10 10:37:34 +02:00
Claude Paroz
d54baf6970
Updated translations from Transifex
...
Forward port of b3f7262e6e
from stable/2.2.x
2019-06-29 16:17:16 +02:00
Jon Dufresne
42b9a23267
Fixed #30400 -- Improved typography of user facing strings.
...
Thanks Claude Paroz for assistance with translations.
2019-06-28 16:46:18 +02:00
Markus Holtermann
ad7b438002
Bumped minimum ESLint version to 4.18.2.
2019-06-21 17:57:35 +02:00
Sanyam Khurana
87f5d07eed
Fixed #12952 -- Adjusted admin log change messages to use form labels instead of field names.
2019-06-14 18:20:29 +02:00
Jones Ambrosi
f9561144d7
Fixed #30520 -- Fixed crash of admin model inlines on custom fields without labels.
2019-06-04 10:27:12 +02:00
Carlton Gibson
34ec52269a
Applied jQuery patch for CVE-2019-11358.
2019-06-03 11:36:12 +02:00
Carlton Gibson
deeba6d920
Fixed CVE-2019-12308 -- Made AdminURLFieldWidget validate URL before rendering clickable link.
2019-06-03 11:36:12 +02:00
Claude Paroz
e286987a27
Fixed #30459 -- Delegated hide/show JS toggle to parent div.
...
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2019-05-17 07:46:45 +02:00
Ben Muschol
8eb4133714
Always remove required attribute in SelectFilter2.js ( #11331 )
...
Fixes bug on browsers which do support the required attribute but not the :valid pseudo-selector
2019-05-07 08:16:30 +02:00
Aarni Koskela
efeceba589
Fixed #30312 -- Relaxed admin check from django.contrib.sessions to SessionMiddleware subclasses.
2019-04-26 11:31:06 +02:00
Jon Dufresne
8b3f1c35dd
Removed unnecessary assignments in various code.
2019-04-24 13:09:29 +02:00
Hasan Ramezani
917fd9d03f
Fixed #27755 -- Added ModelAdmin.get_inlines() hook.
2019-04-17 07:16:04 +02:00
Mariusz Felisiak
7cbcf2e2cb
Fixed #30259 -- Fixed crash of admin views when properties don't have admin_order_field attribute.
2019-04-01 15:11:54 +02:00
Claude Paroz
3e01aab533
Updated contrib translations from Transifex.
...
Forwardport of 7090cbf542
from 2.2.x.
2019-04-01 12:22:15 +02:00
Tim Graham
8335d59200
Fixed #30289 -- Prevented admin inlines for a ManyToManyField's implicit through model from being editable if the user only has the view permission.
2019-03-30 16:49:16 -04:00
Nick Pope
d41a1005eb
Removed unused timeparse.js.
...
Unused since its introduction in dd5320d1d5
.
2019-03-27 09:24:09 -04:00
Nick Pope
3113957123
Simplified Date.prototype.getTwelveHours().
2019-03-27 09:13:21 -04:00
Nick Pope
a25029b336
Removed unused Date.prototype.getHourMinute().
...
Unused since d2180a6bf3
.
2019-03-27 09:12:44 -04:00
Nick Pope
8c694317f8
Removed unused Date.prototype.getHourMinuteSecond().
...
Unused since fa0653cd1d
.
2019-03-27 09:12:15 -04:00
Nick Pope
93d1f2d209
Removed unused String.prototype.pad_left().
...
Unused since its introduction in dd5320d1d5
.
2019-03-27 09:11:30 -04:00
Nick Pope
41e6ef28b0
Removed unneeded compatibility shim for getComputedStyle().
...
Required for IE<9.
2019-03-27 09:10:56 -04:00
Hasan Ramezani
d4df5e1b0b
Fixed #27360 -- Added app or ModelAdmin details for AreadyRegistered exceptions.
2019-03-25 17:34:53 -04:00
Jani Tiainen
044cc54420
Fixed #30259 -- Added support for admin_order_field attribute on properties in ModelAdmin.list_display.
2019-03-24 20:43:56 +01:00
Herman S
f976ab1b11
Fixed #30237 -- Made Authentication/SessionMiddleware and ModelBackend admin checks allow subclasses.
2019-03-14 20:09:57 -04:00
btknu
7c3a8b9db2
Fixed #30243 -- Simplified ModelAdmin.render_change_form()'s has_file_field.
2019-03-08 18:03:58 -05:00
Jon Dufresne
17455e924e
Removed executable bit from static asset xregexp.js.
2019-03-04 10:35:08 -05:00
Dan Wilson
fe65918dca
Fixed #30229 -- Removed polyfill from inlines.min.js.
...
find() is only called on jQuery objects, so the polyfill is necessary.
2019-03-01 13:00:30 -05:00
Etienne Chové
4dcbe6eb2d
Fixed #30221 -- Made label suffix of admin's read-only fields translatable.
2019-02-28 11:12:30 -05:00
Johannes Hoppe
25e724a5d6
Fixed #30218 -- Fixed size of admin changelist's search button.
2019-02-28 11:05:48 -05:00
Tim Graham
93e892bb64
Refs #29523 -- Updated admin's collapse.min.js.
...
Omitted in ba83378a77
.
2019-02-27 16:17:10 -05:00
Johannes Hoppe
5deb7a86e8
Removed AutocompleteJsonView.paginator_class.
...
Unused since its introduction in 94cd8efc50
.
2019-02-27 09:54:16 -05:00
Matthias Kestenholz
c41e6c4eb8
Fixed #30208 -- Fixed login header height and alignment in the largest breakpoint.
2019-02-25 14:39:50 -05:00
Gregory N. Schmit
48c17807a9
Fixed #16027 -- Added app_label to ContentType.__str__().
2019-02-07 19:56:47 -05:00
Nick Pope
24b82cd201
Fixed #30159 -- Removed unneeded use of OrderedDict.
...
Dicts preserve order since Python 3.6.
2019-02-06 13:48:39 -05:00
Tim Graham
6079ed82f4
Refs #27991 -- Made obj a required argument of InlineModelAdmin.has_add_permission().
...
Per deprecation timeline.
2019-01-17 11:14:07 -05:00
Tim Graham
92d4d0859a
Refs #21221 -- Removed staticfiles and admin_static template tag libraries.
...
Per deprecation timeline.
2019-01-17 10:52:19 -05:00
Simon Charette
f84ad16ba4
Refs #17198 -- Detected existing total ordering in admin changelist.
...
Appending pk is not necessary when a subset of the ordering expressions is
contained in a non-nullable unique contraint.
Related field ordering through lookups and related ordering introspection is
omitted for simplicitly purpose.
2019-01-17 16:22:14 +01:00
Claude Paroz
aa5fd84f53
Updated translation catalogs
2019-01-16 20:51:26 +01:00
Claude Paroz
87bf35abd3
Removed unexpected chars in Armenian admin translation
2019-01-15 10:43:11 +01:00
MaximZemskov
3c01fe30f3
Fixed #30097 -- Made 'obj' arg of InlineModelAdmin.has_add_permission() optional.
...
Restored backwards compatibility after refs #27991 .
Regression in be6ca89396
.
2019-01-11 18:02:43 -05:00
Claude Paroz
217f4456d8
Fetched Armenian translations from Transifex
2019-01-10 10:50:42 +01:00
Tim Graham
0004daa536
Used 4 space hanging indent for dictionaries.
...
Thanks Mariusz Felisiak for auditing.
2019-01-02 18:18:19 -05:00
Tim Graham
02c07be95c
Fixed #30050 -- Fixed InlineModelAdmin.has_change_permission() called with non-None obj during add.
...
Thanks andreage for the report and suggested fix.
2019-01-01 09:42:14 -05:00
Carlton Gibson
8245c99ee6
Fixed #29930 -- Allowed editing in admin with view-only inlines.
...
Co-authored-by: Tim Graham <timograham@gmail.com>
2018-12-03 07:44:18 -08:00
Basil Dubyk
7d1123e5ad
Fixed #29929 -- Fixed admin view-only change form crash when using ModelAdmin.prepopulated_fields.
2018-11-28 15:40:14 -05:00
redodo
2e4776196d
Fixed #29953 -- Added CSS class to column headers in tabular inlines.
...
The class name is the same as one given to the fields in the change list.
2018-11-20 18:17:53 -05:00
Sanyam Khurana
a7d6cab771
Fixed #29282 -- Prevented some admin checks from crashing with TypeError.
...
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2018-11-20 17:19:13 -05:00
redodo
89a2216486
Fixed #29961 -- Made RelatedFieldWidgetWrapper hide related item links if wrapping a hidden widget.
2018-11-19 15:12:52 -05:00
Vishvajit Pathak
11bcb57ee2
Fixed #29964 -- Removed unused admin/related_widget_wrapper.html template.
...
Unused since b52c73008a
.
2018-11-18 11:42:48 -05:00
Hasan Ramezani
6d4e5feb79
Fixed #29835 -- Made RelatedFieldListFilter respect ModelAdmin.ordering.
2018-11-14 14:29:39 -05:00
Srinivas Thatiparthy (శ్రీనివాస్ తాటిపర్తి)
1f726311d1
Used method chaining in DateTimeShortcuts.js.
2018-11-09 19:56:46 -05:00
Matthias Kestenholz
f9ff1df1da
Fixed #29917 -- Stopped collecting ModelAdmin.actions from base ModelAdmins.
2018-11-09 18:52:30 -05:00
Javier Matos Odut
3d4d0a25b2
Fixed #29901 -- Allowed overriding an autocomplete/raw_id_fields/radio_fields widget with ModelAdmin.get_formset().
2018-10-31 10:16:17 -04:00
Mac Chapman
fb5dfd53a7
Fixed #29832 -- Updated Roboto font to v2.137.
2018-10-11 23:30:45 -04:00
Sergey Fedoseev
e4df8e6dc0
Simplified contrib.admin.utils.unquote().
2018-10-02 15:42:56 -04:00
Przemysław Buczkowski
70d0a1ca02
Fixed #29711 -- Added a system check for uniquness of admin actions' __name__.
2018-10-02 09:17:23 -04:00
Sergey Fedoseev
e9defb3f6e
Simplified contrib.admin.utils.quote().
2018-10-01 09:11:53 -04:00
Carlton Gibson
bf39978a53
Fixed CVE-2018-16984 -- Fixed password hash disclosure to admin "view only" users.
...
Thanks Claude Paroz & Tim Graham for collaborating on the patch.
2018-10-01 10:05:01 +02:00
Claude Paroz
033d842e84
Updated translations from Transifex
...
Forward port of d5ed08263b
from master.
2018-09-29 17:11:49 +02:00
Sergey Fedoseev
8ef8bc0f64
Refs #28909 -- Simplifed code using unpacking generalizations.
2018-09-28 09:57:12 -04:00
Jon Dufresne
82f286cf6f
Refs #29784 -- Switched to https:// links where available.
2018-09-26 08:48:47 +02:00
Jon Dufresne
8c3e0eb1c1
Normalized spelling of "lowercase" and "lowercased".
2018-09-25 10:30:18 -04:00
Jon Dufresne
ad9a28ee38
Refs #29784 -- Normalized Python docs links to omit the version.
2018-09-25 10:19:42 +02:00
Tim Graham
fd8a7a5313
Fixed #29723 -- Fixed crash if InlineModelAdmin.has_add_permission() doesn't accept the obj argument.
...
* Refs #27991 -- Added testing for ModelAdmin.get_inline_instances() if the inline's has_add_permission() doesn't accept 'obj'.
* Fixed #29723 -- Fixed crash if InlineModelAdmin.has_add_permission() doesn't accept the obj argument.
2018-08-30 11:22:50 +02:00
Claude Paroz
50b8493581
Refs #29654 -- Replaced three dots with ellipsis character in output strings.
2018-08-22 09:13:58 -04:00
Claude Paroz
201017df30
Fixed #29654 -- Made text truncation an ellipsis character instead of three dots.
...
Thanks Sudhanshu Mishra for the initial patch and Tim Graham for the review.
2018-08-21 17:46:45 +02:00
Rodrigo
371ece2f06
Fixed #29695 -- Added system checks for admin's app dependencies and TEMPLATES setting.
2018-08-20 17:57:46 -04:00
Tim Graham
d311124be5
Fixed #29682 -- Fixed admin change form crash if a view-only model's form has an extra field.
2018-08-20 11:14:20 -04:00
Taha Jahangir
0e7a9525ba
Fixed #29690 -- Fixed aligned <ul> positioning for RTL languages in admin.
2018-08-20 10:20:30 -04:00
Jon Dufresne
dc0868d414
Removed redundant 'model' argument in admin checks.
2018-08-20 09:11:42 -04:00
mackong
c832885a3e
Fixed #29426 -- Made UUID inputs in the admin match the width of a UUID.
2018-08-18 10:16:22 -04:00
Jon Dufresne
09ee3b6fe3
Fixed #29663 -- Made admin change view redirect to changelist with view permission.
2018-08-17 11:13:06 -04:00
Jon Dufresne
57f16655cd
Added ModelAdmin._response_post_save() to avoid code duplication.
2018-08-17 10:51:57 -04:00
Jon Dufresne
cd790ed1a6
Refs #8936 -- Added ModelAdmin.has_view_or_change_permission().
2018-08-16 09:49:06 -04:00
Clément Mangin
64e1a271f5
Fixed #29637 -- Fixed admin change form crash if the user doesn’t have the add permission to a TabularInline.
...
Regression in 825f0beda8
.
2018-08-10 11:20:43 -04:00
Vlastimil Zíma
a9f5652113
Fixed #28529 -- Fixed VariableDoesNotExist warnings in admin templates.
2018-08-06 17:03:06 -04:00
Claude Paroz
287fef8693
Updated contrib translations from Transifex
...
Forwardport of cbf7e7dc52
from stable/2.1.x.
2018-08-01 09:24:06 -04:00
Claude Paroz
ba83378a77
Fixed #29523 -- Removed jQuery usage in DateTimeShortcuts.js & collapse.js.
2018-07-20 12:27:53 -04:00
Jonah Bishop
263e039411
Fixed #29045 -- Fixed admin CSS so that select multiple elements honor the HTML size attribute.
2018-07-10 16:22:09 -04:00
Claude Paroz
a5f139236f
Fixed #29536 -- Fixed SelectFilter2.js resizing to make boxes have equal height.
...
Thanks Tim Graham for the review.
2018-06-29 17:21:27 +02:00
Carlton Gibson
5b73317181
Fixed #29502 -- Allowed users with the view permission to use autocomplete_fields.
2018-06-18 15:36:20 -04:00
Carlton Gibson
958c7b301e
Fixed #29419 -- Allowed permissioning of admin actions.
2018-06-18 15:07:29 -04:00
Paulo
553617e613
Fixed #29487 -- Accounted for object level permissions when calculating change view's read-only fields.
...
Thanks Matthew Frazier for the report and fix.
2018-06-15 21:54:22 -04:00
Henk Kahlfuß
3eb9127678
Fixed #23869 -- Made ModelAdmin.get_deleted_objects() use has_delete_permission() for permissions checking.
2018-06-15 10:31:08 -04:00
Tim Graham
ec2c9c3531
Refs #29428 -- Fixed admin check crash when using a query expression in ModelAdmin.ordering.
2018-06-14 21:04:43 -04:00
Tim Graham
0d8e3e608e
Fixed #29428 -- Fixed admin changelist crash when using a query expression without asc()/desc() in the ordering.
2018-06-14 14:22:04 -04:00
Carlton Gibson
b30f9b131c
Refs #29419 , #8936 -- Removed change permission requirement for admin actions.
...
Partially reverted 825f0beda8
.
2018-06-13 14:49:28 -04:00
Tim Graham
e9bd1a3e12
Refs #28462 -- Fixed 'invalid escape sequence' warning on Python 3.6+.
2018-06-06 11:40:24 -04:00
Adam Donaghy
b18650a263
Fixed #28462 -- Decreased memory usage with ModelAdmin.list_editable.
...
Regression in 917cc288a3
.
2018-06-01 10:41:05 -04:00
Sara Heins
5008d59a2a
Fixed #28892 -- Allowed admin navbar height to expand if needed.
2018-05-29 21:52:51 -04:00
Ramiro Morales
f40e71a957
Fixed #29417 -- Corrected two admin page titles for view-only users.
2018-05-23 11:02:37 -04:00
Paulo Alvarado
ffb72a95bc
Fixed #29414 -- Restored form inputs on admin inlines when the user doesn't have the change permission.
...
Regression in 825f0beda8
.
2018-05-18 19:50:58 -04:00
Claude Paroz
77f6340d3b
Updated translation catalogs
2018-05-17 12:09:40 +02:00
olivierdalang
825f0beda8
Fixed #8936 -- Added a view permission and a read-only admin.
...
Co-authored-by: Petr Dlouhy <petr.dlouhy@email.cz>
Co-authored-by: Olivier Dalang <olivier.dalang@gmail.com>
2018-05-16 06:44:55 -04:00
T N
2405833c53
Fixed #29401 -- Updated admin's jQuery to 3.3.1.
2018-05-13 13:02:24 -04:00
Nicolas Noé
c4158d050f
Fixed #29370 -- Added choices to LogEntry.action_flag field.
2018-05-07 10:07:45 -04:00
Matthias Kestenholz
13efbb233a
Fixed #29322 -- Made admin check all ModelAdmin fieldsets for duplicates.
2018-04-13 11:08:30 -04:00
Faheel Ahmad
5d4d62bf4f
Fixed #29248 -- Renamed admin CSS class field-box to fieldBox.
2018-04-05 10:55:36 -04:00
Jon Dufresne
be6ca89396
Fixed #27991 -- Added obj arg to InlineModelAdmin.has_add_permission().
...
Thanks Vladimir Ivanov for the initial patch.
2018-04-04 19:21:50 -04:00
Nick Pope
281c0223b3
Refs #29227 -- Simplified NullBooleanField by making it subclass BooleanField.
2018-03-20 12:10:10 -04:00
Tim Graham
5fa4f40f45
Fixed #29227 -- Allowed BooleanField to be null=True.
...
Thanks Lynn Cyrin for contributing to the patch, and Nick Pope for review.
2018-03-20 12:10:10 -04:00
Hasan Ramezani
274e3e27f3
Fixed #29184 -- Made TabularInline respect model form's Meta.labels and help_texts.
2018-03-17 20:51:24 -04:00
Josh Schneier
b60e5fdbb7
Fixed #28959 -- Fixed 'No, take me back' button on admin's inline popup.
2018-03-15 20:47:18 -04:00
David Sanders
47bb3b68ff
Fixed #29219 -- Made admin filters use processed params rather than request.GET.
2018-03-15 11:33:19 -04:00
Artem Tabolin
a2f7433adc
Fixed #29221 -- Corrected admin's autocomplete widget to add a space after custom classes.
2018-03-15 10:55:34 -04:00
dzhuang
e17088a108
Fixed #29213 -- Fixed autocomplete widget's translations for zh-hans/zh-hant.
2018-03-13 10:58:34 -04:00
Daniel Hahler
683341db43
Condensed some widgets code.
2018-03-03 13:35:09 -05:00
Carlton Gibson
94a180402c
Refs #27728 -- Fixed thread safety of admin template tags.
...
Regression in 5cc28dc752
.
2018-03-01 11:45:08 -05:00
Tim Graham
4c02e3cda3
Refs #27728 -- Made cosmetic edits to admin template tag template overriding.
2018-03-01 11:45:08 -05:00
Claude Paroz
75527c0f83
Updated translations from Transifex
...
Forward port of 2126e9317e
from stable/2.0.x.
2018-02-28 20:06:52 +01:00
Raffaele Salmaso
5cc28dc752
Fixed #27728 -- Allowed overriding admin templatetags templates.
2018-02-28 08:49:40 +01:00
Becky Smith
8116e588db
Fixed #17962 -- Added ModelAdmin.get_deleted_objects().
2018-02-24 20:41:43 -05:00
Tim Graham
9822d88ca0
Removed using argument from admin's get_deleted_objects().
2018-02-24 09:21:13 -05:00
a8568730
ba37ee9ef8
Fixed #28635 -- Fixed admin's preserved filters if the URL contains non-ASCII characters.
2018-02-23 15:40:11 -05:00
Tim Graham
16436f3751
Removed unused opts argument from admin's get_deleted_objects().
...
Unused since e12b3199d0
.
2018-02-21 13:32:13 -05:00
Andreas Pelme
e307ff29d2
Fixed #27810 -- Allowed query expressions in admin_order_field.
2018-02-15 21:00:31 -05:00
Haki Benita
ff5517988a
Fixed #28933 -- Improved the efficiency of ModelAdmin.date_hierarchy queries.
2018-02-14 19:15:41 -05:00
Tim Graham
f5c9bbd3e3
Made cosmetic edits to contrib.admin.filters.
2018-02-14 13:40:24 -05:00
Haki Benita
2014db50f4
Removed redundant filtering in date_hierarchy template tag.
...
cl.queryset is already filtered by the current selections.
2018-02-13 14:12:40 -05:00
Alexander Gaevsky
ef2512b2ff
Fixed #25790 -- Allowed disable column sorting in the admin changelist.
...
Thanks Ramiro Morales for completing the patch.
2018-02-07 17:46:28 -05:00
Raffaele Salmaso
da3df5b878
Fixed #8500 -- Allowed overriding the default admin site instance.
2018-02-03 18:51:10 -05:00
Tim Graham
552abffab1
Fixed #29094 -- Fixed crash when entering an invalid uuid in ModelAdmin.raw_id_fields.
...
Regression in 2f9861d823
.
Thanks Carel Burger for the report and fix.
2018-02-01 08:36:36 -05:00
Jon Dufresne
7d607127e3
Refs #21221 -- Deprecated staticfiles and admin_static template tag libraries.
2018-01-23 10:30:10 -05:00
Jon Dufresne
ff05de760c
Fixed #29038 -- Removed closing slash from HTML void tags.
2018-01-21 02:09:10 -05:00
Tim Graham
a22ef3bb37
Removed library name from file names of admin's JavaScript library licenses.
2018-01-20 12:30:00 -05:00
Дилян Палаузов
a38ae914d8
Fixed #28996 -- Simplified some boolean constructs and removed trivial continue statements.
2018-01-12 12:44:50 -05:00
Vasilis Aggelou
777f216d55
Fixed #15522 -- Added ModelAdmin.delete_queryset() to customize "delete selected objects" deletion.
2018-01-05 18:28:45 -05:00
Paulo
d1286a8a68
Fixed #28517 -- Fixed admin delete confirmation view crash when related models don't have a delete permission.
2018-01-04 19:07:46 -05:00
Дилян Палаузов
d7b2aa24f7
Fixed #28982 -- Simplified code with and/or.
2018-01-03 20:12:23 -05:00
Jonas Haag
602481d0c9
Fixed #28986 -- Prevented boolean values in admin list display from being formatted with thousand separators.
2018-01-03 15:02:06 -05:00
Tim Graham
acc8dd4142
Fixed #28984 -- Made assorted code simplifications.
2018-01-03 13:24:02 -05:00
Дилян Палаузов
d79cf1e9e2
Fixed #28985 -- Removed unneeded None checks before hasattr().
2018-01-03 11:37:06 -05:00
Mariusz Felisiak
c815213740
Fixed #28958 -- Fixed admin changelist crash when using a query expression in the page's ordering.
...
Thanks Tim Graham for the review.
2017-12-27 18:38:30 +01:00
Дилян Палаузов
4c599ece57
Fixed #28930 -- Simplified code with any() and all().
2017-12-26 17:11:15 -05:00
Tim Graham
6deaddcca3
Fixed #28956 -- Updated admin's jQuery to 3.2.1.
2017-12-26 10:21:05 -05:00
Tim Graham
0fc4b1f31f
Refs #28956 -- Removed usage of jQuery's deprecated event methods in admin JavaScript.
2017-12-26 10:21:05 -05:00
Tim Graham
b730973fff
Refs #28956 -- Removed usage of jQuery's deprecated .selector property in admin JavaScript.
2017-12-26 10:21:05 -05:00
Tim Graham
8dbaeb6138
Updated minified admin JavaScript for the latest closure compiler.
2017-12-26 10:21:05 -05:00
Rodrigo Pinheiro Marques de Araújo
30a389bd77
Fixed #28898 -- Corrected admin check to allow a OneToOneField in ModelAdmin.autocomplete_fields.
2017-12-13 02:39:27 -05:00
Nick Pope
d13a9e44de
Fixed #28909 -- Simplified code using tuple/list/set/dict unpacking.
2017-12-11 07:08:45 -05:00
Tim Graham
02d9419fe3
Fixed #28907 -- Removed unnecessary if statements.
2017-12-07 17:12:00 -05:00