Jon Dufresne
4468c08d70
Fixed #23968 -- Replaced list comprehension with generators and dict comprehension
2014-12-08 07:58:23 -05:00
Tim Graham
5c773447c3
Tweaked fix for refs #23946 ; thanks Claude.
2014-12-02 15:57:08 -05:00
Andriy Sokolovskiy
bba545345f
Fixed #23946 -- Fixed runserver crash when socket error contains Unicode chars.
2014-12-02 12:01:51 -05:00
Matthew Somerville
9253042d53
Fixed #4444 - Made runserver suppress 'broken pipe' errors
...
One handler in WSGIServer, to catch the error when raised from
SocketServer.BaseServer's finish_request, and one in WSGIRequestHandler
(by creating a subclass of ServerHandler), to catch the error when
raised in wsgiref.handlers.BaseHandler's finish_response.
2014-11-28 10:51:15 -05:00
Tim Heap
deb607648e
Fixed #23728 -- Added the --exit option to makemigrations.
...
If no changes that need migrations are found, `makemigrations --exit`
exits with error code 1.
2014-11-28 07:48:39 -05:00
Martin Blech
e023ceb453
Fixed #23910 -- Added reply_to parameter to EmailMessage
...
Thanks to Berker Peksag and Tim Graham for the review and suggestions.
2014-11-28 06:00:06 -05:00
Martin Blech
abf87333a1
Fixed #23924 -- Made EmailMessage raise TypeError for type checks
2014-11-27 18:43:45 -05:00
Berker Peksag
093e6c68b9
Fixed #14664 -- Logged a warning if MiddlewareNotUsed is raised in DEBUG mode.
2014-11-27 07:55:07 -05:00
Martin Blech
4c123d0f79
Fixed #23899 -- Added 'Generated by Django X.Y' to startproject template.
2014-11-25 09:41:56 -05:00
Sergey Fedoseev
1e9ac504e4
Fixed #23888 -- Fixed crash in File.__repr__() when name contains unicode.
2014-11-24 15:54:57 -05:00
Tim Graham
ebb927c4c9
Removed workaround for lack of os.getpid() in Jython.
...
The Jython bug was fixed in http://bugs.jython.org/issue1518
(tested on Jython 2.7b3); also updated make_msgid() to be more like
the version in Python 3.2+; refs #23905 .
Thanks Simon Charette for testing and review.
2014-11-24 14:01:15 -05:00
Berker Peksag
a5bd7f2cb2
Fixed #13694 -- Made SafeMIMEText's constructor compatible with MIMEText.
2014-11-24 13:28:58 -05:00
Carl Meyer
bcb693ebd4
Revert "Fixed #23892 -- Made deconstructible classes forwards compatible"
...
This reverts commit f36151ed16
.
Adding kwargs to deconstructed objects does not achieve useful
forward-compatibility in general, since additional arguments are silently
dropped rather than having their intended effect. In fact, it can make the
failure more difficult to diagnose. Thanks Shai Berger for discussion.
2014-11-22 22:29:23 -07:00
Carl Meyer
f36151ed16
Fixed #23892 -- Made deconstructible classes forwards compatible
2014-11-22 14:30:14 -07:00
Claude Paroz
b38637d581
Fixed #23887 -- Returned Bad Request for multipart parsing fails
...
Thanks Antti Häyrynen and Tim Graham for the report, and Aymeric
Augustin for the review.
2014-11-22 14:23:37 +01:00
Brad Walker
54d3dcbc51
Removed reduce() usage in makemigrations; refs #23796 .
...
A lambda all_items_equal() replaced a reduce() that was broken for potential
3+-way merges. A reduce(operator.eq, ...) accumulates bools and can't
generically check equality of all items in a sequence:
>>> bool(reduce(operator.eq, [('migrations', '0001_initial')] * 3))
False
The code now counts the number of common ancestors to calculate slice offsets
for the branches. Each branch shares the same number of common ancestors.
The common_ancestor for loop statement had incomplete branch coverage.
2014-11-20 14:33:30 -05:00
Brad Walker
cfa26f29bd
Reduced reduce() usage; refs #23796 .
...
django.core.exceptions.ValidationError.messages() and
django.db.backends.schema.BaseDatabaseSchemaEditor._alter_field():
Replaced reduce(operator.add, ...) w/uncoupled, explicit sum()
2014-11-20 14:31:14 -05:00
Anton Baklanov
d63703f1cd
Fixed #18714 -- Added 'fuzzy' compilemessages option
2014-11-18 22:44:16 +01:00
Tillmann Karras
d188101319
Fixed #23799 -- Made makemigrations respect --no-optimize.
...
Thanks to yamila-moreno for the idea of a skip message.
2014-11-18 07:37:06 +01:00
Claude Paroz
684b2077b3
Improved readability of negative condition in makemessages
...
Thanks Berker Peksag for the suggestion.
2014-11-17 13:42:14 +01:00
Claude Paroz
6a05f0dfe3
Simplified handle_extensions management utility
...
makemessages now doesn't need any special ignoring logic, after
commit bb4a92d784
.
2014-11-17 09:24:56 +01:00
Ilja Maas
bb4a92d784
Fixed #23840 -- Fixed makemessages find_files method
...
Changed the handling of extensions to be used for gettext. Now
obeying the --extension argument. find_files now only find the
given or default extensions and puts only these in the
TranslatableFiles. As a result there are no more confusing messages
for filetypes (extension) not handled by makemessages.
2014-11-17 09:21:24 +01:00
Berker Peksag
d2d6c0c097
Fixed #21363 -- Added datetime.timedelta support to TimestampSigner.unsign().
2014-11-15 19:36:33 +01:00
Claude Paroz
35dac5070b
Added a new GeoJSON serialization format for GeoDjango
...
Thanks Reinout van Rees for the review.
2014-11-15 18:07:18 +01:00
Michael Manfre
a305695f28
Merge pull request #3481 from manfre/ticket-16358
...
Fixed #16358 - Made memcache backend delete old value on a failure to set.
2014-11-13 22:10:22 -05:00
Tim Graham
c24a2e6cbd
Fixed #23765 -- Removed BooleanField default check which often yielded false positives.
2014-11-13 20:12:29 +01:00
Michael Manfre
bc8abe36ba
Fixed #16358 - Made memcache backend delete old value on a failure to set.
...
Default Memcached configuration allows for a maximum object of 1MB and
will fail to set the key if it is too large. The key will be deleted from
memcached if it fails to be set. This is needed to avoid an issue with
cache_db session backend using the old value stored in memcached, instead
of the newer value stored in the database.
2014-11-13 00:46:03 -05:00
Aymeric Augustin
f742c653e0
Removed return from __init__.
...
__init__ isn't allowed to return anything other than None and it isn't
common practice to include a return statement.
2014-11-12 21:26:31 +01:00
Aymeric Augustin
3bc7a14ea5
Normalized opening a file and decoding its content.
...
`io.open` is required on Python 2.7. Just `open` would work on Python 3.
2014-11-11 22:54:27 +01:00
Aymeric Augustin
95b8323ac2
Removed import forgotten in previous commit.
2014-11-11 22:54:26 +01:00
Claude Paroz
5ec367ccdd
Fixed #23788 -- Used new JavaScript support in recent gettext
...
JavaScript string extraction support has been added in gettext
0.18.3.
Thanks Aymeric Augustin for the review.
2014-11-11 22:52:30 +01:00
Aymeric Augustin
b8ba73cd0c
Raised SuspiciousFileOperation in safe_join.
...
Added a test for the condition safe_join is designed to prevent.
Previously, a generic ValueError was raised. It was impossible to tell
an intentional exception raised to implement safe_join's contract from
an unintentional exception caused by incorrect inputs or unexpected
conditions. That resulted in bizarre exception catching patterns, which
this patch removes.
Since safe_join is a private API and since the change is unlikely to
create security issues for users who use it anyway -- at worst, an
uncaught SuspiciousFileOperation exception will bubble up -- it isn't
documented.
2014-11-11 19:05:14 +01:00
averybigant
b7a5b6ab86
Fixed #23750 -- Allowed core.checks.register to be used as a function
2014-11-11 16:29:32 +01:00
Veres Lajos
a71a2ea756
Fixed typos using https://github.com/vlajos/misspell_fixer
2014-11-03 20:59:30 -05:00
Konrad Świat
934a16dc93
Fixed #23468 -- Added checks for duplicate fixtures directories in loaddata.
...
If settings.FIXTURE_DIRS contains duplicates or a default fixture
directory (app_name/fixtures), ImproperlyConfigured is raised.
Thanks to Berker Peksag and Tim Graham for review.
2014-10-31 18:21:54 -04:00
Matthew Somerville
cc25bfebd5
Clarified BaseCommand --traceback behavior.
2014-10-30 14:15:31 -04:00
Jon Dufresne
eb4f6de980
Fixed #8149 -- Made File.__iter__() support universal newlines.
...
The following are recognized as ending a line: the Unix end-of-line
convention '\n', the Windows convention '\r\n', and the old
Macintosh convention '\r'.
http://www.python.org/dev/peps/pep-0278
Thanks tchaumeny for review.
2014-10-30 11:52:59 -04:00
Claude Paroz
528c9af543
Fixed #23717 -- Fixed makemessages crash when STATIC_ROOT=None
2014-10-27 13:56:25 +01:00
Tony Zhu
dd1ea70779
Fixed #23699 -- Prevented flush from loading initial data for apps with migrations.
2014-10-27 06:56:44 -04:00
Loic Bistuer
eb82fb0a9d
Refactored color_style() and no_style() to improve testability. Refs #23663 .
...
This includes the following improvements:
- The type of the style object is now called 'Style' rather than 'dummy'.
- The new make_style() function allows generating a Style object directly
from a config string. Before the only way to get a style object was
through the environ and it also required that the terminal supported
colors which isn't necessarily the case when testing.
- The output of no_style() is now cached with @lru_cache.
- The output of no_style() now has the same set of attributes as the
other Style objects. Previously it allowed anything to pass through
with __getattr__.
2014-10-22 11:27:00 +07:00
Loic Bistuer
bdb4118b1a
Fixed #23686 -- Tweak color output of the system check framework.
...
Thanks Tim Graham for the review.
2014-10-22 11:27:00 +07:00
Loic Bistuer
533532302a
Fixed #23663 -- Initialize output streams for BaseCommand in __init__().
...
This helps with testability of management commands.
Thanks to trac username daveoncode for the report and to
Tim Graham and Claude Paroz for the reviews.
2014-10-22 09:25:50 +07:00
Claude Paroz
8b4cc9df9c
Fixed #23583 -- More selectively ignored static/media roots
...
Fixed a regression introduced by 28efafa24c
.
Thanks Michal Čihař for the report and initial patch, and
Collin Anderson and Tim Graham for the reviews.
2014-10-21 20:18:21 +02:00
Loic Bistuer
c34e13e17c
Fixed #23107 -- Made runserver output respect --no-color.
...
This commit reverts 67d7da5fb9
.
The previous fix changed the environment globally, which meant
that any call to `call_command(no_color=True)` prevented further
`call_command` with color.
This fix still relies on the environment because it's currently the only
way to reach WSGIRequestHandler, but it's now limited to the `runserver`
command. This seems an acceptable compromise considering `runserver` runs
indefinitely.
Thanks Tim Graham for the review.
2014-10-22 01:03:15 +07:00
Claude Paroz
4fe6824ffd
Fixed #23679 -- Fixed null introspection for char/text fields
...
Thanks Paul Dejean for the report.
2014-10-20 22:37:19 +02:00
Claude Paroz
b8f2c972d0
Removed redundant skip_checks option for call_command
2014-10-20 17:26:00 +02:00
Claude Paroz
6d11bb102d
Revert "Fixed #23650 -- Prevented migrate from calling checks 3 times"
...
This reverts commit 8d6e1afe0b
.
call_command now always set skip_checks to True (tested in
user_commands).
2014-10-20 17:26:00 +02:00
Claude Paroz
685edab9da
Fixed #23685 -- Made call_command skip checks by default
...
Thanks Loic Bistuer for the report/review and Tim Graham for the
review.
2014-10-20 17:26:00 +02:00
Loic Bistuer
c974b7bbe0
Renamed skip_validation into skip_checks as the former is now deprecated.
2014-10-19 18:00:54 +07:00
Loic Bistuer
ec8a2e3b07
Prevented syncdb from calling system checks multiple times. Refs #23650 .
2014-10-19 18:00:53 +07:00
Claude Paroz
8d6e1afe0b
Fixed #23650 -- Prevented migrate from calling checks 3 times
...
Thanks Ilya Baryshev for the report and Tim Graham for the review.
2014-10-17 20:20:56 +02:00
Tim Graham
7ae03204ac
Fixed #23469 -- Removed test runner compatibility check which often yielded false positives.
2014-10-17 10:31:49 -04:00
Rigel Di Scala
a5c77417a6
Fixed #23615 -- Validate that a Model instance's "check" attribute is a method.
...
The "check" name is a reserved word used by Django's check framework,
and cannot be redefined as something else other than a method, or the check
framework will raise an error.
This change amends the django.core.checks.model_check.check_all_models()
function, so that it verifies that a model instance's attribute "check"
is actually a method. This new check is assigned the id "models.E020".
2014-10-16 23:49:21 +07:00
Collin Anderson
a6a8268d19
Fixed #23660 -- Moved sort_dependencies to core.
2014-10-16 03:04:13 +07:00
Anubhav Joshi
10b17a22be
Fixed #19508 -- Implemented uri_to_iri as per RFC.
...
Thanks Loic Bistuer for helping in shaping the patch and Claude Paroz
for the review.
2014-10-16 02:31:17 +07:00
Claude Paroz
59d487e7fc
Fixed #23638 -- Prevented crash while parsing invalid cookie content
...
Thanks Philip Gatt for the report and Tim Graham for the review.
2014-10-13 17:37:58 +02:00
Florian Apolloner
8d789449c7
Fixed #23063 -- Convert \n and \r to \r\n when using the SMTP backend as per RFC.
2014-10-12 22:01:24 +02:00
Thomas Chaumeny
6448dd8335
Fixed #23642 -- Made LocMemCache.incr() thread-safe as documented
2014-10-12 23:47:48 +07:00
Jaap Roes
1b5918f160
Fixed #23625 -- Removed CacheClass shim
2014-10-10 08:43:26 -04:00
Brandon Taylor
16ed35fafc
Fixed #23612 -- Normalized fixuture paths to allow referencing relative paths on Windows.
2014-10-09 14:58:20 -04:00
Jon Dufresne
c1ef234e31
Fixed #23522 -- Changed reverse() to return a Unicode string; not bytes
2014-10-07 13:06:39 -04:00
Markus Holtermann
2f16ff5a6c
Fixed #23601 -- Ensured view exists in URLconf before importing it in admindocs.
2014-10-06 09:31:39 -04:00
Thomas Chaumeny
b2aad7b836
Replaced set([foo, ...]) by {foo, ...} literals. Refs PR 3282.
...
Thanks Collin Anderson for the review.
2014-09-29 00:01:38 +07:00
Claude Paroz
e1fbb68e4e
Updated comment about Python issue
2014-09-27 22:48:30 +02:00
Marco Buttu
e077c29155
Fixed #23551 -- Fixed bash autocompletion crash on Python 3.
2014-09-25 07:44:22 -04:00
Claude Paroz
ed297061a6
Fixed #18782 -- Prevented sql_flush to flush views
...
Thanks rodolfo_3 for the report and the initial patch, and
Josh Smeaton, Shai Berger and Tim Graham for the reviews.
2014-09-23 20:13:31 +02:00
José Padilla
5472d18e31
Fixed #23461 -- Added EMAIL_TIMEOUT setting
2014-09-13 09:33:21 -04:00
Tim Graham
52ef6a4726
Fixed #17101 -- Integrated django-secure and added check --deploy option
...
Thanks Carl Meyer for django-secure and for reviewing.
Thanks also to Zach Borboa, Erik Romijn, Collin Anderson, and
Jorge Carleitao for reviews.
2014-09-12 15:05:23 -04:00
Andi Albrecht
00535e8e6b
Fixed #20743 -- Added support for keyfile/certfile in SMTP connections.
...
Thanks jwmayfield, serg.partizan, and Wojciech Banaś for work on the patch.
2014-09-10 11:14:20 -04:00
Flavio Curella
c53f2451a8
Fixed #23398 -- Added helpful error message when runserver is accessed via HTTPS
2014-09-09 12:29:30 -04:00
Tim Graham
0e4d79c4f0
Fixed #22882 -- Fixed a UnicodeDecodeError in flush.
...
Thanks djbaldey for the report.
2014-09-06 10:07:34 -04:00
Tim Graham
1101467ce0
Limited lines to 119 characters in django/
...
refs #23395 .
2014-09-05 09:22:16 -04:00
Raffaele Salmaso
1435cfbe8d
Fixed #23302 -- Added --name/-n option to makemigrations command
2014-09-02 21:09:18 -04:00
Bas Peschier
eacf244506
Converted sql_queries into a lazily evaluated list.
...
Fixed #23364 . Thanks Markush2010 for the report.
2014-08-30 13:27:56 +02:00
Joshua "jag" Ginsberg
eb2af16c59
Fixed #21483 -- Added WSGI environ to kwargs sent to request_started signal.
2014-08-29 10:12:03 -04:00
Tim Graham
cf33777306
Clarified a comment in django.core.files.temp.
2014-08-29 07:27:15 -04:00
Simon Charette
1e404180c1
Fixed #23379 -- Corrected a referencing issue in sql_create.
...
Thanks to Trac alias flakfizer for the report.
2014-08-28 15:17:50 -04:00
areski
0396cd8f19
Fixed #23327 -- Added 'zero' syntax to migrate help message
2014-08-22 13:40:14 -04:00
Tim Graham
0d8d30b7dd
Fixed #23157 -- Removed O(n) algorithm when uploading duplicate file names.
...
This is a security fix. Disclosure following shortly.
2014-08-20 14:39:40 -04:00
Florian Apolloner
28e765810d
Prevented reverse() from generating URLs pointing to other hosts.
...
This is a security fix. Disclosure following shortly.
2014-08-20 14:39:40 -04:00
Gabriel Muñumel
3e241313a4
Fixed #23136 -- Added a message when sqlclear does nothing
2014-08-18 13:20:29 -04:00
Baptiste Mispelon
5853c87a45
Fixed #23303 -- Added BEGIN and COMMIT statements to the output of sqlmigrate.
2014-08-18 18:55:12 +02:00
Ramiro Morales
152afadef1
Merge pull request #3075 from ramiro/makemessages-ignore-windows
...
Fixed #23298 -- Made makemessages actually ignore specified dirs on Wind...
2014-08-18 13:33:02 -03:00
Raffaele Salmaso
e0a98e2374
Fixed #23309 -- Fixed call_command to parse args correctly
2014-08-18 17:54:24 +02:00
Ramiro Morales
b4dce7c37a
Fixed #23298 -- Made makemessages actually ignore specified dirs on Windows.
...
This was detected by two failures in the i18n.test_extraction of our
test suite.
Refs #20422 , refs #22336
2014-08-15 16:19:04 -03:00
Ramiro Morales
0bfb538661
Fixed #23291 -- Don't add Unicode varname/value to environment.
...
Windows doesn't like that and it causes 114 failures in the
admin_scripts tests with Python 2.x.
2014-08-14 12:22:21 -03:00
Claude Paroz
055d95fce0
Fixed #23265 -- Used system-specific encoding in runserver
...
Thanks SpaceFox for the report.
2014-08-14 12:08:06 +02:00
Tim Graham
7f4be9cbc2
Fixed flake8 warning.
2014-08-13 12:33:18 -04:00
Claude Paroz
2cc8ffe258
Fixed #22985 -- Made call_command accept option name parameter
...
Thanks giulettamasina for the report and Tim Graham for the review.
2014-08-12 21:53:29 +02:00
Claude Paroz
dc462a8ed5
Removed unused migrate option
2014-08-09 17:13:00 +02:00
Justin Hamade
8fe406864c
Fixed #22336 -- Added path matching for makemessages ignore option
...
This fixes a regression introduced by 9012a9e200
.
2014-08-08 22:54:30 +02:00
Florian Apolloner
2d542bf60c
Ensured that Paginator.page_range works the same on Python 2 and 3.
...
This somewhat fixes #23088 , refs 23140.
2014-08-03 21:10:00 +02:00
Florian Apolloner
40fb6a5601
Revert "Fixed #23088 -- Used `six` `range` type in `Paginator.page_range`."
...
This reverts commit 6508db2ff9
.
Refs #23088 .
2014-08-03 21:08:24 +02:00
Christoph Heer
d47409831f
Fixed #23067 -- Updated docs to use django-admin
2014-07-30 14:14:03 -04:00
areski
67d7da5fb9
Fixed #23107 -- Made runserver output respect --no-color.
2014-07-30 12:58:53 -04:00
Andrew Godwin
096a5de5d2
Fixed #23092 : Squashing handles external dependencies
2014-07-29 10:22:00 -07:00
Andrew Godwin
8ebd6d35d7
Fixed #23090 : Document and enforce not double-squashing migrations
2014-07-29 10:02:59 -07:00
Florian Apolloner
2ab0ed7b28
Only warn about initial data if fixtures have been found.
2014-07-27 13:23:16 +02:00
Anubhav Joshi
5cdb8f8c1e
Fixed #16617 -- Added 'value' to BaseValidator params.
...
Also allowed overriding the default messages in subclasses of BaseValidator.
Thanks sperrygrove for initial patch.
2014-07-26 10:03:00 -04:00
Andrew Godwin
f44dbf74a4
Mark initial_data as deprecated separately from syncdb. Refs #23077 .
2014-07-25 09:09:15 -07:00
Moayad Mardini
6508db2ff9
Fixed #23088 -- Used `six` `range` type in `Paginator.page_range`.
2014-07-25 11:04:58 +03:00
Damien Nozay
70c54a3694
Fixed #23028 : Added unique_togther support to inspectdb.
2014-07-18 16:10:59 +00:00
Claude Paroz
28efafa24c
Ignored STATIC_ROOT and MEDIA_ROOT in makemessages
...
Also alleviate issues with weird file names typically found in
MEDIA_ROOT directories (#23010 ).
Thanks Tim Graham for the review.
2014-07-16 09:38:57 +02:00
Huu Nguyen
f7a78f9bba
Fixed #22791 -- Invoke interactive questioner only for conflicts in specified apps.
...
Thanks bendavis78 for the report and Tim Graham for the review.
2014-07-14 11:00:49 -04:00
Tim Graham
b48c2c5925
Removed extra newline.
2014-07-12 10:16:53 -04:00
Andrew Godwin
ebb13bbd88
Fixed #22983 : Alert when squashing RunPython operations with referred functions.
2014-07-11 19:00:39 -07:00
Claude Paroz
e167e96cfe
Fixed #22223 -- Prevented over-escaping URLs in reverse()
...
And follow more closely the class of characters defined in the
RFC 3986.
Thanks Erik van Zijst for the report and the initial patch, and
Tim Graham for the review.
2014-07-09 09:54:34 +02:00
Claude Paroz
b144bfb5ce
Fixed #21079 -- Further normalized table names in inspectdb
...
Thanks Michael Manfre for the report and Tim Graham for the review.
2014-07-06 21:19:27 +02:00
Daniel Hahler
67f9f385aa
Fixed various minor doc typos / references.
2014-07-05 20:26:26 -04:00
Tim Graham
1f8bb95cc2
Corrected domain max length for EmailValidator; refs #20631 .
...
Thanks MarkusH for the report.
2014-07-04 20:50:28 -04:00
Tim Graham
7fd55c3481
Fixed #20631 -- Increased the default EmailField max_length to 254.
...
Thanks pmartin for the report.
2014-07-04 14:15:00 -04:00
Loic Bistuer
1966054feb
Fixed #22915 -- Document backward incompatible changes in the ValidationError constructor.
...
This patch also fixes update_error_dict to better handle the use case described
in this ticket, previously the type of the provided container could be lost in
some conditions.
Thanks Russell Keith-Magee for the report and Tim Graham for review.
2014-07-04 17:05:31 +07:00
Ian Foote
4c39c270af
Add missing spaces to implicitly joined strings
2014-06-29 22:56:21 +01:00
Anubhav Joshi
dbbcfca476
Fixed #21668 -- Return detailed error page when SuspiciousOperation is raised and DEBUG=True
...
Thanks GDorn and gox21 for report.
Thanks Tim Graham for idea and review.
2014-06-24 08:55:36 -04:00
Andrew Godwin
0fba4c0ed7
Fixed #22487 : Don't flush out data from before normal TestCases
2014-06-23 20:25:09 -07:00
Anubhav Joshi
7f76251fb7
Refactored common code in handlers/base.py and urlresolvers.py
2014-06-23 15:27:25 -04:00
Claude Paroz
9618d68b34
Fixed #8033 -- Explained app registry error during translation setup
...
Thanks Tim Graham and Aymeric Augustin for the review.
2014-06-23 09:31:45 +02:00
Andrew Godwin
ecc06d44ed
Clean up syncdb parts of migrate output if no synced apps
2014-06-22 13:03:25 -07:00
Huu Nguyen
fbb684d95e
Fixed #22862 -- Added --noinput option to makemigrations.
...
Thanks artortenburger for the report.
2014-06-20 08:55:02 -04:00
Claude Paroz
b67e9ed8c9
Swapped placeholders in [sql]migrate command error
2014-06-20 13:53:17 +02:00
Andrew Godwin
9f4852f649
Fixed #22863 : Improve clarity of makemigrations for non-db params
2014-06-19 23:41:32 -07:00
Maxime Turcotte
9996158db4
Fixed #22835 -- Deprecated NoArgsCommand.
2014-06-19 08:54:59 -04:00
Vincent-Vega
4529af9ecf
Fixed #22845 -- Correctly handled memcached default timeout value.
2014-06-16 16:34:00 -04:00
Andrew Godwin
2b79be2bee
Fixed #22848 : Ignore no-migrations errors during makemigrations only
2014-06-16 09:58:35 -07:00
Claude Paroz
c24e979ece
Fixed #7762 -- Hidden full script name in command error output
2014-06-14 20:01:02 +02:00
Claude Paroz
5949c2118d
Restored command error behavior when called from command line
...
Refs #19973 .
2014-06-14 18:53:33 +02:00
Alex Gaynor
2ca5fc55b0
Fixed several flake8 errors
2014-06-14 10:20:42 -04:00
Claude Paroz
f17b24e407
Converted remaining management commands to argparse
2014-06-14 13:43:44 +02:00
Claude Paroz
4b4524291a
Converted test management command to argparse
...
Keeping backwards compatibility with test_runner.option_list is
tricky and would imply transforming an optparse.Option to an
argparse.Action. I choose to introduce a backwards incompatible
change because it only affects testing, not runtime behavior.
2014-06-14 13:43:39 +02:00
Claude Paroz
8568638603
Fixed #19973 -- Replaced optparse by argparse in management commands
...
Thanks Tim Graham for the review.
2014-06-14 11:17:48 +02:00
mlavin
4696cd9671
Fixed #22477 -- Removed contrib middleware from the global settings defaults.
...
Also added a compatibility check for changed middleware defaults.
Forwardport of d94de802d3
from stable/1.7.x
2014-06-13 12:45:56 -04:00
Loic Bistuer
6e8d614acd
Made the vendored NamedTemporaryFile work as a context manager. Refs #22680 .
...
This fixes a regression on Windows introduced by b7de5f5
.
Thanks Tim Graham for the report and review.
2014-06-12 08:07:34 +07:00
Florian Apolloner
e2efc8965e
Fixed #22680 -- I/O operation on closed file.
...
This patch is two-fold; first it ensure that Django does close everything in
request.FILES at the end of the request and secondly the storage system should
no longer close any files during save, it's up to the caller to handle that --
or let Django close the files at the end of the request.
2014-06-11 08:57:30 +02:00
Tim Graham
93d05536fd
Fixed #22770 -- Removed create_superuser from post_migrate signals.
...
Moved logic to syncdb command for backwards compatibility.
2014-06-10 14:37:37 -04:00
Andrew Godwin
8c12d51ea2
Fixed #22487 : Optional rollback emulation for migrated apps
2014-06-08 19:30:15 -07:00
Andrew Godwin
3f91238adf
Fixed #22777 : Add dependency on through for autodetected M2M adds
2014-06-08 17:12:59 -07:00
Víðir Valberg Guðmundsson
f70f669941
Fixed #22749 : Making SQL management commands migration aware.
2014-06-07 17:18:30 -07:00
Aymeric Augustin
47a9347b98
Fixed #6992 -- Improved error when middleware omits HttpResponse.
...
Thanks guettli for the report.
2014-06-07 19:48:45 +02:00
Unai Zalakain
11284a63d4
Fixed #18314 -- Corrected request.build_absolute_uri() handling of paths starting with //
...
``HttpRequest.build_absolute_uri()`` now correctly handles paths starting with ``//``.
``WSGIRequest`` now doesn't remove all the leading slashes either,
because ``http://test/server `` and http://test//server `` aren't the same thing
(RFC2396).
Thanks to SmileyChris for the initial patch.
2014-06-07 08:59:02 -04:00
Moayad Mardini
4f72e5f03a
Fixed #21773 -- made daemon threads default in the development server.
...
Thanks clime for the report.
2014-06-05 12:26:24 -04:00
Claude Paroz
fb9d8f0652
Fixed #22717 -- Auto-corrected missing ending slash in FileSystemStorage
...
Thanks David Fischer for the report and Moayad Mardini for the
review.
2014-06-04 08:53:17 +02:00
Tim Graham
4445d36d47
Fixed #22384 -- Deprecated reversing URLs by dotted path.
2014-06-03 07:30:14 -04:00
Florian Apolloner
83e7555ffe
Revert "Making SQL management commands migration aware."
...
This reverts commit cb9c9a7b58
.
2014-06-01 12:00:09 +02:00
Andrew Godwin
67d9f70e4c
Fix test failure caused by 3149cdce32
2014-05-29 15:34:35 -07:00
Víðir Valberg Guðmundsson
cb9c9a7b58
Making SQL management commands migration aware.
2014-05-29 23:03:10 +02:00
Alex Gaynor
1dcc603eff
Fixed several typos in Django
2014-05-28 17:39:14 -07:00
Simon Charette
d0f7c7f59a
Argument to `reversed` must be a sequence on Py3.
2014-05-27 18:28:13 -04:00
Simon Charette
fed2877cf1
Fix a regression introduced by f011b90363
.
...
`django.get_version` was actually used by the module.
2014-05-27 18:23:44 -04:00
Claude Paroz
f011b90363
Removed an old compatibility shim added in 1.0
2014-05-27 22:28:49 +02:00
Claude Paroz
fe53bc524b
Fixed #21630 -- Simplified management command discovery
...
Thanks Aymeric Augustin for the report end the review.
2014-05-27 22:18:51 +02:00
Aymeric Augustin
4865326f22
Fixed #22699 -- Configure default settings in some management commands.
...
This makes it possible to run django.setup() in management commands that
don't need a settings module. In addition it simplifies error handling.
Thanks Claude for the review.
2014-05-27 21:43:52 +02:00
Moayad Mardini
2e613ea5c5
Fixed #22675 -- makemigrations --dry-run to output migrations to stdout.
...
`makemigrations --dry-run` will output the complete migrations file
that would be written if it's used along with `--verbosity 3`.
2014-05-27 00:40:55 +03:00
Florian Apolloner
9d1bf8f841
Removed executeable bit from a few files.
2014-05-25 23:16:40 +02:00
Loic Bistuer
b7de5f5d3f
Fixed a few ResourceWarning in the test suite. Refs #22680 .
2014-05-26 03:23:17 +07:00
Moayad Mardini
63fc91b3ca
Fixed #22676 -- makemigrations --dry-run should not ask for defaults
...
Made the fix in InteractiveMigrationQuestioner class code, rather than
MigrationAutodetector, because --dry-run shouldn't affect whether
MigrationAutodetector will detect non-nullable fields, but the
questioner should skip the question and returns a None for default
(since that won't be used anyway) if --dry-run is used.
2014-05-24 09:56:18 -04:00
Claude Paroz
dbb48d2bb9
Applied unicode_literals to makemessages command
...
This also fixes #22686 as some sort of side-effect.
2014-05-24 11:51:57 +02:00
Thomas Grainger
46082339d2
the SECRET_KEY is not a hash
2014-05-22 11:19:54 +01:00
Ramiro Morales
fce6a29428
Merge pull request #2498 from ramiro/move-serverhandler
...
Moved ServerHandler helper class to tests.
2014-05-21 18:59:01 -03:00
Claude Paroz
7999ed9b69
Updated Django makemessages process
...
makemessages should now automatically distribute translatable
strings in the proper locale files, for Django too
(see 50a8ab7cd1
).
2014-05-19 09:30:26 +02:00
Tim Graham
c7a4ae94a0
Removed some unnecessary exception naming; thanks claudep.
2014-05-18 17:42:03 -04:00
Esau Rodriguez
ec9043ab2f
Fixed #21799 - Modified loaddata --ignorenonexistent to ignore models.
2014-05-18 15:52:07 -04:00
Erik Romijn
424fe76349
Fixed #22579 -- Corrected validation for email to reject trailing slash
...
Thanks to Claude Paroz for the report and patch and Tomasz
Paczkowski for the review.
2014-05-16 15:13:11 +02:00
Claude Paroz
f5d4b45df1
Fixed #21634 -- Prevented hiding ImproperlyConfigured when command not found
...
Thanks nikolay.v.golub@gmail.com for the report.
2014-05-16 12:08:31 +02:00
Claude Paroz
e520a73eee
Harmonized some PEP 0263 coding preambles
2014-05-15 19:58:41 +02:00
Aymeric Augustin
3800f63721
Dropped fix_IE_for_vary/attach.
...
This is a security fix. Disclosure following shortly.
2014-05-14 10:19:48 +02:00
Ramiro Morales
a9b7f31bfc
Completed long overdue sqlinitialdata deprecation.
2014-05-11 23:15:59 -03:00
Rainer Koirikivi
a75324c654
Fixed #14226 -- Dependency calculation for complex M2M relations.
...
`sort_dependencies` incorrectly interpreted 'complex' M2M relations
(with explicit through models) as dependencies for a model. This caused
circular complex M2M relations to be unserializable by dumpdata.
Thanks to aneil for the report and outofculture for initial tests.
2014-05-11 19:50:01 -03:00
Malcolm Box
66880e4cd1
Fixed #22606 -- Locmemcache has_key() failed for infinite cache expiry
...
Refactored cache expiry logic for Locmemcache to make consistent across
all places where accessed, and correctly handle None as expiry time.
2014-05-09 18:35:07 +02:00
David Szotten
7fe60ae64a
Fixed #22588 -- Fix RegexValidator __eq__
...
Compare parameters instead of re.pattern instances, and add the other
parameters to the comparison. Also add a __ne__ to make assertNotEqual
work properly.
2014-05-08 19:51:15 -07:00
Claude Paroz
fc32e9c0d9
Removed unused imports in makemigrations
2014-05-08 19:39:43 +02:00
Andrew Godwin
f9d7e18dc5
Fixed #22576 : Ensure makemigrations doesn't touch the database.
2014-05-06 22:41:59 -07:00
Andrew Godwin
6944418277
Fixed #22337 : FileSystemStorage marked as deconstructible and tested.
2014-05-06 22:23:23 -07:00
Loic Bistuer
d1799233f4
Fixed clash caused by the newly introduced -e shorthand for makemessages --exclude.
...
This fixes a regression caused by 0707b82
. Refs #22328 .
2014-05-02 23:07:17 +07:00
Andrew Godwin
e049c88603
Cleanup failing test w/contenttypes and remove useless graph load
2014-04-30 15:11:52 -07:00
Andrew Godwin
8f6dff372b
Fixed #22485 : Include all unmigrated apps in project state by default.
2014-04-30 12:25:12 -07:00
Tim Graham
d9c272b22f
Removed unused import.
2014-04-30 07:23:39 -04:00
Bruno Ribeiro da Silva
83413c53d2
Fixed #22511 -- Added args to migrations management commands.
2014-04-30 07:15:03 -04:00
Ramiro Morales
2df7238512
Removed bogus, ineffective 'U' flag from codecs.open() call.
2014-04-29 07:46:54 -03:00
Aymeric Augustin
8b5b199e20
Fixed #3214 -- Stopped parsing SQL with regex.
...
Avoided introducing a new regex-based SQL splitter in the migrations
framework, before we're bound by backwards compatibility.
Adapted this change to the legacy "initial SQL data" feature, even
though it's already deprecated, in order to facilitate the transition
to migrations.
sqlparse becomes mandatory for RunSQL on some databases (all but
PostgreSQL). There's no API to provide a single statement and tell
Django not to attempt splitting. Since we have a more robust splitting
implementation, that seems like a good tradeoff. It's easier to add a
new keyword argument later if necessary than to remove one.
Many people contributed to both tickets, thank you all, and especially
Claude for the review.
Refs #22401 .
2014-04-26 17:46:23 +02:00
Ana Krivokapic
0707b824fe
Fixed #22328 -- Added --exclude option to compilemessages and makemessages.
2014-04-26 17:07:44 +07:00
Kevin Christopher Henry
91afc00513
Fixed #21157 -- Fixed problems with ResolverMatch
...
- Fixed bug in get_callable() that caused resolve() to put a string
in ResolverMatch.func.
- Made ResolverMatch.url_name match the actual url name (or None).
- Updated tests that used the string value in ResolverMatch.func, and
added regression tests for this bug.
- Corrected test urls whose dummy view paths caused failures (behavior
that was previously masked by this bug).
2014-04-23 20:12:34 -04:00
Claude Paroz
3a435a057c
Set compile messages options as class variable
...
Refs #18714 . Same logic as options for makemessages commands.
2014-04-23 15:15:03 +02:00
Malcolm Box
af5f688392
Fixed #22495 -- Locmem cache.add() failed with infinite timeouts
...
cache.add() incorrectly succeeded when there was an existing key
with an infinite (None) timeout.
2014-04-23 14:49:46 +02:00
Preston Timmons
3c06b2f2a3
Fixed #22486 -- Restored the ability to reverse views created using functools.partial.
...
Regression in 8b93b31487
.
Thanks rcoup for the report.
2014-04-23 07:27:52 -04:00
Tim Graham
8b93b31487
Fixed a remote code execution vulnerabilty in URL reversing.
...
Thanks Benjamin Bach for the report and initial patch.
This is a security fix; disclosure to follow shortly.
2014-04-21 18:11:26 -04:00
Florian Apolloner
405b13fe83
Fixed migrate when called inside a transaction.
...
This is useful for tests manually calling migrate inside a testcase,
for normal usage this should make no difference, since there is no
surrounding transaction after all. If there is one we still try to
leave the transaction in a useable state (for postgres at least).
If this commit turns out to be causing issues, settings savepoint=False
is probably the right fix :)
2014-04-21 15:37:12 +02:00
Aymeric Augustin
428c0bbe1b
Appeased flake8 2.1.0.
2014-04-21 12:27:34 +02:00
Claude Paroz
275811a93c
Adapted fixture read mode to file type
...
Binary mode added in ed532a6a1e
is not supported by ZipFile.
Refs #22399 .
2014-04-18 18:54:46 +02:00
Claude Paroz
ed532a6a1e
Fixed #22399 -- Forced fixture reading in binary mode
...
This might help on systems where default encoding is not UTF-8 (and
on Python 3).
Thanks bacilla for the report.
2014-04-18 17:55:35 +02:00
Moayad Mardini
214d1e1b0f
Fixed #22454 - Changed compatibility warning hint
...
The warning hint of `_check_test_runner` of 1.6 compatibility had a link
to a general release note. The link should be edited to refer the
relevant "Backwards incompatible changes in 1.6" section that documents
the cause and the possible solutions and workarounds of the warning.
2014-04-17 20:41:25 -04:00
Tim Graham
47927eb786
Revert "Fixed #22401 -- Deprecated regular expression parsing of initial SQL in favor of installing sqlparse."
...
This reverts commit 071c933775
.
This introduced a regression on MySQL and custom SQL is deprecated.
2014-04-16 21:03:22 -04:00
Tim Graham
395d75ea6b
Fixed #22194 -- Added --list-tags option to check command.
...
Thanks Elvard for the patch.
2014-04-10 09:43:55 -04:00
Tim Graham
b513fa5fc6
Fixed #22195 -- Used constants to define built-in tags for check framework.
...
Thanks Elvard for the patch.
2014-04-10 08:45:48 -04:00
julien 'pouete' Godin
071c933775
Fixed #22401 -- Deprecated regular expression parsing of initial SQL in favor of installing sqlparse.
2014-04-09 19:25:07 -04:00
Daniel Neuhäuser
4aa80149e7
Fixed #22327 -- Turned BaseEmailBackend into a context manager
...
Changed the BaseEmailBackend to allow usage as context manager to open
and close connections.
2014-03-31 14:08:51 -04:00
Ramiro Morales
9a982d5ccc
Moved ServerHandler helper class to tests.
...
It has been only used in the builtin_servers tests since Django 1.4.
2014-03-30 20:55:40 -03:00
Alex Gaynor
778ce245dd
Corrected many style guide violations that the newest version of flake8 catches
2014-03-30 12:11:05 -07:00
Zbigniew Siciarz
3cdb0baa45
Fixed #22335 -- Fixed popen_wrapper error on non-English Windows systems.
2014-03-26 00:42:19 +01:00
Tim Graham
9b7ba8af1b
Fixed #22322 -- Fixed incorrect explanation of what managed=False does.
...
refs #14305 .
Thanks Adrian Klaver for the report.
2014-03-25 14:01:37 -04:00
Tim Graham
e3c4205b79
flake8 and doc fixes for refs #22257 .
2014-03-25 09:44:59 -04:00
Anubhav Joshi
f34e8fc890
Fixed #22257 -- Added file output option to dumpdata command.
2014-03-25 13:47:03 +05:30
Baptiste Mispelon
96fc3908ad
Fixed a failing test introduced in 918a16bc4c
.
...
Refs #22307 .
2014-03-22 18:05:56 +01:00
Patrick Michaud
acee46fc95
Fixed #22256 -- Replaced bad fallback for missing PATH
...
Thanks Baptiste Mispelon for the review.
2014-03-22 16:52:05 +01:00
Aymeric Augustin
6877a9d415
Avoided transactional truncates on amateur databases.
...
Fixed a test failure that appeared after 753a22a6
, although the bug
existed before that commit.
Refs #22308 .
2014-03-22 14:39:27 +01:00
Aymeric Augustin
0757e0f30d
Avoided transactional DDL on castrated databases.
...
Fixed a test failure that appeared after 753a22a6
, although the bug
existed before that commit.
Refs #22308 .
2014-03-22 11:05:14 +01:00
Hans Lawrenz
918a16bc4c
Fixed #22307 -- Fixed SpooledTemporaryFile bug in File class.
...
Added condition to prevent checking the existence of a file name of a
file like object when the name attribute is None. This is necessary
because a SpooledTemporaryFile won't exist on the file system or have a
name until it has reached its max_size. Also added tests.
2014-03-21 22:34:47 +01:00
Aymeric Augustin
753a22a635
Fixed transaction handling in two management commands.
...
Previously, when createcachetable and flush operated on non-default
databases, they weren't atomic.
2014-03-21 21:29:51 +01:00
Aymeric Augustin
0f9560855e
Removed legacy transaction management per the deprecation timeline.
2014-03-21 21:06:50 +01:00
Tim Graham
4965a77407
Removed PIL compatability layer per deprecation timeline.
...
refs #19934 .
2014-03-21 10:54:53 -04:00
Dejan Noveski
4d0c5f6142
Fixed #22255 -- Added support for specifying re flags in RegexValidator
2014-03-21 11:12:36 +01:00
smallcode
61fdb8d487
Fixed regression in file locking on some platforms.
...
Some platforms with os.name == 'posix' do not have the
fcntl module, e.g. AppEngine.
refs #19373 .
2014-03-18 10:35:22 -04:00
Daniel Hahler
fc167c9b5e
Mentioned that ``dumpdata --natural`` is deprecated.
2014-03-18 07:25:37 -04:00
Andrew Godwin
28779abb75
Fix bad conflict detection during makemigrations
2014-03-08 13:53:20 -08:00
Claude Paroz
210d0489c5
Fixed #21188 -- Introduced subclasses for to-be-removed-in-django-XX warnings
...
Thanks Anssi Kääriäinen for the idea and Simon Charette for the
review.
2014-03-08 09:57:40 +01:00
Claude Paroz
06efeae598
Added --previous flag to msgmerge command used by makemessages
...
Also took the opportunity to slightly refactor gettext options
so as to ease customization by subclassing the command.
Thanks Michal Čihař for the report and initial patch.
2014-03-06 10:20:01 +01:00
Athena
5d568bcfa6
Fixed #7571 -- Fixed parameter matching in include()'d urlpattern
...
Fixed URL resolving in the case where an outer regex includes an inner
regex and both regexes use positional parameters instead of named
groups, causing the outer regex's parameters to override the inner
regex's.
Modified the regex url resolver so that it will concatenates and then
normalizes, instead of normalizing and then concatenating.
2014-03-05 00:35:03 +01:00
zedr
6fe22b30e0
Fixed #22085 -- Added a feature for setting non-expiring keys as the default.
...
This feature allows the default `TIMEOUT` Cache argument to be set to `None`,
so that cache instances can set a non-expiring key as the default,
instead of using the default value of 5 minutes.
Previously, this was possible only by passing `None` as an argument to
the set() method of objects of type `BaseCache` (and subtypes).
2014-03-04 21:16:35 +01:00
Rodolfo Carvalho
0d91225892
Fixed many typos in comments and docstrings.
...
Thanks Piotr Kasprzyk for help with the patch.
2014-03-03 07:38:09 -05:00
Russell Keith-Magee
6b63742ce5
Corrected expected test output to allow for cleanups in signal and compatibility checks.
2014-03-03 19:29:50 +08:00
Russell Keith-Magee
c41335fa27
Added backwards compatibliity checks to reference documentation.
2014-03-03 19:20:48 +08:00
Russell Keith-Magee
21d8175242
Fixed #22193 -- Made hint a truly optional arugment on check messages.
...
Thanks to Thomas Güttler for the suggestion.
2014-03-03 19:16:19 +08:00
Russell Keith-Magee
82ac389486
Edited model and field checks for grammar and consistency.
2014-03-03 18:18:39 +08:00
Erik Romijn
98f13762d7
Fixed #22123 -- EmailValidator now also accepts IPv6 literals in addresses
2014-02-22 17:45:33 +01:00
Baptiste Mispelon
173aa51997
Fixed #21435 -- Improved error message when urlconf is empty.
...
The new error message now hints that the most likely issue
is a circular import.
Thanks to trac user elena for the report and to
bpeschier for the original patch.
2014-02-22 15:36:49 +01:00
Baptiste Mispelon
3841feee86
Fixed #22107 -- Fixed django.core.files.File object iteration.
...
Due to a mixup between text and bytes, iteration over
a File instance was broken under Python 3.
Thanks to trac user pdewacht for the report and patch.
2014-02-20 19:13:25 +01:00
Dmitro
d3e33fff12
Made content_type_extra optional for TemporaryUploadedFile and MemoryUploadedFile.
...
This provides better backwards compatibility for those constructing these
objects manually.
Refs #13721 .
2014-02-18 07:49:42 -05:00
Claude Paroz
621c5cf4a5
Fixed #21732 -- Made compilemessages complain about non-writable location
...
Instead of crashing with a CommandError, now a non-writable location
of mo files will only make compilemessages complain and continue.
Thanks Ramiro Morales for the review.
2014-02-18 13:38:06 +01:00
Baptiste Mispelon
2a9ee49f3c
Removed BaseCommand.stdin introduced in 116d39842d
.
...
This option is not actually very useful in the general case
because it doesn't override sys.stdin.
It's still marginally useful for testing some features of
the createsuperuser command so it was moved there.
This commit also makes the detection of a TTY in createsuperuser
a bit more robust, after a suggestion of appolo13.
2014-02-18 11:36:06 +01:00
Baptiste Mispelon
116d39842d
Added the possibility to pass a stdin object to a management command.
...
This makes testing certain features easier.
Thanks to AeroNotix for the original patch.
2014-02-17 04:58:31 +01:00
MattBlack85
a8ba76c2d3
Fixed #19980 : Signer broken for binary keys (with non-ASCII chars).
...
With this pull request, request #878 should considered closed.
Thanks to nvie for the patch.
2014-02-16 16:50:50 +01:00
Alex Gaynor
cd7f37b647
Corrected a pair of flake8 violations
2014-02-15 10:42:12 -08:00
Grzegorz Nosek
0b6f9f7c6f
Improved fix for #18373 -- backward compatibility
...
Commit 79558c78
cleaned up the (undocumented) interface of Resolver404
exception, which breaks compatibility with code messing with .args[0]
directly. Revert the cleanup part and simply leave the fix itself.
2014-02-15 17:51:18 +01:00
Tim Graham
65b421c661
Fixed some flake8 errors from recent commits.
2014-02-15 11:21:15 -05:00
Aaron France
1150053b99
Fixed #21912 -- Improved error message if a view returns None.
...
Thanks brycenesbitt for the report.
2014-02-15 11:18:16 -05:00
Grzegorz Nosek
79558c787e
Fixed #18373 - improved handling of Resolver404s from views
...
When django.core.urlresolvers.resolve was called from a view, failed
and the exception was propagated and rendered by technical_404_response,
the URL mentioned on the page was the current URL instead of the URL
passed to resolve().
Fixed by using the path attribute from the Resolver404 exception instead
of request.path_info. Also cleaned up the exceptions to use standard
named parameters instead of stuffing a dict in args[0]
2014-02-15 15:56:04 +01:00
Rodolfo Carvalho
4d4e0ea461
Fixed two typos.
2014-02-15 15:16:16 +01:00
Tim Graham
8251438cb8
Moved relative URL handling added in refs #21177 to a better place.
...
Thanks apollo13: "reverse() shouldn't know about absolute/relative paths."
2014-02-15 07:54:35 -05:00
Antoine Catton
e3d0790bd0
Fixed #21177 -- Made resolve_url support relative URLs.
...
This fixes redirecting to relative URLs with django.shortcuts.redirect.
2014-02-14 17:58:03 -05:00
Andrew Godwin
f0f1ba75b0
Fixed #21856 : Don't crash runserver when DATABASES = {}
2014-02-12 19:09:43 +00:00
Andrew Godwin
7e941ba67c
Reverting unapplied migrations check away from being a system-level check.
...
This reverts commit 0ac13ecceb
.
2014-02-12 18:55:20 +00:00
Andrew Godwin
b333de0f5d
Add --empty option to makemigrations
2014-02-12 17:16:40 +00:00
Eli Bendersky
73f51e4113
Fixed #22025 -- Listing app followed by app.Model in dumpdata command
...
When invoked as follows:
$ python manage.py dumpdata blogapp blogapp.Tag
Django would throw a TypeError. This commit fixes the problem and provides
a test.
2014-02-12 15:34:26 +01:00
Si Feng
b102c27ff4
Fixed #20784 -- Added inverse_match parameter to RegexValidator.
2014-02-10 05:38:43 -05:00
Claude Paroz
e2f28572b7
Merge pull request #2245 from funkybob/parse_header
...
Replaced _parse_content_type with cgi.parse_header
2014-02-09 20:39:07 +01:00
Andrew Godwin
d5df7a0515
Fixed #21969 : Fix behaviour of initial_data with migrated apps
2014-02-09 12:22:59 +00:00
Andrew Godwin
2085f53f56
Fixed #21968 : Bad detection of old-style apps to add initial migration
2014-02-09 11:42:10 +00:00
Andrew Godwin
38b4adc696
Merge pull request #2244 from mlavin/21856-migration-checks
...
Fixed #21856 : Allow Empty DATABASES Setting
2014-02-09 10:46:57 +00:00
Curtis
f43e895b15
Replace _parse_content_type with cgi.parse_header
2014-02-09 10:01:16 +11:00
Kevin Christopher Henry
6fe26bd3ee
Fixed #19373 -- Ported Windows file locking from PyWin32 to ctypes
...
There wasn't any file locking under Windows unless PyWin32 was
installed. This removes that (undocumented) dependency by using ctypes
instead.
Thanks to Anatoly Techtonik for writing the ctypes port upon which this
is based.
2014-02-08 15:52:06 -05:00
Berker Peksag
5d263dee30
Fixed #21674 -- Deprecated the import_by_path() function in favor of import_string().
...
Thanks Aymeric Augustin for the suggestion and review.
2014-02-08 11:12:19 -05:00
mlavin
0ac13ecceb
Remove check_migrations from the runserver command and use the new checks framework to check for unapplied migrations. Don't check for migrations if the DATABASES setting is empty.
2014-02-08 09:01:59 -05:00
Michael Manfre
3ffeb93186
Ensure cursors are closed when no longer needed.
...
This commit touchs various parts of the code base and test framework. Any
found usage of opening a cursor for the sake of initializing a connection
has been replaced with 'ensure_connection()'.
2014-02-02 12:47:21 -05:00
Tim Graham
2b6914049a
Fixed #21849 -- Included the count of silenced system checks in output.
2014-01-28 08:31:02 -05:00
Wojciech Banaś
8f2f48ecc9
Fixed #21866 -- Replaced "COMMIT" in managmement command SQL with backend hook.
2014-01-26 12:42:41 -05:00
Aymeric Augustin
f901b4d6c8
Took advantage of the new get_model API. Refs #21702 .
2014-01-26 13:08:05 +01:00
Aymeric Augustin
ee4b806a85
Fixed #21873 -- Removed duplicate import.
...
Thanks Sephi for the report.
2014-01-25 23:22:03 +01:00
Aymeric Augustin
2ff93e027c
Fixed #21829 -- Added default AppConfigs.
...
Thanks Russell for the report, Marc for the initial patch, Carl for the
final review, and everyone who contributed to the design discussion.
2014-01-25 10:41:56 +01:00
José Moreira
8649833cf8
fixed typo on docstring
2014-01-20 16:33:11 +00:00
Russell Keith-Magee
d818e0c9b2
Fixed #16905 -- Added extensible checks (nee validation) framework
...
This is the result of Christopher Medrela's 2013 Summer of Code project.
Thanks also to Preston Holmes, Tim Graham, Anssi Kääriäinen, Florian
Apolloner, and Alex Gaynor for review notes along the way.
Also: Fixes #8579 , fixes #3055 , fixes #19844 .
2014-01-20 10:45:21 +08:00
Andrew Godwin
a68f325791
Fixed #21638 : Validators are now comparable, stops infinite user mig'ns
2014-01-19 18:56:16 +00:00
JustinTArthur
298a2b577f
Adjusted inspectdb management command to yield PEP 8-compliant output barring Django Coding Style exceptions.
2014-01-17 18:03:16 -05:00
Marc Tamlyn
ac8d0a4815
Remove unneded open(.., 'U') when on python 3.
...
Universal newlines is enabled by default on py3, and the usage of 'U' is
deprecated in py3.4.
2014-01-13 17:11:21 +00:00
Marc Tamlyn
9d2c5b0420
Undelete the `return True` removed in 4e0a2fe
.
...
This is quite important otherwise we don't close our connections to the
SMTP server.
2014-01-12 23:38:28 +00:00
Aymeric Augustin
0a7588dd3f
Fixed #21770 -- Updated autocomplete for app-loading.
...
Thanks dfunckt for the report.
2014-01-12 22:29:27 +01:00
Aymeric Augustin
d562527a16
Fixed #21477 -- Renamed db to using in pre/post_migrate signals.
2014-01-12 22:24:33 +01:00
Aymeric Augustin
2dcde523ab
Avoided catching ImproperlyConfigured on django.setup().
...
Fixed #21737 . Thanks Florian for the report.
Also removed redundant imports in that file.
2014-01-06 23:01:29 +01:00
Claude Paroz
aaf5b3e7aa
Moved django.setup() to ManagementUtility
...
In get_commands, setup() might already have been called, for example
when the management command is called through call_command. Moving
setup() to ManagementUtility so as it is only called when the command
is run from command line.
2014-01-02 20:47:40 +01:00
Aymeric Augustin
30a42a4fc3
Adjusted previous commit for Python 3.
2014-01-01 19:12:46 +01:00
Aymeric Augustin
0ce945a671
Fixed #21018 -- Reversed precedence order for management commands.
2014-01-01 18:11:15 +01:00
Aymeric Augustin
f17d00278e
Wiped get_commands() cache when INSTALLED_APPS changes.
...
Refs #21018 , #21688 .
2014-01-01 18:11:09 +01:00
Aymeric Augustin
a95f74e707
Oops.
2013-12-31 13:16:51 +01:00
Aymeric Augustin
6b172a6d6d
Called django.setup() explicitly in management commands.
...
This avoids duplicating code.
2013-12-31 13:11:05 +01:00
Aymeric Augustin
bfcc686d22
Removed the only_with_models_module argument of get_model[s].
...
Now that the refactorings are complete, it isn't particularly useful any
more, nor very well named. Let's keep the API as simple as possible.
Fixed #21689 .
2013-12-30 23:59:34 +01:00
Florian Apolloner
df075c7489
Merge pull request #2126 from apollo13/email_bytes
...
Many thanks to @bitdancer and @aaugustin for answering my stupid questions about (mail)encodings and pointing me in the right direction.
2013-12-30 14:58:49 -08:00
Florian Apolloner
bfe9052831
Decode mails using the message encoding.
2013-12-30 23:54:12 +01:00
Florian Apolloner
c988745cca
Changed console and filebackend to use msg.as_bytes to output the data as it would get send via smtp.
2013-12-30 23:46:05 +01:00
Aymeric Augustin
1c242a297b
Merged Apps.populate_apps() and populate_models().
...
After the recent series of refactorings, there's no reason to keep
two distinct methods.
Refs #21681 .
2013-12-30 23:18:22 +01:00
Aymeric Augustin
80d74097b4
Stopped populating the app registry as a side effect.
...
Since it triggers imports, it shouldn't be done lightly.
This commit adds a public API for doing it explicitly, django.setup(),
and does it automatically when using manage.py and wsgi.py.
2013-12-30 22:11:17 +01:00
Aymeric Augustin
0d2c8ff2be
Populated the app registry earlier at startup.
...
Refs #1796 , #21676 .
2013-12-30 22:11:16 +01:00
Aymeric Augustin
5892a83b18
Stopped calling get_models() for a side effect.
2013-12-29 21:48:58 +01:00
Aymeric Augustin
e5bcd1d455
Changed get_validation_errors to use an app config.
2013-12-29 21:48:58 +01:00
Aymeric Augustin
856aaaf2b1
Changed get_migratable_models to use an app config.
2013-12-29 21:25:28 +01:00
Aymeric Augustin
1d4bcb86ea
Changed sql_* to use an app config instead of a models module.
2013-12-29 21:25:28 +01:00
Aymeric Augustin
368d90e261
Removed unused import.
2013-12-29 20:45:34 +01:00
Aymeric Augustin
7b88a96553
Added AppConfig.get_models().
2013-12-29 20:31:59 +01:00
Aymeric Augustin
00110904ac
Refactored the migration signals to use app configs.
...
De-aliased pre/post_syncdb to pre/post_migrate to increase
backwards-compatibility.
2013-12-29 17:53:42 +01:00
Claude Paroz
6d66ba5948
Fixed #21242 -- Allowed more IANA schemes in URLValidator
...
Thanks Sascha Peilicke for the report and initial patch, and
Tim Graham for the review.
2013-12-28 21:25:32 +01:00
Aymeric Augustin
ba7206cd81
Changed get_model to raise an exception on errors.
...
Returning None on errors required unpythonic error checking and was
inconsistent with get_app_config.
get_model was a private API until the previous commit, but given that it
was certainly used in third party software, the change is explained in
the release notes.
Applied the same change to get_registered_model, which is a new private
API introduced during the recent refactoring.
2013-12-28 20:53:00 +01:00
Florian Apolloner
5dfd824d38
Introduced as_bytes for SafeMIMEText (and other SafeMIME-classes).
...
This is to provide a consistent interface (namely bytes) for the smtp
backend which after all sends bytes over the wire; encoding with as_string
yields different results since mails as unicode are not really specified.
as_string stays for backwardscompatibilty mostly and some debug outputs.
But keep in mind that the output doesn't match as_bytes!
2013-12-28 18:35:17 +01:00
Florian Apolloner
280c1a65cc
Worked around a bug in python 3.3.3. Refs #21093
2013-12-28 15:25:16 +01:00
Florian Apolloner
f28ea02308
Fixed #21093 -- Ensured that mails are not base64 encoded on python 3.3.3+.
...
Thanks to Arfrever for the report and Aymeric for the review.
2013-12-28 12:42:33 +01:00
Aymeric Augustin
c81fae6b95
Used app_label instead of appname.
...
The last component of the dotted path to the application module is
consistently referenced as the application "label". For instance it's
AppConfig.label. appname could be confused with AppConfig.name, which is
the full dotted path.
2013-12-28 09:53:02 +01:00
Aymeric Augustin
a7add2f296
Migrated built-in AppCommands to use handle_app_config.
2013-12-28 09:43:06 +01:00
Aymeric Augustin
bb8ec71f61
Updated the AppCommand API to support apps without a models module.
2013-12-28 09:42:59 +01:00
Aymeric Augustin
efddae252c
Refactored dumpdata with app configs instead of models modules.
2013-12-27 21:25:35 +01:00
Aymeric Augustin
ce1bc2c94b
Made the AppConfig API marginally more consistent.
...
Eliminated the app_ prefix that was more confusing than useful.
2013-12-26 19:25:09 +01:00
Aymeric Augustin
08bb238eae
Merge pull request #2105 from funkybob/cleanup_get_post
...
Used @cached_property for request.GET and COOKIES
2013-12-25 12:34:06 -08:00
Aymeric Augustin
1716b7ce5a
Renamed AppCache to Apps.
...
Also renamed app_cache to apps and "app cache" to "app registry".
Deprecated AppCache.app_cache_ready() in favor of Apps.ready().
2013-12-24 12:25:17 +01:00
Curtis
d7a4b156d9
Use cached_property for request.GET and request.COOKIES
2013-12-24 21:57:57 +11:00
Aymeric Augustin
2fef9e5375
Moved apps back in the toplevel django namespace.
...
Reverted 4a56a93cc4
.
2013-12-22 11:39:55 +01:00