Malcolm Tredinnick
3815ff7ec5
Fixed #6313 -- Typo fix pointed out by thejaswi_puthraya.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7067 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-02-03 04:06:13 +00:00
Jacob Kaplan-Moss
755278253e
Fixed #6302 for ImageFields.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7025 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-01-18 15:53:19 +00:00
Joseph Kocherhans
fd20365b27
Fixed #6302 . FileField no longer requires a value if one already exists. Thanks Brian Rosner and Øyvind Saltvik.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7021 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-01-17 18:03:21 +00:00
Adrian Holovaty
0b7894423d
Fixed comma splices in PendingDeprecationWarnings of form_for_model and form_for_instance from [6846]
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6945 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-12-19 03:40:39 +00:00
Malcolm Tredinnick
ec72071615
Fixed #6197 -- Added (optional) formfield_callback argument to ModelForms.__new__. Patch from guido@python.org.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6940 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-12-17 11:59:53 +00:00
Joseph Kocherhans
4c59ca6020
Changed ModelForms to allow inheritance as long as their model attributes are the same.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6917 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-12-13 03:14:31 +00:00
Joseph Kocherhans
e415eff0ea
Fixed #6162 . ModelForm's __init__ signature now matches Form's. This is a backwards incompatbile change. Based largely on a patch by ubernostrum.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6915 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-12-13 02:48:04 +00:00
Adrian Holovaty
31a17467eb
Small docstring edit to change from [6745]
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6875 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-12-04 06:02:56 +00:00
Joseph Kocherhans
d25d6b3f86
Added PendingDeprecationWarmings for form_for_instance/form_for_model.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6846 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-12-02 20:41:27 +00:00
Malcolm Tredinnick
51dc4ecf94
Fixed #6042 -- ModelForms implementation from Joseph Kocherhans. Still might
...
need a little tweaking as people start to use it, but this is mostly complete.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6844 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-12-02 19:29:54 +00:00
Malcolm Tredinnick
81832f594d
Fixed #5743 -- Tweaked the exceptions raised when importing settings so that we
...
cooperate with Python's standard help() function. Patch from ionut_bizau and
Ben Slavin.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6832 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-12-02 15:27:44 +00:00
Adrian Holovaty
394807866d
Simplified the newforms error_messages setting code from [6625]
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6785 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-12-01 16:50:48 +00:00
Malcolm Tredinnick
29892d02fa
Fixed #6014 -- More robust error handling when validating decimal fields.
...
Thanks, pigletto.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6746 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-29 19:30:38 +00:00
Malcolm Tredinnick
7a166f1a1c
Fixed #5959 -- Fixed handling of False values in hidden boolean fields. Thanks,
...
SmileyChris.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6745 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-29 19:22:03 +00:00
Malcolm Tredinnick
5a5a71edcd
Fixed #5991 -- Marked the generated HTML for newforms.extra.SelectDateWidget as
...
safe. Patch from alberto.piai@gmail.com .
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6723 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-28 20:19:58 +00:00
Malcolm Tredinnick
1c87a7bb58
Fixed #5730 : Conditionally escape widget contents in newforms to avoid
...
inadvertent double-escaping. This still isn't perfect behaviour (since it's
unaware of the current context's auto-escaping setting), but that's a larger
problem that needs fixing and this change at least makes the existing
behaviour consistent. Patch from SmileyChris.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6722 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-28 20:19:54 +00:00
Gary Wilson Jr
f110da91db
Fixed #5993 -- Made `RadioSelect` easier to subclass by giving it a default `renderer` as a class attribute.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6717 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-26 02:39:48 +00:00
Gary Wilson Jr
42c5a91388
Made use of `EMPTY_VALUES` in `ModelChoiceField.clean()`.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6699 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-19 04:07:03 +00:00
Gary Wilson Jr
b2b6fc8e3c
Fixed #5975 -- Gave `ModelChoiceField` and `ModelMultipleChoiceField` ability to specify custom error messages.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6694 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-18 20:25:23 +00:00
Malcolm Tredinnick
356662cf74
Implemented auto-escaping of variable output in templates. Fully controllable by template authors and it's possible to write filters and templates that simulataneously work in both auto-escaped and non-auto-escaped environments if you need to. Fixed #2359
...
See documentation in templates.txt and templates_python.txt for how everything
works.
Backwards incompatible if you're inserting raw HTML output via template variables.
Based on an original design from Simon Willison and with debugging help from Michael Radziej.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6671 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-14 12:58:53 +00:00
Gary Wilson Jr
babfe78494
Fixed #4787 , #5913 -- Updating the queryset on a `ModelChoiceField` or `ModelMultipleChoiceField` now updates its widget's choices. The clean methods for `ModelChoiceField` and `ModelMultipleChoiceField` were changed to only allow choices in the specified queryset (instead of allowing all choices returned by the queryset model's default manager).
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6670 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-13 14:36:29 +00:00
Gary Wilson Jr
a4907be38e
Fixed #5918 -- Removed `SortedDictFromList` since `SortedDict` now can do everything `SortedDictFromList` could do. Since `SortedDict`'s `copy` method doesn't return a deepcopy as `SortedDictFromList`'s `copy` method did, you will need to update your code if you were relying on `SortedDictFromList.copy` to return a deepcopy by using the `deepcopy` function from the `copy` module.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6668 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-11 04:44:20 +00:00
Malcolm Tredinnick
2184248c05
For readability, use _() as an alias to mark translatable strings.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6642 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-04 02:08:02 +00:00
Gary Wilson Jr
48ce8456cb
Style fixes.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6627 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-10-29 23:52:17 +00:00
Gary Wilson Jr
26ea06b0ab
Fixed #3457 -- Allow overridding of error messages for newforms Fields.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6625 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-10-28 05:40:26 +00:00
Gary Wilson Jr
6e44f4dee8
Removed duplicate decimal import.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6623 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-10-28 03:38:08 +00:00
Malcolm Tredinnick
003b3c1a17
Fixed #5794 -- Be more robust when rendering a DateTimeInput widget. Thanks,
...
MikeH.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6594 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-10-22 13:13:12 +00:00
Malcolm Tredinnick
c64a6c98c4
Removed unwanted import that snuck into [6578].
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6579 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-10-21 14:57:05 +00:00
Malcolm Tredinnick
1671fc48ab
Changed the default form presentation of datetime values to not include the
...
fractional second values (they usually aren't going to be needed). Based on
patches from yi.codeplayer@gmail.com , andrews and Wiliam Alves de Souza. Fixed #4428 , #4487
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6578 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-10-21 14:50:47 +00:00
Malcolm Tredinnick
f5831b03c9
DateTimeField can now clean values that come from SplitDateTimeWidget.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6577 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-10-21 14:50:20 +00:00
Malcolm Tredinnick
e38d54e19a
Changed newforms.CheckboxInput widget to return False as its value when not
...
include in the form (since HTML form submission doesn't send unselected check
boxes). Patch from SmileyChris. Refs #5104 .
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6563 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-10-20 12:21:07 +00:00
Malcolm Tredinnick
3c18331adc
Changed some Widget subclasses to be consistent about how they handle the passed in 'attrs' parameter. We now always copy it (by calling the parent's __init__).
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6451 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-10-04 01:20:27 +00:00
Malcolm Tredinnick
b1cc3318c7
Added a __deepcopy__() method to the Widget class in order to avoid a number of easy-to-trigger problems when copying Widget subclasses. Subclasses which are intended to have extra mutable fields should override this method. Refs #5505 .
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6450 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-10-04 01:12:00 +00:00
Malcolm Tredinnick
c012b8964e
Fixed #4067 -- Fixed validation of IPAddressFields in newforms. Thanks to neils and the team in the Copenhagen sprint group.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6357 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-16 11:38:32 +00:00
Malcolm Tredinnick
748e55b1da
Fixed #4975 -- Allow the default label suffix character to be configured. Thanks, Vincent Foley.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6352 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-16 04:38:20 +00:00
Malcolm Tredinnick
9d18227a56
Fixed #5471 -- Fixed cleaning of boolean field data when it's used as a hidden field. Patch from Paul Lanier.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6285 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-15 14:03:07 +00:00
Malcolm Tredinnick
885db3cb79
Fixed #5355 -- Fixed data cleaning for DecimalField.
...
In passing, fixed a problem with cleaning in IntegerField.
Includes tests from PhiR.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6282 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-15 11:45:19 +00:00
Malcolm Tredinnick
f0cd172cd0
Fixed #5387 -- Added is_multipart method to forms. Original patch from Petr Marhhoun. Tests and documentation from Murkt.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6273 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-15 10:12:05 +00:00
Malcolm Tredinnick
c59903101a
Fixed some Python 2.3 unicode conversion problems. Uncovered by the tests, but that was just a sign of a real bug (luckily!).
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6266 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-15 05:50:45 +00:00
Russell Keith-Magee
63dd4f5322
Fixed #3848 -- Added more comprehensive checks to ImageField validation, checking for image truncation or corruption. Thanks to Andrew C <andrewc-djangotrac1@piffle.org> for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6175 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-14 07:18:27 +00:00
Russell Keith-Magee
20ecbbd9e7
Fiex #5331 -- Modified newforms URLField to prepend http:// if no protocol is specified by the user. Thanks, SmileyChris.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6173 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-14 07:02:55 +00:00
Malcolm Tredinnick
70e5dce365
Fixed #3489 -- Added proper deepcopying to form fields so that widget instances get copied as well. Patch from Jonathan Buchanan and insin.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6156 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-14 03:29:39 +00:00
Russell Keith-Magee
a2ce7669d9
Fixed #3421 -- Added IP and localhost validation to newforms URLField. Thanks, SmileyChris.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6152 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-14 02:11:24 +00:00
Malcolm Tredinnick
ce249d4366
Fixed #4752 -- Make default ErrorList customisable in newforms display. Based on a patch from michal@logix.cz and SmileyChris.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6142 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-13 23:09:40 +00:00
Malcolm Tredinnick
e1cb961a9b
Fixed #5370 -- Allow lazy translations in ValidationError classes. Patch from James Bennett.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6140 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-13 22:35:18 +00:00
Russell Keith-Magee
7115465afa
Fixed #4478 -- Added a catch for an error thrown by PIL when attempting to validate MS OLE files.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6096 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-11 13:13:35 +00:00
Gary Wilson Jr
b0e173ae3f
Fixed imports to adhere to PEP 8 and stripped trailing whitespace.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6068 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-08 19:26:15 +00:00
Gary Wilson Jr
7e57576ff7
Fixed #5232 -- Fixed the validation of `DecimalField` so that the negative sign is not counted as a digit. Thanks, Andrew Durdin.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6067 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-08 19:24:46 +00:00
Adrian Holovaty
babf25c11c
Fixed #5095 -- newforms now checks for EnvironmentError when importing settings. Thanks, SmileyChris
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5861 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-08-12 03:07:34 +00:00
Malcolm Tredinnick
36be3febef
Fixed #4622 -- Fixed SelectDateWidget to work correctly when used as a hidden input field. Thanks, Bill Fenner.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5859 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-08-12 02:15:35 +00:00