0214f367bc
Merged isinstance() calls.
2017-09-13 15:00:45 -04:00
e5bd585c6e
Fixed #28543 -- Prevented ManyToManyField.value_from_object() from being lazy.
...
Previously, it was a QuerySet which could reevaluate to a new value if the
model's data changes. This is inconsistent with other Field.value_from_object()
methods.
This allows reverting the fix in the admin for refs #27998 .
2017-08-31 09:34:44 -04:00
fac74b84a3
Used OrderedDict.fromkeys() to initialize OrderedDict with None values.
2017-08-23 11:40:17 -04:00
7bba82453c
Fixed #28496 -- Added ModelAdmin.get_changelist_instance().
2017-08-22 08:17:26 -04:00
c19b56f633
Fixed #28377 -- Made combining form Media retain relative asset order.
...
Thanks Florian Apolloner, Mariusz Felisiak, and Tim Graham for reviews.
2017-07-20 11:06:30 -04:00
15b465c584
Fixed #27998 -- Made ManyToManyField changes logged in admin's object history.
2017-06-14 13:07:06 -04:00
c16aa69101
Factored shared Inline/ModelAdmin.get_fields() logic into BaseModelAdmin.
...
BaseModelAdmin.get_fields() was previously unused/untested.
2017-06-07 17:11:02 -04:00
5a52d932ef
Replaced Model._get_pk_val() with pk property.
...
Model.pk was added after _get_pk_val() and many places weren't simplified.
2017-06-05 15:20:34 -04:00
b7f99f84bc
Fixed #28262 -- Fixed incorrect DisallowedModelAdminLookup when a nested reverse relation is in list_filter.
2017-06-05 10:29:54 -04:00
21046e7773
Fixed #28249 -- Removed unnecessary dict.keys() calls.
...
iter(dict) is equivalent to iter(dict.keys()).
2017-05-27 19:08:46 -04:00
301de774c2
Refs #27795 -- Replaced many force_text() with str()
...
Thanks Tim Graham for the review.
2017-04-27 09:10:02 +02:00
8346680e1c
Refs #27795 -- Removed unneeded force_text calls
...
Thanks Tim Graham for the review.
2017-03-04 18:18:21 +01:00
b27166b769
Fixed #27356 -- Fixed ModelAdmin.lookup_allowed() for some nested relations.
2017-02-07 19:33:26 -05:00
c651331b34
Converted usage of ugettext* functions to their gettext* aliases
...
Thanks Tim Graham for the review.
2017-02-07 09:04:04 +01:00
5411821e3b
Refs #27656 -- Updated django.contrib docstring verb style according to PEP 257.
2017-02-04 16:39:28 -05:00
29f607927f
Fixed spelling of "nonexistent".
2017-02-03 08:01:45 -05:00
3b2e28fc85
Used model_ngettext in two more places
2017-01-31 08:48:17 +01:00
fee42fd99e
Refs #23919 -- Replaced usage of django.utils.http utilities with Python equivalents
...
Thanks Tim Graham for the review.
2017-01-26 19:49:03 +01:00
d6eaf7c018
Refs #23919 -- Replaced super(ClassName, self) with super().
2017-01-25 12:23:46 -05:00
2b281cc35e
Refs #23919 -- Removed most of remaining six usage
...
Thanks Tim Graham for the review.
2017-01-18 21:33:28 +01:00
7b2f2e74ad
Refs #23919 -- Removed six.<various>_types usage
...
Thanks Tim Graham and Simon Charette for the reviews.
2017-01-18 20:18:46 +01:00
f3c43ad1fd
Refs #23919 -- Removed python_2_unicode_compatible decorator usage
2017-01-18 13:44:34 +01:00
d7b9aaa366
Refs #23919 -- Removed encoding preambles and future imports
2017-01-18 09:55:19 +01:00
8ea541e6a2
Refs #2856 -- Removed redundant escaping in admin's "Perhaps it was deleted?" message.
2017-01-04 10:22:17 -05:00
27267afc41
Fixed #2856 -- Replaced some 404s with messages in admin.
...
Instead of a 404, return a redirect to admin index page with a message
indicating that the requested object does not exist. This avoids the
admin returning 404 from "Recent Actions" links for deleted objects.
2017-01-03 11:31:05 -05:00
8ba01d1e42
Fixed #26543 -- Prevented "confirm form submission" browser prompt when reloading after an admin actions failure.
2016-12-23 17:29:24 -05:00
1e629928e9
Fixed #27313 -- Allowed overriding admin popup response template.
2016-12-14 18:10:56 -05:00
4a246a02bd
Refs #17235 -- Made MultiPartParser leave request.POST immutable.
2016-12-07 08:28:46 -05:00
0a63ef3f61
Fixed #27463 -- Fixed E741 flake8 warnings.
2016-11-14 17:40:28 -05:00
967be82443
Fixed E305 flake8 warnings.
2016-11-14 12:30:46 -05:00
bf91be83d5
Fixed #24941 -- Added ModelAdmin.get_exclude().
...
Thanks Ola Sitarska for the initial patch.
2016-10-07 18:49:28 -04:00
e1b4360adc
Fixed #27273 -- Added a construct_change_message() admin utility function.
2016-10-05 08:02:33 -04:00
aa9569fce1
Fixed #27218 -- Returned LogEntry instances from ModelAdmin.log_*() methods.
2016-10-04 14:08:53 -04:00
67eee5e4fa
Fixed #27302 -- Fixed ModelAdmin.construct_change_message() changed field detection
...
Thanks Ramiro Morales for the report and Tim Graham for the review.
2016-10-01 20:14:27 +02:00
9459ec82aa
Fixed #26170 -- Made ModelAdmin views run transactions on the correct database.
...
Thanks juntatalor for the initial patch.
2016-09-14 16:06:39 -04:00
2315114090
Fixed #27067 -- Deprecated string_concat() in favor of format_lazy().
2016-08-25 16:12:40 -04:00
3c97ba2a0d
Replaced property() usage with decorator in a couple places.
2016-08-24 17:23:16 -04:00
b387189d86
Fixed #26919 -- Added the action form's media in the changelist view.
2016-08-11 19:35:31 -04:00
054e74420b
Refs #16501 , #26474 -- Added xregexp.js source file.
2016-06-06 09:25:02 -04:00
38c43b2a5c
Refs #24227 -- Partially reverted replacement of M2M isinstance checks by field.many_to_many.
...
This fixes django-taggit and reflects some places where duck-typing may not
be appropriate.
2016-05-11 10:29:01 -04:00
b9290b1d49
Fixed #26449 -- Merged admin's FORMFIELD_FOR_DBFIELD_DEFAULTS with formfield_overrides.
...
Useful for overriding the DateTimeField widget.
2016-05-07 19:52:45 -04:00
08cd6a0e56
Fixed #16327 -- Redirected "Save as new" to change view instead of the changelist.
2016-04-20 11:31:44 -04:00
df8d8d4292
Fixed E128 flake8 warnings in django/.
2016-04-08 09:51:06 -04:00
2cd2d18851
Fixed W503 flake8 warnings.
2016-04-04 17:14:26 -04:00
49ac10b4de
Fixed #26235 -- Handled ProtectedError in a POST to admin's delete_view().
2016-03-21 19:25:27 -04:00
983c158da7
Refs #24227 -- Replaced M2M isinstance checks by field.many_to_many
...
Thanks Markus Holtermann, Collin Anderson and Tim Graham for the reviews.
2016-03-19 09:24:27 +01:00
917cc288a3
Fixed #11313 -- Made ModelAdmin.list_editable more resilient to concurrent edits.
...
Allowed admin POSTed bulk-edit data to use modeladmin.get_queryset()
so that the ids in the POST data have a chance to match up even if
the objects on the current page changed based on the ordering.
2016-02-01 16:05:01 -05:00
62f3acc70a
Fixed incorrect permissions check for admin's "Save as new".
...
This is a security fix.
2016-02-01 11:57:00 -05:00
c79852acee
Fixed #14402 -- Removed clearing of help_text for ManyToManyField's raw_id_fields.
2016-01-30 12:42:47 -05:00
3541ca1504
Refs #25165 -- Fixed JSON serialization for delete popup in the admin.
2016-01-09 13:35:58 -05:00
cf7894be88
Fixed #21113 -- Made LogEntry.change_message language independent
...
Thanks Tim Graham for the review.
2016-01-08 20:34:59 +01:00
ade54ffa34
Refs #25165 -- Fixed JSON serialization for add/edit popup in the admin.
...
Forwardport of test in o839d71d8562abe0b245024e55ca1d02a45e58fd from stable/1.9.x
(refs #25997 ).
2016-01-08 12:28:32 -05:00
822a03b3e4
Refs #25165 -- Fixed failure of admin's "Add another" popup to close.
...
Thanks Thomas Grainger for the fix.
2016-01-08 11:41:01 -05:00
16411b8400
Fixed #26013 -- Moved django.core.urlresolvers to django.urls.
...
Thanks to Tim Graham for the review.
2015-12-31 14:21:29 -05:00
dbb0df2a0e
Fixed #25985 -- Updated signature of ModelAdmin.formfield_for_* to make request a positional argument.
2015-12-29 12:49:14 -05:00
5399ccc0f4
Fixed #494 -- Added ability to specify classes on admin inline fieldsets.
...
This includes the ability to collapse inlines by specifying a class named
'collapse'.
2015-12-21 13:50:06 -05:00
cf546e11ac
Fixed #21221 -- Made form Media and static template tag use staticfiles if installed.
2015-12-10 14:30:19 -05:00
d638cdc42a
Fixed #25165 -- Removed inline JavaScript from the admin.
...
This allows setting a Content-Security-Policy HTTP header
(refs #15727 ).
Special thanks to blighj, the original author of this patch.
2015-12-05 15:51:57 -05:00
80bcbecd4a
Fixed #19361 -- Added link to object's change form in admin's post-save message.
...
Thanks Roel Kramer for tests.
2015-11-19 15:04:32 -05:00
9dcfecb7c6
Fixed #25622 -- Accounted for generic relations in the admin to field validation
...
Thanks to Jonathan Liuti for the report and Tim Graham for the review.
2015-10-29 13:13:19 -04:00
1d8eb0cae5
Fixed #25374 -- Made ModelAdmin checks work on instances instead of classes.
...
This allows dynamically-generated attributes to be specified in
checked ModelAdmin attributes without triggering errors.
2015-09-11 09:28:34 -04:00
f2f8972def
Fixed #25135 -- Deprecated the contrib.admin allow_tags attribute.
...
Thanks Jaap Roes for the idea and initial patch.
2015-09-08 19:13:43 -04:00
f8cc464452
Fixed #16501 -- Added an allow_unicode parameter to SlugField.
...
Thanks Flavio Curella and Berker Peksag for the initial patch.
2015-07-17 13:48:58 -04:00
fedef7b2c6
Fixed #24908 -- Fixed duplicate readonly field rendering.
...
ModelAdmin added readonly_fields to exclude, but would not undeclare
them if they were overridden.
2015-07-02 13:37:30 -04:00
788071e22d
Moved jQuery to a vendor/jquery subdirectory.
2015-06-07 22:23:42 +02:00
0207bdd2d4
Fixed #24474 -- Allowed configuring the admin's empty change list value.
2015-06-04 21:06:26 -04:00
4157c502a5
Removed unnecessary arguments in .get method calls
2015-05-13 20:51:18 +02:00
0894643e40
Fixed #23387 -- Kept "Save as new" button after validation errors in admin.
...
When "Save as new" is chosen and errors occur, only show the "Save as new"
button and not the other save buttons.
Thanks to Tino de Bruijn for doing the real work on this fix.
2015-05-02 19:41:10 -04:00
1273a7a0e8
Revert "Fixed #24474 -- Allowed configuring the admin's empty change list value."
...
This reverts commit 72f769f494
2015-04-08 20:39:59 -04:00
72f769f494
Fixed #24474 -- Allowed configuring the admin's empty change list value.
2015-04-08 20:27:01 -04:00
845817b039
Fixed #24466 -- Added JavaScript escaping in a couple places in the admin.
...
Thanks Aymeric Augustin and Florian Apolloner for work on the patch.
2015-03-30 19:07:17 -04:00
8f30556329
Renamed Field.rel attribute to remote_field
...
Field.rel is now deprecated. Rel objects have now also remote_field
attribute. This means that self == self.remote_field.remote_field.
In addition, made the Rel objects a bit more like Field objects. Still,
marked ManyToManyFields as null=True.
2015-03-25 08:16:12 -04:00
a4a58811b9
Removed redundant model instantiation in contrib.admin; refs #11390 .
2015-03-23 10:06:25 -04:00
aea02ddfb7
Fixed #24490 -- Set LogEntry.change_message when adding an object.
2015-03-20 18:25:06 -04:00
35b3158d52
Fixed #24417 -- Added ModelAdmin.get_list_select_related()
2015-03-19 08:52:28 -04:00
28e8c54d7d
Fixed #24467 -- Removed conditional inclusion of actions.js & prepopulate.js.
...
The JavaScript may be required when using ModelAdmin.get_actions() or
get_prepopulated_fields(). Always including them is the easiest solution.
2015-03-11 20:18:59 -04:00
47b35b1844
Fixed #24411 -- Avoided dict key/method clash in admin delete views.
2015-02-25 07:15:56 -05:00
1791a7e75a
Fixed #15779 -- Allowed 'add' primary key in admin edition
...
Thanks Marwan Alsabbagh for the report, and Simon Charette and
Tim Graham for the reviews.
2015-02-14 11:19:55 +01:00
d64baaef3b
Fixed #24333 -- Fixed admin history view crash with non-integer slug.
2015-02-12 14:19:44 -05:00
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
67a76500a5
Removed support for admin validators per deprecation timeline; refs #16905 .
2015-01-18 14:43:21 -05:00
2c9e95639e
Removed ModelAdmin.get_formsets() per deprecation timeline; refs #20702 .
2015-01-17 18:02:35 -05:00
a420f83e7d
Fixed #24055 -- Keep reference to view class for resolve()
2015-01-17 22:09:10 +07:00
d4ee6cda58
Removed ModelAdmin.declared_fieldsets per deprecation timeline; refs #18681 .
2015-01-17 08:40:33 -05:00
07988744b3
Fixed #13165 -- Added edit and delete links to admin foreign key widgets.
...
Thanks to Collin Anderson for the review and suggestions and Tim for the
final review.
2015-01-10 12:24:52 -05:00
fb48eb0581
Fixed #12663 -- Formalized the Model._meta API for retrieving fields.
...
Thanks to Russell Keith-Magee for mentoring this Google Summer of
Code 2014 project and everyone else who helped with the patch!
2015-01-06 19:25:12 -05:00
8958170755
Fixed #9104 -- Moved FieldDoesNotExist to core.exceptions
2015-01-02 10:46:04 -05:00
46068d850d
Fixed #22295 -- Replaced permission check for displaying admin user-tools
2014-12-31 16:31:59 -05:00
32ca159c96
Ignored warnings correctly in test_get_formsets_with_inlines_returns_tuples().
...
The subclass check in ModelAdmin.get_formsets_with_inlines() wasn't
tested correctly because of the super() call in
EpisodeAdmin.get_formsets().
2014-12-31 08:24:09 -05:00
cf1f36bb6e
Deprecated current_app in TemplateResponse and render(_to_response).
2014-12-28 17:02:29 +01:00
f233bf47dd
Fixed #21414 -- Removed RelatedObject and deprecated Field.related.
2014-12-23 10:54:25 -05:00
c7a19f4203
Fixed #23857 -- Fixed admin crash with "save as new" and deleting inline.
...
Thanks amarandon for the report.
2014-12-12 10:24:39 -05:00
d4e449d730
Fixed typo in admin deprecation message.
2014-12-11 13:30:31 -05:00
0623f4dea4
Fixed #23934 -- Fixed regression in admin views obj parameter.
2014-12-02 08:42:17 -05:00
3a9aa155e2
Fixed #23915 -- Made sure m2m fields through non-pk to_field are allowed in the admin.
...
refs #23754 , #23862
2014-11-25 15:28:21 -05:00
f9c4e14aec
Fixed #23754 -- Always allowed reference to the primary key in the admin
...
This change allows dynamically created inlines "Add related" button to work
correcly as long as their associated foreign key is pointing to the primary
key of the related model.
Thanks to amorce for the report, Julien Phalip for the initial patch,
and Collin Anderson for the review.
2014-11-25 13:26:50 -05:00
06b11b617e
Fixed #23616 - Fixed generic relations in ModelAdmin.list_filter.
...
Thanks ranjur for reporting bug, timgraham for review,
and collinanderson for contributing tips.
2014-10-10 12:10:32 -04:00
a24cf21722
Fixed #23604 -- Allowed related m2m fields to be references in the admin.
...
Thanks Simon Charette for review.
2014-10-06 08:35:16 -04:00
17557d068c
Fixed #8408 -- Added ModelAdmin.show_full_result_count to avoid COUNT() query.
...
Thanks lidaobing for the suggestion.
2014-09-26 12:12:40 -04:00
342ccbddc1
Fixed #23431 -- Allowed inline and hidden references to admin fields.
...
This fixes a regression introduced by the 53ff096982#23329 .
2014-09-08 13:49:07 -04:00
Mariusz Felisiak
Tim Graham
Sergey Fedoseev
Simon Meers
Johannes Hoppe
Lincoln Smith
Paulo
Jon Dufresne
Claude Paroz
Anton Samarchyan
chillaranand
Karen Tracey
Adonys Alea Boffill
Michael Scott
Vinay Karanam
Ramin Farajpour Cami
Zach Borboa
François Freitag
Jibodeah
Mattias Loverot
Berker Peksag
Stanislav Karpov
Pyie Zone
Collin Anderson
marysia
Markus Amalthea Magnuson
Akshesh
bphillips
Myk Willis
Alexander Gaevsky
Marten Kenbeek
Thomas Grainger
Anton Baklanov
Simon Charette
Malcolm Box
Ola Sitarska
Edward Henderson
jpic
Trey Hunner
Loek van Gent
Piotr Jakimiak
Adam Zapletal
Anssi Kääriäinen
TomV
Karl Hobley
Anton Danilchenko
Daniel Pyrathon
Thomas Tanner
Aymeric Augustin
Anssi Kääriäinen
Kamil Braun
Konrad Świat
Emmanuelle Delescolle
Thomas Chaumeny