d9eef1f4f7
[1.7.x] Made the vendored NamedTemporaryFile work as a context manager. Refs #22680 .
...
This fixes a regression on Windows introduced by b7de5f56e8d614acd
2014-06-12 14:15:31 -04:00
1ff11304dc
[1.7.x] Fixed #22680 -- I/O operation on closed file.
...
This patch is two-fold; first it ensure that Django does close everything in
request.FILES at the end of the request and secondly the storage system should
no longer close any files during save, it's up to the caller to handle that --
or let Django close the files at the end of the request.
Backport of e2efc8965e
2014-06-11 09:03:11 +02:00
3d98941d5c
[1.7.x] Fixed several typos in Django
...
Backport of 1dcc603eff
2014-05-29 07:53:02 -04:00
099625d760
[1.7.x] Removed executeable bit from a few files.
...
Backport of 9d1bf8f841
2014-05-25 23:17:18 +02:00
f53d1576ca
[1.7.x] Fixed #22337 : FileSystemStorage marked as deconstructible and tested.
2014-05-06 22:24:39 -07:00
61fdb8d487
Fixed regression in file locking on some platforms.
...
Some platforms with os.name == 'posix' do not have the
fcntl module, e.g. AppEngine.
refs #19373 .
2014-03-18 10:35:22 -04:00
0d91225892
Fixed many typos in comments and docstrings.
...
Thanks Piotr Kasprzyk for help with the patch.
2014-03-03 07:38:09 -05:00
3841feee86
Fixed #22107 -- Fixed django.core.files.File object iteration.
...
Due to a mixup between text and bytes, iteration over
a File instance was broken under Python 3.
Thanks to trac user pdewacht for the report and patch.
2014-02-20 19:13:25 +01:00
d3e33fff12
Made content_type_extra optional for TemporaryUploadedFile and MemoryUploadedFile.
...
This provides better backwards compatibility for those constructing these
objects manually.
Refs #13721 .
2014-02-18 07:49:42 -05:00
6fe26bd3ee
Fixed #19373 -- Ported Windows file locking from PyWin32 to ctypes
...
There wasn't any file locking under Windows unless PyWin32 was
installed. This removes that (undocumented) dependency by using ctypes
instead.
Thanks to Anatoly Techtonik for writing the ctypes port upon which this
is based.
2014-02-08 15:52:06 -05:00
5d263dee30
Fixed #21674 -- Deprecated the import_by_path() function in favor of import_string().
...
Thanks Aymeric Augustin for the suggestion and review.
2014-02-08 11:12:19 -05:00
8649833cf8
fixed typo on docstring
2014-01-20 16:33:11 +00:00
6685713869
Fixed E127 pep8 warnings.
2013-12-14 11:59:15 -05:00
7e2d61a972
Fixed #21380 -- Added a way to set different permission for static directories.
...
Previously when collecting static files, the directories would receive permissions
from the global umask. Now the default permission comes from FILE_UPLOAD_DIRECTORY_PERMISSIONS
and there's an option to specify the permissions by subclassing any of the
static files storage classes and setting the directory_permissions_mode parameter.
2013-11-29 08:01:30 -05:00
4cfe6ba6a3
Use `classmethod` as a decorator.
2013-11-19 23:08:21 -05:00
c347f78cc1
Fixed all E226 violations
2013-11-03 10:08:55 -08:00
cbc7cbbc5b
Fixed flake8 E251 violations
2013-11-03 03:22:11 -06:00
3bc0d46a84
Fixed all E261 warnings
2013-11-02 18:20:39 -04:00
7548aa8ffd
More attacking E302 violators
2013-11-02 13:12:09 -07:00
4ad9f4d4ea
Replaced a hardcoded "2" with the right named constant
2013-11-02 12:55:36 -07:00
36ded01527
Fixed #21302 -- Fixed unused imports and import *.
2013-11-02 15:24:56 -04:00
9eecb91695
Fixed #21219 -- Added a way to set different permission for static files.
...
Previously, when collecting static files, the files would receive permission
from FILE_UPLOAD_PERMISSIONS. Now, there's an option to give different
permission from uploaded files permission by subclassing any of the static
files storage classes and setting the file_permissions_mode parameter.
Thanks dblack at atlassian.com for the suggestion.
2013-10-24 17:40:01 -04:00
9bf5610890
Start attacking E231 violations
2013-10-24 10:30:03 -07:00
c3aa2948c6
Fixed #21298 -- Fixed E301 pep8 warnings
2013-10-23 13:45:03 +01:00
b67ab75e82
Fixed assorted flake8 errors.
2013-10-11 07:25:14 -04:00
59a34c43a8
Fixed #18744 -- Updated docstring to highlight limitations of NamedTemporaryFile
...
- Noted that this does not allow for reading and writing the same open
file in different processes under Windows.
- Noted that the keyword arguments to NamedTemporaryFile no longer
match the Python version.
2013-09-19 10:12:03 -04:00
b2b763448f
Fixed #20841 -- Added messages to NotImplementedErrors
...
Thanks joseph at vertstudios.com for the suggestion.
2013-09-10 11:09:59 -04:00
30fc49a7ca
Fixed #21057 -- Prevented FileSystemStorage from leaving temporary files.
2013-09-10 08:33:53 -04:00
7008ed61c5
Fixed #21033 -- Fixed uploaded filenames not always being truncated to 255 characters
2013-09-10 01:55:16 +02:00
b2f5ac1656
Fixed #11857 -- Added missing 'closed' property on TemporaryFile class.
...
- TemporaryFile now minimally mocks the API of the Python standard
library class tempfile.NamedTemporaryFile to avoid AttributeError
exceptions.
- The symbol django.core.files.NamedTemporaryFile is actually assigned
as a different class on different operating systems.
- The bug only occurred if Django is running on Windows, hence why it
was hard to diagnose.
2013-09-06 14:32:46 -04:00
6a6428a36f
Took advantage of django.utils.six.moves.urllib.*.
2013-09-05 14:39:23 -05:00
6bdb3b1135
Fixed #13518 -- Added FILE_UPLOAD_DIRECTORY_PERMISSIONS setting
...
This setting does for new directories what FILE_UPLOAD_PERMISSIONS
does for new files.
Thanks jacob@ for the suggestion.
2013-08-12 07:15:59 -04:00
b0953dc913
Fixed #13721 -- Added UploadedFile.content_type_extra.
...
Thanks Waldemar Kornewald and mvschaik for work on the patch.
2013-07-11 09:11:59 -04:00
7fbab3ebaf
Do not allow FileSystemStorage.delete to receive an empty name
...
Refs #20660 .
2013-06-29 18:09:31 +02:00
18e79f1425
Fixed #20486 -- Ensure that file_move_safe raises an error if the destination already exists.
...
Thanks to kux for the report, and Russ Webber for the patch.
2013-06-20 18:55:27 +08:00
0fa8d43e74
Replaced `and...or...` constructs with PEP 308 conditional expressions.
2013-05-26 23:47:50 -03:00
d228c1192e
Fixed #19866 -- Added security logger and return 400 for SuspiciousOperation.
...
SuspiciousOperations have been differentiated into subclasses, and
are now logged to a 'django.security.*' logger. SuspiciousOperations
that reach django.core.handlers.base.BaseHandler will now return a 400
instead of a 500.
Thanks to tiwoc for the report, and Carl Meyer and Donald Stufft
for review.
2013-05-25 16:27:34 -07:00
838f28974e
Fixed #20427 -- Moved a variable initialization in storage.py
...
This is fixing commit 4e70ad11d2
2013-05-17 18:31:52 +02:00
33793f7c3e
Fixed #19934 - Use of Pillow is now preferred over PIL.
...
This starts the deprecation period for PIL (support to end in 1.8).
2013-05-14 19:32:04 -07:00
664855b74e
#18899 FileSystemStorage.save should support any file-like objects
2013-02-23 16:40:50 +01:00
7c5b244826
Fixed #17061 -- Factored out importing object from a dotted path
...
Thanks Carl Meyer for the report.
2013-02-04 16:38:25 +01:00
7cb0cd5aff
Replaced six.reraise with a simple raise.
2013-01-01 13:20:36 +01:00
a4a4b139cd
Replaced e.message with e.args[0] in 3aa4b8165d.
2013-01-01 13:14:55 +01:00
3aa4b8165d
Fixed #19457 -- ImageField size detection failed for some files.
...
This was caused by PIL raising a zlib truncated stream error since we fed
the parser with chunks instead of the whole image.
2013-01-01 11:54:56 +01:00
34dcf51e06
Fixed #19367 -- Fixed saving ContentFile in filesystem storage
...
This was not working properly when ContentFile was initialized with
an unicode string.
Thanks Alexey Boriskin for the report and the test.
2012-12-06 17:14:44 +01:00
fc10418fba
Fixed #18963 -- Used a subclass-friendly pattern
...
for Python 2 object model compatibility methods.
2012-11-03 22:07:35 +01:00
e8c6aff3bf
Fixed #18947 -- Don't make uploaded files executeable by default.
...
Thanks to Lauri Tirkkonen for the patch.
2012-09-17 22:53:10 +02:00
ae88e73fa6
Replaced some smart_xxx by force_xxx equivalent
...
smart_str/smart_text should only be used when a potential lazy
string should be preserved in the result of the function call.
2012-08-30 15:46:16 +02:00
4e70ad11d2
Made FileSystemStorage accept both text and byte streams
...
Thanks Alexey Boriskin for his help on the patch.
2012-08-29 16:37:37 +02:00
361d6738f8
Fixed #11739 -- Made ContentFile support Unicode input
2012-08-29 11:21:33 +02:00
Loic Bistuer
Florian Apolloner
Alex Gaynor
Andrew Godwin
smallcode
Rodolfo Carvalho
Baptiste Mispelon
Dmitro
Kevin Christopher Henry
Berker Peksag
José Moreira
Loic Bistuer
Vajrasky Kok
xuxiang
Milton Mazzarri
coagulant
Tim Graham
Alasdair Nicol
Gregor MacGregor
John Hensley
homm
Christopher Adams
Aymeric Augustin
Mel Collins
Benjamin Kagia
Claude Paroz
Russell Keith-Magee
Ramiro Morales
Preston Holmes
Daniel Lindsley
Marcin Biernat
Anton Baklanov