Christopher Babiak
a834bc84d8
Fixed #20931 -- Fixed select widgets nested choice rendering
...
ChoiceFieldRenderer was not rendering nested choices. Added recursion
to ChoiceFieldRenderer to take nested choices and render them as
<ul>'s.
2013-09-28 17:25:32 -07:00
Ramiro Morales
783620ccc8
Fixed #21162 -- Better emulation of staticfiles middleware.
...
Code had been added in e909ceae9b
. Solves test suite failures observed
on Windows.
Thanks Michael Manfre for the report. Refs #20739 .
2013-09-28 17:32:23 -03:00
Erik Romijn
1a63092981
Fixed #20439 -- Started deprecation of IPAddressField
2013-09-28 10:55:32 +02:00
Baptiste Mispelon
8f51ba669a
Fixed #21186 : Fixed regression when using date fields in the admin's list_filter.
...
Thanks to onlygoldi2201 for the report and to ramiro and apollo13
for the reviews.
2013-09-28 00:40:43 +02:00
Baptiste Mispelon
3754f4ad41
Fix #21185 : Added tests for unescape_entities.
...
Also fixed a py3 incompatibility.
Thanks to brutasse for the report.
2013-09-27 17:00:42 +02:00
Andrew Godwin
59582a8119
Enforce ordering on PostgreSQL get_constraints cols (refs #21134 )
2013-09-26 14:55:19 +01:00
Michael Manfre
d5606b5763
Fixed #21146 - DatabaseCache converts expires to python value
...
DatabaseCache uses raw cursors to bypass the ORM. This prevents it from
being used by database backends that require special handling of datetime
values.
There is no easy way to test this, so no tests added.
2013-09-26 13:11:43 +03:00
Giles Richard Greenway
6c06adad1d
Fixed #20364 -- Changed urlize regexes to include quotation marks as punctation.
...
Thanks to EmilStenstrom for raising this, and to Chris Piwoński for all of the fixes and most of the tests.
2013-09-25 22:17:22 +02:00
Michael Manfre
99c87f1410
Fixed #17671 - Cursors are now context managers.
2013-09-25 21:47:26 +03:00
Loic Bistuer
04a2a6b0f9
Fixed #3871 -- Custom managers when traversing reverse relations.
2013-09-25 21:15:59 +03:00
Anssi Kääriäinen
83554b018e
Fixed #21126 -- QuerySet value conversion failure
...
A .annotate().select_related() query resulted in misaligned rows vs
columns for compiler.resolve_columns() method.
Report & patch by Michael Manfre.
2013-09-25 20:47:57 +03:00
Andrew Godwin
6d3faba2d2
Add reverse_code optional argument to RunPython
2013-09-25 17:21:20 +01:00
Andrew Godwin
fe9f342d8c
Allow callables as the argument to RunPython
2013-09-25 16:10:43 +01:00
Andrew Godwin
8a3e543f26
Make sqlmigrate ignore the RunPython operation
2013-09-25 14:37:44 +01:00
Andrew Godwin
3b810c5656
Add RunPython migration operation and tests
2013-09-25 13:58:07 +01:00
Andrew Godwin
05656f2388
Add equality support for Project/ModelState
2013-09-25 13:47:46 +01:00
Anssi Kääriäinen
9027da65d3
Added '*' to quote_cache
...
The commit for #18333 missed quote_cache default value for *.
Refs #18333 .
2013-09-24 23:00:31 +03:00
Florian Apolloner
68540fe4df
Fixed #21138 -- Increased the performance of our PBKDF2 implementation.
...
Thanks go to Michael Gebetsroither for pointing out this issue and help on
the patch.
2013-09-24 21:06:26 +02:00
Florian Apolloner
5d74853e15
Revert "Ensure that passwords are never long enough for a DoS."
...
This reverts commit aae5a96d57
.
This fix is no longer necessary, our pbkdf2 (see next commit) implementation
no longer rehashes the password every iteration.
2013-09-24 21:01:21 +02:00
Michael Manfre
9a041807fc
Fixed #18333 - Quoted annotated column names
2013-09-24 10:10:08 -04:00
Andrei Picus
8e737cf282
Fix small grammatical error in comment.
...
Changed 'there are no filtering' to 'there is no filtering'.
2013-09-24 14:55:05 +03:00
Michał Lech
53c7d66869
Marked PermissionsMixin.user_permissions help_text for translation
2013-09-24 07:36:24 -04:00
Claude Paroz
18fb713e7b
Properly marked skipped GIS tests as skipped
2013-09-24 12:23:42 +02:00
Claude Paroz
45403d330a
Reformatted some GIS distance tests
2013-09-24 12:23:42 +02:00
Claude Paroz
4c5bc1ac30
Removed double import in mysql base.py
2013-09-24 10:25:39 +02:00
Helen ST
41167645b1
Fixed #14028 - Added validation for clashing db_columns.
...
Thanks akaariai for the suggestion.
2013-09-23 11:51:58 -04:00
Florian Apolloner
2ca00faa91
Fixed "Address already in use" from liveserver.
...
Our WSGIServer rewrapped the socket errors from server_bind into
WSGIServerExceptions, which is used later on to provide nicer
error messages in runserver and used by the liveserver to see if
the port is already in use. But wrapping server_bind isn't enough since
it only binds to the socket, socket.listen (which is called from
server_activate) could also raise "Address already in use".
Instead of overriding server_activate too I chose to just catch socket
errors, which seems to make more sense anyways and should be more robust
against changes in wsgiref.
2013-09-22 22:02:59 +02:00
Aymeric Augustin
51ed1ef1d5
Fixed a mistake in my previous commit.
2013-09-22 14:36:53 +02:00
Aymeric Augustin
a5b062576b
Removed a few trailing backslashes.
...
We have always been at war with trailing backslashes.
2013-09-22 14:04:10 +02:00
Aymeric Augustin
ee0ef1b094
Partial revert of 165f44aa
.
...
That commit didn't always improve readability.
See discussion on django-developers for details.
2013-09-22 14:04:10 +02:00
Florian Apolloner
56743cf9e3
Ensured that BoundField.as_widget always returns properly localized fields.
...
This is a follow-up to #18777 which improperly converted to strings in
prepare_value and as such caused regressions like #21074 .
Refs #18777 , #21074
2013-09-21 22:54:00 +02:00
tschilling
0d1ba84d13
Fixed #20702 -- Deprecated get_formsets in favor of get_formsets_with_inlines.
...
Thanks stanislas.guerra at gmail.com for the report.
2013-09-20 07:47:24 -04:00
Paul McMillan
f8f47718ab
Merge pull request #1644 from PaulMcMillan/bump_hash_iterations
...
Increase default PBKDF2 iterations
2013-09-19 12:17:56 -07:00
yokomizor
df27803a55
Fixed #9532 -- Added min_num and validate_min on formsets.
...
Thanks gsf for the suggestion.
2013-09-19 13:11:49 -04:00
Paul McMillan
a075e2ad0d
Increase default PBKDF2 iterations
...
Increases the default PBKDF2 iterations, since computers have gotten
faster since 2011. In the future, we plan to increment by 10% per
major version.
2013-09-19 18:02:25 +01:00
Kevin Christopher Henry
59a34c43a8
Fixed #18744 -- Updated docstring to highlight limitations of NamedTemporaryFile
...
- Noted that this does not allow for reading and writing the same open
file in different processes under Windows.
- Noted that the keyword arguments to NamedTemporaryFile no longer
match the Python version.
2013-09-19 10:12:03 -04:00
Curtis Maloney
4e9f800742
Fixed #21125 -- Removed support for cache URI syntax
2013-09-19 10:01:39 -04:00
Tim Graham
7fec5a2240
Fixed #7557 -- Added type checking to Variable initialization.
...
Thanks tobias for the suggestion and boblefrag and saz for work on the
patch.
2013-09-19 09:27:19 -04:00
Tim Graham
e23de9e350
Fixed typo in exception message; refs #19414
...
Thanks Alexey Boriskin for the report.
2013-09-19 06:24:12 -04:00
Brian Holdefehr
98514849dc
Fixed #19414 -- Added admin registration decorator
...
Thanks stavros for the suggestion.
2013-09-18 11:44:10 -04:00
Tim Graham
2daada800f
Fixed #21098 -- Applied sensitive_post_parameters to MultiValueDict
...
Thanks simonpercivall for the report and bmispelon for the review.
2013-09-18 09:48:36 -04:00
Berker Peksag
2f0566fa61
Fixed #4278 -- Added a dirs parameter to a few functions to override TEMPLATE_DIRS.
...
* django.template.loader.get_template()
* django.template.loader.select_template()
* django.shortcuts.render()
* django.shortcuts.render_to_response()
Thanks amcnabb for the suggestion.
2013-09-18 07:37:08 -04:00
Tim Graham
893198509e
Fixed #15625 -- Made message in MultiValueDictKeyError less verbose.
...
Thanks margieroginski for the suggestion.
2013-09-18 06:44:38 -04:00
Anssi Kääriäinen
50633e7353
Fixed #12568 -- no error when accessing custom field's descriptor
...
The SubfieldBase's descriptor caused an AttributeError when accessed
from the class. Introspection didn't like that.
Patch by Trac alias supervacuo.
2013-09-18 10:03:52 +03:00
Markus Holtermann
a772ea8117
Fixed #21115 -- Fixed NameError in migrate --list command
2013-09-17 12:53:59 -04:00
Florian Apolloner
2c6079775e
Destroy selenium before live server threads.
...
Ensure that selenium quits before the live server thread to
prevent occasional hangs when killing the live server.
2013-09-17 18:39:25 +02:00
Markus Holtermann
5a424c2393
Fixed #21114 -- Migrations must not have a dependency to themselves.
2013-09-17 11:47:19 -04:00
Florian Apolloner
73a610d2a8
Final attempt to solve sporadic test failures.
...
tearDownClass is not called if setUpClass throws an exception, in our case
this means that LiveServerTestCase leaks LiveServerThread sockets if the
test happens to be skipped later on, and AdminSeleniumWebDriverTestCase
doesn't close it's already open browser window. To prevent this leakage
we catch errors where needed and manually call _tearDownClassInternal.
_tearDownClassInternal should be written as defensively as possible since
it is not allowed to make any assumptions on how far setUpClass got.
This patch should fix the sporadic "Address already in use"-errors on jenkins
and also the "This code isn't under transaction management"-error for sqlite
(also just on jenkins).
After discussion with koniiiik, jezdez, kmtracey, tos9, lifeless, nedbat and
voidspace it was decided that this is the safest approach (thanks to everyone
for their comments and help). Manually calling tearDownClass was shut down
cause we don't know how our users override our classes.
This is a private and very specialized API on purpose and should not be used
without a strong reason!
This patch partially reverts the earlier attempts to fix those issues,
namely:
2fa0dd73b1
and
3c5775d36f
Final note: If this patch breaks in a later version of Django, please be
very careful on how you fix it, you might not see test failures locally.
That said, this patch hopefully doesn't produce even more failures.
2013-09-17 16:41:01 +02:00
Beshr Kayali
8e04ad9fc2
Added Arabic mapping to contrib/admin/static/admin/js/urlify.js
2013-09-17 10:34:12 -04:00
Simon Charette
f5f662fa5f
Fixed #21112 -- Make sure sitemaps with no lastmod date work correctly.
...
Thanks to Matthias Kestenholz for the report and patch.
2013-09-17 10:21:11 -04:00