2bb3401d06
Fixed various validation errors caught by the validator.nu HTML5 validator.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16051 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-04-20 17:41:04 +00:00
4749159d48
Silenced a DeprecationWarning in formtools caused by testing the deprecated security_hash function
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15996 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-04-02 13:26:19 +00:00
d60ae0b721
Removed deprecated 'no' translation
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15988 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-04-02 08:43:43 +00:00
c1df35b0fa
Advanced deprecations in contrib.formtools.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15972 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-04-02 08:34:15 +00:00
c922a04675
Updated FormPreview to use form_hmac rather than the old security_hash function
...
This ought to have been done in [14218], but although the FormPreview class
was modified, and some tests were added, the crucial lines of code were not
changed (the 'FormPreview.security_hash' method), and tests for the new
behaviour were not added. So it is being changed now. Unlike some of the
other code in that changeset, this does not need to have a compatibility
fallback to cope with existing hashes, because the consequence of a failed
hash is minimal - the user is re-presented with the preview stage of the
form, which will then have a correct hash.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15952 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-30 17:35:01 +00:00
fa4bbfcbfb
Removed Django 1.2 compatibility fallback for form wizard hash
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15951 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-30 17:34:49 +00:00
a89ee065a1
Removed no-longer-valid comment about Python 2.3 and 2.4 in formtools/utils.py
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15931 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-28 02:26:15 +00:00
a87be3554f
Removed a bunch of Python 2.4 workarounds now that we don't support it. Refs #15702 -- thanks to jonash for the patch. Splitting this over muliple commits to make it more manageable.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15926 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-28 01:40:43 +00:00
ada8e2a6fa
Pulled translation updates from Transifex again.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15886 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-20 22:16:14 +00:00
5347bbd514
Fixed plural forms formula for the Croatian (hr) localization by manually overriding the header of affected .po files and re-generating .mo files, this seems to be a quirck in Transifex export to PO functionality. Thanks bmihelac fot the report. Refs #15634 .
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15875 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-17 22:56:10 +00:00
25f975a729
Pulled formtools translation updates from Transifex.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15830 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-15 20:09:10 +00:00
90564a156c
Fixed Hungarian, Russian, Serbian and Ukranian plural forms introduced in r15680.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15752 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-04 01:07:11 +00:00
c11140d04b
Fixed plural forms of Irish translation introduced in r15680.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15751 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-04 01:05:10 +00:00
53b2a25396
Fixed plural forms of Welsh translation introduced in r15680.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15750 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-04 01:04:31 +00:00
bef353873e
Fixed plural forms of Bosnian translation introduced in r15680.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15749 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-04 01:03:14 +00:00
afd040d4d3
Updated test assertions that have been deprecated by the move to unittest2. In summary, this means:
...
assert_ -> assertTrue
assertEquals -> assertEqual
failUnless -> assertTrue
For full details, see http://www.voidspace.org.uk/python/articles/unittest2.shtml#deprecations
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15728 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-03 15:04:39 +00:00
533517ec65
Updated formtools translations from transifex.net. Refs #15300 .
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15688 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-01 09:02:40 +00:00
7536f63b32
Fixed #14768 -- Added an es_MX locale and initial translation. Thanks to Alonso Bautista Villalobos and the rest of the Mexican translation team.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15433 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-02-06 06:06:29 +00:00
3238b6866f
Added new translation files to formtools contrib app.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15264 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-21 18:31:00 +00:00
b7ce6b03bb
Corrected hash in a formtools test to match current method, not Django 1.2
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15199 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-13 23:19:10 +00:00
cfcb591dd8
Fixed some bugs with formtools tests.
...
Without these checks, it is possible for the tests to pass by virtue of
asserts never being reached for some reason (very possible in this case, due
to handling of security hashes).
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15198 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-13 23:18:54 +00:00
a6b9dbc57c
Fixed #15075 - No longer possible to alter the form_list in FormWizard.process_step
...
Thanks to niels, stas for the report, and stas for the patch.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15196 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-13 21:58:11 +00:00
5bc0ec4ec4
Removed all usages of deprecated TestCase methods (self.fail*). This removed most of the Warnings emitted (with -Wall) during the test suite.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14803 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-04 07:28:12 +00:00
70b3ac1f07
Few improvements to FormPreview, thanks Andy!
...
This commit adds several new hooks in backwards-compatible way:
* get_initial to specify initial data based on request
* get_auto_id to enable different AUTO_ID values
* get_context for overriding and extending default context contents
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14659 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-21 13:47:38 +00:00
b84838aef4
Fixed #14576 - FormWizard.done() method doesn't get passed the last form in the list
...
Thanks to cyberdelia for report and test, and steph for the initial patch.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14574 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-16 14:37:00 +00:00
7d0d3b68d6
Fixed bug and test failure introducted in [14290]
...
Thanks Russell for alerting me.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14294 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-20 07:59:17 +00:00
46c17654ed
Fixed #14498 - Forms passed to FormWizard.process_step are not guaranteed to have cleaned_data
...
Thanks to stas for the report.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14290 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-19 20:45:40 +00:00
45c7f427ce
Fixed #14445 - Use HMAC and constant-time comparison functions where needed.
...
All adhoc MAC applications have been updated to use HMAC, using SHA1 to
generate unique keys for each application based on the SECRET_KEY, which is
common practice for this situation. In all cases, backwards compatibility
with existing hashes has been maintained, aiming to phase this out as per
the normal deprecation process. In this way, under most normal
circumstances the old hashes will have expired (e.g. by session expiration
etc.) before they become invalid.
In the case of the messages framework and the cookie backend, which was
already using HMAC, there is the possibility of a backwards incompatibility
if the SECRET_KEY is shorter than the default 50 bytes, but the low
likelihood and low impact meant compatibility code was not worth it.
All known instances where tokens/hashes were compared using simple string
equality, which could potentially open timing based attacks, have also been
fixed using a constant-time comparison function.
There are no known practical attacks against the existing implementations,
so these security improvements will not be backported.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14218 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-14 20:54:30 +00:00
121d2e3678
Fixed #12991 -- Added unittest2 support. Thanks to PaulM for the draft patch, and to Luke, Karen, Justin, Alex, Łukasz Rekucki, and Chuck Harmston for their help testing and reviewing the final patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14139 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-11 12:55:17 +00:00
3c99d06229
Fixed #13951 -- Corrected docstring in formtools wizard. Thanks to suzaku for the report, and lrekucki for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@13630 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-08-23 08:11:24 +00:00
5211f48ae3
Fixed #12164 -- Removed the Python 2.3 compatibility imports and workarounds. Thanks to timo and claudep for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@13094 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-05-04 14:00:30 +00:00
17c466a57b
Fixed a silly bug in [12644].
...
Kids, please don't drink and code; the commit you save might be your own.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12646 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-01 23:59:22 +00:00
4c18facdf7
Fixed #1104 : set `FormWizard.extra_context` in `__init__` to avoid context leakage.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12644 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-01 23:26:08 +00:00
41c30f2fb8
Fixed #12981 -- Removed some stray tabs. Thanks to loewis for the report.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12614 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-02-27 05:38:17 +00:00
a9b2ac25d1
Fixed #9147 -- Added `FormPreview.process_preview` customization hook. Thanks, bthomas and thalin.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12486 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-02-22 05:00:36 +00:00
4bff194633
Fixed #12804 - regression with decorating admin views.
...
This is a BACKWARDS INCOMPATIBLE change, because it removes the flawed
'auto_adapt_to_methods' decorator, and replaces it with 'method_decorator'
which must be applied manually when necessary, as described in the 1.2
release notes.
For users of 1.1 and 1.0, this affects the decorators:
* login_required
* permission_required
* user_passes_test
For those following trunk, this also affects:
* csrf_protect
* anything created with decorator_from_middleware
If a decorator does not depend on the signature of the function it is
supposed to decorate (for example if it only does post-processing of the
result), it will not be affected.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12399 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-02-09 15:02:39 +00:00
7230a995ce
Moved contrib.csrf.* to core code.
...
There is stub code for backwards compatiblity with Django 1.1 imports.
The documentation has been updated, but has been left in
docs/contrib/csrf.txt for now, in order to avoid dead links to
documentation on the website.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@11661 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-10-27 00:36:34 +00:00
8e70cef9b6
Fixed #9977 - CsrfMiddleware gets template tag added, session dependency removed, and turned on by default.
...
This is a large change to CSRF protection for Django. It includes:
* removing the dependency on the session framework.
* deprecating CsrfResponseMiddleware, and replacing with a core template tag.
* turning on CSRF protection by default by adding CsrfViewMiddleware to
the default value of MIDDLEWARE_CLASSES.
* protecting all contrib apps (whatever is in settings.py)
using a decorator.
For existing users of the CSRF functionality, it should be a seamless update,
but please note that it includes DEPRECATION of features in Django 1.1,
and there are upgrade steps which are detailed in the docs.
Many thanks to 'Glenn' and 'bthomas', who did a lot of the thinking and work
on the patch, and to lots of other people including Simon Willison and
Russell Keith-Magee who refined the ideas.
Details of the rationale for these changes is found here:
http://code.djangoproject.com/wiki/CsrfProtection
As of this commit, the CSRF code is mainly in 'contrib'. The code will be
moved to core in a separate commit, to make the changeset as readable as
possible.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@11660 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-10-26 23:23:07 +00:00
96b5b6b34c
Fixed #10643 : fixed the formtools security hash to handle allowed empty forms or forms without changed data.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10753 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-12 22:02:38 +00:00
fce800f3fd
Fixed #10034 : the formtools security hash function is now friendlier to browsers that submit leading/trailing whitespace in form fields.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10752 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-12 21:54:58 +00:00
b4f5655c86
Fixed #10553 -- Corrected several uses of `URLconf` in documentation and comments, according to the Django style guide. Based on patch from rduffield.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10256 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-31 16:07:07 +00:00
24d3129edd
Fixed #8570 : Corrected some code that was using 8-space tabs for some reason. Thanks to Manuel Saelices for the report.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9019 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-14 07:04:40 +00:00
6bdb7b9529
Fixed #8172 -- Improved a whole bunch of contrib templates (admin, databrowse, admindocs, etc.) to remove unnecessary 'escape' filters, given autoescaping. Also removed unnecessary {% if %} tags and shortened some {% if %}/{% else %} tags to use {% firstof %}. Thanks for the patch, benspaulding
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8984 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-08 05:19:28 +00:00
2ca8cf3628
Fixed #8653 : make formtools' security hash more rubust. Silly that I didn't think of this before; thanks to bthomas for providing the obvious fix.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8715 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-29 19:15:34 +00:00
0c66bac4f3
Marked a handful of missed strings for translation. Fixes #8644 , #8617 , and #8610 .
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8679 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-28 20:17:31 +00:00
70966cb9c7
Fixed #6893 : `FormWizard` now properly updates its `step` value. Thanks, siddhi and wamberg.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8603 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-26 21:33:56 +00:00
6056ab1bee
Fixed #6209 : handle `BooleanField`s in `FormPreview` and `FormWizard`. In the process, broke the the security hash calculation out to a helper function. Thanks to mcroydon and rajeshdhawan.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8597 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-26 20:19:12 +00:00
c85c8f8891
Fixed #7919 -- md5 and sha modules are deprecated since Python 2.5, use hashlib module when available. Patch from Karen Tracey.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8193 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-02 05:56:57 +00:00
29f0e8182f
Fixed #7847 -- Removed a whole bunch of unused imports from throughout the codebase. Thanks, julien
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8046 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-07-22 03:24:09 +00:00
46786b4193
Fixed #7741 : django.newforms is now django.forms. This is obviously a backwards-incompatible change. There's a warning upon import of django.newforms itself, but deeper imports will raise errors.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7971 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-07-19 01:22:26 +00:00
415bd694f9
Fixed #7521 -- Added the ability to customize ROOT_URLCONF for the duration of a TestCase. Thanks to Mark Fargas (telenieko) for his work on this patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7805 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-06-30 12:34:29 +00:00
e726065d5d
Fixed #6812 -- Modified the formtools test case to be run order safe with respect to the ROOT_URLCONF setting. Thanks for the patch, james
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7705 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-06-19 13:32:39 +00:00
260d3be69f
Fixed #7354 -- Fixed a Python 2.3 compatibility issue in formtools/wizard.py. Thanks, mage
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7657 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-06-16 04:06:50 +00:00
9b52f35f35
Added "svn:eol-style native" to every text file in the tree (*.txt, *.html,
...
*.py, *.xml and AUTHORS, etc). Added "svn:ignore *.pyc" to some directories in
tests/regressiontests/ that were previously missing it.
Fixed #6545 , #6801 .
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7294 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-03-18 14:54:39 +00:00
17155d3845
Fixed corner-case bug in formtools wizard.py and preview.py, in case of a None value -- thanks, Honza
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7277 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-03-18 00:17:59 +00:00
b1dbff729f
Added parse_params() hook to FormWizard
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7263 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-03-17 15:53:01 +00:00
48d7a6fb30
Fixed #3218 -- Implemented django.contrib.formtools.wizard. Thanks, Honza and Oyvind. Note that there are no docs yet
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7236 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-03-13 20:12:53 +00:00
f1a24be01c
Fixed #6481 -- Fixed a bunch of import problems (and some whitespace cleanups).
...
Found by Bastian Kleineidam with help from pyflakes. Thanks.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7131 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-02-19 00:08:08 +00:00
e0bff49063
Fixed a Python 2.3 incompatibility.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6754 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-29 21:10:11 +00:00
7df7791742
Fixed #5441 -- Added tests for django.contrib.formtools. Thanks, simeon.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6734 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-29 16:32:23 +00:00
92e55fe8b1
Fixed #5432 -- Added docs/form_preview.txt. Thanks, ryankanno
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6247 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-14 23:15:40 +00:00
d8db013eea
Fixed #4330 -- Fixed typo when retrieving field names. Patch from Marc Fargas.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5293 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-05-19 18:54:35 +00:00
b996e214c0
Changed the fix from [5231] so that the backwards-incompatibility is made more
...
obvious and everything still has nice names.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5237 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-05-14 16:24:51 +00:00
61d6249c2b
Fixed #3758 -- Changed FormPreview template to use 'label' instead of 'verbose_name'. Also renamed 'Submit' button to 'Preview'. Thanks for the patch, erickt@dslextreme.com
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@4757 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-03-20 16:54:05 +00:00
0919920bc0
Added missing import to django.contrib.formtools.preview from [4259]. Thanks, Vadim Macagon
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@4260 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-12-30 00:06:28 +00:00
3dbaf60b86
Fixed #3204 -- Changed FormPreview to use RequestContext
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@4259 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-12-29 19:42:56 +00:00
311fadeee0
Added django.contrib.formtools, including the forced-preview application
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@4164 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-12-05 20:51:25 +00:00
Luke Plant
Russell Keith-Magee
Adrian Holovaty
Jannis Leidel
Ramiro Morales
Alex Gaynor
Honza Král
Jacob Kaplan-Moss
Justin Bronn
Gary Wilson Jr
Malcolm Tredinnick