343dfff133
Removed the this_is_the_login_form hack
...
Refs #21911 . Now that we have a more traditional login form, we
don't need any more a special field telling us we are dealing with
the login form.
2014-02-04 20:02:28 +01:00
be0ad62994
Fixed #21911 -- Made admin views redirect to login when needed
...
Historically, the Django admin used to pass through the request
from an unauthorized access to the login view directly. Now we
are using a proper redirection, which is also preventing
inadvertantly changing data when POSTing login data to an admin
view when user is already authorized.
Thanks Marc Tamlyn and Tim Graham for the reviews.
2014-02-04 20:02:28 +01:00
5848bea9dc
Made staff_member_required redirect to login
...
Refs #21911 .
2014-02-04 20:02:28 +01:00
76ff266df1
Avoided importing models from django.contrib.admin.
...
Fixed #21923 . Refs #21719 .
2014-02-01 20:38:15 +01:00
2ff93e027c
Fixed #21829 -- Added default AppConfigs.
...
Thanks Russell for the report, Marc for the initial patch, Carl for the
final review, and everyone who contributed to the design discussion.
2014-01-25 10:41:56 +01:00
06bd181f97
Fixed typo in error message.
2014-01-24 17:40:43 +01:00
38be3cf5e4
Fixed #21870 -- Admin check for list_editable_item
...
During the admin check for list_editable _check_list_editable_item
should return an empty list if all checks pass. Additionally the
Testcase test_readonly_and_editable was changed to test what the
name implies instead of duplicating the logic of test_readonly.
2014-01-24 17:40:24 +01:00
c3fdeb28ff
Fixed #21846 -- Made NestedObjects handle related_name with %(app_label)s or %(class)s.
2014-01-22 09:13:15 -05:00
6ab58e3605
Fixed a couple of deprecation warnings
2014-01-20 13:12:15 +02:00
d818e0c9b2
Fixed #16905 -- Added extensible checks (nee validation) framework
...
This is the result of Christopher Medrela's 2013 Summer of Code project.
Thanks also to Preston Holmes, Tim Graham, Anssi Kääriäinen, Florian
Apolloner, and Alex Gaynor for review notes along the way.
Also: Fixes #8579 , fixes #3055 , fixes #19844 .
2014-01-20 10:45:21 +08:00
10e0cfc0e4
Fixed #21712 -- Moved autodiscover() to AdminConfig.ready().
...
Thanks Marc Tamlyn for the initial version of the patch.
2014-01-18 23:06:00 +01:00
8a34d35696
Fixed #21659 -- Modified the registration/password_change_form.html admin template to use {% admin_static %}.
...
Thanks mcella.
2014-01-18 08:33:42 -05:00
b87c59b04b
Removed some unnecessary __exact operators in filters.
2014-01-17 18:12:45 -05:00
6a320cc14a
Fixed #21718 -- Renamed has_app to is_installed.
2014-01-06 22:48:41 +01:00
27afd302c6
Fixed #21675 -- Added app configs for contrib apps.
2014-01-05 21:18:33 +01:00
3bc6b18cb9
Fixed selenium failure.
...
This fixes (at least according to tests on the ci itself)
admin_widgets.tests.RelatedFieldWidgetSeleniumFirefoxTests.test_foreign_key_using_to_field
(http://ci.djangoproject.com/job/Django/database=mysql_gis,python=python2.7/3792/testReport/junit/admin_widgets.tests/RelatedFieldWidgetSeleniumFirefoxTests/test_foreign_key_using_to_field/ )
The cause for this issue seems to be that wait_page_loaded was executed before click fired
and as such no profile got saved (again just an educated guess, but with this fix I can no
longer reproduce it -- fingers crossed).
2014-01-03 11:29:37 +01:00
7d0a519032
Revert "Fixed #21227 -- Added workaround for selenium test failures"
...
This reverts commit 08c9ab5a0f
2014-01-03 00:44:49 +01:00
b1a399b864
Removed unneeded import.
2014-01-03 00:42:03 +01:00
ed2828f0a0
Fixed a few flaky selenium tests.
...
Many thanks go to David Burns (@AutomatedTester) for helping me understand
css selectors and pointing me towards the correct selenium methods.
2014-01-03 00:36:50 +01:00
80d74097b4
Stopped populating the app registry as a side effect.
...
Since it triggers imports, it shouldn't be done lightly.
This commit adds a public API for doing it explicitly, django.setup(),
and does it automatically when using manage.py and wsgi.py.
2013-12-30 22:11:17 +01:00
20d487c27b
Replaced Options.object_name.lower() by Options.model_name.
...
Thanks Simon for the suggestion.
Also removed inappropriate lowercasing of app labels in migrations.
Unlike model names, they are case sensitive.
2013-12-29 18:48:37 +01:00
6e3ca6507c
Used app_config.verbose_name instead of app_label|capfirst.
...
An admin view performed the capitalization in the template, unlike all others.
Refs #10436 .
2013-12-26 22:58:37 +01:00
8f04f53dd8
Removed a few gratuitous lambdas.
2013-12-26 14:03:50 +01:00
1716b7ce5a
Renamed AppCache to Apps.
...
Also renamed app_cache to apps and "app cache" to "app registry".
Deprecated AppCache.app_cache_ready() in favor of Apps.ready().
2013-12-24 12:25:17 +01:00
8cff95e937
Used a more translator-friendly format in admin sites.py
2013-12-23 09:44:16 +01:00
ba60fcbcf7
Used application verbose names in the admin.
2013-12-22 16:53:57 +01:00
2fef9e5375
Moved apps back in the toplevel django namespace.
...
Reverted 4a56a93cc4
2013-12-22 11:39:55 +01:00
2239081ff1
Expurged INSTALLED_APPS from code and tests.
...
Except the app cache code and a few specific tests, of course.
2013-12-22 11:39:18 +01:00
9cdf1f6d54
Stop testing for inclusion in INSTALLED_APPS.
...
Removed some exception masking in the comments app that was harmful and
couldn't be preserved easily.
2013-12-22 11:39:18 +01:00
86804ab063
Terminated AppCache._populate() with extreme prejudice.
...
It was called _populate() before I renamed it to populate(). Since it
has been superseded by populate_models() there's no reason to keep it.
Removed the can_postpone argument of load_app() as it was only used by
populate(). It's a private API and there's no replacement. Simplified
load_app() accordingly. Then new version behaves exactly like the old
one even though it's much shorter.
2013-12-22 11:39:17 +01:00
b80a8357d6
Revert "Changed admin/templates/admin/index.html to make <caption> translatable"
...
This reverts commit a25fe3b65ehttps://groups.google.com/d/msg/Django-I18N/vc2vQzv80UQ/EuaW38V7X7sJ
Conflicts:
django/contrib/admin/templates/admin/index.html
2013-12-20 15:19:03 +01:00
4a56a93cc4
Moved the new app cache inside core.
2013-12-17 10:17:46 +01:00
d44de9b933
Removed the _-prefix for populate().
...
Several parts of Django call get_apps() with a comment along this lines
of "this has the side effect of calling _populate()". I fail to see how
this is better than just calling populate()!
2013-12-17 10:17:45 +01:00
8662654d6d
Removed module-level functions for the app cache.
...
Since the original ones in django.db.models.loading were kept only for
backwards compatibility, there's no need to recreate them. However, many
internals of Django still relied on them.
They were also imported in django.db.models. They never appear in the
documentation, except a quick mention of get_models and get_app in the
1.2 release notes to document an edge case in GIS. I don't think that
makes them a public API.
This commit doesn't change the overall amount of global state but
clarifies that it's tied to the app_cache object instead of hiding it
behind half a dozen functions.
2013-12-17 10:17:44 +01:00
3ce9829b61
Fixed #17413 -- Serialization of form errors along with all metadata.
2013-12-16 16:33:28 -05:00
6685713869
Fixed E127 pep8 warnings.
2013-12-14 11:59:15 -05:00
c7c647419c
Fixed #21510 -- Readded search reset link in changelist search bar
...
Thanks moritz.pfeiffer at alp-phone.ch for the report and
Tim Graham for the initial patch.
2013-12-11 15:30:20 +01:00
a2814846ca
Fixed E124 pep8 warnings.
2013-12-10 15:12:48 -05:00
65faa84de3
Removed unneeded string normalization in contrib.admin
...
With Python 2.7 and up, named parameter keys are not limited to
bytestrings any longer. This mainly reverts 3bd384aa62
2013-12-07 15:58:27 +01:00
7477a4ffde
Fixed E125 pep8 warnings
2013-11-28 08:50:11 -05:00
c74504c2dd
Fixed #20522 - Allowed use of partially validated object in ModelAdmin.add_view formset validation.
...
Updated ModelAdmin to use form.instance when passing parent model to
child inlines for add_view. There is effectively no change in the
change_view since the previously passed 'obj' is the same as form.instance.
Thanks to meshy for report, and EvilDMP and timo for review.
2013-11-25 20:01:16 -05:00
3ca0815c0b
Fixed #21445 -- Clean up misuse of null in quickElement.
...
Thanks to trac user parsch for the report.
2013-11-23 14:40:01 +01:00
1718b5256c
Fixed #21405 -- Prevented queryset overwrite in BaseModelAdmin
...
Thanks guido@20tab.com for the report and Tim Graham for the
analyze.
2013-11-21 22:18:52 +01:00
f39fd3cd20
Removed isinstance(RelatedObject) checks from admin.utils
2013-11-21 14:52:01 +02:00
752d3d70da
Fixed #21431 -- GenRel->FK list_filter regression in admin
...
Report, analysis and tests from stephenmcd.
2013-11-21 14:52:00 +02:00
8e670a0e50
Refs #8261 -- Fixed regression introduced by fd219fa.
...
ModelAdmin displayed the "View on site" link even if the Model didn't
define the `get_absolute_url()` method.
2013-11-21 16:26:49 +07:00
68b540c977
Fixed #21361 -- allowed access self.value() from SimpleListFilter lookup
...
Reviewed by Chris Medrela.
2013-11-19 09:14:22 +02:00
b2d2d7e60f
Optimise admin images
2013-11-18 13:33:28 +11:00
4142d15102
Fixed #21388 -- Corrected language code for Frisian
2013-11-11 13:34:01 +01:00
c347f78cc1
Fixed all E226 violations
2013-11-03 10:08:55 -08:00
Claude Paroz
Aymeric Augustin
Arne Brodowski
Loic Bistuer
Anssi Kääriäinen
Russell Keith-Magee
Tim Graham
Florian Apolloner
Christopher Medrela
Jay Leadbetter
Baptiste Mispelon
Vajrasky Kok
Curtis Maloney
Bouke Haarsma
Alex Gaynor