François Freitag
aa9569fce1
Fixed #27218 -- Returned LogEntry instances from ModelAdmin.log_*() methods.
2016-10-04 14:08:53 -04:00
Claude Paroz
67eee5e4fa
Fixed #27302 -- Fixed ModelAdmin.construct_change_message() changed field detection
...
Thanks Ramiro Morales for the report and Tim Graham for the review.
2016-10-01 20:14:27 +02:00
Jibodeah
9459ec82aa
Fixed #26170 -- Made ModelAdmin views run transactions on the correct database.
...
Thanks juntatalor for the initial patch.
2016-09-14 16:06:39 -04:00
Mattias Loverot
2315114090
Fixed #27067 -- Deprecated string_concat() in favor of format_lazy().
2016-08-25 16:12:40 -04:00
Berker Peksag
3c97ba2a0d
Replaced property() usage with decorator in a couple places.
2016-08-24 17:23:16 -04:00
Stanislav Karpov
b387189d86
Fixed #26919 -- Added the action form's media in the changelist view.
2016-08-11 19:35:31 -04:00
Pyie Zone
054e74420b
Refs #16501 , #26474 -- Added xregexp.js source file.
2016-06-06 09:25:02 -04:00
Collin Anderson
38c43b2a5c
Refs #24227 -- Partially reverted replacement of M2M isinstance checks by field.many_to_many.
...
This fixes django-taggit and reflects some places where duck-typing may not
be appropriate.
2016-05-11 10:29:01 -04:00
marysia
b9290b1d49
Fixed #26449 -- Merged admin's FORMFIELD_FOR_DBFIELD_DEFAULTS with formfield_overrides.
...
Useful for overriding the DateTimeField widget.
2016-05-07 19:52:45 -04:00
Markus Amalthea Magnuson
08cd6a0e56
Fixed #16327 -- Redirected "Save as new" to change view instead of the changelist.
2016-04-20 11:31:44 -04:00
Tim Graham
df8d8d4292
Fixed E128 flake8 warnings in django/.
2016-04-08 09:51:06 -04:00
Tim Graham
2cd2d18851
Fixed W503 flake8 warnings.
2016-04-04 17:14:26 -04:00
Akshesh
49ac10b4de
Fixed #26235 -- Handled ProtectedError in a POST to admin's delete_view().
2016-03-21 19:25:27 -04:00
Claude Paroz
983c158da7
Refs #24227 -- Replaced M2M isinstance checks by field.many_to_many
...
Thanks Markus Holtermann, Collin Anderson and Tim Graham for the reviews.
2016-03-19 09:24:27 +01:00
bphillips
917cc288a3
Fixed #11313 -- Made ModelAdmin.list_editable more resilient to concurrent edits.
...
Allowed admin POSTed bulk-edit data to use modeladmin.get_queryset()
so that the ids in the POST data have a chance to match up even if
the objects on the current page changed based on the ordering.
2016-02-01 16:05:01 -05:00
Myk Willis
62f3acc70a
Fixed incorrect permissions check for admin's "Save as new".
...
This is a security fix.
2016-02-01 11:57:00 -05:00
Alexander Gaevsky
c79852acee
Fixed #14402 -- Removed clearing of help_text for ManyToManyField's raw_id_fields.
2016-01-30 12:42:47 -05:00
Tim Graham
3541ca1504
Refs #25165 -- Fixed JSON serialization for delete popup in the admin.
2016-01-09 13:35:58 -05:00
Claude Paroz
cf7894be88
Fixed #21113 -- Made LogEntry.change_message language independent
...
Thanks Tim Graham for the review.
2016-01-08 20:34:59 +01:00
Alexander Gaevsky
ade54ffa34
Refs #25165 -- Fixed JSON serialization for add/edit popup in the admin.
...
Forwardport of test in o839d71d8562abe0b245024e55ca1d02a45e58fd from stable/1.9.x
(refs #25997 ).
2016-01-08 12:28:32 -05:00
Tim Graham
822a03b3e4
Refs #25165 -- Fixed failure of admin's "Add another" popup to close.
...
Thanks Thomas Grainger for the fix.
2016-01-08 11:41:01 -05:00
Marten Kenbeek
16411b8400
Fixed #26013 -- Moved django.core.urlresolvers to django.urls.
...
Thanks to Tim Graham for the review.
2015-12-31 14:21:29 -05:00
Tim Graham
dbb0df2a0e
Fixed #25985 -- Updated signature of ModelAdmin.formfield_for_* to make request a positional argument.
2015-12-29 12:49:14 -05:00
Karen Tracey
5399ccc0f4
Fixed #494 -- Added ability to specify classes on admin inline fieldsets.
...
This includes the ability to collapse inlines by specifying a class named
'collapse'.
2015-12-21 13:50:06 -05:00
Johannes Hoppe
cf546e11ac
Fixed #21221 -- Made form Media and static template tag use staticfiles if installed.
2015-12-10 14:30:19 -05:00
Thomas Grainger
d638cdc42a
Fixed #25165 -- Removed inline JavaScript from the admin.
...
This allows setting a Content-Security-Policy HTTP header
(refs #15727 ).
Special thanks to blighj, the original author of this patch.
2015-12-05 15:51:57 -05:00
Anton Baklanov
80bcbecd4a
Fixed #19361 -- Added link to object's change form in admin's post-save message.
...
Thanks Roel Kramer for tests.
2015-11-19 15:04:32 -05:00
Simon Charette
9dcfecb7c6
Fixed #25622 -- Accounted for generic relations in the admin to field validation
...
Thanks to Jonathan Liuti for the report and Tim Graham for the review.
2015-10-29 13:13:19 -04:00
Malcolm Box
1d8eb0cae5
Fixed #25374 -- Made ModelAdmin checks work on instances instead of classes.
...
This allows dynamically-generated attributes to be specified in
checked ModelAdmin attributes without triggering errors.
2015-09-11 09:28:34 -04:00
Ola Sitarska
f2f8972def
Fixed #25135 -- Deprecated the contrib.admin allow_tags attribute.
...
Thanks Jaap Roes for the idea and initial patch.
2015-09-08 19:13:43 -04:00
Edward Henderson
f8cc464452
Fixed #16501 -- Added an allow_unicode parameter to SlugField.
...
Thanks Flavio Curella and Berker Peksag for the initial patch.
2015-07-17 13:48:58 -04:00
jpic
fedef7b2c6
Fixed #24908 -- Fixed duplicate readonly field rendering.
...
ModelAdmin added readonly_fields to exclude, but would not undeclare
them if they were overridden.
2015-07-02 13:37:30 -04:00
Trey Hunner
788071e22d
Moved jQuery to a vendor/jquery subdirectory.
2015-06-07 22:23:42 +02:00
Loek van Gent
0207bdd2d4
Fixed #24474 -- Allowed configuring the admin's empty change list value.
2015-06-04 21:06:26 -04:00
Piotr Jakimiak
4157c502a5
Removed unnecessary arguments in .get method calls
2015-05-13 20:51:18 +02:00
Adam Zapletal
0894643e40
Fixed #23387 -- Kept "Save as new" button after validation errors in admin.
...
When "Save as new" is chosen and errors occur, only show the "Save as new"
button and not the other save buttons.
Thanks to Tino de Bruijn for doing the real work on this fix.
2015-05-02 19:41:10 -04:00
Tim Graham
1273a7a0e8
Revert "Fixed #24474 -- Allowed configuring the admin's empty change list value."
...
This reverts commit 72f769f494
.
There are several test failures that need to be fixed.
2015-04-08 20:39:59 -04:00
Loek van Gent
72f769f494
Fixed #24474 -- Allowed configuring the admin's empty change list value.
2015-04-08 20:27:01 -04:00
Tim Graham
845817b039
Fixed #24466 -- Added JavaScript escaping in a couple places in the admin.
...
Thanks Aymeric Augustin and Florian Apolloner for work on the patch.
2015-03-30 19:07:17 -04:00
Anssi Kääriäinen
8f30556329
Renamed Field.rel attribute to remote_field
...
Field.rel is now deprecated. Rel objects have now also remote_field
attribute. This means that self == self.remote_field.remote_field.
In addition, made the Rel objects a bit more like Field objects. Still,
marked ManyToManyFields as null=True.
2015-03-25 08:16:12 -04:00
TomV
a4a58811b9
Removed redundant model instantiation in contrib.admin; refs #11390 .
2015-03-23 10:06:25 -04:00
Karl Hobley
aea02ddfb7
Fixed #24490 -- Set LogEntry.change_message when adding an object.
2015-03-20 18:25:06 -04:00
Loek van Gent
35b3158d52
Fixed #24417 -- Added ModelAdmin.get_list_select_related()
2015-03-19 08:52:28 -04:00
Anton Danilchenko
28e8c54d7d
Fixed #24467 -- Removed conditional inclusion of actions.js & prepopulate.js.
...
The JavaScript may be required when using ModelAdmin.get_actions() or
get_prepopulated_fields(). Always including them is the easiest solution.
2015-03-11 20:18:59 -04:00
Tim Graham
47b35b1844
Fixed #24411 -- Avoided dict key/method clash in admin delete views.
2015-02-25 07:15:56 -05:00
Claude Paroz
1791a7e75a
Fixed #15779 -- Allowed 'add' primary key in admin edition
...
Thanks Marwan Alsabbagh for the report, and Simon Charette and
Tim Graham for the reviews.
2015-02-14 11:19:55 +01:00
Tim Graham
d64baaef3b
Fixed #24333 -- Fixed admin history view crash with non-integer slug.
2015-02-12 14:19:44 -05:00
Tim Graham
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
Tim Graham
67a76500a5
Removed support for admin validators per deprecation timeline; refs #16905 .
2015-01-18 14:43:21 -05:00
Tim Graham
2c9e95639e
Removed ModelAdmin.get_formsets() per deprecation timeline; refs #20702 .
2015-01-17 18:02:35 -05:00
Collin Anderson
a420f83e7d
Fixed #24055 -- Keep reference to view class for resolve()
2015-01-17 22:09:10 +07:00
Tim Graham
d4ee6cda58
Removed ModelAdmin.declared_fieldsets per deprecation timeline; refs #18681 .
2015-01-17 08:40:33 -05:00
Simon Charette
07988744b3
Fixed #13165 -- Added edit and delete links to admin foreign key widgets.
...
Thanks to Collin Anderson for the review and suggestions and Tim for the
final review.
2015-01-10 12:24:52 -05:00
Daniel Pyrathon
fb48eb0581
Fixed #12663 -- Formalized the Model._meta API for retrieving fields.
...
Thanks to Russell Keith-Magee for mentoring this Google Summer of
Code 2014 project and everyone else who helped with the patch!
2015-01-06 19:25:12 -05:00
Daniel Pyrathon
8958170755
Fixed #9104 -- Moved FieldDoesNotExist to core.exceptions
2015-01-02 10:46:04 -05:00
Thomas Tanner
46068d850d
Fixed #22295 -- Replaced permission check for displaying admin user-tools
2014-12-31 16:31:59 -05:00
Berker Peksag
32ca159c96
Ignored warnings correctly in test_get_formsets_with_inlines_returns_tuples().
...
The subclass check in ModelAdmin.get_formsets_with_inlines() wasn't
tested correctly because of the super() call in
EpisodeAdmin.get_formsets().
2014-12-31 08:24:09 -05:00
Aymeric Augustin
cf1f36bb6e
Deprecated current_app in TemplateResponse and render(_to_response).
2014-12-28 17:02:29 +01:00
Anssi Kääriäinen
f233bf47dd
Fixed #21414 -- Removed RelatedObject and deprecated Field.related.
2014-12-23 10:54:25 -05:00
Tim Graham
c7a19f4203
Fixed #23857 -- Fixed admin crash with "save as new" and deleting inline.
...
Thanks amarandon for the report.
2014-12-12 10:24:39 -05:00
Markus Amalthea Magnuson
d4e449d730
Fixed typo in admin deprecation message.
2014-12-11 13:30:31 -05:00
Kamil Braun
0623f4dea4
Fixed #23934 -- Fixed regression in admin views obj parameter.
2014-12-02 08:42:17 -05:00
Simon Charette
3a9aa155e2
Fixed #23915 -- Made sure m2m fields through non-pk to_field are allowed in the admin.
...
refs #23754 , #23862
2014-11-25 15:28:21 -05:00
Simon Charette
f9c4e14aec
Fixed #23754 -- Always allowed reference to the primary key in the admin
...
This change allows dynamically created inlines "Add related" button to work
correcly as long as their associated foreign key is pointing to the primary
key of the related model.
Thanks to amorce for the report, Julien Phalip for the initial patch,
and Collin Anderson for the review.
2014-11-25 13:26:50 -05:00
Konrad Świat
06b11b617e
Fixed #23616 - Fixed generic relations in ModelAdmin.list_filter.
...
Thanks ranjur for reporting bug, timgraham for review,
and collinanderson for contributing tips.
2014-10-10 12:10:32 -04:00
Emmanuelle Delescolle
a24cf21722
Fixed #23604 -- Allowed related m2m fields to be references in the admin.
...
Thanks Simon Charette for review.
2014-10-06 08:35:16 -04:00
Thomas Chaumeny
17557d068c
Fixed #8408 -- Added ModelAdmin.show_full_result_count to avoid COUNT() query.
...
Thanks lidaobing for the suggestion.
2014-09-26 12:12:40 -04:00
Simon Charette
342ccbddc1
Fixed #23431 -- Allowed inline and hidden references to admin fields.
...
This fixes a regression introduced by the 53ff096982
security fix.
Thanks to @a1tus for the report and Tim for the review.
refs #23329 .
2014-09-08 13:49:07 -04:00
Tim Graham
1101467ce0
Limited lines to 119 characters in django/
...
refs #23395 .
2014-09-05 09:22:16 -04:00
Simon Charette
3cbb7590cb
Fixed #23329 -- Allowed inherited and m2m fields to be referenced in the admin.
...
Thanks to Trac alias Markush2010 and ross for the detailed reports.
2014-08-27 21:26:53 -04:00
Simon Charette
53ff096982
Prevented data leakage in contrib.admin via query string manipulation.
...
This is a security fix. Disclosure following shortly.
2014-08-20 14:39:40 -04:00
areski
3021453285
Fixed #20133 -- Added summary to admin deletion confirmation pages.
...
Thanks jonash for the suggestion and initial patch.
2014-08-14 13:56:23 -04:00
Nick Sandford
9d9f0acd7e
Fixed #13163 -- Added ability to show change links on inline objects in admin.
...
Thanks DrMeers for the suggestion.
2014-07-31 08:07:28 -04:00
Daniel Hahler
67f9f385aa
Fixed various minor doc typos / references.
2014-07-05 20:26:26 -04:00
Maxime Turcotte
504c89e800
Fixed #6327 -- Added has_module_permission method to BaseModelAdmin
...
Thanks chrj for the suggestion.
2014-06-13 09:31:40 -04:00
Tim Graham
5046c110cf
Revert "Fixed #19303 -- Fixed ModelAdmin.formfield_overrides on fields with choices"
...
This reverts commit 9d1987d767
.
2014-06-02 07:05:38 -04:00
Stas Rudakou
ebd70d4d00
Fixed #22266 - quote PK before redirecting away from add_view (django.contrib.admin)
2014-05-16 18:33:17 +02:00
Anders Steinlein
4ef10f245a
Fixed #17642 -- Added min_num support to modelformsets, inlines, and the admin.
...
Thanks Stephen Burrows for work on the patch as well.
Forwardport of 2914f66983
from stable/1.7.x
2014-05-15 07:25:35 -04:00
Alex Gaynor
2bcb8bfc8d
Fix many many typos in comments throughout the codebase
2014-04-26 10:18:45 -07:00
Tim Graham
3cba90f22a
Fixed #21084 -- Used proxy model's content type for admin log entries.
...
(the previous commit included only the test)
2014-04-07 09:04:49 -04:00
Tim Graham
d73d0e071c
Fixed #22218 -- Deprecated django.conf.urls.patterns.
...
Thanks Carl Meyer for the suggestion and Alex Gaynor and Carl for reviews.
2014-04-03 07:28:10 -04:00
Alex Gaynor
778ce245dd
Corrected many style guide violations that the newest version of flake8 catches
2014-03-30 12:11:05 -07:00
Ramiro Morales
491419b5ff
Made m2m fields form help_text munging specific to admin widgets.
...
Refs #9321 and follow-up to e80de93af6
.
2014-03-22 15:43:17 -03:00
Tim Graham
274048351a
Removed reading of legacy admin popup GET parameter.
...
refs #20288 .
2014-03-21 11:35:33 -04:00
Tim Graham
bcc15e2b21
Removed backward compatible shims to rename get_query_set and similar queryset methods.
...
Also removed the backward compatible shims introduced to rename the
attributes ChangeList.root_query_set and ChangeList.query_set.
2014-03-21 07:47:25 -04:00
Claude Paroz
210d0489c5
Fixed #21188 -- Introduced subclasses for to-be-removed-in-django-XX warnings
...
Thanks Anssi Kääriäinen for the idea and Simon Charette for the
review.
2014-03-08 09:57:40 +01:00
Greg Chapple
6acaa52386
Fixed #22135 -- Added ModelAdmin.get_changeform_initial_data().
...
Allows custom behavior for setting initial form data in ModelAdmin.
By default, initial data is set via GET params. The new method allows
this behavior to be overridden.
Thanks egasimus for the suggestion.
2014-03-03 07:28:24 -05:00
Adam Avramov
390001ce52
Fixed #21064 -- Refactored common logic in ModelAdmin.add_view and change_view.
2014-02-13 07:31:18 -05:00
Christopher Adams
eefc88feef
Fixed #2445 -- Allowed limit_choices_to attribute to be a callable.
...
ForeignKey or ManyToManyField attribute ``limit_choices_to`` can now
be a callable that returns either a ``Q`` object or a dict.
Thanks michael at actrix.gen.nz for the original suggestion.
2014-02-11 14:05:12 -05:00
Alasdair Nicol
1b29d32894
Fixed #21771 -- Made log_deletion consistent with other log methods.
...
Thanks Keryn Knight for the report.
2014-02-09 12:08:03 -05:00
Aymeric Augustin
76ff266df1
Avoided importing models from django.contrib.admin.
...
Fixed #21923 . Refs #21719 .
2014-02-01 20:38:15 +01:00
Russell Keith-Magee
d818e0c9b2
Fixed #16905 -- Added extensible checks (nee validation) framework
...
This is the result of Christopher Medrela's 2013 Summer of Code project.
Thanks also to Preston Holmes, Tim Graham, Anssi Kääriäinen, Florian
Apolloner, and Alex Gaynor for review notes along the way.
Also: Fixes #8579 , fixes #3055 , fixes #19844 .
2014-01-20 10:45:21 +08:00
Tim Graham
b87c59b04b
Removed some unnecessary __exact operators in filters.
2014-01-17 18:12:45 -05:00
Aymeric Augustin
8f04f53dd8
Removed a few gratuitous lambdas.
2013-12-26 14:03:50 +01:00
Aymeric Augustin
ba60fcbcf7
Used application verbose names in the admin.
2013-12-22 16:53:57 +01:00
Loic Bistuer
a2814846ca
Fixed E124 pep8 warnings.
2013-12-10 15:12:48 -05:00
Christopher Medrela
7477a4ffde
Fixed E125 pep8 warnings
2013-11-28 08:50:11 -05:00
Jay Leadbetter
c74504c2dd
Fixed #20522 - Allowed use of partially validated object in ModelAdmin.add_view formset validation.
...
Updated ModelAdmin to use form.instance when passing parent model to
child inlines for add_view. There is effectively no change in the
change_view since the previously passed 'obj' is the same as form.instance.
Thanks to meshy for report, and EvilDMP and timo for review.
2013-11-25 20:01:16 -05:00
Claude Paroz
1718b5256c
Fixed #21405 -- Prevented queryset overwrite in BaseModelAdmin
...
Thanks guido@20tab.com for the report and Tim Graham for the
analyze.
2013-11-21 22:18:52 +01:00
Loic Bistuer
8e670a0e50
Refs #8261 -- Fixed regression introduced by fd219fa
.
...
ModelAdmin displayed the "View on site" link even if the Model didn't
define the `get_absolute_url()` method.
2013-11-21 16:26:49 +07:00