b91787910c
Fixed #20642 -- Deprecated `Option.get_(add|change|delete)_permission`.
...
Those methods were only used by `contrib.admin` internally and exclusively
related to `contrib.auth`. Since they were undocumented but used
in the wild the raised deprecation warning point to an also undocumented
alternative that lives in `contrib.auth`.
Also did some PEP8 and other cleanups in the affected modules.
2013-06-25 12:22:37 -04:00
f819bef3dc
Fixed #19773 - Added admin/popup_response.html template.
...
Thanks jimmylam@ for the suggestion.
2013-06-25 11:20:41 -04:00
c4a0c91459
Itty bitty typo fix.
...
"deletes" was missing it's last e.
2013-06-19 17:45:28 -06:00
7462a78c1b
Fixed #20288 -- Fixed inconsistency in the naming of the popup GET parameter.
...
Thanks to Keryn Knight for the initial report and reviews,
and to tomask for the original patch.
2013-06-19 22:16:16 +02:00
ffcf24c9ce
Removed several unused imports.
2013-06-19 17:18:40 +02:00
9da9b3eb04
Merge pull request #1281 from loic/ticket6903
...
Fixed #6903 - Preserved admin changelist filters.
2013-06-18 13:07:28 -07:00
c86a9b6398
Fixed #6903 - Preserve admin changelist filters after saving or deleting an object
2013-06-19 02:41:36 +07:00
aeb1389442
Fixed #20079 -- Improve security of password reset tokens
2013-06-18 20:02:00 +02:00
2c4fe761a0
Fixed #20593 -- Allow blank passwords in check_password() and set_password()
2013-06-18 13:32:54 -04:00
ee77d4b253
Fixed #20199 -- Allow ModelForm fields to override error_messages from model fields
2013-06-18 08:01:17 -04:00
1b7634a0d0
Fixed #20464 -- Added a `total_error_count` method on formsets.
...
Thanks to frog32 for the report and to Tim Graham for the review.
2013-06-16 15:49:30 -04:00
beb652e069
Worked around Python 3.3 modified exception repr
...
Refs #20599 .
2013-06-15 11:14:59 +02:00
990f8d92dc
Fixed #20599 -- Changed wording of ValueError raised by _load_library
...
The _load_library method on BasePasswordHasher turns ImportErrors
into ValueErrors, this masks ImportErrors in the algorithm library.
Changed it to a clearer worded error message that includes
the ImportError string.
2013-06-15 10:50:55 +02:00
c6e6d4eeb7
Defined available_apps in relevant tests.
...
Fixed #20483 .
2013-06-10 11:30:01 +02:00
4daf570b98
Added TransactionTestCase.available_apps.
...
This can be used to make Django's test suite significantly faster by
reducing the number of models for which content types and permissions
must be created and tables must be flushed in each non-transactional
test.
It's documented for Django contributors and committers but it's branded
as a private API to preserve our freedom to change it in the future.
Most of the credit goes to Anssi. He got the idea and did the research.
Fixed #20483 .
2013-06-10 11:24:10 +02:00
69373f3420
Fixed #19925 - Added validation for REQUIRED_FIELDS being a list
...
Thanks Roman Alexander for the suggestion.
2013-06-07 19:58:41 -04:00
b67f2ac8e6
Fixed #20502 (again) -- More i18n cache flush in tests
...
Thanks Timo Graham for noticing the failures.
2013-06-06 14:28:58 +02:00
9ed971f4f1
Merge pull request #1245 from oinopion/list_select_related
...
Fixed #19080 -- Fine-grained control over select_related in admin
2013-06-06 01:27:05 -07:00
0fd9f7c95f
Fixed #19080 -- Fine-grained control over select_related in admin
2013-06-05 23:08:00 +02:00
b00c6371af
Fixed #17927 -- Added initial values support for BaseGenericInlineFormSet
...
Thanks Fak3 for the suggestion.
2013-06-05 07:59:59 -04:00
4f4e9243e4
Fixed #20532 -- Reverse auth views by name, not by path.
...
Auth views should be reversed by name, not their locations in
`django.contrib.auth.views`. This allows substituting your own
implementations of the auth views.
2013-06-03 13:30:40 -04:00
590a41164e
Fixed admindoc template errors introduced by 02fd87c821.
...
Also regenerated the affected translation template.
Refs #20540 .
2013-06-02 00:32:29 -04:00
61524b09cf
Fixed #18388 - Added InlineModelAdmin.get_max_num hook.
...
Thanks d.willy.c.c@ for the suggestion and Melevir and Areski Belaid for work
on the patch.
2013-06-01 18:20:54 -04:00
5442fe46da
Updated contrib.admindocs translation template
2013-06-01 12:10:48 +02:00
02fd87c821
Fixed #20540 -- Added more translatable strings to contrib.admindocs
...
Thanks lborgav for the initial patch.
2013-06-01 12:06:36 +02:00
23e1b59cf2
Fixed #18681 -- BaseModelAdmin.get_form and InlineModelAdmin.get_formset no longer bypass get_fieldsets
...
Thanks msopacua for the report.
2013-05-31 12:48:51 -04:00
3d883e8bd9
Merge pull request #1232 from fusionbox/normalize_email
...
Fixed #20531 -- Don't hard-code class names when calling static methods
2013-05-31 00:56:56 -07:00
36aecb12b8
Fixed #19425 - Added InlineModelAdmin.get_extra hook.
...
Thanks dave@ for the suggestion and Rohan Jain for the patch.
2013-05-30 13:48:10 -04:00
01ae881bb4
Don't hard-code class names when calling static methods
...
normalize_email should be called on the instance, not the class. This
has the same effect normally but is more helpful to subclassers. When
methods are called directly on the class, subclasses can't override
them.
2013-05-29 16:11:26 -06:00
d727518ad6
Fixed #20331 -- Allowed admin actions to serve StreamingHttpResponses
...
Thanks Edwin.
2013-05-29 11:25:42 -04:00
5939864616
Fixed #15653 - Error in admin pagination tag.
...
Thanks jcumbo@ for the report and adamzap
and nott for the patch.
2013-05-29 09:23:08 -04:00
0268aba96b
Fixed #20182 - admin lookup should treat 0 as False for __isnull
...
Thanks Benjie Chen.
2013-05-27 13:29:53 -04:00
7a92312827
Fixed #12491 -- Tweak checkbox widget help text alignment on the admin.
...
Thanks master' for the report and Niels van Dijk for the fix
2013-05-27 08:47:18 -03:00
b14bd60404
Reimplemented PostGIS spatial_version with cached_property
2013-05-27 12:06:56 +02:00
0fa8d43e74
Replaced `and...or...` constructs with PEP 308 conditional expressions.
2013-05-26 23:47:50 -03:00
d228c1192e
Fixed #19866 -- Added security logger and return 400 for SuspiciousOperation.
...
SuspiciousOperations have been differentiated into subclasses, and
are now logged to a 'django.security.*' logger. SuspiciousOperations
that reach django.core.handlers.base.BaseHandler will now return a 400
instead of a 500.
Thanks to tiwoc for the report, and Carl Meyer and Donald Stufft
for review.
2013-05-25 16:27:34 -07:00
ab61dd2829
Updated translation catalogs
...
Updated core/admin/admindocs/comments translation catalogs.
2013-05-25 14:32:44 +02:00
b7cf44dde8
Fixed some minor translation-related issues
2013-05-25 14:32:44 +02:00
b3bccce1a0
Fixed #20455 -- Do not use ngettext for undefined plurals
...
Using two separate translation strings instead of gettext plural when
there is no reference to the number in the translated string. This
prevents some translations like Russian and Latvian to use the singular
form for 11 or 21.
2013-05-25 14:16:46 +02:00
1514f17aa6
Rotate CSRF token on login
2013-05-24 22:15:08 +01:00
48424adaba
Fixed #17648 -- Add `for_concrete_model` to `GenericForeignKey`.
...
Allows a `GenericForeignKey` to reference proxy models. The default
for `for_concrete_model` is `True` to keep backwards compatibility.
Also added the analog `for_concrete_model` kwarg to
`generic_inlineformset_factory` to provide an API at the form level.
2013-05-23 19:03:14 -04:00
d595b61aca
(Re-)moved some imports
2013-05-21 17:34:19 +02:00
cec9558fba
Fixed #17308 -- Enabled the use of short_description on properties in the admin.
2013-05-21 13:19:18 +02:00
f7d7d2be4b
Made 2d309a70 compatible with Python 3.
2013-05-19 17:58:29 +02:00
a4ab0e8b86
Merge pull request #1178 from bmispelon/master
...
Fix for test failure introduced by 980ae2a
2013-05-19 08:08:09 -07:00
3cb1e9b93c
Fix test failure introduced by 980ae2ab29.
2013-05-19 16:51:36 +02:00
2d309a7043
Fixed #15961 -- Modified ModelAdmin to allow for custom search methods.
...
This adds a get_search_results method that users can override to
provide custom search strategies.
Thanks to Daniele Procida for help with the docs.
2013-05-19 16:45:00 +02:00
f88700d610
Fix #19664 -- Illegal Characters In Session Key Give Fatal Error On File Backend Only
2013-05-19 15:33:05 +02:00
980ae2ab29
Fix #20447 : URL names given to contrib.auth.views are now resolved.
...
This commit also adds tests for the redirect feature of most auth views.
It also cleans up the tests, most notably using @override_settings instead
of ad-hoc setUp/tearDown methods.
Thanks to caumons for the report.
Conflicts:
docs/releases/1.6.txt
2013-05-19 14:36:38 +02:00
9b22baddef
Merge pull request #1130 from vdboor/issue_20442_get_for_id
...
Fixed #20442 : NoneType error when fetching a stale ContentType with get_for_id
2013-05-19 05:33:17 -07:00
660762681c
Fixed #20126 -- XViewMiddleware moved to django.contrib.admindocs.middleware
2013-05-19 13:18:35 +02:00
4ad1eb1c14
Fixed #12674 -- provide a way to override admin validation
...
Moved admin validation code to classes and have those be class
attributes to the ModelAdmin classes.
2013-05-19 12:42:52 +02:00
cafcc22b01
Typo in comment
2013-05-19 09:28:36 +02:00
69523c1ba3
Updated contrib.humanize translation template
2013-05-18 23:11:39 +02:00
7d77e9786a
Fixed #20246 -- Added non-breaking spaces between values an units
2013-05-18 23:01:48 +02:00
86e761fee8
Fix NoneType error when fetching a stale ContentType with get_for_id
...
When a stale ContentType is fetched, the _add_to_cache() function
didn't detect that `model_class()` returns `None` (which it does by
design). However, the `app_label` + `model` fields can be used instead
to as local cache key. Third party apps can detect stale models by
checking whether `model_class()` returns `None`.
Ticket: https://code.djangoproject.com/ticket/20442
2013-05-18 17:31:28 +02:00
64e11a68f1
Fixed #13285 : populate_xheaders breaks caching
2013-05-18 17:03:43 +02:00
710c59bf9b
Slightly reworked imports in contrib.auth.__init__
2013-05-18 16:01:47 +02:00
dc43fbc2f2
Fixed #18998 - Prevented session crash when auth backend removed
...
Removing a backend configured in AUTHENTICATION_BACKENDS should not
raise an exception for existing sessions, but should make already
logged-in users disconnect.
Thanks Bradley Ayers for the report.
2013-05-18 15:58:29 +02:00
340115200f
Fixed #20432 -- Test failure in admin_views.
...
The failure was triggered by a cache leak.
2013-05-18 13:13:33 +02:00
9c487b5974
Replaced an antiquated pattern.
...
Thanks Lennart Regebro for pointing it out.
2013-05-17 18:08:58 +02:00
b1bfd9630e
Remove unnecessary and problematic parent class from SuccessMessageMixin
...
refs #16319 , thanks to bmispelon for the catch
2013-05-17 08:59:06 -07:00
b16b72d415
Fixed #5472 --Added OpenLayers-based widgets in contrib.gis
...
Largely inspired from django-floppyforms. Designed to not depend
on OpenLayers at code level.
2013-05-17 13:33:40 +02:00
0732c8e8c6
Fixed #20357 -- Allow empty username field label in `AuthentificationForm`.
2013-05-16 11:41:52 -04:00
79715f267c
Fixed misleading heading on admindocs models page; refs #19712 .
2013-05-16 08:37:20 -04:00
0a29057ebe
Fixed #20415 -- Ensured srid is not localized in openlayers template
...
Thanks pierremarc07 at gmail.com for the report.
2013-05-16 13:48:38 +02:00
3188775174
Fix bug introduced in contrib.gis in 74f3884ae0
2013-05-15 14:07:34 -07:00
74f3884ae0
Fixed #20413 - Respect Query.get_meta()
2013-05-15 12:55:30 -07:00
ebfb71c64a
Fixed previous commit. (Don't commit from DjangCon!)
2013-05-15 16:50:33 +02:00
f6d1ca56c9
Don't unregister OSMGeoAdmin, other tests rely on it.
2013-05-15 16:47:03 +02:00
8f0a4665d6
Recommend using the bcrypt library instead of py-bcrypt
...
* py-bcrypt has not been updated in some time
* py-bcrypt does not support Python3
* py3k-bcrypt, a port of py-bcrypt to python3 is not compatible
with Django
* bcrypt is supported on all versions of Python that Django
supports
2013-05-13 23:49:00 -04:00
a6edde3260
Fixed embarrassing typo.
2013-05-11 22:57:01 +02:00
01820466ca
Don't hardcode primary keys in gis tests.
2013-05-11 22:42:39 +02:00
11c7ec7993
Merge pull request #1052 from dstufft/bcrypt-python3
...
BCrypt on Python3
2013-05-11 10:53:18 -07:00
2bf403ecbd
Fixed a regression from e23a5f9a47.
...
Excluded postgis specific gis tests from other spatial databases.
Refs #17365 , #17366 , #18727 .
2013-05-11 18:29:08 +02:00
3070e8f711
Properly force bytes or str for bcrypt on Python3
2013-05-11 11:16:06 -04:00
9012833af8
Fixed #17365 , #17366 , #18727 -- Switched to discovery test runner.
...
Thanks to Preston Timmons for the bulk of the work on the patch, especially
updating Django's own test suite to comply with the requirements of the new
runner. Thanks also to Jannis Leidel and Mahdi Yusuf for earlier work on the
patch and the discovery runner.
Refs #11077 , #17032 , and #18670 .
2013-05-10 23:08:45 -04:00
7b00d90208
[py3] Made GeoIP tests pass with Python 3
2013-05-10 13:21:07 +02:00
465a29abe0
Fixed #20384 -- Forced GeoIP_open path argument to bytestring
...
Thanks Julian Wachholz for the report.
2013-05-10 13:21:07 +02:00
f026a519ae
Fixed #19733 - deprecated ModelForms without 'fields' or 'exclude', and added '__all__' shortcut
...
This also updates all dependent functionality, including modelform_factory
and modelformset_factory, and the generic views `ModelFormMixin`,
`CreateView` and `UpdateView` which gain a new `fields` attribute.
2013-05-09 16:44:36 +01:00
1e37cb37ce
Further removal of static admin validation that can fail erroneously
2013-05-09 16:44:36 +01:00
1906cb9360
Fixed conditional skipping of test for left/right lookup types.
...
connection.ops.spatial_version is None for some backends (eg. MySQL) and
the comparison fails on Python 3 with TypeError.
2013-05-09 17:39:56 +02:00
a53d7a0a50
Made gis_terms be a set, rather than a dict with None for all keys.
2013-05-09 08:13:13 -07:00
f25fc5b220
Merge pull request #1049 from mfogel/remove-unescessary-parameter-checks
...
Remove unnecessary check on __set__ parameters.
2013-05-08 21:20:58 -07:00
1556b1c3b7
Removed fragile admin validation of fields on ModelForm
...
Refs #19445
2013-05-09 00:49:05 +01:00
a22e15effc
Remove unnecessary check on __set__ parameters.
2013-05-07 21:50:59 -07:00
f3b3c569e7
One more changed import location of wraps
2013-05-04 13:29:40 +02:00
66c83dce07
Fixed #18351 -- Added X-Robots-Tag header to sitemaps
...
Thanks Michael Lissner for the report and initial patch, and
Tom Mortimer-Jones for working on the patch.
2013-05-04 12:08:15 +02:00
9f7a01ef2b
Updated translation templates and removed en translations
...
"en" translations have been mistakenly committed in 87cc3da81
2013-05-02 16:25:23 +02:00
90fe9141de
Fixed #18986 -- Improved error message for missing files
...
in CachedStaticFilesStorage. Thanks zyegfryed for his work on the patch.
2013-04-28 16:45:05 +02:00
53df89c0fe
Updated get_ogr_db_string in inspectapp tests to support MySQL/Spatialite
...
The OGRInspectTest.test_time_field does still not succeed with these
databases (even when removing the postgis guard), but at least it's now
possible to setup a datasource.
2013-04-15 20:27:58 +02:00
1628dfd0b9
Properly used test skipping in OGRInspectTest TestCase
2013-04-15 19:38:24 +02:00
a506b6981b
Fixed #18231 -- Made JavaScript i18n not pollute global JS namespace.
...
Also, use Django templating for the dynamic generated JS code and use
more idiomatic coding techniques.
Thanks Matthew Tretter for the report and the patch.
2013-04-14 17:45:01 -03:00
ddfc68379f
Changed a deprecated warn() call in libgeos
2013-04-11 11:01:17 +02:00
ed576b69f9
Merge pull request #938 from darklow/ticket_20111
...
Added more precise message level for succcess and warning messages
2013-04-08 04:56:57 -07:00
3be368c73e
Fix #20111 Added more precise message level for succcess and warning messages
2013-04-08 14:54:03 +03:00
5ab66dea50
Explicitly removes dismissCalendar
...
Uses the removeEvent function in core.js to remove the dismissCalendar
function from the document click event.
Fixes #4045 .
2013-04-06 13:50:09 +02:00
4509a1be1f
Explicitly removes dismissClock
...
Uses the removeEvent function in core.js to remove the function from
the document click event.
Refs #4045 .
2013-04-06 13:50:09 +02:00
a49e7dd2a3
Fixed #20114 -- support custom project login_url in tests
...
Thanks to Matias Bordese for the patch
2013-04-05 09:03:28 -07:00
7ccbe6a4fa
Fix contrib.messages tests for discovery.
2013-04-03 15:30:34 -06:00
fde2e4fd6e
Modified auth to work with unittest2 discovery.
2013-04-02 21:59:45 -06:00
e3cfbaaca4
Modified sitemaps to work with unittest2 discovery.
2013-04-02 20:12:35 -06:00
629d704d5f
Modified messages to work with unittest2 discovery.
2013-04-02 20:12:30 -06:00
756a70b48d
Modified formtools to work with unittest2 discovery.
2013-04-02 20:12:26 -06:00
8aedde0385
Updated flatpages tests for unittest2 discovery.
2013-04-02 20:12:24 -06:00
7fd1571b2e
Modified admindocs tests to work with unittest2 discovery.
2013-04-02 20:12:15 -06:00
80b658f5aa
Remove unnecessary if conditions
...
if obj it None, it's None, there's no need to check it
2013-03-30 12:22:28 +01:00
86aaff75d0
Fixed #20059 -- Updated humanize tests to force 'en' language setting.
2013-03-30 12:19:39 +01:00
ec04fd1344
Fixed spelling errors
2013-03-28 11:16:53 -06:00
26ad3abadf
Fixed spelling of "consistent" in admin/options.py
2013-03-28 09:10:13 -06:00
244e765a94
Updated translation templates
2013-03-28 10:06:11 +01:00
0a22f7aad2
Added Burmese language
...
Thanks to Yhal Htet Aung for the translation work.
2013-03-28 10:01:30 +01:00
ab76467d54
Added Ossetic language
...
Thanks to Xwybylty Soslan for the translation work.
2013-03-28 09:54:16 +01:00
c5084e7557
Updated translations from Transifex
...
Polish, Telugu, Georgian, Azerbaijani, Norwegian Bokmål, Basque,
Dutch, Thai, Spanish (Argentina), Afrikaans.
2013-03-28 09:24:07 +01:00
9e462f8101
Fixed #20078 : don't allow filtering on password in the user admin.
2013-03-27 11:24:36 -05:00
25f2acfed0
Fixed #20138 -- Added BCryptSHA256PasswordHasher
...
BCryptSHA256PasswordHasher pre-hashes the users password using
SHA256 to prevent the 72 byte truncation inherient in the BCrypt
algorithm.
2013-03-26 13:26:57 -04:00
a4b8a4b632
Fixed #20121 -- Removed LogEntry.get_admin_url's hard-coded path.
...
Updated LogEntry.get_admin_url to use 'reverse' instead
of a hard-coded path.
2013-03-25 23:45:27 -04:00
d9b12ecbe6
Moved removeChildren to core.js
...
The function removeChildren is a general utility that other functions
might want to use.
Fixes #4120 . Thanks arvin for the initial patch.
2013-03-25 09:38:34 +01:00
0a9ea56056
Moved cancelEventPropagation into core.js
...
The cancelEventPropagation function is a general utility function that
can be reused by other widgets. Refs #4120 .
2013-03-25 09:32:12 +01:00
d5824ef69d
Removed quickElement from calendar.js
...
The function quickElement in calendar.js is a duplicate of the
quickElement function in core.js. Refs #4120 .
2013-03-25 09:32:02 +01:00
151938ddb5
Merge pull request #946 from matiasb/minor-flatpage-translation-fix
...
Fixed #20117 -- Added missing translation override to fix flatpages test.
2013-03-24 21:08:16 -07:00
97774429ae
Fixed #19385 again, now with real code changes
...
The commit of 266de5f9ae
2013-03-24 18:40:40 +02:00
e16c48e001
Fixed #15124 -- Changed the default for BooleanField.
...
Thanks to the many contributors who updated and improved the patch over
the life of this ticket.
2013-03-24 13:47:01 +01:00
6985f0c09b
Fixed #20117 -- Added missing translation override to fix flatpages test.
2013-03-23 12:22:44 -03:00
e7514e4978
Merge pull request #942 from stephrdev/trac-18000
...
Fixed #18000 -- Moved the code to handle goto requests to an extra WizardView method.
2013-03-23 05:29:28 -07:00
b614c47f8c
Added some class attributes to pass initial form lists to the WizardView without the need to add them in the as_view call.
2013-03-23 12:24:34 +01:00
46246c6624
Moved the code to handle goto requests in a extra WizardView method.
2013-03-23 12:02:23 +01:00
930af661ab
Fixed #20048 , #20060 -- Modified tests for contrib apps sensitive to custom User models.
...
Thanks to matiasb for the report of #20060 and the draft patch for #20048 .
2013-03-23 09:57:48 +08:00
f7d945e325
Fixed #16350 -- Forced capitalization in template.
...
This improves rendering in some foreign languages.
2013-03-22 22:41:13 +01:00
f9ab543720
Fixed #20084 -- Provided option to validate formset max_num on server.
...
This is provided as a new "validate_max" formset_factory option defaulting to
False, since the non-validating behavior of max_num is longstanding, and there
is certainly code relying on it. (In fact, even the Django admin relies on it
for the case where there are more existing inlines than the given max_num). It
may be that at some point we want to deprecate validate_max=False and
eventually remove the option, but this commit takes no steps in that direction.
This also fixes the DoS-prevention absolute_max enforcement so that it causes a
form validation error rather than an IndexError, and ensures that absolute_max
is always 1000 more than max_num, to prevent surprising changes in behavior
with max_num close to absolute_max.
Lastly, this commit fixes the previous inconsistency between a regular formset
and a model formset in the precedence of max_num and initial data. Previously
in a regular formset, if the provided initial data was longer than max_num, it
was truncated; in a model formset, all initial forms would be displayed
regardless of max_num. Now regular formsets are the same as model formsets; all
initial forms are displayed, even if more than max_num. (But if validate_max is
True, submitting these forms will result in a "too many forms" validation
error!) This combination of behaviors was chosen to keep the max_num validation
simple and consistent, and avoid silent data loss due to truncation of initial
data.
Thanks to Preston for discussion of the design choices.
2013-03-21 01:27:24 -07:00
a45d06ca3d
Fixed #19972 -- Fixed overflow issue in admin changelist pages.
...
Thanks to loic84 for the report and patch.
2013-03-20 17:00:25 +01:00
9a85ad89c2
Fixed #16319 -- added SuccessMessageMixin to contrib.messages
...
Thanks martinogden for the initial patch and d1ffuz0r for tests.
2013-03-19 21:02:55 -07:00
7a3409fc64
Merge pull request #931 from catalanojuan/fix-admin-log-dependency-on-user-id-field-20088
...
Fixed #20088 -- Changed get_admin_log not to depend on User id field
2013-03-19 15:56:01 -07:00
bc4111ba68
Fixed #18003 -- Preserved tracebacks when re-raising errors.
...
Thanks jrothenbuhler for draft patch, Konark Modi for updates.
2013-03-19 15:42:39 -07:00
054ce2aa02
Fixed #20088 -- Changed get_admin_log not to depend on User id field
...
Before this change, the get_admin_log method would expect User model's
FK to be named `id`. When changing that FK name, admin/index.html
rendering would fail.
This includes:
* Changed the use of id for the use of pk property.
* Added a regression test that fails without the patch.
This commit refs #20088 .
2013-03-19 19:30:43 -03:00
9d6ecc6bc6
Fixed #19327 -- Added handling of double login attempts in admin.
...
Thanks to Krzysztof Jurewicz for initial patch and
adupin for tests.
2013-03-18 17:11:07 -07:00
0df8ff3dbe
Fixed #19550 -- Made the filtered select widget wider in the admin.
...
Thanks Claude and Julien for the review.
2013-03-17 22:48:52 +01:00
9d4a5b00f1
Stopped using non-standard __globals__ and __code__ attributes.
...
Some alternative implementations don't have them.
Closes #19944 .
2013-03-17 10:44:28 +01:00
babd1090ee
Fix 20061: remove out of date comment.
2013-03-16 18:55:24 +01:00
0122a98dad
Fixed #20055 -- Add url, email, and number input types to admin CSS.
2013-03-15 18:54:19 -04:00
18e990fa96
Fixed #16110 -- Fixed GeometryField odd behaviour regarding null values
...
Thanks slinkp for the report and the initial patch.
2013-03-15 21:45:33 +01:00
2f121dfe63
Fixed #17051 -- Removed some 'invalid' field error messages
...
When the 'invalid' error message is set at field level, it masks
the error message raised by the validator, if any.
2013-03-14 17:03:43 +01:00
747f7d2549
Fixed #20036 -- Improved GEOS version string parsing
...
Thanks chikiro.spam at gmail.com for the report.
2013-03-13 09:52:33 +01:00
d3f00bd570
Refactored qs.add_q() and utils/tree.py
...
The sql/query.py add_q method did a lot of where/having tree hacking to
get complex queries to work correctly. The logic was refactored so that
it should be simpler to understand. The new logic should also produce
leaner WHERE conditions.
The changes cascade somewhat, as some other parts of Django (like
add_filter() and WhereNode) expect boolean trees in certain format or
they fail to work. So to fix the add_q() one must fix utils/tree.py,
some things in add_filter(), WhereNode and so on.
This commit also fixed add_filter to see negate clauses up the path.
A query like .exclude(Q(reversefk__in=a_list)) didn't work similarly to
.filter(~Q(reversefk__in=a_list)). The reason for this is that only
the immediate parent negate clauses were seen by add_filter, and thus a
tree like AND: (NOT AND: (AND: condition)) will not be handled
correctly, as there is one intermediary AND node in the tree. The
example tree is generated by .exclude(~Q(reversefk__in=a_list)).
Still, aggregation lost connectors in OR cases, and F() objects and
aggregates in same filter clause caused GROUP BY problems on some
databases.
Fixed #17600 , fixed #13198 , fixed #17025 , fixed #17000 , fixed #11293 .
2013-03-13 10:44:49 +02:00
4846e2b744
Removed unused imports.
...
One of these functions didn't exist anymore.
2013-03-12 10:09:04 +01:00
571b2d139b
Deprecated django.contrib.comments.
2013-03-11 15:38:40 -05:00
f2f98abb95
Avoided closing the database connection within a transaction.
...
Refs #9437 .
2013-03-11 21:08:49 +01:00
1adb7b3c38
Ported layermapping for autocommit.
2013-03-11 20:03:17 +01:00
3710a918b2
Switched the admin to use @transaction.atomic.
2013-03-11 19:58:08 +01:00
ba5138b1c0
Deprecated transaction.commit/rollback_unless_managed.
...
Since "unless managed" now means "if database-level autocommit",
committing or rolling back doesn't have any effect.
Restored transactional integrity in a few places that relied on
automatically-started transactions with a transitory API.
2013-03-11 14:48:54 +01:00
360217fc87
Fixed #19171 -- Allowed coordinate transforms with custom SRIDs
...
Thanks reidpr at lanl.gov for the report.
2013-03-09 17:46:20 +01:00
e6f5b7eacd
Fixed #9806 -- Allowed editing GeometryField with OpenLayersWidget
...
Thanks Paul Winkler for the initial patch.
2013-03-09 16:10:28 +01:00
f3d1aebed1
Reformatted slightly openlayers.js
2013-03-09 15:08:16 +01:00
5e80571bf9
Fixed #16594 -- Added wkt 3D support for GEOS geometries
...
This requires GEOS >= 3.3.0 to function properly. On previous
versions, the Z dimension will simply not appear in the wkt.
Disabled OpenLayers editing for 3D geometries (unsupported).
2013-03-09 12:02:22 +01:00
8a92139d8a
Replaced proj4 testing by a regex
2013-03-08 22:52:41 +01:00
6983a1a540
Fixed #15363 -- Renamed and normalized to `get_queryset` the methods that return a QuerySet.
2013-03-08 10:11:45 -05:00
81804ae474
Fix 19916. Smarter tokenizing of contrib.comment's templatetags arguments.
2013-03-07 19:30:38 +01:00
e2ee02c5bd
Fixed #19951 -- Admin: Invalid model PK values shouldn't cause 500 status.
...
Avoid ValueError in admin when passing a string as PK for an inherited
model with an integer PK field.
Thanks ikks for the patch. See also #11191 .
2013-03-06 21:38:44 -03:00
d9330d5be2
Fixed #6585 -- Admin relationship widgets: Respect ordering defined by target model's ModelAdmin.
...
Thanks Gary Wilson for the report and Juan Pedro Fisanotti, Carlos
Matías de la Torre for the fix.
2013-03-04 18:08:53 -03:00
3ea0c7d35a
Fixed #19838 -- Admin: Don't leak a 500 HTTP status when trying to delete protected FKs.
...
Thanks rafadev for the report and Javier Mansilla for the fix.
2013-03-04 13:30:59 -03:00
03e40140ff
Merge pull request #871 from matiasb/ticket_19945
...
Fixed #19945 -- Fixed default User model Meta inheritance.
2013-03-03 14:30:36 -08:00
3bbcec0aba
Removed mentions of regressiontests.
2013-03-03 17:03:11 -03:00
0868e5a8ac
Fixed #19177 -- Better layout for admin login form field labels.
...
Thanks goes to void for the comprehensive report, to Pedro Mourelle for
the fix and to Bryan Veloso, Łukasz Rekucki and Claude Paroz for the
review.
This fix includes the following changes:
* Modified layout to top-aligned labels.
* Added 'air' for inputs (the padding was really needed there.). It
adjust good to zoom in/out.
* Removed float attributes from label and inputs in login form.
* Removed useless text-align property.
2013-03-02 20:27:59 -03:00
8e8c9b908a
Fixed getting default encoding in get_system_username
...
Refs #19933 .
2013-03-02 22:41:08 +01:00
f39fead1c3
Fixed #19945 -- Fixed default User model Meta inheritance.
...
Updated default User model Meta class to extend AbstractUser Meta
where translated verbose_name and verbose_name_plural are
defined.
2013-03-01 19:32:20 -03:00
2ee21d9f0d
Implemented persistent database connections.
...
Thanks Anssi Kääriäinen and Karen Tracey for their inputs.
2013-02-28 15:28:13 +01:00
87cc3da814
Merged contrib translations from 1.5 branch
2013-02-26 21:51:06 +01:00
f1255a3c09
Fixed #18144 -- Restored compatibility with SHA1 hashes with empty salt.
...
Thanks dahool for the report and initial version of the patch.
2013-02-25 20:21:58 +01:00
906dc8522a
Fixed #19854 -- Turn Django's own Selenium tests off by default.
2013-02-25 10:14:42 -07:00
b88bf9f125
Fixed python 3 support. Refs #17320
2013-02-24 18:35:08 +01:00
e3e0f49ece
Merge pull request #834 from vdboor/issue_19906_list_classes
...
Added column-<field_name> classes to the admin list
2013-02-24 08:58:57 -08:00
b7ba4fc408
Add column-<field_name> classes to the admin list
...
This simplifies CSS styling to set column widths.
2013-02-24 17:50:23 +01:00
5e52dc2ade
Merge pull request #828 from zerok/tickets/17320
...
Fixed #17320 -- Added whitespace validation to Site.domain field
2013-02-24 08:39:27 -08:00
c729461479
Fixed #17320 -- Added whitespace validation to the Site.domain field
2013-02-24 16:40:51 +01:00
0a8402eb05
Test case and docs for custom context data in feeds
...
Thanks Paul Winkler for the initial patch. (Ref #18112 ).
2013-02-24 08:33:20 -06:00
bc787f6a32
Loaded cycle and firstof from future in built-in templates. Refs #17906 .
...
This was missing from f49e9a517f
2013-02-24 15:16:45 +01:00
b9cc61021a
Fixed #9084 - Best approach for an OS to atomically rename the session file.
2013-02-24 14:21:40 +01:00
7106a1e594
Merge pull request #819 from erikr/master
...
Fixed #16302 -- Ensured contrib.comments is IPv6 capable.
2013-02-24 05:02:00 -08:00
ade992c61e
Fixed #16302 -- Ensure contrib.comments is IPv6 capable
...
Changed the ip_address field for Comment to GenericIPAddressField. Added
instructions to the release notes on how to update the schema of existing
databases.
2013-02-24 13:58:38 +01:00
d7e835f76d
Merge pull request #820 from viciu/11295
...
Fixed #11295 : If ModelAdmin.queryset returns a filtered QS don't require a 2nd count call
2013-02-24 04:35:27 -08:00
a44531ae15
Fixed #18862 -- Honored script prefix in FlatPage.get_absolute_url.
2013-02-24 13:27:13 +01:00
4b01ee7a50
URL-encoded URLs in FlatPage.get_absolute_url.
2013-02-24 13:27:13 +01:00
f07a5f0a21
Fixed #11295 : If ModelAdmin.queryset returns a filtered QS don't require a 2nd count call
...
Original patch rewritten, added tests and get_filters_params method for ChangeList class.
Thanks Alex for the report.
2013-02-24 13:23:23 +01:00
f56ca3f0e6
Fixed the usage of the deprecated assertEquals.
2013-02-24 11:15:17 +01:00
22d82a7742
Fixed #15198 -- pass request to AuthenticationForm
...
Thanks to Ciantic for the report, claudep and slurms for initial work
2013-02-23 15:28:49 -08:00
9d2c0a0ae6
Removed superfluous cookie check from auth login.
...
This is ensured through the CSRF protection of the view
2013-02-23 15:28:49 -08:00
692902b227
Merge pull request #778 from viciu/19609
...
Fixed #19609 : admin Inlines doesn't display help_text for readonly fields
2013-02-23 14:34:57 -08:00
2b48fcc607
Fixed #18491 -- deleting a proxy doesn't show warning about cascade deletes
2013-02-23 23:20:34 +01:00
32a7ab2148
Fixed #19526
...
CSS specifications governs that syntax is case insensitive.
This modifies CachedFilesMixin to support that.
2013-02-23 23:05:22 +01:00
7e6ad76b24
Fixed #19282 -- Restored ability to pass Decimals to intcomma filter
2013-02-23 21:48:22 +01:00
98ab8e8876
Fixed #19698 -- Cleared sites cache with signals
...
Thanks ddavies at nomensa.com for the report and the patch and
serdaroncode for reviewing the patch.
2013-02-23 19:31:17 +01:00
67dd54dc84
Fixed #19609 : admin Inlines doesn't display help_text for readonly fields
...
Refactoring: field was renamed to field_name, since flatten_fieldsets returns field name, not field.
Original patch from Marc Aymerich Gubern
2013-02-23 18:24:32 +01:00
1cd2f51eb4
Added test runner option to skip Selenium tests ( #19854 ).
2013-02-23 17:45:26 +01:00
8c1cc4b3b0
Fixed regression introduced in 146ed13a.
...
As override_settings was used after the initialization of the session backend,
we need to use a new session backend here.
2013-02-23 16:53:31 +01:00
6bbf4e57c8
Fixed embarrassing typo in last commit.
2013-02-23 14:59:51 +01:00
2db9cbe97c
Removes document_root argument from django.contrib.staticfiles.views.serve
...
This argument can be removed, because the new way of finding static files doesn't take document_root into account at all.
2013-02-23 14:38:13 +01:00
c12891e8cd
Fixed #19850 -- Use configured staticfiles storage to find the URL of a static file in the admin.
2013-02-23 14:36:51 +01:00
2f4a4703e1
Fixed #19758 -- Avoided leaking email existence through the password reset form.
2013-02-23 14:31:21 +01:00
50677b29af
Made a couple of selenium tests wait for page loaded
...
The admin_widgets tests were issuing click() to the browser but
didn't wait for the effects of those clicks. This caused the resulting
request to be processed concurrently with the test case. When using
in-memory SQLite this caused weird failures.
Also added wait_page_loaded() to admin selenium tests for code
reuse.
Fixed #19856
2013-02-20 23:56:57 +02:00
cb5545ea2d
Fixed #19598 -- Fixed jQuery tagName retrieving
...
Thanks rj at rudiculous.net for the report.
2013-02-20 14:16:00 +01:00
4246fe6006
Replaced the obsolete toggle event handling JS function
...
The toggle(func1, func2) event handling function has been removed
in jQuery 1.9.
2013-02-20 13:54:59 +01:00
8bbca211b6
Fixed #14571 -- Updated embedded jQuery from 1.4.2 to 1.9.1
...
Thanks dArignac for the initial patch.
2013-02-20 13:52:15 +01:00
1f39eafd60
Checked object permissions on admin history view.
...
This is a security fix. Disclosure and advisory coming shortly.
Patch by Russell Keith-Magee.
2013-02-19 11:23:30 -07:00
d51fb74360
Added a new required ALLOWED_HOSTS setting for HTTP host header validation.
...
This is a security fix; disclosure and advisory coming shortly.
2013-02-19 11:23:29 -07:00
5ec0405a09
Fixed #19839 -- Isolated auth tests from customized TEMPLATE_LOADERS
...
Thanks limscoder for the report.
2013-02-18 09:22:25 +01:00
e74e207cce
Fixed #17260 -- Added time zone aware aggregation and lookups.
...
Thanks Carl Meyer for the review.
Squashed commit of the following:
commit 4f290bdb6001b6366f3c924a144ef8b4351d289091ef84713c0d0de288a59c0859ff7c68ab511a4f22d52681d3f6800fd04c0c829c23f4104d82a777c01bbb323550fb7a5246a8451a500429413eab2b
2013-02-16 09:19:04 +01:00
87854b0bdf
Fixed geos test to prevent random failure
...
Points in the test fixtures have 20 as max coordinate.
2013-02-15 20:13:36 +01:00
35185495e3
Fixed #17066 -- Prevented TypeError in GeoIP.__del__
...
When garbaging GeoIP instances, it happens that GeoIP_delete is
already None.
Thanks mitar for the report and stefanw for tests.
2013-02-15 17:12:14 +01:00
a8d1421dd9
Avoided unneeded assertion on Python 3
...
Fixes failure introduced in 02e5909f7a
2013-02-15 16:09:31 +01:00
02e5909f7a
Fixed #19807 -- Sanitized getpass input in createsuperuser
...
Python 2 getpass on Windows doesn't accept unicode, even when
containing only ascii chars.
Thanks Semmel for the report and tests.
2013-02-15 15:44:27 +01:00
f5e4a699ca
Fixed #19822 -- Added validation for uniqueness on USERNAME_FIELD on custom User models.
...
Thanks to Claude Peroz for the draft patch.
2013-02-15 09:00:55 +08:00
f1029b308f
Fixed a misnamed variable introduced in commit 142ec8b283
...
Refs #8404 .
2013-02-14 08:33:10 +01:00
142ec8b283
Fixed #8404 -- Isolated auth password-related tests from custom templates
2013-02-13 23:11:49 +01:00
e94f405d94
Fixed #18558 -- Added url property to HttpResponseRedirect*
...
Thanks coolRR for the report.
2013-02-13 10:29:32 +01:00
3a002db6f1
Fix admindocs on Python 3, where None cannot be sorted with strings.
...
This fixes two tests in admin_views which were failing on Python 3, but only if
the tests were run with docutils installed.
2013-02-12 17:10:36 -07:00
0e18fb04ba
Made modwsgi groups_for_user consistent with check_password
...
2b5f848207#19061
that made the is_active attribute mandatory for user models.
The try/except was not removed for the groups_for_user function.
refs #19780
2013-02-09 09:31:04 -08:00
2ed90eac49
Fixed #19779 -- Checked contrib.sites presence in RedirectFallbackMiddleware
...
Thanks Aymeric Augustin for the report and directions for the patch.
2013-02-08 16:32:09 +01:00
c44d748272
Fixed #19662 -- alter auth modelbackend to accept custom username fields
...
Thanks to Aymeric and Carl for the review.
2013-02-07 16:07:56 -08:00
64623a2e11
Fixed #19772 -- Handled APPEND_SLASH correctly in the redirects app.
2013-02-07 22:36:12 +01:00
04d9730b12
Fixed #13085 -- Don't fail on creation of model with GFK to a model with __len__() returning zero.
...
Also, according to the comments on the ticket and its duplicates, added
tests execising saving an instance of a model with a GFK to:
* An unsaved object -- This actually doesn't generate the same failure
but another ORM-level exception. The test verifies it's the case.
* An instance of a model with a __nonzero__() method thant returns False
for it. This doesn't fail because that code path isn't executed.
* An instance of a model with a CharField PK and an empty value for it.
This doesn't fail.
2013-02-07 16:05:54 -03:00
2b916895a1
Updated createsuperuser to use unicode_literals. Refs #19757 .
2013-02-07 14:33:36 +01:00
d18f796a48
Fixed #19704 -- Make use of new ungettext_lazy function at appropriate places
2013-02-06 22:01:55 +01:00
5449240c54
Fixed #9800 -- Allow "isPermaLink" attribute in <guid> element of an RSS item.
...
Thanks @rtnpro for the patch!
2013-02-06 05:28:05 -05:00
2390fe3f4f
Fixed #19745 -- Forced resolution of verbose names in createsupersuser
...
Thanks Baptiste Mispelon for the report and Preston Holmes for the review.
2013-02-06 10:06:21 +01:00
ec469ade2b
Fixed #19689 -- Renamed `Model._meta.module_name` to `model_name`.
2013-02-05 04:16:07 -05:00
7c5b244826
Fixed #17061 -- Factored out importing object from a dotted path
...
Thanks Carl Meyer for the report.
2013-02-04 16:38:25 +01:00
55c585f1c7
Fixed #19725 -- Made createsuperuser handle non-ascii prompts
...
Thanks Michisu for the report.
2013-02-04 10:09:10 +01:00
c9c40bc6bc
Fixed #19333 -- Moved compress.py outside of the admin static folder. Thanks to camilonova, Russell Keith-Magee, Aymeric Augustin and Ramiro Morales for the feedback.
2013-02-02 15:01:32 -08:00
0694d2196f
Fixed #19445 -- Skip admin fieldsets validation when the ModelAdmin.get_form() method is overridden.
2013-02-02 14:53:46 -08:00
a1c470a6f6
Lowered field ordering requirement in ogrinspect test
...
This test was randomly failing depending on the library environment.
2013-02-02 14:01:24 +01:00
1f8e7bb075
Added missing parentheses in if clause
2013-02-02 12:13:47 +01:00
63d6a50dd8
Fixed #18144 -- Added backwards compatibility with old unsalted MD5 passwords
...
Thanks apreobrazhensky at gmail.com for the report.
2013-02-02 12:02:36 +01:00
e0bd93ddd7
Merge pull request #334 from dlo/tickets/18755
...
Fixed #18755 -- Wrapped long admin forms fields labels.
2013-02-01 12:34:35 -08:00
393c268e72
Fixed #19715 -- Simplified findstatic output when verbosity set to 0
2013-02-01 11:55:05 +01:00
8eb84081ad
Set bigger maxDiff for ogrinspect tests
2013-02-01 09:34:39 +01:00
89cb771be7
Fixed #19692 -- Completed deprecation of mimetype in favor of content_type.
...
Thanks Tim for the report and initial patch.
2013-01-31 13:54:40 +01:00
eb9430fc4b
Implemented some SpatiaLiteOperations as cached properties
...
Previously, some properties weren't set unless
confirm_spatial_components_versions() was explicitely called.
2013-01-29 19:39:11 +01:00
ee26797cff
Fixed typos in docs and comments
2013-01-29 10:55:55 -07:00
cebbec9b61
Fixed #19540 -- Stopped using deprecated os.stat_float_times.
2013-01-26 13:34:40 +01:00
1686e0d184
Fixed #18460 -- Fixed change detection of ReadOnlyPasswordHashField
...
Thanks jose.sanchez et ezeep.com for the report and Vladimir Ulupov
for the initial patch.
2013-01-25 21:27:49 +01:00
ebb504db69
Moved has_changed logic from widget to form field
...
Refs #16612 . Thanks Aymeric Augustin for the suggestion.
2013-01-25 20:50:46 +01:00
214fb700b9
Fixed #19477 - Documented generic_inlineformset_factory
...
Thanks epicserve for the suggestion.
2013-01-22 18:17:26 -05:00
cc4de61a2b
Fixed #19596 -- Use `_default_manager` instead of `objects` in the auth app.
...
This is needed to support custom user models which don't define a manager
named `objects`.
2013-01-22 12:47:34 +01:00
013db6ba85
Fixed #18051 -- Allowed admin fieldsets to contain lists
...
Thanks Ricardo di Virgilio for the report, Mateus Gondim for the
patch and Nick Sandford for the review.
2013-01-21 22:34:36 +01:00
97121cb96e
Fixed #18026 -- Don't return an anonymous dict if extra_data in storage is empty.
2013-01-12 15:50:18 +01:00
cdad0b28d4
Fixed #19573 -- Allow override of username field label in AuthenticationForm
2013-01-10 09:06:04 +01:00
34ee7d9875
Updated deprecated test assertions
2013-01-08 19:08:15 +01:00
a2396a4c8f
Fixed #19173 -- Made EmptyQuerySet a marker class only
...
The guarantee that no queries will be made when accessing results is
done by new EmptyWhere class which is used for query.where and having.
Thanks to Simon Charette for reviewing and valuable suggestions.
2013-01-06 19:18:28 +02:00
84ea85fb90
Updated comment about PostGIS bug 2035
...
PostGIS 2.0.2 has been released on December 3rd 2012, with the
fix included.
2013-01-03 17:37:44 +01:00
cf7afeb2d1
Fixed a NameError in geoip/libgeoip if the GeoIP library is not found.
...
Thx to Bouke Haarsma for the report.
2013-01-01 12:24:02 +01:00
cee40c7d79
Added further flexibility to ModelAdmin for controlling post-save redirections.
...
Refs #19505 .
2012-12-30 21:33:21 -08:00
f80a1934cd
Fixed GIS regression in get_default_columns()
...
I changed the normal compiler's get_default_columns() but didn't change
the copy-pasted code in GIS compiler's get_default_columns().
Refs #19385
2012-12-30 12:10:15 +02:00
4511aeb6b8
Moved join path generation to Field
...
Refs #19385
2012-12-30 11:19:19 +02:00
0b09b1a7ca
Merge pull request #609 from mitar/patch-3
...
Fixed typo in collectstatic output.
2012-12-29 13:35:52 -08:00
4e5369a596
Silenced warnings in the tests of deprecated features.
2012-12-29 22:32:07 +01:00
ef017a5f00
Advanced pending deprecation warnings.
...
Also added stacklevel argument, fixed #18127 .
2012-12-29 21:59:07 +01:00
ebd2598596
Removed django.contrib.markup.
2012-12-29 21:59:07 +01:00
f27a4ee327
Removed django.contrib.localflavor.
...
Each localflavor lives on as a separate app.
2012-12-29 21:59:06 +01:00
b2d20e9826
Removed legacy shortcut for importing GeoIP.
2012-12-29 21:58:12 +01:00
d4ea02b992
Removed the legacy form wizard.
2012-12-29 21:58:12 +01:00
052271168b
Removed django.contrib.databrowse.
...
RIP -- you served us well.
2012-12-29 21:58:12 +01:00
02f3daadd6
Removed interpolation of post_url_continue in the admin.
2012-12-29 21:58:12 +01:00
cb98806101
Update django/contrib/staticfiles/management/commands/collectstatic.py
...
Fixed small output error.
2012-12-27 20:37:12 +01:00
0907d3c6f5
Fixed #16408 -- Re-fixed value conversion with Spatialite backend
2012-12-26 12:45:41 +01:00
35d1cd0b28
Fixed #19505 -- A more flexible implementation for customizable admin redirect urls.
...
Work by Julien Phalip.
Refs #8001 , #18310 , #19505 . See also 0b908b92a2
2012-12-24 15:44:19 -03:00
c31c2c92b8
Made admin generated changelist URLs independent of dict ordering
2012-12-24 01:33:24 +00:00
8d35fd4c32
Use new TestCase methods for equality comparisons
2012-12-24 00:24:14 +00:00
0dc3fc954f
Fixed #19509 -- Fixed crypt/bcrypt non-ascii password encoding
...
Also systematically added non-ascii passwords in hashers test suite.
Thanks Vaal for the report.
2012-12-22 16:04:10 +01:00
1e4a27d087
Fixed #19468 -- Decoded request.path correctly on Python 3.
...
Thanks aliva for the report and claudep for the feedback.
2012-12-22 13:32:39 +01:00
e277301c2c
Fixed #19387 -- Preserved SafeData status in contrib.messages
...
Thanks Anton Baklanov for the report and the patch.
2012-12-21 10:09:32 +01:00
ed711c4bd5
Fixed #19483 -- Improved import error message in contrib.comments
...
Thanks Valentin Lorentz for the report and the suggested fix.
2012-12-16 21:12:45 +01:00
69597e5bcc
Fixed #10790 -- Refactored sql.Query.setup_joins()
...
This is a rather large refactoring. The "lookup traversal" code was
splitted out from the setup_joins. There is now names_to_path() method
which does the lookup traveling, the actual work of setup_joins() is
calling names_to_path() and then adding the joins found into the query.
As a side effect it was possible to remove the "process_extra"
functionality used by genric relations. This never worked for left
joins. Now the extra restriction is appended directly to the join
condition instead of the where clause.
To generate the extra condition we need to have the join field
available in the compiler. This has the side-effect that we need more
ugly code in Query.__getstate__ and __setstate__ as Field objects
aren't pickleable.
The join trimming code got a big change - now we trim all direct joins
and never trim reverse joins. This also fixes the problem in #10790
which was join trimming in null filter cases.
2012-12-16 17:23:26 +02:00
d7b49f5b0d
Fixed #19469 -- Removed opts.get_ordered_objects() and related code
...
The code was dead-code since 2006.
2012-12-16 16:22:09 +02:00
9facca28b6
Corrected tests depending on the error message on the AuthenticationForm.
...
Refs #19368 , and the fix introduced in 27f8129d64
2012-12-16 07:18:45 +08:00
27f8129d64
Fixed #19368 -- Ensured that login error messages adapt to changes in the User model.
...
Thanks to un33k for the report.
2012-12-15 22:44:47 +08:00
47e1df896b
Fixed #19412 -- Added PermissionsMixin to the auth.User heirarchy.
...
This makes it easier to make a ModelBackend-compliant (with regards to
permissions) User model.
Thanks to cdestigter for the report about the relationship between
ModelBackend and permissions, and to the many users on django-dev that
contributed to the discussion about mixins.
2012-12-15 22:44:47 +08:00
a2f2a39956
Fixed #18856 -- Ensured that redirects can't be poisoned by malicious users.
2012-12-10 22:11:39 +01:00
35492f8fc4
Fixed #19439 -- Removed unused template tag library in change_password.html
...
Thanks ppetrid for the report.
2012-12-08 12:52:09 +01:00
04e6542b5a
Fixed #19423 -- Prevented ModelAdmin sharing widgets due to formfield_overrides
...
Thanks joebuyer at manycycles.com for the report and Simon Charette
for the review.
2012-12-08 12:41:11 +01:00
6140795150
Fixed a string detection in ogrinspect.py
2012-12-08 12:19:39 +01:00
c91667338a
Fixed #19357 -- Allow non-ASCII chars in filesystem paths
...
Thanks kujiu for the report and Aymeric Augustin for the review.
2012-12-08 11:13:52 +01:00
553838a285
Fixed #19429 -- Applied linebreaksbr to read-only fields in inlines
...
Applied to inlines what ec9d6b1122
2012-12-06 09:52:02 +01:00
45f00dbb93
Minor idiomatic and docstring edits in ar localflavor.
2012-12-04 19:48:39 -03:00
b64d30405a
Fixed #18697 -- Made values accepted for two customizable admin templates consistent.
...
Thanks and at cloverfastfood dot com for the report.
2012-12-04 01:13:01 -03:00
88e1715639
Fixed #19318 -- Ensured that the admin's SimpleListFilter options can be displayed as selected even if the lookup's first element is not a string.
2012-12-03 11:53:15 -08:00
2e2c4968f6
Fixed #17050 -- Added some CSS class names to the admin index pages to facilitate per-app or per-model style customizations. Thanks to scytale for the report and to H0ff1 and thiderman for their work on the patch.
2012-12-02 20:54:34 -08:00
a0cd6dd11e
Fixed #19349 -- Fixed re-rendering of ReadOnlyPasswordHashWidget
...
Thanks tim.bowden at mapforge.com.au for the report, Andreas Hug
for the patch and Anton Baklanov for the review.
2012-12-01 12:22:43 +01:00
84a5294788
Added missing custom user skip decorator
...
PermissionDeniedBackendTest references User model.
2012-11-30 22:54:42 -08:00
0eeae15056
Fixed #19354 -- Do not assume usermodel.pk == usermodel.id
...
Thanks markteisman at hotmail.com for the report.
2012-11-29 21:45:43 +01:00
d913a8b412
Fixed #19356 -- Increased session key entropy.
2012-11-29 16:36:43 +01:00
514ce1d35f
Fixed two docstring/comment typos.
2012-11-28 20:28:30 -03:00
cc3c4a9d55
Fixed #19366 -- Prevented GEOSIndexError when comparing geometries
...
Thanks Craig de Stigter for the report and collaboration on the
patch.
2012-11-28 22:34:02 +01:00
86644e065f
Refactored gis/spatialite connection initialization
...
The connection state is now initialized in get_new_connection().
Refs #19274 .
2012-11-27 19:47:22 +02:00
29d59a879e
Fixed #17911 -- Ensure that admin readonly fields' display values are shown in change forms when the raw value is None.
2012-11-25 23:13:30 +01:00
e18968e0f2
Merge pull request #518 from vanschelven/patch-1
...
Fixed interpolation in a translated string.
Refs #14678 .
2012-11-25 11:59:34 -08:00
ae206d78f6
Fixed #17646 -- Added a get_list_filter() method to ModelAdmin. Thanks to rasca for the suggestion and to mateusgondim for the patch.
2012-11-25 20:39:23 +01:00
35a0fff28a
Fixed #18722 -- Adjusted width of sortable columns in admin
...
Thanks Simon Charette for the report.
2012-11-24 17:12:59 +01:00
a962bc7c45
Updated User manager when testing custom AUTH_USER_MODEL
...
This is giving more real test conditions when AUTH_USER_MODEL is
set with override_settings.
2012-11-24 16:00:00 +01:00
c8985a8a73
Fixed #19806 -- Ensure that content types and permissions aren't created for swapped models.
...
Thanks to rizumu for the report.
2012-11-24 13:43:20 +08:00
7b9a1fb964
Fixed cursor commit command in PostGIS backend
...
Thanks Bruno Renié for noticing the error.
2012-11-23 17:20:36 +01:00
fbd1df8e16
Fixed #19152 -- Allowed PostGIS tests to be run without template
...
From version 2, a PostGIS template is no longer required to create
a GIS-enabled database.
2012-11-23 16:06:31 +01:00
a026e480da
Fixed #16039 -- Made post_syncdb handlers multi-db aware.
...
Also reverted 8fb7a90026#17055 .
2012-11-22 20:53:59 +01:00
9e11253497
Merge pull request #511 from ryankask/username-password-admin
...
Allowed custom User models to use the UserAdmin's change password view.
Fix #19056 (again).
2012-11-22 06:50:37 -08:00
8fdb28219d
Fixed #19331 (again) use the right admin named URL.
...
This allows us to get the trailing slash in URLs without having to
manually assemble and hard-code them.
See also commits e9497a, a222d6, f51eab, 5a9e12.
2012-11-20 21:05:32 -03:00
8c21c53c8b
Fixed #19331 -- Added missing trailing slash in auth admin template
...
Thanks ppetrid at yawd.eu for the report.
2012-11-20 19:19:50 +01:00
edf7ad36fa
Fixed #18658 -- Improved ModelAdmin.message_user API
...
Thanks to Lowe Thiderman for the patch and tests
2012-11-19 16:03:09 -08:00
9b755a298a
Fixed #19291 -- Completed deprecation of ADMIN_MEDIA_PREFIX.
2012-11-17 22:38:19 +01:00
730977046b
Merge pull request #466 from kenthauser/ticket_19025
...
#19025 Add `form` to formwizard context (includes tests)
2012-11-17 12:23:48 -08:00
1520748dac
Fixed #2550 -- Allow the auth backends to raise the PermissionDenied exception to completely stop the authentication chain. Many thanks to namn, danielr, Dan Julius, Łukasz Rekucki, Aashu Dwivedi and umbrae for working this over the years.
2012-11-17 20:24:54 +01:00
e0363c688d
Fixed #19114 -- Fixed LogEntry unicode representation
...
Thanks niko at neagee.net for the report and Emil Stenstrom for
the patch.
2012-11-17 19:19:59 +01:00
ec9d6b1122
Fixed #19226 -- Applied linebreaksbr to read-only fields in admin
...
Thanks shadow for the report, and Melevir and thiderman for the
patch.
2012-11-17 17:06:24 +01:00
d8ee46afff
comment_will_be_sent can cause a 400, not a 403
...
Doc cleanup for django.contrib.comments.signals.comment_will_be_sent
If a receiver returns False, an HttpResponse with status code 400
is returned. A test case already exists confirming this behavior.
Updated docs to reflect reality.
2012-11-16 10:19:54 -05:00
5e3b99d4cf
Update django/contrib/flatpages/forms.py
...
Translate before passing in the variables (i.e. close the bracket earlier).
If you translate after passing in the variables the translated value will contain the actual values for 'url' and 'site' and will therefore not be translated.
(I'm not actually using django's flatpages, but I ran into this apparent error when doing a global grep on my own project)
2012-11-15 22:53:08 +01:00
7cfb567e45
Another regression fix for select_related handling
...
This time gis compiler.get_default_columns() wasn't up to date. Thanks
to CI another regression fixed.
Refs #13781
2012-11-15 21:33:56 +02:00
92d7f541da
Fixed #19058 -- Fixed Oracle GIS crash
...
The problem is the same as in #10888 which was reintroduced when
bulk_insert was added. Thanks to Jani Tiainen for report, patch and
also testing the final patch on Oracle GIS.
2012-11-15 16:08:06 +02:00
bfdedb687a
Allow custom User models to use the UserAdmin's change password view.
2012-11-10 15:48:46 +00:00
aea8bf0662
Added missing encoding preamble to gis tests.
...
'coverage html' did fail without it.
Thanks to Claude Paroz for figuring it out.
2012-11-09 15:16:06 +01:00
11fd00c46e
Fixed #19254 -- Bug in SESSION_FILE_PATH handling.
...
Thanks simonb for the report.
Refs #18194 .
2012-11-06 10:19:14 +01:00
39ec43b478
Removed unnecessary import after b98083ce3d
2012-11-05 09:32:08 +01:00
b98083ce3d
Remove some bizzare and unnecesary code.
2012-11-04 13:58:40 -08:00
fc10418fba
Fixed #18963 -- Used a subclass-friendly pattern
...
for Python 2 object model compatibility methods.
2012-11-03 22:07:35 +01:00
ac2052ebc8
Fixed #17549 -- Added a clickable link for URLFields in admin change list.
2012-11-03 11:57:33 +01:00
92fc263a28
Fixed a regression in gis introduced by Query.select_fields removal
2012-11-02 14:57:19 +02:00
af7ea808d8
Added WizardView.file_storage exception message and docs
...
Thanks Danilo Bargen for the patch.
2012-11-01 16:14:51 -04:00
d9213d09db
Fixed #16678 -- Wrote tests for contrib.redirects app
...
Thanks Julien Phalip for the report.
2012-11-01 19:47:41 +01:00
ba81164fb7
Add `form` to formwizard context (includes tests)
2012-10-31 09:58:28 -04:00
146ed13a11
Fixed #17083 -- Allowed sessions to use non-default cache.
2012-10-31 09:46:16 +01:00
9741912a9a
Fixed #17869 - force logout when REMOTE_USER header disappears
...
If the current sessions user was logged in via a remote user backend log out
the user if REMOTE_USER header not available - otherwise leave it to other auth
middleware to install the AnonymousUser.
Thanks to Sylvain Bouchard for the initial patch and ticket maintenance.
2012-10-29 22:58:14 -07:00
2b5f848207
Fixed #19057 (again) -- added additional tests
2012-10-29 22:24:42 -07:00
81f5d4a1a7
Added some test guards for some recently added auth tests.
...
Refs #19061 , #19057 .
2012-10-30 10:28:35 +08:00
b774c5993c
Fixed #19172 -- Isolated poisoned_http_host tests from 500 handlers
...
Thanks bernardofontes for the report.
2012-10-29 17:28:04 +01:00
4c4d08502c
Fixed #17991 - prefetch_related fails with GenericRelation and varchar ID field
...
Thanks to okke@formsma.nl for the report, and carmandrew@gmail.com for the tests.
2012-10-29 14:31:54 +00:00
4ea8105120
Fixed #19061 -- added is_active attribute to AbstractBaseUser
2012-10-28 23:04:03 -07:00
effe96b303
Fixed a typo in aff9b2f.
...
Thanks void.
2012-10-28 22:35:25 +01:00
58337b3223
Marked cookies-based session expiry test as an expected failure.
...
Refs #19201 .
2012-10-28 18:03:23 +01:00
98032f67c7
Fixed #14093 -- Improved error message in the cache session backend.
...
Thanks stumbles for the patch.
2012-10-28 12:40:10 +01:00
aff9b2f566
Fixed #19203 -- Added isolation to a humanize test
...
Thanks lrekucki for the report.
2012-10-28 09:34:05 +01:00
5fec97b9df
Fixed #18194 -- Expiration of file-based sessions
...
* Prevented stale session files from being loaded
* Added removal of stale session files in django-admin.py clearsessions
Thanks ej for the report, crodjer and Elvard for their inputs.
2012-10-28 09:19:38 +01:00
882c47cd40
Improved tests introduced in 04b00b6.
...
These tests are expected to fail for the file session backend because it
doesn't handle expiry properly. They didn't because of an error in the
test setup sequence.
Refs #19200 , #18194 .
2012-10-27 23:15:45 +02:00
cd17a24083
Added optional kwargs to get_expiry_age/date.
...
This change allows for cleaner tests: we can test the exact output.
Refs #18194 : this change makes it possible to compute session expiry
dates at times other than when the session is saved.
Fixed #18458 : the existence of the `modification` kwarg implies that you
must pass it to get_expiry_age/date if you call these functions outside
of a short request - response cycle (the intended use case).
2012-10-27 23:15:45 +02:00
04b00b668d
Fixed #19200 -- Session expiry with cached_db
...
Also did a little bit of cleanup.
2012-10-27 19:40:39 +02:00
83ba0a9d4b
Fixed #18978 -- Moved cleanup command to sessions.
...
This removes a dependency of 'core' on 'contrib'.
2012-10-27 18:31:00 +02:00
b55de81b9e
Ensured gis tests aren't run on non-gis Oracle
2012-10-27 18:34:47 +03:00
11699ac4b5
Fixed #19190 -- Refactored Query select clause attributes
...
The Query.select and Query.select_fields were collapsed into one list
because the attributes had to be always in sync. Now that they are in
one attribute it is impossible to edit them out of sync.
Similar collapse was done for Query.related_select_cols and
Query.related_select_fields.
2012-10-27 02:13:02 +03:00
58cc3e8484
Fixed #19157 -- Removed test-only string from translatable strings
...
Thanks Alexey Boriskin for the report. Refs #18240 .
2012-10-22 09:31:28 +02:00
c2e19e26bc
Fixed #17856 -- Passed obj to get_inline_instances
...
Thanks ybon, quinode and sjaensch for the patch, and Tim Graham
for the review.
2012-10-20 15:49:52 +02:00
04b53ebfb7
Fixed #19133 -- Corrected regression in form handling for user passwords.
...
Thanks to pressureman for the report, and to Preston Holmes for the draft patch.
2012-10-20 11:41:54 +08:00
0b908b92a2
Fixed #8001 -- Made redirections after add/edit in admin customizable.
...
Also fixes #18310 .
2012-10-18 20:58:52 -03:00
9305c0e12d
Fixed a security issue related to password resets
...
Full disclosure and new release are forthcoming
2012-10-17 14:36:41 -07:00
9d2e1f065e
Reported OpenLayersWidget exceptions through logging
2012-10-17 11:59:10 +02:00
Simon Charette
Javier Mansilla
Christian Metts
Loic Bistuer
Aymeric Augustin
Erik Romijn
Baptiste Mispelon
Claude Paroz
Jaap Roes
Chris Streeter
Marc Tamlyn
Tomek Paczkowski
Bojan Mihelac
Gavin Wahl
Tim Graham
Ramiro Morales
Preston Holmes
Marc Egli
Andrew Godwin
Wiktor Kolodziej
Russell Keith-Magee
Bozidar Benko
Erik Romijn
Łukasz Langa
Honza Kral
Peter Inglesby
Emil Stenström
Diederik van der Boor
Jorge Bastida
Jacob Burch
Mark Huang
Mike Fogel
Florian Apolloner
Donald Stufft
Carl Meyer
Luke Plant
Alex Gaynor
Alex Gaynor
Mike Fogel
Matthew Tretter
Jannis Leidel
Kaspars Sprogis
Andrew Jesaitis
Preston Timmons
Alisson
matiasb
Rocky Meza
Jacob Kaplan-Moss
Adam Wentz
Anssi Kääriäinen
Stephan Jaekel
Andrew Gorcester
Paul Collins
konarkmodi
Juan Catalano
Deric Crago
Igor Támara
Juan Pedro Fisanotti
Pedro Mourelle
Horst Gutmann
Zbigniew Siciarz
Joeri Bekker
Aleksandra Sendecka
Hernan Lozano
Mathijs de Bruin
fako
Hiroki Kiyohara
Alexey Boriskin
Julien Phalip
Nick Sandford
Matt Robenolt
Mitar
Ian Clelland
Marc Aymerich
Sebastián Magrí
Edward Tjörnhammar
Jonatan Heyman
Flavio Curella
Brandon Adams
vanschelven
Ryan Kaskel
Ulrich Petri
Kent Hauser