94d1d4a71b
Captured logging in DebugViewTests with assertLogs().
2020-02-20 09:07:15 +01:00
4261907ff3
Fixed tests when run in reverse.
...
Regression in 98f23a8af0
2020-02-19 14:48:26 +01:00
b457068cf2
Fixed #31187 -- Fixed detecting of existing total ordering in admin changelist when using Meta.constraints.
...
Detection of existing total ordering in admin changelist now takes into
account non-partial unique constraints.
2020-02-19 09:36:23 +01:00
73a34f3fa8
Removed duplicate tests in ChangeListTests.test_total_ordering_optimization().
2020-02-19 07:43:50 +01:00
4ef107e34f
Fixed typos in docs and a test comment.
2020-02-19 07:08:23 +01:00
4d973f5939
Refs #26601 -- Deprecated passing None as get_response arg to middleware classes.
...
This is the new contract since middleware refactoring in Django 1.10.
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2020-02-18 20:03:44 +01:00
a34cb5a6d4
Refs #31282 -- Clarified M2O add/remove/set with PK behaviour.
...
Improved error message for remove() and added tests.
2020-02-18 19:54:29 +01:00
2a038521c4
Fixed #31271 -- Preserved ordering when unifying query parameters on Oracle.
...
This caused misplacing parameters in logged SQL queries.
Regression in 79065b55a7
2020-02-18 11:45:12 +01:00
cbb6531e5b
Fixed #31228 -- Reallowed aggregates to be used with multiple expressions and no DISTINCT on SQLite.
...
Regression in bc05547cd8
2020-02-18 10:32:23 +01:00
f37d548ede
Fixed #20995 -- Added support for iterables of template names to {% include %} template tag.
...
Thanks Adam Johnson for the review.
2020-02-18 06:56:05 +01:00
8690878507
Fixed #31277 -- Relaxed system check of m2m intermediary tables for db_table collision when database routers are installed.
...
Turned the error into a warning when database routers are installed.
2020-02-17 13:53:45 +01:00
98f23a8af0
Fixed #26552 -- Deferred constraint checks when reloading the database with data for tests.
...
deserialize_db_from_string() loads the full serialized database
contents, which might contain forward references and cycles. That
caused IntegrityError because constraints were checked immediately.
Now, it loads data in a transaction with constraint checks deferred
until the end of the transaction.
2020-02-14 13:18:06 +01:00
b330b918e9
Removed unused and incorrect PossessedCar.__str__() method in test_utils.
...
PossessedCar doesn't have a color.
2020-02-14 13:16:17 +01:00
cd2d508707
Removed redundant MiddlewareTest.test_old_style_request() test.
...
CurrentSiteMiddleware.process_request() is already covered by
MiddlewareTest.test_request().
2020-02-14 10:35:58 +01:00
6fba85b766
Removed unused cache.tests.CacheUtils._set_cache().
...
Unused since its introduction in 71a03e01aa
2020-02-13 13:53:12 +01:00
54b7af7eb4
Fixed #31250 -- Ignored processing instructions in assertXMLEqual()/assertXMLNotEqual().
2020-02-13 11:03:54 +01:00
4070d6ceb0
Fixed #31267 -- Added tests cases with empty username or password for URLValidator.
...
Follow up to cdcf4164be
2020-02-13 08:32:20 +01:00
49275c5488
Fixed #30261 -- Prevented Form._html_output() from mutating errors if hidden fields have errors.
2020-02-13 08:12:44 +01:00
da4923ea87
Refs #27468 -- Made PasswordResetTokenGenerator use SHA-256 algorithm.
2020-02-12 21:46:56 +01:00
27f67317da
Removed unnecessary token regex in auth_tests URLs.
...
All URLs in django.contrib.auth use a "<uidb64>/<token>" pattern.
2020-02-12 10:45:53 +01:00
1712a76b9d
Fixed #31246 -- Fixed locking models in QuerySet.select_for_update(of=()) for related fields and parent link fields with multi-table inheritance.
...
Partly regression in 0107e3d105
2020-02-11 20:43:57 +01:00
41a3b3d186
Fixed #31240 -- Properly closed FileResponse when wsgi.file_wrapper is used.
...
Thanks to Oskar Persson for the report.
2020-02-11 20:39:12 +01:00
549445519c
Reverted "Fixed #30565 -- Closed HttpResponse when wsgi.file_wrapper closes file-like object."
...
This reverts commit cce47ff65a
2020-02-11 20:39:12 +01:00
e3f6e18513
Fixed #31253 -- Fixed data loss possibility when using caching from async code.
...
Case missed in a415ce70be
2020-02-11 09:09:25 +01:00
20ba3ce4ac
Fixed #30846 -- Made PostGIS backend respect Index's name argument.
2020-02-10 13:25:32 +01:00
adcf1a7308
Fixed #31248 -- Added missing space before USING SQL on PostGIS.
2020-02-10 11:20:45 +01:00
382af9b141
Fixed #31003 -- Doc'd and tested return value of QuerySet.bulk_create().
2020-02-10 08:36:50 +01:00
708c534e0b
Refs #31055 -- Fixed Model.check() call in ConstraintsTests.test_check_constraints_required_db_features().
2020-02-08 17:23:35 +01:00
fc4f45ebdc
Used assertRaisesMessage() in various tests.
2020-02-07 12:46:23 +01:00
71756bdfed
Fixed #31055 -- Made constraint checks support databases aware.
2020-02-07 11:03:53 +01:00
0b83c8cc4d
Refs #31055 -- Added --database option to the check management command.
...
This avoids enabling the ``database`` checks unless they are explicitly
requested and allows to disable on a per-alias basis which is required
when only creating a subset of the test databases.
This also removes unnecessary BaseCommand._run_checks() hook.
2020-02-07 11:01:31 +01:00
3259983f56
Fixed #31233 -- Closed database connections and cursors after use.
2020-02-06 15:35:23 +01:00
f48f671223
Refs #31233 -- Changed DatabaseWrapper._nodb_connection to _nodb_cursor().
...
It is now a method instead of a property and returns a context manager
that yields a cursor on entry and closes the cursor and connection upon
exit.
2020-02-06 15:29:38 +01:00
2d55cb5c4a
Fixed typo in tests/model_inheritance/tests.py.
2020-02-06 14:20:02 +01:00
2905b41670
Refs #31233 -- Added "error" filter for RuntimeWarning during tests.
2020-02-06 09:46:59 +01:00
4c6ab1f2aa
Fixed #28528 -- Allowed combining SearchVectors with different configs.
2020-02-06 07:52:50 +01:00
72b97a5b1e
Fixed #31232 -- Changed default SECURE_REFERRER_POLICY to 'same-origin'.
2020-02-05 14:39:01 +01:00
7fa1a93c6c
Refs #28214 -- Added test for escaping JSONField key lookups.
...
Thanks mrsanders for the report.
Fixed in 7deeabc7c7
2020-02-05 14:31:30 +01:00
da79ee472d
Fixed #26813 -- Prevented empty choice in ModelChoiceField with RadioSelect for fields with blank=False.
2020-02-05 10:27:01 +01:00
1d5fb35e6a
Refs #26813 -- Added test for ModelChoiceField.choices when using RadioSelect widget.
2020-02-05 09:21:38 +01:00
335c9c94ac
Simplified imports from django.db and django.contrib.gis.db.
2020-02-04 13:20:06 +01:00
8ae84156d6
Fixed #27604 -- Used the cookie signer to sign message cookies.
...
Co-authored-by: Craig Anderson <craiga@craiga.id.au>
2020-02-04 08:05:02 +01:00
eb31d84532
Fixed CVE-2020-7471 -- Properly escaped StringAgg(delimiter) parameter.
2020-02-03 08:49:13 +01:00
6b178a3e93
Fixed #31217 -- Made QuerySet.values()/values_list() group by not selected annotations with aggregations used in order_by().
...
Regression in 59b4e99dd0
2020-02-03 07:48:11 +01:00
a260001a2d
Refs #30943 -- Fixed postgres_tests on PostgreSQL 9.5.
...
Bloom extension is available on PostgreSQL 9.6+.
2020-01-31 20:42:16 +01:00
2e6dc72d83
Used temporary directory in FileFieldTests.test_pickle().
...
Using the current directory caused a PermissionError.
2020-01-31 20:33:48 +01:00
e7d62e97eb
Refs #22426 -- Removed pre-Django 1.5 messages compatibility code and test.
...
This reverts commit f286721f7f
2020-01-31 11:11:24 +01:00
a97111eabf
Fixed 31207 -- Prevented references to non-local remote fields in ForeignKey.to_field.
...
Thanks Simon Charette for the initial patch and review.
2020-01-31 10:19:12 +01:00
4e8d89020c
Fixed #31219 -- Fixed object deletion crash for nested protected related objects.
2020-01-31 09:07:58 +01:00
8c0c0235b6
Added tests for signing non-string values and updated docs.
2020-01-30 11:58:39 +01:00
579f33eb79
Replaced assertWarns() with SimpleTestCase.assertWarnsMessage() in tests.
2020-01-30 11:19:50 +01:00
4ca5c565f4
Refs #27852 -- Fixed object deletion to show all restricted related objects rather than just the first one.
2020-01-29 09:02:23 +01:00
f791673537
Made token tests in auth_tests use assertIs() rather than assertTrue/False().
2020-01-29 09:01:18 +01:00
2633c5341e
Fixed #22261 -- Fixed resolving namespaced URLs for flatpages.
2020-01-28 13:14:23 +01:00
e2fab0b679
Refs #22261 -- Added missing trailing slash to the flatpages_tests urls.
2020-01-28 13:01:08 +01:00
7edd06a9cf
Improved SearchVectorCombinable and SearchQueryCombinable error messages.
2020-01-27 15:09:47 +01:00
50cf183d21
Refs #27468 -- Added algorithm parameter to django.utils.crypto.salted_hmac().
2020-01-27 12:42:21 +01:00
c00b863ac6
Made OnDeleteTests.test_protect() assert more specific ProtectedError.
2020-01-27 12:21:02 +01:00
ab3cbd8b9a
Refs #27852 -- Fixed object deletion to show all protected related objects rather than just the first one.
...
Thanks Anton Samarchyan for the initial patch.
2020-01-27 12:21:02 +01:00
e348ab0d43
Fixed #30997 -- Deprecated HttpRequest.is_ajax().
2020-01-27 08:54:32 +01:00
7fa0fa45c5
Refs #30997 -- Removed HttpRequest.is_ajax() usage.
2020-01-27 08:52:40 +01:00
d66d72f956
Refs #30997 -- Added HttpRequest.accepts().
2020-01-24 14:24:59 +01:00
b94764e178
Fixed #27888 -- Added link to clear all filters in the admin changelist view.
2020-01-23 14:14:54 +01:00
5a68a223c7
Fixed #31200 -- Added system checks for permissions codenames max length.
2020-01-23 12:22:59 +01:00
b423873cb7
Refs #31197 -- Added tests for combined expressions in CheckConstraint.check.
...
Thanks Adam Johnson for the report.
Fixed in 306b687520
2020-01-23 10:28:36 +01:00
0b013564ef
Fixed #31190 -- Fixed prefetch_related() crash for GenericForeignKey with custom ContentType foreign key.
...
Regression in dffa3e1992
2020-01-22 07:54:16 +01:00
31e2ab345b
Fixed #31195 -- Relaxed GeometryDistance test for PROJ 5.2+.
2020-01-21 22:16:23 +01:00
f2a725fba3
Fixed #30274 -- Prevented segmentation fault on LineString iteration.
...
This reverts commit 138a78ec8c
2020-01-21 21:46:47 +01:00
33ec01caaf
Refs #29095 -- Added test for using QuerySet.count() with window expressions ordered by related fields.
...
Fixed in 3f32154f40
2020-01-21 10:43:21 +01:00
227d0c7365
Fixed #31183 -- Added a feature flag for "<db> only supports UNBOUNDED together with PRECEDING and FOLLOWING".
2020-01-20 20:03:35 +01:00
2a2ea4ee18
Refs #31117 -- Made various tests properly handle unexpected databases aliases.
...
- Used selected "databases" instead of django.db.connections.
- Made routers in tests.migrations skip migrations on unexpected
databases.
- Added DiscoverRunnerGetDatabasesTests.assertSkippedDatabases() hook
which properly asserts messages about skipped databases.
2020-01-20 14:39:02 +01:00
b64b1b2e1a
Fixed #31117 -- Isolated backends.base.test_creation.TestDbCreationTests.
...
Previously, this test could modify global state by changing
connection.settings_dict. This dict is a reference to the same dict as
django.db.connections.databases['default'], which is thus also changed.
The cleanup of this test would replace connection.settings_dic` with a
saved copy, which would leave the dict itself modified.
Additionally, create_test_db() would also modify these same dicts, as
well as settings.databases['default']['NAME'] by adding a "test_"
prefix, which is what can cause problems later.
This patch:
- makes a complete copy of the connection and work on that, to improve
isolation.
- calls destroy_test_db() to let that code clean up anything done by
create_test_db().
2020-01-20 11:00:17 +01:00
f34be5294d
Refs #31117 -- Moved get_connection_copy() test hook to a module level.
2020-01-20 11:00:05 +01:00
a920c0b852
Fixed #31142 -- Fixed MakeValid.output_field when geometry type is changed.
...
Regression in 2ef4b4795e
2020-01-20 08:59:45 +01:00
7d8df4ad03
Fixed field default in dates tests.
2020-01-18 20:07:25 +01:00
13e4abf83e
Fixed #30752 -- Allowed using ExceptionReporter subclasses in error reports.
2020-01-16 15:25:49 +01:00
266c853e10
Fixed #31162 -- Prevented error logs when using WKT strings in lookups.
...
Thanks dbxnr for the initial patch.
Regression in 6f44f714c9
2020-01-16 14:34:54 +01:00
d08d4f464a
Fixed #30765 -- Made cache_page decorator take precedence over max-age Cache-Control directive.
2020-01-16 13:39:16 +01:00
bf77669453
Fixed #29998 -- Allowed multiple OneToOneFields to the parent model.
...
We assumed that any OneToOneField's in a child model must be the
parent link and raised an error when parent_link=True was not
specified. This patch allows to specify multiple OneToOneField's to
the parent model.
OneToOneField's without a custom related_name will raise fields.E304
and fields.E305 so this should warn users when they try to override
the auto-created OneToOneField.
2020-01-16 08:06:16 +01:00
29c126bb34
Fixed #31124 -- Fixed setting of get_FOO_display() when overriding inherited choices.
...
Regression in 2d38eb0ab9
2020-01-15 15:35:22 +01:00
b5a62bd17d
Refs #27468 -- Added explicit tests for django.utils.crypto.salted_hmac()
2020-01-15 12:53:21 +01:00
59b4e99dd0
Refs #31136 -- Made QuerySet.values()/values_list() group only by selected annotation.
...
Regression in 0f843fdd5b
2020-01-15 09:32:42 +01:00
63e6ee1f99
Fixed #29871 -- Allowed setting pk=None on a child model to create a copy.
...
Thanks Simon Charette and Tim Graham for the initial patch.
2020-01-15 08:28:30 +01:00
6f7998adc7
Fixed #31155 -- Fixed a system check for the longest choice when a named group contains only non-string values.
...
Regression in b6251956b6
2020-01-11 19:47:36 +01:00
8b3e714ecf
Fixed #30980 -- Improved error message when checking uniqueness of admin actions' __name__.
...
Thanks Keshav Kumar for the initial patch.
2020-01-10 14:00:28 +01:00
e2d9d66a22
Fixed #23004 -- Added request.META filtering to SafeExceptionReporterFilter.
...
Co-authored-by: Ryan Castner <castner.rr@gmail.com>
2020-01-10 11:35:41 +01:00
581ba5a948
Refs #23004 -- Allowed exception reporter filters to customize settings filtering.
...
Thanks to Tim Graham for the original implementation idea.
Co-authored-by: Daniel Maxson <dmaxson@ccpgames.com>
2020-01-10 11:21:23 +01:00
5166097d7c
Fixed #31154 -- Added support for using enumeration types in templates.
...
Enumeration helpers are callables, so the template system tried to call
them with no arguments.
Thanks Rupert Baker for helping discover this.
2020-01-10 07:52:06 +01:00
4c1b401e82
Added file cleanup in FileFieldTests.test_pickle().
2020-01-09 20:47:45 +01:00
eb629f4c02
Fixed #30995 -- Allowed converter.to_url() to raise ValueError to indicate no match.
2020-01-09 14:41:41 +01:00
eef3ea847e
Fixed #31148 -- Added error messages on update()/delete() operations following union(), intersection(), and difference().
2020-01-09 12:20:54 +01:00
f600e3fad6
Fixed #21238 -- Fixed restoring attributes when pickling FileField and ImageField.
2020-01-09 09:37:59 +01:00
aaea9deac4
Refs #21238 -- Added more tests for pickling FileField and ImageField.
2020-01-09 09:18:53 +01:00
66e16dcc99
Removed unused lines in ImageFieldTests.test_pickle().
2020-01-09 08:44:39 +01:00
07f6ff09e4
Added tests for using the same name for multiple URL patterns.
2020-01-08 10:55:53 +01:00
ffcf1a8ebf
Fixed #31118 -- Made FileInput to avoid the required attribute when initial data exists.
2020-01-08 09:15:31 +01:00
53d8646f79
Fixed #31141 -- Relaxed system check of translation settings for sublanguages.
...
Regression in 4400d8296d
2020-01-08 08:05:43 +01:00
8be477be5c
Fixed timezones tests for PyYAML 5.3+.
2020-01-07 09:54:22 +01:00
2ea3fb3e63
Removed "Don't do that" from docs and error messages.
...
It's slightly aggressive and doesn't explain itself.
2020-01-06 13:50:43 +01:00
1487f16f2d
Fixed #11385 -- Made forms.DateTimeField accept ISO 8601 date inputs.
...
Thanks José Padilla for the initial patch, and Carlton Gibson for the
review.
2020-01-06 10:52:09 +01:00
Jon Dufresne
Mariusz Felisiak
Fabio Sangiovanni
Yoo In Keun
Claude Paroz
Carlton Gibson
Taoup
Keshav Kumar
Xavier Francisco
Matthijs Kooijman
yura
Dennis Schwertel
Hasan Ramezani
Abhijeet Viswa
Florian Apolloner
=Pratik Kumar
Hannes Ljungberg
Adam Johnson
Simon Charette
Nikita Sobolev
adamb70
Nick Pope
Matthias Kestenholz
Michael Mulholland
Eugene Hatsko
Sergey Fedoseev
Christopher G Johnson
Tim Graham
Pavel Lysak
Flavio Curella
chetan22
Adam Donaghy
Jack Cushman
Shubham singh