David Wobrock
ee3b719a81
Refs #32675 -- Removed to_field from ForeignKeys in contrib apps' migrations.
...
Refs #22889 .
2021-04-29 07:46:22 +02:00
Mariusz Felisiak
1871182031
Fixed #32682 -- Made admin changelist use Exists() instead of distinct() for preventing duplicates.
...
Thanks Zain Patel for the report and Simon Charette for reviews.
The exception introduced in 6307c3f1a1
revealed a possible data loss issue in the admin.
2021-04-27 10:34:47 +02:00
Mariusz Felisiak
cd74aad90e
Refs #32682 -- Renamed use_distinct variable to may_have_duplicates.
...
QuerySet.distinct() is not the only way to avoid duplicate, it's also
not preferred.
2021-04-27 10:34:47 +02:00
Zain Patel
4e5bbb6ef2
Fixed #32681 -- Fixed VariableDoesNotExist when rendering some admin template.
...
Regression in 84609b3205
.
2021-04-26 07:08:16 +02:00
Carlton Gibson
5c73fbb6a9
Fixed #32647 -- Restored multi-row select with shift-modifier in admin changelist.
...
Regression in 30e59705fc
.
2021-04-21 08:31:06 +02:00
Mariusz Felisiak
23fa29f6a6
Fixed #32649 -- Fixed ModelAdmin.search_fields crash when searching against phrases with unbalanced quotes.
...
Thanks Dlis for the report.
Regression in 26a413507a
.
2021-04-14 12:23:47 +02:00
Raymond Nunez
e84b054325
Added missing "event" argument to addEventListener() call in actions.js.
2021-04-09 09:03:17 +02:00
Claude Paroz
90b95d2959
Updated translations from Transifex.
...
Forwardport of 1ea5e98315
from stable/3.2.x.
2021-04-06 06:19:31 +02:00
Mariusz Felisiak
548dce50cf
Removed unnecessary left/right in admin sidebar CSS.
2021-03-31 20:34:15 +02:00
Maxim Milovanov
d915dd1c58
Fixed #32204 -- Added quick filter to admin's navigation sidebar.
2021-03-31 09:31:37 +02:00
Johannes Maron
03d0f12c82
Fixed #32466 -- Corrected autocomplete to_field resolution for complex cases.
...
In MTI or ForeignKey as primary key cases, it is required to fetch the attname
from the field instance on the remote model in order to reliably resolve the
to_field_name.
Co-authored-by: Johannes Maron <info@johanneshoppe.com>
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2021-03-18 11:21:23 +01:00
mimi89999
0df5c8187a
Fixed #32512 -- Fixed admin dark theme for autocomplete fields.
2021-03-10 11:16:03 +01:00
Mariusz Felisiak
6f5dbe9dbe
Refs #32018 -- Corrected color variable for toggle links in admin.
...
Follow up to cd3019bc10
.
2021-03-09 18:38:07 +01:00
Mariusz Felisiak
781acf0987
Refs #32018 -- Used --darkened-bg for <pre> elements.
2021-03-09 18:34:25 +01:00
Hasan Ramezani
20ddc3b81d
Fixed #32494 -- Adjusted system check for raw_id_fields to warn about Field.attname.
2021-03-04 08:41:28 +01:00
Hasan Ramezani
1da54bfe7d
Corrected messages of admin checks for invalid model field names.
2021-03-04 08:41:28 +01:00
tim-mccurrach
f55f3ce831
Fixed #32493 -- Removed redundant never_cache uses from admin views.
...
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2021-03-03 09:13:07 +01:00
Haki Benita
63bbfa9f45
Fixed #32468 -- Corrected usage of never_cache in contrib.admin.
2021-02-24 10:13:43 +01:00
Amir Ajorloo
1710cdbe79
Fixed #32443 -- Removed "shifted" CSS class when admin's sidebar is disabled.
2021-02-18 09:18:19 +01:00
Teresa Partida
45bef6706a
Fixed #30231 -- Fixed admin filter horizontal/vertical verbose_name generation.
...
Co-authored-by: David Smith <smithdc@gmail.com>
2021-02-16 14:26:53 +01:00
manav014
3119a6deca
Fixed #26607 -- Allowed customizing formset kwargs with ModelAdmin.get_formset_kwargs().
...
Thanks Nick Pope for reviews.
2021-02-15 11:37:35 +01:00
Denis Skulimovskiy
269a767146
Fixed #32391 -- Used CSS flex properties for changelist filter.
...
Matched layout adjustment using flex from admin sidebar added in
d24ba1be7a
.
Filters would become squashed when viewport was
constrained or list display table became too wide.
2021-01-28 15:51:05 +01:00
tim-mccurrach
a736baab92
Fixed #32385 -- Removed unused and duplicated loading of tags in admin templates.
...
- `i18n` is duplicated in base.html.
- `l10n` is unused in prepopulated_fields_js.html
since d638cdc42a
.
- `static` is unused in change_list_results.html
since f2ed107b07
.
- `static` is unused in stacked.html
since d61ebc8fed
.
2021-01-27 12:16:12 +01:00
Tom Carrick
f054468cac
Refs #31259 -- Made various dark theme adjustments.
2021-01-20 15:47:23 +01:00
muskanvaswan
ab7478d1d4
Fixed #32324 -- Added template block to override the admin site header.
2021-01-19 12:27:07 +01:00
Timothy McCurrach
0aff3fd711
Fixed #18549 -- Fixed heading for inlines with a OneToOneField.
...
Used verbose_name instead of verbose_name_plural.
2021-01-18 08:12:19 +01:00
Claude Paroz
e0a46367df
Updated source translation catalogs.
...
Forwardport of 3dc3a952b2
from stable/3.2.x.
2021-01-15 09:43:45 +01:00
Matthias Kestenholz
257dfce6c8
Refs #31259 -- Improved some color contrasts for admin dark theme.
2021-01-14 14:06:02 +01:00
mimi89999
b5cef91a91
Fixed #31259 -- Added admin dark theme.
2021-01-14 08:27:29 +01:00
Nick Pope
9204485396
Fixed #16117 -- Added decorators for admin action and display functions.
...
Refs #25134 , #32099 .
2021-01-13 17:19:22 +01:00
Jon Dufresne
ba31b01034
Fixed #31747 -- Fixed model enumeration via admin URLs.
...
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2021-01-12 14:37:56 +01:00
Johannes Maron
3071660acf
Fixed #29010 , Fixed #29138 -- Added limit_choices_to and to_field support to autocomplete fields.
...
* Fixed #29010 -- Added limit_choices_to support to autocomplete fields.
* Fixed #29138 -- Allowed autocomplete fields to target a custom
to_field rather than the PK.
2021-01-12 11:37:38 +01:00
Michel Le Bihan
16d27fb806
Refs #32018 -- Corrected color variables for paginator and header links in admin.
...
Follow up to cd3019bc10
.
2021-01-12 06:34:25 +01:00
Michel Le Bihan
cd3019bc10
Refs #32018 -- Used --header-link-color for header links in admin.
2021-01-11 11:42:59 +01:00
Matthias Kestenholz
0a802233ec
Fixed #32018 -- Extracted admin colors into CSS variables.
...
Defined all colors used in the admin CSS as variables. Implemented the
following standardizations and accessibility improvements while at it:
- Improved the contrast of text to not use ratios of less than 3:1 anymore.
- Most hover states already used desaturated and darkened colors.
Changed object tools to follow the same rule instead of showing the
primary color on hover.
Various places used similar colors; those have been merged with the goal
of reducing the count of CSS variables. Contrasts have been improved in
a few places.
- Many borders used slightly different colors (e.g. #eaeaea vs. #eee)
- Help texts used #999 , this has been changed to --body-quiet-color
(#666 ) which has a better contrast.
Introduced fast color transitions on links and buttons.
2021-01-07 10:07:19 +01:00
Viktor Grabov
6a054f7681
Fixed #32322 -- Fixed autocomplete widget wrapping.
2021-01-06 09:32:13 +01:00
Tom Forbes
b5e12d490a
Fixed #31007 -- Allowed specifying type of auto-created primary keys.
...
This also changes the default type of auto-created primary keys
for new apps and projects to BigAutoField.
2020-12-15 11:25:46 +01:00
Mariusz Felisiak
3828427f63
Refs #31978 -- Fixed hint in admin's password reset confirmation form for custom username fields.
...
Thanks Jaap Roes for the report.
2020-11-30 06:34:22 +01:00
Author: Nick Pope
20f2b822f8
Added explicit HTMLElement.dir attribute in templates.
2020-11-20 11:09:46 +01:00
Nick Pope
67a1ae68a8
Refs #24474 -- Changed AdminSite.empty_value_display property to an attribute.
...
This was implemented with a property getter and setter when introduced
in 0207bdd2d4
.
There is nothing special occurring here though - a simple read from and
assign to the underlying private attribute.
2020-11-14 07:24:07 +01:00
Nick Pope
fed8129276
Unified admin action description generation.
...
Actions added to AdminSite.actions would not have the first character
of their description capitalized.
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2020-11-13 21:41:18 +01:00
Claude Paroz
187482d743
Avoided direct styles in admin templates.
...
Direct styles might be forbidden by Content Security Policies.
2020-11-10 21:32:15 +01:00
Gagan Deep
982e860b73
Fixed #32062 -- Added %b support to Date.strftime.
...
This enables the admin to display the month as locale's abbreviated
name if %b is used in the date format.
2020-10-28 11:11:37 +01:00
Josh Santos
36bc47069c
Fixed #32127 -- Fixed admin change-form textarea layout for mid-sized displays.
2020-10-27 16:06:11 +01:00
Carlton Gibson
257f8495d6
Fixed #32069 -- Fixed admin change-form layout on small screens.
...
Restored flex-wrap CSS declaration to form elements at smallest breakpoint.
This was present since the responsive admin was introduced in dc37e8846e
.
Regression in 8ee4bb6ffc
, where it was accidentally removed.
2020-10-21 15:06:43 +02:00
Marco Richetta
e92971ccb0
Removed unnecessary check in BaseModelAdmin.get_view_on_site_url().
2020-10-13 06:28:14 +02:00
Tim Schilling
b7da588e88
Fixed #32091 -- Fixed admin search bar width on filtered admin page.
2020-10-09 11:39:22 +02:00
Qi Zhao
de81676b51
Fixed #32080 -- Fixed displaying Unicode chars in forms.JSONField and read-only JSONField values in admin.
2020-10-09 08:14:17 +02:00
Julien Rebetez
b790883065
Fixed #31181 -- Added links to related models for admin's readonly fields.
2020-10-08 19:53:49 +02:00
Tom Carrick
342a41740d
Fixed #32072 -- Fixed admin search bar height.
...
Thanks şuayip üzülmez for the report.
Regression in 8ee4bb6ffc
.
2020-10-06 11:33:48 +02:00
Tom Carrick
8ee4bb6ffc
Fixed #31986 -- Fixed admin filter sidebar scrolling.
...
Regression in 2bc38bc7ca
.
Thanks haki for the report.
2020-09-30 20:35:16 +02:00
Claude Paroz
5fcfe5361e
Updated translations from Transifex.
...
Forwardport of f7397bb7c8
from stable/3.1.x.
2020-09-30 10:25:48 +02:00
Matthias Kestenholz
01974d7f75
Fixed #32029 -- Removed unnecessary margin in admin CSS for horizontal radio inputs.
2020-09-23 13:58:26 +02:00
Matthias Kestenholz
01c6caa3e6
Fixed #32027 -- Fixed wrapping of long words in admin error messages.
2020-09-23 13:51:02 +02:00
Raffaele Salmaso
7b9596b974
Fixed #32034 -- Removed redundant get_app_config() call in AdminSite.app_index.
...
app_config.verbose_name is already in app_dict.
2020-09-23 10:01:05 +02:00
manav014
580a4341cb
Fixed #31636 -- Made BooleanFieldListFilter respect Field.choices.
2020-09-15 09:12:14 +02:00
Tom Carrick
bcc2befd0e
Fixed #31789 -- Added a new headers interface to HttpResponse.
2020-09-14 08:41:59 +02:00
Jon Dufresne
84609b3205
Fixed #31993 -- Added subtitles to admin change/view pages.
2020-09-11 06:28:45 +02:00
Jon Dufresne
53c0d16ac1
Fixed #31992 -- Made admin password reset templates use title/content_title blocks from the base template.
2020-09-10 11:53:09 +02:00
Collin Anderson
daa26acc4e
Fixed #31978 -- Added username hint to admin's password reset confirmation form.
2020-09-03 09:25:21 +02:00
007gzs
2bc38bc7ca
Fixed #31901 -- Prevented content overflowing in the admin changelist with navigation sidebar.
2020-09-01 07:51:22 +02:00
Carlton Gibson
0aeb802cf0
Fixed #31865 -- Adjusted admin nav sidebar template to reduce debug logging.
...
Thanks to Mariusz Felisiak for review.
2020-08-11 11:42:15 +02:00
Nick Pope
0a306f7da6
Fixed #25513 -- Extracted admin pagination to Paginator.get_elided_page_range().
2020-08-06 12:38:56 +02:00
Nick Pope
f35840c196
Refs #25513 -- Fixed admin pagination elision bounds.
...
It doesn't make sense to elide a single page number which could be a
clickable link to that page. We only want to elide two or more pages.
2020-08-06 12:38:56 +02:00
Nick Pope
b203ec70fd
Refs #25513 -- Adjusted admin pagination to be 1-indexed.
2020-08-06 12:38:56 +02:00
Mariusz Felisiak
e70dc506d7
Fixed #31854 -- Fixed wrapping of long model names in admin's sidebar.
2020-08-05 10:54:25 +02:00
007gzs
b0af56f639
Fixed #31853 -- Fixed wrapping of translated action labels in admin sidebar.
2020-08-05 10:24:16 +02:00
Claude Paroz
1a60838fa6
Updated translations from Transifex
2020-08-01 20:41:11 +02:00
David Smith
e74b3d724e
Bumped minimum isort version to 5.1.0.
...
Fixed inner imports per isort 5.
isort 5.0.0 to 5.1.0 was unstable.
2020-07-30 10:58:59 +02:00
Aymeric Augustin
3f2821af6b
Fixed #31180 -- Configured applications automatically.
2020-07-21 10:35:12 +02:00
Claude Paroz
b502061027
Added admin translatable string.
...
Forward port of dda8a2aa1d
from stable/3.1.x.
2020-07-14 21:37:49 +02:00
Jon Dufresne
4d9cd89acb
Simplified <body> element references in DateTimeShortcuts.js.
2020-07-04 21:14:52 +02:00
tapan gujjar
2d67222472
Fixed #31522 -- Made admin's SelectBox preserve scroll position.
2020-07-01 16:31:38 +02:00
Jon Dufresne
1e3ceb485e
Made JavaScript URL manipulation more robust with URL and URLSearchParams.
...
Use the rich interface and native parsing provided by the browser rather
than raw string manipulation.
https://developer.mozilla.org/en-US/docs/Web/API/URL
https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams
2020-07-01 11:19:24 +02:00
Jon Dufresne
dbae6de01e
Simplified JavaScript with Array.prototype.includes().
...
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/includes
2020-07-01 10:16:20 +02:00
Jon Dufresne
feb6581993
Fixed the centering of the "Log in" button on admin login page.
...
Previously, the button's container had a padding of 9.4em which was
approximately center but not precisely. Now, the container uses
'align:text-center' to let the browser center the button.
2020-06-26 06:59:33 +02:00
Jon Dufresne
f3e5fba7c5
Simplified label element CSS in admin login.css.
...
Don't add horizontal padding as the label is always displayed on its own
line. This padding added no visual difference.
Move the 'display: block' property from responsive.css to base.css. The
label is already displayed on its own line in all viewports, so reduce
differences in rendering. Using block also allows the label to consume
the width of its container, creating a larger clickable area for a
slight a11y improvement.
2020-06-25 12:26:36 +02:00
Jon Dufresne
60db8b7b37
Removed unnecessary admin CSS.
...
The "object-tools" container is never rendered as a descendant of
.form-row.
The "golink" CSS class is unused.
A <label> element has not been included in the login .submit-row since
5869afe32b
.
The "help" CSS class from login.css has been unused since
0e5faf225c
.
The <label> color in login.css is already inherited from the <body>
element and so does not need to be re-specified.
The #content-main container already has the property 'width: 100%' from
base.css and so does not need to be re-specified in login.css.
The <td> and <th> font-family property is inherited from the <body>
element and so does not need to be re-specified.
The <html> element has the attribute dir which automatically sets
the text direction in the layout. Adding the direction CSS property was
necessary to support IE which does not support the dir attribute, but IE
is no longer supported, so drop the direction property.
The 'font-size: 1em' property re-specifies the same font size. It
creates no visual difference.
The 'font-size: 14px' property often re-specifies the inherited value.
Avoid re-specifying it.
2020-06-25 11:46:05 +02:00
Hasan Ramezani
fbe82f8255
Refs #26761 -- Removed extra space in admin change list result header.
2020-06-25 06:33:12 +02:00
Jon Dufresne
30e59705fc
Fixed #31523 -- Removed jQuery dependency from actions.js.
2020-06-24 11:54:48 +02:00
Alix
26a413507a
Fixed #6933 -- Added support for searching against quoted phrases in ModelAdmin.search_fields.
2020-06-18 20:17:20 +02:00
Adam Johnson
fcdac3787d
Removed unused HTML class flex from admin changelist.
...
Unused since 233708fb68
.
2020-06-04 11:25:19 +02:00
Collin Anderson
4ae9a2b18e
Fixed #31641 -- Improved loading of navigation sidebar in admin.
2020-06-03 13:04:54 +02:00
Jon Dufresne
2dd4d110c1
Fixed CVE-2020-13596 -- Fixed potential XSS in admin ForeignKeyRawIdWidget.
2020-06-03 09:23:00 +02:00
Carles Pina
e46c2326c8
Fixed #31536 -- Fixed rendering of disabled AdminFileWidget and ClearableFileInput.
2020-06-01 12:25:25 +02:00
Jon Dufresne
3bc4240d97
Removed unused admin:jsi18n <script> element from change_password.html.
...
The view does not contain any other JavaScript and therefore does not
have any user facing JavaScript strings to translate. Avoid the HTTP
request.
2020-05-28 15:21:47 +02:00
Tom Carrick
780473d756
Refs #31034 -- Improved accessibility of admin navigation sidebar.
2020-05-28 10:16:20 +02:00
Scott Cranfill
62f1655a64
Fixed #11157 -- Stopped removing stop words in admin's prepopulated_fields.
...
Co-Authored-By: Andy Chosak <andy@chosak.org>
2020-05-27 12:32:56 +02:00
Hasan Ramezani
18759b2209
Fixed #31616 -- Added hint about middleware ordering for SessionMiddleware admin check.
2020-05-25 21:14:32 +02:00
Fran Hrzenjak
4484bc1b2f
Fixed #31597 , #31603 -- Corrected admin clear all filters link behavior.
...
- Show "Clear all filters" only when any filter is selected.
- Preserve query string not related with filters.
Co-Authored-By: Hasan Ramezani <hasan.r67@gmail.com>
2020-05-20 21:08:47 +02:00
Jon Dufresne
e46f700e39
Refs #31034 -- Used === in nav_sidebar.js admin JS to avoid possible coercion issues.
2020-05-18 07:42:44 +02:00
kjpc-tech
099bce1bf0
Fixed #31590 -- Fixed ModelAdmin.date_hierarchy crash with an empty QuerySet.
...
Regression in 55cdf6c52d
.
2020-05-15 06:35:10 +02:00
Jon Dufresne
81ffedaacc
Fixed #31524 -- Removed minified static assets from the admin.
2020-05-14 16:07:56 +02:00
Jon Dufresne
d522b51c40
Fixed #31575 -- Added system check for admin sidebar request context processor dependency.
...
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2020-05-14 11:00:51 +02:00
Jon Dufresne
0a627dbe73
Removed unused Downcoder.chars.
...
Unused -- other than as a local variable -- since its introduction in
953badbea5
2020-05-13 21:07:14 +02:00
Mariusz Felisiak
0668164b4a
Fixed E128, E741 flake8 warnings.
2020-05-12 08:52:23 +02:00
Claude Paroz
e6ec76d245
Updated JS admin translation catalog.
2020-05-11 22:59:27 +02:00
Claude Paroz
33f26339b7
Updated source translation catalogs.
2020-05-11 21:34:46 +02:00
Tom Carrick
46fe506445
Corrected indentation of #main div in admin base template.
2020-05-11 18:16:38 +02:00
Tom Carrick
d24ba1be7a
Fixed #31034 -- Added a navigation sidebar to the admin.
...
Co-authored-by: elky <elky@users.noreply.github.com>
Co-authored-by: Goetz <goetz.buerkle@gmail.com>
2020-05-11 18:16:38 +02:00