Tim Graham
e0910dcc92
Refs #25604 -- Removed makemigrations --exit option per deprecation timeline.
2017-01-17 20:52:01 -05:00
Tim Graham
ff419de263
Refs #25466 -- Removed aliases for LoaderOrigin and StringOrigin.
...
Per deprecation timeline.
2017-01-17 20:52:01 -05:00
Tim Graham
75cf9b5ac0
Refs #13110 -- Removed SyndicationFeed.add_item()'s enclosure argument.
...
Per deprecation timeline.
2017-01-17 20:52:01 -05:00
Tim Graham
d67a46e104
Refs #25135 -- Removed support for the contrib.admin allow_tags attribute.
...
Per deprecation timeline.
2017-01-17 20:52:01 -05:00
Tim Graham
7510b872e7
Refs #25190 -- Removed callable_obj parameter to assertRaisesMessages().
...
Per deprecation timeline.
2017-01-17 20:52:01 -05:00
Tim Graham
9f9a3d643e
Refs #24126 -- Removed auth views' current_app parameter per deprecation timeline.
2017-01-17 20:52:00 -05:00
Tim Graham
8377abd59e
Refs #25120 -- Removed template.loaders.eggs.Loader per deprecation timeline.
2017-01-17 20:52:00 -05:00
Tim Graham
733c7c7030
Refs #24716 -- Removed Field._get_val_from_obj() per deprecation timeline.
2017-01-17 20:52:00 -05:00
Tim Graham
ad393beeb7
Refs #21927 -- Removed include()'s app_name argument per deprecation timeline.
...
Also removed support for passing a 3-tuple to include() and support for
setting an instance namespace without an application namespace.
Thanks Marten Kenbeek for completing the patch.
2017-01-17 20:52:00 -05:00
Tim Graham
c6de8cca20
Refs #24728 - Removed Atom1Feed/RssFeed mime_type attribute.
...
Per deprecation timeline.
2017-01-17 20:52:00 -05:00
Tim Graham
3cee9edd1b
Refs #24733 -- Removed support for error views without the exception parameter.
...
Per deprecation timeline.
2017-01-17 20:52:00 -05:00
Tim Graham
5d8da093a9
Refs #15053 -- Removed support for non-recursive template loading.
...
Per deprecation timeline.
2017-01-17 20:52:00 -05:00
Tim Graham
56a5760543
Refs #25184 -- Removed contrib.gis.geoip per deprecation timeline.
2017-01-17 20:52:00 -05:00
Tim Graham
a0d166306f
Removed GeoManager and GeoQuerySet per deprecation timeline.
2017-01-17 20:51:56 -05:00
Tim Graham
e90c745afd
Refs #22993 -- Removed skipIfCustomUser per deprecation timeline.
2017-01-17 14:09:29 -05:00
Tim Graham
e707e4c709
Refs #19738 -- Removed timezone conversion in SQL queries executed outside of the ORM.
...
Per deprecation timeline.
2017-01-17 14:09:29 -05:00
Tim Graham
b2ffbb00a5
Refs #24215 -- Removed add_lazy_relation() per deprecation timeline.
2017-01-17 14:09:29 -05:00
Tim Graham
ddd3268975
Refs #21127 -- Required on_delete for ForeignKey/OneToOneField.
...
Per deprecation timeline.
2017-01-17 14:09:28 -05:00
Tim Graham
625e9da9ca
Removed Field.rel and Field.remote_field.to per deprecation timeline.
2017-01-17 14:09:28 -05:00
Tim Graham
0f454f5d4d
Refs #23960 -- Removed the host parameter for SimpleTestCase.assertRedirects().
...
Per deprecation timeline.
2017-01-17 14:09:28 -05:00
Tim Graham
f032bbc8b1
Refs #18651 -- Removed assignment_tag per deprecation timeline.
2017-01-17 14:09:28 -05:00
Tim Graham
742d666da5
Refs #24219 -- Removed django.forms.extras per deprecation timeline.
2017-01-17 14:09:28 -05:00
Tim Graham
a3bd8672d8
Refs #24154 -- Removed deprecated BaseDatabaseOperations.check_aggregate_support().
2017-01-17 14:09:28 -05:00
Tim Graham
03087f80d1
Refs #24205 -- Removed Signal.disconnect()'s weak argument.
...
Per deprecation timeline.
2017-01-17 14:09:28 -05:00
Tim Graham
e8dac72a55
Added stub 2.0 release notes.
2017-01-17 14:09:28 -05:00
Tim Graham
f32feaa901
Bumped version; master is now 2.0 pre-alpha.
2017-01-17 14:09:28 -05:00
Tim Graham
4054013e00
Removed obsolete GIS install instructions.
2017-01-17 13:47:56 -05:00
Ed Morley
44cce3ed00
Fixed #27739 -- Documented LabelCommand.label.
2017-01-17 13:20:31 -05:00
Ed Morley
d1eda9b4ad
Refs #24109 -- Doc'd the elidable feature in squashing migrations docs.
2017-01-17 13:02:58 -05:00
Tim Graham
f01ad1cb6a
Refs #27683 -- Allowed setting isolation level in DATABASES ['OPTIONS'] on MySQL.
2017-01-17 11:16:15 -05:00
Markus Holtermann
45ded053b1
Fixed #27666 -- Delayed rendering of recursivly related models in migration operations.
2017-01-17 08:12:52 -05:00
Mads Jensen
65e321b781
Refs #25809 -- Made a few late review comments for BrinIndex.
2017-01-16 13:23:20 -05:00
Tim Graham
0f46bc67e2
Fixed #27735 -- Doc'd form widget l10n change (refs #15667 ).
2017-01-16 12:58:21 -05:00
Tim Graham
f2d2f17896
Removed empty sections from 1.11 release notes.
2017-01-16 09:58:26 -05:00
Mads Jensen
e585c43be9
Fixed #25809 -- Added BrinIndex support in django.contrib.postgres.
...
Thanks Tim Graham and Markus Holtermann for review.
2017-01-15 13:37:18 +01:00
Matthew Schinckel
236ebe94bf
Fixed #27149 -- Added Subquery and Exists database expressions.
...
Thanks Josh Smeaton for Oracle fixes.
2017-01-14 09:12:24 -05:00
Florian Apolloner
84c1826ded
Fixed #27718 -- Added QuerySet.union(), intersection(), difference().
...
Thanks Mariusz Felisiak for review and Oracle assistance.
Thanks Tim Graham for review and writing docs.
2017-01-14 08:32:07 -05:00
Claude Paroz
611ef422b1
Fixed #27387 -- Doc'd required HTML attribute in Field.required docs.
2017-01-14 07:30:54 -05:00
Romain Garrigues
ede59ef6f3
Fixed #27518 -- Prevented possibie password reset token leak via HTTP Referer header.
...
Thanks Florian Apolloner for contributing to this patch and
Collin Anderson, Markus Holtermann, and Tim Graham for review.
2017-01-13 09:17:54 -05:00
André Cruz
e303739f8e
Fixed outdated log level in docs/topics/logging.txt.
...
Refs b3acdeee50
.
2017-01-12 13:04:17 -05:00
Tim Graham
a4cc622363
Fixed typos in docs/ref/contrib/admin/index.txt
2017-01-11 19:01:30 -05:00
M Somerville
56c87b51ab
Fixed typo in docs/topics/db/managers.txt.
2017-01-11 18:31:11 -05:00
François Freitag
f3b7c05936
Refs #16614 -- Made QuerySet.iterator() use server-side cursors on PostgreSQL.
...
Thanks to Josh Smeaton for the idea of implementing server-side cursors
in PostgreSQL from the iterator method, and Anssi Kääriäinen and Kevin
Turner for their previous work. Also Simon Charette and Tim Graham for
review.
2017-01-11 09:25:37 -05:00
David Sanders
53bffe8d03
Fixed #24452 -- Fixed HashedFilesMixin correctness with nested paths.
2017-01-11 09:21:29 -05:00
Tim Graham
991cd69621
Fixed #27711 -- Demoted "Installing a distribution-specific package" in install intro.
2017-01-10 09:29:23 -05:00
Maxime Lorant
241e1e3cd7
Removed SHOUTING in doc examples.
2017-01-09 17:00:44 -05:00
Tim Graham
823af53bf6
Fixed #27707 -- Removed shell support for IPython < 1.0.
2017-01-09 12:02:43 -05:00
Sebastian Spiegel
8b734d2f99
Fixed #27432 -- Made app_label arguments limit showmigrations --plan output.
2017-01-06 19:50:31 -05:00
Tim Graham
ad7f3c0b7b
Refs #24688 , #27497 -- Corrected docs: distance's 'spheroid' option isn't PostGIS specific.
2017-01-06 07:55:00 -05:00
Tim Graham
ab661e994b
Alphabetized system check reference.
2017-01-05 11:04:44 -05:00
jpic
944610a86c
Fixed #27680 -- Linked to "Classy Class-Based Views" in docs.
2017-01-04 19:12:14 -05:00
Tim Graham
a50926ede2
Added stub release notes for 1.10.6.
2017-01-04 14:33:18 -05:00
Tim Graham
32b3961943
Added release date for 1.10.5.
2017-01-04 13:20:01 -05:00
Tim Graham
c85831e4b7
Fixed #27658 -- Prevented collectstatic from overwriting newer files in remote storages.
...
Thanks revimi for the initial patch.
2017-01-04 12:50:31 -05:00
anabelensc
1c12df4aa6
Fixed #25912 -- Added binary left/right shift operators to F expressions.
...
Thanks Mariusz Felisiak for review and MySQL advice.
2017-01-03 14:15:46 -05:00
Claude Paroz
2ebfda38e6
Fixed #25004 -- Updated OpenLayers-based widget to OpenLayers 3
...
Thanks Tim Graham for the review.
2017-01-02 19:45:52 +01:00
Tim Graham
f996f73667
Removed obsolete versionadded/changed annotations.
2017-01-02 10:38:54 -05:00
vinay karanam
6128c1736d
Refs #27637 -- Fixed timesince, timeuntil on New Year's Eve in a leap year.
2017-01-02 08:40:44 -05:00
Tim Graham
2b4bb78f79
Refs #24154 -- Added check_aggregate_support() to deprecation timeline.
2016-12-31 14:02:44 -05:00
Tim Graham
432b25ace0
Removed nonexistent LogoutView context from docs.
2016-12-31 07:57:39 -05:00
Tim Graham
e2335deeba
Removed links to deprecated GeoIP.
2016-12-30 19:13:49 -05:00
Mads Jensen
398a859642
Fixed #27652 -- Doc'd that intcomma works with floats.
2016-12-30 13:43:40 -05:00
Tim Graham
fae56427e1
Fixed #27649 -- Bumped required cx_Oracle to 5.2.
...
Removed obsolete workarounds from 1aa4889808
and dcf3be7a62
.
2016-12-29 12:45:25 -05:00
Adam Chainz
5eff8a7783
Fixed #25415 -- Made DiscoverRunner run system checks.
2016-12-29 12:33:24 -05:00
Adam Chainz
755406f5ff
Fixed #27641 -- Doc'd default local-memory caching in deployment checklist.
2016-12-28 19:43:01 -05:00
Shivang Bharadwaj
6a74950513
Fixed #27258 -- Prohibited django.Template.render() with non-dict context.
...
Thanks Shivang Bharadwaj for the initial patch.
2016-12-28 16:03:20 -05:00
Tim Graham
9e734875fe
Fixed #24994 -- Documented the expected type of settings.SECRET_KEY.
2016-12-28 07:36:37 -05:00
Preston Timmons
b52c73008a
Fixed #15667 -- Added template-based widget rendering.
...
Thanks Carl Meyer and Tim Graham for contributing to the patch.
2016-12-27 17:50:10 -05:00
Tim Graham
51cde873d9
Fixed #27648 -- Deprecated (iLmsu) regex groups in url() patterns.
2016-12-27 15:59:13 -05:00
Tim Graham
4701abd56e
Refs #27025 -- Documented Python 3.6 compatibility for Django 1.11.
2016-12-27 12:01:24 -05:00
Tim Graham
e2d02c1fc9
Used a nontemporal example in QuerySet.bulk_create() in docs.
2016-12-27 09:59:07 -05:00
Mariusz Felisiak
3e5c5e6754
Fixed #27637 -- Fixed timesince, timeuntil in leap year edge case.
2016-12-27 09:29:11 -05:00
Adam Chainz
8669cf0e68
Fixed #27626 -- Moved MEDIA_URL/STATIC_URL validation to a system check.
2016-12-23 10:55:00 -05:00
Adam Chainz
0a9bd266ff
Documented url()'s 'regex' parameter.
2016-12-22 19:16:26 -05:00
Tim Graham
61225ef721
Removed the importance of "core developers" in triaging tickets, etc.
2016-12-21 20:18:13 -05:00
jpic
bf6392bb75
Fixed #27600 -- Suppressed the REPL during shell's reading from stdin.
...
Thanks Adam Chainz for review and guidance.
2016-12-21 17:05:33 -05:00
Andrew Nester
24fa728a47
Fixed #27612 -- Added a check for duplicate URL instance namespaces.
2016-12-21 16:54:15 -05:00
Alix Martineau
0a8c685447
Fixed #27439 -- Documented macOS locale configuration for Django tests.
2016-12-20 12:58:14 -05:00
Tim Graham
5e239ae907
Fixed #27616 -- Fixed incorrect vary_on_headers() example.
2016-12-20 08:30:18 -05:00
Tim Graham
c27104a9c7
Fixed #27611 -- Doc'd that CSRF_COOKIE_HTTPONLY setting offers no security.
2016-12-19 17:56:58 -05:00
Henry Dang
6af23a4521
Fixed #27377 -- Clarified that prepopulated_fields doesn't work with OneToOneField.
2016-12-19 08:33:46 -05:00
Tim Graham
e2112a5e1a
Made cosmetic edits to the "What happens when you save?" docs.
2016-12-17 10:24:08 -05:00
Tim Graham
2f44fa7f06
Documented how to copy a OneToOneField.
...
Thanks Anton Gilgur for the report and review.
2016-12-17 08:39:52 -05:00
Tim Graham
8dac9890a5
Refs #25550 -- Removed a deprecated reverse assignment example in docs.
2016-12-17 08:39:52 -05:00
Sergey Fedoseev
4884472447
Fixed #27576 -- Made get_srid_info() fallback to GDAL if SpatialRefSys is unavailable.
2016-12-15 16:36:18 -05:00
Javier Rojas
8ab8a8910c
Doc'd how ModelAdmin.list_display uses short_description.
2016-12-15 15:57:04 -05:00
Sergey Fedoseev
986c7d522a
Fixed #27497 -- Improved support of geodetic coordinates on SpatiaLite.
...
Area function, Distance function, and distance lookups now work with
geodetic coordinates on SpatiaLite.
2016-12-15 15:31:07 -05:00
Sergey Fedoseev
38a6df555f
Fixed #27602 -- Added Oracle support for BoundingCircle GIS function.
2016-12-15 14:16:09 -05:00
Sergey Fedoseev
5a23cc00f5
Fixed #27607 -- Added Oracle support for AsGML GIS function.
2016-12-15 14:00:08 -05:00
Tim Graham
ebb85d1e79
Corrected docs claiming AsGML is supported on Oracle.
2016-12-15 13:01:00 -05:00
David Hoffman
bf84d042e0
Fixed #27582 -- Allowed HStoreField to store null values.
2016-12-15 10:35:44 -05:00
Ben Wilkins
9524fd9133
Fixed #25751 -- Doc'd how to use JavaScriptCatalog with i18n_patterns().
2016-12-15 10:30:14 -05:00
Waldemar Kornewald
b24af2f405
Fixed #27418 -- Fixed occasional missing plural forms in JavaScriptCatalog.
2016-12-14 18:20:30 -05:00
Michael Scott
1e629928e9
Fixed #27313 -- Allowed overriding admin popup response template.
2016-12-14 18:10:56 -05:00
Tim Graham
e5d3f98abc
Fixed missing versionadded/changed annotations on docs.djangoproject.com.
...
Fixed a regression in bacdfbf3d1
.
2016-12-14 14:31:29 -05:00
Perry Roper
3be2268992
Added Prefetch import to first use in QuerySet docs.
2016-12-14 13:54:29 -05:00
Tim Graham
92c5eeac33
Fixed #27598 -- Allowed specifying directories for a filesystem template loader.
...
Thanks Carl Meyer for review.
2016-12-14 10:33:51 -05:00
Tim Graham
2e9fa516fd
Fixed #27592 -- Doc'd that QueryDict iter methods are Python 2 only.
2016-12-14 07:29:21 -05:00
ntuckovic
4de8aaf7ff
Fixed #27355 -- Added “Creating extension using migrations” docs.
2016-12-08 13:15:21 -05:00
Yohann Gabory
47ef8f31f3
Fixed #13312 -- Allowed specifying the order of null fields in queries.
...
Thanks Mariusz Felisiak for finishing the patch.
2016-12-08 09:54:07 -05:00
Doug Harris
413216fb9f
Fixed #27566 -- Clarified overriding ModelAdmin.save_model()/delete_model() docs.
2016-12-08 08:21:59 -05:00
Tim Graham
b5f0b3478d
Fixed #27579 -- Added aliases for Python 3's assertion names in SimpleTestCase.
2016-12-07 17:42:31 -05:00
Vinay Karanam
4a246a02bd
Refs #17235 -- Made MultiPartParser leave request.POST immutable.
2016-12-07 08:28:46 -05:00
Andreas Pelme
373140b07a
Fixed #27567 -- Fixed crash in the debug view when request.user errors.
2016-12-06 12:28:00 -05:00
Sergey Fedoseev
d4822148d0
Fixed unrendered rows in GIS DB functions table in docs.
...
Cells in the first column must contain some text.
http://docutils.sourceforge.net/docs/dev/rst/problems.html#tables
2016-12-05 17:29:31 -05:00
Tim Graham
bacdfbf3d1
Removed deprecated html_translator_class sphinx config option.
2016-12-05 14:47:44 -05:00
Tim Graham
6d1394182d
Added stub release notes for 1.10.5.
2016-12-02 08:46:06 -05:00
Tim Graham
9ea9686532
Added release dates for 1.10.4, 1.9.12, 1.8.17.
2016-12-01 17:15:04 -05:00
Ed Morley
dd2e4d7b5d
Refs #27558 -- Added test for no index on InnoDB ForeignKey.
...
The refactor in 3f76d1402d
fixed the creation
of redundant indexes.
Forwardport of 82ce55dbbe
from stable/1.10.x
2016-12-01 13:25:48 -05:00
Tim Graham
e6262aaaf8
Refs #27358 -- Removed invalid/unneeded FileField.upload_to in tests/docs.
2016-11-30 17:05:31 -05:00
Simon Charette
ad8f6a45eb
Replaced RawSQL with Cast in Coalesce doc example.
2016-11-30 12:08:26 -05:00
Sergey Fedoseev
4464b9b9ad
Fixed #27556 -- Added Oracle support for IsValid function and isvalid lookup.
2016-11-30 11:22:56 -05:00
patjouk
bc6bd93cea
Added my bio.
2016-11-30 10:20:48 -05:00
Raphael Michel
ddf169cdac
Refs #16859 -- Allowed storing CSRF tokens in sessions.
...
Major thanks to Shai for helping to refactor the tests, and to
Shai, Tim, Florian, and others for extensive and helpful review.
2016-11-30 08:57:27 -05:00
Sergey Fedoseev
21322f9271
Fixed #27552 -- Added docs/test for GEOSGeometry.normalize().
2016-11-30 07:39:03 -05:00
Adam Chainz
71609a5b90
Fixed #27555 -- Removed django.utils.functional.lazy_property.
2016-11-29 19:01:12 -05:00
Adam Chainz
95627cb0aa
Added my bio
2016-11-29 22:42:29 +00:00
Henry Dang
7cddd8a02e
Fixed #27358 -- Added a system check to prevent FileField's upload_to from starting with a slash.
...
Thanks Frank Bijlsma for the initial patch.
2016-11-29 16:12:24 -05:00
Krzysztof Urbaniak
b8a815e9df
Fixed #27402 -- Fixed incorrect LocaleMiddleware redirects with prefix_default_language=False.
2016-11-29 13:06:35 -05:00
Andrew Nester
ade52ef71f
Fixed #27544 -- Fixed QuerySet.update(dt=F('dt') + timedelta) crash on SQLite.
2016-11-29 12:23:44 -05:00
Tim Graham
d7e6b8febd
Fixed typo in docs/topics/auth/customizing.txt.
2016-11-28 16:39:54 -05:00
Adam Chainz
95238a7de8
Fixed #27321 -- Added detection for table case name sensitivity on MySQL.
2016-11-28 13:29:21 -05:00
Mads Jensen
aa2cb4c622
Refs #26327 -- Renamed JsonAgg to JSONBAgg.
...
Thanks to Christian von Roques for the report.
2016-11-28 06:57:01 -05:00
Adam Chainz
6252fd6314
Fixed #27532 -- Deprecated Model._meta.has_auto_field
2016-11-25 13:24:11 -05:00
Aymeric Augustin
cb7bbf97a7
Fixed #25966 -- Made get_user_model() work at import time.
...
This makes it equivalent to: `from django.contrib.auth.models import User`.
Thanks Aymeric Augustin for the initial patch and Tim Graham for the
review.
2016-11-25 14:15:49 +01:00
Luke Murphy
c238da8942
Fixed #27509 -- Removed redundant gdal-bin dependency listing.
2016-11-25 07:19:10 -05:00
Daniel Musketa
df2a5227c9
Rephrased an ambiguous sentence in docs/topics/signals.txt.
2016-11-24 05:50:39 -05:00
Alex Scott
da4c0e8cc9
Fixed typo in docs/topics/auth/customizing.txt.
2016-11-24 05:41:21 -05:00
Tim Graham
93a081946d
Normalized casing of "custom user model".
2016-11-23 15:14:28 -05:00
Krzysztof Gogolewski
d02a03d574
Fixed #24370 -- Recommended starting with a custom user model.
2016-11-23 14:43:17 -05:00
Daniel Musketa
b5ef90192f
Fixed typo in docs/topics/signals.txt.
2016-11-23 06:54:58 -05:00
Jackie Leng
50613d957a
Fixed #26920 -- Made GEOSGeometry equality check consider the srid
2016-11-23 09:23:06 +01:00
Henry Dang
b1a9041535
Fixed #27221 -- Doc'd how to escape a percent symbol in ugettext().
2016-11-22 13:49:18 -05:00
Quentin Fulsher
f62abfc03d
Fixed #27295 -- Added a system check to prohibit model names that start or end with an underscore or contain double underscores.
2016-11-22 10:14:10 -05:00
Daniel Musketa
66505b72c5
Updated doc links to virtualenv website.
2016-11-22 08:36:41 -05:00
Tim Graham
55adfc0760
Fixed #27511 -- Corrected Field.related_model docs about GenericRelation.
2016-11-21 12:30:54 -05:00
François Freitag
0783aa7deb
Refs #23811 -- Corrected git bisect run example usage.
2016-11-21 06:55:03 -05:00
Jonatas CD
b28c6ca763
Fixed #27482 -- Doc'd an example of Case() in QuerySet.filter().
2016-11-17 12:39:35 -05:00
Tim Graham
0d9ff873d9
Fixed #27467 -- Made UserAttributeSimilarityValidator max_similarity=0/1 work as documented.
...
Thanks goblinJoel for the report and feedback.
2016-11-16 17:40:37 -05:00
Sergey Fedoseev
45e01df373
Fixed #27488 -- Added SpatiaLite suppport for IsValid, MakeValid, and __isvalid.
2016-11-16 09:43:54 -05:00
Tim Graham
3ce212a23c
Fixed #27494 -- Fixed typos in docs/topics/db/models.txt.
2016-11-16 07:28:20 -05:00
Mitchel Humpherys
ae660cde5a
Fixed incorrect word choice in docs/topics/migrations.txt.
2016-11-16 06:57:30 -05:00
Simon Charette
31a56e30cf
Fixed #27407 -- Made Model.delete(keep_parents=True) preserve parent reverse relationships.
...
Thanks Tim for the review.
2016-11-15 20:16:06 -05:00
akki
74ed20b49a
Replaced "django" with "Django" in spelling_wordlist.
2016-11-15 17:00:50 -05:00
Jonatas CD
9da45ff352
Fixed #26985 -- Doc'd that ForeignKey.to_field reference must be unique.
2016-11-15 11:09:23 -05:00
Simon Charette
9e4fd3301d
Refs #25284 -- Corrected an obsolete implicit __in lookup example.
...
Thanks IRC alias rpkilby for the report.
2016-11-15 08:25:02 -05:00
Ramin Farajpour Cami
0a63ef3f61
Fixed #27463 -- Fixed E741 flake8 warnings.
2016-11-14 17:40:28 -05:00
Claude Paroz
df3e92a41c
Documented GEOS 3.5 support
2016-11-12 17:42:12 +01:00
Claude Paroz
8c7778884b
Dropped support for GDAL 1.7 and 1.8
2016-11-12 17:28:03 +01:00
Jacob Rief
b3162cab94
Fixed #27386 -- Wrapped admin's readonly fields in <div> rather than <p>.
2016-11-12 10:02:57 -05:00
Jezeniel Zapanta
48f45431eb
Fixed typo in docs/topics/db/multi-db.txt.
2016-11-11 12:40:06 -05:00
Mads Jensen
1446902be4
Fixed #25240 -- Added ExtractWeek and exposed it through the __week lookup.
...
Thanks to Mariusz Felisiak and Tim Graham for review.
2016-11-11 08:01:40 -05:00
Daniel Wiesmann
2dc07da497
Fixed #27421 -- Added shape, size, and offset controls to GDALRaster constructor.
...
Thanks Tim Graham for the review.
2016-11-11 07:09:38 -05:00
Ian Lee
501c993010
Fixed typo in docs/ref/settings.txt.
2016-11-11 07:01:48 -05:00
za
321e94fa41
Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings.
2016-11-10 21:30:21 -05:00
Paweł Marczewski
50f9e736fa
Fixed #27438 -- Added the diffsettings --default option.
2016-11-10 07:50:49 -05:00
Joseph Kahn
373c6c409c
Fixed #27461 -- Fixed incorrect allow_migrate() arguments in makemigrations.
2016-11-09 10:27:19 -05:00
Tim Graham
0d6c7cae7c
Inlined a note in docs/ref/models/expressions.txt.
2016-11-09 08:20:59 -05:00
Jop Reyntjes
f8fab6f902
Fixed #27414 -- Doc'd that F() expressions on relations return pk values.
2016-11-09 07:11:46 -05:00
Mariusz Felisiak
c4b04e1598
Fixed #27420 -- Quoted the Oracle test user password in queries.
2016-11-08 16:30:22 -05:00
Tim Graham
ee1bf0e8b5
Corrected release note location of BaseCommand.can_import_settings removal.
2016-11-07 14:54:21 -05:00
Maxime Lorant
cb3fb34b86
Fixed #27378 -- Added support for serialization of uuid.UUID in migrations.
...
Thanks Yuriy Korobko for the initial patch and Tobias McNulty for review.
2016-11-06 13:53:00 +01:00
Tim Graham
7301770254
Fixed typo in docs/ref/middleware.txt.
2016-11-06 13:22:08 +01:00
Krzysztof Żuraw
eaa6ea2f37
Fixed #27133 -- Doc'd how to provide initial data with migrations.
2016-11-06 12:51:36 +01:00
Tobias McNulty
d9b65f6397
Added myself to the Ops team. ( #7518 )
2016-11-06 12:07:35 +01:00
Adam Malinowski
37809b891e
Fixed #27346 -- Stopped setting the Content-Length header in ConditionalGetMiddleware.
2016-11-05 22:24:54 +01:00
Krzysztof Gogolewski
d1dbaeaadb
Adjusted documentation of migration related commands.
2016-11-05 21:56:13 +01:00
Rivo Laks
802dd1ffc5
Readded 'pytz' to spelling wordlist.
2016-11-05 13:28:42 +01:00
Aymeric Augustin
24c9cce1c9
Removed myself from the ops team.
2016-11-05 12:47:59 +01:00
Tim Graham
b741fe397a
Updated "fork Django on GitHub" link.
2016-11-04 05:47:49 +01:00
Pamela McA'Nulty
2c4d15e319
Fixed typo in docs/topics/testing/tools.txt.
2016-11-04 05:12:42 +01:00
Tim Graham
58eca7c49c
Fixed #27425 -- Removed obsolete "developers for hire" FAQ.
2016-11-03 12:42:36 +01:00
Tim Graham
b8ae2c16cf
Added CVE-2016-9013,14 to the security release archive.
2016-11-01 10:48:11 -04:00
Tim Graham
7fe2d8d940
Fixed CVE-2016-9014 -- Validated Host header when DEBUG=True.
...
This is a security fix.
2016-11-01 09:30:57 -04:00
Marti Raudsepp
da7910d483
Fixed CVE-2016-9013 -- Generated a random database user password when running tests on Oracle.
...
This is a security fix.
2016-11-01 09:30:57 -04:00
Tim Graham
9e9c81d3c2
Added stub release notes for 1.9.11/1.8.16.
2016-11-01 09:30:57 -04:00
Andrew Nester
1ce04bcce0
Fixed #27363 -- Replaced unsafe redirect in SessionMiddleware with SuspiciousOperation.
2016-11-01 07:15:56 -04:00
Henry Dang
9c2e1ad6a5
Fixed #27400 -- Documented {% static %} encoding change in 1.10.
2016-10-31 16:07:00 -04:00
Timothy Allen
5595db9504
Updated docs/topics/db/queries.txt examples to use print() function.
2016-10-31 15:22:32 -04:00
Tim Graham
de91c172cf
Fixed #27410 -- Clarified when static files is enabled in STATIC_ROOT docs.
2016-10-31 15:17:40 -04:00
Mariusz Felisiak
55993d1e4e
Updated Oracle docs links to Oracle 12c.
2016-10-31 14:32:50 -04:00
Krzysztof Urbaniak
a01d887a3a
Fixed #27063 -- Prevented i18n_patterns() from using too much of the URL as the language.
2016-10-31 14:32:01 -04:00
Anssi Kääriäinen
9513903086
Updated by bio.
2016-10-31 09:55:48 -04:00
medmunds
d3708aeb26
Fixed #27382 -- Doc'd that ugettext_lazy() should be converted to text for non-Django code.
2016-10-29 07:23:57 -04:00
Michael Scott
ec9ed07488
Fixed #27188 -- Allowed using unique=True with FileField.
...
Thanks Tim Graham for the initial patch.
2016-10-28 20:11:03 -04:00
Aymeric Augustin
625cd5bcb3
Added require_ready argument to get_model methods.
...
This allows bringing back the behavior of Django < 1.7.
Also fixed the check for the app registry being ready in
AppConfig.get_model(s), which was inconsistent with the equivalent check in
Apps.get_model(s). That part is a backwards-incompatible change.
2016-10-28 19:08:57 -04:00
Aymeric Augustin
efcb7e1ebf
Modified readiness check in AppConfig.get_model(s).
...
It was inconsistent with the equivalent check in Apps.get_model(s)
because I made incorrect assumptions when I wrote that code and
needlessly complicated readiness checks.
This is a backwards-incompatible change.
2016-10-28 18:42:29 -04:00
Adam Chainz
968f61b991
Documented that cache keys are strings rather than bytes.
2016-10-27 15:49:24 -04:00
mark-summerfield
4584bc3a1e
Described PostgreSQL as more scalable than SQLite.
2016-10-27 09:14:04 -04:00
Tim Graham
414ad25b09
Fixed #27327 -- Simplified time zone handling by requiring pytz.
2016-10-27 08:53:20 -04:00
Tim Graham
d84ffcc22b
Updated "running the tests" to use 'pip install -e'.
2016-10-27 08:18:56 -04:00
Jon Dufresne
c74378bb77
Fixed #27299 -- Documented the Widget.use_required_attribute() method.
...
Thanks Tim Graham for the review and edits.
2016-10-26 19:29:16 -07:00
Thomas Güttler
7cdc2015e3
Clarified when the post_migrate signal is sent during migrate.
2016-10-26 11:01:04 -04:00
Jon Dufresne
f3ea0c4bbd
Reverted "Fixed #26401 -- Added BaseAuthConfig to use auth without migrations."
...
This reverts commit 1ec1633cb2
as it
doesn't handle ContentType's auth.Permission dependency. Thus, it
doesn't allow auth without migrations.
2016-10-25 17:32:59 -07:00
David Barragán Merino
b3bd3aa07c
Fixed #27385 -- Fixed QuerySet.bulk_create() on PostgreSQL when the number of objects is a multiple plus one of batch_size.
2016-10-25 19:21:08 -04:00
Tim Graham
a9d1d95284
Replaced Outputting PDF's "Further Resources" with a link to Django Packages.
2016-10-25 11:58:19 -04:00
Marti Raudsepp
51fbe2a60d
Updated postgresql.org links to https and made them canonical.
2016-10-25 11:43:32 -04:00
Julian Andrews
adc93e8599
Fixed #26357 -- Allowed admin popups to work on links added after page load.
2016-10-24 20:17:31 -04:00
Tim Graham
6fdb12cdcc
Documented how to request CVE IDs.
2016-10-24 15:02:55 -04:00
Alvin Lindstam
6b5106b1ce
Fixed #27374 -- Made JavaScriptCatalog respect the packages argument.
2016-10-22 19:26:08 -04:00
Zach Borboa
90c3b11e87
Fixed #27361 -- Used "from django import forms" in forms api docs.
2016-10-19 09:55:21 -04:00
Markus Holtermann
b5fc192b99
Fixed #27352 -- Doc'd social media fingerprinting consideration with login's redirect_authenticated_user.
2016-10-18 11:37:56 -04:00
Riccardo Magliocchetti
a4e9e834e3
Fixed ModelAdmin.get_max_num() example if obj is None.
2016-10-17 07:33:38 -04:00
Tim Graham
af98a0a25e
Updated security policy according to current practices.
...
Also added security release date notifications to django-announce.
2016-10-15 07:53:08 -04:00
David D Lowe
424187ec4b
Fixed #27349 -- Doc'd the CSRF_FAILURE_VIEW setting in view topic guide.
2016-10-14 13:46:54 -04:00
Tim Graham
61f9243e51
Fixed #27345 -- Stopped setting the Date header in ConditionalGetMiddleware.
2016-10-14 12:48:03 -04:00
Kevin Christopher Henry
9eb49af821
Refs #19705 -- Documented decorator ordering with @condition().
2016-10-14 07:36:01 -04:00
Kevin Christopher Henry
ad332e5ca9
Refs #19705 -- Made GZipMiddleware make ETags weak.
...
Django's conditional request processing can now produce 304 Not Modified
responses for content that is subject to compression.
2016-10-13 14:22:54 -04:00
Tim Graham
cd09524f27
Fixed #27200 -- Provided makemigration's allow_migrate() with model_name.
2016-10-13 11:04:58 -04:00
Tim Graham
51b83d9e51
Fixed #27342 -- Corrected QuerySet.update_or_create() example.
2016-10-13 11:02:02 -04:00
Nick Pope
81463ce0a1
Fixed typo in docs/ref/checks.txt.
2016-10-11 10:32:32 -04:00
Tim Graham
80f5a4d87a
Doc'd the need to provide initial for formset submissions.
2016-10-10 15:36:21 -04:00
Denis Cornehl
a840710e1e
Fixed #26447 -- Deprecated settings.USE_ETAGS in favor of ConditionalGetMiddleware.
2016-10-10 14:55:59 -04:00
Tim Graham
19a140a1b3
Added template syntax highlighting in docs/topics/i18n/timezones.txt.
2016-10-08 08:07:06 -04:00
Zach Borboa
bf91be83d5
Fixed #24941 -- Added ModelAdmin.get_exclude().
...
Thanks Ola Sitarska for the initial patch.
2016-10-07 18:49:28 -04:00
Tim Graham
c60feb6999
Fixed #25475 -- Doc'd how to use a literal % in Func.template.
2016-10-07 10:24:45 -04:00
Markus Holtermann
f8deed7199
Updated security team roster.
2016-10-07 10:14:22 -04:00
Adam Chainz
224fe22bf1
Doc'd that model instances with pk=None don't compare equal.
2016-10-07 09:01:18 -04:00
Mads Jensen
0a26f3c338
Fixed #26327 -- Added JsonAgg to contrib.postgres.
...
Thanks Tim Graham for review.
2016-10-07 07:52:03 -04:00
Tim Graham
e261337eea
Fixed docs typos in lines ending with a dash.
2016-10-06 11:01:20 -04:00
Aymeric Augustin
5d35181de4
Documented AppRegistryNotReady.
2016-10-06 10:21:57 -04:00
Jonatas CD
e8728f03f0
Refs #11078 -- Doc'd Meta inheritance in proxy models.
2016-10-04 19:53:24 -04:00
Corey Farwell
24da355686
Documented render_to_string()'s `using` parameter.
2016-10-04 18:58:50 -04:00
Tim Graham
0083a4c8e9
Refs #18974 -- Deprecated @models.permalink() decorator.
2016-10-04 14:39:49 -04:00
Tim Graham
e262f00231
Fixed #27292 -- Removed unnecessary password assignment in auth backend example.
2016-10-04 14:02:06 -04:00
aruseni
9e26a8331d
Fixed typos in docs/ref/contrib/admin/javascript.txt.
2016-10-04 10:18:08 -04:00
aruseni
12b9aa279f
Fixed typo in docs/ref/contrib/admin/javascript.txt.
2016-10-04 10:13:10 -04:00
Simon Charette
040bd7c938
Fixed #27279 -- Fixed a migration performance regression related to RenameModel operations.
...
Thanks Trac alias mtomiyoshi for the report, Marten Kenbeek for the initial
patch and Tim for the review.
2016-10-04 08:35:15 -04:00
Reto Aebersold
3ab55c1a8a
Fixed #27309 -- Added CallableBool.__hash__().
2016-10-04 07:44:19 -04:00
Tim Graham
fe1aee6b98
Fixed #27307 -- Added missing url names in sitemaps docs.
2016-10-03 16:04:30 -04:00
Claude Paroz
122c90a43b
Fixed #27305 -- Removed BaseCommand.can_import_settings unused attribute
...
Thanks Tim Graham for the review.
2016-10-02 20:31:56 +02:00
Tim Graham
bae1160c3f
Added stub release notes for 1.10.3.
2016-10-01 16:11:54 -04:00
Claude Paroz
67eee5e4fa
Fixed #27302 -- Fixed ModelAdmin.construct_change_message() changed field detection
...
Thanks Ramiro Morales for the report and Tim Graham for the review.
2016-10-01 20:14:27 +02:00
Tim Graham
aa7dc2dc39
Added release date for 1.10.2.
2016-10-01 11:48:11 -04:00
Claude Paroz
fa2f55cfd5
Refs #26940 -- Re-allowed makemessages without settings
...
Thanks Tim Graham for the review.
2016-10-01 14:57:16 +02:00
Tim Graham
87c5e7efeb
Refs #27186 -- Fixed model form default fallback for CheckboxSelectMultiple.
2016-09-30 14:49:50 -04:00
Lewis Cowles
1d25eb9688
Fixed #27294 -- Documented UserCreationForm's fields.
2016-09-30 13:56:53 -04:00
Tim Graham
79c91070e5
Confirmed support for PostGIS 2.3.
2016-09-30 10:00:04 -04:00
Tim Graham
cc282fa731
Updated links to the current version of PostGIS docs.
2016-09-30 09:26:20 -04:00
Tim Graham
9819676676
Updated links to the current version of MySQL docs.
2016-09-30 09:14:17 -04:00
Laurent
bceade84a7
Fixed typos in docs/howto/deployment/checklist.txt.
2016-09-29 19:59:00 -04:00
Tim Graham
eb4d4376fc
Normalized spelling of "Web server/page" in docs.
2016-09-29 19:51:59 -04:00
Frank Wiles
a09c058918
Fixed import typos in the docs.
2016-09-29 12:06:52 -04:00
Christian Bundy
9c522d2ed8
Fixed typo in docs/ref/contrib/gis/install/postgis.txt.
2016-09-28 14:24:49 -04:00
Tim Graham
f2ff1b2fab
Fixed #27289 -- Corrected View.as_view() explanation.
...
Thanks Graham Wideman for the report.
2016-09-28 11:26:32 -04:00
Rinat Khabibiev
9e07a9b5fe
Fixed #27226 -- Removed patch_response_headers()'s setting of the Last-Modified header.
2016-09-28 09:09:09 -04:00
Alasdair Nicol
3203171832
Fixed 27283 -- Fixed typo in 1.8 release notes.
2016-09-28 06:50:49 -04:00
Austin Simmons
0f6829a68a
Fixed #27076 -- Documented contrib.admin.sites.AdminSite.register().
2016-09-27 12:16:44 -04:00
levental
617e36dc1e
Fixed #20705 -- Allowed using PasswordResetForm with user models with an email field not named 'email'.
2016-09-27 11:59:00 -04:00
Berker Peksag
f7e91cac68
Fixed #27053 -- Documented contrib.auth.get_user().
2016-09-27 10:41:14 -04:00
Sergey Fursov
6709ea4ae9
Fixed #27271 -- Fixed a crash in runserver logging.
...
Allowed ServerFormatter to handle simple string messages or messages with
formatting arguments. The formatter will set the server_time variable on
the log record if it's required by the format string but wasn't passed in
extra parameters.
2016-09-27 09:46:07 -04:00
Tim Graham
6fe846a8f0
Added CVE-2016-7401 to the security release archive.
2016-09-26 18:01:19 -04:00
Tim Graham
a46742e738
Added a CVE role for Sphinx.
2016-09-26 15:48:40 -04:00
Tim Graham
8d233a2132
Fixed #27278 -- Fixed an anchor in docs/topics/forms/formsets.txt.
2016-09-26 13:55:39 -04:00
Tim Graham
c6a3109e20
Added release notes for 1.9.10 and 1.8.15 releases.
2016-09-26 13:55:21 -04:00
Jonatas CD
6d6d1b1001
Fixed #27276 -- Doc'd how to reverse admin's login view.
2016-09-26 10:38:34 -04:00
Tim Graham
8110673aaf
Fixed #27270 -- Clarified a paragraph in docs/topics/forms/formsets.txt.
...
Thanks Kifsif for the suggestion.
2016-09-26 09:54:55 -04:00
François Freitag
a5e13a0b92
Fixed #27118 -- Made QuerySet.get_or_create()/update_or_create() error for a non-field in their arguments.
2016-09-24 20:16:16 -04:00
Berker Peksag
0a6ed6b1d9
Simplified has_perm() example in topics/auth/customizing.txt.
2016-09-23 15:28:32 -04:00
Tim Graham
3507d4e773
Fixed #27186 -- Fixed model form default fallback for MultiWidget, FileInput, SplitDateTimeWidget, SelectDateWidget, and SplitArrayWidget.
...
Thanks Matt Westcott for the review.
2016-09-22 12:20:58 -04:00
Claude Paroz
92323d54fd
Fixed #27056 -- Allowed migrating geometry field dimension on PostGIS
...
Thanks Tim Graham for the review.
2016-09-22 16:40:27 +02:00
Jon Dufresne
2c716c1dc7
Fixed #27256 -- Changed Select widget's selected attribute to use HTML5 boolean syntax.
2016-09-21 15:12:13 -07:00
Tim Graham
ddef397b0d
Doc'd how to use GitHub's "Squash and merge" button.
2016-09-21 12:13:21 -04:00
Mads Jensen
094d630ae8
Fixed #26610 -- Added CITextField to contrib.postgres.
2016-09-21 12:11:37 -04:00
Markus Holtermann
7eda99f03f
Added myself to ops team ( #7273 )
2016-09-21 09:42:00 +02:00
Alasdair Nicol
911d9f4ed1
Fixed #27238 -- Disabled check_pattern_startswith_slash if settings.APPEND_SLASH=False.
...
Thanks strycore for the report and timgraham for suggesting the
solution.
2016-09-19 21:00:12 -04:00
aruseni
cdde2eac5b
Fixed a typo in docs/topics/auth/default.txt.
2016-09-17 20:09:15 -04:00
zhuanyenan
17677d510f
Corrected docs for return type of Field.formfield().
2016-09-17 14:26:54 -04:00
Kevin Christopher Henry
22e303887b
Refs #27083 -- Updated conditional header comparison to match RFC 7232.
2016-09-16 15:45:53 -04:00
Tim Graham
5a51b44936
Fixed #26697 -- Removed contrib.gis.maps.
2016-09-16 15:21:46 -04:00
Tim Graham
43c471e81c
Fixed typo in docs/ref/settings.txt.
2016-09-15 19:52:49 -04:00
Michael Scott
3c447b108a
Fixed #15143 -- Doc'd how to set the language for the test client.
2016-09-14 20:08:06 -04:00
Gavin Wahl
f0f3de3c96
Fixed #23155 -- Added request argument to user_login_failed signal.
2016-09-12 20:30:34 -04:00
Aleksej Manaev
4b9330ccc0
Fixed #25187 -- Made request available in authentication backends.
2016-09-12 20:11:53 -04:00
Tim Graham
c2e94bd8df
Fixed #27212 -- Fixed typo in docs/howto/static-files/index.txt.
2016-09-12 16:05:27 -04:00
Simon Charette
767ba00976
Fixed #27209 -- Fixed typo in docs/ref/models/database-functions.txt.
...
Thanks Valentin Ignatyev for the report.
2016-09-12 08:07:30 -04:00
Claude Paroz
d389125606
Fixed #27098 -- Deprecated DatabaseIntrospection.get_indexes
...
Thanks Akshesh <aksheshdoshi@gmail.com> for help with the PostgreSQL query.
Thanks Tim Graham for the review.
2016-09-12 09:26:33 +02:00
Jon Dufresne
1ec1633cb2
Fixed #26401 -- Added BaseAuthConfig to use auth without migrations.
2016-09-10 16:38:05 -07:00
Alexander Gaevsky
536db42cf0
Fixed #26097 -- Added password_validators_help_text_html to UserCreationForm.
2016-09-10 18:23:18 -04:00
Alexander Gaevsky
2d26b4637f
Fixed #27207 -- Replaced <p> tag with <div> in admin help texts.
2016-09-10 16:54:10 -04:00
Kevin Christopher Henry
4ef0e019b7
Fixed #27083 -- Added support for weak ETags.
2016-09-10 08:14:52 -04:00
Tim Graham
ef021412d5
Normalized spelling of ETag.
2016-09-09 11:00:21 -04:00
Rinat Khabibiev
ca9c69a968
Fixed #27199 -- Made AdminIntegerFieldWidget use NumberInput.
2016-09-09 09:42:39 -04:00
Jon Dufresne
331ca5391e
Fixed #27175 -- Deprecated silencing exceptions from the {% include %} template tag.
...
Thanks Tim Graham for the review.
2016-09-08 18:24:22 -07:00
Jon Dufresne
66e1ebbffc
Fixed #26956 -- Added success_url_allowed_hosts to LoginView and LogoutView.
...
Allows specifying additional hosts to redirect after login and log out.
2016-09-07 19:56:25 -07:00
Jon Dufresne
f227b8d15d
Refs #26956 -- Allowed is_safe_url() to validate against multiple hosts
2016-09-07 19:56:25 -07:00
Nicola Jordan
978a00e39f
Fixed #27143 -- Allowed combining SearchQuery with more than one & or | operators.
2016-09-07 15:26:52 -04:00
Ankur Gupta
40d5011471
Fixed #27174 -- Explained where PollsConfig comes from in tutorial 2.
2016-09-07 14:12:53 -04:00
Markus Gerards
2b64ff68cc
Fixed #27180 -- Fixed a crash in MySQL checks where SELECT @@sql_mode doesn't return a result.
2016-09-07 11:15:41 -04:00
Chris Jerdonek
ccf7adb064
Fixed #27172 -- Closed database cursor explicitly in two doc examples
2016-09-07 12:14:29 +02:00
Tim Graham
6a2af01452
Fixed #24865 -- Added remove_stale_contenttypes management command.
...
Thanks Simon Charette for the review.
2016-09-06 09:48:58 -04:00
Tim Graham
277fe2e8f2
Fixed #25788 -- Enabled the cached template loader if debug is False.
2016-09-03 09:06:33 -04:00
Claude Paroz
2ced2f785d
Replaced smart_* by force_* calls whenever possible
...
The smart_* version should only be used when a lazy string should keep
its lazy status.
2016-09-03 13:46:41 +02:00
Daniel Hahler
b1d6b0a7b1
Fixed #26098 -- Used cdnjs.cloudflare for OpenLayers.js.
2016-09-03 06:52:25 -04:00
Tim Graham
5bd967e1c5
Doc'd how to remove old references in migration files.
2016-09-02 09:59:40 -04:00
Jeff Willette
bd3dc670b5
Fixed #27099 -- Documented list filter's has_output() method.
2016-09-02 09:41:13 -04:00
Shai Berger
c93ac9cf42
Refs #25850 , #27142 , #27110 -- Documented migration history consistency checks.
2016-09-01 18:49:10 -04:00
Tim Graham
de7f9758ac
Added stub release notes for 1.10.2.
2016-09-01 16:27:45 -04:00
Tim Graham
894df3e327
Added release date for 1.10.1.
2016-09-01 16:24:46 -04:00
Tim Graham
098c07a032
Fixed #27142 , #27110 -- Made makemigrations consistency checks respect database routers.
...
Partially reverted refs #27054 except for one of the tests as this
solution supersedes that one.
Thanks Shai Berger for the review.
2016-09-01 16:19:29 -04:00