innov
/
django1
1
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity
18,949 Commits 25 Branches 361 Tags 501 MiB
Commit Graph

5949 Commits

Author SHA1 Message Date
Loic Bistuer eb82fb0a9d Refactored color_style() and no_style() to improve testability. Refs #23663. 
This includes the following improvements:

- The type of the style object is now called 'Style' rather than 'dummy'.
- The new make_style() function allows generating a Style object directly
  from a config string. Before the only way to get a style object was
  through the environ and it also required that the terminal supported
  colors which isn't necessarily the case when testing.
- The output of no_style() is now cached with @lru_cache.
- The output of no_style() now has the same set of attributes as the
  other Style objects. Previously it allowed anything to pass through
  with __getattr__.
 2014-10-22 11:27:00 +07:00
Loic Bistuer bdb4118b1a Fixed #23686 -- Tweak color output of the system check framework. 
Thanks Tim Graham for the review.
 2014-10-22 11:27:00 +07:00
Loic Bistuer 494ba051bb Made testing of stdout and stderr more consistent. 
Refs #23663.
 2014-10-22 09:25:50 +07:00
Loic Bistuer 533532302a Fixed #23663 -- Initialize output streams for BaseCommand in __init__(). 
This helps with testability of management commands.

Thanks to trac username daveoncode for the report and to
Tim Graham and Claude Paroz for the reviews.
 2014-10-22 09:25:50 +07:00
Tim Graham 494cd857c8 Fixed #23653 -- Fixed Windows failure of a logging test added in refs #23569. 2014-10-21 18:32:46 -04:00
Claude Paroz bbc3505ef8 Removed unneeded override_system_checks 
Refs #23685.
 2014-10-21 20:54:32 +02:00
Claude Paroz 8b4cc9df9c Fixed #23583 -- More selectively ignored static/media roots 
Fixed a regression introduced by 28efafa24c.
Thanks Michal Čihař for the report and initial patch, and
Collin Anderson and Tim Graham for the reviews.
 2014-10-21 20:18:21 +02:00
Loic Bistuer c34e13e17c Fixed #23107 -- Made runserver output respect --no-color. 
This commit reverts 67d7da5fb9.

The previous fix changed the environment globally, which meant
that any call to `call_command(no_color=True)` prevented further
`call_command` with color.

This fix still relies on the environment because it's currently the only
way to reach WSGIRequestHandler, but it's now limited to the `runserver`
command. This seems an acceptable compromise considering `runserver` runs
indefinitely.

Thanks Tim Graham for the review.
 2014-10-22 01:03:15 +07:00
Anton Novosyolov 9f1202c166 Fixed #23695 -- Made condition decorator work for HEAD requests without ETag. 2014-10-21 11:13:29 -04:00
Gabe Jackson 0e16c3e3cd Fixed #23396 -- Ensured ValueQuerySets are not checked by check_related_objects. 2014-10-21 10:02:51 -04:00
Claude Paroz f0bb3c98cc Fixed #21740 -- Allowed test client data to be an empty string 
This fixes a regression introduced by 2a31d00933.
Thanks tony-zhu for the report.
 2014-10-21 09:16:57 +02:00
Michael Manfre edcb33c92e Fix SettingsCustomLoggingTest on Windows when path contains \u 2014-10-20 21:49:44 -04:00
John-Scott Atlakson dbf7a3df45 Fixed #23688 -- Updated cached_property to preserve docstring of original function 2014-10-20 17:59:07 -04:00
Jon Dufresne 54e695331b Fixed #20221 -- Allowed some functions that use mark_safe() to result in SafeText. 
Thanks Baptiste Mispelon for the report.
 2014-10-20 17:08:29 -04:00
Claude Paroz 4fe6824ffd Fixed #23679 -- Fixed null introspection for char/text fields 
Thanks Paul Dejean for the report.
 2014-10-20 22:37:19 +02:00
Tianyi Wang 5732424bee Fixed #23629 -- Allowed autodetector to detect changes in Meta.db_table. 
Thanks Naddiseo for reporting.
 2014-10-20 13:14:44 -04:00
Claude Paroz 6d11bb102d Revert "Fixed #23650 -- Prevented migrate from calling checks 3 times" 
This reverts commit 8d6e1afe0b.
call_command now always set skip_checks to True (tested in
user_commands).
 2014-10-20 17:26:00 +02:00
Claude Paroz 685edab9da Fixed #23685 -- Made call_command skip checks by default 
Thanks Loic Bistuer for the report/review and Tim Graham for the
review.
 2014-10-20 17:26:00 +02:00
Loic Bistuer 968510e5d7 Moved a test case that caused deprecation warnings. 
`cache.tests.TestEtagWithAdmin` loaded views from the `admin_views` test
package. This is problematic because when the `cache` test package is
run in isolation, `admin_views` isn't in INSTALLED_APPS, and therefore
loading its models isn't allowed since the app loading refactor.
 2014-10-20 00:22:48 +07:00
Nicholas Serra 6c79d32977 Fixed #23684 -- Used correct package name for Pillow in Error hint. 2014-10-19 13:46:46 +07:00
Thomas Chaumeny 825ea83858 Fixed #21196 -- Removed index on test field causing MySQL specific warning. 2014-10-19 13:44:39 +07:00
Claude Paroz 8d6e1afe0b Fixed #23650 -- Prevented migrate from calling checks 3 times 
Thanks Ilya Baryshev for the report and Tim Graham for the review.
 2014-10-17 20:20:56 +02:00
Tim Graham 7ae03204ac Fixed #23469 -- Removed test runner compatibility check which often yielded false positives. 2014-10-17 10:31:49 -04:00
Rigel Di Scala a5c77417a6 Fixed #23615 -- Validate that a Model instance's "check" attribute is a method. 
The "check" name is a reserved word used by Django's check framework,
and cannot be redefined as something else other than a method, or the check
framework will raise an error.

This change amends the django.core.checks.model_check.check_all_models()
function, so that it verifies that a model instance's attribute "check"
is actually a method. This new check is assigned the id "models.E020".
 2014-10-16 23:49:21 +07:00
Loic Bistuer 157f9cf240 Minor cleanup in the check_framework test package. 2014-10-16 23:49:21 +07:00
Thomas Chaumeny b962653060 Fixed #23664 -- Provided a consistent definition for OrderedSet.__bool__ 
This also defines QuerySet.__bool__ for consistency though this should not have any consequence as bool(qs) used to fallback on QuerySet.__len__ in Py3.
 2014-10-16 14:16:24 +02:00
Claude Paroz 374c14b7fd Fixed #23659 -- Kept annotate() args ordering 
Thanks Loic Bistuer and Simon Charette for the review.
 2014-10-16 09:27:20 +02:00
Simon Charette f6c208d95c Fixed a flake8 warning. 2014-10-15 16:36:11 -04:00
Collin Anderson a6a8268d19 Fixed #23660 -- Moved sort_dependencies to core. 2014-10-16 03:04:13 +07:00
Anubhav Joshi 10b17a22be Fixed #19508 -- Implemented uri_to_iri as per RFC. 
Thanks Loic Bistuer for helping in shaping the patch and Claude Paroz
for the review.
 2014-10-16 02:31:17 +07:00
Florian Apolloner 3af5af1a61 Fixed remaining test failure in jslex tests. 2014-10-15 17:36:19 +02:00
Florian Apolloner 2ccbaba1f2 Added unicode_literals to the jslexer. 
This ensure that ''.join(c) in jslex.py always returns text.
 2014-10-15 15:09:35 +02:00
Claude Paroz 7a893ee771 Fixed #23651 -- Isolated non-existent fixture tests 
Previous versions of the tests were buggy, as initial_data.json
did exist and the test wasn't failing. It was finally failing on
Python 3.4.2.
Thanks Raphaël Hertzog for the report (and Debian bug #765117
contributors).
 2014-10-15 09:17:44 +02:00
Claude Paroz 7131efa154 Adapted invalid cookie test to all Python versions 
Refs #23638. Older Python versions are less strict when parsing
invalid cookie content. The test just has to ensure Django doesn't
crash.
 2014-10-14 09:30:26 +02:00
Claude Paroz 59d487e7fc Fixed #23638 -- Prevented crash while parsing invalid cookie content 
Thanks Philip Gatt for the report and Tim Graham for the review.
 2014-10-13 17:37:58 +02:00
Florian Apolloner 8d789449c7 Fixed #23063 -- Convert \n and \r to \r\n when using the SMTP backend as per RFC. 2014-10-12 22:01:24 +02:00
Konrad Świat 06b11b617e Fixed #23616 - Fixed generic relations in ModelAdmin.list_filter. 
Thanks ranjur for reporting bug, timgraham for review,
and collinanderson for contributing tips.
 2014-10-10 12:10:32 -04:00
Jaap Roes 115c307184 Fixed #23613 -- Deprecated django.utils.checksums 2014-10-10 09:22:20 -04:00
Collin Anderson 4ef9618e12 Avoided requiring sqlparse for a test. 
Refs #23426. Thanks Markus Holtermann for the suggestion.
 2014-10-09 14:59:33 -04:00
Brandon Taylor 16ed35fafc Fixed #23612 -- Normalized fixuture paths to allow referencing relative paths on Windows. 2014-10-09 14:58:20 -04:00
Marc Tamlyn 92a17eaae0 Fixed #23627 -- Allowed register_lookup to work as a decorator. 2014-10-09 18:44:58 +01:00
Collin Anderson d6a87eefd8 Skip another test if sqlparse is not available 
Refs #23426
 2014-10-09 11:54:42 -04:00
Markus Holtermann f633ba778d Fixed #23609 -- Fixed IntegrityError that prevented altering a NULL column into a NOT NULL one due to existing rows 
Thanks to Simon Charette, Loic Bistuer and Tim Graham for the review.
 2014-10-09 21:32:06 +07:00
Tim Graham 30b44cea38 Fixed flake8 warning. 2014-10-08 18:10:50 -04:00
Duncan Parkes 88b6cf4ae4 Fixed #23600 -- Made default_storage aware of more settings changes. 
Added MEDIA_URL, FILE_UPLOAD_PERMISSIONS, and
FILE_UPLOAD_DIRECTORY_PERMISSIONS to the list of settings.
 2014-10-08 18:10:47 -04:00
Artem Rizhov ca61195827 Fixed #23555 -- Avoided suppressing IndexError in QuerySet.first() and .last() 2014-10-08 14:28:38 -04:00
Loic Bistuer 0eccf8fbea Fixed misplaced test case. 2014-10-08 05:11:09 +07:00
Loic Bistuer ed37f7e979 Fixed #23611 -- update_or_create failing from a related manager 
Added update_or_create to RelatedManager, ManyRelatedManager and
GenericRelatedObjectManager.
Added missing get_or_create to GenericRelatedObjectManager.
 2014-10-08 03:27:31 +07:00
Jon Dufresne c1ef234e31 Fixed #23522 -- Changed reverse() to return a Unicode string; not bytes 2014-10-07 13:06:39 -04:00
Browniebroke d1e87aebf7 Refactored model lookup tests; refs #18586. 2014-10-07 12:04:56 -04:00