a2814846ca
Fixed E124 pep8 warnings.
2013-12-10 15:12:48 -05:00
e2e2482391
Renamed first argument of class method to cls
2013-12-07 20:13:53 -05:00
5c61b8519d
Fixed #18531 -- Deprecated Geo Sitemaps
...
I've chosen a quick deprecation path, as Geo Sitemaps themselves
are deprecated from some time now.
2013-12-07 21:46:03 +01:00
65faa84de3
Removed unneeded string normalization in contrib.admin
...
With Python 2.7 and up, named parameter keys are not limited to
bytestrings any longer. This mainly reverts 3bd384aa62
2013-12-07 15:58:27 +01:00
362dd68fb2
Added new 'srtext' spatialite 4.x SpatialRefSys column to its model.
...
This is for general consistency in the GeoDjango DB backends.
Thanks Claude for the fix.
Refs #19678 .
2013-12-06 12:35:18 -03:00
9a73e7f40c
Fixed #19678 -- GeoDjango test failure with spatialite >= 3.0.
...
Thanks Julien for the report and Claude for the fix.
2013-12-06 08:51:45 -03:00
482ca0cecc
Renamed syncdb to migrate in spatialite backend
2013-12-06 10:00:09 +01:00
e36c165b14
Corrected setting name in gis test error message.
2013-12-05 18:22:37 -03:00
ae734b75c1
Removed 'return' in __init__
2013-12-05 07:09:36 -05:00
b8be3055f1
Fixed #21543 -- Removed base_dir attribute in StaticFilesHandler.
...
This code seems to be an artifact of AdminMediaHandler removed in [5c53e30607
2013-12-01 18:03:59 -05:00
fddb0131d3
Fixed #21535 -- Fixed password hash iteration upgrade.
...
Thanks jared_mess for the report.
2013-11-30 14:18:37 -05:00
f3e7ab366c
Removed gender-based pronouns per [ c0a2daad78].
2013-11-30 08:37:15 -05:00
9af7e18f35
Fixed an unescisarily gendered pronoun in a docstring
2013-11-29 16:57:36 -06:00
7e2d61a972
Fixed #21380 -- Added a way to set different permission for static directories.
...
Previously when collecting static files, the directories would receive permissions
from the global umask. Now the default permission comes from FILE_UPLOAD_DIRECTORY_PERMISSIONS
and there's an option to specify the permissions by subclassing any of the
static files storage classes and setting the directory_permissions_mode parameter.
2013-11-29 08:01:30 -05:00
34b8a38558
Fixed #21496 -- Fixed crash when GeometryField uses TextInput
...
Thanks Rhett Garber for the report and initial patch.
2013-11-28 18:29:02 +01:00
7477a4ffde
Fixed E125 pep8 warnings
2013-11-28 08:50:11 -05:00
a5b94d9d4e
A handle of flake8 fixes
2013-11-27 16:42:39 -06:00
f450bc9f44
Added a bulk option to RelatedManager remove() and clear() methods
...
Refs #21169
2013-11-27 19:45:22 +02:00
eece3c224e
PostGIS schema editor support
2013-11-27 13:32:12 +00:00
4fcfc31865
Add gis deconstruct() method (this does not make schema work)
2013-11-27 12:56:33 +00:00
c74504c2dd
Fixed #20522 - Allowed use of partially validated object in ModelAdmin.add_view formset validation.
...
Updated ModelAdmin to use form.instance when passing parent model to
child inlines for add_view. There is effectively no change in the
change_view since the previously passed 'obj' is the same as form.instance.
Thanks to meshy for report, and EvilDMP and timo for review.
2013-11-25 20:01:16 -05:00
17912522ce
Fixed #21504 -- Don't shadow database errors when testing for postgis version.
...
Thanks to trac user paultag for the report.
2013-11-24 14:34:43 +01:00
1e97058417
Fixes #21412 -- Better error message for messages.add_message
...
Problem were users calling messages.debug/info/* with a wrong argument
and getting the error "You cannot add messages without installing
MessageMiddleware"
Thanks to trac-user merb for the report.
2013-11-23 17:11:22 +01:00
ffc37e2343
Fixed #21012 -- New API to access cache backends.
...
Thanks Curtis Malony and Florian Apolloner.
Squashed commit of the following:
commit 3380495e93905a74f52b35e289fe928e274f747aee7eb0f73eFixed #21012 -- Thread-local caches, like databases.
2013-11-23 15:06:59 +01:00
3ca0815c0b
Fixed #21445 -- Clean up misuse of null in quickElement.
...
Thanks to trac user parsch for the report.
2013-11-23 14:40:01 +01:00
48ce09f2f6
Fixed missing admindocs' site_header
2013-11-22 13:30:50 +01:00
d6cc37d601
Updated admindocs to use class-based views
...
Thanks Bouke Haarsma for the review.
2013-11-21 22:50:59 +01:00
1718b5256c
Fixed #21405 -- Prevented queryset overwrite in BaseModelAdmin
...
Thanks guido@20tab.com for the report and Tim Graham for the
analyze.
2013-11-21 22:18:52 +01:00
f39fd3cd20
Removed isinstance(RelatedObject) checks from admin.utils
2013-11-21 14:52:01 +02:00
752d3d70da
Fixed #21431 -- GenRel->FK list_filter regression in admin
...
Report, analysis and tests from stephenmcd.
2013-11-21 14:52:00 +02:00
8e670a0e50
Refs #8261 -- Fixed regression introduced by fd219fa.
...
ModelAdmin displayed the "View on site" link even if the Model didn't
define the `get_absolute_url()` method.
2013-11-21 16:26:49 +07:00
68b540c977
Fixed #21361 -- allowed access self.value() from SimpleListFilter lookup
...
Reviewed by Chris Medrela.
2013-11-19 09:14:22 +02:00
b2d2d7e60f
Optimise admin images
2013-11-18 13:33:28 +11:00
0e079e4331
Fixed #21428 -- editable GenericRelation regression
...
The GenericRelation refactoring removed GenericRelations from
model._meta.many_to_many. This had the side effect of disallowing
editable GenericRelations in ModelForms. Editable GenericRelations
aren't officially supported, but if we don't fix this we don't offer any
upgrade path for those who used the ability to set editable=True
in GenericRelation subclass.
Thanks to Trac alias joshcartme for the report and stephencmd and Loic
for working on this issue.
2013-11-16 20:07:35 +02:00
b642d540d4
Moved import at proper place in contrib.sites
2013-11-16 11:13:04 +01:00
7e0ebd74c1
Fixed #21415 -- Replaced escape sequence by literal non-breaking space
...
Unfortunately, escape sequences (\x.. or \u....) do not fit well
with the gettext toolchain. Falling back to using literal char,
even if visibility is not ideal.
2013-11-15 15:32:46 +01:00
3560ef043e
Propagate get_user_model exception from get_user
...
Fixes #21439
2013-11-14 12:02:26 -08:00
0be7f57a90
Merge pull request #1907 from Bouke/tickets/21388
...
Fixed #21388 -- Corrected language code for Frisian
2013-11-11 09:33:55 -08:00
d87127655f
Fixed #21421 -- Added level_tag attribute on messages.
...
Exposing the level name (e.g. "info") makes it possible to prepend
something to the class name. For example, Twitter Bootstrap has
an alert-info class. This class can now be added to the message
using `class="alert-{{ message.level_tag }}".
Because the level_tag was on the end of the `tags` property, it
could not be used in this fashion when extra_tags were given.
2013-11-11 17:58:02 +01:00
4142d15102
Fixed #21388 -- Corrected language code for Frisian
2013-11-11 13:34:01 +01:00
9b7455e918
Fixed #21351 -- Replaced memoize with Python's lru_cache.
...
Replaced the custom, untested memoize with a similar decorator from Python's
3.2 stdlib. Although some minor performance degradation (see ticket), it is
expected that in the long run lru_cache will outperform memoize once it is
implemented in C.
Thanks to EvilDMP for the report and Baptiste Mispelon for the idea of
replacing memoize with lru_cache.
2013-11-11 08:53:09 +01:00
d15985d81f
Fixed #21398 -- Fixed BCryptSHA256PasswordHasher with py-bcrypt and Python 3.
...
Thanks arjan at anymore.nl for the report.
2013-11-09 10:11:50 -05:00
7e714827ea
Don't initialize PostGIS-specific stuff for non-db connections
...
Refs #16969 .
2013-11-09 11:28:16 +01:00
60d27fe7da
Fixed a typo in admindocs template
...
Thanks Reza Mohammadi for the report.
2013-11-08 17:25:17 +01:00
f51c1f5900
Fixed #17001 -- Custom querysets for prefetch_related.
...
This patch introduces the Prefetch object which allows customizing prefetch
operations.
This enables things like filtering prefetched relations, calling select_related
from a prefetched relation, or prefetching the same relation multiple times
with different querysets.
When a Prefetch instance specifies a to_attr argument, the result is stored
in a list rather than a QuerySet. This has the fortunate consequence of being
significantly faster. The preformance improvement is due to the fact that we
save the costly creation of a QuerySet instance.
Thanks @akaariai for the original patch and @bmispelon and @timgraham
for the reviews.
2013-11-07 14:49:49 +02:00
a9093dd376
Fixed #21387 -- Merge two very similar help texts.
2013-11-06 00:35:20 -03:00
c347f78cc1
Fixed all E226 violations
2013-11-03 10:08:55 -08:00
91078f5669
Merge pull request #1861 from milmazz/E251
...
Fixed flake8 E251 violations
2013-11-03 09:42:31 -08:00
f40f90d63b
Fixed regressions from 36ded01527.
...
Refs #21302
2013-11-03 12:45:15 +01:00
cbc7cbbc5b
Fixed flake8 E251 violations
2013-11-03 03:22:11 -06:00
4202d9cf0c
Whitespace fix
2013-11-03 01:53:28 -07:00
6c1b55d61a
Re-expose Count here
2013-11-03 01:52:40 -07:00
3bc0d46a84
Fixed all E261 warnings
2013-11-02 18:20:39 -04:00
7548aa8ffd
More attacking E302 violators
2013-11-02 13:12:09 -07:00
e737c009b8
Fixed flake8 E241
2013-11-02 21:45:40 +02:00
36ded01527
Fixed #21302 -- Fixed unused imports and import *.
2013-11-02 15:24:56 -04:00
19256f300e
Continue to attack E302 violations
2013-11-02 10:18:46 -07:00
c64efe3734
Fixed #15529 -- More permissive geojson syntax in constructor
...
Thanks Wouter Klein Heerenbrink for the report.
2013-10-31 18:15:54 +01:00
726ded5708
Started attackign the next flake8 violation
2013-10-31 08:42:28 -07:00
9fde42a69a
Fixed #20610 : Added a message level dict to contrib.message context processor.
2013-10-30 13:54:07 +01:00
fd219fa24c
Fixed #8261 -- ModelAdmin hook for customising the "show on site" button
...
``ModelAdmin.view_on_site`` defines wether to show a link to the object on the
admin detail page. If ``True``, cleverness (i.e. ``Model.get_absolute_url``) is
used to get the url. If it's a callable, the callable is called with the object
as the only parameter. If ``False``, not link is displayed.
With the aim of maitaining backwards compatibility, ``True`` is the default.
2013-10-29 17:10:12 -04:00
b9a90b371c
Remove dsome import *
2013-10-26 20:57:08 -07:00
b35ff0d920
Fixed all the E203 violations
2013-10-26 18:27:42 -07:00
f2d8027c9a
Fixed up some more flake8 violations (this particular violation still has many occurrences in the tests/ dir so it can't be removed from setup.cfg yet)
2013-10-26 10:50:40 -07:00
08c9ab5a0f
Fixed #21227 -- Added workaround for selenium test failures
...
Added a refresh() before quit() in the selenium tests, since this
solves the problem of spurious test failures in some environments.
2013-10-24 15:07:41 -04:00
43569647ab
Fixed #21299 - Changed filters from title to capfirst on admin inline formsets.
...
Previously there was a mixture of the two which resulted in inconsistent
casing.
2013-10-24 14:44:07 -04:00
9bf5610890
Start attacking E231 violations
2013-10-24 10:30:03 -07:00
c3aa2948c6
Fixed #21298 -- Fixed E301 pep8 warnings
2013-10-23 13:45:03 +01:00
ae48d77ef8
Fixed E225 pep8 warnings.
2013-10-23 06:09:29 -04:00
51d2e1fb23
Fixed #21307 -- Moved TransRealMixin to django.test.utils.
2013-10-22 22:19:56 -03:00
1597503a01
Fixed E221 pep8 warnings.
2013-10-22 09:51:39 -04:00
8e2029f8dd
Removed import * in tests.
...
Thanks to flake8 path/to/file.py | awk -F ' ' '{ print $5 }' | sort | uniq
2013-10-22 08:32:01 -04:00
e565e1332d
Fixed #21275 -- Fixed a serializer error when generating migrations for contrib.auth.
...
The migration serializer now looks for a deconstruct method on any object.
2013-10-21 14:54:52 -04:00
7d0d0dbf26
Force update of the password on iteration count changes.
2013-10-21 20:31:28 +02:00
b289fcf1bf
Fixed #21288 -- Fixed E126 pep8 warnings
2013-10-21 08:31:30 -04:00
5f52590368
Fixed #21291 -- Ensured inactive users cannot reset their passwords
...
Thanks kz26 for the report and the suggested fix. Refs #19758 .
2013-10-19 10:43:06 +02:00
59a8808632
Cleaned formatting/comments in PasswordResetFormTest
2013-10-19 10:43:06 +02:00
ac4fec5ca2
Fixed bug causing CSRF token not to rotate on login.
...
Thanks Gavin McQuillan for the report.
2013-10-18 08:31:19 -04:00
a800036981
Fixed #21287 -- Fixed E123 pep8 warnings
2013-10-18 10:07:39 +01:00
bab9123daa
Fixed #21268 -- Fixed E303 pep8 warnings
2013-10-18 01:46:24 +01:00
65d1d65d52
Fixed #21267 -- Fixed E502 pep8 warnings
2013-10-18 01:28:32 +01:00
dfb4cb9970
Fixed #21285 -- Fixed E121,E122 pep8 warnings
2013-10-17 20:20:11 -04:00
7e5d7a76bf
Fixed #21259 -- Fixed formstools wizard for InlineFormSet.
2013-10-17 14:01:02 -04:00
9833b931b7
Removed importing formtools tests in __init__.py
...
Unnecessary since introduction of DiscoveryTestRunner in 9012833af8
2013-10-17 13:51:36 -04:00
2fb5a51fa3
Fixed #18659 -- Deprecated request.REQUEST and MergeDict
...
Thanks Aymeric Augustin for the suggestion.
2013-10-17 09:42:28 -04:00
98788d3c3a
Remove some unnecesary uses of bool
2013-10-17 05:27:34 -07:00
7f508a3673
Removed some dead code and simplified some other ocde
2013-10-17 05:15:08 -07:00
eb214452c3
Fixed #21270 -- Fixed E701 pep8 warnings
2013-10-17 12:12:40 +01:00
91c77eeab8
Avoided hardcoding Permission.name max_length
...
refs #18866 .
2013-10-16 11:31:07 -04:00
3918eeb9fd
Fixed #7551 -- Made GFK allow None init argument.
...
Thanks SamBull for the report.
2013-10-16 07:03:46 -04:00
f719d4afc7
Updated admin alert colors
...
refs #21220 .
2013-10-15 10:18:51 -04:00
c7634cd7fe
Fixed #7603 -- Added a 'scheme' property to the HttpRequest object
...
`HttpRequest.scheme` is `https` if `settings.SECURE_PROXY_SSL_HEADER` is
appropriately set and falls back to `HttpRequest._get_scheme()` (a hook
for subclasses to implement) otherwise.
`WSGIRequest._get_scheme()` makes use of the `wsgi.url_scheme` WSGI
environ variable to determine the request scheme.
`HttpRequest.is_secure()` simply checks if `HttpRequest.scheme` is
`https`.
This provides a way to check the current scheme in templates, for example.
It also allows us to deal with other schemes.
Thanks nslater for the suggestion.
2013-10-15 09:04:12 -04:00
975415a8ce
Fixed a webdesign template tag docstring to prevent parsing as metadata.
...
Previously admindocs would throw an error when processing it:
"Error in "default-role" directive: no content permitted."
refs #6681
2013-10-14 19:48:24 -04:00
83b9bfea44
Fixed #21266 -- Fixed E201,E202 pep8 warnings.
2013-10-14 18:12:00 -04:00
8ce3c3a928
Merge pull request #1733 from joaoxsouls/#18866
...
Fixed #18866 -- added validation error for verbose_name longer than 39 characters
2013-10-14 06:20:59 -07:00
1ab27e9a65
Fixed #18866 -- added validation error for verbose_name longer than 39 characters
...
Added a validation error check when creating the permissions for model, to avoid
cryptic database error when the verbose_name is longer than 39 characters
thanks elena for reporting it
2013-10-14 14:19:35 +01:00
1e8eadc94e
Fixed #15888 -- Made tablename argument of createcachetable optional
...
Thanks Aymeric Augustin for the report and the documentation and
Tim Graham for the review.
2013-10-14 13:24:40 +02:00
ef22d512b5
Imported custom user classes in tests depending on it
...
Without those imports, affected test files cannot be run
independently. Refs #21164 .
2013-10-14 10:14:24 +02:00
21c2bfdff3
Updated OpenLayers version from 2.11 to 2.13
2013-10-12 18:08:07 +02:00
b67ab75e82
Fixed assorted flake8 errors.
2013-10-11 07:25:14 -04:00
4b0f8d23c9
Sanitized test assertions in gdal tests
2013-10-10 23:02:31 +02:00
1dae4ac177
Whitespace cleanup.
...
* Removed trailing whitespace.
* Added newline to EOF if missing.
* Removed blank lines at EOF.
* Removed some stray tabs.
2013-10-10 16:49:20 -04:00
adedc31072
Fixed "redefinition of unused 'foo' from line X" pyflakes warnings.
2013-10-10 11:09:42 -04:00
4523fcd601
Fixed #19924 -- Fixed selectors in actions.js that did not use options.
2013-10-09 10:41:54 -04:00
24f9967619
Fixed regression introduced by 20472aa827.
...
The wrong exception was being caught when detecting the presence of GeoIP.
Thanks to ramiro for the report.
2013-10-09 11:53:43 +02:00
ddb53856b6
Fixed #21164 -- Added documentation for issue with test users.
...
The package renaming restores the older package names (which were also the
documented package names). This doesn't affect test discovery because the
module in question doesn't contain any tests.
Thanks to Carl for the design discussion.
2013-10-08 10:32:56 +08:00
935001c4f1
Cleaned up admin CSS for consistency.
...
* header selected twice -merged
* match indentation throughout
* color names to hex
refs #21220 .
2013-10-07 14:49:20 -04:00
3eab22a045
Added min-width for date and time inputs in admin.
...
refs #21220 .
2013-10-07 14:29:58 -04:00
a8df8e34f9
Revert "Fixed #21241 -- Avoid extraneous JOINs in admin changelist search."
...
This reverts commit 698dd82eee
2013-10-07 13:45:52 -04:00
259a6ea82c
Added a link in admin branding block to admin index.
...
Refs #13749 and #21220 .
2013-10-07 13:39:40 -04:00
698dd82eee
Fixed #21241 -- Avoid extraneous JOINs in admin changelist search.
2013-10-07 13:10:52 -04:00
617aceb1b4
Fixed #18263 -- Corrrected handling of hidden fields in tabular admin inlines.
...
Thanks hvdklauw for the report and patch.
2013-10-07 12:30:02 -04:00
8d75d1e1bc
Improved error message while setting GeometryProxy
2013-10-06 21:29:39 +02:00
1df3c49a1a
Fixed #21174 -- transaction control in related manager methods
2013-10-05 23:07:52 +03:00
20472aa827
Fixed #21189 : Cleaned up usage of bare except clauses.
...
Thanks to berkerpeksag for the report and to claudep
for the review.
2013-10-05 11:50:03 +02:00
948d209ada
Fixed #21217 -- Avoid connecting `(pre|post)_init` signals to abstract senders.
2013-10-04 16:23:06 -04:00
dc3d2ac98c
Fixed #11277 -- Hid labels of fields with HiddenInput widget in admin forms.
...
Thanks bartTC for the report.
2013-10-04 14:08:06 -04:00
bcd4c3f27d
Fixed #6681 -- Don't break docutils when rendering reStructuredText.
...
Don't set a global default interpreted role function for reStructuredText.
Instead, use the `default-role` directive to change the default only within
the `parse_rst()` function.
Thanks Malcolm Tredinnick for the report.
2013-10-04 13:27:08 -04:00
8b0014869f
Fixed #19321 -- Allowed redirect middleware HTTP responses to be overridden.
...
Thanks Melevir for the suggestion.
2013-10-04 07:36:39 -04:00
c4db7f075e
Fixed #19182 -- Fixed ModelAdmin.lookup_allowed to work with ('fieldname', SimpleListFilter) syntax.
...
Thanks gauss for the report.
2013-10-03 09:37:49 -04:00
1285ca67eb
Fixed #16919 -- Passed user to set_password_form in GET requests.
...
Thanks Jaime Irurzun for the report and initial patch and
ejucovy for the test.
2013-10-02 13:28:15 -04:00
5381317fe3
Fixed #21129 -- Prevented admin filter params modifications from throwing an exception.
...
Thanks Tuttle for the report.
2013-10-02 08:16:09 -04:00
1d0fc61b1c
Fixed #15185 -- Allowed ModelAdmin.list_display_links=None to disable change list links.
...
Thanks rm_ for the suggestion.
2013-10-01 14:25:54 -04:00
d9bbda7149
* Fixing improper grammar
2013-09-30 16:59:45 -04:00
d847ddfe1d
Fixed #3871 -- Fixed regression introduced by 04a2a6b.
...
Added do_not_call_in_templates=True attribute to RelatedManagers
to prevent them from being called.
Thanks jbg@ for the report.
2013-09-30 15:43:44 -04:00
4745ea1d27
Added hints argument to GeoQuerySet; refs #13724 .
2013-09-30 14:16:17 -04:00
728548e483
Fixed #21134 -- Prevented queries in broken transactions.
...
Squashed commit of the following:
commit 63ddb271a44df389b2c302e421fc17b7f0529755
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Sep 29 22:51:00 2013 +0200
Clarified interactions between atomic and exceptions.
commit 2899ec299228217c876ba3aa4024e523a41c8504
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Sep 22 22:45:32 2013 +0200
Fixed TransactionManagementError in tests.
Previous commit introduced an additional check to prevent running
queries in transactions that will be rolled back, which triggered a few
failures in the tests. In practice using transaction.atomic instead of
the low-level savepoint APIs was enough to fix the problems.
commit 4a639b059ea80aeb78f7f160a7d4b9f609b9c238
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Tue Sep 24 22:24:17 2013 +0200
Allowed nesting constraint_checks_disabled inside atomic.
Since MySQL handles transactions loosely, this isn't a problem.
commit 2a4ab1cb6e83391ff7e25d08479e230ca564bfef
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sat Sep 21 18:43:12 2013 +0200
Prevented running queries in transactions that will be rolled back.
This avoids a counter-intuitive behavior in an edge case on databases
with non-atomic transaction semantics.
It prevents using savepoint_rollback() inside an atomic block without
calling set_rollback(False) first, which is backwards-incompatible in
tests.
Refs #21134 .
commit 8e3db393853c7ac64a445b66e57f3620a3fde7b0
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date: Sun Sep 22 22:14:17 2013 +0200
Replaced manual savepoints by atomic blocks.
This ensures the rollback flag is handled consistently in internal APIs.
2013-09-30 09:42:27 +02:00
8f51ba669a
Fixed #21186 : Fixed regression when using date fields in the admin's list_filter.
...
Thanks to onlygoldi2201 for the report and to ramiro and apollo13
for the reviews.
2013-09-28 00:40:43 +02:00
04a2a6b0f9
Fixed #3871 -- Custom managers when traversing reverse relations.
2013-09-25 21:15:59 +03:00
5d74853e15
Revert "Ensure that passwords are never long enough for a DoS."
...
This reverts commit aae5a96d57
2013-09-24 21:01:21 +02:00
53c7d66869
Marked PermissionsMixin.user_permissions help_text for translation
2013-09-24 07:36:24 -04:00
18fb713e7b
Properly marked skipped GIS tests as skipped
2013-09-24 12:23:42 +02:00
45403d330a
Reformatted some GIS distance tests
2013-09-24 12:23:42 +02:00
a5b062576b
Removed a few trailing backslashes.
...
We have always been at war with trailing backslashes.
2013-09-22 14:04:10 +02:00
ee0ef1b094
Partial revert of 165f44aa.
...
That commit didn't always improve readability.
See discussion on django-developers for details.
2013-09-22 14:04:10 +02:00
0d1ba84d13
Fixed #20702 -- Deprecated get_formsets in favor of get_formsets_with_inlines.
...
Thanks stanislas.guerra at gmail.com for the report.
2013-09-20 07:47:24 -04:00
a075e2ad0d
Increase default PBKDF2 iterations
...
Increases the default PBKDF2 iterations, since computers have gotten
faster since 2011. In the future, we plan to increment by 10% per
major version.
2013-09-19 18:02:25 +01:00
e23de9e350
Fixed typo in exception message; refs #19414
...
Thanks Alexey Boriskin for the report.
2013-09-19 06:24:12 -04:00
98514849dc
Fixed #19414 -- Added admin registration decorator
...
Thanks stavros for the suggestion.
2013-09-18 11:44:10 -04:00
2c6079775e
Destroy selenium before live server threads.
...
Ensure that selenium quits before the live server thread to
prevent occasional hangs when killing the live server.
2013-09-17 18:39:25 +02:00
73a610d2a8
Final attempt to solve sporadic test failures.
...
tearDownClass is not called if setUpClass throws an exception, in our case
this means that LiveServerTestCase leaks LiveServerThread sockets if the
test happens to be skipped later on, and AdminSeleniumWebDriverTestCase
doesn't close it's already open browser window. To prevent this leakage
we catch errors where needed and manually call _tearDownClassInternal.
_tearDownClassInternal should be written as defensively as possible since
it is not allowed to make any assumptions on how far setUpClass got.
This patch should fix the sporadic "Address already in use"-errors on jenkins
and also the "This code isn't under transaction management"-error for sqlite
(also just on jenkins).
After discussion with koniiiik, jezdez, kmtracey, tos9, lifeless, nedbat and
voidspace it was decided that this is the safest approach (thanks to everyone
for their comments and help). Manually calling tearDownClass was shut down
cause we don't know how our users override our classes.
This is a private and very specialized API on purpose and should not be used
without a strong reason!
This patch partially reverts the earlier attempts to fix those issues,
namely:
2fa0dd73b13c5775d36f
2013-09-17 16:41:01 +02:00
8e04ad9fc2
Added Arabic mapping to contrib/admin/static/admin/js/urlify.js
2013-09-17 10:34:12 -04:00
f5f662fa5f
Fixed #21112 -- Make sure sitemaps with no lastmod date work correctly.
...
Thanks to Matthias Kestenholz for the report and patch.
2013-09-17 10:21:11 -04:00
f40c82213f
Added backwards compatability shims for util modules.
...
refs #17627
2013-09-16 12:53:42 -04:00
18ffdb1772
Fixed #17627 -- Renamed util.py files to utils.py
...
Thanks PaulM for the suggestion and Luke Granger-Brown and
Wiktor Kołodziej for the initial patch.
2013-09-16 12:52:05 -04:00
aae5a96d57
Ensure that passwords are never long enough for a DoS.
...
* Limit the password length to 4096 bytes
* Password hashers will raise a ValueError
* django.contrib.auth forms will fail validation
* Document in release notes that this is a backwards incompatible change
Thanks to Josh Wright for the report, and Donald Stufft for the patch.
This is a security fix; disclosure to follow shortly.
2013-09-15 13:42:23 +08:00
2fa0dd73b1
Fixed error handling in 3c5775d36f for non-operational webdrivers.
2013-09-14 23:24:48 +02:00
3c5775d36f
Delayed initialization of Selenium webdrivers.
...
If setUpClass throws an exception (in this case "Address already in use" if the
super call can't find any open port to bind too) tearDownClass is not called.
This results in open browser windows from the webdriver, hence we only construct
it once we are sure there is no code afterwards which could error out.
2013-09-14 22:58:30 +02:00
6feb75129f
Fixed #21060 -- Refactored admin's autodiscover method to make it reusable.
...
We want to be able to use it for instance for discovering `tasks.py` modules
inside the INSTALLED_APPS.
This commit therefore moves the logic to `autodiscover_modules` method in
django.utils.module_loading.
2013-09-13 20:09:41 -04:00
4c5641dd92
Fixed inspectdb test for spatialite >=4
2013-09-12 11:14:16 +02:00
c82f6c2227
Add a test for the geo-enabled inspectdb command
2013-09-12 10:30:45 +02:00
170f721367
Fixed #21056 -- AdminSite.app_index no longer blindly accepts any app-labelish input.
2013-09-11 08:48:32 -04:00
b2b763448f
Fixed #20841 -- Added messages to NotImplementedErrors
...
Thanks joseph at vertstudios.com for the suggestion.
2013-09-10 11:09:59 -04:00
af67ce5e18
Fixed #4574 -- Added CSS classes to the admin calendar widget for better control over styling.
2013-09-10 08:07:17 -05:00
2bc5143866
Fixed #7467 -- Added a template block to override the admin welcome message.
...
Thanks Jeff Kowalczyk for the suggestion and rctay for the patch.
2013-09-10 08:48:03 -04:00
d9413d33b2
Refactored code and tests that relied on django.utils.tzinfo.
...
Refs #17262 .
2013-09-09 22:32:52 +02:00
0d74f9553c
Fixed #21063 -- AdminSite app_index should be fail early if the user has no permissions.
2013-09-09 12:51:03 -04:00
9d11522599
Removed some more unused local vars
2013-09-08 12:20:01 -07:00
96fd5557f9
Removed a ton of unused local vars
2013-09-08 08:05:16 -07:00
b11564fd36
Fixed #16869 -- BaseGenericInlineFormSet.save_new should use form's save() method
...
Thanks mattaustin for the report and Pablo Recio (pyriku) for the patch.
2013-09-07 20:00:38 -04:00
04415bf81b
Fixed #21013 -- Ensure that ModelAdmin.get_queryset is considered for the admin history view.
2013-09-07 14:53:29 -05:00
907f19eba7
Merge pull request #1565 from garrypolley/#19988-ordinal-html-i18n-fix
...
fixes #19988 , allow html in ordinal for humanize
2013-09-07 11:13:55 -07:00
55a11683f7
Fixed #20836 -- Ensure that the ForeignKey's to_field attribute is properly considered by the admin's interface when creating related objects.
...
Many thanks to Collin Anderson for the report and patch and to Peter Sheats for the test.
2013-09-07 12:14:07 -05:00
73de9dd1fa
Add `response_delete` and `render_delete_form` methods to `ModelAdmin`
...
This make it easier to control the delete flow.
2013-09-07 10:59:49 -05:00
636860fbfb
Moved two WSGI-specific functions to the WSGI handler.
...
They were defined in base when the mod_python handler used them. See bfcecbff
2013-09-07 10:03:49 -05:00
ec47de77d6
Fixed regression introduced by a962286, changed ugettext to ugettext_lazy.
2013-09-07 08:09:13 -04:00
2530735d2d
Fixed a number of flake8 errors -- particularly around unused imports and local variables
2013-09-06 21:56:40 -07:00
d5df914fe1
Merge pull request #1578 from rmutter/ticket_20821
...
Fixed #20821 -- Added tooltips to Admin SelectBox widget
2013-09-06 14:03:58 -07:00
c438cc2a36
Fixed #20821 -- Added tooltips to Admin SelectBox widget
...
The Admin widget, which can be used to filter multiple selects
can sometimes be too narrow and hide information such as
user permissions. This commit adds tooltips to the select
options so that a user can hover over and see the hidden text.
2013-09-06 15:46:38 -05:00
337bd248a5
fixes #19988 , allow html in ordinal for humanize
2013-09-06 12:59:44 -05:00
a962286b74
Added AdminSite attributes for easily changing admin title.
...
AdminSite now has overridable site_header, site_title and index_title attributes. Changed
each admin view to pass these to the context (in a new AdminSite.each_context() method).
The intent here is to make it easier to override these things in the common case, instead of
having to override a template, which is a bigger burden.
2013-09-06 12:31:50 -05:00
273a1e6b8d
Fixed awkward indentation in admin URLconfs
2013-09-06 12:31:50 -05:00
4d13cc56de
Fixed #21035 -- Changed docs to treat the acronym SQL phonetically.
...
The documentation and comments now all use 'an' to
refer to the word SQL and not 'a'.
2013-09-05 20:14:58 -04:00
6a6428a36f
Took advantage of django.utils.six.moves.urllib.*.
2013-09-05 14:39:23 -05:00
ed9cd4fd8b
Fixed #21000 -- Made cached_db session backend respect SESSION_CACHE_ALIAS
2013-09-05 10:47:58 -04:00
5649c0af9d
Fixed "indentation is not a multiple of four" pep8 issues.
2013-09-03 14:22:21 -04:00
dd656073ad
Fixed #21003 -- Ensured geometry widget return value has SRID
...
Thanks Mathieu Leplatre for the report and initial patch.
2013-09-03 13:53:35 +02:00
3550b27a89
Isolated map creation JS code
2013-09-03 13:53:35 +02:00
b6889c68d7
Prevented rendering attrs to be squashed in OSMWidget
2013-09-03 10:02:55 +02:00
6ecbac21a9
Fixed syntax error in OSMWidget
2013-09-03 09:05:01 +02:00
973502c047
Fixed gis test to run on non gis-enabled settings
...
Refs #20998 .
2013-09-02 14:15:04 +02:00
102f26c929
Fixed #20998 -- Allow custom (de)serialization for GIS widgets
...
Thanks Mathieu Leplatre for the report and the initial patch.
2013-09-02 13:32:00 +02:00
868b4c921c
Used six.moves.zip_longest, new in six 1.4.0.
2013-09-02 12:11:16 +02:00
365c3e8b73
Replaced "not PY3" by "PY2", new in six 1.4.0.
2013-09-02 12:11:02 +02:00
17d898dedd
Remove usage of deprecated module_name model option introduced in 1c0c879be3.
2013-09-01 09:58:33 -03:00
1c0c879be3
Fixed #17074 -- Improved first field detection in admin add form
...
Thanks Kidwind for the report and Julien Phalip for the initial
patch.
2013-08-31 21:19:22 +02:00
92a710cd03
Updated Selenium-based tests after e909ceae9b.
2013-08-31 12:14:52 -03:00
e909ceae9b
Made django.test.testcases not depend on staticfiles contrib app.
...
Do this by introducing a django.contrib.staticfiles.testing.StaticLiveServerCase
unittest TestCase subclass.
Fixes #20739 .
2013-08-31 11:02:32 -03:00
11cd7388f7
Fixed #20989 -- Removed useless explicit list comprehensions.
2013-08-30 10:57:51 -04:00
c7d0ff0cad
Fixed #20989 -- Removed explicit list comprehension inside dict() and tuple()
...
Thanks jeroen.pulles at redslider.net for the suggestion and
helper script.
2013-08-29 12:11:03 -04:00
af953c45cc
Fixed #16433 -- Fixed a help_text/read only field interaction that caused an admin crash.
...
Thanks chris at cogdon.org for the report and admackin for the patch.
2013-08-29 09:39:31 -04:00
cf8d6e9108
Fixed #20881 -- Removed contrib.auth.models.AbstractUser.get_absolute_url()
...
The definition is arbitrary and creates a broken "view on site"
link in the admin if a project doesn't define such a URL.
2013-08-29 06:36:35 -04:00
b89c2a5d9e
Fixed #18171 -- Checked signature of authenticate() to avoid supressing TypeErrors.
...
The current auth backend code catches TypeError to detect backends that
do not support specified argumetnts. As a result, any TypeErrors raised
within the actual backend code are silenced.
In Python 2.7+ and 3.2+ this can be avoided by using inspect.getcallargs().
With this method, we can test whether arguments match the signature without
actually calling the function.
Thanks David Eyk for the report.
2013-08-28 07:51:45 -04:00
fa57266699
Fixed #20972 -- Make messages cookie follow session cookie secure/httponly
2013-08-26 21:34:29 +02:00
5569b0b92f
Merge remote-tracking branch 'core/master' into schema-alteration
...
Conflicts:
django/db/backends/oracle/base.py
django/db/backends/postgresql_psycopg2/base.py
django/db/models/signals.py
tests/queries/tests.py
2013-08-23 12:36:53 +01:00
b0ce6fe656
Fixed #20922 -- Allowed customizing the serializer used by contrib.sessions
...
Added settings.SESSION_SERIALIZER which is the import path of a serializer
to use for sessions.
Thanks apollo13, carljm, shaib, akaariai, charettes, and dstufft for reviews.
2013-08-22 13:58:26 -04:00
9d1987d767
Fixed #19303 -- Fixed ModelAdmin.formfield_overrides on fields with choices
2013-08-22 11:50:52 -04:00
65cf82bd08
Fixed #20934 -- Avoided NoReverseMatch in ModelAdmin.changelist_view
...
The view tried to display links to a ModelAdmin's change_view, which
resulted in NoReverseMatches if get_urls was overridden to remove the
corresponding url.
2013-08-22 10:08:54 -04:00
c5fbd16362
Import test case classes from their public API module.
2013-08-21 22:32:04 +01:00
deebb1a977
Import test case classes from their public API module.
2013-08-20 22:23:41 -03:00
b6a957f0ba
Merge remote-tracking branch 'core/master' into schema-alteration
...
Conflicts:
docs/ref/django-admin.txt
2013-08-19 18:30:48 +01:00
3c03004050
Fixed #20640 -- Avoided NoReverseMatch in get_deleted_objects
...
The default delete action resulted in a NoReverseMatch if it were to
list any Model with a ModelAdmin with `get_urls` overridden to remove
the change url. Catching the error and not displaying the link in that
case, as was already done for models with no registered admins.
Thanks Keryn Knight for the report.
2013-08-19 12:01:33 -04:00
ddeb20e31b
Fixed GIS regression caused by force_subq
...
Caused by commit 7737305a4f
2013-08-19 16:35:11 +03:00
3844089edc
Fixed #20777 -- Admin proxy model deletion regression
...
Added proxy_models tests by Harm Geerts <github@geertswei.nl>.
2013-08-19 09:51:41 +03:00
240886183b
Fixed #20829 -- Skip postgis metadata tables with introspection
2013-08-16 21:14:29 +02:00
165f44aaaa
Combine consecutive with statements
...
Python 2.7 allows to combine several 'with' instructions.
2013-08-16 20:12:10 +02:00
22c6497f99
Fixed #20895 -- Made check management command warn if a BooleanField does not have a default value
...
Thanks to Collin Anderson for the suggestion and Tim Graham for
reviewing the patch.
2013-08-15 19:47:26 -04:00
71c491972e
Fixed #11400 -- Passed kwargs from AbstractUser.email_user() to send_mail()
...
Thanks Jug_ for suggestion, john_scott for the initial patch,
and Tim Graham for code review.
2013-08-14 07:46:11 -04:00
cbe6d5568f
Apply autoescaping to AdminURLFieldWidget.
...
This is a security fix; disclosure to follow shortly.
2013-08-13 11:06:41 -05:00
ae3535169a
Fixed is_safe_url() to reject URLs that use a scheme other than HTTP/S.
...
This is a security fix; disclosure to follow shortly.
2013-08-13 11:06:22 -05:00
737b53ab9a
Merge pull request #1470 from loic/admin.actionlist
...
Fixed overflow for the "Recent Actions" widget on the admin index.
2013-08-13 05:11:39 -07:00
33fc083b0d
Fixed overflow for the "Recent Actions" widget on the admin index.
...
Previously the CSS targeted "li.changelink" and therefore didn't
work for the "add" and "delete" actions.
Refs #14868 .
2013-08-13 18:20:12 +07:00
00d23a13eb
Fixed #20828 -- Allowed @permission_required to take a list of permissions
...
Thanks Giggaflop for the suggestion.
2013-08-10 10:10:18 -04:00
453915bb12
SQLite test fix -- refs #9057
2013-08-09 10:57:25 -04:00
588b523233
Merge remote-tracking branch 'core/master' into schema-alteration
...
Conflicts:
django/db/models/options.py
2013-08-09 14:37:37 +01:00
ddae74b64c
Fixed #9057 -- Added default_permissions model meta option.
...
Thanks hvendelbo for the suggestion and koenb for the draft patch.
2013-08-09 09:19:52 -04:00
de64c4d6e9
Merge remote-tracking branch 'core/master' into schema-alteration
...
Conflicts:
django/core/management/commands/flush.py
django/core/management/commands/syncdb.py
django/db/models/loading.py
docs/internals/deprecation.txt
docs/ref/django-admin.txt
docs/releases/1.7.txt
2013-08-09 14:17:30 +01:00
d53e574676
Fixed #20865 -- Fixed raw_id_fields to work with callable limit_choices_to.
2013-08-06 13:41:52 -04:00
6d88d47be6
Fixed #20832 -- Enabled HTML password reset email
...
Added optional html_email_template_name parameter to password_reset view
and PasswordResetForm.
2013-08-05 09:47:28 -04:00
3e0eb2d788
Fixed a number of lint warnings, particularly around unused variables.
2013-08-04 09:17:10 -07:00
ebb3e50243
Introduced ModelAdmin.get_fields() and refactored get_fieldsets() to use it.
...
Refs #18681 .
This also starts the deprecation of ModelAdmin.declared_fieldsets
2013-08-04 09:14:18 -04:00
59f58bf731
Merge pull request #1432 from loic/modeladmin.get_search_results
...
Moved get_search_results from BaseModelAdmin to ModelAdmin.
2013-08-04 04:17:34 -07:00
07876cf02b
Deprecated SortedDict (replaced with collections.OrderedDict)
...
Thanks Loic Bistuer for the review.
2013-08-04 07:09:39 -04:00
470a9bb22d
Moved get_search_results from BaseModelAdmin to ModelAdmin.
...
Refs #15961 .
2013-08-04 17:18:17 +07:00
0bcdcc7eb9
Added ModelAdmin.get_search_fields.
2013-08-03 20:02:43 -04:00
425d076d0c
Fixed #18923 -- Corrected usage of sensitive_post_parameters in contrib.auth
...
Thanks Collin Anderson for the report.
2013-08-02 14:46:17 -04:00
1b47508ac8
Fixed LogEntry.get_admin_url() for non-existent models.
...
Regression introduced by [369b6fa#18169 .
2013-08-02 12:51:10 -04:00
a0ed2f9260
Fixed #18681 -- GenericInlineModelAdmin.get_formset() no longer bypasses get_fieldsets().
...
Refs 23e1b59
2013-08-02 10:41:29 -04:00
fd0d486467
Fixed #20838 -- Fixed Geodjango spatialrefsys test failure with postgis-2.0.3
2013-08-02 09:26:53 -04:00
a1889397a9
Fixed #12103 -- Added AuthenticationForm.confirm_login_allowed to allow customizing the logic policy.
...
Thanks ejucovy and lasko for work on the patch.
2013-07-31 13:54:05 -04:00
31e6d58d46
Fixed #20348 -- Consistently handle Promise objects in model fields.
...
All Promise objects were passed to force_text() deep in ORM query code.
Not only does this make it difficult or impossible for developers to
prevent or alter this behaviour, but it is also wrong for non-text
fields.
This commit changes `Field.get_prep_value()` from a no-op to one that
resolved Promise objects. All subclasses now call super() method first
to ensure that they have a real value to work with.
2013-07-31 15:54:17 +03:00
8f5533ab25
Fixed #20793 -- Added Last-Modified header to sitemaps.
2013-07-31 07:42:30 -04:00
4c6ffcf721
Fixed #20819 -- Return 404 instead of 500 error when ``staticfiles`` view is used in production.
2013-07-31 18:58:50 +10:00
dafec05548
Updated flatpages tests to override CSRF_FAILURE_VIEW.
2013-07-30 13:04:30 -04:00
5b47a9c5a0
Fixed a test that could fail depending on PASSWORD_HASHERS.
...
Thanks Claude. Refs #20760 .
2013-07-30 16:14:53 +02:00
12e9804d16
Rename allow_syncdb to allow_migrate
2013-07-30 12:08:59 +01:00
68e0a169c4
Rename pre_ and post_syncdb to *_migrate, with aliases from old names
2013-07-30 11:52:52 +01:00
53e9ab72e9
Updated some minified admin javascript files.
2013-07-30 00:21:33 -07:00
e351dbf6ee
Fixed #19082 -- Enabled admin field pre-population for existing objects.
...
Thanks to msaelices and d1ffuz0r for the initial patch and tests.
2013-07-30 00:21:08 -07:00
5c1143910e
Removed most of absolute_import imports
...
Should be unneeded with Python 2.7 and up.
Added some unicode_literals along the way.
2013-07-29 20:28:13 +02:00
402b4a7a20
Fixed #14850 -- Cleaned up duplicate code in admin formset handling.
...
Thanks apollo13 for the report and review.
2013-07-29 12:37:43 -04:00
fdd7a355bf
Deprecated django.utils.importlib
...
This was a shim for pre-Python 2.7 support.
2013-07-29 17:10:22 +02:00
4e0ff35146
Fixed #11195 -- Added CSS classes to the changelist cells to allow style customizations. Thanks to akaihola, Ramiro Morales and vdboor for their work on the patch.
2013-07-27 19:50:02 -07:00
47c755327b
Fixed a number of minor misspellings.
2013-07-27 18:46:03 -07:00
e07e4030b9
Fixed #18511 -- Cleaned up admin password reset template titles.
2013-07-27 14:23:04 -04:00
8676318d2d
Fixed #20805 -- Removed an extra colon beside checkboxes in the admin.
...
Thanks CollinAnderson for the report.
2013-07-26 14:45:38 -04:00
2a979d2a7b
Updated contrib.admin to use Email/URLInputs; refs #16630
2013-07-26 07:22:30 -04:00
9b88dd3809
Fixed #20679 -- Corrected CachedFilesMixin.post_process docstring.
...
Thanks bmispelon for the report.
2013-07-25 12:31:53 -04:00
fb052b528a
Fixed #19900 -- Updated admin buttons to use CSS3 rounded corners.
2013-07-23 11:28:22 -04:00
5dbca13f3b
Fixed #20760 -- Reduced timing variation in ModelBackend.
...
Thanks jpaglier and erikr.
2013-07-23 15:43:12 +02:00
Loic Bistuer
maurycyp
Claude Paroz
Ramiro Morales
Krzysztof Jurewicz
Tim Graham
Alex Gaynor
Vajrasky Kok
Christopher Medrela
Andrew Godwin
Jay Leadbetter
Baptiste Mispelon
Denis Cornehl
Curtis Maloney
Bouke Haarsma
Anssi Kääriäinen
glts
Matt Robenolt
Sjoerd Langkemper
Florian Apolloner
Milton Mazzarri
coagulant
Boryslav Larin
Unai Zalakain
Kevin Christopher Henry
Renato Oliveira
Alasdair Nicol
Alasdair Nicol
Kathryn Killebrew
Ryan Allen
Larry O'Neill
Marc Tamlyn
joaoxsouls
crccheck
Russell Keith-Magee
Simon Charette
Chris Adams
Étienne Loks
Tai Lee
Ryan Kaskel
Anentropic
tschilling
Adam Haney
Aymeric Augustin
Michał Lech
Paul McMillan
Brian Holdefehr
Beshr Kayali
Juan Catalano
Keryn Knight
Gregor MacGregor
Roberto Aguilar
Pablo Mouzo
Julien Phalip
Rudy Mutter
Garry Polley
Adrian Holovaty
Eric Boersma
CHI Cheng
Michał Górny
Erik Romijn
Lukasz Balcerzak
Rainer Koirikivi
Harm Geerts
SusanTan
Jacob Kaplan-Moss
ersran9
Collin Anderson
Justin Michalicek
Petr Dlouhý
Julian Bez
Kirill Zaitsev
Serge G. Spaolonzi
Pedro Mourelle