Jon Dufresne
9b9c8c4a81
Fixed #27368 -- Modifed BaseEmailBackend.__enter__() to close the connection if an exception occurs.
...
Fixes unclosed socket ResourceWarning in mail test.
Thanks Claude Paroz for the review.
2016-10-21 05:59:07 -07:00
Claude Paroz
1f5b69917d
Optimized file copy in TemplateCommand
2016-10-20 16:59:01 +02:00
Tim Graham
cd09524f27
Fixed #27200 -- Provided makemigration's allow_migrate() with model_name.
2016-10-13 11:04:58 -04:00
João Sampaio
74a575eb72
Fixed #24607 -- Serialized natural keys in multi-table inheritance models.
2016-10-12 20:04:57 -04:00
Claude Paroz
458e2fbfcc
Fixed #27333 -- Prevented BASE64 encoding in message.as_string() on Python 3
...
Thanks Tim Graham for the review.
2016-10-12 20:48:09 +02:00
Nick Pope
f1664a2734
Replaced '__' with LOOKUP_SEP constant.
2016-10-11 11:14:06 -04:00
Claude Paroz
979ea95608
Fixed #27300 -- Made makemigrations --dry-run output a string (no bytes)
...
Thanks Markus Holtermann for the report and the review.
2016-10-06 11:41:35 +02:00
Lucas Lois
e7fa89fb58
Fixed #27262 -- Moved URL checks to resolver and pattern classes.
...
Thanks Sjoerd Job Postmus for the report and review.
2016-10-05 15:34:26 -04:00
Tim Graham
d5c0eb7d68
Removed unused variable in django/core/mail/backends/smtp.py.
2016-10-05 11:16:45 -04:00
Claude Paroz
122c90a43b
Fixed #27305 -- Removed BaseCommand.can_import_settings unused attribute
...
Thanks Tim Graham for the review.
2016-10-02 20:31:56 +02:00
Claude Paroz
fa2f55cfd5
Refs #26940 -- Re-allowed makemessages without settings
...
Thanks Tim Graham for the review.
2016-10-01 14:57:16 +02:00
Claude Paroz
fc92c6b500
Removed unneeded no_settings_commands hardcoded list
...
Thanks Tim Graham for the review.
2016-09-30 17:25:28 +02:00
Vesteinn Snaebjarnarson
602bffe758
Fixed #27210 -- Allowed SMTPBackend to fail silently on a socket connection error.
2016-09-27 14:34:49 -04:00
levental
42dc9d0400
Fixed #26210 -- Prevented SMTP backend from trying to send mail after a connection failure.
2016-09-21 16:45:10 -04:00
Alasdair Nicol
911d9f4ed1
Fixed #27238 -- Disabled check_pattern_startswith_slash if settings.APPEND_SLASH=False.
...
Thanks strycore for the report and timgraham for suggesting the
solution.
2016-09-19 21:00:12 -04:00
Tim Graham
8119b679eb
Refs #27025 -- Fixed "invalid escape sequence" warnings in Python 3.6.
...
http://bugs.python.org/issue27364
2016-09-17 15:44:06 -04:00
Claude Paroz
d389125606
Fixed #27098 -- Deprecated DatabaseIntrospection.get_indexes
...
Thanks Akshesh <aksheshdoshi@gmail.com> for help with the PostgreSQL query.
Thanks Tim Graham for the review.
2016-09-12 09:26:33 +02:00
Ivan
9a2a52558e
Fixed #27171 -- Added unicode_literals and coding preamble to all files in startapp template on Python 2.
2016-09-03 12:00:00 -04:00
Claude Paroz
2ced2f785d
Replaced smart_* by force_* calls whenever possible
...
The smart_* version should only be used when a lazy string should keep
its lazy status.
2016-09-03 13:46:41 +02:00
Ed Morley
f02dbbe1ae
Fixed #11331 -- Stopped closing pylibmc connections after each request.
...
libmemcached manages its own connections, so isn't affected by refs #5133 .
2016-09-02 14:44:27 -04:00
Tim Graham
098c07a032
Fixed #27142 , #27110 -- Made makemigrations consistency checks respect database routers.
...
Partially reverted refs #27054 except for one of the tests as this
solution supersedes that one.
Thanks Shai Berger for the review.
2016-09-01 16:19:29 -04:00
Riccardo Magliocchetti
7ed8b98f42
Clarified URL regex check message with respect to include().
2016-09-01 14:06:45 -04:00
Ed Morley
d8ef5b0e65
Fixed #27152 -- Supported comma delimiter in memcached LOCATION string.
2016-08-31 17:23:41 -04:00
Ed Morley
65ec8fa8ca
Fixed #20892 -- Allowed configuring memcached client using OPTIONS.
...
Previously, the MemcachedCache backend ignored `OPTIONS` and
PyLibMCCache used them to set pylibmc behaviors. Both backends now
pass `OPTIONS` as keyword arguments to the client constructors.
2016-08-31 12:50:14 -04:00
Claude Paroz
fe252c0a5a
Fixed #27131 -- Passed proper string type to SMTP connection login
...
Passing an Unicode string on Python 2 was crashing the connection.
Thanks slavugan@gmail.com for the report, and Tim Graham for the review.
2016-08-31 09:00:41 +02:00
Berker Peksag
a02b5848ae
Replaced property() usage with decorator in several places.
2016-08-25 20:06:22 -04:00
Tim Graham
a3abbe1fcb
Removed a blank line per isort.
2016-08-24 13:58:57 -04:00
Simon Charette
d5c4ea5246
Fixed #27100 -- Included already applied migration changes in the pre-migrate state.
...
Refs #24100 .
Thanks Tim for the review.
2016-08-24 01:17:48 -04:00
Simon Charette
d1757d8df4
Fixed #27044 -- Included already applied migration changes in the post-migrate state when the execution plan is empty.
...
Refs #24100 .
Thanks tkhyn for the report and Tim for the review.
2016-08-24 01:17:18 -04:00
Claude Paroz
48c34f3336
Fixed #26971 -- Prevented crash with non-UTF-8 incoming PATH_INFO
...
Thanks Tim Graham and Loïc Bistuer for the reviews.
2016-08-23 22:40:07 +02:00
Tim Graham
1d1e246db6
Removed DateTimeAwareJSONEncoder alias.
2016-08-19 15:00:16 -04:00
Adam Chainz
19e20a2a3f
Fixed crash comparing CheckMessage objects to non-CheckMessage objects.
2016-08-16 17:17:34 -04:00
Michael Schwarz
72d541b61c
Fixed #27007 -- Handled non-UTF-8 bytes objects for text/* attachments.
...
The fallback logic which allows non-UTF-8 encoded files to be passed to
attach_file() even when a `text/*` mime type has been specified is
moved to attach(). Both functions now fall back to a content type of
`application/octet-stream`.
A side effect is that a file's content is decoded in memory instead of
opening it in text mode and reading it into a string.
Some mimetype-related logic in _create_attachment() has become
obsolete as the code moved from attach_file() to attach() already
handles this.
2016-08-12 16:35:09 -04:00
Claude Paroz
5fb22b4d4c
Fixed #27034 -- Made makemessages independent of USE_I18N
...
Thanks Tim Graham for the review.
2016-08-11 21:16:19 +02:00
Ed Morley
7399fee6c3
Refs #26947 -- Added a deployment system check for SECURE_HSTS_PRELOAD.
2016-08-10 20:31:01 -04:00
Antoine Fontaine
004ba05bca
Fixed #27036 -- Made locmem email backend's send_messages() accept generators.
2016-08-08 20:13:29 -04:00
Claude Paroz
a6baada7bd
Fixed #26940 -- Removed makemessages from no_settings_commands whitelist
...
As makemessages uses several settings for proper run (FILE_CHARSET,
LOCALE_PATHS, MEDIA_ROOT, and STATIC_ROOT), we should require settings
configuration for this command.
2016-08-08 19:52:57 +02:00
Johannes Dollinger
46509cf13d
Moved EmpytResultSet to django.core.exceptions.
...
This removes the need for some inner imports.
2016-08-08 10:43:34 -04:00
Peter Inglesby
e139ef5741
Fixed #27023 -- Prevented possibility of shell loading ~/.pythonrc.py twice.
2016-08-05 12:09:45 -04:00
Tim Graham
ccd5a23fba
Fixed #27000 -- Removed BaseCommand.usage() per deprecation timeline (refs #19973 ).
2016-08-02 18:50:12 -04:00
Tim Graham
aad46c3e37
Fixed #26930 -- Prevented makemigrations from accessing an empty database.
...
Thanks Liz Lemon for the report and investigation and
Claude Paroz for the test.
2016-08-01 07:57:12 -04:00
Tomas Pazderka
b820b6108a
Fixed #26896 -- Allowed a lazy base_url for FileSystemStorage.
2016-07-29 14:13:54 -04:00
Alex Hill
44a6b40280
Fixed #26915 -- Fixed regression handling responses returned from view middleware.
2016-07-25 13:41:50 -04:00
Claude Paroz
599393172b
Fixed #26826 -- Stripped spaces from dumpdata pks arguments
...
Thanks Kevin Graham Foster for the report and Tim Graham for the review.
2016-07-16 20:49:10 +02:00
Claude Paroz
3e71f6544f
Fixed #26897 -- Fixed makemessages crash on Python 2 with non-ASCII file names
...
Thanks Tim Graham for the review.
2016-07-14 20:37:56 +02:00
Will Hardy
8ef78b8165
Fixed #26656 -- Added duration (timedelta) support to DjangoJSONEncoder.
2016-07-14 13:34:15 -04:00
Dmitry S..ky / skype: dvska-at-skype
82be474efa
Fixed #26792 -- Allowed None for the value of cache.get_or_set().
2016-07-11 20:49:27 -04:00
Claude Paroz
04b7b28812
Fixed #26802 -- Prevented crash when attaching bytes as text message
...
Thanks Tim Graham for the review.
2016-07-08 11:58:05 +02:00
Berker Peksag
12b4280444
Fixed #21548 -- Added FileExtensionValidator and validate_image_file_extension.
2016-06-30 09:08:50 -04:00
Christopher Grebs
a9e188ccd6
Fixed #26119 -- Fixed URLValidator crash on URLs with brackets.
2016-06-28 15:43:43 -04:00
Berker Peksag
c1b6f554e4
Fixed #15091 -- Allowed passing custom encoder to JSON serializer.
2016-06-28 11:10:07 -04:00
Tim Graham
7e303d15c3
Refs #12594 -- Removed obsolete exception handling in handle_uncaught_exception().
...
Since 859fc020a7
, this is no longer needed.
2016-06-24 09:27:47 -04:00
Claude Paroz
742ea51413
Refs #24829 -- Made TemplateResponse.content available sooner in exception context
...
Thanks Tim Graham for the initial patch.
2016-06-24 10:22:30 +02:00
Tim Graham
81cdcb66bc
Fixed #26791 -- Replaced LiveServerTestCase port ranges with binding to port 0.
2016-06-23 12:04:05 -04:00
Tim Graham
cd217de610
Reverted "Fixed #26644 -- Allowed wrapping NamedTemporaryFile with File."
...
This reverts commit 1b407050dd
as it
introduces a regression in the test for refs #26772 .
2016-06-18 11:06:56 -04:00
Carl Meyer
7d1b69dbe7
Refs #26601 -- Improved backwards-compatibility of DEP 5 middleware exception handling.
2016-06-17 10:00:39 -07:00
Tim Graham
ea34426ae7
Fixed flake8 2.6 warnings.
2016-06-16 09:12:50 -04:00
Ville Skyttä
96f97691ad
Fixed broken links in docs and comments.
2016-06-15 21:20:23 -04:00
Hugo Osvaldo Barrera
1b407050dd
Fixed #26644 -- Allowed wrapping NamedTemporaryFile with File.
...
914c72be2a
introduced a regression that
causes saving a NamedTemporaryFile in a FileField to raise a
SuspiciousFileOperation. To remedy this, if a File has an absolute
path as a filename, use only the basename as the filename.
2016-06-14 09:28:08 -04:00
Jon Dufresne
cd88faa628
Removed unnecessary check in TemporaryUploadedFile.
...
If settings.FILE_UPLOAD_TEMP_DIR is the default value of None,
NamedTemporaryFile will work the same as if nothing was passed.
2016-06-11 20:45:11 -04:00
Berker Peksag
ae2a7da86b
Fixed #20468 -- Added loaddata --exclude option.
...
Thanks Alex Morozov for the initial patch.
2016-06-09 10:35:32 -04:00
Emad Mokhtar
c4980e28e5
Fixed #26290 -- Warned that paginating an unordered QuerySet may result in inconsistent results.
2016-06-08 14:09:24 -04:00
Berker Peksag
724dd2043e
Fixed #26717 -- Added Serializer.stream_class to customize the stream.
2016-06-08 11:08:18 -04:00
Anton I. Sipos
c3495bb984
Fixed #12666 -- Added EMAIL_USE_LOCALTIME setting.
...
When EMAIL_USE_LOCALTIME=True, send emails with a Date header
in the local time zone.
2016-06-04 09:55:50 -04:00
Jon Dufresne
779829662d
Fixed #26694 -- Made FileBasedCache.get() reraise non-ENOENT IOErrors.
2016-06-01 15:29:24 -04:00
Jon Dufresne
359be1c870
Fixed #26691 -- Removed checking for a file's existence before deleting.
...
File operations always raise a ENOENT error when a file doesn't exist.
Checking the file exists before the operation adds a race condition
condition where the file could be removed between operations. As the
operation already raises an error on a missing file, avoid this race and
avoid checking the file exists twice. Instead only check a file exists
by catching the ENOENT error.
2016-05-31 12:03:27 -04:00
Simon Charette
4f474607de
Fixed #26646 -- Added IOBase methods required by TextIOWrapper to File.
...
Thanks Tim for the review.
2016-05-27 21:05:58 -04:00
Ramiro Morales
6ab0d1358f
Fixed #26645 -- Fixed potential makemessages failures on Windows.
...
This was reflected by 27 i18n test errors (not failures) on such
platform caused by corrupt intermediate PO catalog files fed to
`msgmerge(1)`.
Made it handle in-memory PO/POT file contents with normalized line
separators (`'\n'`).
We need to perform manually this after using `subprocess.Popen` as we
can't pass it `universal_newlines=True`.
Also fixes #26670 in the process as this commit refactors the same code
section.
2016-05-27 21:02:14 -03:00
Alex Hill
779bb82f51
Fixed #26421 -- Refactored ModelSignal to use Apps.lazy_model_operation()
2016-05-19 21:33:36 -04:00
Alex Hill
2ff7ef15b0
Refs #26421 -- Refactored Apps.lazy_model_operation() for better checks and tests
2016-05-19 21:33:36 -04:00
Tim Graham
354acd04af
Refs #26601 -- Added a warning if both MIDDLEWARE AND MIDDLEWARE_CLASSES are set.
2016-05-17 07:24:45 -04:00
Tim Graham
ece4d24f8e
Refs #26601 -- Deprecated old-style middleware.
2016-05-17 07:22:26 -04:00
Florian Apolloner
9baf692a58
Fixed #26601 -- Improved middleware per DEP 0005.
...
Thanks Tim Graham for polishing the patch, updating the tests, and
writing documentation. Thanks Carl Meyer for shepherding the DEP.
2016-05-17 07:22:22 -04:00
Florian Apolloner
05c888ffb8
Refs #26601 -- Refactored BaseHandler to prepare for new-style middleware.
2016-05-17 07:20:56 -04:00
Simon Charette
f937c9ec97
Fixed #24100 -- Made the migration signals dispatch its plan and apps.
...
Thanks Markus for your contribution and Tim for your review.
2016-05-15 19:51:15 -04:00
Andre Cruz
929684d6ee
Fixed #21231 -- Enforced a max size for GET/POST values read into memory.
...
Thanks Tom Christie for review.
2016-05-12 10:17:52 -04:00
Raphael Gaschignard
8f6a1a1551
Fixed #26429 -- Added a timestamp to merge migration names.
...
This reduces the possibility of a naming conflict, especially after
squashing migrations.
2016-05-11 08:19:19 -04:00
Vasiliy Faronov
31e0314979
Fixed #26580 -- Updated references to obsolete RFC 2822.
...
Didn't rename django.utils.feedgenerator.rfc2822_date()
as some external code may rely on it.
2016-05-10 11:24:51 -04:00
Jarek Glowacki
c8df17b612
Included reverse deps in showmigrations
2016-05-08 13:53:36 +02:00
Sergei Maertens
ec009ef1d8
Fixed #25986 -- Fixed crash sending email with non-ASCII in local part of the address.
...
On Python 3, sending emails failed for addresses containing non-ASCII
characters due to the usage of the legacy Python email.utils.formataddr()
function. This is fixed by using the proper Address object on Python 3.
2016-05-06 14:34:11 -04:00
Claude Paroz
3204bc8e5e
Replaced a 'raw' six import
2016-05-04 20:59:52 +02:00
Claude Paroz
4731e9d82e
Fixed #26341 (again) -- Addressed multiple occurrences per line use case
2016-05-02 19:39:56 +02:00
Offby-One Kenobi
f2b2a35699
Fixed docstring typos.
2016-05-02 11:43:03 -04:00
Alasdair Nicol
eb5d7bc2f4
Fixed #26440 -- Added a warning for non-url()s in urlpatterns.
...
Thanks Burhan Khalid for the initial patch and knbk/timgraham
for review.
2016-04-30 20:09:31 -04:00
Cristiano
914c72be2a
Fixed #26058 -- Delegated os.path bits of FileField's filename generation to the Storage.
2016-04-30 17:22:40 -04:00
Claude Paroz
b16b124996
Fixed #26341 -- Fixed makemessages breaking location comments for HTML files
...
Thanks Sylvain Garancher for the report and Veranika Sabiashchanskaya for the
initial patch.
2016-04-30 12:08:20 +02:00
Anssi Kääriäinen
7f51876f99
Fixed #26207 -- Replaced dynamic classes with non-data descriptors for deferred instance loading.
2016-04-29 13:06:32 -04:00
David Evans
2fcafd169b
Fixed #26546 -- Allowed HTTPStatus enum values for HttpResponse.status.
2016-04-29 10:55:01 -04:00
Tim Graham
bb0b4b705b
Fixed #26052 -- Moved conditional_content_removal() processing to the test client.
2016-04-25 07:56:07 -04:00
Maxim Novikov
4d1c229ee5
Fixed #26495 -- Added name arg to Storage.save()'s File wrapping.
2016-04-21 10:40:48 -04:00
Carl Worth
40b69607c7
Fixed #26504 -- Avoided logging "Not Found" warnings if a middleware handles the 404.
...
For example, this avoids a warning in the case of a request that's
redirected to a language-prefixed URL by LocaleMiddleware.
2016-04-20 21:02:05 -04:00
Claude Paroz
836d475afe
Fixed #22561 -- Prevented too long lines in email messages
...
Thanks NotSqrt for the excellent report and Tim Graham for the review.
2016-04-19 09:35:24 +02:00
Claude Paroz
79a091820f
Converted property syntax in django.core.paginator
2016-04-15 17:16:55 +02:00
Berker Peksag
93deb1691e
Fixed #26492 -- Fixed "maximum recursion depth exceeded" migrate error.
...
A regression introduced in 0d3c616fbb2f49fa7ff6809e5a6777275352b35b;
refs #26351 .
2016-04-12 09:04:14 -04:00
Claude Paroz
0d3c616fbb
Refs #26351 -- Added check hook to support database-related checks
...
Thanks Tim Graham and Shai Berger for the reviews.
2016-04-08 20:28:00 +02:00
Tim Graham
df8d8d4292
Fixed E128 flake8 warnings in django/.
2016-04-08 09:51:06 -04:00
Przemysław Suliga
90ce5d46bf
Fixed #26462 -- Fixed Python 2 UnicodeEncodeError when warning about long cache keys.
2016-04-05 11:16:04 -04:00
Attila Tovt
02ae5fd31a
Fixed #25850 -- Made migrate/makemigrations error on inconsistent history.
2016-04-05 08:52:08 -04:00
Tim Graham
2cd2d18851
Fixed W503 flake8 warnings.
2016-04-04 17:14:26 -04:00
Przemysław Suliga
d356bb653f
Fixed #26460 -- Issued a single warning for invalid cache key
2016-04-04 15:20:55 -04:00