81ffedaacc
Fixed #31524 -- Removed minified static assets from the admin.
2020-05-14 16:07:56 +02:00
d522b51c40
Fixed #31575 -- Added system check for admin sidebar request context processor dependency.
...
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2020-05-14 11:00:51 +02:00
0a627dbe73
Removed unused Downcoder.chars.
...
Unused -- other than as a local variable -- since its introduction in
953badbea5
2020-05-13 21:07:14 +02:00
0668164b4a
Fixed E128, E741 flake8 warnings.
2020-05-12 08:52:23 +02:00
e6ec76d245
Updated JS admin translation catalog.
2020-05-11 22:59:27 +02:00
33f26339b7
Updated source translation catalogs.
2020-05-11 21:34:46 +02:00
46fe506445
Corrected indentation of #main div in admin base template.
2020-05-11 18:16:38 +02:00
d24ba1be7a
Fixed #31034 -- Added a navigation sidebar to the admin.
...
Co-authored-by: elky <elky@users.noreply.github.com>
Co-authored-by: Goetz <goetz.buerkle@gmail.com>
2020-05-11 18:16:38 +02:00
d6aff369ad
Refs #30116 -- Simplified regex match group access with Match.__getitem__().
...
The method has been available since Python 3.6. The shorter syntax is
also marginally faster.
2020-05-11 12:01:28 +02:00
fc0f7f6c15
Fixed #31157 -- Fixed displaying read-only JSONField values in admin.
2020-05-08 09:44:42 +02:00
6137ec2bf2
Changed selected attribute to HTML5 boolean syntax in SelectBox.js.
...
Per MDN, HTMLOptionElement.selected is a Boolean attribute.
2020-05-08 06:02:42 +02:00
3c5a586ce9
Fixed #31542 -- Simplified admin JavaScript with "for … of" statements.
2020-05-07 18:09:32 +02:00
aff7a58aef
Updated admin's Select2 to 4.0.13.
2020-05-05 11:30:02 +02:00
30083e0780
Fixed #31485 -- Updated admin's jQuery to 3.5.1.
2020-05-05 11:00:05 +02:00
f2051eb8a7
Removed invalid value from admin CSS.
...
The keyword value 'none' is not a valid value for padding-bottom.
2020-05-05 07:01:06 +02:00
e972752504
Removed unused CSS in admin.
...
.system-message, .system-message-title are unused since their
introduction in ce0d0cd9e26eb4f25692
2020-05-01 07:00:00 +02:00
448cdde935
Removed CSS workarounds for IE7 in admin.
2020-05-01 06:33:24 +02:00
29e35b9a3e
Refs #31032 -- Removed unnecessary vendor prefixes from admin CSS.
...
The CSS properties have been standardized and are available in all
supported browsers.
2020-05-01 06:26:36 +02:00
5869afe32b
Removed unnecessary entities from the admin.
...
Normal spaces are fine when used as a single spaced separation. For
larger spacing, CSS is used.
2020-04-29 11:40:24 +02:00
7271c8def4
Refs #31493 -- Changed IIFE to ES6 blocks.
2020-04-29 10:22:41 +02:00
5d37cc703b
Fixed #31493 -- Replaced var with const and let keywords in JavaScript.
...
The eslint configuration and the admin script compress.py have been
updated for ES6.
The unused fallback of globals.django in jquery.init.js was removed. It
is always included before jsi18n-mocks.test.js and it always sets the
global value.
2020-04-29 10:22:41 +02:00
0dafadadb9
Refs #30400 -- Improved typography of user facing strings in admin changelist.
2020-04-29 07:01:46 +02:00
9ef4a18dbe
Changed django.forms.ValidationError imports to django.core.exceptions.ValidationError.
...
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2020-04-28 10:49:00 +02:00
abea86f9e4
Removed unnecessary tuple wrapping of single format string argument.
2020-04-27 08:30:16 +02:00
f48a1990fb
Made compress.py script use the official google-closure-compiler release.
...
The script previously used the PyPI package closure, which is slightly
out of date and not maintained by Google.
The JavaScript contribution docs and the compress.py script now runs the
google-closure-compiler package in the recommended way. Google's
documentation on usage and installation can be found at:
https://github.com/google/closure-compiler-npm/tree/master/packages/google-closure-compiler#usage
This also makes the usage simpler as the package now runs through npm's
npx utility, which will automatically install google-closure-compiler to
a per-user cache.
2020-04-22 16:19:27 +02:00
f27482f147
Fixed #31483 -- Rewrote change_form.js without jQuery.
...
The use of $(document).ready() was removed. The script is loaded at the
end of the document. Therefore, the referenced DOM elements are already
available and the script does not need to wait for the full DOM to be
ready before continuing.
Now that the script has no external dependencies, it can be loaded
asynchronously. As such, the async attribute was added to the script
element.
2020-04-22 15:44:55 +02:00
a8bb53dbd2
Refs #31483 -- Removed CSS and JavaScript for unused HTML class add-another.
...
The HTML class was removed in 07988744b3
2020-04-22 15:44:55 +02:00
fb9b1c245d
Updated admin's XRegExp to 3.2.0.
2020-04-22 08:45:14 +02:00
0f2885e3f6
Simplified collapse.js with Element.closest().
2020-04-22 06:13:58 +02:00
dfbd9ca065
Fixed #30311 -- Restored ability to override global admin actions.
2020-04-17 20:23:00 +02:00
96c6f9c61c
Fixed #31441 -- Ensured TabluarInline expands when child inputs have errors.
2020-04-16 12:17:49 +02:00
b4e7bf5284
Refs #31441 -- Added red border to inputs with errors for TabluarInline.
2020-04-16 12:17:49 +02:00
daabb102c0
Fixed #31470 -- Fixed fieldset admin CSS to prevent overflowing <pre> elements.
...
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2020-04-16 10:47:42 +02:00
d51c50d836
Fixed #31462 -- Allowed overriding autocomplete/raw_id_fields/filter widgets for ManyToManyFields with formfield_overrides.
2020-04-15 08:33:40 +02:00
b9336b78cf
Fixed #31404 -- Changed selector-chosen's multiple attribute to HTML5 boolean syntax.
2020-03-27 08:38:58 +01:00
55cdf6c52d
Fixed #29724 -- Fixed timezone handling in ModelAdmin.date_hierarchy queries.
...
Thanks Alexander Holmbäck for the initial patch.
2020-03-25 21:03:41 +01:00
be648d1c45
Fixed #31391 -- Removed jQuery usage in cancel.js
...
Now that cancel.js has no dependencies, it can be loaded asynchronously.
Co-Authored-By: François Freitag <mail@franek.fr>
2020-03-24 11:09:29 +01:00
3a807a6f59
Fixed #31365 -- Removed jQuery usage in SelectFilter2.js.
2020-03-24 09:14:22 +01:00
f982f0bdb8
Refs #31032 -- Removed unsupported browsers workarounds and comments in admin's JavaScript.
...
Since 8b30360322
2020-03-23 06:19:10 +01:00
25d450c852
Removed unused return values in SelectFilter2.js.
2020-03-17 13:52:29 +01:00
9cf4e40b84
Simplified SelectFilter2 with Element.closest().
...
https://developer.mozilla.org/en-US/docs/Web/API/Element/closest
2020-03-17 12:04:14 +01:00
3857a08bdb
Fixed #31361 -- Fixed invalid action="" in admin forms.
...
The attribute action="" (empty string) on the <form> element is invalid
HTML5. The spec (https://html.spec.whatwg.org/#attr-fs-action ) says:
> The action and formaction content attributes, if specified, must have
> a value that is a valid non-empty URL potentially surrounded by
> spaces.
Emphasis on non-empty. The action attribute is allowed to be omitted, in
which case the current URL is used which is the same behavior as now.
2020-03-16 07:31:19 +01:00
eb77e80de0
Fixed #31349 -- Used :nth-child() CSS pseudo-class to style alternative rows in admin.
2020-03-09 12:34:32 +01:00
a4881f5e5d
Fixed #31307 -- Fixed filter_horizontal add/remove SVG :hover positioning.
2020-02-27 15:39:13 +01:00
b457068cf2
Fixed #31187 -- Fixed detecting of existing total ordering in admin changelist when using Meta.constraints.
...
Detection of existing total ordering in admin changelist now takes into
account non-partial unique constraints.
2020-02-19 09:36:23 +01:00
335c9c94ac
Simplified imports from django.db and django.contrib.gis.db.
2020-02-04 13:20:06 +01:00
5dabb6002e
Updated translations from Transifex.
...
Forwardport of ca4f87027e
2020-01-31 20:59:10 +01:00
b7a3a6c9ef
Used model's Options.label/label_lower where applicable.
2020-01-29 12:09:20 +01:00
5d654e1e71
Refs #27888 -- Removed redundant {% if %} in admin changelist filters.
2020-01-24 20:31:09 +01:00
b94764e178
Fixed #27888 -- Added link to clear all filters in the admin changelist view.
2020-01-23 14:14:54 +01:00
68e018010b
Optimized ModelAdmin._changeform_view() by avoiding multiple get_fieldsets() calls.
...
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
2020-01-17 16:00:04 +01:00
77d335e5ab
Fixed #31160 -- Fixed admin CSS for ordered lists' descendants in unordered list.
2020-01-13 09:13:33 +01:00
8b3e714ecf
Fixed #30980 -- Improved error message when checking uniqueness of admin actions' __name__.
...
Thanks Keshav Kumar for the initial patch.
2020-01-10 14:00:28 +01:00
372eaa395f
Fixed #28991 -- Added EmptyFieldListFilter class in admin.filters.
...
Thanks Simon Charette and Carlton Gibson for reviews.
Co-Authored-By: Jonas Haag <jonas@lophus.org>
Co-Authored-By: Christophe Baldy <christophe.baldy@polyconseil.fr>
2020-01-03 07:58:04 +01:00
b2bd08bb7a
Fixed #30892 -- Fixed slugify() and admin's URLify.js for "İ".
...
Thanks Luis Nell for the implementation idea and very detailed report.
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2019-12-30 20:47:22 +01:00
cf5d4701dc
Fixed #30819 -- Fixed year determination in admin calendar widget for two-digit years.
...
Two-digit years in the range of [00, 68] are in the current century,
while [69,99] are in the previous century, according to the Open Group
Specification.
2019-12-30 13:06:29 +01:00
35d36d9462
Refs #30585 -- Updated project templates and tests to use (block)translate tags.
2019-12-18 13:15:38 +01:00
e703b93a65
Fixed #31080 -- Removed redundant type="text/javascript" attribute from <script> tags.
2019-12-11 09:49:54 +01:00
65285d1e7d
Refs #29892 -- Made Selenium tests wait for popups to be ready.
2019-12-02 15:06:36 +01:00
6376278a90
Updated contrib translations from Transifex.
...
Forward port of 4afa0e5d2a
2019-12-02 11:25:23 +01:00
11c5e0609b
Fixed CVE-2019-19118 -- Required edit permissions on parent model for editable inlines in admin.
...
Thank you to Shen Ying for reporting this issue.
2019-12-02 08:56:08 +01:00
46a0edc3ba
Fixed #31028 -- Used classList API to check, add and remove DOM classes.
...
Thanks to Claude Paroz for review.
2019-11-28 15:21:37 +01:00
c8bd37a860
Fixed #31042 -- Removed AdminSeleniumTestCase.get_css_value() in favor of Selenium .is_displayed().
...
All instances of AdminSeleniumTestCase.get_css_value() were used to
inspect the display property.
2019-11-28 15:10:13 +01:00
249a6190ae
Fixed #30975 -- Replaced custom get_select_option with Selenium's select_by_value.
2019-11-27 16:34:07 +01:00
69dbb6b708
Fixed #30973 -- Converted selenium tests wait_page_loaded to context manager.
2019-11-27 14:36:26 +01:00
cab3661832
Fixed #31027 -- Replaced .getAttribute()/.setAttribute() usage with DOM properties.
2019-11-27 07:53:04 +01:00
52936eface
Fixed #31031 -- Fixed data loss in admin changelist view when formset's prefix contains regex special chars.
...
Regression in b18650a263
2019-11-26 08:48:10 +01:00
ef93fd4683
Fixed #31013 -- Removed jQuery usage in SelectBox.js.
2019-11-25 13:35:20 +01:00
0284a26af9
Fixed #30981 -- Fixed admin changelist crash when using F() or OrderBy() expressions in admin_order_field.
2019-11-19 15:40:04 +01:00
89abecc75d
Fixed #27272 -- Added an on_delete RESTRICT handler to allow cascading deletions while protecting direct ones.
2019-11-19 10:55:05 +01:00
4c45b627f8
Removed unused import of ACTION_CHECKBOX_NAME in django.contrib.admin.
...
Unused since e651b3095c
2019-11-06 12:49:42 +01:00
b9fe7f9294
Fixed #30947 -- Changed tuples to lists in model Meta options in django.contrib modules.
...
The Django "Model Meta options" docs provide examples and generally
point the reader to use lists for the unique_together and ordering
options. Follow our own advice for contrib models.
More generally, lists should be used for homogeneous sequences of
arbitrary lengths of which both unique_together and ordering are.
2019-11-05 08:16:31 +01:00
607004f81a
Simplified consecutive calls to pathlib.Path.parent.
2019-11-04 09:59:34 +01:00
a6cb8ec389
Fixed #30922 -- Fixed ModelAdmin.date_hierarchy queries with DST changes.
...
There was an issue where admin date_hierarchy didn't render last day of
a month in DST-switch month.
2019-10-29 11:21:03 +01:00
e3d0b4d550
Fixed #30899 -- Lazily compiled import time regular expressions.
2019-10-29 09:22:26 +01:00
24e540fbd7
Fixed #29087 -- Added delete buttons for unsaved admin inlines on validation error.
2019-10-25 13:28:08 +02:00
6ea3aadd17
Refs #29087 -- Refactored admin inlines.js.
...
Split logic into separate functions to clarify and allow reuse.
2019-10-25 13:28:08 +02:00
26c66f4519
Fixed #30856 -- Combined fast-delete queries by model during cascade deletion.
...
Reduced the number of queries required when performing cascade deletion
for a model referenced multiple time by another one by performing an
union of reference lookups.
2019-10-09 09:49:53 +02:00
b1d6b35e14
Fixed #30725 -- Fixed width of DateTimeField inputs in admin tabular inline.
...
"width" of DateTimeField inputs in admin tabular inline wasn't set
correctly what caused displaying too small inputs with responsive CSS
when timezone warning wasn't present.
2019-09-17 14:30:33 +02:00
b9db423d3c
Fixed #29376 -- Allowed hiding "Save and Add Another" button in admin.
2019-09-16 11:37:09 +02:00
5495ea3ae0
Updated translation catalogs
2019-09-08 17:35:32 +02:00
a44d80f88e
Adjusted subprocess.run() calls to use arg list, rather than string.
...
The Python docs recommend passing a sequence to subprocess.run() when
possible. Doing so allows for automatic escaping and quoting of
arguments.
https://docs.python.org/3/library/subprocess.html#frequently-used-arguments
> args is required for all calls and should be a string, or a sequence
> of program arguments. Providing a sequence of arguments is generally
> preferred, as it allows the module to take care of any required
> escaping and quoting of arguments (e.g. to permit spaces in file
> names).
Also removed `shell=True` where unnecessary.
2019-08-28 10:19:30 +02:00
8f6860863e
Fixed #30722 -- Added default rate-limiting requests to admin's Select2 widget.
2019-08-27 13:47:36 +02:00
06372a8d27
Fixed #30507 -- Updated admin's jQuery to 3.4.1.
2019-08-23 11:00:16 +02:00
9386586f31
Replaced subprocess commands by run() wherever possible.
2019-08-23 10:53:36 +02:00
5b4c6b58a0
Fixed #30064 -- Added form to validate admin search fields query input.
2019-08-22 14:09:49 +02:00
8289fc55ff
Refs #30449 -- Made RelatedOnlyFieldListFilter respect ModelAdmin.ordering.
2019-08-15 10:29:10 +02:00
00d4e6f8b5
Updated Select2 to version 4.0.7.
2019-07-10 12:31:16 +02:00
ed668796f6
Fixed #30543 -- Fixed checks of ModelAdmin.list_display for fields accessible only via instance.
...
Co-Authored-By: Andrew Simons <andrewsimons@bubblegroup.com>
2019-07-10 10:37:34 +02:00
d54baf6970
Updated translations from Transifex
...
Forward port of b3f7262e6e
2019-06-29 16:17:16 +02:00
42b9a23267
Fixed #30400 -- Improved typography of user facing strings.
...
Thanks Claude Paroz for assistance with translations.
2019-06-28 16:46:18 +02:00
ad7b438002
Bumped minimum ESLint version to 4.18.2.
2019-06-21 17:57:35 +02:00
87f5d07eed
Fixed #12952 -- Adjusted admin log change messages to use form labels instead of field names.
2019-06-14 18:20:29 +02:00
f9561144d7
Fixed #30520 -- Fixed crash of admin model inlines on custom fields without labels.
2019-06-04 10:27:12 +02:00
34ec52269a
Applied jQuery patch for CVE-2019-11358.
2019-06-03 11:36:12 +02:00
deeba6d920
Fixed CVE-2019-12308 -- Made AdminURLFieldWidget validate URL before rendering clickable link.
2019-06-03 11:36:12 +02:00
e286987a27
Fixed #30459 -- Delegated hide/show JS toggle to parent div.
...
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2019-05-17 07:46:45 +02:00
8eb4133714
Always remove required attribute in SelectFilter2.js ( #11331 )
...
Fixes bug on browsers which do support the required attribute but not the :valid pseudo-selector
2019-05-07 08:16:30 +02:00
efeceba589
Fixed #30312 -- Relaxed admin check from django.contrib.sessions to SessionMiddleware subclasses.
2019-04-26 11:31:06 +02:00
8b3f1c35dd
Removed unnecessary assignments in various code.
2019-04-24 13:09:29 +02:00
Jon Dufresne
Mariusz Felisiak
Claude Paroz
Tom Carrick
dbxnr
François Freitag
hashlash
Hasan Ramezani
Nick Pope
007
zriv
Fabio Sangiovanni
Daniel Hahler
Owen T. Heisler
Adam Donaghy
Federico Jaramillo Martínez
Sjbrgsn
Farhaan Bukhsh
Mike Hansen
Carlton Gibson
Johannes Hoppe
Baptiste Mispelon
Daniel Izquierdo
Erwin Junge
Simon Charette
Min ho Kim
Dulmandakh
zeyneloz
Markus Holtermann
Sanyam Khurana
Jones Ambrosi
Ben Muschol
Aarni Koskela