04e6542b5a
Fixed #19423 -- Prevented ModelAdmin sharing widgets due to formfield_overrides
...
Thanks joebuyer at manycycles.com for the report and Simon Charette
for the review.
2012-12-08 12:41:11 +01:00
6140795150
Fixed a string detection in ogrinspect.py
2012-12-08 12:19:39 +01:00
c91667338a
Fixed #19357 -- Allow non-ASCII chars in filesystem paths
...
Thanks kujiu for the report and Aymeric Augustin for the review.
2012-12-08 11:13:52 +01:00
66dfcc10b3
Fixed #18574 -- Make BaseFormSet.is_valid call its underlying forms' is_valid
...
Thanks Simon Charette for the report and the initial patch.
2012-12-06 20:00:56 +01:00
34dcf51e06
Fixed #19367 -- Fixed saving ContentFile in filesystem storage
...
This was not working properly when ContentFile was initialized with
an unicode string.
Thanks Alexey Boriskin for the report and the test.
2012-12-06 17:14:44 +01:00
553838a285
Fixed #19429 -- Applied linebreaksbr to read-only fields in inlines
...
Applied to inlines what ec9d6b1122
2012-12-06 09:52:02 +01:00
45f00dbb93
Minor idiomatic and docstring edits in ar localflavor.
2012-12-04 19:48:39 -03:00
795ac7deda
Fixed #19378 -- Ensured get_success_url returns a non-lazy URL
2012-12-04 13:22:42 +01:00
501c7a221c
Merge pull request #573 from tominsam/master
...
Fixed #19070 : urlize template filter raises exception in some cases
2012-12-04 02:18:10 -08:00
b64d30405a
Fixed #18697 -- Made values accepted for two customizable admin templates consistent.
...
Thanks and at cloverfastfood dot com for the report.
2012-12-04 01:13:01 -03:00
88e1715639
Fixed #19318 -- Ensured that the admin's SimpleListFilter options can be displayed as selected even if the lookup's first element is not a string.
2012-12-03 11:53:15 -08:00
5fa5621f57
Fixed #19416 -- Fixed multi-line commands in initial SQL files
...
Thanks Aymeric Augustin for detecting this regression.
2012-12-03 20:47:08 +01:00
6d27547d20
Merge pull request #569 from orblivion/master
...
Fixed typo in ValuesQuerySet._as_sql docstring
2012-12-03 08:51:40 -08:00
74809fdcc7
cope with unsplittable urls in smarl_urlquote.
2012-12-03 12:13:24 +00:00
baae4b8187
Fixed #19397 -- Crash on binary files in project templates.
...
Thanks gw 2012 at tnode com for the report.
2012-12-03 10:45:18 +01:00
2e2c4968f6
Fixed #17050 -- Added some CSS class names to the admin index pages to facilitate per-app or per-model style customizations. Thanks to scytale for the report and to H0ff1 and thiderman for their work on the patch.
2012-12-02 20:54:34 -08:00
0ff1d4fa49
Typeo in ValuesQuerySet._as_sql docstring
2012-12-01 18:55:26 -08:00
90d3af380e
Fixed #19015 -- Removed ISO formats from localized formats.py
...
ISO formats are automatically appended to the list of input
formats. Kept only when it is specified in first position, as it
has a special meaning in localize_input.
Thanks Bojan Mihelac for the report.
2012-12-01 14:15:06 +01:00
349c4c37f8
Fixed #19015 -- Add ISO input formats to all formats
2012-12-01 14:05:52 +01:00
c0efbc7b53
Fixed #19347 -- Removed unused variable definition in FetchFromCacheMiddleware
...
Thanks gregplaysguitar at gmail.com for the report.
2012-12-01 13:52:26 +01:00
a0cd6dd11e
Fixed #19349 -- Fixed re-rendering of ReadOnlyPasswordHashWidget
...
Thanks tim.bowden at mapforge.com.au for the report, Andreas Hug
for the patch and Anton Baklanov for the review.
2012-12-01 12:22:43 +01:00
84a5294788
Added missing custom user skip decorator
...
PermissionDeniedBackendTest references User model.
2012-11-30 22:54:42 -08:00
0eeae15056
Fixed #19354 -- Do not assume usermodel.pk == usermodel.id
...
Thanks markteisman at hotmail.com for the report.
2012-11-29 21:45:43 +01:00
d913a8b412
Fixed #19356 -- Increased session key entropy.
2012-11-29 16:36:43 +01:00
514ce1d35f
Fixed two docstring/comment typos.
2012-11-28 20:28:30 -03:00
cc3c4a9d55
Fixed #19366 -- Prevented GEOSIndexError when comparing geometries
...
Thanks Craig de Stigter for the report and collaboration on the
patch.
2012-11-28 22:34:02 +01:00
6ebf115206
Fixed #14694 -- Made ``defer()`` work with reverse relations
...
Reverse o2o fields are now usable with defer.
2012-11-28 18:17:10 +02:00
c10aaa70a4
Fixed #19370 -- Made date filter properly handle midnight value
2012-11-27 21:24:16 +01:00
d37483c533
Removed duplicate opts.pk_index() method
2012-11-27 21:54:46 +02:00
86644e065f
Refactored gis/spatialite connection initialization
...
The connection state is now initialized in get_new_connection().
Refs #19274 .
2012-11-27 19:47:22 +02:00
905ea9619b
Made sure global settings are changed in test db creation
...
There was an assumption that changing connection.settings_dict changed
also the settings.DATABASES values. This assumption is now gone.
2012-11-27 19:47:20 +02:00
1893467784
Fixed #19274 -- Made db connection creation overridable in subclasses
...
Connection creation was done in db backend ._cursor() call. This
included taking a new connection if needed, initializing the session
state for the new connection and finally creating the connection.
To allow easier modifying of these steps in subclasses (for example to
support connection pools) the _cursor() now calls get_new_connection()
and init_connection_state() if there isn't an existing connection. This
was done for all non-gis core backends. In addition the parameters used
for taking a connection are now created by get_connection_params().
We should also do the same for gis backends and encourage 3rd party
backends to use the same pattern. The pattern is not enforced in code,
and as the backends are private API this will not be required by
documentation either.
2012-11-27 19:47:19 +02:00
2ea80b94d7
Fixed #19362 -- Detected invalid use of @python_2_unicode_compatible.
...
Thanks m3wolf for the report and akaariai for reproducing the problem.
2012-11-27 09:45:37 +01:00
29d59a879e
Fixed #17911 -- Ensure that admin readonly fields' display values are shown in change forms when the raw value is None.
2012-11-25 23:13:30 +01:00
05dbc07c52
Merge pull request #476 from wraithan/patch-1
...
Indented comments consistently in project template
2012-11-25 12:04:52 -08:00
e18968e0f2
Merge pull request #518 from vanschelven/patch-1
...
Fixed interpolation in a translated string.
Refs #14678 .
2012-11-25 11:59:34 -08:00
ae206d78f6
Fixed #17646 -- Added a get_list_filter() method to ModelAdmin. Thanks to rasca for the suggestion and to mateusgondim for the patch.
2012-11-25 20:39:23 +01:00
7644800070
Change exception type to reduce confusion.
...
TemplateSyntaxError is expected at compile time, not at run time.
Refs #19280 .
2012-11-25 19:51:42 +01:00
a5d47415f4
Enabled SimpleTestCase to be decorated by override_settings
...
Refs #18417 . Also fixed some test case classes which subclassed
the wrong parent.
2012-11-25 19:06:17 +01:00
9f7cefd505
Fixed #18417 -- Raised exception when unittest.TestCase is decorated with override_settings
2012-11-25 19:06:17 +01:00
612357f8ef
Fixed #19355 -- Improved LiveServerThread's handling of exceptions. Thanks to flub for the report.
2012-11-25 12:55:23 +01:00
9d7130e066
Merge pull request #554 from zedr/master
...
Minor spelling error in a docstring
2012-11-24 13:47:09 -08:00
d266919584
Fixed #19280 -- Raised an explicit exception for the old {% url %} syntax.
2012-11-24 22:10:51 +01:00
abd0e76d2d
Fixed #19293 -- Updated Czech input formats
...
Thanks vzima for the report.
2012-11-24 19:18:54 +01:00
35a0fff28a
Fixed #18722 -- Adjusted width of sortable columns in admin
...
Thanks Simon Charette for the report.
2012-11-24 17:12:59 +01:00
a962bc7c45
Updated User manager when testing custom AUTH_USER_MODEL
...
This is giving more real test conditions when AUTH_USER_MODEL is
set with override_settings.
2012-11-24 16:00:00 +01:00
08b4a22293
Updated stale docstring of setup_joins
2012-11-24 16:26:05 +02:00
bf1871d874
Fixed #19237 -- Improved strip_tags utility
...
The previous pattern didn't properly addressed cases where '>'
was present inside quoted tag content.
2012-11-24 12:16:52 +01:00
be64dd35fb
Fixed #19343 -- Deadlock with TransactionTestCase + TEST_MIRROR + multi_db.
...
Thanks Jeremy Dunck for the review.
2012-11-24 09:48:21 +01:00
f2d8004967
Removed some stray debug lines introduced accidentally in c8985a8.
2012-11-24 15:26:36 +08:00
c8985a8a73
Fixed #19806 -- Ensure that content types and permissions aren't created for swapped models.
...
Thanks to rizumu for the report.
2012-11-24 13:43:20 +08:00
0a0a0d66b3
Fixed #19351 -- SQLite bulk_insert of more than 500 single-field objs
2012-11-24 01:13:12 +02:00
a27582484c
Fixed SQLite's collapsing of same-valued instances in bulk_create
...
SQLite used INSERT INTO tbl SELECT %s UNION SELECT %s, the problem
was that there should have been UNION ALL instead of UNION.
Refs #19351
2012-11-24 01:12:17 +02:00
90b86291d0
Fixed #18375 -- Removed dict-ordering dependency for F-expressions
...
F() expressions reuse joins like any lookup in a .filter() call -
reuse multijoins generated in the same .filter() call else generate
new joins. Also, lookups can now reuse joins generated by F().
This change is backwards incompatible, but it is required to prevent
dict randomization from generating different queries depending on
.filter() kwarg ordering. The new way is also more consistent in how
joins are reused.
2012-11-23 19:53:04 +02:00
7b9a1fb964
Fixed cursor commit command in PostGIS backend
...
Thanks Bruno Renié for noticing the error.
2012-11-23 17:20:36 +01:00
2bca9a4eda
Fix spelling error in the docstring
2012-11-23 16:20:18 +00:00
fbd1df8e16
Fixed #19152 -- Allowed PostGIS tests to be run without template
...
From version 2, a PostGIS template is no longer required to create
a GIS-enabled database.
2012-11-23 16:06:31 +01:00
891c530624
Fixed #18984 -- Avoided a deadlock in test teardown.
...
Thanks Jeremy Dunck for the report.
2012-11-22 20:55:50 +01:00
a026e480da
Fixed #16039 -- Made post_syncdb handlers multi-db aware.
...
Also reverted 8fb7a90026#17055 .
2012-11-22 20:53:59 +01:00
ea6b95dbec
Fixed #19316 -- Set View args/kwargs/request before dispatch
2012-11-22 20:13:01 +01:00
9e11253497
Merge pull request #511 from ryankask/username-password-admin
...
Allowed custom User models to use the UserAdmin's change password view.
Fix #19056 (again).
2012-11-22 06:50:37 -08:00
7b2d95eb30
Clarified usage of as_view kwargs for setting arguments on class based views
...
Thanks Dave McLain for the patch.
2012-11-22 09:07:21 -05:00
3fb83729b9
Merge branch 'ticket_19325' of https://github.com/hannesstruss/django into hannesstruss-ticket_19325
2012-11-22 10:05:08 +01:00
48e8b5e944
Add orphans support to MultipleObjectMixin
...
Fixes #7005
2012-11-21 16:50:23 +13:00
fbfa654a15
Paginator._get_page hook
...
This allows for Paginator subclasses to easily override the Page class
that gets used.
Took the opportunity to also do some non-invasive PEP8 tidying of the
paginator module.
2012-11-21 15:19:44 +13:00
8fdb28219d
Fixed #19331 (again) use the right admin named URL.
...
This allows us to get the trailing slash in URLs without having to
manually assemble and hard-code them.
See also commits e9497a, a222d6, f51eab, 5a9e12.
2012-11-20 21:05:32 -03:00
8c21c53c8b
Fixed #19331 -- Added missing trailing slash in auth admin template
...
Thanks ppetrid at yawd.eu for the report.
2012-11-20 19:19:50 +01:00
f9891f2087
Fixed #19325 - Made email backend of AdminEmailHandler configurable
2012-11-20 11:23:12 +01:00
d179794c6b
Fix typo in comment
2012-11-19 19:31:21 -06:00
edf7ad36fa
Fixed #18658 -- Improved ModelAdmin.message_user API
...
Thanks to Lowe Thiderman for the patch and tests
2012-11-19 16:03:09 -08:00
9b755a298a
Fixed #19291 -- Completed deprecation of ADMIN_MEDIA_PREFIX.
2012-11-17 22:38:19 +01:00
778b8bdcf4
Merge pull request #467 from tomchristie/page-kwarg
...
Add 'page_kwarg' attribute to `MultipleObjectMixin`, removing hardcoded "page".
2012-11-17 12:27:01 -08:00
730977046b
Merge pull request #466 from kenthauser/ticket_19025
...
#19025 Add `form` to formwizard context (includes tests)
2012-11-17 12:23:48 -08:00
1520748dac
Fixed #2550 -- Allow the auth backends to raise the PermissionDenied exception to completely stop the authentication chain. Many thanks to namn, danielr, Dan Julius, Łukasz Rekucki, Aashu Dwivedi and umbrae for working this over the years.
2012-11-17 20:24:54 +01:00
e0363c688d
Fixed #19114 -- Fixed LogEntry unicode representation
...
Thanks niko at neagee.net for the report and Emil Stenstrom for
the patch.
2012-11-17 19:19:59 +01:00
2a67374b51
Fixed #19036 -- Fixed base64 uploads decoding
...
Thanks anthony at adsorbtion.org for the report, and johannesl for
bringing the patch up-to-date.
2012-11-17 17:25:21 +01:00
9e7723f851
Refactor loaddata for readability.
...
Thanks Claude Paroz and Daniel Moisset for review and feedback.
2012-11-17 13:18:01 -03:00
ec9d6b1122
Fixed #19226 -- Applied linebreaksbr to read-only fields in admin
...
Thanks shadow for the report, and Melevir and thiderman for the
patch.
2012-11-17 17:06:24 +01:00
8c69278764
Fixed #18989 -- Removed unused condition in CursorWrapper
...
Thanks zimnyx for the report.
2012-11-17 16:34:14 +01:00
233f86443c
Merge pull request #490 from gabrielhurley/reverse-prefix-special-chars
...
Fixed #18210 -- Escaped special characters in reverse prefixes.
2012-11-17 06:49:18 -08:00
4a5e8087ac
Fixed #19136 -- Properly escape gettext context prefixes in the i18n JavaScript view template.
2012-11-17 15:37:30 +01:00
44046e8a38
Fixed #18985 -- made DeprecationWarnings loud
...
Capture warnings in Python >= 2.7 and route through
console handler, which is subject to DEBUG==True
Thanks to dstufft for the idea, and claudep for initial patch
2012-11-16 17:07:38 -08:00
d8ee46afff
comment_will_be_sent can cause a 400, not a 403
...
Doc cleanup for django.contrib.comments.signals.comment_will_be_sent
If a receiver returns False, an HttpResponse with status code 400
is returned. A test case already exists confirming this behavior.
Updated docs to reflect reality.
2012-11-16 10:19:54 -05:00
ff0d3126af
Fixed #19296 -- Applied test connection sharing for spatialite
...
Thanks pegler at gmail.com for the report and the initial patch.
2012-11-16 14:32:36 +01:00
5e3b99d4cf
Update django/contrib/flatpages/forms.py
...
Translate before passing in the variables (i.e. close the bracket earlier).
If you translate after passing in the variables the translated value will contain the actual values for 'url' and 'site' and will therefore not be translated.
(I'm not actually using django's flatpages, but I ran into this apparent error when doing a global grep on my own project)
2012-11-15 22:53:08 +01:00
7cfb567e45
Another regression fix for select_related handling
...
This time gis compiler.get_default_columns() wasn't up to date. Thanks
to CI another regression fixed.
Refs #13781
2012-11-15 21:33:56 +02:00
1194a96999
Fixed a regression in select_related
...
The regression was caused by the fix for #13781 (commit
f51e409a5f
2012-11-15 20:17:57 +02:00
f51e409a5f
Fixed #13781 -- Improved select_related in inheritance situations
...
The select_related code got confused when it needed to travel a
reverse relation to a model which had different parent than the
originally travelled relation.
Thanks to Trac aliases shauncutts for report and ungenio for original
patch (committed patch is somewhat modified version of that).
2012-11-15 17:15:21 +02:00
92d7f541da
Fixed #19058 -- Fixed Oracle GIS crash
...
The problem is the same as in #10888 which was reintroduced when
bulk_insert was added. Thanks to Jani Tiainen for report, patch and
also testing the final patch on Oracle GIS.
2012-11-15 16:08:06 +02:00
550ddc66b4
Fixed #19272 -- Fixed gettext_lazy returned type on Python 2
...
Thanks tyrion for the report.
2012-11-14 10:50:15 +01:00
1620c27936
Fixed #19186 -- Fixed sending mail with unicode content on Python 3
...
Thanks alex_po for the report and Luke Plant for the analysis.
2012-11-14 10:43:33 +01:00
ebcf6b36ff
Fixed select_related performance regressions
...
The regression was caused by select_related fix for Oracle, commit
c159d9cec0
2012-11-13 22:52:58 +02:00
ce1af8d702
Removed use of SortedDict for query.alias_refcount
...
This will have a smallish impact on performance. Refs #19276 .
2012-11-13 22:48:25 +02:00
fa18b0ac89
Some changes to SortedDict to make it faster under py2
...
Refs #19276
2012-11-13 22:48:25 +02:00
09a39ca082
Negligible spacing fix in utils/log.py
2012-11-12 14:19:11 -06:00
6c69de80bd
Tweaked cache key creation to avoid strict typing.
...
This is a provisional change. See #19221 for details.
2012-11-11 21:23:45 +01:00
4c5cea7073
Merge pull request #218 from mgrouchy/ticket_18582
...
Fixed #18582 -- Added a no-op close to BaseCache
2012-11-11 07:18:45 -08:00
cc0ac26f4a
Fixed #19273 -- Fixed DB cache backend on pg 9.0+ and py3
...
There was a problem caused by Postgres 9.0+ having bytea_output default
value of 'hex' and cache backend inserting the content as 'bytes' into
a column of type TEXT. Fixed by converting the bytes value to a string
before insert.
2012-11-10 19:42:20 +02:00
bfdedb687a
Allow custom User models to use the UserAdmin's change password view.
2012-11-10 15:48:46 +00:00
04a7ea3283
Removed an impossible code path in cache function
2012-11-10 15:42:27 +01:00
34162698cc
Fixed #14264 -- Ensured settings.configure configures logging
...
Thanks Matt McDonald for the patch.
2012-11-10 12:05:58 +01:00
4d817b3887
Fixed #19262 -- Support cookie pickling in SimpleTemplateResponse
...
Refs #15863 .
2012-11-09 21:07:53 +01:00
1b307d6c8f
Fixed #19261 -- Delayed Queryset evaluation in paginators
...
Thanks trbs for the report and the patch.
2012-11-09 19:41:57 +01:00
aea8bf0662
Added missing encoding preamble to gis tests.
...
'coverage html' did fail without it.
Thanks to Claude Paroz for figuring it out.
2012-11-09 15:16:06 +01:00
9942adac17
Made Page class inherit collections.Sequence
2012-11-08 16:13:23 +01:00
cafb266954
Fixed #17144 -- MySQL again groups by PK only
...
Thanks to Christian Oudard for the report and tests.
2012-11-08 00:56:32 +02:00
9a09558e9f
Fixed #19257 -- Don't swallow command's KeyError in call_command
...
Thanks Giovanni Bajo for the report.
2012-11-07 18:28:53 +01:00
79dd751b0b
Fixed #14315 -- Made memcached backend handle negative incr/decr values
...
Thanks Michael Manfre for the report and initial patch and
Tobias McNulty for the review.
2012-11-06 12:22:42 +01:00
11fd00c46e
Fixed #19254 -- Bug in SESSION_FILE_PATH handling.
...
Thanks simonb for the report.
Refs #18194 .
2012-11-06 10:19:14 +01:00
78f66691ee
Fixed #8627 -- Prevented textareas to swallow first newline content
...
Browsers consider the first newline in textareas as some display
artifact, not real content. Hence they are not sending it back to
the server. If we want to keep initial newlines, we have to add one
when we render the textarea.
Thanks bastih for the report and initial patch.
2012-11-05 20:27:06 +01:00
39ec43b478
Removed unnecessary import after b98083ce3d
2012-11-05 09:32:08 +01:00
6bd61194d4
Fixed py3 compatibility for 5a00a57aa5
2012-11-04 23:38:41 -08:00
4d766b3c9a
Merge pull request #495 from aisipos/ticket_18949
...
Fixed #18949 -- Improve performance of model_to_dict with many-to-many
2012-11-04 15:57:45 -08:00
e44ab5bb4f
Fixed #18949 -- Improve performance of model_to_dict with many-to-many
...
When calling model_to_dict, improve performance of the generated SQL by
using values_list to determine primary keys of many to many objects. Add
a specific test for this function, test_model_to_dict_many_to_many
Thanks to brian for the original report and suggested fix.
2012-11-04 15:52:05 -08:00
5a00a57aa5
Fixed #19240 -- include pagination error details in ListView 404
...
Thanks to seawolf for the patch
2012-11-04 15:52:00 -08:00
8d3f932f18
Merge pull request #494 from mrj0/model_split
...
model_split: Fixed #19236 - fixed error for abstract models with a split method
2012-11-04 14:20:26 -08:00
088f68252d
use six.string_types for python3
2012-11-04 14:16:32 -08:00
b98083ce3d
Remove some bizzare and unnecesary code.
2012-11-04 13:58:40 -08:00
fcd3d4c68f
model_split: Fixed #19236 - fixed error for abstract models with a split method
2012-11-04 13:43:54 -08:00
4285571c5a
Fixed #5805 -- it is now possible to specify multi-column indexes. Thanks to jgelens for the original patch.
2012-11-04 10:16:06 -08:00
fc10418fba
Fixed #18963 -- Used a subclass-friendly pattern
...
for Python 2 object model compatibility methods.
2012-11-03 22:07:35 +01:00
973f539ab8
Fixed #15152 -- Avoided crash of CommonMiddleware on broken querystring
2012-11-03 21:28:33 +01:00
90e530978d
Fixed #18210 -- Escaped special characters in reverse prefixes.
...
Ensured that special characters passed in to reverse via the
prefix argument are properly escaped so that calls to
django.utils.regex_helpers.normalize and/or string formatting
operations don't result in exceptions.
Thanks to toofishes for the error report.
2012-11-03 13:06:57 -07:00
3e98d98b69
Prevented host resolution when running dev server
...
Refs #19075 , #2494 .
Thanks Karen Tracey for spotting the issue.
2012-11-03 20:12:24 +01:00
095eca8dd8
Fixed #19101 -- Decoding of non-ASCII POST data on Python 3.
...
Thanks Claude Paroz.
2012-11-03 13:03:15 +01:00
ac2052ebc8
Fixed #17549 -- Added a clickable link for URLFields in admin change list.
2012-11-03 11:57:33 +01:00
965cc0b1ff
Deprecated depth kwarg on select_related.
...
This is the start of a deprecation path for the depth kwarg on
select_related. Removing this will allow us to update select_related so
it chains properly and have an API similar to prefetch_related.
Thanks to Marc Tamlyn for spearheading and initial patch.
refs #16855
2012-11-02 22:03:33 -07:00
92fc263a28
Fixed a regression in gis introduced by Query.select_fields removal
2012-11-02 14:57:19 +02:00
af7ea808d8
Added WizardView.file_storage exception message and docs
...
Thanks Danilo Bargen for the patch.
2012-11-01 16:14:51 -04:00
d9213d09db
Fixed #16678 -- Wrote tests for contrib.redirects app
...
Thanks Julien Phalip for the report.
2012-11-01 19:47:41 +01:00
ba81164fb7
Add `form` to formwizard context (includes tests)
2012-10-31 09:58:28 -04:00
7f75460fd6
Fixed #19070 -- urlize filter no longer raises exceptions on 2.7
...
Thanks to claudep for the patch.
2012-10-31 10:58:14 +00:00
146ed13a11
Fixed #17083 -- Allowed sessions to use non-default cache.
2012-10-31 09:46:16 +01:00
68847135bc
Removed dupe_avoidance from sql/query and sql/compiler.py
...
The dupe avoidance logic was removed as it doesn't seem to do anything,
it is complicated, and it has nearly zero documentation.
The removal of dupe_avoidance allowed for refactoring of both the
implementation and signature of Query.join(). This refactoring cascades
again to some other parts. The most significant of them is the changes
in qs.combine(), and compiler.select_related_descent().
2012-10-31 08:19:44 +02:00
2f035a9723
Fixed #19174 -- Fixed capitalization errors in LANG_INFO
...
Thanks waldeinburg for the report.
2012-10-30 23:05:47 +01:00
9a02851340
Fixed #17744 -- Reset default file storage with setting_changed signal
2012-10-30 22:23:28 +01:00
5dc4437dfa
Fixed #15714 -- Added note about capitalization of LANG_INFO name_local
2012-10-30 09:28:19 +01:00
6de6988f99
Fixed #5076 -- Properly decode POSTs with non-utf-8 payload encoding
...
Thanks daniel at blogg.se for the report and Aymeric Augustin for
his assistance on the patch.
2012-10-30 09:00:32 +01:00
9741912a9a
Fixed #17869 - force logout when REMOTE_USER header disappears
...
If the current sessions user was logged in via a remote user backend log out
the user if REMOTE_USER header not available - otherwise leave it to other auth
middleware to install the AnonymousUser.
Thanks to Sylvain Bouchard for the initial patch and ticket maintenance.
2012-10-29 22:58:14 -07:00
2b5f848207
Fixed #19057 (again) -- added additional tests
2012-10-29 22:24:42 -07:00
81f5d4a1a7
Added some test guards for some recently added auth tests.
...
Refs #19061 , #19057 .
2012-10-30 10:28:35 +08:00
b774c5993c
Fixed #19172 -- Isolated poisoned_http_host tests from 500 handlers
...
Thanks bernardofontes for the report.
2012-10-29 17:28:04 +01:00
4c4d08502c
Fixed #17991 - prefetch_related fails with GenericRelation and varchar ID field
...
Thanks to okke@formsma.nl for the report, and carmandrew@gmail.com for the tests.
2012-10-29 14:31:54 +00:00
4ea8105120
Fixed #19061 -- added is_active attribute to AbstractBaseUser
2012-10-28 23:04:03 -07:00
f1cc2be0c5
Fixed #18575 -- Empty DATABASES should default to dummy backend
...
Thanks delormemarco@gmail.com for the report.
2012-10-28 23:44:03 +01:00
ee96f83ab0
Consistently indent comments in project template
...
Makes this file slightly more pep8 compliant.
2012-10-28 14:46:09 -07:00
effe96b303
Fixed a typo in aff9b2f.
...
Thanks void.
2012-10-28 22:35:25 +01:00
58337b3223
Marked cookies-based session expiry test as an expected failure.
...
Refs #19201 .
2012-10-28 18:03:23 +01:00
58a086acfb
Required serializer to use bytes in loads/dumps
...
loads has no way to tell if it should provide text or bytes to the
serializer; bytes are more reasonnable for a serialized representation,
and are the only option for pickled data.
dumps can perform conversions on the value it receives from the
serializer; but for consistency it seems better to require bytes too.
The current code would cause an exception when loading pickled session
data. See next commit.
Also fixed a bug when checking for compressed data.
2012-10-28 16:57:15 +01:00
611c4d6f1c
Fixed #18823 -- Ensured m2m.clear() works when using through+to_field
...
There was a potential data-loss issue involved -- when clearing
instance's m2m assignments it was possible some other instance's
m2m data was deleted instead.
This commit also improved None handling for to_field cases.
2012-10-28 17:31:35 +02:00
98032f67c7
Fixed #14093 -- Improved error message in the cache session backend.
...
Thanks stumbles for the patch.
2012-10-28 12:40:10 +01:00
785bf0d5a0
Reverted unintentional change in aff9b2f.
2012-10-28 12:33:38 +01:00
aff9b2f566
Fixed #19203 -- Added isolation to a humanize test
...
Thanks lrekucki for the report.
2012-10-28 09:34:05 +01:00
5fec97b9df
Fixed #18194 -- Expiration of file-based sessions
...
* Prevented stale session files from being loaded
* Added removal of stale session files in django-admin.py clearsessions
Thanks ej for the report, crodjer and Elvard for their inputs.
2012-10-28 09:19:38 +01:00
882c47cd40
Improved tests introduced in 04b00b6.
...
These tests are expected to fail for the file session backend because it
doesn't handle expiry properly. They didn't because of an error in the
test setup sequence.
Refs #19200 , #18194 .
2012-10-27 23:15:45 +02:00
cd17a24083
Added optional kwargs to get_expiry_age/date.
...
This change allows for cleaner tests: we can test the exact output.
Refs #18194 : this change makes it possible to compute session expiry
dates at times other than when the session is saved.
Fixed #18458 : the existence of the `modification` kwarg implies that you
must pass it to get_expiry_age/date if you call these functions outside
of a short request - response cycle (the intended use case).
2012-10-27 23:15:45 +02:00
04b00b668d
Fixed #19200 -- Session expiry with cached_db
...
Also did a little bit of cleanup.
2012-10-27 19:40:39 +02:00
83ba0a9d4b
Fixed #18978 -- Moved cleanup command to sessions.
...
This removes a dependency of 'core' on 'contrib'.
2012-10-27 18:31:00 +02:00
908efca817
Fixed #19198 -- merged 4 different Oracle fixes
2012-10-27 19:05:46 +03:00
b55de81b9e
Ensured gis tests aren't run on non-gis Oracle
2012-10-27 18:34:47 +03:00
c159d9cec0
Fixed Oracle failure caused by None converted to '' in select_related case
2012-10-27 05:26:53 +03:00
2249bd275c
Fixed Oracle failure for "%" in table name
2012-10-27 05:26:42 +03:00
373df56d36
Advanced version identifiers for 1.6 cycle.
2012-10-26 22:01:34 -03:00
11699ac4b5
Fixed #19190 -- Refactored Query select clause attributes
...
The Query.select and Query.select_fields were collapsed into one list
because the attributes had to be always in sync. Now that they are in
one attribute it is impossible to edit them out of sync.
Similar collapse was done for Query.related_select_cols and
Query.related_select_fields.
2012-10-27 02:13:02 +03:00
be29329ccd
Fixed #16820 -- Treated '0' value as True for checkbox inputs
...
Thanks Dan Fairs for the report and the initial patch.
2012-10-26 20:44:00 +02:00
3266c26eb2
Properly support pickling of LazyObjects in Python 3.3
2012-10-26 01:40:33 +01:00
3629a159f9
PEP 302 source loaders already decode appropriately
2012-10-26 01:40:32 +01:00
f3a2bcdee9
Fixed #15040 - Boolean fields return 0 and 1 when loaded through select_related
...
Thanks to homm for the report and ramiro for the patch.
2012-10-26 00:25:59 +01:00
45c8818503
Ensured get_version returns a native string.
...
Returning unicode triggers a bug in Python 2.7:
http://bugs.python.org/issue11638
This problem was introduced in 4a103086
2012-10-25 21:49:18 +02:00
bd6d9ea87c
Fixed regression caused by #19102
2012-10-25 19:13:10 +03:00
7de439f32d
Fixed #19187 -- Raise consistent error from qs.values().delete()
2012-10-25 17:16:56 +03:00
11b8712cc7
Added docstring to DeleteQuery.delete_qs()
2012-10-25 17:16:56 +03:00
f64a5ef404
Fixed #19102 -- Fixed fast-path delete for modified SELECT clause cases
...
There was a bug introduced in #18676 which caused fast-path deletes
implemented as "DELETE WHERE pk IN <subquery>" to fail if the SELECT
clause contained additional stuff (for example extra() and annotate()).
Thanks to Trac alias pressureman for spotting this regression.
2012-10-25 17:16:44 +03:00
502be865c6
Add 'page_kwarg' attribute to `MultipleObjectMixin`, removing hardcoded 'page'.
2012-10-25 10:31:14 +01:00
da56e1bac6
Fixed #18796 -- Refactored conversion to bytes in HttpResponse
...
Thanks mrmachine for the review.
2012-10-25 08:49:51 +02:00
ce1eb320e5
Remove a case that is no longer reachable in encodings.py.
...
This case was originally designed to handle Exception's which didn't gracefully support coercing themselves to unicode. However, because it lives in the `else` case of `if hasattr(s, '__unicode__'):` we can be sure it's no longer reachable in djanog anymore, because since Python 2.5 exception has subclassed object, which means Exception objects always have an __unicode__ method.
2012-10-24 15:53:00 -07:00
1b096ad773
Removed a function that is already fully implemented by a base class.
2012-10-24 12:49:57 -07:00
82b3e6ffcb
Fixed #13222 -- Made HttpResponse iterable once
...
response.content can be accessed many times as desired, and always
returns the same result.
iter(response) works only once and consumes the iterator.
2012-10-24 17:19:56 +02:00
495a8b8107
Fixed #6527 -- Provided repeatable content access
...
in HttpResponses instantiated with iterators.
2012-10-24 17:08:37 +02:00
c736a1a9f8
Fixed #19176 -- Typo in copy-pasted error message.
...
Thanks maxirobaina for the report.
2012-10-24 16:21:30 +02:00
9fd2f9c5f3
Fixed #19088 -- Always escape % inside blocktrans tag
...
Thanks vlinhart for the report and Łukasz Rekucki for the patch.
2012-10-23 18:49:22 +02:00
3541a10d49
Fixed #19164 -- Fixed diffsettings command broken in fix for #18545 .
...
Thanks Mario César for the report and draft patch.
2012-10-22 18:49:08 -06:00
ea57112d53
Reverted 6a64822bf4.
...
This commit caused every test that does two or more assertContains to
fail, because of #6527 . It also made HttpResponse non-pickleable.
Refs #13222 .
2012-10-23 00:11:17 +02:00
11a4b6d923
Merge pull request #460 from JanBednarik/ticket_19162
...
Fixed #19162 -- Wrong indentation.
2012-10-22 14:43:28 -07:00
6a64822bf4
Fixed #13222 -- Repeated iteration of HttpResponse
...
Thanks teepark for the report and grahamd for his insights.
2012-10-22 22:52:36 +02:00
4cceb5cb31
Fixed #19162 -- Wrong indentation.
2012-10-22 19:23:19 +02:00
58cc3e8484
Fixed #19157 -- Removed test-only string from translatable strings
...
Thanks Alexey Boriskin for the report. Refs #18240 .
2012-10-22 09:31:28 +02:00
b4066d7d21
Cleaned up the the http module. Moved all of the code from __init__.py to request.py, response.py and utils.py
2012-10-21 11:12:59 -07:00
22471a41ba
Merge pull request #457 from JanBednarik/ticket_19142
...
Fixed #19142 -- Language codes can include numbers (RFC 3066)
2012-10-21 10:35:01 -07:00
1a3ff63199
Updated error message for bad database engine
...
removing typo in the process. Thanks to Carlos Palol for the catch.
Closes pull 450
2012-10-21 07:41:59 -07:00
6b3d2bc981
Merge pull request #444 from mitar/patch-2
...
Allow reversed iteration over SortedDict.
2012-10-20 20:39:49 -07:00
e6b34193c5
Fixed #19142 -- Language codes can include numbers (RFC 3066).
2012-10-21 01:25:35 +02:00
b87e2f46c8
Fixed #19151 -- Added missing methods to EmptyQuerySet.
...
Added values() and values_list() methods to EmptyQuerySet.
2012-10-21 00:19:38 +02:00
4b27813198
Fixed #7581 -- Added streaming responses.
...
Thanks mrmachine and everyone else involved on this long-standing ticket.
2012-10-20 20:05:11 +02:00
c2e19e26bc
Fixed #17856 -- Passed obj to get_inline_instances
...
Thanks ybon, quinode and sjaensch for the patch, and Tim Graham
for the review.
2012-10-20 15:49:52 +02:00
dcbf08cce5
Fixed #19094 -- Improved FakePayload to support write, len and string input
...
Thanks Ondrej Slinták for the suggestion.
2012-10-20 15:36:24 +02:00
dfd4a71751
Fixed #5611 -- Restricted accepted content types in parsing POST data
...
Thanks paulegan for the report and Preston Holmes for the review.
2012-10-20 14:56:16 +02:00
681550ca6d
Removed custom WSGIRequestHandler.get_environ
...
We probably historically customized it for good reasons, but
currently, the differences with upstream Python are not
significant any longer.
Also fixes #19075 for which a test has been added.
2012-10-20 13:55:13 +02:00
7a908747a5
Fixed #19150 -- Added validation for USERNAME_FIELD being included in REQUIRED_FIELDS.
...
Thanks to Chris Pagnutti for the suggestion.
2012-10-20 11:51:15 +08:00
04b53ebfb7
Fixed #19133 -- Corrected regression in form handling for user passwords.
...
Thanks to pressureman for the report, and to Preston Holmes for the draft patch.
2012-10-20 11:41:54 +08:00
Claude Paroz
Andreas Hug
Marc Aymerich
Ramiro Morales
Andrew Godwin
Sebastián Magrí
Preston Holmes
Tom Insam
Aymeric Augustin
Julien Phalip
orblivion
Tai Lee
Danilo Bargen
Anssi Kääriäinen
Edward Tjörnhammar
Vladimír Macek
Jonatan Heyman
Chris Khoo
Russell Keith-Magee
Rigel Di Scala
Flavio Curella
George Hickman
Tim Graham
Jannis Leidel
Chris Beaven
Hannes Struss
Riley Strong
Brandon Adams
vanschelven
Adrian Holovaty
Ryan Kaskel
Sean Breant
Florian Apolloner
Alex Gaynor
Anton I. Sipos
Mike Johnson
Alex Gaynor
Gabriel Hurley
Ulrich Petri
Kent Hauser
Luke Plant
Chris McDonald
Ian Clelland
Tom Christie
Carl Meyer
Jan Bednařík