c555741aa7
Fixed #18530 -- Fixed a small regression in the admin filters where wrongly formatted dates passed as url parameters caused an unhandled ValidationError. Thanks to david for the report.
2012-09-15 16:20:56 -07:00
c4aa26a983
Internal refactoring; moving LOOKUP_SEP up one level.
...
In an ideal world, nothing except django.db.models.query should have to
import stuff from django.models.sql.*. A few things were needing to get
hold of sql.constants.LOOKUP_SEP, so this commit moves it up to
django.db.models.constants.LOOKUP_SEP.
There are still a couple of places (admin) poking into sql.* to get
QUERY_TERMS, which is unfortunate, but a slightly different issue and
harder to adjust.
2012-09-08 19:51:36 -04:00
4754f122dd
Moved the admin inline JS to new JS files for cleanliness.
2012-09-08 15:09:37 -04:00
ccd1bb0d81
Remove Admin's swallowing of AttributeError ( #16655 , #18593 , #18747 )
...
During the new-admin changes, catching of AttributeError was added to
the admin. This patch removes that as it's no longer possible to add a
value to a ModelAdmin that is not available. Adding an attribute that
can not be called causes an ImproperlyConfigured exception to be raised.
2012-09-08 11:20:05 -04:00
ebc773ada3
Replaced many smart_bytes by force_bytes
...
In all those occurrences, we didn't care about preserving the
lazy status of the strings, but we really wanted to obtain a
real bytestring.
2012-08-29 11:20:32 +02:00
5a9e127efc
Made model instance history admin view link not hard-coded. Refs #15294 .
2012-08-26 17:54:49 -03:00
a351e383b6
There's no need to do `list(dict.keys())` list(dict)` is enough.
2012-08-14 06:57:16 -07:00
c2d59e5564
[py3] Fixed admin_views tests
...
Also changed several occurrences of 'request' to 'response'.
2012-08-14 14:45:28 +02:00
d4a0b27838
[py3] Refactored __unicode__ to __str__.
...
* Renamed the __unicode__ methods
* Applied the python_2_unicode_compatible decorator
* Removed the StrAndUnicode mix-in that is superseded by
python_2_unicode_compatible
* Kept the __unicode__ methods in classes that specifically
test it under Python 2
2012-08-12 14:44:40 +02:00
db729266d6
[py3] Fixed 'iterable but non string' detection
...
In Python 3, the str type has an __iter__ attribute. Therefore, the
presence of an __iter__ attribute is not sufficient to distinguish
'standard' iterables (list, tuple) from strings.
2012-08-08 18:02:25 +02:00
4c97101b1f
remove a bunch of unnescesarry iterkeys() calls
2012-08-08 07:33:15 -07:00
c5ef65bcf3
[py3] Ported django.utils.encoding.
...
* Renamed smart_unicode to smart_text (but kept the old name under
Python 2 for backwards compatibility).
* Renamed smart_str to smart_bytes.
* Re-introduced smart_str as an alias for smart_text under Python 3
and smart_bytes under Python 2 (which is backwards compatible).
Thus smart_str always returns a str objects.
* Used the new smart_str in a few places where both Python 2 and 3
want a str.
2012-08-07 12:00:22 +02:00
ee191715ea
[py3] Fixed access to dict keys/values/items.
2012-08-07 12:00:22 +02:00
bdca5ea345
[py3] Replaced unicode/str by six.text_type/bytes.
2012-07-22 09:29:54 +02:00
3cb2457f46
[py3] Replaced basestring by six.string_types.
2012-07-22 09:29:54 +02:00
56dbe924a6
[py3] Removed longs.
2012-07-22 09:29:53 +02:00
d11d45aad9
[py3] Used six.with_metaclass wherever necessary.
2012-07-22 09:29:52 +02:00
01c392623d
Fixed #10057 -- Ensured that the 'show_delete' context variable in the admin's change view actually controls the display of the delete button. Thanks to rajeesh for the report, to patcoll for the patch, and to David Gouldin for the test.
2012-07-21 18:10:24 -07:00
8015593bc1
Fixed #17978 -- Fixed a minor layout issue when an inline contains a filter horizontal widget. Thanks to Aymeric Augustin for the report.
2012-07-07 15:41:04 -07:00
8fdc56d2a6
Fixed #18572 - Python26 string format incompatibility
...
Thanks to anonymous/AeroNotix for the report
2012-07-06 00:23:02 +01:00
a222d6e800
Fixed incorrect URL to object on delete confirmation and history page
2012-07-03 22:20:12 +01:00
b0eee0ba4b
Removed various unnecessary instances of mark_safe applied to URLs
...
Also fixed some test breakages introduced in last commit
2012-07-03 22:20:12 +01:00
a92e7f37c4
Changed a lot of internal code to use 'format_html' where appropriate/possible
2012-07-03 22:20:12 +01:00
2cd4cf58d3
Fixed #18550 -- Ensured that the admin history view works with escaped primary keys.
...
Thanks to josh.oosterman for the report and patch.
2012-07-01 18:40:50 -07:00
aee9eecb92
Fixed #18444 -- Replace hard coded "View on Site" URLs
2012-06-18 18:12:29 +02:00
108f8dddea
Fixed #18450 -- Removed default values for i18n JavaScript URLs in Admin templates
2012-06-18 18:09:05 +02:00
d708298184
Fixed #18420 -- Prevented the admin JS from crashing when the main form contains no field. Thanks to maciej.maciaszek for the report and patch.
2012-06-16 17:18:23 -07:00
fadcc6ddb7
Updated the admin's minified JS files.
2012-06-16 16:23:39 -07:00
1ace912f7e
Fixed #18477 -- Fixed colspan value when a TabularInline form contains validation errors. Thanks to yedpodtrzitko for the report and patch.
2012-06-16 14:29:41 -07:00
e9497a3803
Corrected way to get URL of object in admin history template
2012-06-10 06:18:16 +01:00
23d230f058
Merge pull request #123 from apollo13/ticket18381
...
Fixed #18381 -- Stopped escaping object ids
when passing them to the contenttypes.shortcut view.
Thanks apollo13 for the patch and dhepper for the review.
2012-06-08 01:48:41 -07:00
0ae727beda
Fixed #18433 -- Fixed "View on Site" link in inline admin for models with custom PK
2012-06-07 21:08:36 +02:00
4a103086d5
Fixed #18269 -- Applied unicode_literals for Python 3 compatibility.
...
Thanks Vinay Sajip for the support of his django3 branch and
Jannis Leidel for the review.
2012-06-07 18:08:47 +02:00
e1643e3535
Don't escape object ids when passing to the contenttypes.shortcut view.
...
This commit also changes the string pk to string_pk instead of id, to test
if the admin uses .pk throughout the codebase.
2012-06-07 17:52:12 +02:00
eee791e9b2
Merge branch 'master' of https://github.com/django/django
2012-06-05 13:29:33 +02:00
fbb7389439
Ticket #17804 fix.
2012-06-05 13:28:32 +02:00
43a46e9004
Remove the summary attribute of the table
...
In the discussion here: https://code.djangoproject.com/ticket/17138
it was decided that using the caption for this previously
non-visible part of the table element was not semantic, so in this
patch is moves that summary to the `title` attribute of the `a`
tag which when overed over, on most browsers, will show the text.
2012-06-03 12:44:37 -07:00
23b9418458
Regenerated the minified versions of the admin actions and admin inlines JavaScript files forgotten in 04785d2 and f92c7c5 (and previous).
2012-05-20 18:23:14 +02:00
35e6585568
Imported reduce from functools for forward compatibility.
...
In Python 3, reduce has to be imported from functools.
2012-05-20 00:25:46 +02:00
04785d2697
Merge pull request #24 from marcneuwirth/master
...
Removed 'return false' in favor of preventDefault in admin JS.
2012-05-18 13:41:53 -07:00
f92c7c5df2
Swap out to === for the true comparison to avoid possible coercion issues
2012-05-16 13:40:24 -05:00
6e3b9962cc
Add missing semi-colons
2012-05-16 13:38:23 -05:00
67fd30e9ab
Remove `var` declaration---this variable is already delcared as an argument
2012-05-16 13:38:02 -05:00
c647065b49
Make sure these functions don't bleed into the global scope
...
This makes sure that all of these functions are assigned to variables
assigned to the current scope, rather than the global scope. It also
adds a trailing semi-colon to make sure various linters are happy.
2012-05-16 13:33:48 -05:00
b719cbb901
Removed 'return false' in favor of preventDefault.
...
Moved preventDefault to the top
2012-05-12 00:39:31 -04:00
3dde02640c
Fixed #17518 -- CSS glitch in StackedInline.
...
Thanks sebastian for the report and patch.
2012-05-10 22:44:40 +02:00
169b1a404c
Replaced foo.next() by next(foo).
...
This new syntax for next() has been introduced in Python 2.6 and is
compatible with Python 3.
2012-05-10 20:15:49 +02:00
e84f79f051
Fixed #18042 -- Advanced deprecation warnings.
...
Thanks Ramiro for the patch.
2012-05-03 15:27:01 +02:00
3904b74a3f
Fixed #18013 -- Use the new 'as' syntax for exceptions.
...
Thanks Clueless for the initial patch.
Note that unittest has been purposely left out (external package only used by Python 2.6).
2012-04-29 20:57:15 +02:00
3e8b40f479
Fixed #17992 -- Added a public API for localtime.
...
Thanks Bradley Ayers for the report.
2012-04-29 15:37:23 +02:00
Julien Phalip
Malcolm Tredinnick
Travis Swicegood
Travis Swicegood
Claude Paroz
Ramiro Morales
Alex Gaynor
Aymeric Augustin
Luke Plant
Daniel Hepper
Florian Apolloner
martin.bohacek
Samuel Sutch
Jannis Leidel
Adrian Holovaty
Marc Neuwirth
Aymeric Augustin