0bea6c8749
Factored create_fk_sql, create_unique_sql, and delete_constraint_sql.
2014-09-23 09:24:32 -04:00
0eb5cde9da
Fixed #21775 -- Allowed customization of datafile for Oracle tablespace
2014-09-17 09:55:33 -04:00
ed7821231b
Fixed #19463 -- Added UUIDField
...
Uses native support in postgres, and char(32) on other backends.
2014-09-16 10:08:09 +01:00
6072f17d09
Factorized create_index_sql expression
2014-09-13 21:34:37 +02:00
638d1393ee
Fixed #23434 -- Coerce Oracle bool params to int
2014-09-08 10:11:20 -04:00
14c8456ffe
Fixed #23416 -- Make sure DatabaseCreation respects checks.
...
Migrations respected Field.db_parameters()['check'], but
DatabaseCreation was still using just Field.db_type().
2014-09-06 19:01:06 +01:00
1101467ce0
Limited lines to 119 characters in django/
...
refs #23395 .
2014-09-05 09:22:16 -04:00
e9103402c0
Fixed #18757 , #14462 , #21565 -- Reworked database-python type conversions
...
Complete rework of translating data values from database
Deprecation of SubfieldBase, removal of resolve_columns and
convert_values in favour of a more general converter based approach and
public API Field.from_db_value(). Now works seamlessly with aggregation,
.values() and raw queries.
Thanks to akaariai in particular for extensive advice and inspiration,
also to shaib, manfre and timograham for their reviews.
2014-09-03 20:36:03 +01:00
f0d3dd4f04
Fixed #23357 -- Added small int introspection support to MySQL backend.
...
In the MySQL backend, updated the can_introspect_small_integer feature
flag to True. In data_types_reverse, map FIELD_TYPE.SHORT to a
SmallIntegerField. Added test to verify introspecting SmallIntegerFields
and fixed existing tests influenced by this change.
2014-08-27 10:58:44 -04:00
4c85a0d95f
Made main user disconnect after creating test user/tablespaces on Oracle
2014-08-25 20:20:10 +03:00
a6222af0ed
Added docstring forgotten in 56252e7.
2014-08-22 05:37:36 +03:00
56252e7f46
Fixed schema test for Oracle 11.2.0.1 which is used in Django Project's CI.
...
Refs #23073 Workaround.
Refs #22738 Repeats the mysql "offense". When the issue is solved, the
Oracle special case should be made to play with the solution (that is,
Oracle should be fixed the same way that mysql and the 3rd-party backneds
are).
2014-08-22 05:08:53 +03:00
6295ea0027
Replaced HAS_SPATIAL_DB by testing database feature
...
Refs #22632 . This should be the base for using more database
features to exclude specific backends in GIS tests.
Thanks Tim Graham for the review.
2014-08-19 17:57:01 +02:00
01801edd37
Fixed #22646 : Added support for the MySQL ssl-ca option to dbshell.
2014-08-13 18:29:42 -04:00
61d783f3d7
Made sqlite's remove_field behave like the base backend.
2014-08-10 13:31:06 +02:00
dc462a8ed5
Removed unused migrate option
2014-08-09 17:13:00 +02:00
27b6f28435
Fixed #23264 : Schema backends honour db_constraint
2014-08-09 17:50:00 +10:00
8d93b21ec9
Moved index dropping after FK dropping to please MySQL and fix test
2014-08-07 11:59:11 +10:00
938da36cb1
Fixed #21603 -- Fixed complex RawQuerySets queries on some versions of SQLite.
2014-08-06 08:41:34 -04:00
746f2a4bed
Fixed #23061 : Avoided setting a limit on a query for get with select_for_update on Oracle
...
Thanks Michael Miller for reporting the issue.
2014-08-05 03:12:08 +03:00
bf5382c6e5
Fixed #22234 -- Replaced OS-specific code with subprocess.call() in dbshell.
...
This fixes escaping of special characters on Windows.
2014-08-04 09:21:03 -04:00
c06e124b5e
Fixed #23091 : CreateModel and AddField were clashing with deferred SQL
2014-08-04 11:59:29 +10:00
d28396f526
Fixed #23144 -- Dropped support for MySQL 5.0, 5.1.
2014-08-02 10:28:40 -04:00
8f9d6e83a0
Fixed #23145 -- Dropped support for Oracle < 11.1
2014-08-01 19:32:00 -04:00
a9bdce7e55
Fixed #23108 -- Dropped support for PostgreSQL 8.4 & PostGIS 1.3, 1.4.
...
Thanks Claude Paroz for the review.
2014-08-01 10:26:00 -04:00
729e4ae4f0
Fixed #23074 -- Avoided leaking savepoints in atomic.
...
Thanks Chow Loong Jin for the report and the initial patch.
2014-07-28 14:30:41 +02:00
90faa196f6
Fixed #22873 -- Renamed use_debug_cursor to force_debug_cursor to clarify the behavior.
2014-07-26 10:38:46 -04:00
08681d7757
Fixed #23085 : Better error message for PostGIS 1.5/bad custom fields
2014-07-25 09:49:51 -07:00
8c30df15f1
Fixed #23030 -- Properly handled geometry columns metadata during migrations
...
Thanks kunitoki for the report and initial patches.
2014-07-23 12:10:23 +02:00
e24e9e0438
Fixed #23014 : Renaming not atomic with unique together
2014-07-21 11:36:34 +01:00
7dacc6ae46
Fixed #23009 : Shorten FK identifiers in add_field and make consistent
2014-07-21 10:50:21 +01:00
dcb4ed5170
Fixed #22975 : Don't call rename SQL if not needed
2014-07-21 10:14:00 +01:00
2984b30ce8
Fixed #23039 : Don't try to serialize unmanaged models in tests
2014-07-21 10:09:31 +01:00
5875b8d133
Fixed #23043 : alter_field drops defaults too
2014-07-21 10:04:36 +01:00
dd9b3312d0
Fixed name of database connection feature
2014-07-14 19:23:57 +03:00
0fba4c0ed7
Fixed #22487 : Don't flush out data from before normal TestCases
2014-06-23 20:25:09 -07:00
1c50d6ae2b
Fixed problem introduced with #refs 13711.
2014-06-23 19:36:40 +03:00
78c32f1caa
Fixed #22514 -- Prevented indexes on virtual fields [postgres].
2014-06-20 11:59:02 -04:00
91f1b6dcdc
Fixed #13711 -- Model check added to ensure that auto-generated column name is within limits of the database.
...
Thanks russellm for report and Tim Graham for review.
2014-06-17 16:16:02 -04:00
b22917bd50
Fixed #22851 : BinaryView wasn't getting a binary default
2014-06-16 18:44:08 -07:00
82c935d44c
Renamed DatabaseFeature.supports_check_constraints to supports_column_check_constraints.
...
Thanks maxi for the suggestion.
2014-06-16 19:25:13 -04:00
c8c79367a2
Fixed #22844 : Duplicate SQL for SQLite FKs
2014-06-16 00:27:32 -07:00
612290400f
Fixed #22816 -- Corrected Oracle feature flag and fixed introspection test
2014-06-14 00:43:49 +03:00
06c0e740a4
Added django.utils.six.buffer_types
...
and used it in the Oracle SchemaEditor. Refs #22715 .
2014-06-13 13:09:51 -04:00
bc0aba7786
Dropped support for SpatiaLite < 2.4.
2014-06-09 17:53:25 -04:00
40bfd8561d
Fixed #20420 -- Normalized query counts on Oracle.
...
This is achieved by inserting a fake entry in connection.queries when
not releasing a savepoint (since Oracle doesn't support that operation.)
Also removed the can_release_savepoints feature that was recently added,
but is superseded by this solution.
2014-06-09 21:38:10 +02:00
127218b92b
Simplified handling of use_debug_cursor.
...
Turned it from a tri-valued boolean into a regular boolean.
2014-06-09 21:35:17 +02:00
3a926c0778
Tweaked order of create_test_db arguments for backwards compatibility.
...
Since `serialize` was backported to 1.7, it should appear before `keepdb`.
2014-06-09 11:12:28 -04:00
8c12d51ea2
Fixed #22487 : Optional rollback emulation for migrated apps
2014-06-08 19:30:15 -07:00
58de495c54
Fixed #17427 -- Removed dubious definition of connections equality.
2014-06-07 17:04:10 +02:00
cfcca7ccce
Fixed #3711 , #6734 , #12581 -- Bounded connection.queries.
...
Prevented unlimited memory consumption when running background tasks
with DEBUG=True.
Thanks Rob, Alex, Baptiste, and others.
2014-06-07 14:37:43 +02:00
1181b8a4a9
Merge pull request #2764 from gchp/ticket-20550
...
Fixed #20550 -- Added keepdb argument to destroy_test_db
2014-06-06 14:05:41 +02:00
e071f67b7f
Replaced an explicit vendor check by a feature flag.
...
Forward-port of c9aedce0
2014-06-06 00:32:13 +02:00
72f055e535
Fixed #20550 -- Added keepdb argument to destroy_test_db
2014-06-05 23:17:27 +01:00
a03d38ddd4
Added a flag for the ability to introspect nullable fields.
...
Previously this was conflated with another Oracle-specific behavior.
2014-06-05 17:56:56 +02:00
5a504a5311
Fixed #22744 -- Fixed sqlite3 get_relations introspection with views
...
Thanks Tim Graham for the report and Simon Charette for the review.
2014-06-01 22:03:33 +02:00
2a5c750ad1
Merge pull request #2726 from gchp/ticket-20550
...
Fixed #20550 -- Added ability to preserve test db between runs
2014-06-01 17:26:56 +02:00
e79725cdf9
Simplified, very slightly, some code in the oracle backend
2014-05-28 17:17:58 -07:00
69337d485c
Set straight the sense of 'uppercases_column_names' feature flag
2014-05-28 21:16:24 +03:00
fd427f1fe3
Fixed #22715 : Corrected sql for defaults of BinaryField on Oracle with Python3
...
While at it, fixed a problem in returning empty values
(still with BinaryField/Oracle/Python3).
2014-05-28 18:57:40 +03:00
b7aa7c4ab4
Fixed #20550 -- Added ability to preserve test db between runs
2014-05-28 16:22:46 +01:00
27a3cfcd77
Fixed unused import.
2014-05-21 10:42:07 +07:00
03900a02d5
Fixed #22432 : SQLite M2M repointing now works. Thanks to xelnor.
2014-05-20 16:25:59 +01:00
125b3d4407
Fixed #22649 : Beefed up quote_value
2014-05-20 15:41:01 +01:00
4e32e47348
Merge pull request #2634 from loic/ticket22424
...
Fixed #22424 -- MySQL doesn't accept migrations' one-off default values ...
2014-05-20 14:25:59 +01:00
1b07781292
Add feature for implied null (needed for Firebird backend)
2014-05-20 13:27:07 +01:00
ecbabc216d
Revert "Fixed regression from a2dd618e3b4a7472fab852da450ca5eef92a922f."
...
This reverts commit 5a2556afb9
2014-05-19 14:57:06 +01:00
5a2556afb9
Fixed regression from a2dd618e3b.
2014-05-18 20:35:06 +02:00
1d3d01b4f7
Fixed #22424 -- Fixed handling of default values for TextField/BinaryField on MySQL.
...
Thanks syphar for the review and suggestions.
2014-05-18 11:58:16 +07:00
6aacb4c991
Fixed #22626 -- Allow BinaryField defaults with SQlite.
...
Also fixes a slight issue in sqlite3.schema._remake_table where
default values where quoted with "column name" quoting rules.
Reference for quoting: http://www.sqlite.org/lang_expr.html
Thanks Shai Berger for the review. Refs #22424 .
2014-05-17 22:32:17 +07:00
6bb6df2943
Fix storing of binary fields and unicode textfields for Oracle/Python3
2014-05-16 20:08:52 +03:00
27aa85246a
Fixed #20897 -- Added make_cursor() for consistent cursor creation
...
In django.db.backends.BaseDatabaseWrapper, pulled the creation of
cursors in the non-debug case into a separate method, in order to
make behavior more consistent when overriding the cursor creation
in derived classes.
2014-05-15 07:55:36 -04:00
fb90b7cda2
Adjusted refactoring of vendor checks.
...
Thanks Shai for the thorough review.
2014-05-10 14:40:42 +02:00
99d9fa329a
Added feature flags for introspection capabilities.
2014-05-08 22:11:20 +02:00
cff59bedc2
Split ignores_nulls_in_unique_constraints feature.
...
Oracle and SQL Server don't have exactly the same limitations. It's
worth treating them differently.
2014-05-08 22:11:20 +02:00
c70a61eb49
Replaced vendor checks by three feature flags.
2014-05-08 22:11:15 +02:00
b25aee3b7b
Fixed #22476 : Couldn't alter attributes on M2Ms with through= set
2014-05-08 10:34:24 -07:00
e9a456d11b
Fixed #22581 : Pass default values for schema through get_db_prep_save()
2014-05-07 13:46:23 -07:00
2bcb8bfc8d
Fix many many typos in comments throughout the codebase
2014-04-26 10:18:45 -07:00
8b5b199e20
Fixed #3214 -- Stopped parsing SQL with regex.
...
Avoided introducing a new regex-based SQL splitter in the migrations
framework, before we're bound by backwards compatibility.
Adapted this change to the legacy "initial SQL data" feature, even
though it's already deprecated, in order to facilitate the transition
to migrations.
sqlparse becomes mandatory for RunSQL on some databases (all but
PostgreSQL). There's no API to provide a single statement and tell
Django not to attempt splitting. Since we have a more robust splitting
implementation, that seems like a good tradeoff. It's easier to add a
new keyword argument later if necessary than to remove one.
Many people contributed to both tickets, thank you all, and especially
Claude for the review.
Refs #22401 .
2014-04-26 17:46:23 +02:00
3033a7193a
Fixed #21166 -- Reset errors_occurred flag after commit and rollback.
2014-04-25 22:45:11 +02:00
e368912902
Set some transaction-related feature flags on SQLite.
...
Refs #22496 .
2014-04-25 11:43:20 +02:00
843613add4
Fixed #22498 -- constraint name was not quoted in FK creation SQL
2014-04-25 01:30:43 +03:00
53d97e4fe3
Made sure cursor.close() does not complain if cursor is already closed on Oracle
...
Refs #22483
2014-04-25 00:36:40 +03:00
25209715d4
Prevented a crash in the cursor wrappers on Oracle.
...
Fixed #22483 (again).
Forwardport of 5cd6429620
2014-04-24 09:14:42 -04:00
b0f4eecfa7
Ignored repeated calls to connection.close().
...
Forwardport of 9bbb43dd1a
2014-04-24 09:14:26 -04:00
0aa4c6c391
Used the same instance of atomic for entry and exit.
...
Since all state is maintained on the connection at this time and none in
the atomic, it doesn't matter, but it could introduce some subtle bugs
if the implementation changed in the future.
2014-04-23 21:44:36 +02:00
e74d2183c2
Wrapped migrations in a transaction only on DBs with transactional DDL.
2014-04-23 21:44:36 +02:00
956bd64424
Fixed #22397 -- Issues removing M2M field with explicit through model
...
Changed the migration autodetector to remove models last so that FK
and M2M fields will not be left as dangling references. Added a check
in the migration state renderer to error out in the presence of
dangling references instead of leaving them as strings. Fixed a bug
in the sqlite backend to handle the deletion of M2M fields with
"through" models properly (i.e., do nothing successfully).
Thanks to melinath for report, loic for tests and andrewgodwin and
charettes for assistance with architecture.
2014-04-18 16:44:47 -04:00
0d397e5a5b
Revert "Fixed #22397 -- Issues removing M2M field with explicit through model."
...
This reverts commit 00e3b9a2a9
2014-04-18 01:27:30 -04:00
00e3b9a2a9
Fixed #22397 -- Issues removing M2M field with explicit through model.
...
Changed the migration autodetector to remove models last so that FK
and M2M fields will not be left as dangling references. Added a check
in the migration state renderer to error out in the presence of
dangling references instead of leaving them as strings. Fixed a bug
in the sqlite backend to handle the deletion of M2M fields with
"through" models properly (i.e., do nothing successfully).
Thanks to melinath for report, loic for tests and andrewgodwin and
charettes for assistance with architecture.
2014-04-17 12:54:35 -04:00
79f05616fb
Fixed flake8 warnings introduced in recent commits.
2014-04-16 16:49:37 -04:00
0e45669fa9
Fixed #22460 -- Explicity remove constraints when dropping a related field.
2014-04-16 15:38:31 -04:00
25860096f9
Fixed #21239 -- Maintained atomicity when closing the connection.
...
Refs #15802 -- Reverted #7c657b24 as BaseDatabaseWrapper.close() now
has a proper "finally" clause that may need to preserve self.connection.
2014-04-10 20:57:43 +02:00
3becac8484
Fixed #22321 -- Wrapped exceptions in _set_autocommit.
...
Refs #21202 .
2014-04-10 20:16:12 +02:00
5f2f47fdfc
Fixed #21553 -- Ensured unusable database connections get closed.
2014-04-09 22:41:33 +02:00
a449e7feec
Fixed #22359 -- Changing M2M field to blank=True failed on sqlite.
2014-03-31 06:13:19 -04:00
778ce245dd
Corrected many style guide violations that the newest version of flake8 catches
2014-03-30 12:11:05 -07:00
b077ba7ac1
Add a useful stacklevel to some RemovedInDjango19Warnings
2014-03-27 15:44:52 +13:00
1506c71a95
Fixed #12030 -- Validate integer field range at the model level.
...
Thanks to @timgraham for the review.
2014-03-25 14:31:20 -04:00
Sergey Fedoseev
Josh Smeaton
Marc Tamlyn
Claude Paroz
Tim Graham
Jon Dufresne
Shai Berger
zsoldosp
Florian Apolloner
Andrew Godwin
Alex Hill
Mihail Milushev
Aymeric Augustin
areski
Anubhav Joshi
Vlastimil Zíma
Aymeric Augustin
Greg Chapple
Alex Gaynor
Loic Bistuer
Raphaël Barrois
Tim Martin
Andrew Gorcester
Simon Charette
Motiejus Jakštys
Chris Beaven