9ce36512fa
Removed backwards compatibility shims for "util" modules per deprecation timeline.
...
refs #17627 .
2015-01-17 07:40:12 -05:00
3f9ec12d9c
Fixed #23712 -- Fixed KeyError with BaseForm._html_output()
2015-01-15 20:19:53 -05:00
baf2542c4f
Fixed DoS possibility in ModelMultipleChoiceField.
...
This is a security fix. Disclosure following shortly.
Thanks Keryn Knight for the report and initial patch.
2015-01-13 13:03:06 -05:00
3844ccc958
Fixed #24138 -- Added modelform_factory to __all__.
2015-01-12 17:44:06 -05:00
fb48eb0581
Fixed #12663 -- Formalized the Model._meta API for retrieving fields.
...
Thanks to Russell Keith-Magee for mentoring this Google Summer of
Code 2014 project and everyone else who helped with the patch!
2015-01-06 19:25:12 -05:00
f233bf47dd
Fixed #21414 -- Removed RelatedObject and deprecated Field.related.
2014-12-23 10:54:25 -05:00
57554442fe
Fixed #2443 -- Added DurationField.
...
A field for storing periods of time - modeled in Python by timedelta. It
is stored in the native interval data type on PostgreSQL and as a bigint
of microseconds on other backends.
Also includes significant changes to the internals of time related maths
in expressions, including the removal of DateModifierNode.
Thanks to Tim and Josh in particular for reviews.
2014-12-20 18:28:29 +00:00
895dc880eb
Fixed #23812 -- Changed django.utils.six.moves.xrange imports to range
2014-12-13 12:45:58 -05:00
0dea81cd6d
Fixed #23674 -- Fixed a crash when a MultiValueField has invalid data.
2014-12-12 08:47:21 -05:00
4468c08d70
Fixed #23968 -- Replaced list comprehension with generators and dict comprehension
2014-12-08 07:58:23 -05:00
560b4207b1
Removed redundant numbered parameters from str.format().
...
Since Python 2.7 and 3.1, "{0} {1}" is equivalent to "{} {}".
2014-12-03 14:27:38 -05:00
a7c3d0f288
Fixed typo in forms/models.py comment.
2014-11-21 15:59:09 -05:00
5b17dcd8ef
Fixed #23883 -- Stopped flatatt modifying its argument
2014-11-21 09:45:08 +01:00
bfb11b9562
Fixed #23795 -- Fixed a regression in custom form fields
...
Custom form fields having a `queryset` attribute but no
`limit_choices_to` could no longer be used in ModelForms.
Refs #2445 .
Thanks to artscoop for the report.
2014-11-12 22:38:18 +01:00
74e1980cf9
Fixed #13181 -- Added support for callable choices to forms.ChoiceField
...
Thanks vanschelven and expleo for the initial patch.
2014-11-04 11:23:58 -05:00
984a57a9c9
Removed some commented code in the forms Media class.
2014-10-27 08:21:37 -04:00
fa534b92dd
Fixed #23623 -- Reduced memory consumption when generating ModelChoiceField choices
2014-10-10 09:50:02 -04:00
ec2fd02bb3
Fixed #23594 -- Fixed deepcopy on ErrorList.
...
Thanks Troy Grosfield for the report and Tim Graham for the tests.
2014-10-07 00:09:55 +07:00
ed7821231b
Fixed #19463 -- Added UUIDField
...
Uses native support in postgres, and char(32) on other backends.
2014-09-16 10:08:09 +01:00
f7eee04ebe
Fixed #23451 -- Fixed typo in inlineformset_factory() error message.
2014-09-08 17:22:23 -04:00
1101467ce0
Limited lines to 119 characters in django/
...
refs #23395 .
2014-09-05 09:22:16 -04:00
e622caaa85
Fixed #21201 -- Improved customization of ClearableFileInput.
2014-08-29 09:40:08 -04:00
a6691e5dcf
Fixed #23167 -- Added BaseForm.__repr__()
...
Thanks Keryn Knight for the idea.
2014-08-22 15:55:56 -04:00
deed00c0d8
Fixed #23162 -- Renamed forms.Field._has_changed() to has_changed().
2014-08-15 08:14:45 -04:00
5e06fa1469
Fixed #22745 -- Prevented reevaluation of ModelChoiceField's queryset when accesssing BoundField's attrs.
...
Thanks Christian Schmitt for review.
2014-08-04 07:47:37 -04:00
399cf303cb
Corrected a comment in forms/forms.py; refs #16612 .
2014-08-04 06:57:09 -04:00
0f2ceee025
Fixed #23151 -- Deprecated RegexField.error_message.
...
Thanks Baptiste Mispelon for the suggestion.
2014-08-03 11:21:01 -04:00
de0a22be35
Fixed two typos in docstrings.
2014-08-02 15:14:13 +02:00
8b7347220f
Fixed #23103 -- Annotated ImageField file with image and content_type attributes.
...
Thanks Jeremy Dunck for the suggestion and Nick Sanford for review.
2014-08-01 09:30:58 -04:00
cdc25ac474
Fixed #22808 -- Made ModelMultipleChoiceField validation more robust to invalid data types..
...
Thanks Mattias Lindvall for the report and inital patch.
2014-07-31 15:29:46 -04:00
17e75d03f9
Fixed #23129 -- Added 'true' and 'false' to `NullBooleanField`.
...
JavaScript serializations of forms will sometimes render the boolean
values as the strings 'true' and 'false', in lower case. Rather than
repeat boilerplate in the JavaScript to circumvent this, it seems
reasonable to allow Django to understand the lower-case versions of the
booleans.
2014-07-29 19:55:55 -04:00
80708ac772
Fixed #23113 -- ChoiceInput.render should take specified attrs into account.
...
Thanks to Tim Graham for the review.
2014-07-28 10:01:07 -04:00
5e2c4a4bd1
Fixed #13794 -- Fixed to_field usage in BaseInlineFormSet.
...
Thanks sebastien at clarisys.fr for the report and gautier
for the patch.
2014-07-09 07:59:20 -04:00
67f9f385aa
Fixed various minor doc typos / references.
2014-07-05 20:26:26 -04:00
dd9a23d5cf
Fixed #22950 -- Eased markup customization for choice field rendering
...
Thanks Patrick Robertson for the report.
2014-07-05 13:36:49 +02:00
9209049211
Ensured bound field renders as unicode safe data
...
Refs #22950 .
2014-07-05 11:42:27 +02:00
cecbb71312
Prevented evaluation of a possible lazy message
...
As far as possible, message evaluation should not happen in field
__init__ (often run at import time).
2014-06-21 11:21:35 +02:00
2764146586
Fixed #22838 -- Deprecated ModelChoiceField.cache_choices.
...
Undocumented, untested and probably not even useful feature.
2014-06-20 20:29:46 +01:00
45e049937d
Fixed #13776 -- Fixed ModelForm.is_valid() exception with non-nullable FK and blank=True.
...
Thanks peterbe for the report.
2014-06-04 07:57:19 -04:00
7e2c87809c
Fixed #22684 -- Amended SelectDateWidget.empty_label to accept a tuple of values.
...
Thanks danielsamuels for the report
2014-06-04 07:23:25 -04:00
11f0899bbe
Fixed #11776 -- Added CSS class for non-field/top of form errors.
...
Thanks Daniel Pope for the suggestion.
2014-06-02 15:22:15 -04:00
1dcc603eff
Fixed several typos in Django
2014-05-28 17:39:14 -07:00
32586b0ba4
Fixed #22684 -- Added `empty_label` option on `django.forms.extras.widets.SelectDateWidget`
...
Thanks danielsamuels for the report
2014-05-28 13:23:28 -04:00
9fb0f5dddc
Fixed #22510 -- Harden field removal to only None.
...
Refs #8620 .
If we allow any value to remove form fields then we get name clashes
with method names, media classes etc. There was a backwards
incompatibility introduced meaning ModelForm subclasses with declared
fields called media or clean would lose those fields.
Field removal is now only permitted by using the sentinel value None.
The docs have been slightly reworded to refer to removal of fields
rather than shadowing.
Thanks to gcbirzan for the report and initial patch, and several of the
core team for opinions.
2014-05-24 13:10:50 +01:00
d64f192df1
Fixed #22628 -- Took initial forms into account when combining FormSet.min_num and FormSet.extra.
...
Forwardport of 79f15ab1ef
2014-05-16 06:38:24 -04:00
4ef10f245a
Fixed #17642 -- Added min_num support to modelformsets, inlines, and the admin.
...
Thanks Stephen Burrows for work on the patch as well.
Forwardport of 2914f66983
2014-05-15 07:25:35 -04:00
5eb81ce445
Fixed #22533 -- Added label_suffix parameter to form fields.
...
Fields can now receive the `label_suffix` attribute, which will override
a form's `label_suffix`.
This enhances the possibility to customize form's `label_suffix`, allowing
to use such customizations while using shortcuts such as
`{{ form.as_p }}`.
Note that the field's own customization can be overridden at runtime by
using the `label_prefix` parameter to `BoundField.label_tag()`.
Refs #18134 .
2014-05-13 09:09:33 -04:00
a5de0df58b
Fixed #22502 -- Fixed microseconds/default/form interaction
...
Made explicit lack of microsecond handling by built-in datetime form
fields. Used that explicitness to appropriately nix microsecond
values in bound fields. Thanks Claude Paroz for the review.
2014-05-10 10:56:39 +02:00
df60db0e78
Fixed #22570 -- Made Form.__getitem__ KeyError more descriptive.
2014-05-05 20:01:15 -04:00
2bcb8bfc8d
Fix many many typos in comments throughout the codebase
2014-04-26 10:18:45 -07:00
ea5a984704
Refactored some code in SelectDateWidget.
2014-04-10 13:03:23 -04:00
78623d253b
Removed casting to bool just before negation.
2014-04-07 08:30:05 -04:00
778ce245dd
Corrected many style guide violations that the newest version of flake8 catches
2014-03-30 12:11:05 -07:00
b077ba7ac1
Add a useful stacklevel to some RemovedInDjango19Warnings
2014-03-27 15:44:52 +13:00
d320863878
Fixed #22114 -- Stopped adding trailing slashes in URLField.to_python
...
Thanks coredumperror at gmail.com for the report and Tim Graham
for the review.
2014-03-26 18:10:58 +01:00
416a858023
Fixed #17922 -- Added required_css_class to form label.
...
Thanks hanson2010 for the suggestion.
2014-03-24 08:11:54 -04:00
7ac8380799
Fixed #22318 -- Added Form.has_error() to easily check if a given error has happened.
2014-03-24 07:21:32 -04:00
e61d99d96d
Fixed #20684 -- Added support for HTML5 boolean attributes to form widgets.
2014-03-22 14:28:12 -04:00
ee4edb1eda
Made ModelForms raise ImproperlyConfigured if the list of fields is not specified.
...
Also applies to modelform(set)_factory and generic model views.
refs #19733 .
2014-03-22 07:56:48 -04:00
d74e33eb0e
Removed backwards compatibility code to call field.widget._has_changed()
...
This logic should be moved to field._has_changed() as described
in ebb504db69#16612 .
2014-03-21 19:34:21 -04:00
306283bf35
Removed warning for Widget.is_hidden property.
...
refs #22137 .
2014-03-21 19:25:54 -04:00
e80de93af6
Removed hard-coded help_text for ManyToManyFields that use a SelectMultiple widget
...
Per deprecation timeline; refs #9321 .
2014-03-21 19:10:07 -04:00
797d742662
Removed django.forms.widgets.RadioInput per deprecation timeline.
...
refs #4592 .
2014-03-21 11:18:04 -04:00
4965a77407
Removed PIL compatability layer per deprecation timeline.
...
refs #19934 .
2014-03-21 10:54:53 -04:00
5a976b4bec
Fixed #22245 -- Avoided widget overwrite in forms.IntegerField subclasses
...
Thanks Jeroen Pulles for the report and Simon Charette for the review.
2014-03-13 16:58:14 +01:00
210d0489c5
Fixed #21188 -- Introduced subclasses for to-be-removed-in-django-XX warnings
...
Thanks Anssi Kääriäinen for the idea and Simon Charette for the
review.
2014-03-08 09:57:40 +01:00
34236efc5e
Reworked ErrorDict.as_json() to prevent unnecessary serialization/deserialization step.
...
Thanks @apollo13 for the suggestion. Refs #17413 .
2014-03-06 18:33:58 +01:00
95c74b9d69
Fixed #22206 -- Passed models.TextField.max_length to forms.CharField.maxlength
2014-03-05 20:09:28 +01:00
0d91225892
Fixed many typos in comments and docstrings.
...
Thanks Piotr Kasprzyk for help with the patch.
2014-03-03 07:38:09 -05:00
a19f0d0c1e
Fixed #22137 -- Made Widget.is_hidden a read-only property
...
Thanks django at patjack.co.uk for the report and the review.
2014-03-01 10:36:48 +01:00
c23b3717be
Fixed #21962 -- Added escape_html flag to ErrorDict.as_json()
2014-02-28 07:05:55 -05:00
9f76d0d351
Fixed #22136 -- Updated comment for Textarea widget
...
Thanks Aymeric Augustin for the suggestion.
2014-02-27 19:38:37 +01:00
cb844497d0
Fixed #22097 -- Fixed change detection for TypedChoiceField
...
Thanks Igor Mitrenko for the report.
2014-02-20 13:40:42 +01:00
eefc88feef
Fixed #2445 -- Allowed limit_choices_to attribute to be a callable.
...
ForeignKey or ManyToManyField attribute ``limit_choices_to`` can now
be a callable that returns either a ``Q`` object or a dict.
Thanks michael at actrix.gen.nz for the original suggestion.
2014-02-11 14:05:12 -05:00
8847a0c601
Fixed #16192 -- Made unique error messages in ModelForm customizable.
...
Overriding the error messages now works for both unique fields, unique_together
and unique_for_date.
This patch changed the overriding logic to allow customizing NON_FIELD_ERRORS
since previously only fields' errors were customizable.
Refs #20199 .
Thanks leahculver for the suggestion.
2014-02-08 04:59:09 -05:00
d818e0c9b2
Fixed #16905 -- Added extensible checks (nee validation) framework
...
This is the result of Christopher Medrela's 2013 Summer of Code project.
Thanks also to Preston Holmes, Tim Graham, Anssi Kääriäinen, Florian
Apolloner, and Alex Gaynor for review notes along the way.
Also: Fixes #8579 , fixes #3055 , fixes #19844 .
2014-01-20 10:45:21 +08:00
0179852d7f
Fixed #8898 -- Obsoleted SplitDateTimeWidget usage with DateTimeField
...
Thanks Tim Graham for the review.
2014-01-11 15:50:34 +01:00
18374c1d8c
Fixed #21752 -- Prevented custom widget step attribute to be overwritten
...
Thanks orcein at gmail.com for the report.
2014-01-11 14:08:04 +01:00
81bb8d1220
Fixed docstring typo in django/forms/forms.py.
2014-01-10 08:33:30 -05:00
2fd7fc134c
Refs #17413 -- Added isinstance backward compatibility on ErrorList.
2013-12-18 08:59:53 -05:00
fe1389e911
Removed duplicated `TimeField` in __all__.
2013-12-16 17:52:37 -05:00
3ce9829b61
Fixed #17413 -- Serialization of form errors along with all metadata.
2013-12-16 16:33:28 -05:00
6685713869
Fixed E127 pep8 warnings.
2013-12-14 11:59:15 -05:00
a2814846ca
Fixed E124 pep8 warnings.
2013-12-10 15:12:48 -05:00
8a9c8bb907
Fixed #21568 -- Added missing ModelMultipleChoiceField to_python method
...
Thanks dibrovsd at gmail.com for the report and Simon Charette
for the review.
2013-12-07 10:14:22 +01:00
f563c339ca
Fixed #20867 -- Added the Form.add_error() method.
...
Refs #20199 #16986 .
Thanks @akaariai, @bmispelon, @mjtamlyn, @timgraham for the reviews.
2013-11-30 01:00:53 +07:00
7477a4ffde
Fixed E125 pep8 warnings
2013-11-28 08:50:11 -05:00
1c7a83ee8e
Fixed #21489 -- Make formsets directly importable from django.forms.
2013-11-25 19:16:19 -05:00
fafb6cf049
Fixed #21472 -- Fixed inline formsets display when parent pk is 0
...
Thanks agale031176@gmail.com for the report.
2013-11-20 21:36:20 +01:00
a0f3eeccf3
Fixed #21397 -- Re-added flexibility to TypedChoiceField coercion
...
Thanks Elec for the report and Simon Charette for the review.
2013-11-18 18:24:56 +01:00
326539f6a4
Fixed a regression caused by fix for #21428
...
On Python 3 sorting Fields mixed with GenericForeignKeys doesn't work
as GenericForeignKey isn't a subclass of django.db.models.fields.Field.
Refs #21428 .
2013-11-16 20:54:36 +02:00
0e079e4331
Fixed #21428 -- editable GenericRelation regression
...
The GenericRelation refactoring removed GenericRelations from
model._meta.many_to_many. This had the side effect of disallowing
editable GenericRelations in ModelForms. Editable GenericRelations
aren't officially supported, but if we don't fix this we don't offer any
upgrade path for those who used the ability to set editable=True
in GenericRelation subclass.
Thanks to Trac alias joshcartme for the report and stephencmd and Loic
for working on this issue.
2013-11-16 20:07:35 +02:00
5fda9c9810
Fixed #21423 -- Fixed typo in widgets.py.
2013-11-11 18:03:01 +01:00
bc21e9c0d9
Fixed #13970 -- Made SelectDateWidget use the standard widget is_required attribute
...
Thanks mitar for the report and Tim Graham for the review.
2013-11-08 16:58:17 +01:00
c347f78cc1
Fixed all E226 violations
2013-11-03 10:08:55 -08:00
7288e1b02b
Merge pull request #1852 from jasonamyers/cleanup/PEP8
...
Cleanup/pep8 tests
2013-11-03 09:51:49 -08:00
91078f5669
Merge pull request #1861 from milmazz/E251
...
Fixed flake8 E251 violations
2013-11-03 09:42:31 -08:00
4f151da1e5
Merging in master
...
Signed-off-by: Jason Myers <jason@jasonamyers.com>
2013-11-03 07:19:25 -06:00
539e3693d4
Fixed #20849 -- ModelForms do not work well with prefetch_related.
...
model_to_dict() (used when rendering forms) queries the database
to get the list of primary keys for ManyToMany fields. This is
unnecessary if the field queryset has been prefetched, all the
keys are already in memory and can be obtained with a simple
iteration.
2013-11-03 12:27:54 +02:00
cbc7cbbc5b
Fixed flake8 E251 violations
2013-11-03 03:22:11 -06:00
Tim Graham
Yang Liu
Josh Schneier
Daniel Pyrathon
Anssi Kääriäinen
Marc Tamlyn
Michael Hall
Grzegorz Slusarek
Jon Dufresne
Berker Peksag
Simon Charette
Tim Heap
Baptiste Mispelon
Peter Inglesby
Thomas Chaumeny
Loic Bistuer
Petras Zdanavičius
Vlastimil Zíma
areski
Gabriel Muñumel
Vincent-Vega
Niclas Olofsson
Kit La Touche
Daniel Hahler
Claude Paroz
Anubhav Joshi
gyx1000
Nick Presta
Alex Gaynor
Stephen Burrows
Anders Steinlein
Julen Ruiz Aizpuru
Ben Davis
Tomasz Wysocki
Chris Beaven
Chris Wilson
Rodolfo Carvalho
vvojvoda
Christopher Adams
Loic Bistuer
Russell Keith-Magee
Marc Sibson
Artur Barseghyan
Christopher Medrela
Jason Myers
Jim Bailey
Milton Mazzarri