8092745593
Fixed #25779 -- Removed redundant try block in WSGIHandler
2015-11-20 16:12:17 +02:00
fa08d27fb7
Fixed #25677 -- Prevented decoding errors in/after Popen calls
...
Thanks Gavin Wahl for the report and Tim Graham for the review.
2015-11-19 15:17:47 +01:00
c7adfe941b
Removed redundant termcolors.
...
Replaced MIGRATE_SUCCESS and MIGRATE_FAILURE with
SUCCESS and ERROR.
2015-11-18 10:26:39 -05:00
0a2d3b7387
Fixed #25682 -- Removed bare except clauses.
2015-11-17 14:39:15 -05:00
92eced62cd
Simplified lists creation in three places.
2015-11-17 07:58:49 -05:00
1aba0e4c68
Refs #25501 -- Fixed a typo in django/core/cache/backends/filebased.py
...
The original intent in refs #20536 was to use the highest protocol.
Calling zlib.compress() with a compression level of -1 seems to
fall back to the default level of 6.
2015-11-14 15:10:14 -05:00
9bc0c21b1c
Made BaseCommand.get_version() docstring consistent with docs.
2015-11-14 07:58:58 -05:00
3ee18400ae
Fixed #25668 -- Misc spelling errors
2015-11-03 11:58:13 +02:00
06627ef2ca
Fixed #25635 -- Made URLValidator allow '+' in scheme.
2015-10-31 17:50:05 -04:00
7d81ee6efc
Fixed #16734 -- Set script prefix even outside of requests
...
Thanks Tim Graham for the review.
2015-10-29 20:12:38 +01:00
96fe90f535
Fixed #25620 -- Made URLValidator prohibit URLs with consecutive dots in the domain section.
2015-10-29 10:59:22 -04:00
ea2f48ce8b
Refs #17133 -- Optimized script_url handling in get_script_name
...
10ace52a
2015-10-27 14:29:18 +01:00
9c5e272860
Fixed #25550 -- Deprecated direct assignment to the reverse side of a related set.
2015-10-27 07:57:15 -04:00
5d35b53c36
Removed hardcoded utf-8 BOM, used value from codecs instead.
2015-10-25 09:28:11 -07:00
3c7d2ee881
Fixed #25604 -- Added makemigrations --check option.
...
Command exits with non-zero status if changes without migrations exist.
2015-10-24 14:45:00 -04:00
a1b9737aea
Cached model field_names in Python Deserializer.
2015-10-23 16:23:30 -04:00
10ace52a41
Fixed #17133 -- Properly handled successive slashes in incoming requests
...
Thanks gjanee@ucop.edu for the report and Tim Graham for the review.
2015-10-23 22:18:18 +02:00
37ea3cb03e
Fixed "URLconf" spelling in code comments.
2015-10-22 14:46:42 -04:00
3f300efede
Fixed #25589 -- Allowed startapp/project to create apps with Unicode characters in the name.
2015-10-22 13:01:07 -04:00
48888a1a67
Fixed #25501 -- Made the file-based cache backend use the highest pickling protocol.
2015-10-20 13:05:33 -04:00
df0a446fd4
Fixed #25510 -- Allowed runserver to start with incorrect INSTALLED_APPS.
...
In that case, the content of INSTALLED_APPS will be ignored until it's
fixed and the autoreloader kicks in. I confirmed this behavior manually.
As explained on the ticket it's hard to write a test for this case
2015-10-18 10:34:04 +02:00
2875325889
Fixed #25500 -- Added --fail-level option to check command.
...
This option specifies the level that check command exits with a
non-zero status. Default is ``ERROR``.
2015-10-05 17:11:40 -04:00
3f22e83e90
Fixed #25483 -- Allowed passing non-string arguments to call_command
...
Thanks KS Chan for the report and Tim Graham for the review.
2015-10-03 14:40:33 +02:00
b7ade64529
Fixed #25468 -- Made DjangoJSONEncoder lazy string aware
...
Thanks Stavros Korokithakis for the report and Tim Graham for the
review.
2015-09-27 22:37:27 +02:00
e6cfa08f2d
Refs #22804 -- Made an unsafe value of 'sep' in Signer an exception.
...
Per deprecation timeline.
2015-09-23 19:31:11 -04:00
2a20ebe6a5
Removed deprecated TEMPLATE_* settings per deprecation timeline.
2015-09-23 19:31:11 -04:00
54fd769eb4
Removed django.core.context_processors per deprecation timeline.
2015-09-23 19:31:10 -04:00
b4002a2143
Refs #22835 -- Removed NoArgsCommand per deprecation timeline.
2015-09-23 19:31:10 -04:00
b6e6fcf326
Refs #23359 -- Removed the migrate --list option per deprecation timeline.
2015-09-23 19:31:10 -04:00
1bb6ecf6d3
Refs #9893 -- Removed shims for lack of max_length support in file storage per deprecation timeline.
2015-09-23 19:31:10 -04:00
6a70cb5397
Refs #19973 -- Removed optparse support in management commands per deprecation timeline.
2015-09-23 19:31:10 -04:00
785cc71d5b
Refs #22384 -- Removed the ability to reverse URLs by dotted path per deprecation timeline.
2015-09-23 19:31:09 -04:00
a25d3ce007
Refs #22218 -- Removed conf.urls.patterns() per deprecation timeline.
2015-09-23 19:31:09 -04:00
04ee4059d7
Refs #24022 -- Removed the ssi tag per deprecation timeline.
2015-09-23 19:31:09 -04:00
f2975c021d
Refs #23813 -- Moved URLconfs into module and tidied docstrings.
2015-09-21 20:10:33 -04:00
c07f9fef39
Corrected docstring in core.urlresolvers module.
...
The RegexURLResolver.resolve() method no longer returns a tuple.
It has returned a ResolverMatch object since commit e0fb90b2
2015-09-21 13:59:17 -04:00
fe3fc5210f
Fixed #23813 -- Added checks for common URL pattern errors
...
Thanks jwa and lamby for the suggestions, and timgraham and jarshwah
for their reviews.
2015-09-21 23:46:21 +10:00
43f2eb7ef3
Fixed #25390 -- Allowed specifying a start migration in squashmigrations
...
Thanks Tim Graham for the review.
2015-09-19 14:55:34 +10:00
75ed590032
Fixed #24636 -- Added model field validation for decimal places and max digits.
2015-09-18 14:30:20 -04:00
b02f08e02c
Fixed #25034 -- Converted caches ImproperlyConfigured error to a system check.
2015-09-18 07:44:39 -04:00
8615e41586
Fixed typo in django/core/cache/backends/base.py docstring.
2015-09-16 09:29:56 -04:00
d731cf5caf
Added upgrade tip in BaseCommand.option_list deprecation comment.
2015-09-15 12:06:29 -04:00
b1e33ceced
Fixed #23395 -- Limited line lengths to 119 characters.
2015-09-12 11:40:50 -04:00
326bc0955b
Allowed a port range for the liveserver by default.
...
This is required for running tests in parallel.
2015-09-09 23:01:16 +02:00
acb833081d
Fixed #25372 -- Fixed autocompletion for options of non-argparse commands.
2015-09-09 14:51:41 -04:00
1bbca7961c
Fixed #25350 -- Added alias --no-input for --noinput to management commands.
2015-09-08 08:41:03 -04:00
721d8e50ac
Fixed #25144 -- Allowed migrate to create tables for apps without migrations.
2015-09-04 09:47:30 -04:00
5153a3bfdc
Fixed #25331 -- Removed trailing blank lines in docstrings.
2015-08-31 17:37:21 -04:00
fe6ddb837d
Fixed #24704 -- Made the autoreloader survive SyntaxErrors.
...
With this change, it's expected to survive anything except errors
that make it impossible to import the settings. It's too complex
to fallback to a sensible behavior with a broken settings module.
Harcoding things about runserver in ManagementUtility.execute is
atrocious but it's the only way out of the chicken'n'egg problem:
the current implementation of the autoreloader primarily watches
imported Python modules -- and then a few other things that were
bolted on top of this design -- but we want it to kick in even if
the project contains import-time errors and django.setup() fails.
At some point we should throw away this code and replace it by an
off-the-shelf autoreloader that watches the working directory and
re-runs `django-admin runserver` whenever something changes.
2015-08-29 20:49:56 +02:00
e75882332c
Fixed #17375 -- Changed makemessages to use xgettext with --files-from
...
Changed the way makemessages invokes xgettext from one call per
translatable file to one call per locale directory (using --files-from).
This allows to avoid https://savannah.gnu.org/bugs/index.php?35027 and,
as a positive side effect, speeds up localization build.
2015-08-28 15:41:58 -04:00
01b2b0b654
Fixed #25318 -- Made SILENCED_SYSTEM_CHECKS suppress all messages.
...
Previously, messages of ERROR level or higher were printed to
the console.
2015-08-28 13:34:56 -04:00
2bb1027d6b
Fixed #25322 -- Lazily compiled core.validators regular expressions.
...
This speeds up import of 'django.core.validators' which can save a
few hundred milliseconds when importing the module for the first
time. It can be a significant speedup to the django-admin command.
2015-08-28 13:05:41 -04:00
45ed19de68
Fixed #25047 -- Improved "Conflicting migrations" error message.
2015-08-24 08:05:21 -04:00
c1893e2839
Fixed #25285 -- Provided unknown command message with plain django-admin.py
...
Thanks Maxime Lorant for the report and Tim Graham for suggesting
the improved comment.
2015-08-19 19:58:44 +02:00
0271a11ba5
Fixed #24755 -- Hid operations from dependency apps when merging migrations
...
Thanks Carl Meyer for the report and Tim Graham for the review.
2015-08-18 18:33:14 +10:00
69db1c7455
Fixed #25231 -- Added recording of squashed migrations in the migrate command.
...
Ensured squashed migrations are recorded as applied when the
migrate command is run and all of the original migrations
have been previously applied.
2015-08-07 17:59:18 -04:00
1a76257b1b
Fixed #25204 -- Added missing space in runserver logging.
2015-08-01 08:01:24 -04:00
c2e70f0265
Fixed #21127 -- Started deprecation toward requiring on_delete for ForeignKey/OneToOneField
2015-07-27 18:28:13 -04:00
c6da621def
Fixed #24623 -- Fixed EmailMessage.attach_file() with text files on Python 3.
...
Thanks tkrapp for the report and Tim Graham for the review.
2015-07-25 07:42:30 -04:00
c296e55dc6
Fixed #22258 -- Added progress status for dumpdata when outputting to file
...
Thanks Gwildor Sok for the report and Tim Graham for the review.
2015-07-24 18:37:55 +02:00
5cedef9b50
Fixed #25155 -- Removed an inner class in core.management.color for PyPy performance.
2015-07-21 13:07:45 -04:00
6e3fe089dd
Replaced six.BytesIO with io.BytesIO
2015-07-20 08:19:47 -04:00
f8cc464452
Fixed #16501 -- Added an allow_unicode parameter to SlugField.
...
Thanks Flavio Curella and Berker Peksag for the initial patch.
2015-07-17 13:48:58 -04:00
ed514caed2
Fixed #24966 -- Added deployment system check for empty ALLOWED_HOSTS.
2015-07-15 09:18:58 -04:00
035b0fa60d
Fixed #24716 -- Deprecated Field._get_val_from_obj()
...
The method duplicates the functionality of Field.value_from_object()
and has the additional downside of being a privately named public
API method.
2015-07-14 09:13:22 -04:00
561c018d88
Fixed #25123 -- Corrected makemessages --extension help text
2015-07-14 07:35:27 -04:00
24620d71f2
Fixed #25079 -- Added warning if both TEMPLATES and TEMPLATE_* settings are defined.
...
Django ignores the value of the TEMPLATE_* settings if TEMPLATES is also
set, which is confusing for users following older tutorials. This change
adds a system check that warns if any of the TEMPLATE_* settings have
changed from their defaults but the TEMPLATES dict is also non-empty.
Removed the TEMPLATE_DIRS from the test settings file; this was marked
for removal in 1.10 but no tests fail if it is removed now.
2015-07-13 17:50:22 -04:00
db97a88495
Fixed #24375 -- Added Migration.initial attribute
...
The new attribute is checked when the `migrate --fake-initial` option
is used. initial will be set to True for all initial migrations (this
is particularly useful when initial migrations are split) as well as
for squashed migrations.
2015-07-13 15:57:40 -04:00
17d3a6d804
Fixed catastrophic backtracking in URLValidator.
...
Thanks João Silva for reporting the problem and Tim Graham for finding the
problematic RE and for review.
This is a security fix; disclosure to follow shortly.
2015-07-08 15:23:03 -04:00
014247ad19
Prevented newlines from being accepted in some validators.
...
This is a security fix; disclosure to follow shortly.
Thanks to Sjoerd Job Postmus for the report and draft patch.
2015-07-08 15:23:03 -04:00
0d71349773
Fixed #22804 -- Added warning for unsafe value of 'sep' in Signer
...
Thanks Jaap Roes for completing the patch.
2015-07-07 11:44:37 -04:00
bc98bc56a5
Fixed #25059 -- Allowed Punycode TLDs in URLValidator
2015-07-06 15:08:43 -04:00
b74b94445d
Updated Memcached get_backend_timeout() comment.
2015-07-06 10:13:20 -04:00
f5d5867a4a
Fixed #24877 -- Added middleware handling of response.render() errors.
2015-07-03 12:06:40 -04:00
b91a2a499f
Fixed #23190 -- Made Paginator.page_range an iterator
2015-07-03 11:34:34 -04:00
c6cce4de38
Fixed #25050 -- Allowed serialization of models with deferred fields.
2015-07-02 14:46:16 -04:00
7da3923ba0
Sorted imports in __init__.py files.
2015-06-27 11:53:33 -04:00
aaacaeb096
Renamed RemovedInDjangoXYWarnings for new roadmap.
...
Forwardport of ae1d663b79
2015-06-24 16:08:20 -04:00
e73842a95f
Reordered import in JSON serializer
2015-06-24 18:45:46 +02:00
6355a6d4f5
Fixed #25019 -- Added UUID support in DjangoJSONEncoder
2015-06-24 18:41:25 +02:00
e7b4bd48c7
Fixed #24970 -- Added --managers and --admins options to the sendtestemail management command.
2015-06-22 07:21:26 -04:00
738c0de300
Fixed #14200 -- Added a fallback if HttpRequest.urlconf is None.
...
Made BaseHandler fall back to settings.ROOT_URLCONF if
HttpRequest.urlconf is set to None, rather than raising
ImproperlyConfigured.
2015-06-20 18:52:33 -04:00
9368f51e12
Fixed #20197 -- Made XML serializer fail loudly when outputting unserializable chars
...
Thanks Tim Graham for the review.
2015-06-19 20:54:46 +02:00
7f1168e387
Removed support for Python 3.3.
2015-06-18 08:36:50 -04:00
2f615b10e6
Fixed #24829 -- Allowed use of TemplateResponse in view error handlers.
2015-06-17 17:11:50 -04:00
e6dd7f995a
Fixed #24971 -- Made startapp generate an apps.py
2015-06-16 07:08:04 -04:00
3872a33132
Fixed #24979 -- Removed usage of inspect.getargspec().
2015-06-15 13:43:22 -04:00
4b600ed244
Removed django.utils.functional.total_ordering()
2015-06-15 13:15:24 -04:00
98df288dda
Fixed #24978 -- Escaped special characters in loaddata fixture paths
2015-06-13 19:45:05 -04:00
e93e0c03b2
Fixed #24963 -- Added File.seekable() on Python 3.
2015-06-12 10:17:21 -04:00
5d42890821
Fixed #24950 -- Added unicode_literals to models.py in app template
...
Thanks Tim Graham for the patch
2015-06-11 16:38:12 +02:00
9851e54121
Merge pull request #4811 from mthornhill/12685
...
Fixed #12685 - Ensure that deserialised model instances honor the same arguments as normal models.
2015-06-10 21:41:48 +08:00
211c19c579
Fix for ticket 12685
2015-06-10 10:20:51 +01:00
a0047c6242
Fixed #24769 -- Cast optparse verbosity argument to an integer for better backwards compatibility.
...
Using `BaseCommand.options_list` makes Django use the legacy optparse
parser, which does not set the verbosity attribute correctly. Now the
verbosity argument is always cast to int. Regression in 8568638#19973 ).
Initial report and patch from blueyed.
2015-06-09 19:03:23 -04:00
eaf4d8c0d8
Fixed #24922 -- Added system check for templates setting
...
If `'loaders'` is present in the `TEMPLATES` options together with
`APP_DIRS` set to `True`, the template engine raises an exception. This
conflict is now detected by the system check templates.E001.
2015-06-06 19:40:26 -04:00
bc77eb6d08
Fixed #24906 -- Fixed ResolverMatch.app_name for nested namespaces.
...
Set ResolverMatch.app_name to the full path of nested application
namespaces.
2015-06-06 10:44:43 -04:00
f0450c9b12
Fixed #24904 -- Fixed nested namespaces in current_app.
...
Fixed reverse() to correctly handled nested namespace lookups
in current_app.
2015-06-05 11:47:21 -04:00
40f0a84cb1
Fixed #24159 -- Made compilemessages run across all apps.
...
Updated the command to match the documentation, which states it
runs over all .po files.
2015-06-04 21:02:02 -04:00
0688a7946a
Fixed #24776 -- Improved apps.get_app_config() error message on fully-qualified package names.
2015-05-22 11:08:25 -04:00
7b027c463e
Fixed #24805 -- Delayed check for locale_dir in makemessages
...
Thanks Wim Feijen for the report.
2015-05-18 14:12:49 +02:00
e2a652fac1
Refactored datetime handling in the database cache backend.
...
Took advantage of the new database adapters and converters.
2015-05-17 09:40:33 +02:00
54026f1e8d
Renamed value_to_db_xxx to adapt_xxxfield_value.
...
This mirrors convert_xxxfield_value nicely, taking advantage of the
adapter/converter terminology which is commonly used by DB-API modules.
2015-05-17 09:39:34 +02:00
ec186572e6
Removed global timezone-aware datetime converters.
...
Refs #23820 .
2015-05-17 09:36:23 +02:00
4157c502a5
Removed unnecessary arguments in .get method calls
2015-05-13 20:51:18 +02:00
f61c4f490d
Fixed #24742 -- Made runserver.check_migrations ignore read-only databases
...
Thanks Luis Del Giudice for the report, and Aymeric Augustin and Markus
Holtermann for the reviews.
2015-05-13 18:30:36 +02:00
0d7a295f28
Allowed runserver sublcasses to easily override the default port.
2015-05-12 08:51:29 -04:00
70779d9c1c
Fixed #24733 -- Passed the triggering exception to 40x error handlers
...
Thanks Tim Graham for the review.
2015-05-11 22:02:14 +02:00
69125ce904
Extended variable name in handlers/base.py
...
Refs #24733 .
2015-05-05 10:58:27 +02:00
69ddc1b3da
Fixed #24693 -- Added label and label_lower property to Model._meta
2015-05-02 16:58:18 +02:00
57202a112a
Fixed #23271 -- Fixed makemessages crash/test failure for some locales.
2015-05-01 10:27:28 -04:00
40768ec29d
Fixed #24707 -- Improved error reporting for explicitly imported uncallable views
2015-04-26 19:19:15 +02:00
1521861b3c
Fixed #24703 -- Changed squashmigrations to use a MigrationLoader
...
Changed squashmigrations to not instantiate a MigrationExecutor,
but to directly use a MigrationLoader instance instead.
2015-04-25 17:41:17 +02:00
9346e45f84
Fixed #24664 -- Removed misleading arg name from TemporaryFileUploadHandler.new_file
2015-04-20 11:59:30 +02:00
8097e54832
Fixed #23879 -- Allowed model migration skip based on feature/vendor
...
Thanks Carl Meyer for the report and review, and Tim Graham for the
review.
2015-04-18 15:17:49 +02:00
2400329508
Fixed #24349 -- Limited domain name labels to 63 characters in EmailValidator
2015-04-17 18:08:33 -04:00
188a241880
Fixed #21652 -- Added notification when processing objects in loaddata
...
Added a running count of the objects processed by loaddata when
verbosity >= 3.
2015-04-16 09:42:18 -04:00
503bbc49d8
Added missing periods in migrate help messages.
2015-04-14 08:10:16 -04:00
5564d0f2ee
Fixed #24560 -- Added a --dry-run mode to the createcachetable command.
2015-04-09 12:15:50 -04:00
727e40c879
Fixed #19820 -- Added more helpful error messages to Python deserializer.
2015-04-09 10:56:33 -04:00
0824c02603
Removed unused exception "as" variable.
2015-04-08 13:09:51 -04:00
2fc19b9238
Fixed #24544 -- Fixed get_image_dimensions() on image buffers that Pillow fails to parse.
...
Thanks Steve Kossouho for the report and original patch.
2015-04-07 19:51:19 -04:00
426b63ba04
Fixed #24571 -- Restored testserver positional arguments parsing
...
Thanks Domas Lapinskas for the report and Tim Graham for the
review.
2015-04-04 10:46:29 +02:00
2c39f282b8
Fixed typo in django.core.files.File docstring.
2015-04-02 20:38:22 -04:00
5bc3123479
Fixed #24558 -- Made dumpdata mapping ordering deterministic.
...
Thanks to gfairchild for the report and Claude for the review.
2015-04-02 15:21:43 -04:00
a2e56db8a7
Removed unused import in makemessages
2015-04-01 20:01:12 +02:00
3f4e778402
Refs #24500 -- Avoided locale.getpreferredencoding in makemessages
...
Fixes a regression introduced in 53c2cf1e
2015-04-01 19:57:48 +02:00
3e64f3d0fc
Fixed #24531 -- Improved CommaSeparatedIntegerField validation.
...
`','`, `'1,,1'`, `',1'` etc. are no longer considered as valid
comma-separated integer lists.
2015-03-25 18:49:59 -04:00
cda74c7fc9
Fixed #24441 -- Changed get_image_dimensions() return value for broken images
2015-03-25 12:39:29 -04:00
8f30556329
Renamed Field.rel attribute to remote_field
...
Field.rel is now deprecated. Rel objects have now also remote_field
attribute. This means that self == self.remote_field.remote_field.
In addition, made the Rel objects a bit more like Field objects. Still,
marked ManyToManyFields as null=True.
2015-03-25 08:16:12 -04:00
53c2cf1e7b
Fixed #24500 -- Fixed makemessages encoding problems retrieving gettext version.
2015-03-21 09:08:51 -04:00
a3e75f6bed
Removed unused imports.
2015-03-20 17:57:11 -04:00
ba37ac749e
Adapted sendtestemail to be more argparse-ish
2015-03-20 20:40:35 +01:00
d898ba1bec
Fixed #24419 -- Added sendtestemail management command
2015-03-20 12:03:50 -04:00
a0c2eb46dd
Fixed #23960 -- Removed http.fix_location_header
...
Thanks Carl Meyer for the report and Tim Graham for the review.
2015-03-18 18:22:50 +01:00
0339844b70
Fixed #24476 -- Added context manager/decorator for overriding script prefix.
...
Tests were using an undocumented keyword argument for easily overriding
script prefix while reversing. This is now changed into a test utility
which can be used as decorator or context manager.
2015-03-18 13:03:25 -04:00
8758a63ddb
Fixed #24427 -- Stopped writing migration files in dry run mode when merging.
...
Also added display of migration to stdout when verbosity=3.
2015-03-16 14:04:37 -04:00
34fb909180
Fixed #12982 -- Added a get_or_set() method to the BaseCache backend.
2015-03-14 20:07:16 +02:00
a52cd407b8
Fed tuples to startswith when appropriate
2015-03-13 21:58:28 +01:00
5993b52e6d
Fixed #24416 -- Added support for lazy email addresses.
2015-03-13 12:33:49 -04:00
aa5ab114e3
Fixed #24122 -- Redirected to translated url after setting language
...
Thanks gbdlin for the initial patch and Tim Graham for the review.
2015-03-13 16:46:40 +01:00
c9f1a12925
Fixed #24013 -- Fixed escaping of reverse() prefix.
...
Prefix was treated as a part of the url pattern, which it is not.
Improved tests to conform with RFC 3986 which allows certain
characters in path segments without being escaped.
2015-03-12 19:05:17 -04:00
f0f5212624
Fixed #12943 -- Allowed unnamed arguments to be propagated in includes
...
Propagated unnamed arguments as positional arguments into included
URLconfs if no named arguments are defined. Positional and keyword
arguments are never combined.
2015-03-12 09:18:39 -04:00
578ac17f81
Made runserver use leave_locale_alone
2015-03-09 18:59:27 +01:00
e272904ff7
Fixed #23407 -- Extended coverage of makemigrations --noinput option.
...
Changed --noinput option in makemigrations to suppress all user prompts,
not just when combined with --merge.
2015-03-08 19:44:14 +01:00
336512fae7
Fixed #23173 -- Fixed incorrect stripping of SCRIPT_URL
2015-03-08 15:48:27 +01:00
767c33d1fa
Fixed #24369 -- Prevented crash when flushing before db migration
...
Thanks Thomas Tanner for the report and Tim Graham for the review.
2015-03-05 08:57:28 +01:00
23c612199a
Simplified emit_post_migrate from flush command
...
Follow-up of f4f24d30e0
2015-02-28 16:10:32 +01:00
90ab6ee612
Revert "Fixed #24369 -- Prevented crash when `flush`ing before db migration"
...
This reverts commit 9f1dbe29c0
2015-02-28 12:11:27 +01:00
9f1dbe29c0
Fixed #24369 -- Prevented crash when `flush`ing before db migration
...
Thanks Thomas Tanner for the report.
2015-02-28 10:12:32 +01:00
556a74879f
Fixed a few uses of Template that relied on a default engine.
...
Refs #24389 .
2015-02-22 23:13:55 +01:00
c688460df6
Removed rmtree_errorhandler.
...
The stated reason for its introduction in d18d37ce
2015-02-22 23:09:42 +01:00
bed504d70b
Fixed #24351 , #24346 -- Changed the signature of allow_migrate().
...
The new signature enables better support for routing RunPython and
RunSQL operations, especially w.r.t. reusable and third-party apps.
This commit also takes advantage of the deprecation cycle for the old
signature to remove the backward incompatibility introduced in #22583 ;
RunPython and RunSQL won't call allow_migrate() when when the router
has the old signature.
Thanks Aymeric Augustin and Tim Graham for helping shape up the patch.
Refs 22583.
2015-02-20 21:34:09 +07:00
e467919c63
Fixed typo in django.core.servers.basehttp message.
2015-02-19 19:31:49 -05:00
81a94cc616
Refs #24324 -- Fixed makemessages crash when Django is installed in a non-ASCII path.
2015-02-17 08:06:33 -05:00
4a0aeac1b5
Refs #24324 -- Fixed management command discovery on non-ASCII paths.
2015-02-17 07:27:47 -05:00
5c995dcfc2
Fixed #24320 - Used field.value_to_string() in serialization of foreign key.
...
This fixes serialization of a ForeignKey to a UUIDField as the
test indicates.
2015-02-13 12:37:23 -05:00
f287bec583
Fixed #24184 -- Prevented automatic soft-apply of migrations
...
Previously Django only checked for the table name in CreateModel
operations in initial migrations and faked the migration automatically.
This led to various errors and unexpected behavior. The newly introduced
--fake-initial flag to the migrate command must be passed to get the
same behavior again. With this change Django will bail out in with a
"duplicate relation / table" error instead.
Thanks Carl Meyer and Tim Graham for the documentation update, report
and review.
2015-02-13 14:29:59 +01:00
c970018f41
Removed Django 1.7 MIDDLEWARE_CLASSES upgrade check.
2015-02-09 19:16:07 -05:00
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
bbe28496d3
Removed old import aliases.
2015-02-05 19:37:01 -05:00
de62b8ef45
Simplified handling of RegexURLResolver.urlconf_module.
...
Also made RegexURLResolver.url_patterns a cached property for
consistency and efficiency.
2015-02-05 12:43:55 +01:00
9ec8aa5e5d
Fixed #24149 -- Normalized tuple settings to lists.
2015-02-03 14:59:45 -05:00
24b2bc635e
Fixed #24137 -- Switched to HTTP reason phrases from Python stdlib.
2015-01-28 06:59:40 -05:00
4a5512a61d
Refs #16905 -- Replaced call to removed method in runserver
...
Regression introduced in 0f169098ef
2015-01-19 12:26:00 +01:00
7e8cf74dc7
Removed support for syncing apps without migrations per deprecation timeline.
...
Kept support for creating models without migrations when running tests
(especially for Django's test suite).
2015-01-18 15:58:06 -05:00
0f169098ef
Removed BaseCommand.validate() per deprecation timeline; refs #16905 .
2015-01-18 14:49:51 -05:00
c3336e7e4f
Removed dumpdata --natural option and serializers use_natural_keys parameter.
...
Per deprecation timeline; refs #13252 .
2015-01-17 20:18:34 -05:00
40d6b376d4
Removed BaseMemcachedCacheMethods._get_memcache_timeout backwards compatibility shim.
...
Per deprecation timeline; refs #21147 .
2015-01-17 19:32:54 -05:00
0622bca5d1
Removed the validate management command per deprecation timeline.
2015-01-17 19:12:03 -05:00
e278407b20
Removed unused imports from previous commit.
2015-01-17 13:22:52 -05:00
4a03d348c7
Removed BaseCommand.requires_model_validation per deprecation timeline.
2015-01-17 12:59:07 -05:00
00a11994a5
Removed support for AppCommand.handle_app() per deprecation timeline.
2015-01-17 12:34:34 -05:00
b845951fd4
Required sqlparse for SQL splitting per deprecation timeline.
2015-01-17 10:20:30 -05:00
4aa089a9a9
Removed support for custom SQL per deprecation timeline.
2015-01-17 10:16:06 -05:00
67235fd4ef
Removed support for initial_data fixtures per deprecation timeline.
2015-01-17 09:59:25 -05:00
d038c547b5
Removed django.core.cache.get_cache() per deprecation timeline; refs #21012 .
2015-01-17 09:55:18 -05:00
f6463bb380
Removed the syncdb command per deprecation timeline.
2015-01-17 09:20:12 -05:00
f4f24d30e0
Removed pre_syncdb and post_syncdb signals per deprecation timeline.
2015-01-17 09:07:00 -05:00
fed25f1105
Removed compatibility with Python 3.2.
2015-01-17 09:00:17 -05:00
41f0d3d3bc
Removed FastCGI support per deprecation timeline; refs #20766 .
2015-01-17 08:32:31 -05:00
75f107b884
Removed request.REQUEST per deprecation timeline; refs #18659 .
2015-01-17 08:05:18 -05:00
dc90bf2ac8
Removed unused import
2015-01-14 09:31:24 +01:00
316b8d4974
Stripped headers containing underscores to prevent spoofing in WSGI environ.
...
This is a security fix. Disclosure following shortly.
Thanks to Jedediah Smith for the report.
2015-01-13 13:03:05 -05:00
4c413e231c
Fixed #17785 -- Preferred column names in get_relations introspection
...
Thanks Thomas Güttler for the report and the initial patch, and
Tim Graham for the review.
2015-01-12 19:58:47 +01:00
eeb88123e7
Fixed #24129 -- Added indicator that migrations are rendering the initial state
...
Thanks Tim Graham for the review.
2015-01-12 19:23:46 +01:00
a7c256cb54
Fixed #9893 -- Allowed using a field's max_length in the Storage.
2015-01-12 09:09:18 -05:00
f7c287fca9
Fixed #24073 -- Deactivated translations when leave_locale_alone is False
...
Thanks Tim Graham and Markus Holtermann for the reviews.
2015-01-07 20:11:24 +01:00
fb48eb0581
Fixed #12663 -- Formalized the Model._meta API for retrieving fields.
...
Thanks to Russell Keith-Magee for mentoring this Google Summer of
Code 2014 project and everyone else who helped with the patch!
2015-01-06 19:25:12 -05:00
2e65d56156
Fixed #20003 -- Improved and extended URLValidator
...
This adds support for authentication data (`user:password`) in URLs,
IPv6 addresses, and unicode domains.
The test suite has been improved by adding test URLs from
http://mathiasbynens.be/demo/url-regex (with a few adjustments,
like allowing local and reserved IPs).
The previous URL validation regex failed this test suite on 13
occasions, the validator was updated based on
https://gist.github.com/dperini/729294 .
2015-01-06 14:04:25 -05:00
9f328405f6
Fixed gettext version regex
...
...with the theoretical assumption that gettext may once reach a
two-digit number. Thanks Walter Doekes for noticing this potential
issue.
2015-01-06 18:43:32 +01:00
e08318b4ef
Refs #23359 -- Removed double newline from output of migrate --list
...
Thanks Berker Peksag for the review.
2015-01-05 14:52:54 -05:00
6e1c9c6568
Fixed #8280 -- Allowed management command discovery for eggs
...
Thanks jdetaeye for the report, bhuztez and jdetaeye for the
initial patches, Tim Graham and Berker Peksag for the reviews.
2015-01-05 17:19:35 +01:00
3d2cae0896
Fixed #24072 -- Added FileResponse for streaming binary files.
2015-01-05 10:51:52 -05:00
8958170755
Fixed #9104 -- Moved FieldDoesNotExist to core.exceptions
2015-01-02 10:46:04 -05:00
285bd02c92
Show migration elapsed time when verbosity>1
...
This facilitates performance debugging related to migrations.
2015-01-02 15:37:09 +01:00
4ee06ec3fc
Fixed #24069 -- Made ServerHandler a new style class to fix super() call.
2015-01-02 08:51:28 -05:00
b4bdd5262b
Fixed #23366 -- Fixed a crash with the migrate --list command.
2014-12-31 17:26:15 -05:00
7a878ca5cb
Fixed #24008 -- Fixed ValidationError crash with list of dicts.
2014-12-31 14:43:13 -05:00
a1487deebf
Fixed #23359 -- Added showmigrations command to list migrations and plan.
...
Thanks to Collin Anderson, Tim Graham, Gabe Jackson, and Marc Tamlyn
for their input, ideas, and review.
2014-12-31 14:14:28 -05:00
002a8ffe47
Fixed breakage by 6fb9dee4 under Python2+Windows.
...
Refs #23271
2014-12-29 21:04:27 -03:00
1d24f073e6
Fixed #21255 -- Closed connections after management command ran
...
Thanks kabakov.as@gmail.com for the report, and Aymeric Augustin,
Simon Charette for the reviews.
2014-12-29 19:02:45 +01:00
6fb9dee470
Fixed #23271 -- Don't corrupt PO files on Windows when updating them.
...
Make sure PO catalog text fetched from gettext programs via standard
output isn't corrupted by mismatch between assumed (UTF-8) and real
(CP1252) encodings. This can cause mojibake to be written when creating
or updating PO files.
Also fixes #23311 .
Thanks to contributor with Trac nick 'danielmenzel' for the report,
excellent research and fix.
2014-12-29 12:24:50 -03:00
92e8f1f302
Moved context_processors from django.core to django.template.
2014-12-28 17:00:07 +01:00
75bbcfa332
Replaced sqlall in some bash_completion/admin_scripts tests.
...
sqlall will be removed in Django 1.9, so now's a good time to remove
its usage where it's not important.
2014-12-26 18:52:26 -05:00
c2e419c267
Fixed #24054 -- Enabled sqlsequencereset for apps with migrations.
2014-12-26 15:55:34 -05:00
234a2e0b6b
Fixed #23866 -- Harmonized refs to Django documentation from code
2014-12-25 13:53:13 +01:00
426ead27bd
Removed shutil.copystat copied from stdlib (added to support an old Python?).
2014-12-24 19:29:33 -05:00
5dddd79433
Fixed #20349 -- Moved setting_changed signal to django.core.signals.
...
This removes the need to load django.test when not testing.
2014-12-24 07:18:43 -05:00
30cbd5d360
Replaced DatabaseCreation sql methods by schema editor equivalents
...
Also used schema editor in migrate to sync unmigrated apps (sync_apps).
Refs #22340 . Thanks Tim Graham for the review.
2014-12-23 19:35:01 +01:00
9fecb86a52
Fixed #17946 -- Fixed deserialization of self-referencing M2M fields
...
Thanks Philip Mountifield for the report and excellent analysis, and
Simon Charette for the review.
2014-12-23 16:01:39 +01:00
9bcd4d812c
Fixed #23788 (2) -- Improved gettext version checker
...
Thanks Tim Graham for the report and initial patch.
2014-12-18 16:06:33 +01:00
d2ff8a7241
Fixed #23975 -- Restored pre_migrate signal if all apps have migrations.
...
Thanks kmmbvnr for the report.
2014-12-16 18:34:25 -05:00
8f97413fae
Fixed #20968 -- Checked Spatialite metadata before migrations
...
Thanks Kenial S. Lee for the initial patch and Tim Graham for
the review.
2014-12-08 22:22:53 +01:00
4468c08d70
Fixed #23968 -- Replaced list comprehension with generators and dict comprehension
2014-12-08 07:58:23 -05:00
5c773447c3
Tweaked fix for refs #23946 ; thanks Claude.
2014-12-02 15:57:08 -05:00
bba545345f
Fixed #23946 -- Fixed runserver crash when socket error contains Unicode chars.
2014-12-02 12:01:51 -05:00
9253042d53
Fixed #4444 - Made runserver suppress 'broken pipe' errors
...
One handler in WSGIServer, to catch the error when raised from
SocketServer.BaseServer's finish_request, and one in WSGIRequestHandler
(by creating a subclass of ServerHandler), to catch the error when
raised in wsgiref.handlers.BaseHandler's finish_response.
2014-11-28 10:51:15 -05:00
deb607648e
Fixed #23728 -- Added the --exit option to makemigrations.
...
If no changes that need migrations are found, `makemigrations --exit`
exits with error code 1.
2014-11-28 07:48:39 -05:00
e023ceb453
Fixed #23910 -- Added reply_to parameter to EmailMessage
...
Thanks to Berker Peksag and Tim Graham for the review and suggestions.
2014-11-28 06:00:06 -05:00
abf87333a1
Fixed #23924 -- Made EmailMessage raise TypeError for type checks
2014-11-27 18:43:45 -05:00
093e6c68b9
Fixed #14664 -- Logged a warning if MiddlewareNotUsed is raised in DEBUG mode.
2014-11-27 07:55:07 -05:00
4c123d0f79
Fixed #23899 -- Added 'Generated by Django X.Y' to startproject template.
2014-11-25 09:41:56 -05:00
1e9ac504e4
Fixed #23888 -- Fixed crash in File.__repr__() when name contains unicode.
2014-11-24 15:54:57 -05:00
ebb927c4c9
Removed workaround for lack of os.getpid() in Jython.
...
The Jython bug was fixed in http://bugs.jython.org/issue1518
(tested on Jython 2.7b3); also updated make_msgid() to be more like
the version in Python 3.2+; refs #23905 .
Thanks Simon Charette for testing and review.
2014-11-24 14:01:15 -05:00
a5bd7f2cb2
Fixed #13694 -- Made SafeMIMEText's constructor compatible with MIMEText.
2014-11-24 13:28:58 -05:00
bcb693ebd4
Revert "Fixed #23892 -- Made deconstructible classes forwards compatible"
...
This reverts commit f36151ed16
2014-11-22 22:29:23 -07:00
f36151ed16
Fixed #23892 -- Made deconstructible classes forwards compatible
2014-11-22 14:30:14 -07:00
b38637d581
Fixed #23887 -- Returned Bad Request for multipart parsing fails
...
Thanks Antti Häyrynen and Tim Graham for the report, and Aymeric
Augustin for the review.
2014-11-22 14:23:37 +01:00
54d3dcbc51
Removed reduce() usage in makemigrations; refs #23796 .
...
A lambda all_items_equal() replaced a reduce() that was broken for potential
3+-way merges. A reduce(operator.eq, ...) accumulates bools and can't
generically check equality of all items in a sequence:
>>> bool(reduce(operator.eq, [('migrations', '0001_initial')] * 3))
False
The code now counts the number of common ancestors to calculate slice offsets
for the branches. Each branch shares the same number of common ancestors.
The common_ancestor for loop statement had incomplete branch coverage.
2014-11-20 14:33:30 -05:00
cfa26f29bd
Reduced reduce() usage; refs #23796 .
...
django.core.exceptions.ValidationError.messages() and
django.db.backends.schema.BaseDatabaseSchemaEditor._alter_field():
Replaced reduce(operator.add, ...) w/uncoupled, explicit sum()
2014-11-20 14:31:14 -05:00
d63703f1cd
Fixed #18714 -- Added 'fuzzy' compilemessages option
2014-11-18 22:44:16 +01:00
d188101319
Fixed #23799 -- Made makemigrations respect --no-optimize.
...
Thanks to yamila-moreno for the idea of a skip message.
2014-11-18 07:37:06 +01:00
684b2077b3
Improved readability of negative condition in makemessages
...
Thanks Berker Peksag for the suggestion.
2014-11-17 13:42:14 +01:00
6a05f0dfe3
Simplified handle_extensions management utility
...
makemessages now doesn't need any special ignoring logic, after
commit bb4a92d784
2014-11-17 09:24:56 +01:00
bb4a92d784
Fixed #23840 -- Fixed makemessages find_files method
...
Changed the handling of extensions to be used for gettext. Now
obeying the --extension argument. find_files now only find the
given or default extensions and puts only these in the
TranslatableFiles. As a result there are no more confusing messages
for filetypes (extension) not handled by makemessages.
2014-11-17 09:21:24 +01:00
d2d6c0c097
Fixed #21363 -- Added datetime.timedelta support to TimestampSigner.unsign().
2014-11-15 19:36:33 +01:00
35dac5070b
Added a new GeoJSON serialization format for GeoDjango
...
Thanks Reinout van Rees for the review.
2014-11-15 18:07:18 +01:00
a305695f28
Merge pull request #3481 from manfre/ticket-16358
...
Fixed #16358 - Made memcache backend delete old value on a failure to set.
2014-11-13 22:10:22 -05:00
c24a2e6cbd
Fixed #23765 -- Removed BooleanField default check which often yielded false positives.
2014-11-13 20:12:29 +01:00
bc8abe36ba
Fixed #16358 - Made memcache backend delete old value on a failure to set.
...
Default Memcached configuration allows for a maximum object of 1MB and
will fail to set the key if it is too large. The key will be deleted from
memcached if it fails to be set. This is needed to avoid an issue with
cache_db session backend using the old value stored in memcached, instead
of the newer value stored in the database.
2014-11-13 00:46:03 -05:00
f742c653e0
Removed return from __init__.
...
__init__ isn't allowed to return anything other than None and it isn't
common practice to include a return statement.
2014-11-12 21:26:31 +01:00
3bc7a14ea5
Normalized opening a file and decoding its content.
...
`io.open` is required on Python 2.7. Just `open` would work on Python 3.
2014-11-11 22:54:27 +01:00
95b8323ac2
Removed import forgotten in previous commit.
2014-11-11 22:54:26 +01:00
5ec367ccdd
Fixed #23788 -- Used new JavaScript support in recent gettext
...
JavaScript string extraction support has been added in gettext
0.18.3.
Thanks Aymeric Augustin for the review.
2014-11-11 22:52:30 +01:00
b8ba73cd0c
Raised SuspiciousFileOperation in safe_join.
...
Added a test for the condition safe_join is designed to prevent.
Previously, a generic ValueError was raised. It was impossible to tell
an intentional exception raised to implement safe_join's contract from
an unintentional exception caused by incorrect inputs or unexpected
conditions. That resulted in bizarre exception catching patterns, which
this patch removes.
Since safe_join is a private API and since the change is unlikely to
create security issues for users who use it anyway -- at worst, an
uncaught SuspiciousFileOperation exception will bubble up -- it isn't
documented.
2014-11-11 19:05:14 +01:00
b7a5b6ab86
Fixed #23750 -- Allowed core.checks.register to be used as a function
2014-11-11 16:29:32 +01:00
a71a2ea756
Fixed typos using https://github.com/vlajos/misspell_fixer
2014-11-03 20:59:30 -05:00
934a16dc93
Fixed #23468 -- Added checks for duplicate fixtures directories in loaddata.
...
If settings.FIXTURE_DIRS contains duplicates or a default fixture
directory (app_name/fixtures), ImproperlyConfigured is raised.
Thanks to Berker Peksag and Tim Graham for review.
2014-10-31 18:21:54 -04:00
cc25bfebd5
Clarified BaseCommand --traceback behavior.
2014-10-30 14:15:31 -04:00
eb4f6de980
Fixed #8149 -- Made File.__iter__() support universal newlines.
...
The following are recognized as ending a line: the Unix end-of-line
convention '\n', the Windows convention '\r\n', and the old
Macintosh convention '\r'.
http://www.python.org/dev/peps/pep-0278
Thanks tchaumeny for review.
2014-10-30 11:52:59 -04:00
528c9af543
Fixed #23717 -- Fixed makemessages crash when STATIC_ROOT=None
2014-10-27 13:56:25 +01:00
dd1ea70779
Fixed #23699 -- Prevented flush from loading initial data for apps with migrations.
2014-10-27 06:56:44 -04:00
eb82fb0a9d
Refactored color_style() and no_style() to improve testability. Refs #23663 .
...
This includes the following improvements:
- The type of the style object is now called 'Style' rather than 'dummy'.
- The new make_style() function allows generating a Style object directly
from a config string. Before the only way to get a style object was
through the environ and it also required that the terminal supported
colors which isn't necessarily the case when testing.
- The output of no_style() is now cached with @lru_cache.
- The output of no_style() now has the same set of attributes as the
other Style objects. Previously it allowed anything to pass through
with __getattr__.
2014-10-22 11:27:00 +07:00
bdb4118b1a
Fixed #23686 -- Tweak color output of the system check framework.
...
Thanks Tim Graham for the review.
2014-10-22 11:27:00 +07:00
533532302a
Fixed #23663 -- Initialize output streams for BaseCommand in __init__().
...
This helps with testability of management commands.
Thanks to trac username daveoncode for the report and to
Tim Graham and Claude Paroz for the reviews.
2014-10-22 09:25:50 +07:00
8b4cc9df9c
Fixed #23583 -- More selectively ignored static/media roots
...
Fixed a regression introduced by 28efafa24c
2014-10-21 20:18:21 +02:00
c34e13e17c
Fixed #23107 -- Made runserver output respect --no-color.
...
This commit reverts 67d7da5fb9
2014-10-22 01:03:15 +07:00
4fe6824ffd
Fixed #23679 -- Fixed null introspection for char/text fields
...
Thanks Paul Dejean for the report.
2014-10-20 22:37:19 +02:00
b8f2c972d0
Removed redundant skip_checks option for call_command
2014-10-20 17:26:00 +02:00
6d11bb102d
Revert "Fixed #23650 -- Prevented migrate from calling checks 3 times"
...
This reverts commit 8d6e1afe0b
2014-10-20 17:26:00 +02:00
685edab9da
Fixed #23685 -- Made call_command skip checks by default
...
Thanks Loic Bistuer for the report/review and Tim Graham for the
review.
2014-10-20 17:26:00 +02:00
c974b7bbe0
Renamed skip_validation into skip_checks as the former is now deprecated.
2014-10-19 18:00:54 +07:00
ec8a2e3b07
Prevented syncdb from calling system checks multiple times. Refs #23650 .
2014-10-19 18:00:53 +07:00
8d6e1afe0b
Fixed #23650 -- Prevented migrate from calling checks 3 times
...
Thanks Ilya Baryshev for the report and Tim Graham for the review.
2014-10-17 20:20:56 +02:00
7ae03204ac
Fixed #23469 -- Removed test runner compatibility check which often yielded false positives.
2014-10-17 10:31:49 -04:00
a5c77417a6
Fixed #23615 -- Validate that a Model instance's "check" attribute is a method.
...
The "check" name is a reserved word used by Django's check framework,
and cannot be redefined as something else other than a method, or the check
framework will raise an error.
This change amends the django.core.checks.model_check.check_all_models()
function, so that it verifies that a model instance's attribute "check"
is actually a method. This new check is assigned the id "models.E020".
2014-10-16 23:49:21 +07:00
a6a8268d19
Fixed #23660 -- Moved sort_dependencies to core.
2014-10-16 03:04:13 +07:00
10b17a22be
Fixed #19508 -- Implemented uri_to_iri as per RFC.
...
Thanks Loic Bistuer for helping in shaping the patch and Claude Paroz
for the review.
2014-10-16 02:31:17 +07:00
59d487e7fc
Fixed #23638 -- Prevented crash while parsing invalid cookie content
...
Thanks Philip Gatt for the report and Tim Graham for the review.
2014-10-13 17:37:58 +02:00
8d789449c7
Fixed #23063 -- Convert \n and \r to \r\n when using the SMTP backend as per RFC.
2014-10-12 22:01:24 +02:00
6448dd8335
Fixed #23642 -- Made LocMemCache.incr() thread-safe as documented
2014-10-12 23:47:48 +07:00
1b5918f160
Fixed #23625 -- Removed CacheClass shim
2014-10-10 08:43:26 -04:00
16ed35fafc
Fixed #23612 -- Normalized fixuture paths to allow referencing relative paths on Windows.
2014-10-09 14:58:20 -04:00
c1ef234e31
Fixed #23522 -- Changed reverse() to return a Unicode string; not bytes
2014-10-07 13:06:39 -04:00
2f16ff5a6c
Fixed #23601 -- Ensured view exists in URLconf before importing it in admindocs.
2014-10-06 09:31:39 -04:00
b2aad7b836
Replaced set([foo, ...]) by {foo, ...} literals. Refs PR 3282.
...
Thanks Collin Anderson for the review.
2014-09-29 00:01:38 +07:00
e1fbb68e4e
Updated comment about Python issue
2014-09-27 22:48:30 +02:00
e077c29155
Fixed #23551 -- Fixed bash autocompletion crash on Python 3.
2014-09-25 07:44:22 -04:00
ed297061a6
Fixed #18782 -- Prevented sql_flush to flush views
...
Thanks rodolfo_3 for the report and the initial patch, and
Josh Smeaton, Shai Berger and Tim Graham for the reviews.
2014-09-23 20:13:31 +02:00
5472d18e31
Fixed #23461 -- Added EMAIL_TIMEOUT setting
2014-09-13 09:33:21 -04:00
52ef6a4726
Fixed #17101 -- Integrated django-secure and added check --deploy option
...
Thanks Carl Meyer for django-secure and for reviewing.
Thanks also to Zach Borboa, Erik Romijn, Collin Anderson, and
Jorge Carleitao for reviews.
2014-09-12 15:05:23 -04:00
00535e8e6b
Fixed #20743 -- Added support for keyfile/certfile in SMTP connections.
...
Thanks jwmayfield, serg.partizan, and Wojciech Banaś for work on the patch.
2014-09-10 11:14:20 -04:00
c53f2451a8
Fixed #23398 -- Added helpful error message when runserver is accessed via HTTPS
2014-09-09 12:29:30 -04:00
0e4d79c4f0
Fixed #22882 -- Fixed a UnicodeDecodeError in flush.
...
Thanks djbaldey for the report.
2014-09-06 10:07:34 -04:00
1101467ce0
Limited lines to 119 characters in django/
...
refs #23395 .
2014-09-05 09:22:16 -04:00
1435cfbe8d
Fixed #23302 -- Added --name/-n option to makemigrations command
2014-09-02 21:09:18 -04:00
eacf244506
Converted sql_queries into a lazily evaluated list.
...
Fixed #23364 . Thanks Markush2010 for the report.
2014-08-30 13:27:56 +02:00
eb2af16c59
Fixed #21483 -- Added WSGI environ to kwargs sent to request_started signal.
2014-08-29 10:12:03 -04:00
cf33777306
Clarified a comment in django.core.files.temp.
2014-08-29 07:27:15 -04:00
1e404180c1
Fixed #23379 -- Corrected a referencing issue in sql_create.
...
Thanks to Trac alias flakfizer for the report.
2014-08-28 15:17:50 -04:00
0396cd8f19
Fixed #23327 -- Added 'zero' syntax to migrate help message
2014-08-22 13:40:14 -04:00
0d8d30b7dd
Fixed #23157 -- Removed O(n) algorithm when uploading duplicate file names.
...
This is a security fix. Disclosure following shortly.
2014-08-20 14:39:40 -04:00
28e765810d
Prevented reverse() from generating URLs pointing to other hosts.
...
This is a security fix. Disclosure following shortly.
2014-08-20 14:39:40 -04:00
3e241313a4
Fixed #23136 -- Added a message when sqlclear does nothing
2014-08-18 13:20:29 -04:00
5853c87a45
Fixed #23303 -- Added BEGIN and COMMIT statements to the output of sqlmigrate.
2014-08-18 18:55:12 +02:00
152afadef1
Merge pull request #3075 from ramiro/makemessages-ignore-windows
...
Fixed #23298 -- Made makemessages actually ignore specified dirs on Wind...
2014-08-18 13:33:02 -03:00
e0a98e2374
Fixed #23309 -- Fixed call_command to parse args correctly
2014-08-18 17:54:24 +02:00
b4dce7c37a
Fixed #23298 -- Made makemessages actually ignore specified dirs on Windows.
...
This was detected by two failures in the i18n.test_extraction of our
test suite.
Refs #20422 , refs #22336
2014-08-15 16:19:04 -03:00
0bfb538661
Fixed #23291 -- Don't add Unicode varname/value to environment.
...
Windows doesn't like that and it causes 114 failures in the
admin_scripts tests with Python 2.x.
2014-08-14 12:22:21 -03:00
055d95fce0
Fixed #23265 -- Used system-specific encoding in runserver
...
Thanks SpaceFox for the report.
2014-08-14 12:08:06 +02:00
7f4be9cbc2
Fixed flake8 warning.
2014-08-13 12:33:18 -04:00
2cc8ffe258
Fixed #22985 -- Made call_command accept option name parameter
...
Thanks giulettamasina for the report and Tim Graham for the review.
2014-08-12 21:53:29 +02:00
dc462a8ed5
Removed unused migrate option
2014-08-09 17:13:00 +02:00
8fe406864c
Fixed #22336 -- Added path matching for makemessages ignore option
...
This fixes a regression introduced by 9012a9e200
2014-08-08 22:54:30 +02:00
2d542bf60c
Ensured that Paginator.page_range works the same on Python 2 and 3.
...
This somewhat fixes #23088 , refs 23140.
2014-08-03 21:10:00 +02:00
40fb6a5601
Revert "Fixed #23088 -- Used `six` `range` type in `Paginator.page_range`."
...
This reverts commit 6508db2ff9#23088 .
2014-08-03 21:08:24 +02:00
d47409831f
Fixed #23067 -- Updated docs to use django-admin
2014-07-30 14:14:03 -04:00
67d7da5fb9
Fixed #23107 -- Made runserver output respect --no-color.
2014-07-30 12:58:53 -04:00
096a5de5d2
Fixed #23092 : Squashing handles external dependencies
2014-07-29 10:22:00 -07:00
8ebd6d35d7
Fixed #23090 : Document and enforce not double-squashing migrations
2014-07-29 10:02:59 -07:00
2ab0ed7b28
Only warn about initial data if fixtures have been found.
2014-07-27 13:23:16 +02:00
5cdb8f8c1e
Fixed #16617 -- Added 'value' to BaseValidator params.
...
Also allowed overriding the default messages in subclasses of BaseValidator.
Thanks sperrygrove for initial patch.
2014-07-26 10:03:00 -04:00
f44dbf74a4
Mark initial_data as deprecated separately from syncdb. Refs #23077 .
2014-07-25 09:09:15 -07:00
6508db2ff9
Fixed #23088 -- Used `six` `range` type in `Paginator.page_range`.
2014-07-25 11:04:58 +03:00
70c54a3694
Fixed #23028 : Added unique_togther support to inspectdb.
2014-07-18 16:10:59 +00:00
28efafa24c
Ignored STATIC_ROOT and MEDIA_ROOT in makemessages
...
Also alleviate issues with weird file names typically found in
MEDIA_ROOT directories (#23010 ).
Thanks Tim Graham for the review.
2014-07-16 09:38:57 +02:00
f7a78f9bba
Fixed #22791 -- Invoke interactive questioner only for conflicts in specified apps.
...
Thanks bendavis78 for the report and Tim Graham for the review.
2014-07-14 11:00:49 -04:00
b48c2c5925
Removed extra newline.
2014-07-12 10:16:53 -04:00
ebb13bbd88
Fixed #22983 : Alert when squashing RunPython operations with referred functions.
2014-07-11 19:00:39 -07:00
e167e96cfe
Fixed #22223 -- Prevented over-escaping URLs in reverse()
...
And follow more closely the class of characters defined in the
RFC 3986.
Thanks Erik van Zijst for the report and the initial patch, and
Tim Graham for the review.
2014-07-09 09:54:34 +02:00
b144bfb5ce
Fixed #21079 -- Further normalized table names in inspectdb
...
Thanks Michael Manfre for the report and Tim Graham for the review.
2014-07-06 21:19:27 +02:00
67f9f385aa
Fixed various minor doc typos / references.
2014-07-05 20:26:26 -04:00
1f8bb95cc2
Corrected domain max length for EmailValidator; refs #20631 .
...
Thanks MarkusH for the report.
2014-07-04 20:50:28 -04:00
7fd55c3481
Fixed #20631 -- Increased the default EmailField max_length to 254.
...
Thanks pmartin for the report.
2014-07-04 14:15:00 -04:00
1966054feb
Fixed #22915 -- Document backward incompatible changes in the ValidationError constructor.
...
This patch also fixes update_error_dict to better handle the use case described
in this ticket, previously the type of the provided container could be lost in
some conditions.
Thanks Russell Keith-Magee for the report and Tim Graham for review.
2014-07-04 17:05:31 +07:00
4c39c270af
Add missing spaces to implicitly joined strings
2014-06-29 22:56:21 +01:00
dbbcfca476
Fixed #21668 -- Return detailed error page when SuspiciousOperation is raised and DEBUG=True
...
Thanks GDorn and gox21 for report.
Thanks Tim Graham for idea and review.
2014-06-24 08:55:36 -04:00
0fba4c0ed7
Fixed #22487 : Don't flush out data from before normal TestCases
2014-06-23 20:25:09 -07:00
7f76251fb7
Refactored common code in handlers/base.py and urlresolvers.py
2014-06-23 15:27:25 -04:00
9618d68b34
Fixed #8033 -- Explained app registry error during translation setup
...
Thanks Tim Graham and Aymeric Augustin for the review.
2014-06-23 09:31:45 +02:00
ecc06d44ed
Clean up syncdb parts of migrate output if no synced apps
2014-06-22 13:03:25 -07:00
fbb684d95e
Fixed #22862 -- Added --noinput option to makemigrations.
...
Thanks artortenburger for the report.
2014-06-20 08:55:02 -04:00
b67e9ed8c9
Swapped placeholders in [sql]migrate command error
2014-06-20 13:53:17 +02:00
9f4852f649
Fixed #22863 : Improve clarity of makemigrations for non-db params
2014-06-19 23:41:32 -07:00
9996158db4
Fixed #22835 -- Deprecated NoArgsCommand.
2014-06-19 08:54:59 -04:00
4529af9ecf
Fixed #22845 -- Correctly handled memcached default timeout value.
2014-06-16 16:34:00 -04:00
2b79be2bee
Fixed #22848 : Ignore no-migrations errors during makemigrations only
2014-06-16 09:58:35 -07:00
c24e979ece
Fixed #7762 -- Hidden full script name in command error output
2014-06-14 20:01:02 +02:00
5949c2118d
Restored command error behavior when called from command line
...
Refs #19973 .
2014-06-14 18:53:33 +02:00
2ca5fc55b0
Fixed several flake8 errors
2014-06-14 10:20:42 -04:00
f17b24e407
Converted remaining management commands to argparse
2014-06-14 13:43:44 +02:00
4b4524291a
Converted test management command to argparse
...
Keeping backwards compatibility with test_runner.option_list is
tricky and would imply transforming an optparse.Option to an
argparse.Action. I choose to introduce a backwards incompatible
change because it only affects testing, not runtime behavior.
2014-06-14 13:43:39 +02:00
8568638603
Fixed #19973 -- Replaced optparse by argparse in management commands
...
Thanks Tim Graham for the review.
2014-06-14 11:17:48 +02:00
4696cd9671
Fixed #22477 -- Removed contrib middleware from the global settings defaults.
...
Also added a compatibility check for changed middleware defaults.
Forwardport of d94de802d3
2014-06-13 12:45:56 -04:00
6e8d614acd
Made the vendored NamedTemporaryFile work as a context manager. Refs #22680 .
...
This fixes a regression on Windows introduced by b7de5f5
2014-06-12 08:07:34 +07:00
e2efc8965e
Fixed #22680 -- I/O operation on closed file.
...
This patch is two-fold; first it ensure that Django does close everything in
request.FILES at the end of the request and secondly the storage system should
no longer close any files during save, it's up to the caller to handle that --
or let Django close the files at the end of the request.
2014-06-11 08:57:30 +02:00
93d05536fd
Fixed #22770 -- Removed create_superuser from post_migrate signals.
...
Moved logic to syncdb command for backwards compatibility.
2014-06-10 14:37:37 -04:00
8c12d51ea2
Fixed #22487 : Optional rollback emulation for migrated apps
2014-06-08 19:30:15 -07:00
3f91238adf
Fixed #22777 : Add dependency on through for autodetected M2M adds
2014-06-08 17:12:59 -07:00
f70f669941
Fixed #22749 : Making SQL management commands migration aware.
2014-06-07 17:18:30 -07:00
47a9347b98
Fixed #6992 -- Improved error when middleware omits HttpResponse.
...
Thanks guettli for the report.
2014-06-07 19:48:45 +02:00
11284a63d4
Fixed #18314 -- Corrected request.build_absolute_uri() handling of paths starting with //
...
``HttpRequest.build_absolute_uri()`` now correctly handles paths starting with ``//``.
``WSGIRequest`` now doesn't remove all the leading slashes either,
because ``http://test/server `` and http://test//server `` aren't the same thing
(RFC2396).
Thanks to SmileyChris for the initial patch.
2014-06-07 08:59:02 -04:00
4f72e5f03a
Fixed #21773 -- made daemon threads default in the development server.
...
Thanks clime for the report.
2014-06-05 12:26:24 -04:00
fb9d8f0652
Fixed #22717 -- Auto-corrected missing ending slash in FileSystemStorage
...
Thanks David Fischer for the report and Moayad Mardini for the
review.
2014-06-04 08:53:17 +02:00
4445d36d47
Fixed #22384 -- Deprecated reversing URLs by dotted path.
2014-06-03 07:30:14 -04:00
83e7555ffe
Revert "Making SQL management commands migration aware."
...
This reverts commit cb9c9a7b58
2014-06-01 12:00:09 +02:00
67d9f70e4c
Fix test failure caused by 3149cdce32
2014-05-29 15:34:35 -07:00
cb9c9a7b58
Making SQL management commands migration aware.
2014-05-29 23:03:10 +02:00
1dcc603eff
Fixed several typos in Django
2014-05-28 17:39:14 -07:00
d0f7c7f59a
Argument to `reversed` must be a sequence on Py3.
2014-05-27 18:28:13 -04:00
fed2877cf1
Fix a regression introduced by f011b90363.
...
`django.get_version` was actually used by the module.
2014-05-27 18:23:44 -04:00
f011b90363
Removed an old compatibility shim added in 1.0
2014-05-27 22:28:49 +02:00
fe53bc524b
Fixed #21630 -- Simplified management command discovery
...
Thanks Aymeric Augustin for the report end the review.
2014-05-27 22:18:51 +02:00
4865326f22
Fixed #22699 -- Configure default settings in some management commands.
...
This makes it possible to run django.setup() in management commands that
don't need a settings module. In addition it simplifies error handling.
Thanks Claude for the review.
2014-05-27 21:43:52 +02:00
2e613ea5c5
Fixed #22675 -- makemigrations --dry-run to output migrations to stdout.
...
`makemigrations --dry-run` will output the complete migrations file
that would be written if it's used along with `--verbosity 3`.
2014-05-27 00:40:55 +03:00
9d1bf8f841
Removed executeable bit from a few files.
2014-05-25 23:16:40 +02:00
b7de5f5d3f
Fixed a few ResourceWarning in the test suite. Refs #22680 .
2014-05-26 03:23:17 +07:00
63fc91b3ca
Fixed #22676 -- makemigrations --dry-run should not ask for defaults
...
Made the fix in InteractiveMigrationQuestioner class code, rather than
MigrationAutodetector, because --dry-run shouldn't affect whether
MigrationAutodetector will detect non-nullable fields, but the
questioner should skip the question and returns a None for default
(since that won't be used anyway) if --dry-run is used.
2014-05-24 09:56:18 -04:00
dbb48d2bb9
Applied unicode_literals to makemessages command
...
This also fixes #22686 as some sort of side-effect.
2014-05-24 11:51:57 +02:00
46082339d2
the SECRET_KEY is not a hash
2014-05-22 11:19:54 +01:00
fce6a29428
Merge pull request #2498 from ramiro/move-serverhandler
...
Moved ServerHandler helper class to tests.
2014-05-21 18:59:01 -03:00
7999ed9b69
Updated Django makemessages process
...
makemessages should now automatically distribute translatable
strings in the proper locale files, for Django too
(see 50a8ab7cd1
2014-05-19 09:30:26 +02:00
c7a4ae94a0
Removed some unnecessary exception naming; thanks claudep.
2014-05-18 17:42:03 -04:00
ec9043ab2f
Fixed #21799 - Modified loaddata --ignorenonexistent to ignore models.
2014-05-18 15:52:07 -04:00
424fe76349
Fixed #22579 -- Corrected validation for email to reject trailing slash
...
Thanks to Claude Paroz for the report and patch and Tomasz
Paczkowski for the review.
2014-05-16 15:13:11 +02:00
f5d4b45df1
Fixed #21634 -- Prevented hiding ImproperlyConfigured when command not found
...
Thanks nikolay.v.golub@gmail.com for the report.
2014-05-16 12:08:31 +02:00
e520a73eee
Harmonized some PEP 0263 coding preambles
2014-05-15 19:58:41 +02:00
3800f63721
Dropped fix_IE_for_vary/attach.
...
This is a security fix. Disclosure following shortly.
2014-05-14 10:19:48 +02:00
a9b7f31bfc
Completed long overdue sqlinitialdata deprecation.
2014-05-11 23:15:59 -03:00
a75324c654
Fixed #14226 -- Dependency calculation for complex M2M relations.
...
`sort_dependencies` incorrectly interpreted 'complex' M2M relations
(with explicit through models) as dependencies for a model. This caused
circular complex M2M relations to be unserializable by dumpdata.
Thanks to aneil for the report and outofculture for initial tests.
2014-05-11 19:50:01 -03:00
66880e4cd1
Fixed #22606 -- Locmemcache has_key() failed for infinite cache expiry
...
Refactored cache expiry logic for Locmemcache to make consistent across
all places where accessed, and correctly handle None as expiry time.
2014-05-09 18:35:07 +02:00
7fe60ae64a
Fixed #22588 -- Fix RegexValidator __eq__
...
Compare parameters instead of re.pattern instances, and add the other
parameters to the comparison. Also add a __ne__ to make assertNotEqual
work properly.
2014-05-08 19:51:15 -07:00
fc32e9c0d9
Removed unused imports in makemigrations
2014-05-08 19:39:43 +02:00
f9d7e18dc5
Fixed #22576 : Ensure makemigrations doesn't touch the database.
2014-05-06 22:41:59 -07:00
6944418277
Fixed #22337 : FileSystemStorage marked as deconstructible and tested.
2014-05-06 22:23:23 -07:00
d1799233f4
Fixed clash caused by the newly introduced -e shorthand for makemessages --exclude.
...
This fixes a regression caused by 0707b82#22328 .
2014-05-02 23:07:17 +07:00
e049c88603
Cleanup failing test w/contenttypes and remove useless graph load
2014-04-30 15:11:52 -07:00
8f6dff372b
Fixed #22485 : Include all unmigrated apps in project state by default.
2014-04-30 12:25:12 -07:00
d9c272b22f
Removed unused import.
2014-04-30 07:23:39 -04:00
83413c53d2
Fixed #22511 -- Added args to migrations management commands.
2014-04-30 07:15:03 -04:00
2df7238512
Removed bogus, ineffective 'U' flag from codecs.open() call.
2014-04-29 07:46:54 -03:00
8b5b199e20
Fixed #3214 -- Stopped parsing SQL with regex.
...
Avoided introducing a new regex-based SQL splitter in the migrations
framework, before we're bound by backwards compatibility.
Adapted this change to the legacy "initial SQL data" feature, even
though it's already deprecated, in order to facilitate the transition
to migrations.
sqlparse becomes mandatory for RunSQL on some databases (all but
PostgreSQL). There's no API to provide a single statement and tell
Django not to attempt splitting. Since we have a more robust splitting
implementation, that seems like a good tradeoff. It's easier to add a
new keyword argument later if necessary than to remove one.
Many people contributed to both tickets, thank you all, and especially
Claude for the review.
Refs #22401 .
2014-04-26 17:46:23 +02:00
0707b824fe
Fixed #22328 -- Added --exclude option to compilemessages and makemessages.
2014-04-26 17:07:44 +07:00
91afc00513
Fixed #21157 -- Fixed problems with ResolverMatch
...
- Fixed bug in get_callable() that caused resolve() to put a string
in ResolverMatch.func.
- Made ResolverMatch.url_name match the actual url name (or None).
- Updated tests that used the string value in ResolverMatch.func, and
added regression tests for this bug.
- Corrected test urls whose dummy view paths caused failures (behavior
that was previously masked by this bug).
2014-04-23 20:12:34 -04:00
3a435a057c
Set compile messages options as class variable
...
Refs #18714 . Same logic as options for makemessages commands.
2014-04-23 15:15:03 +02:00
af5f688392
Fixed #22495 -- Locmem cache.add() failed with infinite timeouts
...
cache.add() incorrectly succeeded when there was an existing key
with an infinite (None) timeout.
2014-04-23 14:49:46 +02:00
3c06b2f2a3
Fixed #22486 -- Restored the ability to reverse views created using functools.partial.
...
Regression in 8b93b31487
2014-04-23 07:27:52 -04:00
8b93b31487
Fixed a remote code execution vulnerabilty in URL reversing.
...
Thanks Benjamin Bach for the report and initial patch.
This is a security fix; disclosure to follow shortly.
2014-04-21 18:11:26 -04:00
405b13fe83
Fixed migrate when called inside a transaction.
...
This is useful for tests manually calling migrate inside a testcase,
for normal usage this should make no difference, since there is no
surrounding transaction after all. If there is one we still try to
leave the transaction in a useable state (for postgres at least).
If this commit turns out to be causing issues, settings savepoint=False
is probably the right fix :)
2014-04-21 15:37:12 +02:00
428c0bbe1b
Appeased flake8 2.1.0.
2014-04-21 12:27:34 +02:00
275811a93c
Adapted fixture read mode to file type
...
Binary mode added in ed532a6a1e#22399 .
2014-04-18 18:54:46 +02:00
ed532a6a1e
Fixed #22399 -- Forced fixture reading in binary mode
...
This might help on systems where default encoding is not UTF-8 (and
on Python 3).
Thanks bacilla for the report.
2014-04-18 17:55:35 +02:00
214d1e1b0f
Fixed #22454 - Changed compatibility warning hint
...
The warning hint of `_check_test_runner` of 1.6 compatibility had a link
to a general release note. The link should be edited to refer the
relevant "Backwards incompatible changes in 1.6" section that documents
the cause and the possible solutions and workarounds of the warning.
2014-04-17 20:41:25 -04:00
47927eb786
Revert "Fixed #22401 -- Deprecated regular expression parsing of initial SQL in favor of installing sqlparse."
...
This reverts commit 071c933775
2014-04-16 21:03:22 -04:00
395d75ea6b
Fixed #22194 -- Added --list-tags option to check command.
...
Thanks Elvard for the patch.
2014-04-10 09:43:55 -04:00
b513fa5fc6
Fixed #22195 -- Used constants to define built-in tags for check framework.
...
Thanks Elvard for the patch.
2014-04-10 08:45:48 -04:00
071c933775
Fixed #22401 -- Deprecated regular expression parsing of initial SQL in favor of installing sqlparse.
2014-04-09 19:25:07 -04:00
4aa80149e7
Fixed #22327 -- Turned BaseEmailBackend into a context manager
...
Changed the BaseEmailBackend to allow usage as context manager to open
and close connections.
2014-03-31 14:08:51 -04:00
9a982d5ccc
Moved ServerHandler helper class to tests.
...
It has been only used in the builtin_servers tests since Django 1.4.
2014-03-30 20:55:40 -03:00
778ce245dd
Corrected many style guide violations that the newest version of flake8 catches
2014-03-30 12:11:05 -07:00
3cdb0baa45
Fixed #22335 -- Fixed popen_wrapper error on non-English Windows systems.
2014-03-26 00:42:19 +01:00
9b7ba8af1b
Fixed #22322 -- Fixed incorrect explanation of what managed=False does.
...
refs #14305 .
Thanks Adrian Klaver for the report.
2014-03-25 14:01:37 -04:00
e3c4205b79
flake8 and doc fixes for refs #22257 .
2014-03-25 09:44:59 -04:00
f34e8fc890
Fixed #22257 -- Added file output option to dumpdata command.
2014-03-25 13:47:03 +05:30
96fc3908ad
Fixed a failing test introduced in 918a16bc4c.
...
Refs #22307 .
2014-03-22 18:05:56 +01:00
acee46fc95
Fixed #22256 -- Replaced bad fallback for missing PATH
...
Thanks Baptiste Mispelon for the review.
2014-03-22 16:52:05 +01:00
6877a9d415
Avoided transactional truncates on amateur databases.
...
Fixed a test failure that appeared after 753a22a6#22308 .
2014-03-22 14:39:27 +01:00
0757e0f30d
Avoided transactional DDL on castrated databases.
...
Fixed a test failure that appeared after 753a22a6#22308 .
2014-03-22 11:05:14 +01:00
918a16bc4c
Fixed #22307 -- Fixed SpooledTemporaryFile bug in File class.
...
Added condition to prevent checking the existence of a file name of a
file like object when the name attribute is None. This is necessary
because a SpooledTemporaryFile won't exist on the file system or have a
name until it has reached its max_size. Also added tests.
2014-03-21 22:34:47 +01:00
753a22a635
Fixed transaction handling in two management commands.
...
Previously, when createcachetable and flush operated on non-default
databases, they weren't atomic.
2014-03-21 21:29:51 +01:00
0f9560855e
Removed legacy transaction management per the deprecation timeline.
2014-03-21 21:06:50 +01:00
4965a77407
Removed PIL compatability layer per deprecation timeline.
...
refs #19934 .
2014-03-21 10:54:53 -04:00
4d0c5f6142
Fixed #22255 -- Added support for specifying re flags in RegexValidator
2014-03-21 11:12:36 +01:00
61fdb8d487
Fixed regression in file locking on some platforms.
...
Some platforms with os.name == 'posix' do not have the
fcntl module, e.g. AppEngine.
refs #19373 .
2014-03-18 10:35:22 -04:00
fc167c9b5e
Mentioned that ``dumpdata --natural`` is deprecated.
2014-03-18 07:25:37 -04:00
28779abb75
Fix bad conflict detection during makemigrations
2014-03-08 13:53:20 -08:00
210d0489c5
Fixed #21188 -- Introduced subclasses for to-be-removed-in-django-XX warnings
...
Thanks Anssi Kääriäinen for the idea and Simon Charette for the
review.
2014-03-08 09:57:40 +01:00
06efeae598
Added --previous flag to msgmerge command used by makemessages
...
Also took the opportunity to slightly refactor gettext options
so as to ease customization by subclassing the command.
Thanks Michal Čihař for the report and initial patch.
2014-03-06 10:20:01 +01:00
5d568bcfa6
Fixed #7571 -- Fixed parameter matching in include()'d urlpattern
...
Fixed URL resolving in the case where an outer regex includes an inner
regex and both regexes use positional parameters instead of named
groups, causing the outer regex's parameters to override the inner
regex's.
Modified the regex url resolver so that it will concatenates and then
normalizes, instead of normalizing and then concatenating.
2014-03-05 00:35:03 +01:00
6fe22b30e0
Fixed #22085 -- Added a feature for setting non-expiring keys as the default.
...
This feature allows the default `TIMEOUT` Cache argument to be set to `None`,
so that cache instances can set a non-expiring key as the default,
instead of using the default value of 5 minutes.
Previously, this was possible only by passing `None` as an argument to
the set() method of objects of type `BaseCache` (and subtypes).
2014-03-04 21:16:35 +01:00
0d91225892
Fixed many typos in comments and docstrings.
...
Thanks Piotr Kasprzyk for help with the patch.
2014-03-03 07:38:09 -05:00
6b63742ce5
Corrected expected test output to allow for cleanups in signal and compatibility checks.
2014-03-03 19:29:50 +08:00
c41335fa27
Added backwards compatibliity checks to reference documentation.
2014-03-03 19:20:48 +08:00
21d8175242
Fixed #22193 -- Made hint a truly optional arugment on check messages.
...
Thanks to Thomas Güttler for the suggestion.
2014-03-03 19:16:19 +08:00
82ac389486
Edited model and field checks for grammar and consistency.
2014-03-03 18:18:39 +08:00
98f13762d7
Fixed #22123 -- EmailValidator now also accepts IPv6 literals in addresses
2014-02-22 17:45:33 +01:00
173aa51997
Fixed #21435 -- Improved error message when urlconf is empty.
...
The new error message now hints that the most likely issue
is a circular import.
Thanks to trac user elena for the report and to
bpeschier for the original patch.
2014-02-22 15:36:49 +01:00
3841feee86
Fixed #22107 -- Fixed django.core.files.File object iteration.
...
Due to a mixup between text and bytes, iteration over
a File instance was broken under Python 3.
Thanks to trac user pdewacht for the report and patch.
2014-02-20 19:13:25 +01:00
d3e33fff12
Made content_type_extra optional for TemporaryUploadedFile and MemoryUploadedFile.
...
This provides better backwards compatibility for those constructing these
objects manually.
Refs #13721 .
2014-02-18 07:49:42 -05:00
621c5cf4a5
Fixed #21732 -- Made compilemessages complain about non-writable location
...
Instead of crashing with a CommandError, now a non-writable location
of mo files will only make compilemessages complain and continue.
Thanks Ramiro Morales for the review.
2014-02-18 13:38:06 +01:00
2a9ee49f3c
Removed BaseCommand.stdin introduced in 116d39842d.
...
This option is not actually very useful in the general case
because it doesn't override sys.stdin.
It's still marginally useful for testing some features of
the createsuperuser command so it was moved there.
This commit also makes the detection of a TTY in createsuperuser
a bit more robust, after a suggestion of appolo13.
2014-02-18 11:36:06 +01:00
116d39842d
Added the possibility to pass a stdin object to a management command.
...
This makes testing certain features easier.
Thanks to AeroNotix for the original patch.
2014-02-17 04:58:31 +01:00
a8ba76c2d3
Fixed #19980 : Signer broken for binary keys (with non-ASCII chars).
...
With this pull request, request #878 should considered closed.
Thanks to nvie for the patch.
2014-02-16 16:50:50 +01:00
cd7f37b647
Corrected a pair of flake8 violations
2014-02-15 10:42:12 -08:00
0b6f9f7c6f
Improved fix for #18373 -- backward compatibility
...
Commit 79558c78
2014-02-15 17:51:18 +01:00
65b421c661
Fixed some flake8 errors from recent commits.
2014-02-15 11:21:15 -05:00
1150053b99
Fixed #21912 -- Improved error message if a view returns None.
...
Thanks brycenesbitt for the report.
2014-02-15 11:18:16 -05:00
79558c787e
Fixed #18373 - improved handling of Resolver404s from views
...
When django.core.urlresolvers.resolve was called from a view, failed
and the exception was propagated and rendered by technical_404_response,
the URL mentioned on the page was the current URL instead of the URL
passed to resolve().
Fixed by using the path attribute from the Resolver404 exception instead
of request.path_info. Also cleaned up the exceptions to use standard
named parameters instead of stuffing a dict in args[0]
2014-02-15 15:56:04 +01:00
4d4e0ea461
Fixed two typos.
2014-02-15 15:16:16 +01:00
8251438cb8
Moved relative URL handling added in refs #21177 to a better place.
...
Thanks apollo13: "reverse() shouldn't know about absolute/relative paths."
2014-02-15 07:54:35 -05:00
e3d0790bd0
Fixed #21177 -- Made resolve_url support relative URLs.
...
This fixes redirecting to relative URLs with django.shortcuts.redirect.
2014-02-14 17:58:03 -05:00
f0f1ba75b0
Fixed #21856 : Don't crash runserver when DATABASES = {}
2014-02-12 19:09:43 +00:00
7e941ba67c
Reverting unapplied migrations check away from being a system-level check.
...
This reverts commit 0ac13ecceb
2014-02-12 18:55:20 +00:00
b333de0f5d
Add --empty option to makemigrations
2014-02-12 17:16:40 +00:00
73f51e4113
Fixed #22025 -- Listing app followed by app.Model in dumpdata command
...
When invoked as follows:
$ python manage.py dumpdata blogapp blogapp.Tag
Django would throw a TypeError. This commit fixes the problem and provides
a test.
2014-02-12 15:34:26 +01:00
b102c27ff4
Fixed #20784 -- Added inverse_match parameter to RegexValidator.
2014-02-10 05:38:43 -05:00
e2f28572b7
Merge pull request #2245 from funkybob/parse_header
...
Replaced _parse_content_type with cgi.parse_header
2014-02-09 20:39:07 +01:00
d5df7a0515
Fixed #21969 : Fix behaviour of initial_data with migrated apps
2014-02-09 12:22:59 +00:00
2085f53f56
Fixed #21968 : Bad detection of old-style apps to add initial migration
2014-02-09 11:42:10 +00:00
38b4adc696
Merge pull request #2244 from mlavin/21856-migration-checks
...
Fixed #21856 : Allow Empty DATABASES Setting
2014-02-09 10:46:57 +00:00
f43e895b15
Replace _parse_content_type with cgi.parse_header
2014-02-09 10:01:16 +11:00
6fe26bd3ee
Fixed #19373 -- Ported Windows file locking from PyWin32 to ctypes
...
There wasn't any file locking under Windows unless PyWin32 was
installed. This removes that (undocumented) dependency by using ctypes
instead.
Thanks to Anatoly Techtonik for writing the ctypes port upon which this
is based.
2014-02-08 15:52:06 -05:00
5d263dee30
Fixed #21674 -- Deprecated the import_by_path() function in favor of import_string().
...
Thanks Aymeric Augustin for the suggestion and review.
2014-02-08 11:12:19 -05:00
0ac13ecceb
Remove check_migrations from the runserver command and use the new checks framework to check for unapplied migrations. Don't check for migrations if the DATABASES setting is empty.
2014-02-08 09:01:59 -05:00
3ffeb93186
Ensure cursors are closed when no longer needed.
...
This commit touchs various parts of the code base and test framework. Any
found usage of opening a cursor for the sake of initializing a connection
has been replaced with 'ensure_connection()'.
2014-02-02 12:47:21 -05:00
2b6914049a
Fixed #21849 -- Included the count of silenced system checks in output.
2014-01-28 08:31:02 -05:00
8f2f48ecc9
Fixed #21866 -- Replaced "COMMIT" in managmement command SQL with backend hook.
2014-01-26 12:42:41 -05:00
f901b4d6c8
Took advantage of the new get_model API. Refs #21702 .
2014-01-26 13:08:05 +01:00
ee4b806a85
Fixed #21873 -- Removed duplicate import.
...
Thanks Sephi for the report.
2014-01-25 23:22:03 +01:00
2ff93e027c
Fixed #21829 -- Added default AppConfigs.
...
Thanks Russell for the report, Marc for the initial patch, Carl for the
final review, and everyone who contributed to the design discussion.
2014-01-25 10:41:56 +01:00
8649833cf8
fixed typo on docstring
2014-01-20 16:33:11 +00:00
d818e0c9b2
Fixed #16905 -- Added extensible checks (nee validation) framework
...
This is the result of Christopher Medrela's 2013 Summer of Code project.
Thanks also to Preston Holmes, Tim Graham, Anssi Kääriäinen, Florian
Apolloner, and Alex Gaynor for review notes along the way.
Also: Fixes #8579 , fixes #3055 , fixes #19844 .
2014-01-20 10:45:21 +08:00
a68f325791
Fixed #21638 : Validators are now comparable, stops infinite user mig'ns
2014-01-19 18:56:16 +00:00
298a2b577f
Adjusted inspectdb management command to yield PEP 8-compliant output barring Django Coding Style exceptions.
2014-01-17 18:03:16 -05:00
ac8d0a4815
Remove unneded open(.., 'U') when on python 3.
...
Universal newlines is enabled by default on py3, and the usage of 'U' is
deprecated in py3.4.
2014-01-13 17:11:21 +00:00
9d2c5b0420
Undelete the `return True` removed in 4e0a2fe.
...
This is quite important otherwise we don't close our connections to the
SMTP server.
2014-01-12 23:38:28 +00:00
0a7588dd3f
Fixed #21770 -- Updated autocomplete for app-loading.
...
Thanks dfunckt for the report.
2014-01-12 22:29:27 +01:00
d562527a16
Fixed #21477 -- Renamed db to using in pre/post_migrate signals.
2014-01-12 22:24:33 +01:00
2dcde523ab
Avoided catching ImproperlyConfigured on django.setup().
...
Fixed #21737 . Thanks Florian for the report.
Also removed redundant imports in that file.
2014-01-06 23:01:29 +01:00
aaf5b3e7aa
Moved django.setup() to ManagementUtility
...
In get_commands, setup() might already have been called, for example
when the management command is called through call_command. Moving
setup() to ManagementUtility so as it is only called when the command
is run from command line.
2014-01-02 20:47:40 +01:00
30a42a4fc3
Adjusted previous commit for Python 3.
2014-01-01 19:12:46 +01:00
0ce945a671
Fixed #21018 -- Reversed precedence order for management commands.
2014-01-01 18:11:15 +01:00
f17d00278e
Wiped get_commands() cache when INSTALLED_APPS changes.
...
Refs #21018 , #21688 .
2014-01-01 18:11:09 +01:00
a95f74e707
Oops.
2013-12-31 13:16:51 +01:00
6b172a6d6d
Called django.setup() explicitly in management commands.
...
This avoids duplicating code.
2013-12-31 13:11:05 +01:00
bfcc686d22
Removed the only_with_models_module argument of get_model[s].
...
Now that the refactorings are complete, it isn't particularly useful any
more, nor very well named. Let's keep the API as simple as possible.
Fixed #21689 .
2013-12-30 23:59:34 +01:00
df075c7489
Merge pull request #2126 from apollo13/email_bytes
...
Many thanks to @bitdancer and @aaugustin for answering my stupid questions about (mail)encodings and pointing me in the right direction.
2013-12-30 14:58:49 -08:00
bfe9052831
Decode mails using the message encoding.
2013-12-30 23:54:12 +01:00
c988745cca
Changed console and filebackend to use msg.as_bytes to output the data as it would get send via smtp.
2013-12-30 23:46:05 +01:00
1c242a297b
Merged Apps.populate_apps() and populate_models().
...
After the recent series of refactorings, there's no reason to keep
two distinct methods.
Refs #21681 .
2013-12-30 23:18:22 +01:00
80d74097b4
Stopped populating the app registry as a side effect.
...
Since it triggers imports, it shouldn't be done lightly.
This commit adds a public API for doing it explicitly, django.setup(),
and does it automatically when using manage.py and wsgi.py.
2013-12-30 22:11:17 +01:00
0d2c8ff2be
Populated the app registry earlier at startup.
...
Refs #1796 , #21676 .
2013-12-30 22:11:16 +01:00
5892a83b18
Stopped calling get_models() for a side effect.
2013-12-29 21:48:58 +01:00
e5bcd1d455
Changed get_validation_errors to use an app config.
2013-12-29 21:48:58 +01:00
856aaaf2b1
Changed get_migratable_models to use an app config.
2013-12-29 21:25:28 +01:00
1d4bcb86ea
Changed sql_* to use an app config instead of a models module.
2013-12-29 21:25:28 +01:00
368d90e261
Removed unused import.
2013-12-29 20:45:34 +01:00
7b88a96553
Added AppConfig.get_models().
2013-12-29 20:31:59 +01:00
00110904ac
Refactored the migration signals to use app configs.
...
De-aliased pre/post_syncdb to pre/post_migrate to increase
backwards-compatibility.
2013-12-29 17:53:42 +01:00
6d66ba5948
Fixed #21242 -- Allowed more IANA schemes in URLValidator
...
Thanks Sascha Peilicke for the report and initial patch, and
Tim Graham for the review.
2013-12-28 21:25:32 +01:00
ba7206cd81
Changed get_model to raise an exception on errors.
...
Returning None on errors required unpythonic error checking and was
inconsistent with get_app_config.
get_model was a private API until the previous commit, but given that it
was certainly used in third party software, the change is explained in
the release notes.
Applied the same change to get_registered_model, which is a new private
API introduced during the recent refactoring.
2013-12-28 20:53:00 +01:00
5dfd824d38
Introduced as_bytes for SafeMIMEText (and other SafeMIME-classes).
...
This is to provide a consistent interface (namely bytes) for the smtp
backend which after all sends bytes over the wire; encoding with as_string
yields different results since mails as unicode are not really specified.
as_string stays for backwardscompatibilty mostly and some debug outputs.
But keep in mind that the output doesn't match as_bytes!
2013-12-28 18:35:17 +01:00
280c1a65cc
Worked around a bug in python 3.3.3. Refs #21093
2013-12-28 15:25:16 +01:00
f28ea02308
Fixed #21093 -- Ensured that mails are not base64 encoded on python 3.3.3+.
...
Thanks to Arfrever for the report and Aymeric for the review.
2013-12-28 12:42:33 +01:00
c81fae6b95
Used app_label instead of appname.
...
The last component of the dotted path to the application module is
consistently referenced as the application "label". For instance it's
AppConfig.label. appname could be confused with AppConfig.name, which is
the full dotted path.
2013-12-28 09:53:02 +01:00
a7add2f296
Migrated built-in AppCommands to use handle_app_config.
2013-12-28 09:43:06 +01:00
bb8ec71f61
Updated the AppCommand API to support apps without a models module.
2013-12-28 09:42:59 +01:00
efddae252c
Refactored dumpdata with app configs instead of models modules.
2013-12-27 21:25:35 +01:00
ce1bc2c94b
Made the AppConfig API marginally more consistent.
...
Eliminated the app_ prefix that was more confusing than useful.
2013-12-26 19:25:09 +01:00
08bb238eae
Merge pull request #2105 from funkybob/cleanup_get_post
...
Used @cached_property for request.GET and COOKIES
2013-12-25 12:34:06 -08:00
1716b7ce5a
Renamed AppCache to Apps.
...
Also renamed app_cache to apps and "app cache" to "app registry".
Deprecated AppCache.app_cache_ready() in favor of Apps.ready().
2013-12-24 12:25:17 +01:00
d7a4b156d9
Use cached_property for request.GET and request.COOKIES
2013-12-24 21:57:57 +11:00
2fef9e5375
Moved apps back in the toplevel django namespace.
...
Reverted 4a56a93cc4
2013-12-22 11:39:55 +01:00
99bd39ef6e
Added the ability to supply custom app configs.
2013-12-22 11:39:18 +01:00
16aae35ca8
Improved set_available_apps() in several ways.
...
- Tested consistency the current app_configs instead of INSTALLED_APPS.
- Considered applications added with _with_app as available.
- Added docstrings.
2013-12-22 11:39:18 +01:00
9cdf1f6d54
Stop testing for inclusion in INSTALLED_APPS.
...
Removed some exception masking in the comments app that was harmful and
couldn't be preserved easily.
2013-12-22 11:39:18 +01:00
70c9654d45
Renamed registered_model to has_model.
...
This avoids possible confusion with register_model.
Thanks Marc Tamlyn for the suggestion.
2013-12-22 11:39:18 +01:00
65cd74be8e
Stopped iterating on INSTALLED_APPS.
...
Used the app cache's get_app_configs() method instead.
2013-12-22 11:39:18 +01:00
d4733b6df0
Not all Python modules have a __path__.
2013-12-22 11:39:18 +01:00
4582993302
Populated models only when necessary in get_app_config[s].
...
Took this opportunity to change get_app[s] to only consider applications
containing a model module as that seems slightly more backwards compatible.
Since callers that care about models pass only_with_models_module=True,
this has very few consequences. Only AppCommand needed a change.
2013-12-22 11:39:18 +01:00
f25fa9d859
Deprecated load_app().
...
Adjusted several tests that used it to add apps to the app cache and
then attempted to remove them by manipulating attributes directly.
Also renamed invalid_models to invalid_models_tests to avoid clashing
application labels between the outer and the inner invalid_models
applications.
2013-12-22 11:39:17 +01:00
439b364e1e
Added an _-prefix to pending lookups because it's transient.
2013-12-22 11:39:17 +01:00
86804ab063
Terminated AppCache._populate() with extreme prejudice.
...
It was called _populate() before I renamed it to populate(). Since it
has been superseded by populate_models() there's no reason to keep it.
Removed the can_postpone argument of load_app() as it was only used by
populate(). It's a private API and there's no replacement. Simplified
load_app() accordingly. Then new version behaves exactly like the old
one even though it's much shorter.
2013-12-22 11:39:17 +01:00
2b56d69102
Implemented two-stage app-cache population.
...
First stage imports app modules. It doesn't catch import errors. This
matches the previous behavior and keeps the code simple.
Second stage import models modules. It catches import errors and retries
them after walking through the entire list once. This matches the
previous behavior and seems useful.
populate_models() is intended to be equivalent to populate(). It isn't
wired yet. That is coming in the next commit.
2013-12-22 11:39:17 +01:00
9b3389b726
Removed the app_config.installed flag.
...
Since applications that aren't installed no longer have an application
configuration, it is now always True in practice.
Provided an abstraction to temporarily add or remove applications as
several tests messed with app_config.installed to achieve this effect.
For now this API is _-prefixed because it looks dangerous.
2013-12-22 11:39:17 +01:00
972babc3b4
Removed the only_installed argument of get_app_config[s].
...
It wasn't used anywhere and couldn't be implemented any more since
non-installed apps no longer have a configuration.
2013-12-22 11:39:17 +01:00
742ed9878e
Refactored registration of models.
...
Got rid of AppConfig._stub. As a side effect, app_cache.app_configs now
only contains entries for applications that are in INSTALLED_APPS, which
is a good thing and will allow dramatic simplifications (which I will
perform in the next commit). That required adjusting all methods that
iterate on app_configs without checking the "installed" flag, hence the
large changes in get_model[s].
Introduced AppCache.all_models to store models:
- while the app cache is being populated and a suitable app config
object to register models isn't available yet;
- for applications that aren't in INSTALLED_APPS since they don't have
an app config any longer.
Replaced get_model(seed_cache=False) by registered_model() which can be
kept simple and safe to call at any time, and removed the seed_cache
argument to get_model[s]. There's no replacement for that private API.
Allowed non-master app caches to go through populate() as it is now
safe to do so. They were introduced in 1.7 so backwards compatibility
isn't a concern as long as the migrations framework keeps working.
2013-12-22 11:39:17 +01:00
73c9e65b75
Added a context manager to hold the import lock.
2013-12-22 11:39:17 +01:00
9bfdad5472
Style cleanup forgotten in second previous commit.
2013-12-17 22:24:25 +01:00
0242c56fd8
Deborgified the app cache.
...
Improved Andrew's hack to create temporary app caches to handle
migrations. Now the main app cache has a "master" flag set to True
(which is a non-default keyword argument, thus unlikely to be used by
mistake). Other app cache instances have "master" set to False.
The only sanctioned way to access the app cache is by importing
django.core.apps.app_cache.
If you were instanciating an app cache and relying on the Borg pattern,
you'll have to refactor your code.
2013-12-17 21:53:18 +01:00
4a56a93cc4
Moved the new app cache inside core.
2013-12-17 10:17:46 +01:00
5ba743e262
Made it possible to create apps without a models module.
...
This commit reverts f44c4a5d0f39bbd165
2013-12-17 10:17:45 +01:00
69039becde
Deprecated get_app().
2013-12-17 10:17:45 +01:00
2732edc5f2
Deprecated get_apps().
2013-12-17 10:17:45 +01:00
d44de9b933
Removed the _-prefix for populate().
...
Several parts of Django call get_apps() with a comment along this lines
of "this has the side effect of calling _populate()". I fail to see how
this is better than just calling populate()!
2013-12-17 10:17:45 +01:00
259cd3cd41
Deprecated get_app_package, get_app_path and get_app_paths.
2013-12-17 10:17:45 +01:00
2c9e84af4a
Removed unused attribute app_errors of the app cache.
...
get_app_errors() always returned an empty dictionary; this behavior is
preserved in django.db.models.loading until that module is deprecated.
2013-12-17 10:17:44 +01:00
8662654d6d
Removed module-level functions for the app cache.
...
Since the original ones in django.db.models.loading were kept only for
backwards compatibility, there's no need to recreate them. However, many
internals of Django still relied on them.
They were also imported in django.db.models. They never appear in the
documentation, except a quick mention of get_models and get_app in the
1.2 release notes to document an edge case in GIS. I don't think that
makes them a public API.
This commit doesn't change the overall amount of global state but
clarifies that it's tied to the app_cache object instead of hiding it
behind half a dozen functions.
2013-12-17 10:17:44 +01:00
860c2c8bc5
Moved django.db.models.loading to django.apps.cache.
...
This commit doesn't contain any code changes; it's purely a refactoring.
2013-12-17 10:17:43 +01:00
6685713869
Fixed E127 pep8 warnings.
2013-12-14 11:59:15 -05:00
a2814846ca
Fixed E124 pep8 warnings.
2013-12-10 15:12:48 -05:00
2e3c7d8820
Trigger AttributeError in ValidationError.message_dict when error_dict is missing.
...
The goal of this change is twofold; firstly, matching the behavior of Django 1.6
and secondly, an AttributeError is more informative than an obscure ValueError
about mismatching sequence lengths.
Refs #20867 .
2013-12-07 23:01:28 +07:00
a8f4553aae
Fixed #21555 -- Made ValidationError pickable.
...
Thanks trac username zanuxzan for the report and original patch.
2013-12-07 18:58:37 +07:00
41ebc4838d
Fixed #21551 -- Reenabled loading fixtures from subdirectory
...
This was a regression in Django 1.6 that was only partially
restored in 839940f27f
2013-12-07 10:47:34 +01:00
4ca39684ee
Fix poor variable name (flake8 warning)
2013-12-05 14:11:46 +00:00
3b8e46cbc7
Migration VCS conflict detection and --merge for makemigrations
2013-12-04 16:01:49 +00:00
ab587fa51a
Add --dry-run option to makemigrations
2013-12-04 13:55:20 +00:00
1d20e6df95
Migrate prompts if you need makemigrations, runserver prompts for migrate
2013-12-04 13:34:01 +00:00
12615dab78
Fixed #13476 -- Added support for color in console output under Windows.
...
Detect and use the services of the ANSICON third-party tool if it's
available.
2013-12-02 23:18:04 -03:00
2080bce695
Fixed #21358 -- Allowed runserver on non-English locales
...
Thanks svartalf for the report.
2013-11-30 19:17:36 +01:00
6310d658b7
Closed file after reading pot file
...
Faulty line was introduced in 50a8ab7cd1
2013-11-30 11:31:17 +01:00
50a8ab7cd1
Enabled makemessages to support several translation directories
...
Thanks Rémy Hubscher, Ramiro Morales, Unai Zalakain and
Tim Graham for the reviews.
Also fixes #16084 .
2013-11-30 11:00:23 +01:00
f563c339ca
Fixed #20867 -- Added the Form.add_error() method.
...
Refs #20199 #16986 .
Thanks @akaariai, @bmispelon, @mjtamlyn, @timgraham for the reviews.
2013-11-30 01:00:53 +07:00
7e2d61a972
Fixed #21380 -- Added a way to set different permission for static directories.
...
Previously when collecting static files, the directories would receive permissions
from the global umask. Now the default permission comes from FILE_UPLOAD_DIRECTORY_PERMISSIONS
and there's an option to specify the permissions by subclassing any of the
static files storage classes and setting the directory_permissions_mode parameter.
2013-11-29 08:01:30 -05:00
83ab04c6d6
flake8 fixes
2013-11-24 21:07:21 -06:00
eb38257e51
Fixed #21391 -- Allow model signals to lazily reference their senders.
2013-11-24 17:51:22 -05:00
d47f794f8f
Properly closed cache connections at the end of the request.
...
This only affects the new cache api and not the deprecated get_cache.
Refs #21012
2013-11-24 16:23:28 +01:00
cf7ddc5765
Follow up to e112654fc8
...
Actually comitted the code now :þ
2013-11-23 18:55:28 +01:00
0ec712dd11
A handful of flake8 fixes
2013-11-23 08:26:11 -08:00
62b393c5ae
Fixed #21488 -- Multiple locales treatment in i18n commands.
...
Removed multiple locales separated by commas variation (that wasn't
working as documented) in favor of simply allowing use of the
``--locale``/``-l`` options more than once for ``makemessages`` and
``compilemessages``.
Thanks Romain Beylerian for the report and Claude, Simon for their help.
8750296918
2013-11-23 11:53:47 -03:00
ffc37e2343
Fixed #21012 -- New API to access cache backends.
...
Thanks Curtis Malony and Florian Apolloner.
Squashed commit of the following:
commit 3380495e93905a74f52b35e289fe928e274f747aee7eb0f73eFixed #21012 -- Thread-local caches, like databases.
2013-11-23 15:06:59 +01:00
4cfe6ba6a3
Use `classmethod` as a decorator.
2013-11-19 23:08:21 -05:00
97ac22ebfc
Fixed #21457 -- Allowed fixture file name to contain dots
...
Thanks Keryn Knight for the report.
2013-11-18 20:32:13 +01:00
115fd140ab
Configure settings sooner in makemessages
...
As get_text_list is using translations, setup settings before
calling it.
2013-11-15 15:30:22 +01:00
dffcc5e979
Fixed #20990 -- Ensured unicode paths in compilemessages
...
Thanks Gregoire Astruc for the report and furins for the review.
2013-11-11 11:51:38 +01:00
9b7455e918
Fixed #21351 -- Replaced memoize with Python's lru_cache.
...
Replaced the custom, untested memoize with a similar decorator from Python's
3.2 stdlib. Although some minor performance degradation (see ticket), it is
expected that in the long run lru_cache will outperform memoize once it is
implemented in C.
Thanks to EvilDMP for the report and Baptiste Mispelon for the idea of
replacing memoize with lru_cache.
2013-11-11 08:53:09 +01:00
e7383f16b4
Fixed #14800 -- Suppressed WSGIRequestHandler message filtering
...
Filtering out static file requests in runserver has been judged
arbitrary and can hide some debugging-related activity.
Thanks Roy Smith for the report and Aymeric Augustin for the
review.
2013-11-09 16:23:14 +01:00
e6dd70b4db
Fixed #21383 -- Added request details in SuspiciousOperation messages
2013-11-09 12:11:58 +01:00
536c447820
Fixed a couple flake8 warnings.
2013-11-07 20:10:25 -05:00
7be638390e
Fixed #20536 -- rewrite of the file based cache backend
...
* Safer for use in multiprocess environments
* Better random culling
* Cache files use less disk space
* Safer delete behavior
Also fixed #15806 , fixed #15825 .
2013-11-07 16:12:15 +02:00
c7bf4c27a0
Allow squashing of squashed migrations
2013-11-06 15:27:08 +00:00
c347f78cc1
Fixed all E226 violations
2013-11-03 10:08:55 -08:00
cbc7cbbc5b
Fixed flake8 E251 violations
2013-11-03 03:22:11 -06:00
3bc0d46a84
Fixed all E261 warnings
2013-11-02 18:20:39 -04:00
7548aa8ffd
More attacking E302 violators
2013-11-02 13:12:09 -07:00
65c4ac3b24
Merge pull request #1849 from brabadu/master
...
Fixed flake8 E241
2013-11-02 12:57:58 -07:00
4ad9f4d4ea
Replaced a hardcoded "2" with the right named constant
2013-11-02 12:55:36 -07:00
e737c009b8
Fixed flake8 E241
2013-11-02 21:45:40 +02:00
36ded01527
Fixed #21302 -- Fixed unused imports and import *.
2013-11-02 15:24:56 -04:00
9f76ea1eaa
Fixed #21375 -- related_name='+' clashed with other '+' names
2013-11-02 21:18:35 +02:00
e9cb333bc3
Auto-apply initial migrations if their tables exist already.
2013-10-30 15:17:49 +00:00
b35ff0d920
Fixed all the E203 violations
2013-10-26 18:27:42 -07:00
f2d8027c9a
Fixed up some more flake8 violations (this particular violation still has many occurrences in the tests/ dir so it can't be removed from setup.cfg yet)
2013-10-26 10:50:40 -07:00
3afde36d03
Undelete the login() call inadvertantly removed in 4e0a2fe59c
...
Refs #21271 .
2013-10-25 11:23:19 +02:00
4e0a2fe59c
Fixed #21271 -- Added timeout parameter to SMTP EmailBackend.
...
Thanks Tobias McNulty and Tim Graham for discussions and code review.
Thanks Andre Cruz the suggestion and initial patch.
2013-10-24 20:38:00 -04:00
9eecb91695
Fixed #21219 -- Added a way to set different permission for static files.
...
Previously, when collecting static files, the files would receive permission
from FILE_UPLOAD_PERMISSIONS. Now, there's an option to give different
permission from uploaded files permission by subclassing any of the static
files storage classes and setting the file_permissions_mode parameter.
Thanks dblack at atlassian.com for the suggestion.
2013-10-24 17:40:01 -04:00
9bf5610890
Start attacking E231 violations
2013-10-24 10:30:03 -07:00
4cfbde71a3
Fixed #12027 -- Fixed EmailValidator to reject a trailing dot.
...
Thanks Klas H for the report and claudep for the patch.
2013-10-23 12:22:14 -04:00
c3aa2948c6
Fixed #21298 -- Fixed E301 pep8 warnings
2013-10-23 13:45:03 +01:00
ae48d77ef8
Fixed E225 pep8 warnings.
2013-10-23 06:09:29 -04:00
1597503a01
Fixed E221 pep8 warnings.
2013-10-22 09:51:39 -04:00
b5f52647fe
Decode from UTF-8 explicitly when reading a text file in makemessages.
...
This shows itself with Python 3 under Windows where UTF-8 usually isn't
the default file I/O encoding and caused one failure and three errors
in our test suite under that platform setup.
2013-10-22 06:09:21 -03:00
a098bee1b9
Fixed #19724 -- Output note when showing only core management commands
...
When listing available management commands, only core commands are
listed if settings have any error. This commit adds a note in this
case so errors are not totally silently skipped.
Thanks Peter Davis for the report.
2013-10-21 21:26:48 +02:00
e565e1332d
Fixed #21275 -- Fixed a serializer error when generating migrations for contrib.auth.
...
The migration serializer now looks for a deconstruct method on any object.
2013-10-21 14:54:52 -04:00
b289fcf1bf
Fixed #21288 -- Fixed E126 pep8 warnings
2013-10-21 08:31:30 -04:00
a800036981
Fixed #21287 -- Fixed E123 pep8 warnings
2013-10-18 10:07:39 +01:00
bab9123daa
Fixed #21268 -- Fixed E303 pep8 warnings
2013-10-18 01:46:24 +01:00
65d1d65d52
Fixed #21267 -- Fixed E502 pep8 warnings
2013-10-18 01:28:32 +01:00
dfb4cb9970
Fixed #21285 -- Fixed E121,E122 pep8 warnings
2013-10-17 20:20:11 -04:00
3514bcb251
Fixed #21284 -- Prevented KeyError swallowing in fetch_command
...
Thanks wildfire for the report.
2013-10-17 18:57:44 +02:00
2fb5a51fa3
Fixed #18659 -- Deprecated request.REQUEST and MergeDict
...
Thanks Aymeric Augustin for the suggestion.
2013-10-17 09:42:28 -04:00
a921f06345
Fixed #21280 -- Don't generate empty migration files
2013-10-17 08:21:17 -04:00
eb214452c3
Fixed #21270 -- Fixed E701 pep8 warnings
2013-10-17 12:12:40 +01:00
650b6fd90e
Add get_migratable_models util method to ConnectionRouter
2013-10-16 18:02:49 +02:00
2992f42861
Fixed #19657 -- Made sql commands honor allow_migrate
...
Thanks Manel Clos for the report and the initial patch, and
Marc Tamlyn and Tim Graham for the review.
2013-10-16 18:02:32 +02:00
763ac8b642
First pass on squashmigrations command; files are right, execution not.
2013-10-16 12:00:07 +01:00
c7634cd7fe
Fixed #7603 -- Added a 'scheme' property to the HttpRequest object
...
`HttpRequest.scheme` is `https` if `settings.SECURE_PROXY_SSL_HEADER` is
appropriately set and falls back to `HttpRequest._get_scheme()` (a hook
for subclasses to implement) otherwise.
`WSGIRequest._get_scheme()` makes use of the `wsgi.url_scheme` WSGI
environ variable to determine the request scheme.
`HttpRequest.is_secure()` simply checks if `HttpRequest.scheme` is
`https`.
This provides a way to check the current scheme in templates, for example.
It also allows us to deal with other schemes.
Thanks nslater for the suggestion.
2013-10-15 09:04:12 -04:00
83b9bfea44
Fixed #21266 -- Fixed E201,E202 pep8 warnings.
2013-10-14 18:12:00 -04:00
42a67ec1cd
Fixed #21269 -- Don't crash when CommandError contains non-ascii
...
Thanks kontakt@eikefoken.de for the report.
2013-10-14 21:21:07 +02:00
1e8eadc94e
Fixed #15888 -- Made tablename argument of createcachetable optional
...
Thanks Aymeric Augustin for the report and the documentation and
Tim Graham for the review.
2013-10-14 13:24:40 +02:00
e527c0b6d8
Fixed #13252 -- Added ability to serialize with natural primary keys.
...
Added ``--natural-foreign`` and ``--natural-primary`` options and
deprecated the ``--natural`` option to the ``dumpdata`` management
command.
Added ``use_natural_foreign_keys`` and ``use_natural_primary_keys``
arguments and deprecated the ``use_natural_keys`` argument to
``django.core.serializers.Serializer.serialize()``.
Thanks SmileyChris for the suggestion.
2013-10-11 12:52:57 -04:00
945e033a69
Fixed #8918 -- Made FileField.upload_to optional.
...
Thanks leahculver for the suggestion and dc and vajrasky for work
on the patch.
2013-10-11 08:07:25 -04:00
b67ab75e82
Fixed assorted flake8 errors.
2013-10-11 07:25:14 -04:00
1dae4ac177
Whitespace cleanup.
...
* Removed trailing whitespace.
* Added newline to EOF if missing.
* Removed blank lines at EOF.
* Removed some stray tabs.
2013-10-10 16:49:20 -04:00
cec11a3336
Used "is" for comparisons with None.
2013-10-10 09:35:56 -04:00
8ff4303946
Refs #21197 -- Clarified upgrade check message.
...
Thanks to Carl and Shai for the discussion.
2013-10-08 10:00:39 +08:00
20472aa827
Fixed #21189 : Cleaned up usage of bare except clauses.
...
Thanks to berkerpeksag for the report and to claudep
for the review.
2013-10-05 11:50:03 +02:00
4b715fc05a
Fixed #21209 -- .po file path comments on Windows.
...
Literals from source files with Django template language syntax don't
have a '.py' suffix anymore.
Also, the '.\' prefix is preserved to respect GNU gettext behavior on
that platform.
Refs #16903 .
2013-10-01 20:37:43 -03:00
bf757a2f4d
Fixed #21147 -- Avoided time.time precision issue with cache backends.
...
The precision of time.time() is OS specific and it is possible for the
resolution to be low enough to allow reading a cache key previously set
with a timeout of 0.
2013-10-01 13:42:59 -04:00
d5606b5763
Fixed #21146 - DatabaseCache converts expires to python value
...
DatabaseCache uses raw cursors to bypass the ORM. This prevents it from
being used by database backends that require special handling of datetime
values.
There is no easy way to test this, so no tests added.
2013-09-26 13:11:43 +03:00
41167645b1
Fixed #14028 - Added validation for clashing db_columns.
...
Thanks akaariai for the suggestion.
2013-09-23 11:51:58 -04:00
2ca00faa91
Fixed "Address already in use" from liveserver.
...
Our WSGIServer rewrapped the socket errors from server_bind into
WSGIServerExceptions, which is used later on to provide nicer
error messages in runserver and used by the liveserver to see if
the port is already in use. But wrapping server_bind isn't enough since
it only binds to the socket, socket.listen (which is called from
server_activate) could also raise "Address already in use".
Instead of overriding server_activate too I chose to just catch socket
errors, which seems to make more sense anyways and should be more robust
against changes in wsgiref.
2013-09-22 22:02:59 +02:00
59a34c43a8
Fixed #18744 -- Updated docstring to highlight limitations of NamedTemporaryFile
...
- Noted that this does not allow for reading and writing the same open
file in different processes under Windows.
- Noted that the keyword arguments to NamedTemporaryFile no longer
match the Python version.
2013-09-19 10:12:03 -04:00
4e9f800742
Fixed #21125 -- Removed support for cache URI syntax
2013-09-19 10:01:39 -04:00
a772ea8117
Fixed #21115 -- Fixed NameError in migrate --list command
2013-09-17 12:53:59 -04:00
c89d80e2cc
Fixed #21097 - Added DatabaseFeature.can_introspect_autofield
2013-09-14 09:48:59 +03:00
e61cc87129
Fixed #21090 -- Allowed backends to provide dotted field path to inspectdb.
2013-09-11 13:35:26 -04:00
b2b763448f
Fixed #20841 -- Added messages to NotImplementedErrors
...
Thanks joseph at vertstudios.com for the suggestion.
2013-09-10 11:09:59 -04:00
30fc49a7ca
Fixed #21057 -- Prevented FileSystemStorage from leaving temporary files.
2013-09-10 08:33:53 -04:00
7008ed61c5
Fixed #21033 -- Fixed uploaded filenames not always being truncated to 255 characters
2013-09-10 01:55:16 +02:00
8aaca651cf
Fixed #20557 -- Properly decoded non-ASCII cookies on Python 3.
...
Thanks mitsuhiko for the report.
Non-ASCII values are supported. Non-ASCII keys still aren't, because the
current parser mangles them. That's another bug.
2013-09-07 10:25:43 -05:00
ae7f9afaf6
Minor cleanup in the WSGI handler.
2013-09-07 10:25:16 -05:00
4e88d106dc
Refactored the unmangling of the WSGI environ.
2013-09-07 10:03:50 -05:00
636860fbfb
Moved two WSGI-specific functions to the WSGI handler.
...
They were defined in base when the mod_python handler used them. See bfcecbff
2013-09-07 10:03:49 -05:00
2530735d2d
Fixed a number of flake8 errors -- particularly around unused imports and local variables
2013-09-06 21:56:40 -07:00
926bc421d9
Merge pull request #1566 from adamsc64/ticket_11857
...
Fixed #11857 -- Added missing 'closed' property on TemporaryFile class.
2013-09-06 17:38:37 -07:00
498014ccd5
Fixed Python 3 syntax error introduced in [ c72392da]
2013-09-06 20:07:57 -04:00
4f5faa1916
Merge pull request #1582 from rca/12756-missing-yaml-module-serializer-error-message
...
Fixed #12756 : Improved error message when yaml module is missing.
2013-09-06 16:05:02 -07:00
01a5359477
Cleanup commit after peer review.
2013-09-06 22:45:31 +00:00
0b7cf56e28
Add -l alias for migrate --list
2013-09-06 17:00:38 -05:00
076cf131ec
Moved get_serializer() call in dumpdata command.
...
Moved the get_serializer() call within the condition that checks public
serializers. This will allow exceptions other than
SerializerDoesNotExist to be raised in order to provide the caller with
useful information, e.g when pyyaml is not installed.
2013-09-06 20:33:23 +00:00
c72392dab4
Added yaml directly into BUILTIN_SERIALIZERS.
...
The serializer definitely exists, but the dependent yaml module may not
be installed. The register_serializer() function will catch exceptions
and will stub in a fake serializer object that will raise the exception
when the serializer is used.
2013-09-06 20:33:23 +00:00
efd1e6096e
Adding 'sqlmigrate' command and quote_parameter to support it.
2013-09-06 15:28:12 -05:00
df462cf760
Fixed #21043 -- Made resolve() handle reverse_lazy objects.
...
Thanks Keryn Knight for the report.
2013-09-06 15:46:43 -04:00
b2f5ac1656
Fixed #11857 -- Added missing 'closed' property on TemporaryFile class.
...
- TemporaryFile now minimally mocks the API of the Python standard
library class tempfile.NamedTemporaryFile to avoid AttributeError
exceptions.
- The symbol django.core.files.NamedTemporaryFile is actually assigned
as a different class on different operating systems.
- The bug only occurred if Django is running on Windows, hence why it
was hard to diagnose.
2013-09-06 14:32:46 -04:00
9f6e6009a4
Add --list option to migrate command
2013-09-06 11:06:19 -05:00
bd8e1a354c
Fixed #20977 -- Fixed writing migrations to disk on Python 3
2013-09-06 09:51:58 -04:00
6a6428a36f
Took advantage of django.utils.six.moves.urllib.*.
2013-09-05 14:39:23 -05:00
5649c0af9d
Fixed "indentation is not a multiple of four" pep8 issues.
2013-09-03 14:22:21 -04:00
8f7f8bf688
Fixed #21026 -- Corrected help for manage.py test command.
2013-09-03 09:50:34 -06:00
Attila Tovt
Claude Paroz
Tim Graham
Dmitry Dygalo
Jaap Roes
Baptiste Mispelon
Ville Skyttä
Dheerendra Rathor
Jon Dufresne
Andrey Kuzmin
Yoong Kang Lim
Andrew Artajos
Aymeric Augustin
Alasdair Nicol
Matt Deacalion Stevens
Markus Holtermann
Iulia Chiriac
Tom Christie
Matthew Crowson
Daniel Hahler
Dražen Odobašić
Raphael Michel
Maxime Lorant
Sergey Kolosov
Jonas Haag
mlavin
Flavio Curella
Konrad Świat
Edward Henderson
rroskam
Thomas Stephenson
Cesar Canassa
Daniel Roseman
Andrei Kulakov
Shai Berger
David Wolever
Alexey Sveshnikov
Karol Duleba
Sylvain Fankhauser
Rigel Di Scala
Grégoire ROCHER
Lukas Hetzenecker
Rolo
Marten Kenbeek
ana-balica
Mounir Messelmeni
Moritz Sichert
Carson Gee
Russell Keith-Magee
mick
Rivo Laks
Sergei Maertens
Matthew Somerville
Peter Inglesby
Piotr Jakimiak
Matt Robenolt
Luis Del Giudice
daphshez
Harry
David Danier
Anoop Thomas Mathew
Yitzhak Clark
Joe Borg
Adam Chainz
Richard Eames
steve
Matt Hooks
Simon Charette
Bertrand Bordage
Raúl Cumplido
Anssi Kääriäinen
Pakal
Loek van Gent
Bas Peschier
John Giannelos
Berker Peksag
medmunds
Bas Peschier
Aymeric Augustin
Loic Bistuer
Alex Vidal
Andriy Sokolovskiy
darkryder
R3v1L
Carl Meyer
Pavel Shpilev
Daniel Pyrathon
Danilo Bargen
Collin Anderson
Andreas Pelme
Andrey Maslov
Ramiro Morales
Andriy Sokolovskiy
Tim Heap
Martin Blech
Sergey Fedoseev
Brad Walker
Anton Baklanov
Tillmann Karras
Ilja Maas
Michael Manfre
averybigant
Veres Lajos
Tony Zhu
Anubhav Joshi
Florian Apolloner
Thomas Chaumeny
Jaap Roes
Brandon Taylor
Thomas Chaumeny
Marco Buttu
José Padilla
Andi Albrecht
Raffaele Salmaso
Bas Peschier
Joshua "jag" Ginsberg
areski
Gabriel Muñumel
Ramiro Morales
Ramiro Morales
Justin Hamade
Christoph Heer
Andrew Godwin
Moayad Mardini
Damien Nozay
Huu Nguyen
Ian Foote
Maxime Turcotte
Vincent-Vega
Alex Gaynor
Víðir Valberg Guðmundsson
Unai Zalakain
Thomas Grainger
Esau Rodriguez
Erik Romijn
Rainer Koirikivi
Malcolm Box
David Szotten
Bruno Ribeiro da Silva
Ana Krivokapic
Kevin Christopher Henry
Preston Timmons
julien 'pouete' Godin
Daniel Neuhäuser
Zbigniew Siciarz
Patrick Michaud
Hans Lawrenz
Dejan Noveski
smallcode
Athena
Rodolfo Carvalho
Dmitro
MattBlack85
Grzegorz Nosek
Aaron France
Antoine Catton
Eli Bendersky
Si Feng
Curtis
Wojciech Banaś
José Moreira
JustinTArthur
Marc Tamlyn
Loic Bistuer
Vajrasky Kok
xuxiang
Bouke Haarsma
Milton Mazzarri
coagulant
Boryslav Larin
Anssi Kääriäinen
SusanTan
Alasdair Nicol
Javed Khan
Larry O'Neill
Tai Lee
Helen ST
Gregor MacGregor
John Hensley
homm
Roberto Aguilar
Dan Johnson
Christopher Adams