e429c5186c
Fixed #26018 -- Prevented unecessary get_form() call in FormMixin.get_context_data().
...
Changed "dict.setdefault" to "if x in dict" pattern so that get_form() would not
be called unnecessarily, specifically in the case where FormMixin.form_invalid()
calls get_context_data() with the current form.
2015-12-30 17:29:39 -05:00
e171a83b15
Fixed #25548 -- Prevented FormView.form_invalid() from discarding its form argument.
2015-11-11 13:28:34 -05:00
491de4f07c
Refs #23656 -- Required FormMixin.get_form() form_class parameter to be optional.
...
Per deprecation timeline.
2015-09-23 19:31:10 -04:00
6eed9ae747
Refs #24133 -- Removed legacy formatting syntax in success_url placeholders.
...
Per deprecation timeline.
2015-09-23 19:31:10 -04:00
aaacaeb096
Renamed RemovedInDjangoXYWarnings for new roadmap.
...
Forwardport of ae1d663b79
2015-06-24 16:08:20 -04:00
8a1824d465
Fixed #24643 -- Added get_context_data() method to FormMixin
2015-04-24 20:17:29 -04:00
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
511be35779
Fixed #24220 - Allowed lazy objects for success_url
2015-01-26 17:58:55 +01:00
ea0ea7859a
Fixed #24221 - Used precompiled regexp for percent-placeholder matching.
2015-01-26 10:48:31 -05:00
f48e2258a9
Fixed #24133 -- Replaced formatting syntax in success_url placeholders
...
Thanks Laurent Payot for the report, and Markus Holtermann, Tim Graham
for the reviews.
2015-01-12 22:51:22 +01:00
343162410f
Fixed #21753 -- Raised exception when both `form_class` and `fields` are specified.
2014-11-21 14:23:17 -05:00
f2ddc439b1
Fixed #23656 -- Made FormMixin.get_form's form_class argument optional.
...
Thanks Tim Graham for the review.
2014-10-30 19:10:52 -04:00
ee4edb1eda
Made ModelForms raise ImproperlyConfigured if the list of fields is not specified.
...
Also applies to modelform(set)_factory and generic model views.
refs #19733 .
2014-03-22 07:56:48 -04:00
210d0489c5
Fixed #21188 -- Introduced subclasses for to-be-removed-in-django-XX warnings
...
Thanks Anssi Kääriäinen for the idea and Simon Charette for the
review.
2014-03-08 09:57:40 +01:00
75a96f06e9
Fixed #21967 : Added check for object in ModelFormMixin.get_form_kwargs.
...
Thanks lagovas.lagovas at gmail.com for the report.
2014-02-09 06:30:03 -05:00
acd7b34aaf
Advanced deprecation warnings for Django 1.7.
2013-06-29 18:49:37 +02:00
299983616f
Fixed #20644 -- Add ModelFormMixin.fields to the CBV flattened index
...
Thanks to Tim Graham for the report and review.
2013-06-24 11:59:08 +02:00
ef37b23050
Fixed #18872 -- Added prefix to FormMixin
...
Thanks @ibustama for the initial patch and dragonsnaker for opening the
report.
2013-06-22 12:12:43 +01:00
52f99b78bc
Fixed #20585 : normalize signature of DeletionMixin.post.
2013-06-11 12:40:06 +02:00
3eba8c7f7f
Fixed #20234 and #20236 -- SingleObjectMixin fixes
...
Added object on SingleObjectMixin returned context,
some code clanup.
2013-05-18 21:13:27 +02:00
f026a519ae
Fixed #19733 - deprecated ModelForms without 'fields' or 'exclude', and added '__all__' shortcut
...
This also updates all dependent functionality, including modelform_factory
and modelformset_factory, and the generic views `ModelFormMixin`,
`CreateView` and `UpdateView` which gain a new `fields` attribute.
2013-05-09 16:44:36 +01:00
a10f390804
Fixed #19044 -- Made `DeletionMixin` interpolate its `success_url`.
...
Thanks to nxvl and slurms for the initial patch, ptone for the review
and timo for the documentation tweaks.
2013-02-11 02:39:14 -05:00
795ac7deda
Fixed #19378 -- Ensured get_success_url returns a non-lazy URL
2012-12-04 13:22:42 +01:00
c4c7fbcc0d
Fixed #18451 -- Vastly improved class based view documentation.
...
Many thanks to Daniel Greenfeld, James Aylett, Marc Tamlyn, Simon Williams, Danilo Bargen and Luke Plant for their work on this.
2012-06-11 10:40:23 +02:00
a0d34348dd
fix typo: instanciating -> instantiating
2012-04-28 14:18:16 -03:00
8663bc1103
Fixed #16074 -- Added ContextMixin to class-based generic views to handle get_context_data. Thanks emyller, Luke Plant, Preston Holmes for working on the ticket and patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17875 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-04-06 21:24:33 +00:00
c7cc4cfb9e
Fixed #16138 -- Made FormMixin get_initial return a copy of the 'initial' class variable. Thanks hanson2010, wilfred@potatolondon.com and agriffis for their work on the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17765 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-03-17 22:31:03 +00:00
299874cbe1
Fixed #15560 -- Cleaned up some redundant post->put redirections in the class-based generic views. Thanks to maney for the report and patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15763 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-06 05:55:12 +00:00
64b042bb3c
Fixed #15247 -- Ensured that if a SingleObject view defines get_object but not get_queryset, the ModelFormMixin doesn't fail. Thanks to Sergey N. Belinsky for the report and test case.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15540 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-02-15 08:12:29 +00:00
461f01b7a6
Fixed #15061 -- Removed a redundant method implementation in the class-based ModelFormMixin, and did some PEP8 cleanup. Thanks to rasca for the report and patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15341 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-27 03:14:20 +00:00
2e909489d7
Add FormMixin.get_form_kwargs method to abstract some common logic in a tidier
...
way. Tidy up (and amend) documentation about FormMixin and ModelFormMixin.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14865 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-10 03:51:30 +00:00
adfd7f8172
Fixed #14797 -- Corrected the handling of get_form_class() when a custom queryset has been defined, but a model hasn't. Thanks to Gabriel Grant for the report and patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14809 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-04 11:20:52 +00:00
324658ef26
Fixed #14803 -- Corrected an inconsistency in redirection handling between old-style generic views and class-based views. Thanks to gg for the report and patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14808 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-04 11:20:30 +00:00
4c9741cba2
Fixed #14558 -- Modified the way PUT and DELETE HTTP methods are handled so that overridden methods will get used correctly. Thanks to pyrou for the report and patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14374 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-28 02:59:04 +00:00
8bc2f2a0b5
Fixed #14568 -- Use keyword rather than positional arguments for form construction. Thanks to mattmcc for the report and patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14371 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-28 02:58:06 +00:00
a014ee0288
Modified the implementation of get_object() to be consistent with the approach used elsewhere in the API. Also added documentation for get_object() which seems to have been accidentally omitted.
...
This is a BACKWARDS-INCOMPATIBLE CHANGE for anyone depending on the API for get_object() that was introduced (but not documented) in r14254.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14292 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-20 00:21:47 +00:00
1a270bd103
Fixed #14495 -- DeletionMixin and FormMixin don't have an object to work with so they cannot redirect to get_absolute_url and shouldn't claim they do.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14284 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-19 07:22:38 +00:00
0fcb094557
Fixed #6735 -- Added class-based views.
...
This patch is the result of the work of many people, over many years.
To try and thank individuals would inevitably lead to many people
being left out or forgotten -- so rather than try to give a list that
will inevitably be incomplete, I'd like to thank *everybody* who
contributed in any way, big or small, with coding, testing, feedback
and/or documentation over the multi-year process of getting this into
trunk.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14254 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 13:34:47 +00:00
Chris Cogdon
Alex Morozov
Tim Graham
Andrei Kulakov
Tomáš Ehrlich
Claude Paroz
Berker Peksag
Simon Charette
Ryan Kaskel
Aymeric Augustin
Baptiste Mispelon
Gilberto Gonçalves
Baptiste Darthenay
Karol Sikora
Luke Plant
Jannis Leidel
Tom Terrace
Russell Keith-Magee
Chris Beaven
Honza Král